FindBugs Bug Detector Report
The following document contains the results of FindBugs
FindBugs Version is 3.0.1
Threshold is
Effort is max
Summary
| Classes |
Bugs |
Errors |
Missing Classes |
| 160 |
50 |
0 |
60 |
fr.paris.lutece.plugins.releaser.business.ReleaserUser$Credential
| Bug |
Category |
Details |
Line |
Priority |
| Should fr.paris.lutece.plugins.releaser.business.ReleaserUser$Credential be a _static_ inner class? |
PERFORMANCE |
SIC_INNER_SHOULD_BE_STATIC |
108-137 |
Medium |
fr.paris.lutece.plugins.releaser.business.WorkflowContextHistory
| Bug |
Category |
Details |
Line |
Priority |
| fr.paris.lutece.plugins.releaser.business.WorkflowContextHistory.getDateBegin() may expose internal representation by returning WorkflowContextHistory._dateBegin |
MALICIOUS_CODE |
EI_EXPOSE_REP |
172 |
Medium |
| fr.paris.lutece.plugins.releaser.business.WorkflowContextHistory.getDateEnd() may expose internal representation by returning WorkflowContextHistory._dateEnd |
MALICIOUS_CODE |
EI_EXPOSE_REP |
193 |
Medium |
| fr.paris.lutece.plugins.releaser.business.WorkflowContextHistory.setDateBegin(Timestamp) may expose internal representation by storing an externally mutable object into WorkflowContextHistory._dateBegin |
MALICIOUS_CODE |
EI_EXPOSE_REP2 |
183 |
Medium |
| fr.paris.lutece.plugins.releaser.business.WorkflowContextHistory.setDateEnd(Timestamp) may expose internal representation by storing an externally mutable object into WorkflowContextHistory._dateEnd |
MALICIOUS_CODE |
EI_EXPOSE_REP2 |
204 |
Medium |
fr.paris.lutece.plugins.releaser.service.ClusterService
| Bug |
Category |
Details |
Line |
Priority |
| The method name fr.paris.lutece.plugins.releaser.service.ClusterService.IsAddClusterAuthorized(AdminUser) doesn't start with a lower case letter |
BAD_PRACTICE |
NM_METHOD_NAMING_CONVENTION |
149-154 |
Medium |
| The method name fr.paris.lutece.plugins.releaser.service.ClusterService.IsUserAuthorized(AdminUser, String, String) doesn't start with a lower case letter |
BAD_PRACTICE |
NM_METHOD_NAMING_CONVENTION |
160-167 |
Medium |
fr.paris.lutece.plugins.releaser.service.ComponentService
| Bug |
Category |
Details |
Line |
Priority |
| Incorrect lazy initialization and update of static field fr.paris.lutece.plugins.releaser.service.ComponentService._instance in fr.paris.lutece.plugins.releaser.service.ComponentService.getService() |
MT_CORRECTNESS |
LI_LAZY_INIT_UPDATE_STATIC |
109-111 |
Medium |
| The method name fr.paris.lutece.plugins.releaser.service.ComponentService.IsSearchComponentAuthorized(AdminUser) doesn't start with a lower case letter |
BAD_PRACTICE |
NM_METHOD_NAMING_CONVENTION |
481-486 |
Medium |
fr.paris.lutece.plugins.releaser.service.JiraComponentService
| Bug |
Category |
Details |
Line |
Priority |
| Incorrect lazy initialization and update of static field fr.paris.lutece.plugins.releaser.service.JiraComponentService._instance in fr.paris.lutece.plugins.releaser.service.JiraComponentService.getService() |
MT_CORRECTNESS |
LI_LAZY_INIT_UPDATE_STATIC |
122-124 |
Medium |
| Write to static field fr.paris.lutece.plugins.releaser.service.JiraComponentService.JIRA_USER from instance method fr.paris.lutece.plugins.releaser.service.JiraComponentService.init() |
STYLE |
ST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD |
162 |
Medium |
| Write to static field fr.paris.lutece.plugins.releaser.service.JiraComponentService.JIRA_USER_PWD from instance method fr.paris.lutece.plugins.releaser.service.JiraComponentService.init() |
STYLE |
ST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD |
163 |
Medium |
| Write to static field fr.paris.lutece.plugins.releaser.service.JiraComponentService.URL_JIRA_SERVER from instance method fr.paris.lutece.plugins.releaser.service.JiraComponentService.init() |
STYLE |
ST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD |
161 |
Medium |
| Write to static field fr.paris.lutece.plugins.releaser.service.JiraComponentService._auth from instance method fr.paris.lutece.plugins.releaser.service.JiraComponentService.init() |
STYLE |
ST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD |
166 |
Medium |
| Write to static field fr.paris.lutece.plugins.releaser.service.JiraComponentService._factory from instance method fr.paris.lutece.plugins.releaser.service.JiraComponentService.init() |
STYLE |
ST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD |
165 |
Medium |
fr.paris.lutece.plugins.releaser.service.MavenService
| Bug |
Category |
Details |
Line |
Priority |
| Incorrect lazy initialization and update of static field fr.paris.lutece.plugins.releaser.service.MavenService._instance in fr.paris.lutece.plugins.releaser.service.MavenService.getService() |
MT_CORRECTNESS |
LI_LAZY_INIT_UPDATE_STATIC |
87-89 |
Medium |
| Method fr.paris.lutece.plugins.releaser.service.MavenService.mvnSiteAssembly(String, String, String, SvnUser, CommandResult) seems to be useless |
STYLE |
UC_USELESS_VOID_METHOD |
138 |
High |
fr.paris.lutece.plugins.releaser.service.ReleaseComponentTask
| Bug |
Category |
Details |
Line |
Priority |
| Dead store to state in fr.paris.lutece.plugins.releaser.service.ReleaseComponentTask.run() |
STYLE |
DLS_DEAD_LOCAL_STORE |
110 |
Medium |
fr.paris.lutece.plugins.releaser.service.SiteService
| Bug |
Category |
Details |
Line |
Priority |
| fr.paris.lutece.plugins.releaser.service.SiteService.isProjectComponent(Site, String) invokes inefficient Boolean constructor; use Boolean.valueOf(...) instead |
PERFORMANCE |
DM_BOOLEAN_CTOR |
339 |
Medium |
| The method name fr.paris.lutece.plugins.releaser.service.SiteService.IsSiteAlreadyExist(String, String, String) doesn't start with a lower case letter |
BAD_PRACTICE |
NM_METHOD_NAMING_CONVENTION |
866-870 |
Medium |
| The method name fr.paris.lutece.plugins.releaser.service.SiteService.IsUserAuthorized(AdminUser, String, String) doesn't start with a lower case letter |
BAD_PRACTICE |
NM_METHOD_NAMING_CONVENTION |
854-861 |
Medium |
fr.paris.lutece.plugins.releaser.service.TwitterService
| Bug |
Category |
Details |
Line |
Priority |
| Write to static field fr.paris.lutece.plugins.releaser.service.TwitterService._twitter from instance method fr.paris.lutece.plugins.releaser.service.TwitterService.init() |
STYLE |
ST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD |
165 |
Medium |
fr.paris.lutece.plugins.releaser.service.WorkflowReleaseContextService
| Bug |
Category |
Details |
Line |
Priority |
| Incorrect lazy initialization and update of static field fr.paris.lutece.plugins.releaser.service.WorkflowReleaseContextService._singleton in fr.paris.lutece.plugins.releaser.service.WorkflowReleaseContextService.getService() |
MT_CORRECTNESS |
LI_LAZY_INIT_UPDATE_STATIC |
295-298 |
Medium |
fr.paris.lutece.plugins.releaser.service.svn.SvnResourceService
| Bug |
Category |
Details |
Line |
Priority |
| fr.paris.lutece.plugins.releaser.service.svn.SvnResourceService.rollbackRelease(WorkflowReleaseContext, Locale) invokes inefficient new Long(String) constructor; use Long.valueOf(String) instead |
PERFORMANCE |
DM_NUMBER_CTOR |
355 |
Medium |
| Suspicious comparison of Long references in fr.paris.lutece.plugins.releaser.service.svn.SvnResourceService.rollbackRelease(WorkflowReleaseContext, Locale) |
CORRECTNESS |
RC_REF_COMPARISON |
357 |
High |
fr.paris.lutece.plugins.releaser.util.CommandResult
| Bug |
Category |
Details |
Line |
Priority |
| fr.paris.lutece.plugins.releaser.util.CommandResult.getDateBegin() may expose internal representation by returning CommandResult._dBegin |
MALICIOUS_CODE |
EI_EXPOSE_REP |
239 |
Medium |
| fr.paris.lutece.plugins.releaser.util.CommandResult.getDateEnd() may expose internal representation by returning CommandResult._dEnd |
MALICIOUS_CODE |
EI_EXPOSE_REP |
260 |
Medium |
| fr.paris.lutece.plugins.releaser.util.CommandResult.setDateBegin(Date) may expose internal representation by storing an externally mutable object into CommandResult._dBegin |
MALICIOUS_CODE |
EI_EXPOSE_REP2 |
250 |
Medium |
| fr.paris.lutece.plugins.releaser.util.CommandResult.setDateEnd(Date) may expose internal representation by storing an externally mutable object into CommandResult._dEnd |
MALICIOUS_CODE |
EI_EXPOSE_REP2 |
271 |
Medium |
| fr.paris.lutece.plugins.releaser.util.CommandResult.ERROR_TYPE_INFO isn't final but should be |
MALICIOUS_CODE |
MS_SHOULD_BE_FINAL |
58 |
High |
| fr.paris.lutece.plugins.releaser.util.CommandResult.ERROR_TYPE_STOP isn't final but should be |
MALICIOUS_CODE |
MS_SHOULD_BE_FINAL |
61 |
High |
| fr.paris.lutece.plugins.releaser.util.CommandResult.STATUS_ERROR isn't final but should be |
MALICIOUS_CODE |
MS_SHOULD_BE_FINAL |
52 |
High |
| fr.paris.lutece.plugins.releaser.util.CommandResult.STATUS_OK isn't final but should be |
MALICIOUS_CODE |
MS_SHOULD_BE_FINAL |
55 |
High |
fr.paris.lutece.plugins.releaser.util.PluginUtils
| Bug |
Category |
Details |
Line |
Priority |
| Found reliance on default encoding in fr.paris.lutece.plugins.releaser.util.PluginUtils.updateAppInfoFile(String, String, CommandResult): new java.io.FileReader(String) |
I18N |
DM_DEFAULT_ENCODING |
193 |
High |
| Found reliance on default encoding in fr.paris.lutece.plugins.releaser.util.PluginUtils.updateAppInfoFile(String, String, CommandResult): new java.io.FileWriter(String) |
I18N |
DM_DEFAULT_ENCODING |
247 |
High |
| Found reliance on default encoding in fr.paris.lutece.plugins.releaser.util.PluginUtils.updatePluginXMLVersion(String, String, CommandResult): new java.io.FileWriter(File) |
I18N |
DM_DEFAULT_ENCODING |
308 |
High |
fr.paris.lutece.plugins.releaser.util.github.GitUtils
| Bug |
Category |
Details |
Line |
Priority |
| fr.paris.lutece.plugins.releaser.util.github.GitUtils.getLastLog(Git, int) concatenates strings using + in a loop |
PERFORMANCE |
SBSC_USE_STRINGBUFFER_CONCATENATION |
426 |
Medium |
fr.paris.lutece.plugins.releaser.util.github.ReleaseGITGetRepoClient
| Bug |
Category |
Details |
Line |
Priority |
| Unread field: fr.paris.lutece.plugins.releaser.util.github.ReleaseGITGetRepoClient.bCancelled |
PERFORMANCE |
URF_UNREAD_FIELD |
58 |
Medium |
fr.paris.lutece.plugins.releaser.util.svn.ReleaseSvnCheckoutClient
| Bug |
Category |
Details |
Line |
Priority |
| Unread field: fr.paris.lutece.plugins.releaser.util.svn.ReleaseSvnCheckoutClient.bCancelled |
PERFORMANCE |
URF_UNREAD_FIELD |
82 |
Medium |
fr.paris.lutece.plugins.releaser.util.svn.ReleaseSvnCommitClient
| Bug |
Category |
Details |
Line |
Priority |
| Unread field: fr.paris.lutece.plugins.releaser.util.svn.ReleaseSvnCommitClient.bCancelled |
PERFORMANCE |
URF_UNREAD_FIELD |
79 |
Medium |
fr.paris.lutece.plugins.releaser.util.svn.ReleaseSvnCopyClient
| Bug |
Category |
Details |
Line |
Priority |
| Unread field: fr.paris.lutece.plugins.releaser.util.svn.ReleaseSvnCopyClient.bCancelled |
PERFORMANCE |
URF_UNREAD_FIELD |
79 |
Medium |
fr.paris.lutece.plugins.releaser.util.svn.SvnUtils
| Bug |
Category |
Details |
Line |
Priority |
| Dead store to errorLog in fr.paris.lutece.plugins.releaser.util.svn.SvnUtils.doSvnCheckout(String, String, ReleaseSvnCheckoutClient, CommandResult) |
STYLE |
DLS_DEAD_LOCAL_STORE |
277 |
Medium |
fr.paris.lutece.plugins.releaser.util.version.Version
| Bug |
Category |
Details |
Line |
Priority |
| fr.paris.lutece.plugins.releaser.util.version.Version defines compareTo(Object) and uses Object.equals() |
BAD_PRACTICE |
EQ_COMPARETO_USE_OBJECT_EQUALS |
212-224 |
Medium |
fr.paris.lutece.plugins.releaser.web.ManageComponentReleaseJspBean
| Bug |
Category |
Details |
Line |
Priority |
| Dead store to component in fr.paris.lutece.plugins.releaser.web.ManageComponentReleaseJspBean.doChangeBranch(HttpServletRequest) |
STYLE |
DLS_DEAD_LOCAL_STORE |
284 |
Medium |
| Dead store to component in fr.paris.lutece.plugins.releaser.web.ManageComponentReleaseJspBean.getChangeBranch(HttpServletRequest) |
STYLE |
DLS_DEAD_LOCAL_STORE |
262 |
Medium |
| Dead store to user in fr.paris.lutece.plugins.releaser.web.ManageComponentReleaseJspBean.getManageComponent(HttpServletRequest) |
STYLE |
DLS_DEAD_LOCAL_STORE |
145 |
Medium |
fr.paris.lutece.plugins.releaser.web.ManageSiteReleaseJspBean
| Bug |
Category |
Details |
Line |
Priority |
| Dead store to component in fr.paris.lutece.plugins.releaser.web.ManageSiteReleaseJspBean.doChangeBranch(HttpServletRequest) |
STYLE |
DLS_DEAD_LOCAL_STORE |
662 |
Medium |
| Dead store to component in fr.paris.lutece.plugins.releaser.web.ManageSiteReleaseJspBean.getChangeBranch(HttpServletRequest) |
STYLE |
DLS_DEAD_LOCAL_STORE |
641 |
Medium |
| Null passed for non-null parameter of fr.paris.lutece.plugins.releaser.service.SiteService.releaseSite(Site, Locale, AdminUser, HttpServletRequest) in fr.paris.lutece.plugins.releaser.web.ManageSiteReleaseJspBean.doConfirmReleaseSite(HttpServletRequest) |
CORRECTNESS |
NP_NULL_PARAM_DEREF |
529 |
Medium |
| Suspicious comparison of Boolean references in fr.paris.lutece.plugins.releaser.web.ManageSiteReleaseJspBean.doConfirmReleaseSite(HttpServletRequest) |
BAD_PRACTICE |
RC_REF_COMPARISON_BAD_PRACTICE_BOOLEAN |
521 |
Medium |
