Fork me on GitHub

Résultats PMD

Le document suivant contient les résultats de PMD 6.13.0.

Violations By Priority

Priority 1

fr/paris/lutece/plugins/releaser/business/Cluster.java

Rule Violation Ligne
FieldNamingConventions The field name 'permissions' doesn't match '_[a-z][a-zA-Z0-9]*' 59

fr/paris/lutece/plugins/releaser/business/Component.java

Rule Violation Ligne
FieldNamingConventions The field name 'permissions' doesn't match '_[a-z][a-zA-Z0-9]*' 54
FormalParameterNamingConventions The method parameter name '_strScmDeveloperConnection' doesn't match '[a-z][a-zA-Z0-9]*' 464
FormalParameterNamingConventions The method parameter name '_bUpgrade' doesn't match '[a-z][a-zA-Z0-9]*' 495
FormalParameterNamingConventions The method parameter name '_bDowngrade' doesn't match '[a-z][a-zA-Z0-9]*' 516
FormalParameterNamingConventions The method parameter name '_strLastAvailableSnapshotVersion' doesn't match '[a-z][a-zA-Z0-9]*' 547
FormalParameterNamingConventions The method parameter name '_bErrorLastRelease' doesn't match '[a-z][a-zA-Z0-9]*' 568
FormalParameterNamingConventions The method parameter name '_strName' doesn't match '[a-z][a-zA-Z0-9]*' 589
FormalParameterNamingConventions The method parameter name '_strCloneUrl' doesn't match '[a-z][a-zA-Z0-9]*' 610
FormalParameterNamingConventions The method parameter name '_strTweetMessage' doesn't match '[a-z][a-zA-Z0-9]*' 652
FormalParameterNamingConventions The method parameter name '_strBranchReleaseFrom' doesn't match '[a-z][a-zA-Z0-9]*' 706
FormalParameterNamingConventions The method parameter name '_strBranchReleaseVersion' doesn't match '[a-z][a-zA-Z0-9]*' 716

fr/paris/lutece/plugins/releaser/business/Site.java

Rule Violation Ligne
FieldNamingConventions The field name 'permissions' doesn't match '_[a-z][a-zA-Z0-9]*' 62
FormalParameterNamingConventions The method parameter name '_strTagInfotmation' doesn't match '[a-z][a-zA-Z0-9]*' 493
FormalParameterNamingConventions The method parameter name '_strGroupId' doesn't match '[a-z][a-zA-Z0-9]*' 514
FormalParameterNamingConventions The method parameter name '_bTheme' doesn't match '[a-z][a-zA-Z0-9]*' 535
FormalParameterNamingConventions The method parameter name '_strBranchReleaseFrom' doesn't match '[a-z][a-zA-Z0-9]*' 555

fr/paris/lutece/plugins/releaser/business/WorkflowContextHistory.java

Rule Violation Ligne
FormalParameterNamingConventions The method parameter name '_dateBegin' doesn't match '[a-z][a-zA-Z0-9]*' 181
FormalParameterNamingConventions The method parameter name '_dateEnd' doesn't match '[a-z][a-zA-Z0-9]*' 202
FormalParameterNamingConventions The method parameter name '_strArtifactId' doesn't match '[a-z][a-zA-Z0-9]*' 223

fr/paris/lutece/plugins/releaser/business/WorkflowReleaseContext.java

Rule Violation Ligne
FormalParameterNamingConventions The method parameter name '_nId' doesn't match '[a-z][a-zA-Z0-9]*' 98
FormalParameterNamingConventions The method parameter name '_component' doesn't match '[a-z][a-zA-Z0-9]*' 119
FormalParameterNamingConventions The method parameter name '_commandResult' doesn't match '[a-z][a-zA-Z0-9]*' 140
FormalParameterNamingConventions The method parameter name '_releaserUser' doesn't match '[a-z][a-zA-Z0-9]*' 194
FormalParameterNamingConventions The method parameter name '_strRefBranchRelease' doesn't match '[a-z][a-zA-Z0-9]*' 215
FormalParameterNamingConventions The method parameter name '_strRefBranchReleaseFrom' doesn't match '[a-z][a-zA-Z0-9]*' 236

fr/paris/lutece/plugins/releaser/service/ClusterService.java

Rule Violation Ligne
MethodNamingConventions The static method name 'IsAddClusterAuthorized' doesn't match '[a-z][a-zA-Z0-9]*' 146155
MethodNamingConventions The static method name 'IsUserAuthorized' doesn't match '[a-z][a-zA-Z0-9]*' 157168

fr/paris/lutece/plugins/releaser/service/ComponentService.java

Rule Violation Ligne
AvoidFileStream Avoid instantiating FileInputStream, FileOutputStream, FileReader, or FileWriter 437
MethodNamingConventions The static method name 'IsSearchComponentAuthorized' doesn't match '[a-z][a-zA-Z0-9]*' 478487

fr/paris/lutece/plugins/releaser/service/JiraComponentService.java

Rule Violation Ligne
FieldNamingConventions The static field name 'URL_JIRA_SERVER' doesn't match '_[a-z][a-zA-Z0-9]*' 87
FieldNamingConventions The static field name 'JIRA_USER' doesn't match '_[a-z][a-zA-Z0-9]*' 90
FieldNamingConventions The static field name 'JIRA_USER_PWD' doesn't match '_[a-z][a-zA-Z0-9]*' 93

fr/paris/lutece/plugins/releaser/service/MavenService.java

Rule Violation Ligne
ClassWithOnlyPrivateConstructorsShouldBeFinal A class which only has private constructors should be final 62291

fr/paris/lutece/plugins/releaser/service/SiteService.java

Rule Violation Ligne
AvoidFileStream Avoid instantiating FileInputStream, FileOutputStream, FileReader, or FileWriter 764
MethodNamingConventions The static method name 'IsUserAuthorized' doesn't match '[a-z][a-zA-Z0-9]*' 851862
MethodNamingConventions The static method name 'IsSiteAlreadyExist' doesn't match '[a-z][a-zA-Z0-9]*' 864871

fr/paris/lutece/plugins/releaser/util/CommandResult.java

Rule Violation Ligne
FieldNamingConventions The static field name 'STATUS_ERROR' doesn't match '_[a-z][a-zA-Z0-9]*' 52
FieldNamingConventions The static field name 'STATUS_OK' doesn't match '_[a-z][a-zA-Z0-9]*' 55
FieldNamingConventions The static field name 'ERROR_TYPE_INFO' doesn't match '_[a-z][a-zA-Z0-9]*' 58
FieldNamingConventions The static field name 'ERROR_TYPE_STOP' doesn't match '_[a-z][a-zA-Z0-9]*' 61
FieldNamingConventions The field name 'progressValue' doesn't match '_[a-z][a-zA-Z0-9]*' 82
FormalParameterNamingConventions The method parameter name '_mResultInformations' doesn't match '[a-z][a-zA-Z0-9]*' 206
FormalParameterNamingConventions The method parameter name '_nErrorType' doesn't match '[a-z][a-zA-Z0-9]*' 227
FormalParameterNamingConventions The method parameter name '_dBegin' doesn't match '[a-z][a-zA-Z0-9]*' 248
FormalParameterNamingConventions The method parameter name '_dEnd' doesn't match '[a-z][a-zA-Z0-9]*' 269

fr/paris/lutece/plugins/releaser/util/MapperJsonUtil.java

Rule Violation Ligne
FieldNamingConventions The constant name '_mapper' doesn't match '[A-Z][A-Z_0-9]*' 50

fr/paris/lutece/plugins/releaser/util/PluginUtils.java

Rule Violation Ligne
AvoidFileStream Avoid instantiating FileInputStream, FileOutputStream, FileReader, or FileWriter 193
AvoidFileStream Avoid instantiating FileInputStream, FileOutputStream, FileReader, or FileWriter 247
AvoidFileStream Avoid instantiating FileInputStream, FileOutputStream, FileReader, or FileWriter 308

fr/paris/lutece/plugins/releaser/util/github/GitUtils.java

Rule Violation Ligne
LocalVariableNamingConventions The final local variable name 'TOKEN' doesn't match '[a-z][a-zA-Z0-9]*' 621

fr/paris/lutece/plugins/releaser/util/github/GithubSearchRepoItem.java

Rule Violation Ligne
FormalParameterNamingConventions The method parameter name '_strName' doesn't match '[a-z][a-zA-Z0-9]*' 73
FormalParameterNamingConventions The method parameter name '_strCloneUrl' doesn't match '[a-z][a-zA-Z0-9]*' 96
FormalParameterNamingConventions The method parameter name '_strContentsUrl' doesn't match '[a-z][a-zA-Z0-9]*' 119
FormalParameterNamingConventions The method parameter name '_strFullName' doesn't match '[a-z][a-zA-Z0-9]*' 142

fr/paris/lutece/plugins/releaser/util/github/ReleaseGITGetRepoClient.java

Rule Violation Ligne
FieldNamingConventions The field name 'bCancelled' doesn't match '_[a-z][a-zA-Z0-9]*' 44

fr/paris/lutece/plugins/releaser/util/pom/PomUpdater.java

Rule Violation Ligne
ClassNamingConventions The utility class name 'PomUpdater' doesn't match '[A-Z][a-zA-Z0-9]+(Utils?|Helper|Home|Service)' 64274
AvoidFileStream Avoid instantiating FileInputStream, FileOutputStream, FileReader, or FileWriter 87
AvoidFileStream Avoid instantiating FileInputStream, FileOutputStream, FileReader, or FileWriter 124
AvoidFileStream Avoid instantiating FileInputStream, FileOutputStream, FileReader, or FileWriter 172
AvoidFileStream Avoid instantiating FileInputStream, FileOutputStream, FileReader, or FileWriter 201

fr/paris/lutece/plugins/releaser/util/svn/ReleaseSvnCheckoutClient.java

Rule Violation Ligne
FieldNamingConventions The field name 'bCancelled' doesn't match '_[a-z][a-zA-Z0-9]*' 49

fr/paris/lutece/plugins/releaser/util/svn/ReleaseSvnCommitClient.java

Rule Violation Ligne
FieldNamingConventions The field name 'bCancelled' doesn't match '_[a-z][a-zA-Z0-9]*' 48

fr/paris/lutece/plugins/releaser/util/svn/ReleaseSvnCopyClient.java

Rule Violation Ligne
FieldNamingConventions The field name 'bCancelled' doesn't match '_[a-z][a-zA-Z0-9]*' 48

fr/paris/lutece/plugins/releaser/util/svn/SvnUser.java

Rule Violation Ligne
FormalParameterNamingConventions The method parameter name '_mUserContex' doesn't match '[a-z][a-zA-Z0-9]*' 120

fr/paris/lutece/plugins/releaser/util/svn/SvnUtils.java

Rule Violation Ligne
FieldNamingConventions The constant name 'logger' doesn't match '[A-Z][A-Z_0-9]*' 92

Priority 2

fr/paris/lutece/plugins/releaser/service/ComponentService.java

Rule Violation Ligne
AvoidReassigningParameters Avoid reassigning parameters such as 'component' 370
AvoidReassigningParameters Avoid reassigning parameters such as 'component' 370
AvoidReassigningParameters Avoid reassigning parameters such as 'component' 530

fr/paris/lutece/plugins/releaser/service/MavenService.java

Rule Violation Ligne
SystemPrintln System.out.println is used 246

fr/paris/lutece/plugins/releaser/service/ReleaseComponentTask.java

Rule Violation Ligne
AvoidBranchingStatementAsLastInLoop Avoid using a branching statement as the last in a loop. 160

fr/paris/lutece/plugins/releaser/service/SiteService.java

Rule Violation Ligne
BooleanInstantiation Avoid instantiating Boolean objects; reference Boolean.TRUE or Boolean.FALSE or call Boolean.valueOf() instead. 339

fr/paris/lutece/plugins/releaser/service/svn/SvnResourceService.java

Rule Violation Ligne
LongInstantiation Avoid instantiating Long objects.Call Long.valueOf() instead 355

fr/paris/lutece/plugins/releaser/util/github/GitUtils.java

Rule Violation Ligne
AvoidReassigningParameters Avoid reassigning parameters such as 'strRepoUrl' 689

fr/paris/lutece/plugins/releaser/util/svn/SvnUtils.java

Rule Violation Ligne
AvoidReassigningParameters Avoid reassigning parameters such as 'strRepoUrl' 465

Priority 3

fr/paris/lutece/plugins/releaser/business/AbstractReleaserResource.java

Rule Violation Ligne
ConfusingTernary Avoid if (x != y) ..; else ..; 5775
ConfusingTernary Avoid if (x != y) ..; else ..; 100107
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 115

fr/paris/lutece/plugins/releaser/business/Cluster.java

Rule Violation Ligne
LooseCoupling Avoid using implementation types like 'HashMap'; use the interface instead 59
LooseCoupling Avoid using implementation types like 'HashMap'; use the interface instead 170
LooseCoupling Avoid using implementation types like 'HashMap'; use the interface instead 175

fr/paris/lutece/plugins/releaser/business/ClusterDAO.java

Rule Violation Ligne
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 158
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 184

fr/paris/lutece/plugins/releaser/business/Component.java

Rule Violation Ligne
ExcessivePublicCount This class has a bunch of public methods and attributes 34721
TooManyFields Too many fields 47721
LooseCoupling Avoid using implementation types like 'HashMap'; use the interface instead 54
UnusedPrivateField Avoid unused private fields such as '_strDescription'. 82
MissingOverride The method 'getArtifactId()' is missing an @Override annotation. 143146
MissingOverride The method 'getTargetVersion()' is missing an @Override annotation. 227230
SimplifyBooleanReturns Avoid unnecessary if..then..else statements when returning booleans 440444
LooseCoupling Avoid using implementation types like 'HashMap'; use the interface instead 681
LooseCoupling Avoid using implementation types like 'HashMap'; use the interface instead 686
CommentRequired Public method and constructor comments are required 691694
CommentRequired Public method and constructor comments are required 696699
CommentRequired Public method and constructor comments are required 701704
CommentRequired Public method and constructor comments are required 706709
CommentRequired Public method and constructor comments are required 711714
CommentRequired Public method and constructor comments are required 716719

fr/paris/lutece/plugins/releaser/business/ReleaserUser.java

Rule Violation Ligne
LooseCoupling Avoid using implementation types like 'HashMap'; use the interface instead 54
ImmutableField Private field '_mapCredential' could be made final; it is only initialized in the declaration or constructor. 54
ImmutableField Private field '_strLogin' could be made final; it is only initialized in the declaration or constructor. 115
FieldDeclarationsShouldBeAtStartOfClass Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. 115
ImmutableField Private field '_strPassword' could be made final; it is only initialized in the declaration or constructor. 118
FieldDeclarationsShouldBeAtStartOfClass Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. 118

fr/paris/lutece/plugins/releaser/business/Site.java

Rule Violation Ligne
ExcessivePublicCount This class has a bunch of public methods and attributes 34612
TooManyFields Too many fields 51612
LooseCoupling Avoid using implementation types like 'HashMap'; use the interface instead 62
ImmutableField Private field '_listCurrentDependencies' could be made final; it is only initialized in the declaration or constructor. 106
ImmutableField Private field '_listComponents' could be made final; it is only initialized in the declaration or constructor. 109
MissingOverride The method 'getArtifactId()' is missing an @Override annotation. 167170
MissingOverride The method 'getScmUrl()' is missing an @Override annotation. 209212
CommentRequired Public method and constructor comments are required 540543
CommentRequired Public method and constructor comments are required 545548
CommentRequired Public method and constructor comments are required 550553
CommentRequired Public method and constructor comments are required 555558
LooseCoupling Avoid using implementation types like 'HashMap'; use the interface instead 594
LooseCoupling Avoid using implementation types like 'HashMap'; use the interface instead 599
ControlStatementBraces This statement should have braces 602
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 602
ControlStatementBraces This statement should have braces 604

fr/paris/lutece/plugins/releaser/business/SiteDAO.java

Rule Violation Ligne
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 182
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 214
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 252
UnusedLocalVariable Avoid unused local variables such as 'nIndex'. 294
ControlStatementBraces This statement should have braces 296

fr/paris/lutece/plugins/releaser/service/ClusterResourceIdService.java

Rule Violation Ligne
DataClass The class 'ClusterResourceIdService' is suspected to be a Data Class (WOC=0.000%, NOPA=4, NOAM=0, WMC=1) 48147
CommentRequired Header comments are required 48147
CallSuperInConstructor It is a good practice to call super() in a constructor 7174
ShortVariable Avoid variables with short names like rt 80
ShortVariable Avoid variables with short names like p 86

fr/paris/lutece/plugins/releaser/service/ClusterService.java

Rule Violation Ligne
UseUtilityClass All methods are static. Consider using a utility class instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning. 51169
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 82
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 86
ControlStatementBraces This statement should have braces 140
CommentRequired Public method and constructor comments are required 146155
SimplifyBooleanReturns Avoid unnecessary if..then..else statements when returning booleans 149152
CommentRequired Public method and constructor comments are required 157168

fr/paris/lutece/plugins/releaser/service/ComponentResourceIdService.java

Rule Violation Ligne
CommentRequired Header comments are required 4595
CallSuperInConstructor It is a good practice to call super() in a constructor 5659
ShortVariable Avoid variables with short names like rt 65
ShortVariable Avoid variables with short names like p 71

fr/paris/lutece/plugins/releaser/service/ComponentService.java

Rule Violation Ligne
ExcessiveImports A high number of imports can indicate a high degree of coupling within an object. 34579
GodClass Possible God Class (WMC=50, ATFD=64, TCC=0.526%) 84579
UnusedPrivateField Avoid unused private fields such as '_executor'. 86
SingularField Perhaps '_executor' could be replaced by a local variable. 86
NonThreadSafeSingleton Singleton is not thread safe 109113
NPathComplexity The method 'setRemoteInformations(Component, boolean)' has an NPath complexity of 517 119169
CommentRequired Public method and constructor comments are required 119169
CyclomaticComplexity The method 'setRemoteInformations(Component, boolean)' has a cyclomatic complexity of 14. 119169
MissingOverride The method 'setRemoteInformations(Component, boolean)' is missing an @Override annotation. 119169
AvoidDeeplyNestedIfStmts Deeply nested if..then statements are hard to read 138141
ConfusingTernary Avoid if (x != y) ..; else ..; 150
ConfusingTernary Avoid if (x != y) ..; else ..; 151
ConfusingTernary Avoid if (x != y) ..; else ..; 152
ConfusingTernary Avoid if (x != y) ..; else ..; 153
ConfusingTernary Avoid if (x != y) ..; else ..; 154
AvoidDeeplyNestedIfStmts Deeply nested if..then statements are hard to read 156160
MissingOverride The method 'getLastReleaseVersion(String)' is missing an @Override annotation. 176181
MissingOverride The method 'setLastReleaseVersion(String, String)' is missing an @Override annotation. 188193
MissingOverride The method 'getLastReleaseNextSnapshotVersion(String)' is missing an @Override annotation. 200205
MissingOverride The method 'setLastReleaseNextSnapshotVersion(String, String)' is missing an @Override annotation. 212216
CommentRequired Public method and constructor comments are required 242245
MissingOverride The method 'release(Component, Locale, AdminUser, HttpServletRequest)' is missing an @Override annotation. 242245
CommentRequired Public method and constructor comments are required 247251
MissingOverride The method 'isGitComponent(Component)' is missing an @Override annotation. 247251
MissingOverride The method 'init()' is missing an @Override annotation. 253259
CommentRequired Public method and constructor comments are required 253259
CyclomaticComplexity The method 'updateRemoteInformations(Component)' has a cyclomatic complexity of 11. 262310
CommentRequired Public method and constructor comments are required 312345
MissingOverride The method 'getSearchComponent(String, HttpServletRequest, Locale, String, String)' is missing an @Override annotation. 312345
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 327
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 341342
UnusedFormalParameter Avoid unused method parameters such as 'strPassword'. 347
UnusedFormalParameter Avoid unused method parameters such as 'strUser'. 347
MissingOverride The method 'loadComponent(Component, String, String, String)' is missing an @Override annotation. 370400
CommentRequired Public method and constructor comments are required 370400
MissingOverride The method 'isErrorSnapshotComponentInformations(Component, String)' is missing an @Override annotation. 426456
CommentRequired Public method and constructor comments are required 426456
MissingOverride The method 'changeNextReleaseVersion(Component)' is missing an @Override annotation. 464476
CommentRequired Public method and constructor comments are required 478487
SimplifyBooleanReturns Avoid unnecessary if..then..else statements when returning booleans 481484
CommentRequired Public method and constructor comments are required 530577
MissingOverride The method 'getLastBranchVersion(Component, String, ReleaserUser)' is missing an @Override annotation. 530577

fr/paris/lutece/plugins/releaser/service/GetRemoteInformationsTask.java

Rule Violation Ligne
DoNotUseThreads To be compliant to J2EE, a webapp should not use any thread. 46
ImmutableField Private field '_component' could be made final; it is only initialized in the declaration or constructor. 49

fr/paris/lutece/plugins/releaser/service/IComponentService.java

Rule Violation Ligne
CommentRequired Public method and constructor comments are required 231

fr/paris/lutece/plugins/releaser/service/IJiraService.java

Rule Violation Ligne
UnnecessaryModifier Unnecessary modifiers 'public abstract' on method 'init': the method is declared in an interface type 48
UnnecessaryModifier Unnecessary modifiers 'public abstract' on method 'updateComponentVersions': the method is declared in an interface type 58

fr/paris/lutece/plugins/releaser/service/IMavenService.java

Rule Violation Ligne
UseObjectForClearerAPI Rather than using a lot of String arguments, consider using a container object for those values. 8182

fr/paris/lutece/plugins/releaser/service/IWorkflowReleaseContextService.java

Rule Violation Ligne
TooManyMethods This class has too many methods, consider refactoring it. 49221

fr/paris/lutece/plugins/releaser/service/JiraComponentService.java

Rule Violation Ligne
ExcessiveImports A high number of imports can indicate a high degree of coupling within an object. 34286
UnnecessaryConstructor Avoid unnecessary constructors - the compiler will generate these for you 110113
UncommentedEmptyConstructor Document empty constructor 110113
NonThreadSafeSingleton Singleton is not thread safe 122126
CyclomaticComplexity The method 'updateComponentVersions(Component, CommandResult)' has a cyclomatic complexity of 12. 185284
AvoidSynchronizedAtMethodLevel Use block level rather than method level synchronization 185284
ConfusingTernary Avoid if (x != y) ..; else ..; 191282
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 229
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 230
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 230
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 259

fr/paris/lutece/plugins/releaser/service/MavenService.java

Rule Violation Ligne
NonThreadSafeSingleton Singleton is not thread safe 8791
MissingOverride The method 'init()' is missing an @Override annotation. 100106
MissingOverride The method 'mvnSiteAssembly(String, String, String, SvnUser, CommandResult)' is missing an @Override annotation. 128138
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 133
AvoidSynchronizedAtMethodLevel Use block level rather than method level synchronization 176224
AddEmptyString Do not add empty strings 195
CommentRequired Public method and constructor comments are required 206209
MissingOverride The method 'consumeLine(String)' is missing an @Override annotation. 206209
InefficientStringBuffering Avoid concatenating nonliterals in a StringBuffer/StringBuilder constructor or append(). 208
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 217
MissingOverride The method 'mvnReleasePerform(String, String, String, CommandResult, boolean)' is missing an @Override annotation. 239253
UseObjectForClearerAPI Rather than using a lot of String arguments, consider using a container object for those values. 274275
MissingOverride The method 'mvnReleasePrepare(String, String, String, String, String, String, CommandResult)' is missing an @Override annotation. 274289

fr/paris/lutece/plugins/releaser/service/ReleaseComponentTask.java

Rule Violation Ligne
DoNotUseThreads To be compliant to J2EE, a webapp should not use any thread. 59
ImmutableField Private field '_nIdWorkflow' could be made final; it is only initialized in the declaration or constructor. 66
ImmutableField Private field '_wfContext' could be made final; it is only initialized in the declaration or constructor. 69
ImmutableField Private field '_request' could be made final; it is only initialized in the declaration or constructor. 72
ImmutableField Private field '_user' could be made final; it is only initialized in the declaration or constructor. 75
ImmutableField Private field '_locale' could be made final; it is only initialized in the declaration or constructor. 78
MissingOverride The method 'run()' is missing an @Override annotation. 107178
UnusedLocalVariable Avoid unused local variables such as 'state'. 110

fr/paris/lutece/plugins/releaser/service/SiteResourceIdService.java

Rule Violation Ligne
CallSuperInConstructor It is a good practice to call super() in a constructor 7275
ShortVariable Avoid variables with short names like rt 80
ShortVariable Avoid variables with short names like p 86

fr/paris/lutece/plugins/releaser/service/SiteService.java

Rule Violation Ligne
ExcessiveImports A high number of imports can indicate a high degree of coupling within an object. 34873
GodClass Possible God Class (WMC=95, ATFD=142, TCC=0.000%) 83873
CyclomaticComplexity The class 'SiteService' has a total cyclomatic complexity of 95 (highest 14). 83873
TooManyMethods This class has too many methods, consider refactoring it. 84873
ConfusingTernary Avoid if (x != y) ..; else ..; 127143
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 227
IdenticalCatchBranches 'catch' branch identical to 'InterruptedException' branch 246250
CyclomaticComplexity The method 'buildReleaseComments(Component, Locale)' has a cyclomatic complexity of 14. 428501
ConfusingTernary Avoid if (x != y) ..; else ..; 439500
ConfusingTernary Avoid if (x != y) ..; else ..; 472488
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 630
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 630
IdenticalCatchBranches 'catch' branch identical to 'FileNotFoundException' branch 781785
CommentRequired Public method and constructor comments are required 790849
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 793
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 802
CommentRequired Public method and constructor comments are required 851862
CommentRequired Public method and constructor comments are required 864871
SimplifyBooleanReturns Avoid unnecessary if..then..else statements when returning booleans 867868
ControlStatementBraces This statement should have braces 868

fr/paris/lutece/plugins/releaser/service/TwitterService.java

Rule Violation Ligne
RedundantFieldInitializer Avoid using redundant field initializer for '_twitter' 89
RedundantFieldInitializer Avoid using redundant field initializer for '_instance' 92
NonThreadSafeSingleton Singleton is not thread safe 101105
UnnecessaryConstructor Avoid unnecessary constructors - the compiler will generate these for you 113116
MissingOverride The method 'sendTweet(String, CommandResult)' is missing an @Override annotation. 126144
MissingOverride The method 'init()' is missing an @Override annotation. 149167

fr/paris/lutece/plugins/releaser/service/WorkflowReleaseContextService.java

Rule Violation Ligne
ExcessiveImports A high number of imports can indicate a high degree of coupling within an object. 34870
GodClass Possible God Class (WMC=62, ATFD=100, TCC=2.632%) 83870
TooManyMethods This class has too many methods, consider refactoring it. 84870
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 90
LooseCoupling Avoid using implementation types like 'HashMap'; use the interface instead 90
ImmutableField Private field '_mapWorkflowReleaseContext' could be made final; it is only initialized in the declaration or constructor. 90
LooseCoupling Avoid using implementation types like 'HashSet'; use the interface instead 96
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 96
ImmutableField Private field '_releaseInProgress' could be made final; it is only initialized in the declaration or constructor. 96
AvoidSynchronizedAtMethodLevel Use block level rather than method level synchronization 112134
ConfusingTernary Avoid if (x != y) ..; else ..; 122
MissingOverride The method 'saveWorkflowReleaseContext(WorkflowReleaseContext)' is missing an @Override annotation. 160198
AvoidSynchronizedAtMethodLevel Use block level rather than method level synchronization 160198
ConfusingTernary Avoid if (x != y) ..; else ..; 170191
ConfusingTernary Avoid if (x != y) ..; else ..; 187
MissingOverride The method 'getListWorkflowReleaseContextHistory(String)' is missing an @Override annotation. 232261
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 235
MissingOverride The method 'getIdWorkflow(WorkflowReleaseContext)' is missing an @Override annotation. 270286
NonThreadSafeSingleton Singleton is not thread safe 295300
MissingOverride The method 'mergeDevelopMaster(WorkflowReleaseContext, Locale)' is missing an @Override annotation. 313411
CyclomaticComplexity The method 'mergeDevelopMaster(WorkflowReleaseContext, Locale)' has a cyclomatic complexity of 14. 313411
ConfusingTernary Avoid if (x != y) ..; else ..; 335371
IdenticalCatchBranches 'catch' branch identical to 'InvalidRemoteException' branch 380384
IdenticalCatchBranches 'catch' branch identical to 'InvalidRemoteException' branch 385388
IdenticalCatchBranches 'catch' branch identical to 'InvalidRemoteException' branch 389392
ExcessiveMethodLength Avoid really long methods. 421579
NcssCount The method 'releasePrepareComponent(WorkflowReleaseContext, Locale)' has a NCSS line count of 71. 421579
CyclomaticComplexity The method 'releasePrepareComponent(WorkflowReleaseContext, Locale)' has a cyclomatic complexity of 13. 421579
MissingOverride The method 'releasePrepareComponent(WorkflowReleaseContext, Locale)' is missing an @Override annotation. 421579
AvoidDuplicateLiterals The String literal " to " appears 4 times in this file; the first occurrence is on line 462 462
MissingOverride The method 'releasePerformComponent(WorkflowReleaseContext, Locale)' is missing an @Override annotation. 589619
AvoidDuplicateLiterals The String literal " Release Perform" appears 4 times in this file; the first occurrence is on line 597 597
MissingOverride The method 'checkoutRepository(WorkflowReleaseContext, Locale)' is missing an @Override annotation. 629642
MissingOverride The method 'releasePrepareSite(WorkflowReleaseContext, Locale)' is missing an @Override annotation. 652716
AvoidDuplicateLiterals The String literal "...\n" appears 4 times in this file; the first occurrence is on line 665 665
MissingOverride The method 'sendTweet(WorkflowReleaseContext, Locale)' is missing an @Override annotation. 726737
MissingOverride The method 'updateJiraVersions(WorkflowReleaseContext, Locale)' is missing an @Override annotation. 747758
MissingOverride The method 'startWorkflowReleaseContext(WorkflowReleaseContext, int, Locale, HttpServletRequest, AdminUser)' is missing an @Override annotation. 774777
MissingOverride The method 'init()' is missing an @Override annotation. 782787
MissingOverride The method 'startReleaseInProgress(String)' is missing an @Override annotation. 795799
MissingOverride The method 'stopReleaseInProgress(String)' is missing an @Override annotation. 807811
MissingOverride The method 'isReleaseInProgress(String)' is missing an @Override annotation. 820824

fr/paris/lutece/plugins/releaser/service/github/GitResourceService.java

Rule Violation Ligne
MissingOverride The method 'fetchPom(Site, String, String)' is missing an @Override annotation. 8598
MissingOverride The method 'getLastRelease(Site, String, String)' is missing an @Override annotation. 111138
CyclomaticComplexity The method 'doCheckoutRepository(WorkflowReleaseContext, String, String)' has a cyclomatic complexity of 11. 152240
ConfusingTernary Avoid if (x != y) ..; else ..; 187198
AvoidDuplicateLiterals The String literal "/.git" appears 4 times in this file; the first occurrence is on line 283 283
IdenticalCatchBranches 'catch' branch identical to 'InvalidRemoteException' branch 297301
IdenticalCatchBranches 'catch' branch identical to 'InvalidRemoteException' branch 302305
IdenticalCatchBranches 'catch' branch identical to 'InvalidRemoteException' branch 306309
IdenticalCatchBranches 'catch' branch identical to 'InvalidRemoteException' branch 368372
IdenticalCatchBranches 'catch' branch identical to 'InvalidRemoteException' branch 373376
IdenticalCatchBranches 'catch' branch identical to 'InvalidRemoteException' branch 377380
CyclomaticComplexity The method 'rollbackRelease(WorkflowReleaseContext, Locale)' has a cyclomatic complexity of 15. 411526
ExcessiveMethodLength Avoid really long methods. 411526
ConfusingTernary Avoid if (x != y) ..; else ..; 459466
IdenticalCatchBranches 'catch' branch identical to 'InvalidRemoteException' branch 493497
IdenticalCatchBranches 'catch' branch identical to 'InvalidRemoteException' branch 498501
IdenticalCatchBranches 'catch' branch identical to 'InvalidRemoteException' branch 502505
IdenticalCatchBranches 'catch' branch identical to 'InvalidRemoteException' branch 582586
IdenticalCatchBranches 'catch' branch identical to 'InvalidRemoteException' branch 587590
IdenticalCatchBranches 'catch' branch identical to 'InvalidRemoteException' branch 591594

fr/paris/lutece/plugins/releaser/service/svn/SvnResourceService.java

Rule Violation Ligne
ExcessiveImports A high number of imports can indicate a high degree of coupling within an object. 34412
MissingOverride The method 'fetchPom(Site, String, String)' is missing an @Override annotation. 92112
AvoidLiteralsInIfCondition Avoid using Literals in Conditional Statements 106
MissingOverride The method 'getLastRelease(Site, String, String)' is missing an @Override annotation. 125160
ConfusingTernary Avoid if (x != y) ..; else ..; 146
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 173
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 262
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 310
ConfusingTernary Avoid if (x != y) ..; else ..; 355
CompareObjectsWithEquals Use equals() to compare object references. 357
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 371

fr/paris/lutece/plugins/releaser/util/CVSFactoryService.java

Rule Violation Ligne
UseUtilityClass All methods are static. Consider using a utility class instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning. 44104
UncommentedEmptyConstructor Document empty constructor 5861
UnnecessaryConstructor Avoid unnecessary constructors - the compiler will generate these for you 5861

fr/paris/lutece/plugins/releaser/util/CommandResult.java

Rule Violation Ligne
RedundantFieldInitializer Avoid using redundant field initializer for 'STATUS_ERROR' 52
RedundantFieldInitializer Avoid using redundant field initializer for 'ERROR_TYPE_INFO' 58
AvoidStringBufferField StringBuffers can grow quite a lot, and so may become a source of memory leak (if the owning class has a long life time). 64
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 88
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 88
CloneMethodReturnTypeMustMatchClassName The return type of the clone() method must be the class name when implements Cloneable 158167

fr/paris/lutece/plugins/releaser/util/MapperJsonUtil.java

Rule Violation Ligne
ShortVariable Avoid variables with short names like t 78

fr/paris/lutece/plugins/releaser/util/PluginUtils.java

Rule Violation Ligne
UseUtilityClass All methods are static. Consider using a utility class instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning. 66363
CyclomaticComplexity The method 'updateAppInfoFile(String, String, CommandResult)' has a cyclomatic complexity of 12. 185269
ShortVariable Avoid variables with short names like br 188
AvoidLiteralsInIfCondition Avoid using Literals in Conditional Statements 200
CollapsibleIfStatements These nested if statements could be combined 200213
ConfusingTernary Avoid if (x != y) ..; else ..; 203212
InefficientStringBuffering Avoid concatenating nonliterals in a StringBuffer/StringBuilder constructor or append(). 216
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 220
ShortVariable Avoid variables with short names like fw 244
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 250
ShortVariable Avoid variables with short names like fw 284
ShortVariable Avoid variables with short names like sw 301
ShortVariable Avoid variables with short names like tf 304
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 319
AvoidPrintStackTrace Avoid printStackTrace(); use a logger call instead. 334
CommentDefaultAccessModifier To avoid mistakes add a comment at the beginning of the ContextFileFilter nested class if you want a default access modifier 345361
MissingOverride The method 'accept(File, String)' is missing an @Override annotation. 357360

fr/paris/lutece/plugins/releaser/util/ReleaserUtils.java

Rule Violation Ligne
GodClass Possible God Class (WMC=54, ATFD=68, TCC=0.000%) 64563
TooManyMethods This class has too many methods, consider refactoring it. 65563
UseUtilityClass All methods are static. Consider using a utility class instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning. 65563
ConfusingTernary Avoid if (x != y) ..; else ..; 118129
ShortVariable Avoid variables with short names like e 238
ConfusingTernary Avoid if (x != y) ..; else ..; 241248
ShortVariable Avoid variables with short names like e 271
AvoidUncheckedExceptionsInSignatures A method or constructor should not explicitly declare unchecked exceptions in its 'throws' clause 271
ConfusingTernary Avoid if (x != y) ..; else ..; 274281
ConfusingTernary Avoid if (x != y) ..; else ..; 291298
AvoidUncheckedExceptionsInSignatures A method or constructor should not explicitly declare unchecked exceptions in its 'throws' clause 311
ConfusingTernary Avoid if (x != y) ..; else ..; 332
ConfusingTernary Avoid if (x != y) ..; else ..; 377
ConfusingTernary Avoid if (x != y) ..; else ..; 439
ForLoopCanBeForeach This for loop can be replaced by a foreach loop 463473
ConfusingTernary Avoid if (x != y) ..; else ..; 487
CommentRequired Public method and constructor comments are required 531539
CommentRequired Public method and constructor comments are required 541561
ConfusingTernary Avoid if (x != y) ..; else ..; 546558
ConfusingTernary Avoid if (x != y) ..; else ..; 551558

fr/paris/lutece/plugins/releaser/util/file/FileUtils.java

Rule Violation Ligne
UseUtilityClass All methods are static. Consider using a utility class instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning. 48160
InefficientStringBuffering Avoid concatenating nonliterals in a StringBuffer/StringBuilder constructor or append(). 82
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 141

fr/paris/lutece/plugins/releaser/util/github/GitUtils.java

Rule Violation Ligne
ExcessiveImports A high number of imports can indicate a high degree of coupling within an object. 34788
GodClass Possible God Class (WMC=69, ATFD=39, TCC=0.000%) 89788
UseUtilityClass All methods are static. Consider using a utility class instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning. 90788
UseObjectForClearerAPI Rather than using a lot of String arguments, consider using a container object for those values. 118119
IdenticalCatchBranches 'catch' branch identical to 'InvalidRemoteException' branch 145149
IdenticalCatchBranches 'catch' branch identical to 'InvalidRemoteException' branch 150153
IdenticalCatchBranches 'catch' branch identical to 'InvalidRemoteException' branch 154158
IdenticalCatchBranches 'catch' branch identical to 'InvalidRemoteException' branch 193197
IdenticalCatchBranches 'catch' branch identical to 'InvalidRemoteException' branch 199202
IdenticalCatchBranches 'catch' branch identical to 'InvalidRemoteException' branch 229233
IdenticalCatchBranches 'catch' branch identical to 'InvalidRemoteException' branch 235238
IdenticalCatchBranches 'catch' branch identical to 'RefAlreadyExistsException' branch 267270
IdenticalCatchBranches 'catch' branch identical to 'RefAlreadyExistsException' branch 271274
IdenticalCatchBranches 'catch' branch identical to 'RefAlreadyExistsException' branch 275278
IdenticalCatchBranches 'catch' branch identical to 'RefAlreadyExistsException' branch 279282
UnnecessaryLocalBeforeReturn Consider simply returning the value vs storing it in local variable 'mergeResult' 400
ShortVariable Avoid variables with short names like i 419
UseStringBufferForStringAppends Prefer StringBuilder (non-synchronized) or StringBuffer (synchronized) over += for concatenating strings 424
UseStringBufferForStringAppends Prefer StringBuilder (non-synchronized) or StringBuffer (synchronized) over += for concatenating strings 425
UseStringBufferForStringAppends Prefer StringBuilder (non-synchronized) or StringBuffer (synchronized) over += for concatenating strings 426
ShortVariable Avoid variables with short names like i 445
UseObjectForClearerAPI Rather than using a lot of String arguments, consider using a container object for those values. 527
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 550
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 550
IdenticalCatchBranches 'catch' branch identical to 'HttpAccessException' branch 565568
UseObjectForClearerAPI Rather than using a lot of String arguments, consider using a container object for those values. 588
ShortVariable Avoid variables with short names like i 626
ForLoopCanBeForeach This for loop can be replaced by a foreach loop 644653
UnusedLocalVariable Avoid unused local variables such as 'tagName'. 647
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 711
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 712
CommentRequired Public method and constructor comments are required 736787
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 747

fr/paris/lutece/plugins/releaser/util/github/ReleaseGITGetRepoClient.java

Rule Violation Ligne
UnusedPrivateField Avoid unused private fields such as 'bCancelled'. 44
SingularField Perhaps 'bCancelled' could be replaced by a local variable. 44
UncommentedEmptyConstructor Document empty constructor 4951
UnnecessaryConstructor Avoid unnecessary constructors - the compiler will generate these for you 4951

fr/paris/lutece/plugins/releaser/util/maven/MavenUtils.java

Rule Violation Ligne
UseObjectForClearerAPI Rather than using a lot of String arguments, consider using a container object for those values. 7677
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 85

fr/paris/lutece/plugins/releaser/util/pom/PomParser.java

Rule Violation Ligne
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 66
ImmutableField Private field '_listDependencies' could be made final; it is only initialized in the declaration or constructor. 66
LooseCoupling Avoid using implementation types like 'ArrayList'; use the interface instead 66
LinguisticNaming Linguistics Antipattern - The variable 'isPOM' indicates linguistically it is a boolean, but it is 'InputSource' 90
LinguisticNaming Linguistics Antipattern - The variable 'isPOM' indicates linguistically it is a boolean, but it is 'InputSource' 125
ShortVariable Avoid variables with short names like jc 238
ShortVariable Avoid variables with short names like u 239

fr/paris/lutece/plugins/releaser/util/pom/PomUpdater.java

Rule Violation Ligne
UseUtilityClass All methods are static. Consider using a utility class instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning. 65274
CyclomaticComplexity The method 'updateSiteAfterTag(Site, String)' has a cyclomatic complexity of 10. 163227
CollapsibleIfStatements These nested if statements could be combined 190193
AvoidDeeplyNestedIfStmts Deeply nested if..then statements are hard to read 190193
ShortVariable Avoid variables with short names like jc 245
ShortVariable Avoid variables with short names like m 246
ShortVariable Avoid variables with short names like jc 268
ShortVariable Avoid variables with short names like u 269

fr/paris/lutece/plugins/releaser/util/svn/ReleaseSvnCheckoutClient.java

Rule Violation Ligne
SingularField Perhaps 'bCancelled' could be replaced by a local variable. 49
UnusedPrivateField Avoid unused private fields such as 'bCancelled'. 49

fr/paris/lutece/plugins/releaser/util/svn/ReleaseSvnCommitClient.java

Rule Violation Ligne
UnusedPrivateField Avoid unused private fields such as 'bCancelled'. 48
SingularField Perhaps 'bCancelled' could be replaced by a local variable. 48

fr/paris/lutece/plugins/releaser/util/svn/ReleaseSvnCopyClient.java

Rule Violation Ligne
UnusedPrivateField Avoid unused private fields such as 'bCancelled'. 48
SingularField Perhaps 'bCancelled' could be replaced by a local variable. 48

fr/paris/lutece/plugins/releaser/util/svn/SvnUtils.java

Rule Violation Ligne
ExcessiveImports A high number of imports can indicate a high degree of coupling within an object. 34508
UnusedPrivateField Avoid unused private fields such as 'MESSAGE_ERROR_SVN'. 86
UnusedPrivateField Avoid unused private fields such as 'CONSTANTE_SLASH'. 89
UnusedPrivateField Avoid unused private fields such as 'logger'. 92
UseObjectForClearerAPI Rather than using a lot of String arguments, consider using a container object for those values. 163
CollapsibleIfStatements These nested if statements could be combined 207212
CommentRequired Public method and constructor comments are required 222225
MissingOverride The method 'checkCancelled()' is missing an @Override annotation. 222225
CommentRequired Public method and constructor comments are required 227230
MissingOverride The method 'handleEvent(SVNEvent, double)' is missing an @Override annotation. 227230
ShortVariable Avoid variables with short names like sw 245
ShortVariable Avoid variables with short names like pw 246
UnusedLocalVariable Avoid unused local variables such as 'errorLog'. 249
EmptyCatchBlock Avoid empty catch blocks 258262
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 269
ShortVariable Avoid variables with short names like sw 273
ShortVariable Avoid variables with short names like pw 274
UnusedLocalVariable Avoid unused local variables such as 'errorLog'. 277
EmptyCatchBlock Avoid empty catch blocks 286290
MissingOverride The method 'handleDirEntry(SVNDirEntry)' is missing an @Override annotation. 321331
CommentRequired Public method and constructor comments are required 321331
CollapsibleIfStatements These nested if statements could be combined 326329
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 350
UseObjectForClearerAPI Rather than using a lot of String arguments, consider using a container object for those values. 413

fr/paris/lutece/plugins/releaser/util/version/Version.java

Rule Violation Ligne
GodClass Possible God Class (WMC=47, ATFD=10, TCC=30.333%) 47542
UncommentedEmptyConstructor Document empty constructor 8688
ConfusingTernary Avoid if (x != y) ..; else ..; 238245
ConfusingTernary Avoid if (x != y) ..; else ..; 277
ConfusingTernary Avoid if (x != y) ..; else ..; 297308
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 310
AvoidDuplicateLiterals The String literal " : " appears 5 times in this file; the first occurrence is on line 440 440
AvoidDuplicateLiterals The String literal "Error parsing version " appears 5 times in this file; the first occurrence is on line 440 440

fr/paris/lutece/plugins/releaser/util/version/VersionParsingException.java

Rule Violation Ligne
MissingSerialVersionUID Classes implementing Serializable should set a serialVersionUID 4055

fr/paris/lutece/plugins/releaser/web/ClusterJspBean.java

Rule Violation Ligne
MissingSerialVersionUID Classes implementing Serializable should set a serialVersionUID 70615
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 165
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 166
ConfusingTernary Avoid if (x != y) ..; else ..; 207
ConfusingTernary Avoid if (x != y) ..; else ..; 449

fr/paris/lutece/plugins/releaser/web/ManageComponentReleaseJspBean.java

Rule Violation Ligne
MissingSerialVersionUID Classes implementing Serializable should set a serialVersionUID 65323
DefaultPackage Use explicit scoping instead of the default package private level 126
CommentDefaultAccessModifier To avoid mistakes add a comment at the beginning of the _paginatorComponents field if you want a default access modifier 126
CyclomaticComplexity The method 'getManageComponent(HttpServletRequest)' has a cyclomatic complexity of 12. 137180
UnusedLocalVariable Avoid unused local variables such as 'user'. 145
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 145
ConfusingTernary Avoid if (x != y) ..; else ..; 147170
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 168
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 169
ConfusingTernary Avoid if (x != y) ..; else ..; 174
ConfusingTernary Avoid if (x != y) ..; else ..; 176
UnnecessaryAnnotationValueElement Avoid the use of value in annotations when its the only element 254
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 262
UnusedLocalVariable Avoid unused local variables such as 'component'. 262
UnusedLocalVariable Avoid unused local variables such as 'component'. 284
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 284
LinguisticNaming Linguistics Antipattern - The setter 'setReleaserUser' should not return any type except void linguistically 289302

fr/paris/lutece/plugins/releaser/web/ManageSiteReleaseJspBean.java

Rule Violation Ligne
ExcessiveImports A high number of imports can indicate a high degree of coupling within an object. 34701
MissingSerialVersionUID Classes implementing Serializable should set a serialVersionUID 74701
TooManyMethods This class has too many methods, consider refactoring it. 75701
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 217
UnnecessaryAnnotationValueElement Avoid the use of value in annotations when its the only element 266
NPathComplexity The method 'getConfirmReleaseSite(HttpServletRequest)' has an NPath complexity of 324 267313
CyclomaticComplexity The method 'getConfirmReleaseSite(HttpServletRequest)' has a cyclomatic complexity of 11. 267313
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 272
UnnecessaryAnnotationValueElement Avoid the use of value in annotations when its the only element 322
UnnecessaryAnnotationValueElement Avoid the use of value in annotations when its the only element 349
ConfusingTernary Avoid if (x != y) ..; else ..; 357376
ConfusingTernary Avoid if (x != y) ..; else ..; 361370
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 505
UnnecessaryAnnotationValueElement Avoid the use of value in annotations when its the only element 562
UnnecessaryLocalBeforeReturn Consider simply returning the value vs storing it in local variable 'strTemplate' 575
UnnecessaryAnnotationValueElement Avoid the use of value in annotations when its the only element 633
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 641
UnusedLocalVariable Avoid unused local variables such as 'component'. 641
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 662
UnusedLocalVariable Avoid unused local variables such as 'component'. 662
LinguisticNaming Linguistics Antipattern - The setter 'setReleaserUser' should not return any type except void linguistically 668681

fr/paris/lutece/plugins/releaser/web/ManageSitesJspBean.java

Rule Violation Ligne
MissingSerialVersionUID Classes implementing Serializable should set a serialVersionUID 4999
SingularField Perhaps '_nDefaultItemsPerPage' could be replaced by a local variable. 62

Priority 4

fr/paris/lutece/plugins/releaser/business/Component.java

Rule Violation Ligne
UnusedImports Avoid unused imports such as 'fr.paris.lutece.plugins.releaser.util.github.GitUtils' 39

fr/paris/lutece/plugins/releaser/business/IReleaserResource.java

Rule Violation Ligne
UnusedImports Avoid unused imports such as 'org.apache.commons.lang3.StringUtils' 36

fr/paris/lutece/plugins/releaser/business/IWorkflowContextHistoryDAO.java

Rule Violation Ligne
UnusedImports Avoid unused imports such as 'fr.paris.lutece.util.ReferenceList' 72

fr/paris/lutece/plugins/releaser/business/Site.java

Rule Violation Ligne
ShortClassName Avoid short class names like Site 51612

fr/paris/lutece/plugins/releaser/business/WorkflowContextHistoryDAO.java

Rule Violation Ligne
UnusedImports Avoid unused imports such as 'fr.paris.lutece.util.ReferenceList' 72

fr/paris/lutece/plugins/releaser/business/WorkflowContextHistoryHome.java

Rule Violation Ligne
UnusedImports Avoid unused imports such as 'fr.paris.lutece.util.ReferenceList' 73

fr/paris/lutece/plugins/releaser/service/IComponentService.java

Rule Violation Ligne
UnusedImports Avoid unused imports such as 'fr.paris.lutece.plugins.releaser.business.Site' 44

fr/paris/lutece/plugins/releaser/service/JiraComponentService.java

Rule Violation Ligne
UnusedImports Avoid unused imports such as 'com.atlassian.jira.rest.client.api.domain.IssueField' 51

fr/paris/lutece/plugins/releaser/service/MavenService.java

Rule Violation Ligne
UnusedImports Avoid unused imports such as 'fr.paris.lutece.util.string.StringUtil' 56

fr/paris/lutece/plugins/releaser/service/SiteService.java

Rule Violation Ligne
UnusedImports Avoid unused imports such as 'fr.paris.lutece.portal.service.plugin.Plugin' 72

fr/paris/lutece/plugins/releaser/service/svn/SvnResourceService.java

Rule Violation Ligne
UnusedImports Avoid unused imports such as 'java.io.IOException' 37
UnusedImports Avoid unused imports such as 'java.io.PrintWriter' 38
UnusedImports Avoid unused imports such as 'java.io.StringWriter' 39
UnusedImports Avoid unused imports such as 'org.apache.commons.lang3.ObjectUtils' 44
UnusedImports Avoid unused imports such as 'org.apache.commons.lang3.StringUtils' 45
UnusedImports Avoid unused imports such as 'org.tmatesoft.svn.core.SVNCancelException' 46
UnusedImports Avoid unused imports such as 'org.tmatesoft.svn.core.SVNException' 47
UnusedImports Avoid unused imports such as 'org.tmatesoft.svn.core.wc.ISVNEventHandler' 49
UnusedImports Avoid unused imports such as 'org.tmatesoft.svn.core.wc.SVNEvent' 50
UnusedImports Avoid unused imports such as 'org.tmatesoft.svn.core.wc.SVNEventAction' 51
UnusedImports Avoid unused imports such as 'fr.paris.lutece.plugins.releaser.business.RepositoryType' 54
UnusedImports Avoid unused imports such as 'fr.paris.lutece.plugins.releaser.util.svn.ReleaseSvnCopyClient' 65

fr/paris/lutece/plugins/releaser/util/PluginUtils.java

Rule Violation Ligne
UnusedImports Avoid unused imports such as 'javax.xml.parsers.ParserConfigurationException' 48
UnusedImports Avoid unused imports such as 'javax.xml.transform.TransformerException' 50
UnusedImports Avoid unused imports such as 'org.eclipse.jgit.api.errors.NoFilepatternException' 55
UnusedImports Avoid unused imports such as 'org.xml.sax.SAXException' 59

fr/paris/lutece/plugins/releaser/util/pom/PomParser.java

Rule Violation Ligne
UnusedImports Avoid unused imports such as 'java.io.FileInputStream' 36
UnusedImports Avoid unused imports such as 'java.io.FileNotFoundException' 37
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'fr.paris.lutece.plugins.releaser.business.jaxb.maven.Model.Dependencies' due to existing import 'fr.paris.lutece.plugins.releaser.business.jaxb.maven.Model' 95

fr/paris/lutece/plugins/releaser/util/pom/PomUpdater.java

Rule Violation Ligne
UnusedImports Avoid unused imports such as 'java.util.Iterator' 42
UnusedImports Avoid unused imports such as 'fr.paris.lutece.portal.service.i18n.I18nService' 56
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'fr.paris.lutece.plugins.releaser.business.jaxb.maven.Model.Dependencies' due to existing import 'fr.paris.lutece.plugins.releaser.business.jaxb.maven.Model' 92
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'fr.paris.lutece.plugins.releaser.business.jaxb.maven.Model.Dependencies' due to existing import 'fr.paris.lutece.plugins.releaser.business.jaxb.maven.Model' 178

fr/paris/lutece/plugins/releaser/web/ManageSiteReleaseJspBean.java

Rule Violation Ligne
UnusedImports Avoid unused imports such as 'fr.paris.lutece.portal.service.i18n.I18nService' 49

Fichiers

fr/paris/lutece/plugins/releaser/business/AbstractReleaserResource.java

Rule Violation Priority Ligne
ConfusingTernary Avoid if (x != y) ..; else ..; 3 5775
ConfusingTernary Avoid if (x != y) ..; else ..; 3 100107
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 3 115

fr/paris/lutece/plugins/releaser/business/Cluster.java

Rule Violation Priority Ligne
FieldNamingConventions The field name 'permissions' doesn't match '_[a-z][a-zA-Z0-9]*' 1 59
LooseCoupling Avoid using implementation types like 'HashMap'; use the interface instead 3 59
LooseCoupling Avoid using implementation types like 'HashMap'; use the interface instead 3 170
LooseCoupling Avoid using implementation types like 'HashMap'; use the interface instead 3 175

fr/paris/lutece/plugins/releaser/business/ClusterDAO.java

Rule Violation Priority Ligne
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 3 158
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 3 184

fr/paris/lutece/plugins/releaser/business/Component.java

Rule Violation Priority Ligne
ExcessivePublicCount This class has a bunch of public methods and attributes 3 34721
UnusedImports Avoid unused imports such as 'fr.paris.lutece.plugins.releaser.util.github.GitUtils' 4 39
TooManyFields Too many fields 3 47721
LooseCoupling Avoid using implementation types like 'HashMap'; use the interface instead 3 54
FieldNamingConventions The field name 'permissions' doesn't match '_[a-z][a-zA-Z0-9]*' 1 54
UnusedPrivateField Avoid unused private fields such as '_strDescription'. 3 82
MissingOverride The method 'getArtifactId()' is missing an @Override annotation. 3 143146
MissingOverride The method 'getTargetVersion()' is missing an @Override annotation. 3 227230
SimplifyBooleanReturns Avoid unnecessary if..then..else statements when returning booleans 3 440444
FormalParameterNamingConventions The method parameter name '_strScmDeveloperConnection' doesn't match '[a-z][a-zA-Z0-9]*' 1 464
FormalParameterNamingConventions The method parameter name '_bUpgrade' doesn't match '[a-z][a-zA-Z0-9]*' 1 495
FormalParameterNamingConventions The method parameter name '_bDowngrade' doesn't match '[a-z][a-zA-Z0-9]*' 1 516
FormalParameterNamingConventions The method parameter name '_strLastAvailableSnapshotVersion' doesn't match '[a-z][a-zA-Z0-9]*' 1 547
FormalParameterNamingConventions The method parameter name '_bErrorLastRelease' doesn't match '[a-z][a-zA-Z0-9]*' 1 568
FormalParameterNamingConventions The method parameter name '_strName' doesn't match '[a-z][a-zA-Z0-9]*' 1 589
FormalParameterNamingConventions The method parameter name '_strCloneUrl' doesn't match '[a-z][a-zA-Z0-9]*' 1 610
FormalParameterNamingConventions The method parameter name '_strTweetMessage' doesn't match '[a-z][a-zA-Z0-9]*' 1 652
LooseCoupling Avoid using implementation types like 'HashMap'; use the interface instead 3 681
LooseCoupling Avoid using implementation types like 'HashMap'; use the interface instead 3 686
CommentRequired Public method and constructor comments are required 3 691694
CommentRequired Public method and constructor comments are required 3 696699
CommentRequired Public method and constructor comments are required 3 701704
FormalParameterNamingConventions The method parameter name '_strBranchReleaseFrom' doesn't match '[a-z][a-zA-Z0-9]*' 1 706
CommentRequired Public method and constructor comments are required 3 706709
CommentRequired Public method and constructor comments are required 3 711714
FormalParameterNamingConventions The method parameter name '_strBranchReleaseVersion' doesn't match '[a-z][a-zA-Z0-9]*' 1 716
CommentRequired Public method and constructor comments are required 3 716719

fr/paris/lutece/plugins/releaser/business/IReleaserResource.java

Rule Violation Priority Ligne
UnusedImports Avoid unused imports such as 'org.apache.commons.lang3.StringUtils' 4 36

fr/paris/lutece/plugins/releaser/business/IWorkflowContextHistoryDAO.java

Rule Violation Priority Ligne
UnusedImports Avoid unused imports such as 'fr.paris.lutece.util.ReferenceList' 4 72

fr/paris/lutece/plugins/releaser/business/ReleaserUser.java

Rule Violation Priority Ligne
LooseCoupling Avoid using implementation types like 'HashMap'; use the interface instead 3 54
ImmutableField Private field '_mapCredential' could be made final; it is only initialized in the declaration or constructor. 3 54
ImmutableField Private field '_strLogin' could be made final; it is only initialized in the declaration or constructor. 3 115
FieldDeclarationsShouldBeAtStartOfClass Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. 3 115
ImmutableField Private field '_strPassword' could be made final; it is only initialized in the declaration or constructor. 3 118
FieldDeclarationsShouldBeAtStartOfClass Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. 3 118

fr/paris/lutece/plugins/releaser/business/Site.java

Rule Violation Priority Ligne
ExcessivePublicCount This class has a bunch of public methods and attributes 3 34612
ShortClassName Avoid short class names like Site 4 51612
TooManyFields Too many fields 3 51612
LooseCoupling Avoid using implementation types like 'HashMap'; use the interface instead 3 62
FieldNamingConventions The field name 'permissions' doesn't match '_[a-z][a-zA-Z0-9]*' 1 62
ImmutableField Private field '_listCurrentDependencies' could be made final; it is only initialized in the declaration or constructor. 3 106
ImmutableField Private field '_listComponents' could be made final; it is only initialized in the declaration or constructor. 3 109
MissingOverride The method 'getArtifactId()' is missing an @Override annotation. 3 167170
MissingOverride The method 'getScmUrl()' is missing an @Override annotation. 3 209212
FormalParameterNamingConventions The method parameter name '_strTagInfotmation' doesn't match '[a-z][a-zA-Z0-9]*' 1 493
FormalParameterNamingConventions The method parameter name '_strGroupId' doesn't match '[a-z][a-zA-Z0-9]*' 1 514
FormalParameterNamingConventions The method parameter name '_bTheme' doesn't match '[a-z][a-zA-Z0-9]*' 1 535
CommentRequired Public method and constructor comments are required 3 540543
CommentRequired Public method and constructor comments are required 3 545548
CommentRequired Public method and constructor comments are required 3 550553
FormalParameterNamingConventions The method parameter name '_strBranchReleaseFrom' doesn't match '[a-z][a-zA-Z0-9]*' 1 555
CommentRequired Public method and constructor comments are required 3 555558
LooseCoupling Avoid using implementation types like 'HashMap'; use the interface instead 3 594
LooseCoupling Avoid using implementation types like 'HashMap'; use the interface instead 3 599
ControlStatementBraces This statement should have braces 3 602
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 3 602
ControlStatementBraces This statement should have braces 3 604

fr/paris/lutece/plugins/releaser/business/SiteDAO.java

Rule Violation Priority Ligne
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 3 182
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 3 214
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 3 252
UnusedLocalVariable Avoid unused local variables such as 'nIndex'. 3 294
ControlStatementBraces This statement should have braces 3 296

fr/paris/lutece/plugins/releaser/business/WorkflowContextHistory.java

Rule Violation Priority Ligne
FormalParameterNamingConventions The method parameter name '_dateBegin' doesn't match '[a-z][a-zA-Z0-9]*' 1 181
FormalParameterNamingConventions The method parameter name '_dateEnd' doesn't match '[a-z][a-zA-Z0-9]*' 1 202
FormalParameterNamingConventions The method parameter name '_strArtifactId' doesn't match '[a-z][a-zA-Z0-9]*' 1 223

fr/paris/lutece/plugins/releaser/business/WorkflowContextHistoryDAO.java

Rule Violation Priority Ligne
UnusedImports Avoid unused imports such as 'fr.paris.lutece.util.ReferenceList' 4 72

fr/paris/lutece/plugins/releaser/business/WorkflowContextHistoryHome.java

Rule Violation Priority Ligne
UnusedImports Avoid unused imports such as 'fr.paris.lutece.util.ReferenceList' 4 73

fr/paris/lutece/plugins/releaser/business/WorkflowReleaseContext.java

Rule Violation Priority Ligne
FormalParameterNamingConventions The method parameter name '_nId' doesn't match '[a-z][a-zA-Z0-9]*' 1 98
FormalParameterNamingConventions The method parameter name '_component' doesn't match '[a-z][a-zA-Z0-9]*' 1 119
FormalParameterNamingConventions The method parameter name '_commandResult' doesn't match '[a-z][a-zA-Z0-9]*' 1 140
FormalParameterNamingConventions The method parameter name '_releaserUser' doesn't match '[a-z][a-zA-Z0-9]*' 1 194
FormalParameterNamingConventions The method parameter name '_strRefBranchRelease' doesn't match '[a-z][a-zA-Z0-9]*' 1 215
FormalParameterNamingConventions The method parameter name '_strRefBranchReleaseFrom' doesn't match '[a-z][a-zA-Z0-9]*' 1 236

fr/paris/lutece/plugins/releaser/service/ClusterResourceIdService.java

Rule Violation Priority Ligne
DataClass The class 'ClusterResourceIdService' is suspected to be a Data Class (WOC=0.000%, NOPA=4, NOAM=0, WMC=1) 3 48147
CommentRequired Header comments are required 3 48147
CallSuperInConstructor It is a good practice to call super() in a constructor 3 7174
ShortVariable Avoid variables with short names like rt 3 80
ShortVariable Avoid variables with short names like p 3 86

fr/paris/lutece/plugins/releaser/service/ClusterService.java

Rule Violation Priority Ligne
UseUtilityClass All methods are static. Consider using a utility class instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning. 3 51169
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 3 82
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 3 86
ControlStatementBraces This statement should have braces 3 140
CommentRequired Public method and constructor comments are required 3 146155
MethodNamingConventions The static method name 'IsAddClusterAuthorized' doesn't match '[a-z][a-zA-Z0-9]*' 1 146155
SimplifyBooleanReturns Avoid unnecessary if..then..else statements when returning booleans 3 149152
CommentRequired Public method and constructor comments are required 3 157168
MethodNamingConventions The static method name 'IsUserAuthorized' doesn't match '[a-z][a-zA-Z0-9]*' 1 157168

fr/paris/lutece/plugins/releaser/service/ComponentResourceIdService.java

Rule Violation Priority Ligne
CommentRequired Header comments are required 3 4595
CallSuperInConstructor It is a good practice to call super() in a constructor 3 5659
ShortVariable Avoid variables with short names like rt 3 65
ShortVariable Avoid variables with short names like p 3 71

fr/paris/lutece/plugins/releaser/service/ComponentService.java

Rule Violation Priority Ligne
ExcessiveImports A high number of imports can indicate a high degree of coupling within an object. 3 34579
GodClass Possible God Class (WMC=50, ATFD=64, TCC=0.526%) 3 84579
UnusedPrivateField Avoid unused private fields such as '_executor'. 3 86
SingularField Perhaps '_executor' could be replaced by a local variable. 3 86
NonThreadSafeSingleton Singleton is not thread safe 3 109113
NPathComplexity The method 'setRemoteInformations(Component, boolean)' has an NPath complexity of 517 3 119169
CommentRequired Public method and constructor comments are required 3 119169
CyclomaticComplexity The method 'setRemoteInformations(Component, boolean)' has a cyclomatic complexity of 14. 3 119169
MissingOverride The method 'setRemoteInformations(Component, boolean)' is missing an @Override annotation. 3 119169
AvoidDeeplyNestedIfStmts Deeply nested if..then statements are hard to read 3 138141
ConfusingTernary Avoid if (x != y) ..; else ..; 3 150
ConfusingTernary Avoid if (x != y) ..; else ..; 3 151
ConfusingTernary Avoid if (x != y) ..; else ..; 3 152
ConfusingTernary Avoid if (x != y) ..; else ..; 3 153
ConfusingTernary Avoid if (x != y) ..; else ..; 3 154
AvoidDeeplyNestedIfStmts Deeply nested if..then statements are hard to read 3 156160
MissingOverride The method 'getLastReleaseVersion(String)' is missing an @Override annotation. 3 176181
MissingOverride The method 'setLastReleaseVersion(String, String)' is missing an @Override annotation. 3 188193
MissingOverride The method 'getLastReleaseNextSnapshotVersion(String)' is missing an @Override annotation. 3 200205
MissingOverride The method 'setLastReleaseNextSnapshotVersion(String, String)' is missing an @Override annotation. 3 212216
CommentRequired Public method and constructor comments are required 3 242245
MissingOverride The method 'release(Component, Locale, AdminUser, HttpServletRequest)' is missing an @Override annotation. 3 242245
CommentRequired Public method and constructor comments are required 3 247251
MissingOverride The method 'isGitComponent(Component)' is missing an @Override annotation. 3 247251
MissingOverride The method 'init()' is missing an @Override annotation. 3 253259
CommentRequired Public method and constructor comments are required 3 253259
CyclomaticComplexity The method 'updateRemoteInformations(Component)' has a cyclomatic complexity of 11. 3 262310
CommentRequired Public method and constructor comments are required 3 312345
MissingOverride The method 'getSearchComponent(String, HttpServletRequest, Locale, String, String)' is missing an @Override annotation. 3 312345
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 3 327
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 3 341342
UnusedFormalParameter Avoid unused method parameters such as 'strPassword'. 3 347
UnusedFormalParameter Avoid unused method parameters such as 'strUser'. 3 347
AvoidReassigningParameters Avoid reassigning parameters such as 'component' 2 370
AvoidReassigningParameters Avoid reassigning parameters such as 'component' 2 370
MissingOverride The method 'loadComponent(Component, String, String, String)' is missing an @Override annotation. 3 370400
CommentRequired Public method and constructor comments are required 3 370400
MissingOverride The method 'isErrorSnapshotComponentInformations(Component, String)' is missing an @Override annotation. 3 426456
CommentRequired Public method and constructor comments are required 3 426456
AvoidFileStream Avoid instantiating FileInputStream, FileOutputStream, FileReader, or FileWriter 1 437
MissingOverride The method 'changeNextReleaseVersion(Component)' is missing an @Override annotation. 3 464476
MethodNamingConventions The static method name 'IsSearchComponentAuthorized' doesn't match '[a-z][a-zA-Z0-9]*' 1 478487
CommentRequired Public method and constructor comments are required 3 478487
SimplifyBooleanReturns Avoid unnecessary if..then..else statements when returning booleans 3 481484
CommentRequired Public method and constructor comments are required 3 530577
MissingOverride The method 'getLastBranchVersion(Component, String, ReleaserUser)' is missing an @Override annotation. 3 530577
AvoidReassigningParameters Avoid reassigning parameters such as 'component' 2 530

fr/paris/lutece/plugins/releaser/service/GetRemoteInformationsTask.java

Rule Violation Priority Ligne
DoNotUseThreads To be compliant to J2EE, a webapp should not use any thread. 3 46
ImmutableField Private field '_component' could be made final; it is only initialized in the declaration or constructor. 3 49

fr/paris/lutece/plugins/releaser/service/IComponentService.java

Rule Violation Priority Ligne
UnusedImports Avoid unused imports such as 'fr.paris.lutece.plugins.releaser.business.Site' 4 44
CommentRequired Public method and constructor comments are required 3 231

fr/paris/lutece/plugins/releaser/service/IJiraService.java

Rule Violation Priority Ligne
UnnecessaryModifier Unnecessary modifiers 'public abstract' on method 'init': the method is declared in an interface type 3 48
UnnecessaryModifier Unnecessary modifiers 'public abstract' on method 'updateComponentVersions': the method is declared in an interface type 3 58

fr/paris/lutece/plugins/releaser/service/IMavenService.java

Rule Violation Priority Ligne
UseObjectForClearerAPI Rather than using a lot of String arguments, consider using a container object for those values. 3 8182

fr/paris/lutece/plugins/releaser/service/IWorkflowReleaseContextService.java

Rule Violation Priority Ligne
TooManyMethods This class has too many methods, consider refactoring it. 3 49221

fr/paris/lutece/plugins/releaser/service/JiraComponentService.java

Rule Violation Priority Ligne
ExcessiveImports A high number of imports can indicate a high degree of coupling within an object. 3 34286
UnusedImports Avoid unused imports such as 'com.atlassian.jira.rest.client.api.domain.IssueField' 4 51
FieldNamingConventions The static field name 'URL_JIRA_SERVER' doesn't match '_[a-z][a-zA-Z0-9]*' 1 87
FieldNamingConventions The static field name 'JIRA_USER' doesn't match '_[a-z][a-zA-Z0-9]*' 1 90
FieldNamingConventions The static field name 'JIRA_USER_PWD' doesn't match '_[a-z][a-zA-Z0-9]*' 1 93
UnnecessaryConstructor Avoid unnecessary constructors - the compiler will generate these for you 3 110113
UncommentedEmptyConstructor Document empty constructor 3 110113
NonThreadSafeSingleton Singleton is not thread safe 3 122126
CyclomaticComplexity The method 'updateComponentVersions(Component, CommandResult)' has a cyclomatic complexity of 12. 3 185284
AvoidSynchronizedAtMethodLevel Use block level rather than method level synchronization 3 185284
ConfusingTernary Avoid if (x != y) ..; else ..; 3 191282
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 3 229
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 3 230
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 3 230
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 3 259

fr/paris/lutece/plugins/releaser/service/MavenService.java

Rule Violation Priority Ligne
UnusedImports Avoid unused imports such as 'fr.paris.lutece.util.string.StringUtil' 4 56
ClassWithOnlyPrivateConstructorsShouldBeFinal A class which only has private constructors should be final 1 62291
NonThreadSafeSingleton Singleton is not thread safe 3 8791
MissingOverride The method 'init()' is missing an @Override annotation. 3 100106
MissingOverride The method 'mvnSiteAssembly(String, String, String, SvnUser, CommandResult)' is missing an @Override annotation. 3 128138
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 3 133
AvoidSynchronizedAtMethodLevel Use block level rather than method level synchronization 3 176224
AddEmptyString Do not add empty strings 3 195
CommentRequired Public method and constructor comments are required 3 206209
MissingOverride The method 'consumeLine(String)' is missing an @Override annotation. 3 206209
InefficientStringBuffering Avoid concatenating nonliterals in a StringBuffer/StringBuilder constructor or append(). 3 208
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 3 217
MissingOverride The method 'mvnReleasePerform(String, String, String, CommandResult, boolean)' is missing an @Override annotation. 3 239253
SystemPrintln System.out.println is used 2 246
UseObjectForClearerAPI Rather than using a lot of String arguments, consider using a container object for those values. 3 274275
MissingOverride The method 'mvnReleasePrepare(String, String, String, String, String, String, CommandResult)' is missing an @Override annotation. 3 274289

fr/paris/lutece/plugins/releaser/service/ReleaseComponentTask.java

Rule Violation Priority Ligne
DoNotUseThreads To be compliant to J2EE, a webapp should not use any thread. 3 59
ImmutableField Private field '_nIdWorkflow' could be made final; it is only initialized in the declaration or constructor. 3 66
ImmutableField Private field '_wfContext' could be made final; it is only initialized in the declaration or constructor. 3 69
ImmutableField Private field '_request' could be made final; it is only initialized in the declaration or constructor. 3 72
ImmutableField Private field '_user' could be made final; it is only initialized in the declaration or constructor. 3 75
ImmutableField Private field '_locale' could be made final; it is only initialized in the declaration or constructor. 3 78
MissingOverride The method 'run()' is missing an @Override annotation. 3 107178
UnusedLocalVariable Avoid unused local variables such as 'state'. 3 110
AvoidBranchingStatementAsLastInLoop Avoid using a branching statement as the last in a loop. 2 160

fr/paris/lutece/plugins/releaser/service/SiteResourceIdService.java

Rule Violation Priority Ligne
CallSuperInConstructor It is a good practice to call super() in a constructor 3 7275
ShortVariable Avoid variables with short names like rt 3 80
ShortVariable Avoid variables with short names like p 3 86

fr/paris/lutece/plugins/releaser/service/SiteService.java

Rule Violation Priority Ligne
ExcessiveImports A high number of imports can indicate a high degree of coupling within an object. 3 34873
UnusedImports Avoid unused imports such as 'fr.paris.lutece.portal.service.plugin.Plugin' 4 72
GodClass Possible God Class (WMC=95, ATFD=142, TCC=0.000%) 3 83873
CyclomaticComplexity The class 'SiteService' has a total cyclomatic complexity of 95 (highest 14). 3 83873
TooManyMethods This class has too many methods, consider refactoring it. 3 84873
ConfusingTernary Avoid if (x != y) ..; else ..; 3 127143
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 3 227
IdenticalCatchBranches 'catch' branch identical to 'InterruptedException' branch 3 246250
BooleanInstantiation Avoid instantiating Boolean objects; reference Boolean.TRUE or Boolean.FALSE or call Boolean.valueOf() instead. 2 339
CyclomaticComplexity The method 'buildReleaseComments(Component, Locale)' has a cyclomatic complexity of 14. 3 428501
ConfusingTernary Avoid if (x != y) ..; else ..; 3 439500
ConfusingTernary Avoid if (x != y) ..; else ..; 3 472488
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 3 630
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 3 630
AvoidFileStream Avoid instantiating FileInputStream, FileOutputStream, FileReader, or FileWriter 1 764
IdenticalCatchBranches 'catch' branch identical to 'FileNotFoundException' branch 3 781785
CommentRequired Public method and constructor comments are required 3 790849
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 3 793
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 3 802
CommentRequired Public method and constructor comments are required 3 851862
MethodNamingConventions The static method name 'IsUserAuthorized' doesn't match '[a-z][a-zA-Z0-9]*' 1 851862
CommentRequired Public method and constructor comments are required 3 864871
MethodNamingConventions The static method name 'IsSiteAlreadyExist' doesn't match '[a-z][a-zA-Z0-9]*' 1 864871
SimplifyBooleanReturns Avoid unnecessary if..then..else statements when returning booleans 3 867868
ControlStatementBraces This statement should have braces 3 868

fr/paris/lutece/plugins/releaser/service/TwitterService.java

Rule Violation Priority Ligne
RedundantFieldInitializer Avoid using redundant field initializer for '_twitter' 3 89
RedundantFieldInitializer Avoid using redundant field initializer for '_instance' 3 92
NonThreadSafeSingleton Singleton is not thread safe 3 101105
UnnecessaryConstructor Avoid unnecessary constructors - the compiler will generate these for you 3 113116
MissingOverride The method 'sendTweet(String, CommandResult)' is missing an @Override annotation. 3 126144
MissingOverride The method 'init()' is missing an @Override annotation. 3 149167

fr/paris/lutece/plugins/releaser/service/WorkflowReleaseContextService.java

Rule Violation Priority Ligne
ExcessiveImports A high number of imports can indicate a high degree of coupling within an object. 3 34870
GodClass Possible God Class (WMC=62, ATFD=100, TCC=2.632%) 3 83870
TooManyMethods This class has too many methods, consider refactoring it. 3 84870
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 3 90
LooseCoupling Avoid using implementation types like 'HashMap'; use the interface instead 3 90
ImmutableField Private field '_mapWorkflowReleaseContext' could be made final; it is only initialized in the declaration or constructor. 3 90
LooseCoupling Avoid using implementation types like 'HashSet'; use the interface instead 3 96
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 3 96
ImmutableField Private field '_releaseInProgress' could be made final; it is only initialized in the declaration or constructor. 3 96
AvoidSynchronizedAtMethodLevel Use block level rather than method level synchronization 3 112134
ConfusingTernary Avoid if (x != y) ..; else ..; 3 122
MissingOverride The method 'saveWorkflowReleaseContext(WorkflowReleaseContext)' is missing an @Override annotation. 3 160198
AvoidSynchronizedAtMethodLevel Use block level rather than method level synchronization 3 160198
ConfusingTernary Avoid if (x != y) ..; else ..; 3 170191
ConfusingTernary Avoid if (x != y) ..; else ..; 3 187
MissingOverride The method 'getListWorkflowReleaseContextHistory(String)' is missing an @Override annotation. 3 232261
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 3 235
MissingOverride The method 'getIdWorkflow(WorkflowReleaseContext)' is missing an @Override annotation. 3 270286
NonThreadSafeSingleton Singleton is not thread safe 3 295300
MissingOverride The method 'mergeDevelopMaster(WorkflowReleaseContext, Locale)' is missing an @Override annotation. 3 313411
CyclomaticComplexity The method 'mergeDevelopMaster(WorkflowReleaseContext, Locale)' has a cyclomatic complexity of 14. 3 313411
ConfusingTernary Avoid if (x != y) ..; else ..; 3 335371
IdenticalCatchBranches 'catch' branch identical to 'InvalidRemoteException' branch 3 380384
IdenticalCatchBranches 'catch' branch identical to 'InvalidRemoteException' branch 3 385388
IdenticalCatchBranches 'catch' branch identical to 'InvalidRemoteException' branch 3 389392
ExcessiveMethodLength Avoid really long methods. 3 421579
NcssCount The method 'releasePrepareComponent(WorkflowReleaseContext, Locale)' has a NCSS line count of 71. 3 421579
CyclomaticComplexity The method 'releasePrepareComponent(WorkflowReleaseContext, Locale)' has a cyclomatic complexity of 13. 3 421579
MissingOverride The method 'releasePrepareComponent(WorkflowReleaseContext, Locale)' is missing an @Override annotation. 3 421579
AvoidDuplicateLiterals The String literal " to " appears 4 times in this file; the first occurrence is on line 462 3 462
MissingOverride The method 'releasePerformComponent(WorkflowReleaseContext, Locale)' is missing an @Override annotation. 3 589619
AvoidDuplicateLiterals The String literal " Release Perform" appears 4 times in this file; the first occurrence is on line 597 3 597
MissingOverride The method 'checkoutRepository(WorkflowReleaseContext, Locale)' is missing an @Override annotation. 3 629642
MissingOverride The method 'releasePrepareSite(WorkflowReleaseContext, Locale)' is missing an @Override annotation. 3 652716
AvoidDuplicateLiterals The String literal "...\n" appears 4 times in this file; the first occurrence is on line 665 3 665
MissingOverride The method 'sendTweet(WorkflowReleaseContext, Locale)' is missing an @Override annotation. 3 726737
MissingOverride The method 'updateJiraVersions(WorkflowReleaseContext, Locale)' is missing an @Override annotation. 3 747758
MissingOverride The method 'startWorkflowReleaseContext(WorkflowReleaseContext, int, Locale, HttpServletRequest, AdminUser)' is missing an @Override annotation. 3 774777
MissingOverride The method 'init()' is missing an @Override annotation. 3 782787
MissingOverride The method 'startReleaseInProgress(String)' is missing an @Override annotation. 3 795799
MissingOverride The method 'stopReleaseInProgress(String)' is missing an @Override annotation. 3 807811
MissingOverride The method 'isReleaseInProgress(String)' is missing an @Override annotation. 3 820824

fr/paris/lutece/plugins/releaser/service/github/GitResourceService.java

Rule Violation Priority Ligne
MissingOverride The method 'fetchPom(Site, String, String)' is missing an @Override annotation. 3 8598
MissingOverride The method 'getLastRelease(Site, String, String)' is missing an @Override annotation. 3 111138
CyclomaticComplexity The method 'doCheckoutRepository(WorkflowReleaseContext, String, String)' has a cyclomatic complexity of 11. 3 152240
ConfusingTernary Avoid if (x != y) ..; else ..; 3 187198
AvoidDuplicateLiterals The String literal "/.git" appears 4 times in this file; the first occurrence is on line 283 3 283
IdenticalCatchBranches 'catch' branch identical to 'InvalidRemoteException' branch 3 297301
IdenticalCatchBranches 'catch' branch identical to 'InvalidRemoteException' branch 3 302305
IdenticalCatchBranches 'catch' branch identical to 'InvalidRemoteException' branch 3 306309
IdenticalCatchBranches 'catch' branch identical to 'InvalidRemoteException' branch 3 368372
IdenticalCatchBranches 'catch' branch identical to 'InvalidRemoteException' branch 3 373376
IdenticalCatchBranches 'catch' branch identical to 'InvalidRemoteException' branch 3 377380
CyclomaticComplexity The method 'rollbackRelease(WorkflowReleaseContext, Locale)' has a cyclomatic complexity of 15. 3 411526
ExcessiveMethodLength Avoid really long methods. 3 411526
ConfusingTernary Avoid if (x != y) ..; else ..; 3 459466
IdenticalCatchBranches 'catch' branch identical to 'InvalidRemoteException' branch 3 493497
IdenticalCatchBranches 'catch' branch identical to 'InvalidRemoteException' branch 3 498501
IdenticalCatchBranches 'catch' branch identical to 'InvalidRemoteException' branch 3 502505
IdenticalCatchBranches 'catch' branch identical to 'InvalidRemoteException' branch 3 582586
IdenticalCatchBranches 'catch' branch identical to 'InvalidRemoteException' branch 3 587590
IdenticalCatchBranches 'catch' branch identical to 'InvalidRemoteException' branch 3 591594

fr/paris/lutece/plugins/releaser/service/svn/SvnResourceService.java

Rule Violation Priority Ligne
ExcessiveImports A high number of imports can indicate a high degree of coupling within an object. 3 34412
UnusedImports Avoid unused imports such as 'java.io.IOException' 4 37
UnusedImports Avoid unused imports such as 'java.io.PrintWriter' 4 38
UnusedImports Avoid unused imports such as 'java.io.StringWriter' 4 39
UnusedImports Avoid unused imports such as 'org.apache.commons.lang3.ObjectUtils' 4 44
UnusedImports Avoid unused imports such as 'org.apache.commons.lang3.StringUtils' 4 45
UnusedImports Avoid unused imports such as 'org.tmatesoft.svn.core.SVNCancelException' 4 46
UnusedImports Avoid unused imports such as 'org.tmatesoft.svn.core.SVNException' 4 47
UnusedImports Avoid unused imports such as 'org.tmatesoft.svn.core.wc.ISVNEventHandler' 4 49
UnusedImports Avoid unused imports such as 'org.tmatesoft.svn.core.wc.SVNEvent' 4 50
UnusedImports Avoid unused imports such as 'org.tmatesoft.svn.core.wc.SVNEventAction' 4 51
UnusedImports Avoid unused imports such as 'fr.paris.lutece.plugins.releaser.business.RepositoryType' 4 54
UnusedImports Avoid unused imports such as 'fr.paris.lutece.plugins.releaser.util.svn.ReleaseSvnCopyClient' 4 65
MissingOverride The method 'fetchPom(Site, String, String)' is missing an @Override annotation. 3 92112
AvoidLiteralsInIfCondition Avoid using Literals in Conditional Statements 3 106
MissingOverride The method 'getLastRelease(Site, String, String)' is missing an @Override annotation. 3 125160
ConfusingTernary Avoid if (x != y) ..; else ..; 3 146
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 3 173
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 3 262
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 3 310
LongInstantiation Avoid instantiating Long objects.Call Long.valueOf() instead 2 355
ConfusingTernary Avoid if (x != y) ..; else ..; 3 355
CompareObjectsWithEquals Use equals() to compare object references. 3 357
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 3 371

fr/paris/lutece/plugins/releaser/util/CVSFactoryService.java

Rule Violation Priority Ligne
UseUtilityClass All methods are static. Consider using a utility class instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning. 3 44104
UncommentedEmptyConstructor Document empty constructor 3 5861
UnnecessaryConstructor Avoid unnecessary constructors - the compiler will generate these for you 3 5861

fr/paris/lutece/plugins/releaser/util/CommandResult.java

Rule Violation Priority Ligne
FieldNamingConventions The static field name 'STATUS_ERROR' doesn't match '_[a-z][a-zA-Z0-9]*' 1 52
RedundantFieldInitializer Avoid using redundant field initializer for 'STATUS_ERROR' 3 52
FieldNamingConventions The static field name 'STATUS_OK' doesn't match '_[a-z][a-zA-Z0-9]*' 1 55
FieldNamingConventions The static field name 'ERROR_TYPE_INFO' doesn't match '_[a-z][a-zA-Z0-9]*' 1 58
RedundantFieldInitializer Avoid using redundant field initializer for 'ERROR_TYPE_INFO' 3 58
FieldNamingConventions The static field name 'ERROR_TYPE_STOP' doesn't match '_[a-z][a-zA-Z0-9]*' 1 61
AvoidStringBufferField StringBuffers can grow quite a lot, and so may become a source of memory leak (if the owning class has a long life time). 3 64
FieldNamingConventions The field name 'progressValue' doesn't match '_[a-z][a-zA-Z0-9]*' 1 82
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 3 88
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 3 88
CloneMethodReturnTypeMustMatchClassName The return type of the clone() method must be the class name when implements Cloneable 3 158167
FormalParameterNamingConventions The method parameter name '_mResultInformations' doesn't match '[a-z][a-zA-Z0-9]*' 1 206
FormalParameterNamingConventions The method parameter name '_nErrorType' doesn't match '[a-z][a-zA-Z0-9]*' 1 227
FormalParameterNamingConventions The method parameter name '_dBegin' doesn't match '[a-z][a-zA-Z0-9]*' 1 248
FormalParameterNamingConventions The method parameter name '_dEnd' doesn't match '[a-z][a-zA-Z0-9]*' 1 269

fr/paris/lutece/plugins/releaser/util/MapperJsonUtil.java

Rule Violation Priority Ligne
FieldNamingConventions The constant name '_mapper' doesn't match '[A-Z][A-Z_0-9]*' 1 50
ShortVariable Avoid variables with short names like t 3 78

fr/paris/lutece/plugins/releaser/util/PluginUtils.java

Rule Violation Priority Ligne
UnusedImports Avoid unused imports such as 'javax.xml.parsers.ParserConfigurationException' 4 48
UnusedImports Avoid unused imports such as 'javax.xml.transform.TransformerException' 4 50
UnusedImports Avoid unused imports such as 'org.eclipse.jgit.api.errors.NoFilepatternException' 4 55
UnusedImports Avoid unused imports such as 'org.xml.sax.SAXException' 4 59
UseUtilityClass All methods are static. Consider using a utility class instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning. 3 66363
CyclomaticComplexity The method 'updateAppInfoFile(String, String, CommandResult)' has a cyclomatic complexity of 12. 3 185269
ShortVariable Avoid variables with short names like br 3 188
AvoidFileStream Avoid instantiating FileInputStream, FileOutputStream, FileReader, or FileWriter 1 193
AvoidLiteralsInIfCondition Avoid using Literals in Conditional Statements 3 200
CollapsibleIfStatements These nested if statements could be combined 3 200213
ConfusingTernary Avoid if (x != y) ..; else ..; 3 203212
InefficientStringBuffering Avoid concatenating nonliterals in a StringBuffer/StringBuilder constructor or append(). 3 216
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 3 220
ShortVariable Avoid variables with short names like fw 3 244
AvoidFileStream Avoid instantiating FileInputStream, FileOutputStream, FileReader, or FileWriter 1 247
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 3 250
ShortVariable Avoid variables with short names like fw 3 284
ShortVariable Avoid variables with short names like sw 3 301
ShortVariable Avoid variables with short names like tf 3 304
AvoidFileStream Avoid instantiating FileInputStream, FileOutputStream, FileReader, or FileWriter 1 308
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 3 319
AvoidPrintStackTrace Avoid printStackTrace(); use a logger call instead. 3 334
CommentDefaultAccessModifier To avoid mistakes add a comment at the beginning of the ContextFileFilter nested class if you want a default access modifier 3 345361
MissingOverride The method 'accept(File, String)' is missing an @Override annotation. 3 357360

fr/paris/lutece/plugins/releaser/util/ReleaserUtils.java

Rule Violation Priority Ligne
GodClass Possible God Class (WMC=54, ATFD=68, TCC=0.000%) 3 64563
TooManyMethods This class has too many methods, consider refactoring it. 3 65563
UseUtilityClass All methods are static. Consider using a utility class instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning. 3 65563
ConfusingTernary Avoid if (x != y) ..; else ..; 3 118129
ShortVariable Avoid variables with short names like e 3 238
ConfusingTernary Avoid if (x != y) ..; else ..; 3 241248
ShortVariable Avoid variables with short names like e 3 271
AvoidUncheckedExceptionsInSignatures A method or constructor should not explicitly declare unchecked exceptions in its 'throws' clause 3 271
ConfusingTernary Avoid if (x != y) ..; else ..; 3 274281
ConfusingTernary Avoid if (x != y) ..; else ..; 3 291298
AvoidUncheckedExceptionsInSignatures A method or constructor should not explicitly declare unchecked exceptions in its 'throws' clause 3 311
ConfusingTernary Avoid if (x != y) ..; else ..; 3 332
ConfusingTernary Avoid if (x != y) ..; else ..; 3 377
ConfusingTernary Avoid if (x != y) ..; else ..; 3 439
ForLoopCanBeForeach This for loop can be replaced by a foreach loop 3 463473
ConfusingTernary Avoid if (x != y) ..; else ..; 3 487
CommentRequired Public method and constructor comments are required 3 531539
CommentRequired Public method and constructor comments are required 3 541561
ConfusingTernary Avoid if (x != y) ..; else ..; 3 546558
ConfusingTernary Avoid if (x != y) ..; else ..; 3 551558

fr/paris/lutece/plugins/releaser/util/file/FileUtils.java

Rule Violation Priority Ligne
UseUtilityClass All methods are static. Consider using a utility class instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning. 3 48160
InefficientStringBuffering Avoid concatenating nonliterals in a StringBuffer/StringBuilder constructor or append(). 3 82
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 3 141

fr/paris/lutece/plugins/releaser/util/github/GitUtils.java

Rule Violation Priority Ligne
ExcessiveImports A high number of imports can indicate a high degree of coupling within an object. 3 34788
GodClass Possible God Class (WMC=69, ATFD=39, TCC=0.000%) 3 89788
UseUtilityClass All methods are static. Consider using a utility class instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning. 3 90788
UseObjectForClearerAPI Rather than using a lot of String arguments, consider using a container object for those values. 3 118119
IdenticalCatchBranches 'catch' branch identical to 'InvalidRemoteException' branch 3 145149
IdenticalCatchBranches 'catch' branch identical to 'InvalidRemoteException' branch 3 150153
IdenticalCatchBranches 'catch' branch identical to 'InvalidRemoteException' branch 3 154158
IdenticalCatchBranches 'catch' branch identical to 'InvalidRemoteException' branch 3 193197
IdenticalCatchBranches 'catch' branch identical to 'InvalidRemoteException' branch 3 199202
IdenticalCatchBranches 'catch' branch identical to 'InvalidRemoteException' branch 3 229233
IdenticalCatchBranches 'catch' branch identical to 'InvalidRemoteException' branch 3 235238
IdenticalCatchBranches 'catch' branch identical to 'RefAlreadyExistsException' branch 3 267270
IdenticalCatchBranches 'catch' branch identical to 'RefAlreadyExistsException' branch 3 271274
IdenticalCatchBranches 'catch' branch identical to 'RefAlreadyExistsException' branch 3 275278
IdenticalCatchBranches 'catch' branch identical to 'RefAlreadyExistsException' branch 3 279282
UnnecessaryLocalBeforeReturn Consider simply returning the value vs storing it in local variable 'mergeResult' 3 400
ShortVariable Avoid variables with short names like i 3 419
UseStringBufferForStringAppends Prefer StringBuilder (non-synchronized) or StringBuffer (synchronized) over += for concatenating strings 3 424
UseStringBufferForStringAppends Prefer StringBuilder (non-synchronized) or StringBuffer (synchronized) over += for concatenating strings 3 425
UseStringBufferForStringAppends Prefer StringBuilder (non-synchronized) or StringBuffer (synchronized) over += for concatenating strings 3 426
ShortVariable Avoid variables with short names like i 3 445
UseObjectForClearerAPI Rather than using a lot of String arguments, consider using a container object for those values. 3 527
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 3 550
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 3 550
IdenticalCatchBranches 'catch' branch identical to 'HttpAccessException' branch 3 565568
UseObjectForClearerAPI Rather than using a lot of String arguments, consider using a container object for those values. 3 588
LocalVariableNamingConventions The final local variable name 'TOKEN' doesn't match '[a-z][a-zA-Z0-9]*' 1 621
ShortVariable Avoid variables with short names like i 3 626
ForLoopCanBeForeach This for loop can be replaced by a foreach loop 3 644653
UnusedLocalVariable Avoid unused local variables such as 'tagName'. 3 647
AvoidReassigningParameters Avoid reassigning parameters such as 'strRepoUrl' 2 689
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 3 711
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 3 712
CommentRequired Public method and constructor comments are required 3 736787
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 3 747

fr/paris/lutece/plugins/releaser/util/github/GithubSearchRepoItem.java

Rule Violation Priority Ligne
FormalParameterNamingConventions The method parameter name '_strName' doesn't match '[a-z][a-zA-Z0-9]*' 1 73
FormalParameterNamingConventions The method parameter name '_strCloneUrl' doesn't match '[a-z][a-zA-Z0-9]*' 1 96
FormalParameterNamingConventions The method parameter name '_strContentsUrl' doesn't match '[a-z][a-zA-Z0-9]*' 1 119
FormalParameterNamingConventions The method parameter name '_strFullName' doesn't match '[a-z][a-zA-Z0-9]*' 1 142

fr/paris/lutece/plugins/releaser/util/github/ReleaseGITGetRepoClient.java

Rule Violation Priority Ligne
FieldNamingConventions The field name 'bCancelled' doesn't match '_[a-z][a-zA-Z0-9]*' 1 44
UnusedPrivateField Avoid unused private fields such as 'bCancelled'. 3 44
SingularField Perhaps 'bCancelled' could be replaced by a local variable. 3 44
UncommentedEmptyConstructor Document empty constructor 3 4951
UnnecessaryConstructor Avoid unnecessary constructors - the compiler will generate these for you 3 4951

fr/paris/lutece/plugins/releaser/util/maven/MavenUtils.java

Rule Violation Priority Ligne
UseObjectForClearerAPI Rather than using a lot of String arguments, consider using a container object for those values. 3 7677
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 3 85

fr/paris/lutece/plugins/releaser/util/pom/PomParser.java

Rule Violation Priority Ligne
UnusedImports Avoid unused imports such as 'java.io.FileInputStream' 4 36
UnusedImports Avoid unused imports such as 'java.io.FileNotFoundException' 4 37
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 3 66
ImmutableField Private field '_listDependencies' could be made final; it is only initialized in the declaration or constructor. 3 66
LooseCoupling Avoid using implementation types like 'ArrayList'; use the interface instead 3 66
LinguisticNaming Linguistics Antipattern - The variable 'isPOM' indicates linguistically it is a boolean, but it is 'InputSource' 3 90
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'fr.paris.lutece.plugins.releaser.business.jaxb.maven.Model.Dependencies' due to existing import 'fr.paris.lutece.plugins.releaser.business.jaxb.maven.Model' 4 95
LinguisticNaming Linguistics Antipattern - The variable 'isPOM' indicates linguistically it is a boolean, but it is 'InputSource' 3 125
ShortVariable Avoid variables with short names like jc 3 238
ShortVariable Avoid variables with short names like u 3 239

fr/paris/lutece/plugins/releaser/util/pom/PomUpdater.java

Rule Violation Priority Ligne
UnusedImports Avoid unused imports such as 'java.util.Iterator' 4 42
UnusedImports Avoid unused imports such as 'fr.paris.lutece.portal.service.i18n.I18nService' 4 56
ClassNamingConventions The utility class name 'PomUpdater' doesn't match '[A-Z][a-zA-Z0-9]+(Utils?|Helper|Home|Service)' 1 64274
UseUtilityClass All methods are static. Consider using a utility class instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning. 3 65274
AvoidFileStream Avoid instantiating FileInputStream, FileOutputStream, FileReader, or FileWriter 1 87
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'fr.paris.lutece.plugins.releaser.business.jaxb.maven.Model.Dependencies' due to existing import 'fr.paris.lutece.plugins.releaser.business.jaxb.maven.Model' 4 92
AvoidFileStream Avoid instantiating FileInputStream, FileOutputStream, FileReader, or FileWriter 1 124
CyclomaticComplexity The method 'updateSiteAfterTag(Site, String)' has a cyclomatic complexity of 10. 3 163227
AvoidFileStream Avoid instantiating FileInputStream, FileOutputStream, FileReader, or FileWriter 1 172
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'fr.paris.lutece.plugins.releaser.business.jaxb.maven.Model.Dependencies' due to existing import 'fr.paris.lutece.plugins.releaser.business.jaxb.maven.Model' 4 178
CollapsibleIfStatements These nested if statements could be combined 3 190193
AvoidDeeplyNestedIfStmts Deeply nested if..then statements are hard to read 3 190193
AvoidFileStream Avoid instantiating FileInputStream, FileOutputStream, FileReader, or FileWriter 1 201
ShortVariable Avoid variables with short names like jc 3 245
ShortVariable Avoid variables with short names like m 3 246
ShortVariable Avoid variables with short names like jc 3 268
ShortVariable Avoid variables with short names like u 3 269

fr/paris/lutece/plugins/releaser/util/svn/ReleaseSvnCheckoutClient.java

Rule Violation Priority Ligne
SingularField Perhaps 'bCancelled' could be replaced by a local variable. 3 49
FieldNamingConventions The field name 'bCancelled' doesn't match '_[a-z][a-zA-Z0-9]*' 1 49
UnusedPrivateField Avoid unused private fields such as 'bCancelled'. 3 49

fr/paris/lutece/plugins/releaser/util/svn/ReleaseSvnCommitClient.java

Rule Violation Priority Ligne
FieldNamingConventions The field name 'bCancelled' doesn't match '_[a-z][a-zA-Z0-9]*' 1 48
UnusedPrivateField Avoid unused private fields such as 'bCancelled'. 3 48
SingularField Perhaps 'bCancelled' could be replaced by a local variable. 3 48

fr/paris/lutece/plugins/releaser/util/svn/ReleaseSvnCopyClient.java

Rule Violation Priority Ligne
FieldNamingConventions The field name 'bCancelled' doesn't match '_[a-z][a-zA-Z0-9]*' 1 48
UnusedPrivateField Avoid unused private fields such as 'bCancelled'. 3 48
SingularField Perhaps 'bCancelled' could be replaced by a local variable. 3 48

fr/paris/lutece/plugins/releaser/util/svn/SvnUser.java

Rule Violation Priority Ligne
FormalParameterNamingConventions The method parameter name '_mUserContex' doesn't match '[a-z][a-zA-Z0-9]*' 1 120

fr/paris/lutece/plugins/releaser/util/svn/SvnUtils.java

Rule Violation Priority Ligne
ExcessiveImports A high number of imports can indicate a high degree of coupling within an object. 3 34508
UnusedPrivateField Avoid unused private fields such as 'MESSAGE_ERROR_SVN'. 3 86
UnusedPrivateField Avoid unused private fields such as 'CONSTANTE_SLASH'. 3 89
UnusedPrivateField Avoid unused private fields such as 'logger'. 3 92
FieldNamingConventions The constant name 'logger' doesn't match '[A-Z][A-Z_0-9]*' 1 92
UseObjectForClearerAPI Rather than using a lot of String arguments, consider using a container object for those values. 3 163
CollapsibleIfStatements These nested if statements could be combined 3 207212
CommentRequired Public method and constructor comments are required 3 222225
MissingOverride The method 'checkCancelled()' is missing an @Override annotation. 3 222225
CommentRequired Public method and constructor comments are required 3 227230
MissingOverride The method 'handleEvent(SVNEvent, double)' is missing an @Override annotation. 3 227230
ShortVariable Avoid variables with short names like sw 3 245
ShortVariable Avoid variables with short names like pw 3 246
UnusedLocalVariable Avoid unused local variables such as 'errorLog'. 3 249
EmptyCatchBlock Avoid empty catch blocks 3 258262
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 3 269
ShortVariable Avoid variables with short names like sw 3 273
ShortVariable Avoid variables with short names like pw 3 274
UnusedLocalVariable Avoid unused local variables such as 'errorLog'. 3 277
EmptyCatchBlock Avoid empty catch blocks 3 286290
MissingOverride The method 'handleDirEntry(SVNDirEntry)' is missing an @Override annotation. 3 321331
CommentRequired Public method and constructor comments are required 3 321331
CollapsibleIfStatements These nested if statements could be combined 3 326329
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 3 350
UseObjectForClearerAPI Rather than using a lot of String arguments, consider using a container object for those values. 3 413
AvoidReassigningParameters Avoid reassigning parameters such as 'strRepoUrl' 2 465

fr/paris/lutece/plugins/releaser/util/version/Version.java

Rule Violation Priority Ligne
GodClass Possible God Class (WMC=47, ATFD=10, TCC=30.333%) 3 47542
UncommentedEmptyConstructor Document empty constructor 3 8688
ConfusingTernary Avoid if (x != y) ..; else ..; 3 238245
ConfusingTernary Avoid if (x != y) ..; else ..; 3 277
ConfusingTernary Avoid if (x != y) ..; else ..; 3 297308
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 3 310
AvoidDuplicateLiterals The String literal " : " appears 5 times in this file; the first occurrence is on line 440 3 440
AvoidDuplicateLiterals The String literal "Error parsing version " appears 5 times in this file; the first occurrence is on line 440 3 440

fr/paris/lutece/plugins/releaser/util/version/VersionParsingException.java

Rule Violation Priority Ligne
MissingSerialVersionUID Classes implementing Serializable should set a serialVersionUID 3 4055

fr/paris/lutece/plugins/releaser/web/ClusterJspBean.java

Rule Violation Priority Ligne
MissingSerialVersionUID Classes implementing Serializable should set a serialVersionUID 3 70615
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 3 165
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 3 166
ConfusingTernary Avoid if (x != y) ..; else ..; 3 207
ConfusingTernary Avoid if (x != y) ..; else ..; 3 449

fr/paris/lutece/plugins/releaser/web/ManageComponentReleaseJspBean.java

Rule Violation Priority Ligne
MissingSerialVersionUID Classes implementing Serializable should set a serialVersionUID 3 65323
DefaultPackage Use explicit scoping instead of the default package private level 3 126
CommentDefaultAccessModifier To avoid mistakes add a comment at the beginning of the _paginatorComponents field if you want a default access modifier 3 126
CyclomaticComplexity The method 'getManageComponent(HttpServletRequest)' has a cyclomatic complexity of 12. 3 137180
UnusedLocalVariable Avoid unused local variables such as 'user'. 3 145
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 3 145
ConfusingTernary Avoid if (x != y) ..; else ..; 3 147170
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 3 168
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 3 169
ConfusingTernary Avoid if (x != y) ..; else ..; 3 174
ConfusingTernary Avoid if (x != y) ..; else ..; 3 176
UnnecessaryAnnotationValueElement Avoid the use of value in annotations when its the only element 3 254
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 3 262
UnusedLocalVariable Avoid unused local variables such as 'component'. 3 262
UnusedLocalVariable Avoid unused local variables such as 'component'. 3 284
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 3 284
LinguisticNaming Linguistics Antipattern - The setter 'setReleaserUser' should not return any type except void linguistically 3 289302

fr/paris/lutece/plugins/releaser/web/ManageSiteReleaseJspBean.java

Rule Violation Priority Ligne
ExcessiveImports A high number of imports can indicate a high degree of coupling within an object. 3 34701
UnusedImports Avoid unused imports such as 'fr.paris.lutece.portal.service.i18n.I18nService' 4 49
MissingSerialVersionUID Classes implementing Serializable should set a serialVersionUID 3 74701
TooManyMethods This class has too many methods, consider refactoring it. 3 75701
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 3 217
UnnecessaryAnnotationValueElement Avoid the use of value in annotations when its the only element 3 266
NPathComplexity The method 'getConfirmReleaseSite(HttpServletRequest)' has an NPath complexity of 324 3 267313
CyclomaticComplexity The method 'getConfirmReleaseSite(HttpServletRequest)' has a cyclomatic complexity of 11. 3 267313
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 3 272
UnnecessaryAnnotationValueElement Avoid the use of value in annotations when its the only element 3 322
UnnecessaryAnnotationValueElement Avoid the use of value in annotations when its the only element 3 349
ConfusingTernary Avoid if (x != y) ..; else ..; 3 357376
ConfusingTernary Avoid if (x != y) ..; else ..; 3 361370
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 3 505
UnnecessaryAnnotationValueElement Avoid the use of value in annotations when its the only element 3 562
UnnecessaryLocalBeforeReturn Consider simply returning the value vs storing it in local variable 'strTemplate' 3 575
UnnecessaryAnnotationValueElement Avoid the use of value in annotations when its the only element 3 633
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 3 641
UnusedLocalVariable Avoid unused local variables such as 'component'. 3 641
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 3 662
UnusedLocalVariable Avoid unused local variables such as 'component'. 3 662
LinguisticNaming Linguistics Antipattern - The setter 'setReleaserUser' should not return any type except void linguistically 3 668681

fr/paris/lutece/plugins/releaser/web/ManageSitesJspBean.java

Rule Violation Priority Ligne
MissingSerialVersionUID Classes implementing Serializable should set a serialVersionUID 3 4999
SingularField Perhaps '_nDefaultItemsPerPage' could be replaced by a local variable. 3 62