Fork me on GitHub

Résultats PMD

Le document suivant contient les résultats de PMD 6.13.0.

Violations By Priority

Priority 1

fr/paris/lutece/plugins/releaser/business/Cluster.java

Rule Violation Ligne
FieldNamingConventions The field name 'permissions' doesn't match '_[a-z][a-zA-Z0-9]*' 59

fr/paris/lutece/plugins/releaser/business/Component.java

Rule Violation Ligne
FieldNamingConventions The field name 'permissions' doesn't match '_[a-z][a-zA-Z0-9]*' 54
FormalParameterNamingConventions The method parameter name '_strScmDeveloperConnection' doesn't match '[a-z][a-zA-Z0-9]*' 472
FormalParameterNamingConventions The method parameter name '_bUpgrade' doesn't match '[a-z][a-zA-Z0-9]*' 503
FormalParameterNamingConventions The method parameter name '_bDowngrade' doesn't match '[a-z][a-zA-Z0-9]*' 524
FormalParameterNamingConventions The method parameter name '_strLastAvailableSnapshotVersion' doesn't match '[a-z][a-zA-Z0-9]*' 555
FormalParameterNamingConventions The method parameter name '_bErrorLastRelease' doesn't match '[a-z][a-zA-Z0-9]*' 576
FormalParameterNamingConventions The method parameter name '_strName' doesn't match '[a-z][a-zA-Z0-9]*' 597
FormalParameterNamingConventions The method parameter name '_strCloneUrl' doesn't match '[a-z][a-zA-Z0-9]*' 618
FormalParameterNamingConventions The method parameter name '_strTweetMessage' doesn't match '[a-z][a-zA-Z0-9]*' 660
FormalParameterNamingConventions The method parameter name '_strBranchReleaseFrom' doesn't match '[a-z][a-zA-Z0-9]*' 714
FormalParameterNamingConventions The method parameter name '_strBranchReleaseVersion' doesn't match '[a-z][a-zA-Z0-9]*' 724
FormalParameterNamingConventions The method parameter name '_strTargetJdk' doesn't match '[a-z][a-zA-Z0-9]*' 733

fr/paris/lutece/plugins/releaser/business/Site.java

Rule Violation Ligne
FieldNamingConventions The field name 'permissions' doesn't match '_[a-z][a-zA-Z0-9]*' 62
FormalParameterNamingConventions The method parameter name '_strTagInfotmation' doesn't match '[a-z][a-zA-Z0-9]*' 499
FormalParameterNamingConventions The method parameter name '_strGroupId' doesn't match '[a-z][a-zA-Z0-9]*' 520
FormalParameterNamingConventions The method parameter name '_bTheme' doesn't match '[a-z][a-zA-Z0-9]*' 541
FormalParameterNamingConventions The method parameter name '_bCreateDckerImage' doesn't match '[a-z][a-zA-Z0-9]*' 551
FormalParameterNamingConventions The method parameter name '_strBranchReleaseFrom' doesn't match '[a-z][a-zA-Z0-9]*' 570
FormalParameterNamingConventions The method parameter name '_strParentVersion' doesn't match '[a-z][a-zA-Z0-9]*' 632

fr/paris/lutece/plugins/releaser/business/WorkflowContextHistory.java

Rule Violation Ligne
FormalParameterNamingConventions The method parameter name '_dateBegin' doesn't match '[a-z][a-zA-Z0-9]*' 181
FormalParameterNamingConventions The method parameter name '_dateEnd' doesn't match '[a-z][a-zA-Z0-9]*' 202
FormalParameterNamingConventions The method parameter name '_strArtifactId' doesn't match '[a-z][a-zA-Z0-9]*' 223

fr/paris/lutece/plugins/releaser/business/WorkflowReleaseContext.java

Rule Violation Ligne
FormalParameterNamingConventions The method parameter name '_nId' doesn't match '[a-z][a-zA-Z0-9]*' 98
FormalParameterNamingConventions The method parameter name '_component' doesn't match '[a-z][a-zA-Z0-9]*' 119
FormalParameterNamingConventions The method parameter name '_commandResult' doesn't match '[a-z][a-zA-Z0-9]*' 140
FormalParameterNamingConventions The method parameter name '_releaserUser' doesn't match '[a-z][a-zA-Z0-9]*' 194
FormalParameterNamingConventions The method parameter name '_strRefBranchRelease' doesn't match '[a-z][a-zA-Z0-9]*' 215
FormalParameterNamingConventions The method parameter name '_strRefBranchReleaseFrom' doesn't match '[a-z][a-zA-Z0-9]*' 236

fr/paris/lutece/plugins/releaser/service/ClusterService.java

Rule Violation Ligne
MethodNamingConventions The static method name 'IsAddClusterAuthorized' doesn't match '[a-z][a-zA-Z0-9]*' 146155
MethodNamingConventions The static method name 'IsUserAuthorized' doesn't match '[a-z][a-zA-Z0-9]*' 157168

fr/paris/lutece/plugins/releaser/service/ComponentService.java

Rule Violation Ligne
AvoidFileStream Avoid instantiating FileInputStream, FileOutputStream, FileReader, or FileWriter 383
MethodNamingConventions The static method name 'IsSearchComponentAuthorized' doesn't match '[a-z][a-zA-Z0-9]*' 424433

fr/paris/lutece/plugins/releaser/service/IJenkinsService.java

Rule Violation Ligne
MethodNamingConventions The instance method name 'TriggerPipeline' doesn't match '[a-z][a-zA-Z0-9]*' 12

fr/paris/lutece/plugins/releaser/service/JenkinsService.java

Rule Violation Ligne
FieldNamingConventions The static field name 'JENKINS_BASE_URL' doesn't match '_[a-z][a-zA-Z0-9]*' 39
FieldNamingConventions The static field name 'JENKINS_PIPELINE_NAME' doesn't match '_[a-z][a-zA-Z0-9]*' 42
FieldNamingConventions The static field name 'JENKINS_BUILD_TYPE' doesn't match '_[a-z][a-zA-Z0-9]*' 45
FieldNamingConventions The static field name 'JENKINS_USER_LOGIN' doesn't match '_[a-z][a-zA-Z0-9]*' 48
FieldNamingConventions The static field name 'JENKINS_USER_PWD' doesn't match '_[a-z][a-zA-Z0-9]*' 51
LocalVariableNamingConventions The local variable name 'ObjectBuildJson' doesn't match '[a-z][a-zA-Z0-9]*' 135

fr/paris/lutece/plugins/releaser/service/JiraComponentService.java

Rule Violation Ligne
FieldNamingConventions The static field name 'URL_JIRA_SERVER' doesn't match '_[a-z][a-zA-Z0-9]*' 87
FieldNamingConventions The static field name 'JIRA_USER' doesn't match '_[a-z][a-zA-Z0-9]*' 90
FieldNamingConventions The static field name 'JIRA_USER_PWD' doesn't match '_[a-z][a-zA-Z0-9]*' 93

fr/paris/lutece/plugins/releaser/service/MavenService.java

Rule Violation Ligne
ClassWithOnlyPrivateConstructorsShouldBeFinal A class which only has private constructors should be final 62330

fr/paris/lutece/plugins/releaser/service/SiteService.java

Rule Violation Ligne
FieldNamingConventions The static field name 'POM_PARENT_MIN_VERSION_TO_CREATE_DOCKET_IMAGE' doesn't match '_[a-z][a-zA-Z0-9]*' 111
AvoidFileStream Avoid instantiating FileInputStream, FileOutputStream, FileReader, or FileWriter 801
MethodNamingConventions The static method name 'IsUserAuthorized' doesn't match '[a-z][a-zA-Z0-9]*' 888899
MethodNamingConventions The static method name 'IsSiteAlreadyExist' doesn't match '[a-z][a-zA-Z0-9]*' 901908

fr/paris/lutece/plugins/releaser/service/WorkflowReleaseContextService.java

Rule Violation Ligne
LocalVariableNamingConventions The local variable name 'StrLocalComponentPomEffectivePath' doesn't match '[a-z][a-zA-Z0-9]*' 445

fr/paris/lutece/plugins/releaser/util/CommandResult.java

Rule Violation Ligne
FieldNamingConventions The static field name 'STATUS_ERROR' doesn't match '_[a-z][a-zA-Z0-9]*' 52
FieldNamingConventions The static field name 'STATUS_OK' doesn't match '_[a-z][a-zA-Z0-9]*' 55
FieldNamingConventions The static field name 'ERROR_TYPE_INFO' doesn't match '_[a-z][a-zA-Z0-9]*' 58
FieldNamingConventions The static field name 'ERROR_TYPE_STOP' doesn't match '_[a-z][a-zA-Z0-9]*' 61
FieldNamingConventions The field name 'progressValue' doesn't match '_[a-z][a-zA-Z0-9]*' 82
FormalParameterNamingConventions The method parameter name '_mResultInformations' doesn't match '[a-z][a-zA-Z0-9]*' 206
FormalParameterNamingConventions The method parameter name '_nErrorType' doesn't match '[a-z][a-zA-Z0-9]*' 227
FormalParameterNamingConventions The method parameter name '_dBegin' doesn't match '[a-z][a-zA-Z0-9]*' 248
FormalParameterNamingConventions The method parameter name '_dEnd' doesn't match '[a-z][a-zA-Z0-9]*' 269

fr/paris/lutece/plugins/releaser/util/MapperJsonUtil.java

Rule Violation Ligne
FieldNamingConventions The constant name '_mapper' doesn't match '[A-Z][A-Z_0-9]*' 50

fr/paris/lutece/plugins/releaser/util/PluginUtils.java

Rule Violation Ligne
AvoidFileStream Avoid instantiating FileInputStream, FileOutputStream, FileReader, or FileWriter 193
AvoidFileStream Avoid instantiating FileInputStream, FileOutputStream, FileReader, or FileWriter 247
AvoidFileStream Avoid instantiating FileInputStream, FileOutputStream, FileReader, or FileWriter 308

fr/paris/lutece/plugins/releaser/util/ReleaserUtils.java

Rule Violation Ligne
MethodNamingConventions The static method name 'IsVersionInRightFormat' doesn't match '[a-z][a-zA-Z0-9]*' 567586

fr/paris/lutece/plugins/releaser/util/github/GitUtils.java

Rule Violation Ligne
LocalVariableNamingConventions The final local variable name 'TOKEN' doesn't match '[a-z][a-zA-Z0-9]*' 621

fr/paris/lutece/plugins/releaser/util/github/GithubSearchRepoItem.java

Rule Violation Ligne
FormalParameterNamingConventions The method parameter name '_strName' doesn't match '[a-z][a-zA-Z0-9]*' 73
FormalParameterNamingConventions The method parameter name '_strCloneUrl' doesn't match '[a-z][a-zA-Z0-9]*' 96
FormalParameterNamingConventions The method parameter name '_strContentsUrl' doesn't match '[a-z][a-zA-Z0-9]*' 119
FormalParameterNamingConventions The method parameter name '_strFullName' doesn't match '[a-z][a-zA-Z0-9]*' 142

fr/paris/lutece/plugins/releaser/util/github/ReleaseGITGetRepoClient.java

Rule Violation Ligne
FieldNamingConventions The field name 'bCancelled' doesn't match '_[a-z][a-zA-Z0-9]*' 44

fr/paris/lutece/plugins/releaser/util/pom/PomParser.java

Rule Violation Ligne
AvoidFileStream Avoid instantiating FileInputStream, FileOutputStream, FileReader, or FileWriter 134

fr/paris/lutece/plugins/releaser/util/pom/PomUpdater.java

Rule Violation Ligne
ClassNamingConventions The utility class name 'PomUpdater' doesn't match '[A-Z][a-zA-Z0-9]+(Utils?|Helper|Home|Service)' 64276
AvoidFileStream Avoid instantiating FileInputStream, FileOutputStream, FileReader, or FileWriter 87
AvoidFileStream Avoid instantiating FileInputStream, FileOutputStream, FileReader, or FileWriter 126
AvoidFileStream Avoid instantiating FileInputStream, FileOutputStream, FileReader, or FileWriter 174
AvoidFileStream Avoid instantiating FileInputStream, FileOutputStream, FileReader, or FileWriter 203

fr/paris/lutece/plugins/releaser/util/svn/ReleaseSvnCheckoutClient.java

Rule Violation Ligne
FieldNamingConventions The field name 'bCancelled' doesn't match '_[a-z][a-zA-Z0-9]*' 49

fr/paris/lutece/plugins/releaser/util/svn/ReleaseSvnCommitClient.java

Rule Violation Ligne
FieldNamingConventions The field name 'bCancelled' doesn't match '_[a-z][a-zA-Z0-9]*' 48

fr/paris/lutece/plugins/releaser/util/svn/ReleaseSvnCopyClient.java

Rule Violation Ligne
FieldNamingConventions The field name 'bCancelled' doesn't match '_[a-z][a-zA-Z0-9]*' 48

fr/paris/lutece/plugins/releaser/util/svn/SvnUser.java

Rule Violation Ligne
FormalParameterNamingConventions The method parameter name '_mUserContex' doesn't match '[a-z][a-zA-Z0-9]*' 120

fr/paris/lutece/plugins/releaser/util/svn/SvnUtils.java

Rule Violation Ligne
FieldNamingConventions The constant name 'logger' doesn't match '[A-Z][A-Z_0-9]*' 92

fr/paris/lutece/plugins/releaser/util/version/Version.java

Rule Violation Ligne
FormalParameterNamingConventions The method parameter name '_strQualifierRadix' doesn't match '[a-z][a-zA-Z0-9]*' 209
FormalParameterNamingConventions The method parameter name '_nQualifierNumber' doesn't match '[a-z][a-zA-Z0-9]*' 217

Priority 2

fr/paris/lutece/plugins/releaser/service/ComponentService.java

Rule Violation Ligne
AvoidReassigningParameters Avoid reassigning parameters such as 'component' 307
AvoidReassigningParameters Avoid reassigning parameters such as 'component' 307
AvoidReassigningParameters Avoid reassigning parameters such as 'component' 476

fr/paris/lutece/plugins/releaser/service/MavenService.java

Rule Violation Ligne
SystemPrintln System.out.println is used 264

fr/paris/lutece/plugins/releaser/service/ReleaseComponentTask.java

Rule Violation Ligne
AvoidBranchingStatementAsLastInLoop Avoid using a branching statement as the last in a loop. 160

fr/paris/lutece/plugins/releaser/service/SiteService.java

Rule Violation Ligne
BooleanInstantiation Avoid instantiating Boolean objects; reference Boolean.TRUE or Boolean.FALSE or call Boolean.valueOf() instead. 376

fr/paris/lutece/plugins/releaser/service/svn/SvnResourceService.java

Rule Violation Ligne
LongInstantiation Avoid instantiating Long objects.Call Long.valueOf() instead 355

fr/paris/lutece/plugins/releaser/util/github/GitUtils.java

Rule Violation Ligne
AvoidReassigningParameters Avoid reassigning parameters such as 'strRepoUrl' 689

fr/paris/lutece/plugins/releaser/util/svn/SvnUtils.java

Rule Violation Ligne
AvoidReassigningParameters Avoid reassigning parameters such as 'strRepoUrl' 465

Priority 3

fr/paris/lutece/plugins/releaser/business/AbstractReleaserResource.java

Rule Violation Ligne
ConfusingTernary Avoid if (x != y) ..; else ..; 5775
ConfusingTernary Avoid if (x != y) ..; else ..; 100107
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 115

fr/paris/lutece/plugins/releaser/business/Cluster.java

Rule Violation Ligne
LooseCoupling Avoid using implementation types like 'HashMap'; use the interface instead 59
LooseCoupling Avoid using implementation types like 'HashMap'; use the interface instead 170
LooseCoupling Avoid using implementation types like 'HashMap'; use the interface instead 175

fr/paris/lutece/plugins/releaser/business/ClusterDAO.java

Rule Violation Ligne
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 158
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 184

fr/paris/lutece/plugins/releaser/business/Component.java

Rule Violation Ligne
ExcessivePublicCount This class has a bunch of public methods and attributes 34779
TooManyFields Too many fields 47779
LooseCoupling Avoid using implementation types like 'HashMap'; use the interface instead 54
UnusedPrivateField Avoid unused private fields such as '_strDescription'. 82
MissingOverride The method 'getArtifactId()' is missing an @Override annotation. 151154
MissingOverride The method 'getTargetVersion()' is missing an @Override annotation. 235238
SimplifyBooleanReturns Avoid unnecessary if..then..else statements when returning booleans 448452
LooseCoupling Avoid using implementation types like 'HashMap'; use the interface instead 689
LooseCoupling Avoid using implementation types like 'HashMap'; use the interface instead 694
CommentRequired Public method and constructor comments are required 699702
CommentRequired Public method and constructor comments are required 704707
CommentRequired Public method and constructor comments are required 709712
CommentRequired Public method and constructor comments are required 714717
CommentRequired Public method and constructor comments are required 719722
CommentRequired Public method and constructor comments are required 724727
CommentRequired Public method and constructor comments are required 729731
CommentRequired Public method and constructor comments are required 733735

fr/paris/lutece/plugins/releaser/business/ReleaserUser.java

Rule Violation Ligne
ImmutableField Private field '_mapCredential' could be made final; it is only initialized in the declaration or constructor. 54
LooseCoupling Avoid using implementation types like 'HashMap'; use the interface instead 54
FieldDeclarationsShouldBeAtStartOfClass Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. 115
ImmutableField Private field '_strLogin' could be made final; it is only initialized in the declaration or constructor. 115
FieldDeclarationsShouldBeAtStartOfClass Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. 118
ImmutableField Private field '_strPassword' could be made final; it is only initialized in the declaration or constructor. 118

fr/paris/lutece/plugins/releaser/business/Site.java

Rule Violation Ligne
ExcessivePublicCount This class has a bunch of public methods and attributes 34637
TooManyFields Too many fields 51637
LooseCoupling Avoid using implementation types like 'HashMap'; use the interface instead 62
ImmutableField Private field '_listCurrentDependencies' could be made final; it is only initialized in the declaration or constructor. 106
ImmutableField Private field '_listComponents' could be made final; it is only initialized in the declaration or constructor. 109
MissingOverride The method 'getArtifactId()' is missing an @Override annotation. 173176
MissingOverride The method 'getScmUrl()' is missing an @Override annotation. 215218
CommentRequired Public method and constructor comments are required 546549
CommentRequired Public method and constructor comments are required 551553
CommentRequired Public method and constructor comments are required 555558
CommentRequired Public method and constructor comments are required 560563
CommentRequired Public method and constructor comments are required 565568
CommentRequired Public method and constructor comments are required 570573
LooseCoupling Avoid using implementation types like 'HashMap'; use the interface instead 609
LooseCoupling Avoid using implementation types like 'HashMap'; use the interface instead 614
ControlStatementBraces This statement should have braces 617
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 617
ControlStatementBraces This statement should have braces 619
CommentRequired Public method and constructor comments are required 627630
CommentRequired Public method and constructor comments are required 632635

fr/paris/lutece/plugins/releaser/business/SiteDAO.java

Rule Violation Ligne
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 182
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 214
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 252
UnusedLocalVariable Avoid unused local variables such as 'nIndex'. 294
ControlStatementBraces This statement should have braces 296

fr/paris/lutece/plugins/releaser/service/ClusterResourceIdService.java

Rule Violation Ligne
CommentRequired Header comments are required 48147
DataClass The class 'ClusterResourceIdService' is suspected to be a Data Class (WOC=0.000%, NOPA=4, NOAM=0, WMC=1) 48147
CallSuperInConstructor It is a good practice to call super() in a constructor 7174
ShortVariable Avoid variables with short names like rt 80
ShortVariable Avoid variables with short names like p 86

fr/paris/lutece/plugins/releaser/service/ClusterService.java

Rule Violation Ligne
UseUtilityClass All methods are static. Consider using a utility class instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning. 51169
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 82
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 86
ControlStatementBraces This statement should have braces 140
CommentRequired Public method and constructor comments are required 146155
SimplifyBooleanReturns Avoid unnecessary if..then..else statements when returning booleans 149152
CommentRequired Public method and constructor comments are required 157168

fr/paris/lutece/plugins/releaser/service/ComponentResourceIdService.java

Rule Violation Ligne
CommentRequired Header comments are required 4595
CallSuperInConstructor It is a good practice to call super() in a constructor 5659
ShortVariable Avoid variables with short names like rt 65
ShortVariable Avoid variables with short names like p 71

fr/paris/lutece/plugins/releaser/service/ComponentService.java

Rule Violation Ligne
ExcessiveImports A high number of imports can indicate a high degree of coupling within an object. 34525
UnusedPrivateField Avoid unused private fields such as '_executor'. 83
SingularField Perhaps '_executor' could be replaced by a local variable. 83
SingularField Perhaps '_mapper' could be replaced by a local variable. 84
UnusedPrivateField Avoid unused private fields such as '_mapper'. 84
NonThreadSafeSingleton Singleton is not thread safe 9397
CommentRequired Public method and constructor comments are required 103106
MissingOverride The method 'setRemoteInformations(Component, boolean)' is missing an @Override annotation. 103106
MissingOverride The method 'getLastReleaseVersion(String)' is missing an @Override annotation. 113118
MissingOverride The method 'setLastReleaseVersion(String, String)' is missing an @Override annotation. 125130
MissingOverride The method 'getLastReleaseNextSnapshotVersion(String)' is missing an @Override annotation. 137142
MissingOverride The method 'setLastReleaseNextSnapshotVersion(String, String)' is missing an @Override annotation. 149153
MissingOverride The method 'release(Component, Locale, AdminUser, HttpServletRequest)' is missing an @Override annotation. 179182
CommentRequired Public method and constructor comments are required 179182
MissingOverride The method 'isGitComponent(Component)' is missing an @Override annotation. 184188
CommentRequired Public method and constructor comments are required 184188
CommentRequired Public method and constructor comments are required 190196
MissingOverride The method 'init()' is missing an @Override annotation. 190196
CyclomaticComplexity The method 'updateRemoteInformations(Component)' has a cyclomatic complexity of 11. 199247
MissingOverride The method 'getSearchComponent(String, HttpServletRequest, Locale, String, String)' is missing an @Override annotation. 249282
CommentRequired Public method and constructor comments are required 249282
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 264
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 278279
UnusedFormalParameter Avoid unused method parameters such as 'strUser'. 284
UnusedFormalParameter Avoid unused method parameters such as 'strPassword'. 284
MissingOverride The method 'loadComponent(Component, String, String, String)' is missing an @Override annotation. 307338
CommentRequired Public method and constructor comments are required 307338
ConfusingTernary Avoid if (x != y) ..; else ..; 342350
EmptyIfStmt Avoid empty if statements 347350
CommentRequired Public method and constructor comments are required 372402
MissingOverride The method 'isErrorSnapshotComponentInformations(Component, String)' is missing an @Override annotation. 372402
MissingOverride The method 'changeNextReleaseVersion(Component)' is missing an @Override annotation. 410422
CommentRequired Public method and constructor comments are required 424433
SimplifyBooleanReturns Avoid unnecessary if..then..else statements when returning booleans 427430
CommentRequired Public method and constructor comments are required 476523
MissingOverride The method 'getLastBranchVersion(Component, String, ReleaserUser)' is missing an @Override annotation. 476523

fr/paris/lutece/plugins/releaser/service/GetRemoteInformationsTask.java

Rule Violation Ligne
DoNotUseThreads To be compliant to J2EE, a webapp should not use any thread. 46
ImmutableField Private field '_component' could be made final; it is only initialized in the declaration or constructor. 49

fr/paris/lutece/plugins/releaser/service/IComponentService.java

Rule Violation Ligne
CommentRequired Public method and constructor comments are required 231

fr/paris/lutece/plugins/releaser/service/IJenkinsService.java

Rule Violation Ligne
CommentRequired Header comments are required 513
UnnecessaryModifier Unnecessary modifiers 'public abstract' on method 'init': the method is declared in an interface type 10
CommentRequired Public method and constructor comments are required 12

fr/paris/lutece/plugins/releaser/service/IJiraService.java

Rule Violation Ligne
UnnecessaryModifier Unnecessary modifiers 'public abstract' on method 'init': the method is declared in an interface type 48
UnnecessaryModifier Unnecessary modifiers 'public abstract' on method 'updateComponentVersions': the method is declared in an interface type 58

fr/paris/lutece/plugins/releaser/service/IMavenService.java

Rule Violation Ligne
UseObjectForClearerAPI Rather than using a lot of String arguments, consider using a container object for those values. 8182
UseObjectForClearerAPI Rather than using a lot of String arguments, consider using a container object for those values. 98

fr/paris/lutece/plugins/releaser/service/IWorkflowReleaseContextService.java

Rule Violation Ligne
TooManyMethods This class has too many methods, consider refactoring it. 49231

fr/paris/lutece/plugins/releaser/service/JenkinsService.java

Rule Violation Ligne
CommentRequired Header comments are required 18162
RedundantFieldInitializer Avoid using redundant field initializer for '_instance' 54
NonThreadSafeSingleton Singleton is not thread safe 6367
CyclomaticComplexity The method 'TriggerPipeline(WorkflowReleaseContext)' has a cyclomatic complexity of 10. 83161
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 97
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 98
IdenticalCatchBranches 'catch' branch identical to 'HttpAccessException' branch 151154
IdenticalCatchBranches 'catch' branch identical to 'HttpAccessException' branch 155158

fr/paris/lutece/plugins/releaser/service/JiraComponentService.java

Rule Violation Ligne
ExcessiveImports A high number of imports can indicate a high degree of coupling within an object. 34286
UncommentedEmptyConstructor Document empty constructor 110113
UnnecessaryConstructor Avoid unnecessary constructors - the compiler will generate these for you 110113
NonThreadSafeSingleton Singleton is not thread safe 122126
CyclomaticComplexity The method 'updateComponentVersions(Component, CommandResult)' has a cyclomatic complexity of 12. 185284
AvoidSynchronizedAtMethodLevel Use block level rather than method level synchronization 185284
ConfusingTernary Avoid if (x != y) ..; else ..; 191282
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 229
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 230
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 230
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 259

fr/paris/lutece/plugins/releaser/service/MavenRepoComponentInfoProvider.java

Rule Violation Ligne
ExcessiveImports A high number of imports can indicate a high degree of coupling within an object. 2413
GodClass Possible God Class (WMC=48, ATFD=24, TCC=1.818%) 44413
UnusedPrivateField Avoid unused private fields such as 'URL_MAVEN_PATH_SITE_POM'. 72
AvoidSynchronizedAtMethodLevel Use block level rather than method level synchronization 99106
CommentRequired Public method and constructor comments are required 108153
ConfusingTernary Avoid if (x != y) ..; else ..; 119128
ConfusingTernary Avoid if (x != y) ..; else ..; 132145
ControlStatementBraces This statement should have braces 140
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 148
ConfusingTernary Avoid if (x != y) ..; else ..; 227242
UnusedPrivateMethod Avoid unused private methods such as 'getPomUrl(String,String,String)'. 269
AvoidLiteralsInIfCondition Avoid using Literals in Conditional Statements 273
UseEqualsToCompareStrings Use equals() to compare strings instead of '==' or '!=' 273
UseStringBufferForStringAppends Prefer StringBuilder (non-synchronized) or StringBuffer (synchronized) over += for concatenating strings 275
UseStringBufferForStringAppends Prefer StringBuilder (non-synchronized) or StringBuffer (synchronized) over += for concatenating strings 278
UseStringBufferForStringAppends Prefer StringBuilder (non-synchronized) or StringBuffer (synchronized) over += for concatenating strings 280
UnusedFormalParameter Avoid unused method parameters such as 'strArtifactId'. 285
UseEqualsToCompareStrings Use equals() to compare strings instead of '==' or '!=' 289
AvoidLiteralsInIfCondition Avoid using Literals in Conditional Statements 289
UseStringBufferForStringAppends Prefer StringBuilder (non-synchronized) or StringBuffer (synchronized) over += for concatenating strings 291
UseStringBufferForStringAppends Prefer StringBuilder (non-synchronized) or StringBuffer (synchronized) over += for concatenating strings 293
UnusedLocalVariable Avoid unused local variables such as 'listVersions'. 298
StringToString Avoid calling toString() on String objects; this is unnecessary. 300
UseStringBufferForStringAppends Prefer StringBuilder (non-synchronized) or StringBuffer (synchronized) over += for concatenating strings 320
LinguisticNaming Linguistics Antipattern - The getter 'getPomInfos' should not return void linguistically 337368
UnusedLocalVariable Avoid unused local variables such as 'headersResponse'. 342
UseIndexOfChar String.indexOf(char) is faster than String.indexOf(String). 403

fr/paris/lutece/plugins/releaser/service/MavenService.java

Rule Violation Ligne
NonThreadSafeSingleton Singleton is not thread safe 8791
MissingOverride The method 'init()' is missing an @Override annotation. 100106
MissingOverride The method 'mvnSiteAssembly(String, String, String, SvnUser, CommandResult)' is missing an @Override annotation. 128138
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 133
AvoidSynchronizedAtMethodLevel Use block level rather than method level synchronization 168171
AvoidSynchronizedAtMethodLevel Use block level rather than method level synchronization 187244
AddEmptyString Do not add empty strings 215
CommentRequired Public method and constructor comments are required 226229
MissingOverride The method 'consumeLine(String)' is missing an @Override annotation. 226229
InefficientStringBuffering Avoid concatenating nonliterals in a StringBuffer/StringBuilder constructor or append(). 228
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 237
UseObjectForClearerAPI Rather than using a lot of String arguments, consider using a container object for those values. 259
MissingOverride The method 'mvnReleasePerform(String, String, String, CommandResult, boolean, String)' is missing an @Override annotation. 259271
MissingOverride The method 'mvnReleasePrepare(String, String, String, String, String, String, CommandResult, String)' is missing an @Override annotation. 292307
UseObjectForClearerAPI Rather than using a lot of String arguments, consider using a container object for those values. 292293
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 313

fr/paris/lutece/plugins/releaser/service/ReleaseComponentTask.java

Rule Violation Ligne
DoNotUseThreads To be compliant to J2EE, a webapp should not use any thread. 59
ImmutableField Private field '_nIdWorkflow' could be made final; it is only initialized in the declaration or constructor. 66
ImmutableField Private field '_wfContext' could be made final; it is only initialized in the declaration or constructor. 69
ImmutableField Private field '_request' could be made final; it is only initialized in the declaration or constructor. 72
ImmutableField Private field '_user' could be made final; it is only initialized in the declaration or constructor. 75
ImmutableField Private field '_locale' could be made final; it is only initialized in the declaration or constructor. 78
MissingOverride The method 'run()' is missing an @Override annotation. 107178
UnusedLocalVariable Avoid unused local variables such as 'state'. 110

fr/paris/lutece/plugins/releaser/service/SiteResourceIdService.java

Rule Violation Ligne
CallSuperInConstructor It is a good practice to call super() in a constructor 7275
ShortVariable Avoid variables with short names like rt 80
ShortVariable Avoid variables with short names like p 86

fr/paris/lutece/plugins/releaser/service/SiteService.java

Rule Violation Ligne
ExcessiveImports A high number of imports can indicate a high degree of coupling within an object. 34910
GodClass Possible God Class (WMC=100, ATFD=148, TCC=0.000%) 83910
CyclomaticComplexity The class 'SiteService' has a total cyclomatic complexity of 100 (highest 14). 83910
TooManyMethods This class has too many methods, consider refactoring it. 84910
ConfusingTernary Avoid if (x != y) ..; else ..; 131147
CommentRequired Public method and constructor comments are required 187209
UselessOperationOnImmutable An operation on an Immutable object (String, BigDecimal or BigInteger) wont change the object itself 195
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 264
IdenticalCatchBranches 'catch' branch identical to 'InterruptedException' branch 283287
CyclomaticComplexity The method 'buildReleaseComments(Component, Locale)' has a cyclomatic complexity of 14. 465538
ConfusingTernary Avoid if (x != y) ..; else ..; 476537
ConfusingTernary Avoid if (x != y) ..; else ..; 509525
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 667
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 667
IdenticalCatchBranches 'catch' branch identical to 'FileNotFoundException' branch 818822
CommentRequired Public method and constructor comments are required 827886
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 830
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 839
CommentRequired Public method and constructor comments are required 888899
CommentRequired Public method and constructor comments are required 901908
SimplifyBooleanReturns Avoid unnecessary if..then..else statements when returning booleans 904905
ControlStatementBraces This statement should have braces 905

fr/paris/lutece/plugins/releaser/service/TwitterService.java

Rule Violation Ligne
RedundantFieldInitializer Avoid using redundant field initializer for '_twitter' 89
RedundantFieldInitializer Avoid using redundant field initializer for '_instance' 92
NonThreadSafeSingleton Singleton is not thread safe 101105
UnnecessaryConstructor Avoid unnecessary constructors - the compiler will generate these for you 113116
MissingOverride The method 'sendTweet(String, CommandResult)' is missing an @Override annotation. 126144
MissingOverride The method 'init()' is missing an @Override annotation. 149167

fr/paris/lutece/plugins/releaser/service/WorkflowReleaseContextService.java

Rule Violation Ligne
ExcessiveImports A high number of imports can indicate a high degree of coupling within an object. 34903
GodClass Possible God Class (WMC=64, ATFD=102, TCC=2.381%) 84903
TooManyMethods This class has too many methods, consider refactoring it. 85903
ImmutableField Private field '_mapWorkflowReleaseContext' could be made final; it is only initialized in the declaration or constructor. 91
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 91
LooseCoupling Avoid using implementation types like 'HashMap'; use the interface instead 91
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 97
LooseCoupling Avoid using implementation types like 'HashSet'; use the interface instead 97
ImmutableField Private field '_releaseInProgress' could be made final; it is only initialized in the declaration or constructor. 97
AvoidSynchronizedAtMethodLevel Use block level rather than method level synchronization 113135
ConfusingTernary Avoid if (x != y) ..; else ..; 123
MissingOverride The method 'saveWorkflowReleaseContext(WorkflowReleaseContext)' is missing an @Override annotation. 161199
AvoidSynchronizedAtMethodLevel Use block level rather than method level synchronization 161199
ConfusingTernary Avoid if (x != y) ..; else ..; 171192
ConfusingTernary Avoid if (x != y) ..; else ..; 188
MissingOverride The method 'getListWorkflowReleaseContextHistory(String)' is missing an @Override annotation. 233268
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 236
MissingOverride The method 'getIdWorkflow(WorkflowReleaseContext)' is missing an @Override annotation. 277293
NonThreadSafeSingleton Singleton is not thread safe 302307
CyclomaticComplexity The method 'mergeDevelopMaster(WorkflowReleaseContext, Locale)' has a cyclomatic complexity of 14. 320418
MissingOverride The method 'mergeDevelopMaster(WorkflowReleaseContext, Locale)' is missing an @Override annotation. 320418
ConfusingTernary Avoid if (x != y) ..; else ..; 342378
IdenticalCatchBranches 'catch' branch identical to 'InvalidRemoteException' branch 387391
IdenticalCatchBranches 'catch' branch identical to 'InvalidRemoteException' branch 392395
IdenticalCatchBranches 'catch' branch identical to 'InvalidRemoteException' branch 396399
NcssCount The method 'releasePrepareComponent(WorkflowReleaseContext, Locale)' has a NCSS line count of 71. 428586
MissingOverride The method 'releasePrepareComponent(WorkflowReleaseContext, Locale)' is missing an @Override annotation. 428586
CyclomaticComplexity The method 'releasePrepareComponent(WorkflowReleaseContext, Locale)' has a cyclomatic complexity of 12. 428586
ExcessiveMethodLength Avoid really long methods. 428586
AvoidDuplicateLiterals The String literal " to " appears 4 times in this file; the first occurrence is on line 464 464
MissingOverride The method 'releasePerformComponent(WorkflowReleaseContext, Locale)' is missing an @Override annotation. 596630
AvoidDuplicateLiterals The String literal " Release Perform" appears 4 times in this file; the first occurrence is on line 604 604
MissingOverride The method 'checkoutRepository(WorkflowReleaseContext, Locale)' is missing an @Override annotation. 640653
MissingOverride The method 'releasePrepareSite(WorkflowReleaseContext, Locale)' is missing an @Override annotation. 663727
AvoidDuplicateLiterals The String literal "...\n" appears 4 times in this file; the first occurrence is on line 676 676
MissingOverride The method 'sendTweet(WorkflowReleaseContext, Locale)' is missing an @Override annotation. 737748
MissingOverride The method 'updateJiraVersions(WorkflowReleaseContext, Locale)' is missing an @Override annotation. 758769
MissingOverride The method 'startWorkflowReleaseContext(WorkflowReleaseContext, int, Locale, HttpServletRequest, AdminUser)' is missing an @Override annotation. 785788
MissingOverride The method 'init()' is missing an @Override annotation. 793798
MissingOverride The method 'startReleaseInProgress(String)' is missing an @Override annotation. 806810
MissingOverride The method 'stopReleaseInProgress(String)' is missing an @Override annotation. 818822
MissingOverride The method 'isReleaseInProgress(String)' is missing an @Override annotation. 831835
MissingOverride The method 'createDockerImage(WorkflowReleaseContext, Locale)' is missing an @Override annotation. 889901
UnusedLocalVariable Avoid unused local variables such as 'commandResult'. 893

fr/paris/lutece/plugins/releaser/service/github/GitResourceService.java

Rule Violation Ligne
ExcessiveImports A high number of imports can indicate a high degree of coupling within an object. 34662
MissingOverride The method 'fetchPom(Site, String, String)' is missing an @Override annotation. 87100
CyclomaticComplexity The method 'getLastRelease(Site, String, String)' has a cyclomatic complexity of 15. 113184
MissingOverride The method 'getLastRelease(Site, String, String)' is missing an @Override annotation. 113184
ConfusingTernary Avoid if (x != y) ..; else ..; 125174
PositionLiteralsFirstInComparisons Position literals first in String comparisons 138
PositionLiteralsFirstInComparisons Position literals first in String comparisons 138
CollapsibleIfStatements These nested if statements could be combined 141146
AvoidDeeplyNestedIfStmts Deeply nested if..then statements are hard to read 141146
CyclomaticComplexity The method 'doCheckoutRepository(WorkflowReleaseContext, String, String)' has a cyclomatic complexity of 11. 198286
ConfusingTernary Avoid if (x != y) ..; else ..; 233244
AvoidDuplicateLiterals The String literal "/.git" appears 4 times in this file; the first occurrence is on line 329 329
IdenticalCatchBranches 'catch' branch identical to 'InvalidRemoteException' branch 343347
IdenticalCatchBranches 'catch' branch identical to 'InvalidRemoteException' branch 348351
IdenticalCatchBranches 'catch' branch identical to 'InvalidRemoteException' branch 352355
IdenticalCatchBranches 'catch' branch identical to 'InvalidRemoteException' branch 414418
IdenticalCatchBranches 'catch' branch identical to 'InvalidRemoteException' branch 419422
IdenticalCatchBranches 'catch' branch identical to 'InvalidRemoteException' branch 423426
ExcessiveMethodLength Avoid really long methods. 457572
CyclomaticComplexity The method 'rollbackRelease(WorkflowReleaseContext, Locale)' has a cyclomatic complexity of 15. 457572
ConfusingTernary Avoid if (x != y) ..; else ..; 505512
IdenticalCatchBranches 'catch' branch identical to 'InvalidRemoteException' branch 539543
IdenticalCatchBranches 'catch' branch identical to 'InvalidRemoteException' branch 544547
IdenticalCatchBranches 'catch' branch identical to 'InvalidRemoteException' branch 548551
IdenticalCatchBranches 'catch' branch identical to 'InvalidRemoteException' branch 628632
IdenticalCatchBranches 'catch' branch identical to 'InvalidRemoteException' branch 633636
IdenticalCatchBranches 'catch' branch identical to 'InvalidRemoteException' branch 637640

fr/paris/lutece/plugins/releaser/service/svn/SvnResourceService.java

Rule Violation Ligne
ExcessiveImports A high number of imports can indicate a high degree of coupling within an object. 34412
MissingOverride The method 'fetchPom(Site, String, String)' is missing an @Override annotation. 92112
AvoidLiteralsInIfCondition Avoid using Literals in Conditional Statements 106
MissingOverride The method 'getLastRelease(Site, String, String)' is missing an @Override annotation. 125160
ConfusingTernary Avoid if (x != y) ..; else ..; 146
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 173
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 262
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 310
ConfusingTernary Avoid if (x != y) ..; else ..; 355
CompareObjectsWithEquals Use equals() to compare object references. 357
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 371

fr/paris/lutece/plugins/releaser/util/CVSFactoryService.java

Rule Violation Ligne
UseUtilityClass All methods are static. Consider using a utility class instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning. 44104
UnnecessaryConstructor Avoid unnecessary constructors - the compiler will generate these for you 5861
UncommentedEmptyConstructor Document empty constructor 5861

fr/paris/lutece/plugins/releaser/util/CommandResult.java

Rule Violation Ligne
RedundantFieldInitializer Avoid using redundant field initializer for 'STATUS_ERROR' 52
RedundantFieldInitializer Avoid using redundant field initializer for 'ERROR_TYPE_INFO' 58
AvoidStringBufferField StringBuffers can grow quite a lot, and so may become a source of memory leak (if the owning class has a long life time). 64
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 88
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 88
CloneMethodReturnTypeMustMatchClassName The return type of the clone() method must be the class name when implements Cloneable 158167

fr/paris/lutece/plugins/releaser/util/MapperJsonUtil.java

Rule Violation Ligne
ShortVariable Avoid variables with short names like t 78

fr/paris/lutece/plugins/releaser/util/PluginUtils.java

Rule Violation Ligne
UseUtilityClass All methods are static. Consider using a utility class instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning. 66363
CyclomaticComplexity The method 'updateAppInfoFile(String, String, CommandResult)' has a cyclomatic complexity of 12. 185269
ShortVariable Avoid variables with short names like br 188
AvoidLiteralsInIfCondition Avoid using Literals in Conditional Statements 200
CollapsibleIfStatements These nested if statements could be combined 200213
ConfusingTernary Avoid if (x != y) ..; else ..; 203212
InefficientStringBuffering Avoid concatenating nonliterals in a StringBuffer/StringBuilder constructor or append(). 216
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 220
ShortVariable Avoid variables with short names like fw 244
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 250
ShortVariable Avoid variables with short names like fw 284
ShortVariable Avoid variables with short names like sw 301
ShortVariable Avoid variables with short names like tf 304
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 319
AvoidPrintStackTrace Avoid printStackTrace(); use a logger call instead. 334
CommentDefaultAccessModifier To avoid mistakes add a comment at the beginning of the ContextFileFilter nested class if you want a default access modifier 345361
MissingOverride The method 'accept(File, String)' is missing an @Override annotation. 357360

fr/paris/lutece/plugins/releaser/util/ReleaserUtils.java

Rule Violation Ligne
GodClass Possible God Class (WMC=59, ATFD=70, TCC=0.000%) 64589
TooManyMethods This class has too many methods, consider refactoring it. 65589
UseUtilityClass All methods are static. Consider using a utility class instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning. 65589
ConfusingTernary Avoid if (x != y) ..; else ..; 118129
ShortVariable Avoid variables with short names like e 242
ConfusingTernary Avoid if (x != y) ..; else ..; 245252
ShortVariable Avoid variables with short names like e 275
AvoidUncheckedExceptionsInSignatures A method or constructor should not explicitly declare unchecked exceptions in its 'throws' clause 275
ConfusingTernary Avoid if (x != y) ..; else ..; 278285
ConfusingTernary Avoid if (x != y) ..; else ..; 295302
AvoidUncheckedExceptionsInSignatures A method or constructor should not explicitly declare unchecked exceptions in its 'throws' clause 315
ConfusingTernary Avoid if (x != y) ..; else ..; 336
ConfusingTernary Avoid if (x != y) ..; else ..; 381
ConfusingTernary Avoid if (x != y) ..; else ..; 443
ForLoopCanBeForeach This for loop can be replaced by a foreach loop 467477
ConfusingTernary Avoid if (x != y) ..; else ..; 491
CommentRequired Public method and constructor comments are required 535543
CommentRequired Public method and constructor comments are required 545565
ConfusingTernary Avoid if (x != y) ..; else ..; 550562
ConfusingTernary Avoid if (x != y) ..; else ..; 555562
CommentRequired Public method and constructor comments are required 567586
AvoidLiteralsInIfCondition Avoid using Literals in Conditional Statements 570

fr/paris/lutece/plugins/releaser/util/file/FileUtils.java

Rule Violation Ligne
UseUtilityClass All methods are static. Consider using a utility class instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning. 48160
InefficientStringBuffering Avoid concatenating nonliterals in a StringBuffer/StringBuilder constructor or append(). 82
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 141

fr/paris/lutece/plugins/releaser/util/github/GitUtils.java

Rule Violation Ligne
ExcessiveImports A high number of imports can indicate a high degree of coupling within an object. 34788
GodClass Possible God Class (WMC=69, ATFD=39, TCC=0.000%) 89788
UseUtilityClass All methods are static. Consider using a utility class instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning. 90788
UseObjectForClearerAPI Rather than using a lot of String arguments, consider using a container object for those values. 118119
IdenticalCatchBranches 'catch' branch identical to 'InvalidRemoteException' branch 145149
IdenticalCatchBranches 'catch' branch identical to 'InvalidRemoteException' branch 150153
IdenticalCatchBranches 'catch' branch identical to 'InvalidRemoteException' branch 154158
IdenticalCatchBranches 'catch' branch identical to 'InvalidRemoteException' branch 193197
IdenticalCatchBranches 'catch' branch identical to 'InvalidRemoteException' branch 199202
IdenticalCatchBranches 'catch' branch identical to 'InvalidRemoteException' branch 229233
IdenticalCatchBranches 'catch' branch identical to 'InvalidRemoteException' branch 235238
IdenticalCatchBranches 'catch' branch identical to 'RefAlreadyExistsException' branch 267270
IdenticalCatchBranches 'catch' branch identical to 'RefAlreadyExistsException' branch 271274
IdenticalCatchBranches 'catch' branch identical to 'RefAlreadyExistsException' branch 275278
IdenticalCatchBranches 'catch' branch identical to 'RefAlreadyExistsException' branch 279282
UnnecessaryLocalBeforeReturn Consider simply returning the value vs storing it in local variable 'mergeResult' 400
ShortVariable Avoid variables with short names like i 419
UseStringBufferForStringAppends Prefer StringBuilder (non-synchronized) or StringBuffer (synchronized) over += for concatenating strings 424
UseStringBufferForStringAppends Prefer StringBuilder (non-synchronized) or StringBuffer (synchronized) over += for concatenating strings 425
UseStringBufferForStringAppends Prefer StringBuilder (non-synchronized) or StringBuffer (synchronized) over += for concatenating strings 426
ShortVariable Avoid variables with short names like i 445
UseObjectForClearerAPI Rather than using a lot of String arguments, consider using a container object for those values. 527
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 550
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 550
IdenticalCatchBranches 'catch' branch identical to 'HttpAccessException' branch 565568
UseObjectForClearerAPI Rather than using a lot of String arguments, consider using a container object for those values. 588
ShortVariable Avoid variables with short names like i 626
ForLoopCanBeForeach This for loop can be replaced by a foreach loop 644653
UnusedLocalVariable Avoid unused local variables such as 'tagName'. 647
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 711
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 712
CommentRequired Public method and constructor comments are required 736787
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 747

fr/paris/lutece/plugins/releaser/util/github/ReleaseGITGetRepoClient.java

Rule Violation Ligne
SingularField Perhaps 'bCancelled' could be replaced by a local variable. 44
UnusedPrivateField Avoid unused private fields such as 'bCancelled'. 44
UncommentedEmptyConstructor Document empty constructor 4951
UnnecessaryConstructor Avoid unnecessary constructors - the compiler will generate these for you 4951

fr/paris/lutece/plugins/releaser/util/maven/MavenUtils.java

Rule Violation Ligne
UseObjectForClearerAPI Rather than using a lot of String arguments, consider using a container object for those values. 7677
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 85

fr/paris/lutece/plugins/releaser/util/pom/PomParser.java

Rule Violation Ligne
ImmutableField Private field '_listDependencies' could be made final; it is only initialized in the declaration or constructor. 68
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 68
LooseCoupling Avoid using implementation types like 'ArrayList'; use the interface instead 68
LinguisticNaming Linguistics Antipattern - The variable 'isPOM' indicates linguistically it is a boolean, but it is 'InputSource' 92
LinguisticNaming Linguistics Antipattern - The variable 'isPOM' indicates linguistically it is a boolean, but it is 'InputSource' 155
ShortVariable Avoid variables with short names like op 162
ShortVariable Avoid variables with short names like op 203
ShortVariable Avoid variables with short names like jc 286
ShortVariable Avoid variables with short names like u 287

fr/paris/lutece/plugins/releaser/util/pom/PomUpdater.java

Rule Violation Ligne
UseUtilityClass All methods are static. Consider using a utility class instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning. 65276
CyclomaticComplexity The method 'updateSiteBeforeTag(Site, String)' has a cyclomatic complexity of 10. 78152
CollapsibleIfStatements These nested if statements could be combined 102105
AvoidDeeplyNestedIfStmts Deeply nested if..then statements are hard to read 102105
CyclomaticComplexity The method 'updateSiteAfterTag(Site, String)' has a cyclomatic complexity of 10. 165229
AvoidDeeplyNestedIfStmts Deeply nested if..then statements are hard to read 192195
CollapsibleIfStatements These nested if statements could be combined 192195
ShortVariable Avoid variables with short names like jc 247
ShortVariable Avoid variables with short names like m 248
ShortVariable Avoid variables with short names like jc 270
ShortVariable Avoid variables with short names like u 271

fr/paris/lutece/plugins/releaser/util/pom/SaxPomHandler.java

Rule Violation Ligne
CommentRequired Header comments are required 7230
AvoidStringBufferField StringBuffers can grow quite a lot, and so may become a source of memory leak (if the owning class has a long life time). 20
ImmutableField Private field '_sbScmUrl' could be made final; it is only initialized in the declaration or constructor. 20
AvoidStringBufferField StringBuffers can grow quite a lot, and so may become a source of memory leak (if the owning class has a long life time). 21
ImmutableField Private field '_sbScmConnection' could be made final; it is only initialized in the declaration or constructor. 21
ImmutableField Private field '_sbScmDeveloperConnection' could be made final; it is only initialized in the declaration or constructor. 22
AvoidStringBufferField StringBuffers can grow quite a lot, and so may become a source of memory leak (if the owning class has a long life time). 22
CyclomaticComplexity The method 'characters(char, int, int)' has a cyclomatic complexity of 13. 192229
ShortVariable Avoid variables with short names like ch 192
PositionLiteralsFirstInComparisons Position literals first in String comparisons 202

fr/paris/lutece/plugins/releaser/util/svn/ReleaseSvnCheckoutClient.java

Rule Violation Ligne
UnusedPrivateField Avoid unused private fields such as 'bCancelled'. 49
SingularField Perhaps 'bCancelled' could be replaced by a local variable. 49

fr/paris/lutece/plugins/releaser/util/svn/ReleaseSvnCommitClient.java

Rule Violation Ligne
UnusedPrivateField Avoid unused private fields such as 'bCancelled'. 48
SingularField Perhaps 'bCancelled' could be replaced by a local variable. 48

fr/paris/lutece/plugins/releaser/util/svn/ReleaseSvnCopyClient.java

Rule Violation Ligne
SingularField Perhaps 'bCancelled' could be replaced by a local variable. 48
UnusedPrivateField Avoid unused private fields such as 'bCancelled'. 48

fr/paris/lutece/plugins/releaser/util/svn/SvnUtils.java

Rule Violation Ligne
ExcessiveImports A high number of imports can indicate a high degree of coupling within an object. 34508
UnusedPrivateField Avoid unused private fields such as 'MESSAGE_ERROR_SVN'. 86
UnusedPrivateField Avoid unused private fields such as 'CONSTANTE_SLASH'. 89
UnusedPrivateField Avoid unused private fields such as 'logger'. 92
UseObjectForClearerAPI Rather than using a lot of String arguments, consider using a container object for those values. 163
CollapsibleIfStatements These nested if statements could be combined 207212
CommentRequired Public method and constructor comments are required 222225
MissingOverride The method 'checkCancelled()' is missing an @Override annotation. 222225
CommentRequired Public method and constructor comments are required 227230
MissingOverride The method 'handleEvent(SVNEvent, double)' is missing an @Override annotation. 227230
ShortVariable Avoid variables with short names like sw 245
ShortVariable Avoid variables with short names like pw 246
UnusedLocalVariable Avoid unused local variables such as 'errorLog'. 249
EmptyCatchBlock Avoid empty catch blocks 258262
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 269
ShortVariable Avoid variables with short names like sw 273
ShortVariable Avoid variables with short names like pw 274
UnusedLocalVariable Avoid unused local variables such as 'errorLog'. 277
EmptyCatchBlock Avoid empty catch blocks 286290
CommentRequired Public method and constructor comments are required 321331
MissingOverride The method 'handleDirEntry(SVNDirEntry)' is missing an @Override annotation. 321331
CollapsibleIfStatements These nested if statements could be combined 326329
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 350
UseObjectForClearerAPI Rather than using a lot of String arguments, consider using a container object for those values. 413

fr/paris/lutece/plugins/releaser/util/version/Version.java

Rule Violation Ligne
GodClass Possible God Class (WMC=71, ATFD=22, TCC=29.735%) 47731
UncommentedEmptyConstructor Document empty constructor 8991
CommentRequired Public method and constructor comments are required 205207
CommentRequired Public method and constructor comments are required 209211
CommentRequired Public method and constructor comments are required 213215
CommentRequired Public method and constructor comments are required 217219
CyclomaticComplexity The method 'compareTo(Object)' has a cyclomatic complexity of 16. 229287
ConfusingTernary Avoid if (x != y) ..; else ..; 248284
CompareObjectsWithEquals Use equals() to compare object references. 265
ConfusingTernary Avoid if (x != y) ..; else ..; 300307
ConfusingTernary Avoid if (x != y) ..; else ..; 338
AvoidLiteralsInIfCondition Avoid using Literals in Conditional Statements 343
ConfusingTernary Avoid if (x != y) ..; else ..; 369380
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 382
AvoidDuplicateLiterals The String literal "Error parsing version " appears 7 times in this file; the first occurrence is on line 550 550
AvoidDuplicateLiterals The String literal " : " appears 7 times in this file; the first occurrence is on line 550 550
EmptyIfStmt Avoid empty if statements 634637

fr/paris/lutece/plugins/releaser/util/version/VersionParsingException.java

Rule Violation Ligne
MissingSerialVersionUID Classes implementing Serializable should set a serialVersionUID 4055

fr/paris/lutece/plugins/releaser/web/ClusterJspBean.java

Rule Violation Ligne
MissingSerialVersionUID Classes implementing Serializable should set a serialVersionUID 70615
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 165
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 166
ConfusingTernary Avoid if (x != y) ..; else ..; 207
ConfusingTernary Avoid if (x != y) ..; else ..; 449

fr/paris/lutece/plugins/releaser/web/ManageComponentReleaseJspBean.java

Rule Violation Ligne
MissingSerialVersionUID Classes implementing Serializable should set a serialVersionUID 65322
CommentDefaultAccessModifier To avoid mistakes add a comment at the beginning of the _paginatorComponents field if you want a default access modifier 126
DefaultPackage Use explicit scoping instead of the default package private level 126
CyclomaticComplexity The method 'getManageComponent(HttpServletRequest)' has a cyclomatic complexity of 12. 137179
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 145
UnusedLocalVariable Avoid unused local variables such as 'user'. 145
ConfusingTernary Avoid if (x != y) ..; else ..; 147169
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 168
ConfusingTernary Avoid if (x != y) ..; else ..; 173
ConfusingTernary Avoid if (x != y) ..; else ..; 175
UnnecessaryAnnotationValueElement Avoid the use of value in annotations when its the only element 253
UnusedLocalVariable Avoid unused local variables such as 'component'. 261
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 261
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 283
UnusedLocalVariable Avoid unused local variables such as 'component'. 283
LinguisticNaming Linguistics Antipattern - The setter 'setReleaserUser' should not return any type except void linguistically 288301

fr/paris/lutece/plugins/releaser/web/ManageSiteReleaseJspBean.java

Rule Violation Ligne
ExcessiveImports A high number of imports can indicate a high degree of coupling within an object. 34701
MissingSerialVersionUID Classes implementing Serializable should set a serialVersionUID 74701
TooManyMethods This class has too many methods, consider refactoring it. 75701
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 217
UnnecessaryAnnotationValueElement Avoid the use of value in annotations when its the only element 266
CyclomaticComplexity The method 'getConfirmReleaseSite(HttpServletRequest)' has a cyclomatic complexity of 11. 267313
NPathComplexity The method 'getConfirmReleaseSite(HttpServletRequest)' has an NPath complexity of 324 267313
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 272
UnnecessaryAnnotationValueElement Avoid the use of value in annotations when its the only element 322
UnnecessaryAnnotationValueElement Avoid the use of value in annotations when its the only element 349
ConfusingTernary Avoid if (x != y) ..; else ..; 357376
ConfusingTernary Avoid if (x != y) ..; else ..; 361370
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 505
UnnecessaryAnnotationValueElement Avoid the use of value in annotations when its the only element 562
UnnecessaryLocalBeforeReturn Consider simply returning the value vs storing it in local variable 'strTemplate' 575
UnnecessaryAnnotationValueElement Avoid the use of value in annotations when its the only element 633
UnusedLocalVariable Avoid unused local variables such as 'component'. 641
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 641
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 662
UnusedLocalVariable Avoid unused local variables such as 'component'. 662
LinguisticNaming Linguistics Antipattern - The setter 'setReleaserUser' should not return any type except void linguistically 668681

fr/paris/lutece/plugins/releaser/web/ManageSitesJspBean.java

Rule Violation Ligne
MissingSerialVersionUID Classes implementing Serializable should set a serialVersionUID 4999
SingularField Perhaps '_nDefaultItemsPerPage' could be replaced by a local variable. 62

Priority 4

fr/paris/lutece/plugins/releaser/business/Component.java

Rule Violation Ligne
UnusedImports Avoid unused imports such as 'fr.paris.lutece.plugins.releaser.util.github.GitUtils' 39

fr/paris/lutece/plugins/releaser/business/IReleaserResource.java

Rule Violation Ligne
UnusedImports Avoid unused imports such as 'org.apache.commons.lang3.StringUtils' 36

fr/paris/lutece/plugins/releaser/business/IWorkflowContextHistoryDAO.java

Rule Violation Ligne
UnusedImports Avoid unused imports such as 'fr.paris.lutece.util.ReferenceList' 72

fr/paris/lutece/plugins/releaser/business/Site.java

Rule Violation Ligne
ShortClassName Avoid short class names like Site 51637

fr/paris/lutece/plugins/releaser/business/WorkflowContextHistoryHome.java

Rule Violation Ligne
UnusedImports Avoid unused imports such as 'fr.paris.lutece.util.ReferenceList' 73

fr/paris/lutece/plugins/releaser/service/IComponentService.java

Rule Violation Ligne
UnusedImports Avoid unused imports such as 'fr.paris.lutece.plugins.releaser.business.Site' 44

fr/paris/lutece/plugins/releaser/service/JiraComponentService.java

Rule Violation Ligne
UnusedImports Avoid unused imports such as 'com.atlassian.jira.rest.client.api.domain.IssueField' 51

fr/paris/lutece/plugins/releaser/service/MavenRepoComponentInfoProvider.java

Rule Violation Ligne
UnusedImports Avoid unused imports such as 'java.io.Serializable' 5
UnusedImports Avoid unused imports such as 'java.util.Collections' 8
UnusedImports Avoid unused imports such as 'java.util.Comparator' 9
UnusedImports Avoid unused imports such as 'java.util.Date' 10
UnusedImports Avoid unused imports such as 'java.util.HashMap' 11
UnusedImports Avoid unused imports such as 'java.util.regex.Matcher' 14
UnusedImports Avoid unused imports such as 'java.util.regex.Pattern' 15
UnusedImports Avoid unused imports such as 'org.apache.commons.collections.MapUtils' 23
UnusedImports Avoid unused imports such as 'org.apache.commons.lang3.math.NumberUtils' 24
UnusedImports Avoid unused imports such as 'java.time.ZonedDateTime' 25
UnusedImports Avoid unused imports such as 'java.time.format.DateTimeFormatter' 26
UnusedImports Avoid unused imports such as 'java.time.format.DateTimeParseException' 27
UnusedImports Avoid unused imports such as 'fr.paris.lutece.portal.service.datastore.DatastoreService' 34
UnusedImports Avoid unused imports such as 'fr.paris.lutece.portal.service.spring.SpringContextService' 35

fr/paris/lutece/plugins/releaser/service/MavenService.java

Rule Violation Ligne
UnusedImports Avoid unused imports such as 'fr.paris.lutece.util.string.StringUtil' 56

fr/paris/lutece/plugins/releaser/service/SiteService.java

Rule Violation Ligne
UnusedImports Avoid unused imports such as 'fr.paris.lutece.portal.service.plugin.Plugin' 72

fr/paris/lutece/plugins/releaser/service/svn/SvnResourceService.java

Rule Violation Ligne
UnusedImports Avoid unused imports such as 'java.io.IOException' 37
UnusedImports Avoid unused imports such as 'java.io.PrintWriter' 38
UnusedImports Avoid unused imports such as 'java.io.StringWriter' 39
UnusedImports Avoid unused imports such as 'org.apache.commons.lang3.ObjectUtils' 44
UnusedImports Avoid unused imports such as 'org.apache.commons.lang3.StringUtils' 45
UnusedImports Avoid unused imports such as 'org.tmatesoft.svn.core.SVNCancelException' 46
UnusedImports Avoid unused imports such as 'org.tmatesoft.svn.core.SVNException' 47
UnusedImports Avoid unused imports such as 'org.tmatesoft.svn.core.wc.ISVNEventHandler' 49
UnusedImports Avoid unused imports such as 'org.tmatesoft.svn.core.wc.SVNEvent' 50
UnusedImports Avoid unused imports such as 'org.tmatesoft.svn.core.wc.SVNEventAction' 51
UnusedImports Avoid unused imports such as 'fr.paris.lutece.plugins.releaser.business.RepositoryType' 54
UnusedImports Avoid unused imports such as 'fr.paris.lutece.plugins.releaser.util.svn.ReleaseSvnCopyClient' 65

fr/paris/lutece/plugins/releaser/util/PluginUtils.java

Rule Violation Ligne
UnusedImports Avoid unused imports such as 'javax.xml.parsers.ParserConfigurationException' 48
UnusedImports Avoid unused imports such as 'javax.xml.transform.TransformerException' 50
UnusedImports Avoid unused imports such as 'org.eclipse.jgit.api.errors.NoFilepatternException' 55
UnusedImports Avoid unused imports such as 'org.xml.sax.SAXException' 59

fr/paris/lutece/plugins/releaser/util/pom/PomParser.java

Rule Violation Ligne
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'fr.paris.lutece.plugins.releaser.business.jaxb.maven.Model.Dependencies' due to existing import 'fr.paris.lutece.plugins.releaser.business.jaxb.maven.Model' 97

fr/paris/lutece/plugins/releaser/util/pom/PomUpdater.java

Rule Violation Ligne
UnusedImports Avoid unused imports such as 'java.util.Iterator' 42
UnusedImports Avoid unused imports such as 'fr.paris.lutece.portal.service.i18n.I18nService' 56
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'fr.paris.lutece.plugins.releaser.business.jaxb.maven.Model.Dependencies' due to existing import 'fr.paris.lutece.plugins.releaser.business.jaxb.maven.Model' 92
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'fr.paris.lutece.plugins.releaser.business.jaxb.maven.Model.Dependencies' due to existing import 'fr.paris.lutece.plugins.releaser.business.jaxb.maven.Model' 180

fr/paris/lutece/plugins/releaser/web/ManageSiteReleaseJspBean.java

Rule Violation Ligne
UnusedImports Avoid unused imports such as 'fr.paris.lutece.portal.service.i18n.I18nService' 49

Fichiers

fr/paris/lutece/plugins/releaser/business/AbstractReleaserResource.java

Rule Violation Priority Ligne
ConfusingTernary Avoid if (x != y) ..; else ..; 3 5775
ConfusingTernary Avoid if (x != y) ..; else ..; 3 100107
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 3 115

fr/paris/lutece/plugins/releaser/business/Cluster.java

Rule Violation Priority Ligne
LooseCoupling Avoid using implementation types like 'HashMap'; use the interface instead 3 59
FieldNamingConventions The field name 'permissions' doesn't match '_[a-z][a-zA-Z0-9]*' 1 59
LooseCoupling Avoid using implementation types like 'HashMap'; use the interface instead 3 170
LooseCoupling Avoid using implementation types like 'HashMap'; use the interface instead 3 175

fr/paris/lutece/plugins/releaser/business/ClusterDAO.java

Rule Violation Priority Ligne
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 3 158
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 3 184

fr/paris/lutece/plugins/releaser/business/Component.java

Rule Violation Priority Ligne
ExcessivePublicCount This class has a bunch of public methods and attributes 3 34779
UnusedImports Avoid unused imports such as 'fr.paris.lutece.plugins.releaser.util.github.GitUtils' 4 39
TooManyFields Too many fields 3 47779
FieldNamingConventions The field name 'permissions' doesn't match '_[a-z][a-zA-Z0-9]*' 1 54
LooseCoupling Avoid using implementation types like 'HashMap'; use the interface instead 3 54
UnusedPrivateField Avoid unused private fields such as '_strDescription'. 3 82
MissingOverride The method 'getArtifactId()' is missing an @Override annotation. 3 151154
MissingOverride The method 'getTargetVersion()' is missing an @Override annotation. 3 235238
SimplifyBooleanReturns Avoid unnecessary if..then..else statements when returning booleans 3 448452
FormalParameterNamingConventions The method parameter name '_strScmDeveloperConnection' doesn't match '[a-z][a-zA-Z0-9]*' 1 472
FormalParameterNamingConventions The method parameter name '_bUpgrade' doesn't match '[a-z][a-zA-Z0-9]*' 1 503
FormalParameterNamingConventions The method parameter name '_bDowngrade' doesn't match '[a-z][a-zA-Z0-9]*' 1 524
FormalParameterNamingConventions The method parameter name '_strLastAvailableSnapshotVersion' doesn't match '[a-z][a-zA-Z0-9]*' 1 555
FormalParameterNamingConventions The method parameter name '_bErrorLastRelease' doesn't match '[a-z][a-zA-Z0-9]*' 1 576
FormalParameterNamingConventions The method parameter name '_strName' doesn't match '[a-z][a-zA-Z0-9]*' 1 597
FormalParameterNamingConventions The method parameter name '_strCloneUrl' doesn't match '[a-z][a-zA-Z0-9]*' 1 618
FormalParameterNamingConventions The method parameter name '_strTweetMessage' doesn't match '[a-z][a-zA-Z0-9]*' 1 660
LooseCoupling Avoid using implementation types like 'HashMap'; use the interface instead 3 689
LooseCoupling Avoid using implementation types like 'HashMap'; use the interface instead 3 694
CommentRequired Public method and constructor comments are required 3 699702
CommentRequired Public method and constructor comments are required 3 704707
CommentRequired Public method and constructor comments are required 3 709712
FormalParameterNamingConventions The method parameter name '_strBranchReleaseFrom' doesn't match '[a-z][a-zA-Z0-9]*' 1 714
CommentRequired Public method and constructor comments are required 3 714717
CommentRequired Public method and constructor comments are required 3 719722
CommentRequired Public method and constructor comments are required 3 724727
FormalParameterNamingConventions The method parameter name '_strBranchReleaseVersion' doesn't match '[a-z][a-zA-Z0-9]*' 1 724
CommentRequired Public method and constructor comments are required 3 729731
CommentRequired Public method and constructor comments are required 3 733735
FormalParameterNamingConventions The method parameter name '_strTargetJdk' doesn't match '[a-z][a-zA-Z0-9]*' 1 733

fr/paris/lutece/plugins/releaser/business/IReleaserResource.java

Rule Violation Priority Ligne
UnusedImports Avoid unused imports such as 'org.apache.commons.lang3.StringUtils' 4 36

fr/paris/lutece/plugins/releaser/business/IWorkflowContextHistoryDAO.java

Rule Violation Priority Ligne
UnusedImports Avoid unused imports such as 'fr.paris.lutece.util.ReferenceList' 4 72

fr/paris/lutece/plugins/releaser/business/ReleaserUser.java

Rule Violation Priority Ligne
ImmutableField Private field '_mapCredential' could be made final; it is only initialized in the declaration or constructor. 3 54
LooseCoupling Avoid using implementation types like 'HashMap'; use the interface instead 3 54
FieldDeclarationsShouldBeAtStartOfClass Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. 3 115
ImmutableField Private field '_strLogin' could be made final; it is only initialized in the declaration or constructor. 3 115
FieldDeclarationsShouldBeAtStartOfClass Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. 3 118
ImmutableField Private field '_strPassword' could be made final; it is only initialized in the declaration or constructor. 3 118

fr/paris/lutece/plugins/releaser/business/Site.java

Rule Violation Priority Ligne
ExcessivePublicCount This class has a bunch of public methods and attributes 3 34637
ShortClassName Avoid short class names like Site 4 51637
TooManyFields Too many fields 3 51637
FieldNamingConventions The field name 'permissions' doesn't match '_[a-z][a-zA-Z0-9]*' 1 62
LooseCoupling Avoid using implementation types like 'HashMap'; use the interface instead 3 62
ImmutableField Private field '_listCurrentDependencies' could be made final; it is only initialized in the declaration or constructor. 3 106
ImmutableField Private field '_listComponents' could be made final; it is only initialized in the declaration or constructor. 3 109
MissingOverride The method 'getArtifactId()' is missing an @Override annotation. 3 173176
MissingOverride The method 'getScmUrl()' is missing an @Override annotation. 3 215218
FormalParameterNamingConventions The method parameter name '_strTagInfotmation' doesn't match '[a-z][a-zA-Z0-9]*' 1 499
FormalParameterNamingConventions The method parameter name '_strGroupId' doesn't match '[a-z][a-zA-Z0-9]*' 1 520
FormalParameterNamingConventions The method parameter name '_bTheme' doesn't match '[a-z][a-zA-Z0-9]*' 1 541
CommentRequired Public method and constructor comments are required 3 546549
FormalParameterNamingConventions The method parameter name '_bCreateDckerImage' doesn't match '[a-z][a-zA-Z0-9]*' 1 551
CommentRequired Public method and constructor comments are required 3 551553
CommentRequired Public method and constructor comments are required 3 555558
CommentRequired Public method and constructor comments are required 3 560563
CommentRequired Public method and constructor comments are required 3 565568
FormalParameterNamingConventions The method parameter name '_strBranchReleaseFrom' doesn't match '[a-z][a-zA-Z0-9]*' 1 570
CommentRequired Public method and constructor comments are required 3 570573
LooseCoupling Avoid using implementation types like 'HashMap'; use the interface instead 3 609
LooseCoupling Avoid using implementation types like 'HashMap'; use the interface instead 3 614
ControlStatementBraces This statement should have braces 3 617
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 3 617
ControlStatementBraces This statement should have braces 3 619
CommentRequired Public method and constructor comments are required 3 627630
CommentRequired Public method and constructor comments are required 3 632635
FormalParameterNamingConventions The method parameter name '_strParentVersion' doesn't match '[a-z][a-zA-Z0-9]*' 1 632

fr/paris/lutece/plugins/releaser/business/SiteDAO.java

Rule Violation Priority Ligne
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 3 182
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 3 214
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 3 252
UnusedLocalVariable Avoid unused local variables such as 'nIndex'. 3 294
ControlStatementBraces This statement should have braces 3 296

fr/paris/lutece/plugins/releaser/business/WorkflowContextHistory.java

Rule Violation Priority Ligne
FormalParameterNamingConventions The method parameter name '_dateBegin' doesn't match '[a-z][a-zA-Z0-9]*' 1 181
FormalParameterNamingConventions The method parameter name '_dateEnd' doesn't match '[a-z][a-zA-Z0-9]*' 1 202
FormalParameterNamingConventions The method parameter name '_strArtifactId' doesn't match '[a-z][a-zA-Z0-9]*' 1 223

fr/paris/lutece/plugins/releaser/business/WorkflowContextHistoryHome.java

Rule Violation Priority Ligne
UnusedImports Avoid unused imports such as 'fr.paris.lutece.util.ReferenceList' 4 73

fr/paris/lutece/plugins/releaser/business/WorkflowReleaseContext.java

Rule Violation Priority Ligne
FormalParameterNamingConventions The method parameter name '_nId' doesn't match '[a-z][a-zA-Z0-9]*' 1 98
FormalParameterNamingConventions The method parameter name '_component' doesn't match '[a-z][a-zA-Z0-9]*' 1 119
FormalParameterNamingConventions The method parameter name '_commandResult' doesn't match '[a-z][a-zA-Z0-9]*' 1 140
FormalParameterNamingConventions The method parameter name '_releaserUser' doesn't match '[a-z][a-zA-Z0-9]*' 1 194
FormalParameterNamingConventions The method parameter name '_strRefBranchRelease' doesn't match '[a-z][a-zA-Z0-9]*' 1 215
FormalParameterNamingConventions The method parameter name '_strRefBranchReleaseFrom' doesn't match '[a-z][a-zA-Z0-9]*' 1 236

fr/paris/lutece/plugins/releaser/service/ClusterResourceIdService.java

Rule Violation Priority Ligne
CommentRequired Header comments are required 3 48147
DataClass The class 'ClusterResourceIdService' is suspected to be a Data Class (WOC=0.000%, NOPA=4, NOAM=0, WMC=1) 3 48147
CallSuperInConstructor It is a good practice to call super() in a constructor 3 7174
ShortVariable Avoid variables with short names like rt 3 80
ShortVariable Avoid variables with short names like p 3 86

fr/paris/lutece/plugins/releaser/service/ClusterService.java

Rule Violation Priority Ligne
UseUtilityClass All methods are static. Consider using a utility class instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning. 3 51169
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 3 82
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 3 86
ControlStatementBraces This statement should have braces 3 140
CommentRequired Public method and constructor comments are required 3 146155
MethodNamingConventions The static method name 'IsAddClusterAuthorized' doesn't match '[a-z][a-zA-Z0-9]*' 1 146155
SimplifyBooleanReturns Avoid unnecessary if..then..else statements when returning booleans 3 149152
MethodNamingConventions The static method name 'IsUserAuthorized' doesn't match '[a-z][a-zA-Z0-9]*' 1 157168
CommentRequired Public method and constructor comments are required 3 157168

fr/paris/lutece/plugins/releaser/service/ComponentResourceIdService.java

Rule Violation Priority Ligne
CommentRequired Header comments are required 3 4595
CallSuperInConstructor It is a good practice to call super() in a constructor 3 5659
ShortVariable Avoid variables with short names like rt 3 65
ShortVariable Avoid variables with short names like p 3 71

fr/paris/lutece/plugins/releaser/service/ComponentService.java

Rule Violation Priority Ligne
ExcessiveImports A high number of imports can indicate a high degree of coupling within an object. 3 34525
UnusedPrivateField Avoid unused private fields such as '_executor'. 3 83
SingularField Perhaps '_executor' could be replaced by a local variable. 3 83
SingularField Perhaps '_mapper' could be replaced by a local variable. 3 84
UnusedPrivateField Avoid unused private fields such as '_mapper'. 3 84
NonThreadSafeSingleton Singleton is not thread safe 3 9397
CommentRequired Public method and constructor comments are required 3 103106
MissingOverride The method 'setRemoteInformations(Component, boolean)' is missing an @Override annotation. 3 103106
MissingOverride The method 'getLastReleaseVersion(String)' is missing an @Override annotation. 3 113118
MissingOverride The method 'setLastReleaseVersion(String, String)' is missing an @Override annotation. 3 125130
MissingOverride The method 'getLastReleaseNextSnapshotVersion(String)' is missing an @Override annotation. 3 137142
MissingOverride The method 'setLastReleaseNextSnapshotVersion(String, String)' is missing an @Override annotation. 3 149153
MissingOverride The method 'release(Component, Locale, AdminUser, HttpServletRequest)' is missing an @Override annotation. 3 179182
CommentRequired Public method and constructor comments are required 3 179182
MissingOverride The method 'isGitComponent(Component)' is missing an @Override annotation. 3 184188
CommentRequired Public method and constructor comments are required 3 184188
CommentRequired Public method and constructor comments are required 3 190196
MissingOverride The method 'init()' is missing an @Override annotation. 3 190196
CyclomaticComplexity The method 'updateRemoteInformations(Component)' has a cyclomatic complexity of 11. 3 199247
MissingOverride The method 'getSearchComponent(String, HttpServletRequest, Locale, String, String)' is missing an @Override annotation. 3 249282
CommentRequired Public method and constructor comments are required 3 249282
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 3 264
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 3 278279
UnusedFormalParameter Avoid unused method parameters such as 'strUser'. 3 284
UnusedFormalParameter Avoid unused method parameters such as 'strPassword'. 3 284
MissingOverride The method 'loadComponent(Component, String, String, String)' is missing an @Override annotation. 3 307338
CommentRequired Public method and constructor comments are required 3 307338
AvoidReassigningParameters Avoid reassigning parameters such as 'component' 2 307
AvoidReassigningParameters Avoid reassigning parameters such as 'component' 2 307
ConfusingTernary Avoid if (x != y) ..; else ..; 3 342350
EmptyIfStmt Avoid empty if statements 3 347350
CommentRequired Public method and constructor comments are required 3 372402
MissingOverride The method 'isErrorSnapshotComponentInformations(Component, String)' is missing an @Override annotation. 3 372402
AvoidFileStream Avoid instantiating FileInputStream, FileOutputStream, FileReader, or FileWriter 1 383
MissingOverride The method 'changeNextReleaseVersion(Component)' is missing an @Override annotation. 3 410422
MethodNamingConventions The static method name 'IsSearchComponentAuthorized' doesn't match '[a-z][a-zA-Z0-9]*' 1 424433
CommentRequired Public method and constructor comments are required 3 424433
SimplifyBooleanReturns Avoid unnecessary if..then..else statements when returning booleans 3 427430
CommentRequired Public method and constructor comments are required 3 476523
AvoidReassigningParameters Avoid reassigning parameters such as 'component' 2 476
MissingOverride The method 'getLastBranchVersion(Component, String, ReleaserUser)' is missing an @Override annotation. 3 476523

fr/paris/lutece/plugins/releaser/service/GetRemoteInformationsTask.java

Rule Violation Priority Ligne
DoNotUseThreads To be compliant to J2EE, a webapp should not use any thread. 3 46
ImmutableField Private field '_component' could be made final; it is only initialized in the declaration or constructor. 3 49

fr/paris/lutece/plugins/releaser/service/IComponentService.java

Rule Violation Priority Ligne
UnusedImports Avoid unused imports such as 'fr.paris.lutece.plugins.releaser.business.Site' 4 44
CommentRequired Public method and constructor comments are required 3 231

fr/paris/lutece/plugins/releaser/service/IJenkinsService.java

Rule Violation Priority Ligne
CommentRequired Header comments are required 3 513
UnnecessaryModifier Unnecessary modifiers 'public abstract' on method 'init': the method is declared in an interface type 3 10
MethodNamingConventions The instance method name 'TriggerPipeline' doesn't match '[a-z][a-zA-Z0-9]*' 1 12
CommentRequired Public method and constructor comments are required 3 12

fr/paris/lutece/plugins/releaser/service/IJiraService.java

Rule Violation Priority Ligne
UnnecessaryModifier Unnecessary modifiers 'public abstract' on method 'init': the method is declared in an interface type 3 48
UnnecessaryModifier Unnecessary modifiers 'public abstract' on method 'updateComponentVersions': the method is declared in an interface type 3 58

fr/paris/lutece/plugins/releaser/service/IMavenService.java

Rule Violation Priority Ligne
UseObjectForClearerAPI Rather than using a lot of String arguments, consider using a container object for those values. 3 8182
UseObjectForClearerAPI Rather than using a lot of String arguments, consider using a container object for those values. 3 98

fr/paris/lutece/plugins/releaser/service/IWorkflowReleaseContextService.java

Rule Violation Priority Ligne
TooManyMethods This class has too many methods, consider refactoring it. 3 49231

fr/paris/lutece/plugins/releaser/service/JenkinsService.java

Rule Violation Priority Ligne
CommentRequired Header comments are required 3 18162
FieldNamingConventions The static field name 'JENKINS_BASE_URL' doesn't match '_[a-z][a-zA-Z0-9]*' 1 39
FieldNamingConventions The static field name 'JENKINS_PIPELINE_NAME' doesn't match '_[a-z][a-zA-Z0-9]*' 1 42
FieldNamingConventions The static field name 'JENKINS_BUILD_TYPE' doesn't match '_[a-z][a-zA-Z0-9]*' 1 45
FieldNamingConventions The static field name 'JENKINS_USER_LOGIN' doesn't match '_[a-z][a-zA-Z0-9]*' 1 48
FieldNamingConventions The static field name 'JENKINS_USER_PWD' doesn't match '_[a-z][a-zA-Z0-9]*' 1 51
RedundantFieldInitializer Avoid using redundant field initializer for '_instance' 3 54
NonThreadSafeSingleton Singleton is not thread safe 3 6367
CyclomaticComplexity The method 'TriggerPipeline(WorkflowReleaseContext)' has a cyclomatic complexity of 10. 3 83161
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 3 97
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 3 98
LocalVariableNamingConventions The local variable name 'ObjectBuildJson' doesn't match '[a-z][a-zA-Z0-9]*' 1 135
IdenticalCatchBranches 'catch' branch identical to 'HttpAccessException' branch 3 151154
IdenticalCatchBranches 'catch' branch identical to 'HttpAccessException' branch 3 155158

fr/paris/lutece/plugins/releaser/service/JiraComponentService.java

Rule Violation Priority Ligne
ExcessiveImports A high number of imports can indicate a high degree of coupling within an object. 3 34286
UnusedImports Avoid unused imports such as 'com.atlassian.jira.rest.client.api.domain.IssueField' 4 51
FieldNamingConventions The static field name 'URL_JIRA_SERVER' doesn't match '_[a-z][a-zA-Z0-9]*' 1 87
FieldNamingConventions The static field name 'JIRA_USER' doesn't match '_[a-z][a-zA-Z0-9]*' 1 90
FieldNamingConventions The static field name 'JIRA_USER_PWD' doesn't match '_[a-z][a-zA-Z0-9]*' 1 93
UncommentedEmptyConstructor Document empty constructor 3 110113
UnnecessaryConstructor Avoid unnecessary constructors - the compiler will generate these for you 3 110113
NonThreadSafeSingleton Singleton is not thread safe 3 122126
CyclomaticComplexity The method 'updateComponentVersions(Component, CommandResult)' has a cyclomatic complexity of 12. 3 185284
AvoidSynchronizedAtMethodLevel Use block level rather than method level synchronization 3 185284
ConfusingTernary Avoid if (x != y) ..; else ..; 3 191282
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 3 229
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 3 230
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 3 230
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 3 259

fr/paris/lutece/plugins/releaser/service/MavenRepoComponentInfoProvider.java

Rule Violation Priority Ligne
ExcessiveImports A high number of imports can indicate a high degree of coupling within an object. 3 2413
UnusedImports Avoid unused imports such as 'java.io.Serializable' 4 5
UnusedImports Avoid unused imports such as 'java.util.Collections' 4 8
UnusedImports Avoid unused imports such as 'java.util.Comparator' 4 9
UnusedImports Avoid unused imports such as 'java.util.Date' 4 10
UnusedImports Avoid unused imports such as 'java.util.HashMap' 4 11
UnusedImports Avoid unused imports such as 'java.util.regex.Matcher' 4 14
UnusedImports Avoid unused imports such as 'java.util.regex.Pattern' 4 15
UnusedImports Avoid unused imports such as 'org.apache.commons.collections.MapUtils' 4 23
UnusedImports Avoid unused imports such as 'org.apache.commons.lang3.math.NumberUtils' 4 24
UnusedImports Avoid unused imports such as 'java.time.ZonedDateTime' 4 25
UnusedImports Avoid unused imports such as 'java.time.format.DateTimeFormatter' 4 26
UnusedImports Avoid unused imports such as 'java.time.format.DateTimeParseException' 4 27
UnusedImports Avoid unused imports such as 'fr.paris.lutece.portal.service.datastore.DatastoreService' 4 34
UnusedImports Avoid unused imports such as 'fr.paris.lutece.portal.service.spring.SpringContextService' 4 35
GodClass Possible God Class (WMC=48, ATFD=24, TCC=1.818%) 3 44413
UnusedPrivateField Avoid unused private fields such as 'URL_MAVEN_PATH_SITE_POM'. 3 72
AvoidSynchronizedAtMethodLevel Use block level rather than method level synchronization 3 99106
CommentRequired Public method and constructor comments are required 3 108153
ConfusingTernary Avoid if (x != y) ..; else ..; 3 119128
ConfusingTernary Avoid if (x != y) ..; else ..; 3 132145
ControlStatementBraces This statement should have braces 3 140
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 3 148
ConfusingTernary Avoid if (x != y) ..; else ..; 3 227242
UnusedPrivateMethod Avoid unused private methods such as 'getPomUrl(String,String,String)'. 3 269
AvoidLiteralsInIfCondition Avoid using Literals in Conditional Statements 3 273
UseEqualsToCompareStrings Use equals() to compare strings instead of '==' or '!=' 3 273
UseStringBufferForStringAppends Prefer StringBuilder (non-synchronized) or StringBuffer (synchronized) over += for concatenating strings 3 275
UseStringBufferForStringAppends Prefer StringBuilder (non-synchronized) or StringBuffer (synchronized) over += for concatenating strings 3 278
UseStringBufferForStringAppends Prefer StringBuilder (non-synchronized) or StringBuffer (synchronized) over += for concatenating strings 3 280
UnusedFormalParameter Avoid unused method parameters such as 'strArtifactId'. 3 285
UseEqualsToCompareStrings Use equals() to compare strings instead of '==' or '!=' 3 289
AvoidLiteralsInIfCondition Avoid using Literals in Conditional Statements 3 289
UseStringBufferForStringAppends Prefer StringBuilder (non-synchronized) or StringBuffer (synchronized) over += for concatenating strings 3 291
UseStringBufferForStringAppends Prefer StringBuilder (non-synchronized) or StringBuffer (synchronized) over += for concatenating strings 3 293
UnusedLocalVariable Avoid unused local variables such as 'listVersions'. 3 298
StringToString Avoid calling toString() on String objects; this is unnecessary. 3 300
UseStringBufferForStringAppends Prefer StringBuilder (non-synchronized) or StringBuffer (synchronized) over += for concatenating strings 3 320
LinguisticNaming Linguistics Antipattern - The getter 'getPomInfos' should not return void linguistically 3 337368
UnusedLocalVariable Avoid unused local variables such as 'headersResponse'. 3 342
UseIndexOfChar String.indexOf(char) is faster than String.indexOf(String). 3 403

fr/paris/lutece/plugins/releaser/service/MavenService.java

Rule Violation Priority Ligne
UnusedImports Avoid unused imports such as 'fr.paris.lutece.util.string.StringUtil' 4 56
ClassWithOnlyPrivateConstructorsShouldBeFinal A class which only has private constructors should be final 1 62330
NonThreadSafeSingleton Singleton is not thread safe 3 8791
MissingOverride The method 'init()' is missing an @Override annotation. 3 100106
MissingOverride The method 'mvnSiteAssembly(String, String, String, SvnUser, CommandResult)' is missing an @Override annotation. 3 128138
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 3 133
AvoidSynchronizedAtMethodLevel Use block level rather than method level synchronization 3 168171
AvoidSynchronizedAtMethodLevel Use block level rather than method level synchronization 3 187244
AddEmptyString Do not add empty strings 3 215
CommentRequired Public method and constructor comments are required 3 226229
MissingOverride The method 'consumeLine(String)' is missing an @Override annotation. 3 226229
InefficientStringBuffering Avoid concatenating nonliterals in a StringBuffer/StringBuilder constructor or append(). 3 228
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 3 237
UseObjectForClearerAPI Rather than using a lot of String arguments, consider using a container object for those values. 3 259
MissingOverride The method 'mvnReleasePerform(String, String, String, CommandResult, boolean, String)' is missing an @Override annotation. 3 259271
SystemPrintln System.out.println is used 2 264
MissingOverride The method 'mvnReleasePrepare(String, String, String, String, String, String, CommandResult, String)' is missing an @Override annotation. 3 292307
UseObjectForClearerAPI Rather than using a lot of String arguments, consider using a container object for those values. 3 292293
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 3 313

fr/paris/lutece/plugins/releaser/service/ReleaseComponentTask.java

Rule Violation Priority Ligne
DoNotUseThreads To be compliant to J2EE, a webapp should not use any thread. 3 59
ImmutableField Private field '_nIdWorkflow' could be made final; it is only initialized in the declaration or constructor. 3 66
ImmutableField Private field '_wfContext' could be made final; it is only initialized in the declaration or constructor. 3 69
ImmutableField Private field '_request' could be made final; it is only initialized in the declaration or constructor. 3 72
ImmutableField Private field '_user' could be made final; it is only initialized in the declaration or constructor. 3 75
ImmutableField Private field '_locale' could be made final; it is only initialized in the declaration or constructor. 3 78
MissingOverride The method 'run()' is missing an @Override annotation. 3 107178
UnusedLocalVariable Avoid unused local variables such as 'state'. 3 110
AvoidBranchingStatementAsLastInLoop Avoid using a branching statement as the last in a loop. 2 160

fr/paris/lutece/plugins/releaser/service/SiteResourceIdService.java

Rule Violation Priority Ligne
CallSuperInConstructor It is a good practice to call super() in a constructor 3 7275
ShortVariable Avoid variables with short names like rt 3 80
ShortVariable Avoid variables with short names like p 3 86

fr/paris/lutece/plugins/releaser/service/SiteService.java

Rule Violation Priority Ligne
ExcessiveImports A high number of imports can indicate a high degree of coupling within an object. 3 34910
UnusedImports Avoid unused imports such as 'fr.paris.lutece.portal.service.plugin.Plugin' 4 72
GodClass Possible God Class (WMC=100, ATFD=148, TCC=0.000%) 3 83910
CyclomaticComplexity The class 'SiteService' has a total cyclomatic complexity of 100 (highest 14). 3 83910
TooManyMethods This class has too many methods, consider refactoring it. 3 84910
FieldNamingConventions The static field name 'POM_PARENT_MIN_VERSION_TO_CREATE_DOCKET_IMAGE' doesn't match '_[a-z][a-zA-Z0-9]*' 1 111
ConfusingTernary Avoid if (x != y) ..; else ..; 3 131147
CommentRequired Public method and constructor comments are required 3 187209
UselessOperationOnImmutable An operation on an Immutable object (String, BigDecimal or BigInteger) wont change the object itself 3 195
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 3 264
IdenticalCatchBranches 'catch' branch identical to 'InterruptedException' branch 3 283287
BooleanInstantiation Avoid instantiating Boolean objects; reference Boolean.TRUE or Boolean.FALSE or call Boolean.valueOf() instead. 2 376
CyclomaticComplexity The method 'buildReleaseComments(Component, Locale)' has a cyclomatic complexity of 14. 3 465538
ConfusingTernary Avoid if (x != y) ..; else ..; 3 476537
ConfusingTernary Avoid if (x != y) ..; else ..; 3 509525
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 3 667
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 3 667
AvoidFileStream Avoid instantiating FileInputStream, FileOutputStream, FileReader, or FileWriter 1 801
IdenticalCatchBranches 'catch' branch identical to 'FileNotFoundException' branch 3 818822
CommentRequired Public method and constructor comments are required 3 827886
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 3 830
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 3 839
MethodNamingConventions The static method name 'IsUserAuthorized' doesn't match '[a-z][a-zA-Z0-9]*' 1 888899
CommentRequired Public method and constructor comments are required 3 888899
CommentRequired Public method and constructor comments are required 3 901908
MethodNamingConventions The static method name 'IsSiteAlreadyExist' doesn't match '[a-z][a-zA-Z0-9]*' 1 901908
SimplifyBooleanReturns Avoid unnecessary if..then..else statements when returning booleans 3 904905
ControlStatementBraces This statement should have braces 3 905

fr/paris/lutece/plugins/releaser/service/TwitterService.java

Rule Violation Priority Ligne
RedundantFieldInitializer Avoid using redundant field initializer for '_twitter' 3 89
RedundantFieldInitializer Avoid using redundant field initializer for '_instance' 3 92
NonThreadSafeSingleton Singleton is not thread safe 3 101105
UnnecessaryConstructor Avoid unnecessary constructors - the compiler will generate these for you 3 113116
MissingOverride The method 'sendTweet(String, CommandResult)' is missing an @Override annotation. 3 126144
MissingOverride The method 'init()' is missing an @Override annotation. 3 149167

fr/paris/lutece/plugins/releaser/service/WorkflowReleaseContextService.java

Rule Violation Priority Ligne
ExcessiveImports A high number of imports can indicate a high degree of coupling within an object. 3 34903
GodClass Possible God Class (WMC=64, ATFD=102, TCC=2.381%) 3 84903
TooManyMethods This class has too many methods, consider refactoring it. 3 85903
ImmutableField Private field '_mapWorkflowReleaseContext' could be made final; it is only initialized in the declaration or constructor. 3 91
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 3 91
LooseCoupling Avoid using implementation types like 'HashMap'; use the interface instead 3 91
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 3 97
LooseCoupling Avoid using implementation types like 'HashSet'; use the interface instead 3 97
ImmutableField Private field '_releaseInProgress' could be made final; it is only initialized in the declaration or constructor. 3 97
AvoidSynchronizedAtMethodLevel Use block level rather than method level synchronization 3 113135
ConfusingTernary Avoid if (x != y) ..; else ..; 3 123
MissingOverride The method 'saveWorkflowReleaseContext(WorkflowReleaseContext)' is missing an @Override annotation. 3 161199
AvoidSynchronizedAtMethodLevel Use block level rather than method level synchronization 3 161199
ConfusingTernary Avoid if (x != y) ..; else ..; 3 171192
ConfusingTernary Avoid if (x != y) ..; else ..; 3 188
MissingOverride The method 'getListWorkflowReleaseContextHistory(String)' is missing an @Override annotation. 3 233268
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 3 236
MissingOverride The method 'getIdWorkflow(WorkflowReleaseContext)' is missing an @Override annotation. 3 277293
NonThreadSafeSingleton Singleton is not thread safe 3 302307
CyclomaticComplexity The method 'mergeDevelopMaster(WorkflowReleaseContext, Locale)' has a cyclomatic complexity of 14. 3 320418
MissingOverride The method 'mergeDevelopMaster(WorkflowReleaseContext, Locale)' is missing an @Override annotation. 3 320418
ConfusingTernary Avoid if (x != y) ..; else ..; 3 342378
IdenticalCatchBranches 'catch' branch identical to 'InvalidRemoteException' branch 3 387391
IdenticalCatchBranches 'catch' branch identical to 'InvalidRemoteException' branch 3 392395
IdenticalCatchBranches 'catch' branch identical to 'InvalidRemoteException' branch 3 396399
NcssCount The method 'releasePrepareComponent(WorkflowReleaseContext, Locale)' has a NCSS line count of 71. 3 428586
MissingOverride The method 'releasePrepareComponent(WorkflowReleaseContext, Locale)' is missing an @Override annotation. 3 428586
CyclomaticComplexity The method 'releasePrepareComponent(WorkflowReleaseContext, Locale)' has a cyclomatic complexity of 12. 3 428586
ExcessiveMethodLength Avoid really long methods. 3 428586
LocalVariableNamingConventions The local variable name 'StrLocalComponentPomEffectivePath' doesn't match '[a-z][a-zA-Z0-9]*' 1 445
AvoidDuplicateLiterals The String literal " to " appears 4 times in this file; the first occurrence is on line 464 3 464
MissingOverride The method 'releasePerformComponent(WorkflowReleaseContext, Locale)' is missing an @Override annotation. 3 596630
AvoidDuplicateLiterals The String literal " Release Perform" appears 4 times in this file; the first occurrence is on line 604 3 604
MissingOverride The method 'checkoutRepository(WorkflowReleaseContext, Locale)' is missing an @Override annotation. 3 640653
MissingOverride The method 'releasePrepareSite(WorkflowReleaseContext, Locale)' is missing an @Override annotation. 3 663727
AvoidDuplicateLiterals The String literal "...\n" appears 4 times in this file; the first occurrence is on line 676 3 676
MissingOverride The method 'sendTweet(WorkflowReleaseContext, Locale)' is missing an @Override annotation. 3 737748
MissingOverride The method 'updateJiraVersions(WorkflowReleaseContext, Locale)' is missing an @Override annotation. 3 758769
MissingOverride The method 'startWorkflowReleaseContext(WorkflowReleaseContext, int, Locale, HttpServletRequest, AdminUser)' is missing an @Override annotation. 3 785788
MissingOverride The method 'init()' is missing an @Override annotation. 3 793798
MissingOverride The method 'startReleaseInProgress(String)' is missing an @Override annotation. 3 806810
MissingOverride The method 'stopReleaseInProgress(String)' is missing an @Override annotation. 3 818822
MissingOverride The method 'isReleaseInProgress(String)' is missing an @Override annotation. 3 831835
MissingOverride The method 'createDockerImage(WorkflowReleaseContext, Locale)' is missing an @Override annotation. 3 889901
UnusedLocalVariable Avoid unused local variables such as 'commandResult'. 3 893

fr/paris/lutece/plugins/releaser/service/github/GitResourceService.java

Rule Violation Priority Ligne
ExcessiveImports A high number of imports can indicate a high degree of coupling within an object. 3 34662
MissingOverride The method 'fetchPom(Site, String, String)' is missing an @Override annotation. 3 87100
CyclomaticComplexity The method 'getLastRelease(Site, String, String)' has a cyclomatic complexity of 15. 3 113184
MissingOverride The method 'getLastRelease(Site, String, String)' is missing an @Override annotation. 3 113184
ConfusingTernary Avoid if (x != y) ..; else ..; 3 125174
PositionLiteralsFirstInComparisons Position literals first in String comparisons 3 138
PositionLiteralsFirstInComparisons Position literals first in String comparisons 3 138
CollapsibleIfStatements These nested if statements could be combined 3 141146
AvoidDeeplyNestedIfStmts Deeply nested if..then statements are hard to read 3 141146
CyclomaticComplexity The method 'doCheckoutRepository(WorkflowReleaseContext, String, String)' has a cyclomatic complexity of 11. 3 198286
ConfusingTernary Avoid if (x != y) ..; else ..; 3 233244
AvoidDuplicateLiterals The String literal "/.git" appears 4 times in this file; the first occurrence is on line 329 3 329
IdenticalCatchBranches 'catch' branch identical to 'InvalidRemoteException' branch 3 343347
IdenticalCatchBranches 'catch' branch identical to 'InvalidRemoteException' branch 3 348351
IdenticalCatchBranches 'catch' branch identical to 'InvalidRemoteException' branch 3 352355
IdenticalCatchBranches 'catch' branch identical to 'InvalidRemoteException' branch 3 414418
IdenticalCatchBranches 'catch' branch identical to 'InvalidRemoteException' branch 3 419422
IdenticalCatchBranches 'catch' branch identical to 'InvalidRemoteException' branch 3 423426
ExcessiveMethodLength Avoid really long methods. 3 457572
CyclomaticComplexity The method 'rollbackRelease(WorkflowReleaseContext, Locale)' has a cyclomatic complexity of 15. 3 457572
ConfusingTernary Avoid if (x != y) ..; else ..; 3 505512
IdenticalCatchBranches 'catch' branch identical to 'InvalidRemoteException' branch 3 539543
IdenticalCatchBranches 'catch' branch identical to 'InvalidRemoteException' branch 3 544547
IdenticalCatchBranches 'catch' branch identical to 'InvalidRemoteException' branch 3 548551
IdenticalCatchBranches 'catch' branch identical to 'InvalidRemoteException' branch 3 628632
IdenticalCatchBranches 'catch' branch identical to 'InvalidRemoteException' branch 3 633636
IdenticalCatchBranches 'catch' branch identical to 'InvalidRemoteException' branch 3 637640

fr/paris/lutece/plugins/releaser/service/svn/SvnResourceService.java

Rule Violation Priority Ligne
ExcessiveImports A high number of imports can indicate a high degree of coupling within an object. 3 34412
UnusedImports Avoid unused imports such as 'java.io.IOException' 4 37
UnusedImports Avoid unused imports such as 'java.io.PrintWriter' 4 38
UnusedImports Avoid unused imports such as 'java.io.StringWriter' 4 39
UnusedImports Avoid unused imports such as 'org.apache.commons.lang3.ObjectUtils' 4 44
UnusedImports Avoid unused imports such as 'org.apache.commons.lang3.StringUtils' 4 45
UnusedImports Avoid unused imports such as 'org.tmatesoft.svn.core.SVNCancelException' 4 46
UnusedImports Avoid unused imports such as 'org.tmatesoft.svn.core.SVNException' 4 47
UnusedImports Avoid unused imports such as 'org.tmatesoft.svn.core.wc.ISVNEventHandler' 4 49
UnusedImports Avoid unused imports such as 'org.tmatesoft.svn.core.wc.SVNEvent' 4 50
UnusedImports Avoid unused imports such as 'org.tmatesoft.svn.core.wc.SVNEventAction' 4 51
UnusedImports Avoid unused imports such as 'fr.paris.lutece.plugins.releaser.business.RepositoryType' 4 54
UnusedImports Avoid unused imports such as 'fr.paris.lutece.plugins.releaser.util.svn.ReleaseSvnCopyClient' 4 65
MissingOverride The method 'fetchPom(Site, String, String)' is missing an @Override annotation. 3 92112
AvoidLiteralsInIfCondition Avoid using Literals in Conditional Statements 3 106
MissingOverride The method 'getLastRelease(Site, String, String)' is missing an @Override annotation. 3 125160
ConfusingTernary Avoid if (x != y) ..; else ..; 3 146
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 3 173
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 3 262
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 3 310
ConfusingTernary Avoid if (x != y) ..; else ..; 3 355
LongInstantiation Avoid instantiating Long objects.Call Long.valueOf() instead 2 355
CompareObjectsWithEquals Use equals() to compare object references. 3 357
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 3 371

fr/paris/lutece/plugins/releaser/util/CVSFactoryService.java

Rule Violation Priority Ligne
UseUtilityClass All methods are static. Consider using a utility class instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning. 3 44104
UnnecessaryConstructor Avoid unnecessary constructors - the compiler will generate these for you 3 5861
UncommentedEmptyConstructor Document empty constructor 3 5861

fr/paris/lutece/plugins/releaser/util/CommandResult.java

Rule Violation Priority Ligne
FieldNamingConventions The static field name 'STATUS_ERROR' doesn't match '_[a-z][a-zA-Z0-9]*' 1 52
RedundantFieldInitializer Avoid using redundant field initializer for 'STATUS_ERROR' 3 52
FieldNamingConventions The static field name 'STATUS_OK' doesn't match '_[a-z][a-zA-Z0-9]*' 1 55
RedundantFieldInitializer Avoid using redundant field initializer for 'ERROR_TYPE_INFO' 3 58
FieldNamingConventions The static field name 'ERROR_TYPE_INFO' doesn't match '_[a-z][a-zA-Z0-9]*' 1 58
FieldNamingConventions The static field name 'ERROR_TYPE_STOP' doesn't match '_[a-z][a-zA-Z0-9]*' 1 61
AvoidStringBufferField StringBuffers can grow quite a lot, and so may become a source of memory leak (if the owning class has a long life time). 3 64
FieldNamingConventions The field name 'progressValue' doesn't match '_[a-z][a-zA-Z0-9]*' 1 82
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 3 88
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 3 88
CloneMethodReturnTypeMustMatchClassName The return type of the clone() method must be the class name when implements Cloneable 3 158167
FormalParameterNamingConventions The method parameter name '_mResultInformations' doesn't match '[a-z][a-zA-Z0-9]*' 1 206
FormalParameterNamingConventions The method parameter name '_nErrorType' doesn't match '[a-z][a-zA-Z0-9]*' 1 227
FormalParameterNamingConventions The method parameter name '_dBegin' doesn't match '[a-z][a-zA-Z0-9]*' 1 248
FormalParameterNamingConventions The method parameter name '_dEnd' doesn't match '[a-z][a-zA-Z0-9]*' 1 269

fr/paris/lutece/plugins/releaser/util/MapperJsonUtil.java

Rule Violation Priority Ligne
FieldNamingConventions The constant name '_mapper' doesn't match '[A-Z][A-Z_0-9]*' 1 50
ShortVariable Avoid variables with short names like t 3 78

fr/paris/lutece/plugins/releaser/util/PluginUtils.java

Rule Violation Priority Ligne
UnusedImports Avoid unused imports such as 'javax.xml.parsers.ParserConfigurationException' 4 48
UnusedImports Avoid unused imports such as 'javax.xml.transform.TransformerException' 4 50
UnusedImports Avoid unused imports such as 'org.eclipse.jgit.api.errors.NoFilepatternException' 4 55
UnusedImports Avoid unused imports such as 'org.xml.sax.SAXException' 4 59
UseUtilityClass All methods are static. Consider using a utility class instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning. 3 66363
CyclomaticComplexity The method 'updateAppInfoFile(String, String, CommandResult)' has a cyclomatic complexity of 12. 3 185269
ShortVariable Avoid variables with short names like br 3 188
AvoidFileStream Avoid instantiating FileInputStream, FileOutputStream, FileReader, or FileWriter 1 193
AvoidLiteralsInIfCondition Avoid using Literals in Conditional Statements 3 200
CollapsibleIfStatements These nested if statements could be combined 3 200213
ConfusingTernary Avoid if (x != y) ..; else ..; 3 203212
InefficientStringBuffering Avoid concatenating nonliterals in a StringBuffer/StringBuilder constructor or append(). 3 216
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 3 220
ShortVariable Avoid variables with short names like fw 3 244
AvoidFileStream Avoid instantiating FileInputStream, FileOutputStream, FileReader, or FileWriter 1 247
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 3 250
ShortVariable Avoid variables with short names like fw 3 284
ShortVariable Avoid variables with short names like sw 3 301
ShortVariable Avoid variables with short names like tf 3 304
AvoidFileStream Avoid instantiating FileInputStream, FileOutputStream, FileReader, or FileWriter 1 308
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 3 319
AvoidPrintStackTrace Avoid printStackTrace(); use a logger call instead. 3 334
CommentDefaultAccessModifier To avoid mistakes add a comment at the beginning of the ContextFileFilter nested class if you want a default access modifier 3 345361
MissingOverride The method 'accept(File, String)' is missing an @Override annotation. 3 357360

fr/paris/lutece/plugins/releaser/util/ReleaserUtils.java

Rule Violation Priority Ligne
GodClass Possible God Class (WMC=59, ATFD=70, TCC=0.000%) 3 64589
TooManyMethods This class has too many methods, consider refactoring it. 3 65589
UseUtilityClass All methods are static. Consider using a utility class instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning. 3 65589
ConfusingTernary Avoid if (x != y) ..; else ..; 3 118129
ShortVariable Avoid variables with short names like e 3 242
ConfusingTernary Avoid if (x != y) ..; else ..; 3 245252
ShortVariable Avoid variables with short names like e 3 275
AvoidUncheckedExceptionsInSignatures A method or constructor should not explicitly declare unchecked exceptions in its 'throws' clause 3 275
ConfusingTernary Avoid if (x != y) ..; else ..; 3 278285
ConfusingTernary Avoid if (x != y) ..; else ..; 3 295302
AvoidUncheckedExceptionsInSignatures A method or constructor should not explicitly declare unchecked exceptions in its 'throws' clause 3 315
ConfusingTernary Avoid if (x != y) ..; else ..; 3 336
ConfusingTernary Avoid if (x != y) ..; else ..; 3 381
ConfusingTernary Avoid if (x != y) ..; else ..; 3 443
ForLoopCanBeForeach This for loop can be replaced by a foreach loop 3 467477
ConfusingTernary Avoid if (x != y) ..; else ..; 3 491
CommentRequired Public method and constructor comments are required 3 535543
CommentRequired Public method and constructor comments are required 3 545565
ConfusingTernary Avoid if (x != y) ..; else ..; 3 550562
ConfusingTernary Avoid if (x != y) ..; else ..; 3 555562
CommentRequired Public method and constructor comments are required 3 567586
MethodNamingConventions The static method name 'IsVersionInRightFormat' doesn't match '[a-z][a-zA-Z0-9]*' 1 567586
AvoidLiteralsInIfCondition Avoid using Literals in Conditional Statements 3 570

fr/paris/lutece/plugins/releaser/util/file/FileUtils.java

Rule Violation Priority Ligne
UseUtilityClass All methods are static. Consider using a utility class instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning. 3 48160
InefficientStringBuffering Avoid concatenating nonliterals in a StringBuffer/StringBuilder constructor or append(). 3 82
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 3 141

fr/paris/lutece/plugins/releaser/util/github/GitUtils.java

Rule Violation Priority Ligne
ExcessiveImports A high number of imports can indicate a high degree of coupling within an object. 3 34788
GodClass Possible God Class (WMC=69, ATFD=39, TCC=0.000%) 3 89788
UseUtilityClass All methods are static. Consider using a utility class instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning. 3 90788
UseObjectForClearerAPI Rather than using a lot of String arguments, consider using a container object for those values. 3 118119
IdenticalCatchBranches 'catch' branch identical to 'InvalidRemoteException' branch 3 145149
IdenticalCatchBranches 'catch' branch identical to 'InvalidRemoteException' branch 3 150153
IdenticalCatchBranches 'catch' branch identical to 'InvalidRemoteException' branch 3 154158
IdenticalCatchBranches 'catch' branch identical to 'InvalidRemoteException' branch 3 193197
IdenticalCatchBranches 'catch' branch identical to 'InvalidRemoteException' branch 3 199202
IdenticalCatchBranches 'catch' branch identical to 'InvalidRemoteException' branch 3 229233
IdenticalCatchBranches 'catch' branch identical to 'InvalidRemoteException' branch 3 235238
IdenticalCatchBranches 'catch' branch identical to 'RefAlreadyExistsException' branch 3 267270
IdenticalCatchBranches 'catch' branch identical to 'RefAlreadyExistsException' branch 3 271274
IdenticalCatchBranches 'catch' branch identical to 'RefAlreadyExistsException' branch 3 275278
IdenticalCatchBranches 'catch' branch identical to 'RefAlreadyExistsException' branch 3 279282
UnnecessaryLocalBeforeReturn Consider simply returning the value vs storing it in local variable 'mergeResult' 3 400
ShortVariable Avoid variables with short names like i 3 419
UseStringBufferForStringAppends Prefer StringBuilder (non-synchronized) or StringBuffer (synchronized) over += for concatenating strings 3 424
UseStringBufferForStringAppends Prefer StringBuilder (non-synchronized) or StringBuffer (synchronized) over += for concatenating strings 3 425
UseStringBufferForStringAppends Prefer StringBuilder (non-synchronized) or StringBuffer (synchronized) over += for concatenating strings 3 426
ShortVariable Avoid variables with short names like i 3 445
UseObjectForClearerAPI Rather than using a lot of String arguments, consider using a container object for those values. 3 527
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 3 550
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 3 550
IdenticalCatchBranches 'catch' branch identical to 'HttpAccessException' branch 3 565568
UseObjectForClearerAPI Rather than using a lot of String arguments, consider using a container object for those values. 3 588
LocalVariableNamingConventions The final local variable name 'TOKEN' doesn't match '[a-z][a-zA-Z0-9]*' 1 621
ShortVariable Avoid variables with short names like i 3 626
ForLoopCanBeForeach This for loop can be replaced by a foreach loop 3 644653
UnusedLocalVariable Avoid unused local variables such as 'tagName'. 3 647
AvoidReassigningParameters Avoid reassigning parameters such as 'strRepoUrl' 2 689
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 3 711
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 3 712
CommentRequired Public method and constructor comments are required 3 736787
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 3 747

fr/paris/lutece/plugins/releaser/util/github/GithubSearchRepoItem.java

Rule Violation Priority Ligne
FormalParameterNamingConventions The method parameter name '_strName' doesn't match '[a-z][a-zA-Z0-9]*' 1 73
FormalParameterNamingConventions The method parameter name '_strCloneUrl' doesn't match '[a-z][a-zA-Z0-9]*' 1 96
FormalParameterNamingConventions The method parameter name '_strContentsUrl' doesn't match '[a-z][a-zA-Z0-9]*' 1 119
FormalParameterNamingConventions The method parameter name '_strFullName' doesn't match '[a-z][a-zA-Z0-9]*' 1 142

fr/paris/lutece/plugins/releaser/util/github/ReleaseGITGetRepoClient.java

Rule Violation Priority Ligne
SingularField Perhaps 'bCancelled' could be replaced by a local variable. 3 44
UnusedPrivateField Avoid unused private fields such as 'bCancelled'. 3 44
FieldNamingConventions The field name 'bCancelled' doesn't match '_[a-z][a-zA-Z0-9]*' 1 44
UncommentedEmptyConstructor Document empty constructor 3 4951
UnnecessaryConstructor Avoid unnecessary constructors - the compiler will generate these for you 3 4951

fr/paris/lutece/plugins/releaser/util/maven/MavenUtils.java

Rule Violation Priority Ligne
UseObjectForClearerAPI Rather than using a lot of String arguments, consider using a container object for those values. 3 7677
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 3 85

fr/paris/lutece/plugins/releaser/util/pom/PomParser.java

Rule Violation Priority Ligne
ImmutableField Private field '_listDependencies' could be made final; it is only initialized in the declaration or constructor. 3 68
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 3 68
LooseCoupling Avoid using implementation types like 'ArrayList'; use the interface instead 3 68
LinguisticNaming Linguistics Antipattern - The variable 'isPOM' indicates linguistically it is a boolean, but it is 'InputSource' 3 92
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'fr.paris.lutece.plugins.releaser.business.jaxb.maven.Model.Dependencies' due to existing import 'fr.paris.lutece.plugins.releaser.business.jaxb.maven.Model' 4 97
AvoidFileStream Avoid instantiating FileInputStream, FileOutputStream, FileReader, or FileWriter 1 134
LinguisticNaming Linguistics Antipattern - The variable 'isPOM' indicates linguistically it is a boolean, but it is 'InputSource' 3 155
ShortVariable Avoid variables with short names like op 3 162
ShortVariable Avoid variables with short names like op 3 203
ShortVariable Avoid variables with short names like jc 3 286
ShortVariable Avoid variables with short names like u 3 287

fr/paris/lutece/plugins/releaser/util/pom/PomUpdater.java

Rule Violation Priority Ligne
UnusedImports Avoid unused imports such as 'java.util.Iterator' 4 42
UnusedImports Avoid unused imports such as 'fr.paris.lutece.portal.service.i18n.I18nService' 4 56
ClassNamingConventions The utility class name 'PomUpdater' doesn't match '[A-Z][a-zA-Z0-9]+(Utils?|Helper|Home|Service)' 1 64276
UseUtilityClass All methods are static. Consider using a utility class instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning. 3 65276
CyclomaticComplexity The method 'updateSiteBeforeTag(Site, String)' has a cyclomatic complexity of 10. 3 78152
AvoidFileStream Avoid instantiating FileInputStream, FileOutputStream, FileReader, or FileWriter 1 87
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'fr.paris.lutece.plugins.releaser.business.jaxb.maven.Model.Dependencies' due to existing import 'fr.paris.lutece.plugins.releaser.business.jaxb.maven.Model' 4 92
CollapsibleIfStatements These nested if statements could be combined 3 102105
AvoidDeeplyNestedIfStmts Deeply nested if..then statements are hard to read 3 102105
AvoidFileStream Avoid instantiating FileInputStream, FileOutputStream, FileReader, or FileWriter 1 126
CyclomaticComplexity The method 'updateSiteAfterTag(Site, String)' has a cyclomatic complexity of 10. 3 165229
AvoidFileStream Avoid instantiating FileInputStream, FileOutputStream, FileReader, or FileWriter 1 174
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'fr.paris.lutece.plugins.releaser.business.jaxb.maven.Model.Dependencies' due to existing import 'fr.paris.lutece.plugins.releaser.business.jaxb.maven.Model' 4 180
AvoidDeeplyNestedIfStmts Deeply nested if..then statements are hard to read 3 192195
CollapsibleIfStatements These nested if statements could be combined 3 192195
AvoidFileStream Avoid instantiating FileInputStream, FileOutputStream, FileReader, or FileWriter 1 203
ShortVariable Avoid variables with short names like jc 3 247
ShortVariable Avoid variables with short names like m 3 248
ShortVariable Avoid variables with short names like jc 3 270
ShortVariable Avoid variables with short names like u 3 271

fr/paris/lutece/plugins/releaser/util/pom/SaxPomHandler.java

Rule Violation Priority Ligne
CommentRequired Header comments are required 3 7230
AvoidStringBufferField StringBuffers can grow quite a lot, and so may become a source of memory leak (if the owning class has a long life time). 3 20
ImmutableField Private field '_sbScmUrl' could be made final; it is only initialized in the declaration or constructor. 3 20
AvoidStringBufferField StringBuffers can grow quite a lot, and so may become a source of memory leak (if the owning class has a long life time). 3 21
ImmutableField Private field '_sbScmConnection' could be made final; it is only initialized in the declaration or constructor. 3 21
ImmutableField Private field '_sbScmDeveloperConnection' could be made final; it is only initialized in the declaration or constructor. 3 22
AvoidStringBufferField StringBuffers can grow quite a lot, and so may become a source of memory leak (if the owning class has a long life time). 3 22
CyclomaticComplexity The method 'characters(char, int, int)' has a cyclomatic complexity of 13. 3 192229
ShortVariable Avoid variables with short names like ch 3 192
PositionLiteralsFirstInComparisons Position literals first in String comparisons 3 202

fr/paris/lutece/plugins/releaser/util/svn/ReleaseSvnCheckoutClient.java

Rule Violation Priority Ligne
FieldNamingConventions The field name 'bCancelled' doesn't match '_[a-z][a-zA-Z0-9]*' 1 49
UnusedPrivateField Avoid unused private fields such as 'bCancelled'. 3 49
SingularField Perhaps 'bCancelled' could be replaced by a local variable. 3 49

fr/paris/lutece/plugins/releaser/util/svn/ReleaseSvnCommitClient.java

Rule Violation Priority Ligne
UnusedPrivateField Avoid unused private fields such as 'bCancelled'. 3 48
FieldNamingConventions The field name 'bCancelled' doesn't match '_[a-z][a-zA-Z0-9]*' 1 48
SingularField Perhaps 'bCancelled' could be replaced by a local variable. 3 48

fr/paris/lutece/plugins/releaser/util/svn/ReleaseSvnCopyClient.java

Rule Violation Priority Ligne
SingularField Perhaps 'bCancelled' could be replaced by a local variable. 3 48
UnusedPrivateField Avoid unused private fields such as 'bCancelled'. 3 48
FieldNamingConventions The field name 'bCancelled' doesn't match '_[a-z][a-zA-Z0-9]*' 1 48

fr/paris/lutece/plugins/releaser/util/svn/SvnUser.java

Rule Violation Priority Ligne
FormalParameterNamingConventions The method parameter name '_mUserContex' doesn't match '[a-z][a-zA-Z0-9]*' 1 120

fr/paris/lutece/plugins/releaser/util/svn/SvnUtils.java

Rule Violation Priority Ligne
ExcessiveImports A high number of imports can indicate a high degree of coupling within an object. 3 34508
UnusedPrivateField Avoid unused private fields such as 'MESSAGE_ERROR_SVN'. 3 86
UnusedPrivateField Avoid unused private fields such as 'CONSTANTE_SLASH'. 3 89
FieldNamingConventions The constant name 'logger' doesn't match '[A-Z][A-Z_0-9]*' 1 92
UnusedPrivateField Avoid unused private fields such as 'logger'. 3 92
UseObjectForClearerAPI Rather than using a lot of String arguments, consider using a container object for those values. 3 163
CollapsibleIfStatements These nested if statements could be combined 3 207212
CommentRequired Public method and constructor comments are required 3 222225
MissingOverride The method 'checkCancelled()' is missing an @Override annotation. 3 222225
CommentRequired Public method and constructor comments are required 3 227230
MissingOverride The method 'handleEvent(SVNEvent, double)' is missing an @Override annotation. 3 227230
ShortVariable Avoid variables with short names like sw 3 245
ShortVariable Avoid variables with short names like pw 3 246
UnusedLocalVariable Avoid unused local variables such as 'errorLog'. 3 249
EmptyCatchBlock Avoid empty catch blocks 3 258262
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 3 269
ShortVariable Avoid variables with short names like sw 3 273
ShortVariable Avoid variables with short names like pw 3 274
UnusedLocalVariable Avoid unused local variables such as 'errorLog'. 3 277
EmptyCatchBlock Avoid empty catch blocks 3 286290
CommentRequired Public method and constructor comments are required 3 321331
MissingOverride The method 'handleDirEntry(SVNDirEntry)' is missing an @Override annotation. 3 321331
CollapsibleIfStatements These nested if statements could be combined 3 326329
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 3 350
UseObjectForClearerAPI Rather than using a lot of String arguments, consider using a container object for those values. 3 413
AvoidReassigningParameters Avoid reassigning parameters such as 'strRepoUrl' 2 465

fr/paris/lutece/plugins/releaser/util/version/Version.java

Rule Violation Priority Ligne
GodClass Possible God Class (WMC=71, ATFD=22, TCC=29.735%) 3 47731
UncommentedEmptyConstructor Document empty constructor 3 8991
CommentRequired Public method and constructor comments are required 3 205207
FormalParameterNamingConventions The method parameter name '_strQualifierRadix' doesn't match '[a-z][a-zA-Z0-9]*' 1 209
CommentRequired Public method and constructor comments are required 3 209211
CommentRequired Public method and constructor comments are required 3 213215
CommentRequired Public method and constructor comments are required 3 217219
FormalParameterNamingConventions The method parameter name '_nQualifierNumber' doesn't match '[a-z][a-zA-Z0-9]*' 1 217
CyclomaticComplexity The method 'compareTo(Object)' has a cyclomatic complexity of 16. 3 229287
ConfusingTernary Avoid if (x != y) ..; else ..; 3 248284
CompareObjectsWithEquals Use equals() to compare object references. 3 265
ConfusingTernary Avoid if (x != y) ..; else ..; 3 300307
ConfusingTernary Avoid if (x != y) ..; else ..; 3 338
AvoidLiteralsInIfCondition Avoid using Literals in Conditional Statements 3 343
ConfusingTernary Avoid if (x != y) ..; else ..; 3 369380
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 3 382
AvoidDuplicateLiterals The String literal "Error parsing version " appears 7 times in this file; the first occurrence is on line 550 3 550
AvoidDuplicateLiterals The String literal " : " appears 7 times in this file; the first occurrence is on line 550 3 550
EmptyIfStmt Avoid empty if statements 3 634637

fr/paris/lutece/plugins/releaser/util/version/VersionParsingException.java

Rule Violation Priority Ligne
MissingSerialVersionUID Classes implementing Serializable should set a serialVersionUID 3 4055

fr/paris/lutece/plugins/releaser/web/ClusterJspBean.java

Rule Violation Priority Ligne
MissingSerialVersionUID Classes implementing Serializable should set a serialVersionUID 3 70615
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 3 165
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 3 166
ConfusingTernary Avoid if (x != y) ..; else ..; 3 207
ConfusingTernary Avoid if (x != y) ..; else ..; 3 449

fr/paris/lutece/plugins/releaser/web/ManageComponentReleaseJspBean.java

Rule Violation Priority Ligne
MissingSerialVersionUID Classes implementing Serializable should set a serialVersionUID 3 65322
CommentDefaultAccessModifier To avoid mistakes add a comment at the beginning of the _paginatorComponents field if you want a default access modifier 3 126
DefaultPackage Use explicit scoping instead of the default package private level 3 126
CyclomaticComplexity The method 'getManageComponent(HttpServletRequest)' has a cyclomatic complexity of 12. 3 137179
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 3 145
UnusedLocalVariable Avoid unused local variables such as 'user'. 3 145
ConfusingTernary Avoid if (x != y) ..; else ..; 3 147169
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 3 168
ConfusingTernary Avoid if (x != y) ..; else ..; 3 173
ConfusingTernary Avoid if (x != y) ..; else ..; 3 175
UnnecessaryAnnotationValueElement Avoid the use of value in annotations when its the only element 3 253
UnusedLocalVariable Avoid unused local variables such as 'component'. 3 261
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 3 261
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 3 283
UnusedLocalVariable Avoid unused local variables such as 'component'. 3 283
LinguisticNaming Linguistics Antipattern - The setter 'setReleaserUser' should not return any type except void linguistically 3 288301

fr/paris/lutece/plugins/releaser/web/ManageSiteReleaseJspBean.java

Rule Violation Priority Ligne
ExcessiveImports A high number of imports can indicate a high degree of coupling within an object. 3 34701
UnusedImports Avoid unused imports such as 'fr.paris.lutece.portal.service.i18n.I18nService' 4 49
MissingSerialVersionUID Classes implementing Serializable should set a serialVersionUID 3 74701
TooManyMethods This class has too many methods, consider refactoring it. 3 75701
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 3 217
UnnecessaryAnnotationValueElement Avoid the use of value in annotations when its the only element 3 266
CyclomaticComplexity The method 'getConfirmReleaseSite(HttpServletRequest)' has a cyclomatic complexity of 11. 3 267313
NPathComplexity The method 'getConfirmReleaseSite(HttpServletRequest)' has an NPath complexity of 324 3 267313
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 3 272
UnnecessaryAnnotationValueElement Avoid the use of value in annotations when its the only element 3 322
UnnecessaryAnnotationValueElement Avoid the use of value in annotations when its the only element 3 349
ConfusingTernary Avoid if (x != y) ..; else ..; 3 357376
ConfusingTernary Avoid if (x != y) ..; else ..; 3 361370
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 3 505
UnnecessaryAnnotationValueElement Avoid the use of value in annotations when its the only element 3 562
UnnecessaryLocalBeforeReturn Consider simply returning the value vs storing it in local variable 'strTemplate' 3 575
UnnecessaryAnnotationValueElement Avoid the use of value in annotations when its the only element 3 633
UnusedLocalVariable Avoid unused local variables such as 'component'. 3 641
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 3 641
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 3 662
UnusedLocalVariable Avoid unused local variables such as 'component'. 3 662
LinguisticNaming Linguistics Antipattern - The setter 'setReleaserUser' should not return any type except void linguistically 3 668681

fr/paris/lutece/plugins/releaser/web/ManageSitesJspBean.java

Rule Violation Priority Ligne
MissingSerialVersionUID Classes implementing Serializable should set a serialVersionUID 3 4999
SingularField Perhaps '_nDefaultItemsPerPage' could be replaced by a local variable. 3 62