Fork me on GitHub

PMD Results

The following document contains the results of PMD 5.3.5.

Files

fr/paris/lutece/plugins/sponsoredlinks/business/SponsoredLink.java

Violation Line
Avoid unnecessary if..then..else statements when returning booleans 165168

fr/paris/lutece/plugins/sponsoredlinks/business/SponsoredLinkGroup.java

Violation Line
Avoid variables with short names like id 63

fr/paris/lutece/plugins/sponsoredlinks/business/SponsoredLinkSet.java

Violation Line
Avoid variables with short names like id 67

fr/paris/lutece/plugins/sponsoredlinks/business/SponsoredLinkTemplate.java

Violation Line
Assigning an Object to null is a code smell. Consider refactoring. 148

fr/paris/lutece/plugins/sponsoredlinks/business/SponsoredLinkTemplateHome.java

Violation Line
The class 'SponsoredLinkTemplateHome' has a Cyclomatic Complexity of 2 (Highest = 11). 49207
The method 'updateOrder' has a Cyclomatic Complexity of 11. 99135
Avoid declaring a variable if it is unreferenced before a possible exit point. 103
Avoid reassigning parameters such as 'template' 144

fr/paris/lutece/plugins/sponsoredlinks/service/SponsoredLinksGroupResourceIdService.java

Violation Line
It is a good practice to call super() in a constructor 7275
Avoid variables with short names like rt 126
Avoid variables with short names like p 132

fr/paris/lutece/plugins/sponsoredlinks/service/SponsoredLinksService.java

Violation Line
If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 94

fr/paris/lutece/plugins/sponsoredlinks/service/SponsoredLinksSetResourceIdService.java

Violation Line
It is a good practice to call super() in a constructor 7275
Avoid variables with short names like rt 126
Avoid variables with short names like p 132

fr/paris/lutece/plugins/sponsoredlinks/service/SponsoredLinksTemplateResourceIdService.java

Violation Line
It is a good practice to call super() in a constructor 6467
Avoid variables with short names like rt 118
Avoid variables with short names like p 124

fr/paris/lutece/plugins/sponsoredlinks/service/search/SponsoredLinksIndexer.java

Violation Line
A high number of imports can indicate a high degree of coupling within an object. 34307
Unnecessary use of fully qualified name 'org.apache.lucene.document.Document' due to existing import 'org.apache.lucene.document.Document' 121
Avoid declaring a variable if it is unreferenced before a possible exit point. 122
Unnecessary use of fully qualified name 'org.apache.lucene.document.Document' due to existing import 'org.apache.lucene.document.Document' 168
Unnecessary use of fully qualified name 'org.apache.lucene.document.Document' due to existing import 'org.apache.lucene.document.Document' 208
Avoid variables with short names like ft 252

fr/paris/lutece/plugins/sponsoredlinks/service/sponsoredlinkssearch/SponsoredLinksLuceneSearchEngine.java

Violation Line
Avoid variables with short names like ir 77
Avoid variables with short names like si 109
Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 113

fr/paris/lutece/plugins/sponsoredlinks/service/sponsoredlinkssearch/SponsoredLinksSearchService.java

Violation Line
Singleton is not thread safe 7073

fr/paris/lutece/plugins/sponsoredlinks/web/SponsoredLinksJspBean.java

Violation Line
A high number of imports can indicate a high degree of coupling within an object. 341249
Possible God class (WMC=101, ATFD=257, TCC=0.328042328042328) 341249
The class 'SponsoredLinksJspBean' has a Cyclomatic Complexity of 4 (Highest = 12). 821249
Avoid really long classes. 821249
Private field '_nDefaultItemsPerPage' could be made final; it is only initialized in the declaration or constructor. 189
If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 207
If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 240
If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 241
If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 293
The method 'doCreateSet' has a Cyclomatic Complexity of 10. 311366
If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 395
If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 397
The method 'doModifySet' has a Cyclomatic Complexity of 12. 435495
If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 596
If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 609
If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 648
This statement may have some unnecessary parentheses 654
The method doCreateGroup() has an NPath complexity of 234 675714
If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 739
This statement may have some unnecessary parentheses 743
The method 'doModifyGroup' has a Cyclomatic Complexity of 12. 776820
The method doModifyGroup() has an NPath complexity of 2520 776820
If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 887
If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 928
Avoid catching NullPointerException; consider removing the cause of the NPE. 936
Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 936
Avoid catching NullPointerException; consider removing the cause of the NPE. 974
Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 974
If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 980
Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 1091
Avoid catching NullPointerException; consider removing the cause of the NPE. 1091
Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 1104
Avoid catching NullPointerException; consider removing the cause of the NPE. 1104
If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 1110