PMD Results
The following document contains the results of PMD 5.5.1.
Files
fr/paris/lutece/plugins/sqlpage/business/SQLFragmentHome.java
| Violation |
Line |
| Avoid using Literals in Conditional Statements |
134 |
fr/paris/lutece/plugins/sqlpage/business/parameter/SQLPageParameterDAO.java
| Violation |
Line |
| Use block level rather than method level synchronization |
85–101 |
fr/paris/lutece/plugins/sqlpage/business/query/QueryDAO.java
| Violation |
Line |
| Ensure that resources like this Connection object are closed after use |
67 |
| Ensure that resources like this ResultSet object are closed after use |
77 |
| Assigning an Object to null is a code smell. Consider refactoring. |
103 |
| A throw statement in a finally block makes the control flow hard to understand. |
110–125 |
| New exception is thrown in catch block, original stack trace may be lost |
121 |
fr/paris/lutece/plugins/sqlpage/business/query/ResultSetRow.java
| Violation |
Line |
| Private field '_listColumns' could be made final; it is only initialized in the declaration or constructor. |
44 |
fr/paris/lutece/plugins/sqlpage/service/SQLPageService.java
| Violation |
Line |
| If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation |
94 |
| The String literal "SQLPage - Template error building page : " appears 4 times in this file; the first occurrence is on line 104 |
104 |
| Avoid declaring a variable if it is unreferenced before a possible exit point. |
126 |
| If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation |
159 |
| If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation |
233 |
| Avoid declaring a variable if it is unreferenced before a possible exit point. |
233 |
| If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation |
249 |
fr/paris/lutece/plugins/sqlpage/service/SQLService.java
| Violation |
Line |
| If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation |
54 |
| An empty statement (semicolon) not part of a loop |
85 |
| Do not add empty strings |
122 |
| Do not add empty strings |
210 |
fr/paris/lutece/plugins/sqlpage/service/TemplateService.java
| Violation |
Line |
| Use block level rather than method level synchronization |
58–66 |
fr/paris/lutece/plugins/sqlpage/web/ManageSQLPageJspBean.java
| Violation |
Line |
| Abstract classes should be named AbstractXXX |
50–101 |
| Perhaps '_nDefaultItemsPerPage' could be replaced by a local variable. |
64 |
| Do not add empty strings |
95 |
fr/paris/lutece/plugins/sqlpage/web/ManageSQLPageParameterJspBean.java
| Violation |
Line |
| Assigning an Object to null is a code smell. Consider refactoring. |
121 |
| Avoid declaring a variable if it is unreferenced before a possible exit point. |
289 |
| If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation |
327 |
fr/paris/lutece/plugins/sqlpage/web/SQLFragmentJspBean.java
| Violation |
Line |
| Assigning an Object to null is a code smell. Consider refactoring. |
140 |
| If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation |
192 |
| These nested if statements could be combined |
205–208 |
| If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation |
260 |
| If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation |
305 |
| These nested if statements could be combined |
319–322 |
| When doing a String.toLowerCase()/toUpperCase() call, use a Locale |
367 |
| These nested if statements could be combined |
451–456 |
| If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation |
462 |
| If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation |
502 |
fr/paris/lutece/plugins/sqlpage/web/SQLPageJspBean.java
| Violation |
Line |
| Assigning an Object to null is a code smell. Consider refactoring. |
113 |
| Avoid unused method parameters such as 'request'. |
283 |
fr/paris/lutece/plugins/sqlpage/web/SQLPageSecondJspBean.java
| Violation |
Line |
| Assigning an Object to null is a code smell. Consider refactoring. |
91 |
