Fork me on GitHub
Built by Maven

PMD Results

The following document contains the results of PMD 6.13.0.

Violations By Priority

Priority 2

fr/paris/lutece/plugins/subscribe/business/SubscriptionDAO.java

Rule Violation Line
AvoidBranchingStatementAsLastInLoop Avoid using a branching statement as the last in a loop. 317

fr/paris/lutece/plugins/subscribe/service/SubscribePlugin.java

Rule Violation Line
AvoidUsingVolatile Use of modifier volatile is not recommended. 47

Priority 3

fr/paris/lutece/plugins/subscribe/business/Subscription.java

Rule Violation Line
AvoidDuplicateLiterals The String literal "#i18n{portal.validation.message.notEmpty}" appears 4 times in this file; the first occurrence is on line 53 53

fr/paris/lutece/plugins/subscribe/business/SubscriptionDAO.java

Rule Violation Line
AvoidSynchronizedAtMethodLevel Use block level rather than method level synchronization 98–115
CyclomaticComplexity The method 'findByFilter(SubscriptionFilter)' has a cyclomatic complexity of 13. 216–305
NPathComplexity The method 'findByFilter(SubscriptionFilter)' has an NPath complexity of 1782 216–305

fr/paris/lutece/plugins/subscribe/service/ISubscriptionProviderService.java

Rule Violation Line
CommentRequired Public method and constructor comments are required 68

fr/paris/lutece/plugins/subscribe/service/SubscribePlugin.java

Rule Violation Line
NonThreadSafeSingleton Singleton is not thread safe 56–62

fr/paris/lutece/plugins/subscribe/service/SubscriptionService.java

Rule Violation Line
ImmutableField Private field '_dao' could be made final; it is only initialized in the declaration or constructor. 57

fr/paris/lutece/plugins/subscribe/web/SubscribeApp.java

Rule Violation Line
ExcessiveImports A high number of imports can indicate a high degree of coupling within an object. 34–253
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 149
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 175

Priority 4

fr/paris/lutece/plugins/subscribe/business/SubscriptionDTO.java

Rule Violation Line
BooleanGetMethodName A getX() method which returns a boolean should be named isX() 93–96

Files

fr/paris/lutece/plugins/subscribe/business/Subscription.java

Rule Violation Priority Line
AvoidDuplicateLiterals The String literal "#i18n{portal.validation.message.notEmpty}" appears 4 times in this file; the first occurrence is on line 53 3 53

fr/paris/lutece/plugins/subscribe/business/SubscriptionDAO.java

Rule Violation Priority Line
AvoidSynchronizedAtMethodLevel Use block level rather than method level synchronization 3 98–115
CyclomaticComplexity The method 'findByFilter(SubscriptionFilter)' has a cyclomatic complexity of 13. 3 216–305
NPathComplexity The method 'findByFilter(SubscriptionFilter)' has an NPath complexity of 1782 3 216–305
AvoidBranchingStatementAsLastInLoop Avoid using a branching statement as the last in a loop. 2 317

fr/paris/lutece/plugins/subscribe/business/SubscriptionDTO.java

Rule Violation Priority Line
BooleanGetMethodName A getX() method which returns a boolean should be named isX() 4 93–96

fr/paris/lutece/plugins/subscribe/service/ISubscriptionProviderService.java

Rule Violation Priority Line
CommentRequired Public method and constructor comments are required 3 68

fr/paris/lutece/plugins/subscribe/service/SubscribePlugin.java

Rule Violation Priority Line
AvoidUsingVolatile Use of modifier volatile is not recommended. 2 47
NonThreadSafeSingleton Singleton is not thread safe 3 56–62

fr/paris/lutece/plugins/subscribe/service/SubscriptionService.java

Rule Violation Priority Line
ImmutableField Private field '_dao' could be made final; it is only initialized in the declaration or constructor. 3 57

fr/paris/lutece/plugins/subscribe/web/SubscribeApp.java

Rule Violation Priority Line
ExcessiveImports A high number of imports can indicate a high degree of coupling within an object. 3 34–253
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 3 149
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 3 175