Fork me on GitHub

Résultats PMD

Le document suivant contient les résultats de PMD 6.13.0.

Violations By Priority

Priority 3

fr/paris/lutece/plugins/tagcloud/business/ITagDAO.java

Rule Violation Ligne
TooManyMethods This class has too many methods, consider refactoring it. 47139
LooseCoupling Avoid using implementation types like 'ArrayList'; use the interface instead 95

fr/paris/lutece/plugins/tagcloud/business/TagCloudDAO.java

Rule Violation Ligne
TooManyMethods This class has too many methods, consider refactoring it. 48383
MissingOverride The method 'insert(Tag, Plugin)' is missing an @Override annotation. 117131
MissingOverride The method 'load(int, int, Plugin)' is missing an @Override annotation. 140163
LooseCoupling Avoid using implementation types like 'ArrayList'; use the interface instead 171
MissingOverride The method 'loadByCloud(int, Plugin)' is missing an @Override annotation. 171196
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 177
MissingOverride The method 'deleteTag(int, int, Plugin)' is missing an @Override annotation. 204211
MissingOverride The method 'store(Tag, Plugin)' is missing an @Override annotation. 218231
MissingOverride The method 'selectTagList(Plugin)' is missing an @Override annotation. 238260
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 240
MissingOverride The method 'selectTagClouds(Plugin)' is missing an @Override annotation. 267286
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 269
MissingOverride The method 'selectCloudById(int, Plugin)' is missing an @Override annotation. 294312
MissingOverride The method 'insert(TagCloud, Plugin)' is missing an @Override annotation. 319329
MissingOverride The method 'store(TagCloud, Plugin)' is missing an @Override annotation. 336345
MissingOverride The method 'deleteCloud(int, Plugin)' is missing an @Override annotation. 352358
MissingOverride The method 'selectAllTagClouds(Plugin)' is missing an @Override annotation. 365382

fr/paris/lutece/plugins/tagcloud/business/TagHome.java

Rule Violation Ligne
LooseCoupling Avoid using implementation types like 'ArrayList'; use the interface instead 117

fr/paris/lutece/plugins/tagcloud/business/portlet/ITagCloudPortletDAO.java

Rule Violation Ligne
MissingOverride The method 'delete(int)' is missing an @Override annotation. 51

fr/paris/lutece/plugins/tagcloud/business/portlet/TagCloudPortlet.java

Rule Violation Ligne
CallSuperInConstructor It is a good practice to call super() in a constructor 7073
MissingOverride The method 'getXmlDocument(HttpServletRequest)' is missing an @Override annotation. 8184
MissingOverride The method 'getXml(HttpServletRequest)' is missing an @Override annotation. 92134
ConfusingTernary Avoid if (x != y) ..; else ..; 107127
MissingOverride The method 'remove()' is missing an @Override annotation. 147150

fr/paris/lutece/plugins/tagcloud/business/portlet/TagCloudPortletDAO.java

Rule Violation Ligne
UncommentedEmptyMethodBody Document empty method body 6263
MissingOverride The method 'load(int)' is missing an @Override annotation. 7190
MissingOverride The method 'delete(int)' is missing an @Override annotation. 97103
UncommentedEmptyMethodBody Document empty method body 110111
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 120
MissingOverride The method 'selectTagCloudByPortlet(int)' is missing an @Override annotation. 144159
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 146
MissingOverride The method 'insertCloud(int, int)' is missing an @Override annotation. 166175
MissingOverride The method 'storeCloud(int, int)' is missing an @Override annotation. 182192
MissingOverride The method 'insert(Portlet)' is missing an @Override annotation. 198202
MissingOverride The method 'store(Portlet)' is missing an @Override annotation. 208211

fr/paris/lutece/plugins/tagcloud/business/portlet/TagCloudPortletHome.java

Rule Violation Ligne
AssignmentToNonFinalStatic Possible unsafe assignment to a non-final static field in a constructor. 54
RedundantFieldInitializer Avoid using redundant field initializer for '_singleton' 54
CallSuperInConstructor It is a good practice to call super() in a constructor 5965
NonThreadSafeSingleton Singleton is not thread safe 7477
MissingOverride The method 'getPortletTypeId()' is missing an @Override annotation. 8793
UnnecessaryLocalBeforeReturn Consider simply returning the value vs storing it in local variable 'strPortletTypeId' 92
MissingOverride The method 'getDAO()' is missing an @Override annotation. 100103

fr/paris/lutece/plugins/tagcloud/service/ITransformationService.java

Rule Violation Ligne
CommentRequired Public method and constructor comments are required 47
LooseCoupling Avoid using implementation types like 'ArrayList'; use the interface instead 47
LooseCoupling Avoid using implementation types like 'ArrayList'; use the interface instead 47

fr/paris/lutece/plugins/tagcloud/service/RandomTagService.java

Rule Violation Ligne
UnnecessaryConstructor Avoid unnecessary constructors - the compiler will generate these for you 4951
CommentRequired Public method and constructor comments are required 4951
UncommentedEmptyConstructor Document empty constructor 4951
LooseCoupling Avoid using implementation types like 'ArrayList'; use the interface instead 58
MissingOverride The method 'transform(ArrayList)' is missing an @Override annotation. 5872
LooseCoupling Avoid using implementation types like 'ArrayList'; use the interface instead 58

fr/paris/lutece/plugins/tagcloud/web/TagCloudJspBean.java

Rule Violation Ligne
MissingSerialVersionUID Classes implementing Serializable should set a serialVersionUID 60448
ImmutableField Private field '_nDefaultItemsPerPage' could be made final; it is only initialized in the declaration or constructor. 112
CallSuperInConstructor It is a good practice to call super() in a constructor 121124
AddEmptyString Do not add empty strings 146
AddEmptyString Do not add empty strings 181
PositionLiteralsFirstInComparisons Position literals first in String comparisons 217
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 240
PositionLiteralsFirstInComparisons Position literals first in String comparisons 242
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 353
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 355
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 356
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 385
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 386
AddEmptyString Do not add empty strings 443
AddEmptyString Do not add empty strings 443

fr/paris/lutece/plugins/tagcloud/web/portlet/TagCloudPortletJspBean.java

Rule Violation Ligne
MissingSerialVersionUID Classes implementing Serializable should set a serialVersionUID 55220
MissingOverride The method 'getCreate(HttpServletRequest)' is missing an @Override annotation. 95109
MissingOverride The method 'getModify(HttpServletRequest)' is missing an @Override annotation. 116132
AddEmptyString Do not add empty strings 128
MissingOverride The method 'doCreate(HttpServletRequest)' is missing an @Override annotation. 139167
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 144
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 147
MissingOverride The method 'doModify(HttpServletRequest)' is missing an @Override annotation. 175202

Priority 4

fr/paris/lutece/plugins/tagcloud/business/Tag.java

Rule Violation Ligne
ShortClassName Avoid short class names like Tag 40138

Fichiers

fr/paris/lutece/plugins/tagcloud/business/ITagDAO.java

Rule Violation Priority Ligne
TooManyMethods This class has too many methods, consider refactoring it. 3 47139
LooseCoupling Avoid using implementation types like 'ArrayList'; use the interface instead 3 95

fr/paris/lutece/plugins/tagcloud/business/Tag.java

Rule Violation Priority Ligne
ShortClassName Avoid short class names like Tag 4 40138

fr/paris/lutece/plugins/tagcloud/business/TagCloudDAO.java

Rule Violation Priority Ligne
TooManyMethods This class has too many methods, consider refactoring it. 3 48383
MissingOverride The method 'insert(Tag, Plugin)' is missing an @Override annotation. 3 117131
MissingOverride The method 'load(int, int, Plugin)' is missing an @Override annotation. 3 140163
LooseCoupling Avoid using implementation types like 'ArrayList'; use the interface instead 3 171
MissingOverride The method 'loadByCloud(int, Plugin)' is missing an @Override annotation. 3 171196
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 3 177
MissingOverride The method 'deleteTag(int, int, Plugin)' is missing an @Override annotation. 3 204211
MissingOverride The method 'store(Tag, Plugin)' is missing an @Override annotation. 3 218231
MissingOverride The method 'selectTagList(Plugin)' is missing an @Override annotation. 3 238260
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 3 240
MissingOverride The method 'selectTagClouds(Plugin)' is missing an @Override annotation. 3 267286
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 3 269
MissingOverride The method 'selectCloudById(int, Plugin)' is missing an @Override annotation. 3 294312
MissingOverride The method 'insert(TagCloud, Plugin)' is missing an @Override annotation. 3 319329
MissingOverride The method 'store(TagCloud, Plugin)' is missing an @Override annotation. 3 336345
MissingOverride The method 'deleteCloud(int, Plugin)' is missing an @Override annotation. 3 352358
MissingOverride The method 'selectAllTagClouds(Plugin)' is missing an @Override annotation. 3 365382

fr/paris/lutece/plugins/tagcloud/business/TagHome.java

Rule Violation Priority Ligne
LooseCoupling Avoid using implementation types like 'ArrayList'; use the interface instead 3 117

fr/paris/lutece/plugins/tagcloud/business/portlet/ITagCloudPortletDAO.java

Rule Violation Priority Ligne
MissingOverride The method 'delete(int)' is missing an @Override annotation. 3 51

fr/paris/lutece/plugins/tagcloud/business/portlet/TagCloudPortlet.java

Rule Violation Priority Ligne
CallSuperInConstructor It is a good practice to call super() in a constructor 3 7073
MissingOverride The method 'getXmlDocument(HttpServletRequest)' is missing an @Override annotation. 3 8184
MissingOverride The method 'getXml(HttpServletRequest)' is missing an @Override annotation. 3 92134
ConfusingTernary Avoid if (x != y) ..; else ..; 3 107127
MissingOverride The method 'remove()' is missing an @Override annotation. 3 147150

fr/paris/lutece/plugins/tagcloud/business/portlet/TagCloudPortletDAO.java

Rule Violation Priority Ligne
UncommentedEmptyMethodBody Document empty method body 3 6263
MissingOverride The method 'load(int)' is missing an @Override annotation. 3 7190
MissingOverride The method 'delete(int)' is missing an @Override annotation. 3 97103
UncommentedEmptyMethodBody Document empty method body 3 110111
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 3 120
MissingOverride The method 'selectTagCloudByPortlet(int)' is missing an @Override annotation. 3 144159
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 3 146
MissingOverride The method 'insertCloud(int, int)' is missing an @Override annotation. 3 166175
MissingOverride The method 'storeCloud(int, int)' is missing an @Override annotation. 3 182192
MissingOverride The method 'insert(Portlet)' is missing an @Override annotation. 3 198202
MissingOverride The method 'store(Portlet)' is missing an @Override annotation. 3 208211

fr/paris/lutece/plugins/tagcloud/business/portlet/TagCloudPortletHome.java

Rule Violation Priority Ligne
AssignmentToNonFinalStatic Possible unsafe assignment to a non-final static field in a constructor. 3 54
RedundantFieldInitializer Avoid using redundant field initializer for '_singleton' 3 54
CallSuperInConstructor It is a good practice to call super() in a constructor 3 5965
NonThreadSafeSingleton Singleton is not thread safe 3 7477
MissingOverride The method 'getPortletTypeId()' is missing an @Override annotation. 3 8793
UnnecessaryLocalBeforeReturn Consider simply returning the value vs storing it in local variable 'strPortletTypeId' 3 92
MissingOverride The method 'getDAO()' is missing an @Override annotation. 3 100103

fr/paris/lutece/plugins/tagcloud/service/ITransformationService.java

Rule Violation Priority Ligne
CommentRequired Public method and constructor comments are required 3 47
LooseCoupling Avoid using implementation types like 'ArrayList'; use the interface instead 3 47
LooseCoupling Avoid using implementation types like 'ArrayList'; use the interface instead 3 47

fr/paris/lutece/plugins/tagcloud/service/RandomTagService.java

Rule Violation Priority Ligne
UnnecessaryConstructor Avoid unnecessary constructors - the compiler will generate these for you 3 4951
CommentRequired Public method and constructor comments are required 3 4951
UncommentedEmptyConstructor Document empty constructor 3 4951
LooseCoupling Avoid using implementation types like 'ArrayList'; use the interface instead 3 58
MissingOverride The method 'transform(ArrayList)' is missing an @Override annotation. 3 5872
LooseCoupling Avoid using implementation types like 'ArrayList'; use the interface instead 3 58

fr/paris/lutece/plugins/tagcloud/web/TagCloudJspBean.java

Rule Violation Priority Ligne
MissingSerialVersionUID Classes implementing Serializable should set a serialVersionUID 3 60448
ImmutableField Private field '_nDefaultItemsPerPage' could be made final; it is only initialized in the declaration or constructor. 3 112
CallSuperInConstructor It is a good practice to call super() in a constructor 3 121124
AddEmptyString Do not add empty strings 3 146
AddEmptyString Do not add empty strings 3 181
PositionLiteralsFirstInComparisons Position literals first in String comparisons 3 217
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 3 240
PositionLiteralsFirstInComparisons Position literals first in String comparisons 3 242
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 3 353
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 3 355
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 3 356
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 3 385
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 3 386
AddEmptyString Do not add empty strings 3 443
AddEmptyString Do not add empty strings 3 443

fr/paris/lutece/plugins/tagcloud/web/portlet/TagCloudPortletJspBean.java

Rule Violation Priority Ligne
MissingSerialVersionUID Classes implementing Serializable should set a serialVersionUID 3 55220
MissingOverride The method 'getCreate(HttpServletRequest)' is missing an @Override annotation. 3 95109
MissingOverride The method 'getModify(HttpServletRequest)' is missing an @Override annotation. 3 116132
AddEmptyString Do not add empty strings 3 128
MissingOverride The method 'doCreate(HttpServletRequest)' is missing an @Override annotation. 3 139167
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 3 144
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 3 147
MissingOverride The method 'doModify(HttpServletRequest)' is missing an @Override annotation. 3 175202