Fork me on GitHub

PMD Results

The following document contains the results of PMD 6.13.0.

Violations By Priority

Priority 1

fr/paris/lutece/plugins/temporarycode/business/ITemporaryCodeConfigDAO.java

Rule Violation Line
FormalParameterNamingConventions The method parameter name '_plugin' doesn't match '[a-z][a-zA-Z0-9]*' 119

fr/paris/lutece/plugins/temporarycode/business/ITemporaryCodeDAO.java

Rule Violation Line
FormalParameterNamingConventions The method parameter name '_plugin' doesn't match '[a-z][a-zA-Z0-9]*' 132

fr/paris/lutece/plugins/temporarycode/business/TemporaryCode.java

Rule Violation Line
FormalParameterNamingConventions The method parameter name '_strComplementaryInfo' doesn't match '[a-z][a-zA-Z0-9]*' 192

fr/paris/lutece/plugins/temporarycode/utils/Constants.java

Rule Violation Line
ClassNamingConventions The utility class name 'Constants' doesn't match '[A-Z][a-zA-Z0-9]+(Utils?|Helper|Home|Service)' 4274

fr/paris/lutece/plugins/temporarycode/utils/TemporaryCodeUtils.java

Rule Violation Line
ClassWithOnlyPrivateConstructorsShouldBeFinal A class which only has private constructors should be final 56141

Priority 3

fr/paris/lutece/plugins/temporarycode/business/EnumCharacterType.java

Rule Violation Line
CommentRequired Public method and constructor comments are required 6164

fr/paris/lutece/plugins/temporarycode/business/ITemporaryCodeDAO.java

Rule Violation Line
TooManyMethods This class has too many methods, consider refactoring it. 46133

fr/paris/lutece/plugins/temporarycode/business/TemporaryCodeConfigDAO.java

Rule Violation Line
ForLoopCanBeForeach This for loop can be replaced by a foreach loop 227229

fr/paris/lutece/plugins/temporarycode/business/TemporaryCodeDAO.java

Rule Violation Line
TooManyMethods This class has too many methods, consider refactoring it. 50371
ForLoopCanBeForeach This for loop can be replaced by a foreach loop 240242

fr/paris/lutece/plugins/temporarycode/service/ClearExpiredTemporaryCodeDaemon.java

Rule Violation Line
ShortVariable Avoid variables with short names like ts 60

fr/paris/lutece/plugins/temporarycode/service/ITemporaryCodeService.java

Rule Violation Line
UnnecessaryModifier Unnecessary modifier 'public' on method 'useTemporaryCode': the method is declared in an interface type 88

fr/paris/lutece/plugins/temporarycode/service/TemporaryCodeService.java

Rule Violation Line
NonThreadSafeSingleton Singleton is not thread safe 6669
ShortVariable Avoid variables with short names like ts 140

fr/paris/lutece/plugins/temporarycode/utils/Constants.java

Rule Violation Line
FieldDeclarationsShouldBeAtStartOfClass Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. 53
FieldDeclarationsShouldBeAtStartOfClass Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. 54
FieldDeclarationsShouldBeAtStartOfClass Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. 55
FieldDeclarationsShouldBeAtStartOfClass Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. 56
FieldDeclarationsShouldBeAtStartOfClass Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. 57
FieldDeclarationsShouldBeAtStartOfClass Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. 60
FieldDeclarationsShouldBeAtStartOfClass Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. 61
FieldDeclarationsShouldBeAtStartOfClass Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. 62
FieldDeclarationsShouldBeAtStartOfClass Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. 63
FieldDeclarationsShouldBeAtStartOfClass Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. 66
FieldDeclarationsShouldBeAtStartOfClass Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. 67
FieldDeclarationsShouldBeAtStartOfClass Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. 68
FieldDeclarationsShouldBeAtStartOfClass Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. 69
FieldDeclarationsShouldBeAtStartOfClass Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. 70
FieldDeclarationsShouldBeAtStartOfClass Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. 71

fr/paris/lutece/plugins/temporarycode/utils/TemporaryCodeUtils.java

Rule Violation Line
FieldDeclarationsShouldBeAtStartOfClass Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. 68
UseLocaleWithCaseConversions When doing a String.toLowerCase()/toUpperCase() call, use a Locale 86
ShortVariable Avoid variables with short names like c 96
IdenticalCatchBranches 'catch' branch identical to 'JsonGenerationException' branch 124127
IdenticalCatchBranches 'catch' branch identical to 'JsonGenerationException' branch 128131

fr/paris/lutece/plugins/temporarycode/web/AbstractManageCodeJspBean.java

Rule Violation Line
MissingSerialVersionUID Classes implementing Serializable should set a serialVersionUID 50110
DefaultPackage Use explicit scoping instead of the default package private level 109
CommentDefaultAccessModifier To avoid mistakes add a comment at the beginning of the getItemsFromIds method if you want a default access modifier 109

fr/paris/lutece/plugins/temporarycode/web/TemporaryCodeConfigJspBean.java

Rule Violation Line
MissingSerialVersionUID Classes implementing Serializable should set a serialVersionUID 67328
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 127
DefaultPackage Use explicit scoping instead of the default package private level 144153
CommentDefaultAccessModifier To avoid mistakes add a comment at the beginning of the getItemsFromIds method if you want a default access modifier 145153
ConfusingTernary Avoid if (x != y) ..; else ..; 172

Priority 4

fr/paris/lutece/plugins/temporarycode/business/TemporaryCode.java

Rule Violation Line
BooleanGetMethodName A getX() method which returns a boolean should be named isX() 166169

fr/paris/lutece/plugins/temporarycode/web/TemporaryCodeConfigJspBean.java

Rule Violation Line
UnusedImports Avoid unused imports such as 'org.apache.commons.lang3.StringUtils' 57

Files

fr/paris/lutece/plugins/temporarycode/business/EnumCharacterType.java

Rule Violation Priority Line
CommentRequired Public method and constructor comments are required 3 6164

fr/paris/lutece/plugins/temporarycode/business/ITemporaryCodeConfigDAO.java

Rule Violation Priority Line
FormalParameterNamingConventions The method parameter name '_plugin' doesn't match '[a-z][a-zA-Z0-9]*' 1 119

fr/paris/lutece/plugins/temporarycode/business/ITemporaryCodeDAO.java

Rule Violation Priority Line
TooManyMethods This class has too many methods, consider refactoring it. 3 46133
FormalParameterNamingConventions The method parameter name '_plugin' doesn't match '[a-z][a-zA-Z0-9]*' 1 132

fr/paris/lutece/plugins/temporarycode/business/TemporaryCode.java

Rule Violation Priority Line
BooleanGetMethodName A getX() method which returns a boolean should be named isX() 4 166169
FormalParameterNamingConventions The method parameter name '_strComplementaryInfo' doesn't match '[a-z][a-zA-Z0-9]*' 1 192

fr/paris/lutece/plugins/temporarycode/business/TemporaryCodeConfigDAO.java

Rule Violation Priority Line
ForLoopCanBeForeach This for loop can be replaced by a foreach loop 3 227229

fr/paris/lutece/plugins/temporarycode/business/TemporaryCodeDAO.java

Rule Violation Priority Line
TooManyMethods This class has too many methods, consider refactoring it. 3 50371
ForLoopCanBeForeach This for loop can be replaced by a foreach loop 3 240242

fr/paris/lutece/plugins/temporarycode/service/ClearExpiredTemporaryCodeDaemon.java

Rule Violation Priority Line
ShortVariable Avoid variables with short names like ts 3 60

fr/paris/lutece/plugins/temporarycode/service/ITemporaryCodeService.java

Rule Violation Priority Line
UnnecessaryModifier Unnecessary modifier 'public' on method 'useTemporaryCode': the method is declared in an interface type 3 88

fr/paris/lutece/plugins/temporarycode/service/TemporaryCodeService.java

Rule Violation Priority Line
NonThreadSafeSingleton Singleton is not thread safe 3 6669
ShortVariable Avoid variables with short names like ts 3 140

fr/paris/lutece/plugins/temporarycode/utils/Constants.java

Rule Violation Priority Line
ClassNamingConventions The utility class name 'Constants' doesn't match '[A-Z][a-zA-Z0-9]+(Utils?|Helper|Home|Service)' 1 4274
FieldDeclarationsShouldBeAtStartOfClass Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. 3 53
FieldDeclarationsShouldBeAtStartOfClass Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. 3 54
FieldDeclarationsShouldBeAtStartOfClass Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. 3 55
FieldDeclarationsShouldBeAtStartOfClass Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. 3 56
FieldDeclarationsShouldBeAtStartOfClass Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. 3 57
FieldDeclarationsShouldBeAtStartOfClass Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. 3 60
FieldDeclarationsShouldBeAtStartOfClass Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. 3 61
FieldDeclarationsShouldBeAtStartOfClass Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. 3 62
FieldDeclarationsShouldBeAtStartOfClass Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. 3 63
FieldDeclarationsShouldBeAtStartOfClass Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. 3 66
FieldDeclarationsShouldBeAtStartOfClass Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. 3 67
FieldDeclarationsShouldBeAtStartOfClass Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. 3 68
FieldDeclarationsShouldBeAtStartOfClass Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. 3 69
FieldDeclarationsShouldBeAtStartOfClass Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. 3 70
FieldDeclarationsShouldBeAtStartOfClass Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. 3 71

fr/paris/lutece/plugins/temporarycode/utils/TemporaryCodeUtils.java

Rule Violation Priority Line
ClassWithOnlyPrivateConstructorsShouldBeFinal A class which only has private constructors should be final 1 56141
FieldDeclarationsShouldBeAtStartOfClass Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. 3 68
UseLocaleWithCaseConversions When doing a String.toLowerCase()/toUpperCase() call, use a Locale 3 86
ShortVariable Avoid variables with short names like c 3 96
IdenticalCatchBranches 'catch' branch identical to 'JsonGenerationException' branch 3 124127
IdenticalCatchBranches 'catch' branch identical to 'JsonGenerationException' branch 3 128131

fr/paris/lutece/plugins/temporarycode/web/AbstractManageCodeJspBean.java

Rule Violation Priority Line
MissingSerialVersionUID Classes implementing Serializable should set a serialVersionUID 3 50110
DefaultPackage Use explicit scoping instead of the default package private level 3 109
CommentDefaultAccessModifier To avoid mistakes add a comment at the beginning of the getItemsFromIds method if you want a default access modifier 3 109

fr/paris/lutece/plugins/temporarycode/web/TemporaryCodeConfigJspBean.java

Rule Violation Priority Line
UnusedImports Avoid unused imports such as 'org.apache.commons.lang3.StringUtils' 4 57
MissingSerialVersionUID Classes implementing Serializable should set a serialVersionUID 3 67328
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 3 127
DefaultPackage Use explicit scoping instead of the default package private level 3 144153
CommentDefaultAccessModifier To avoid mistakes add a comment at the beginning of the getItemsFromIds method if you want a default access modifier 3 145153
ConfusingTernary Avoid if (x != y) ..; else ..; 3 172