PMD Results
The following document contains the results of PMD 5.3.5.
Files
fr/paris/lutece/plugins/theme/business/ThemeDAO.java
| Violation |
Line |
| Use block level rather than method level synchronization |
69–85 |
fr/paris/lutece/plugins/theme/business/ThemeHome.java
| Violation |
Line |
| Avoid unnecessary if..then..else statements when returning booleans |
145–148 |
fr/paris/lutece/plugins/theme/service/ThemeResourceIdService.java
| Violation |
Line |
| It is a good practice to call super() in a constructor |
68–71 |
| Avoid variables with short names like rt |
78 |
| Avoid variables with short names like p |
83 |
fr/paris/lutece/plugins/theme/service/ThemeService.java
| Violation |
Line |
| Singleton is not thread safe |
66–69 |
| Document empty method |
78–79 |
| Deeply nested if..then statements are hard to read |
136–144 |
fr/paris/lutece/plugins/theme/web/ThemeJspBean.java
| Violation |
Line |
| If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation |
89 |
| If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation |
92 |
| If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation |
95 |
