Fork me on GitHub
Built by Maven

PMD Results

The following document contains the results of PMD 5.5.1.

Files

fr/paris/lutece/plugins/transparency/business/Appointment.java

Violation Line
Avoid unused imports such as 'javax.validation.constraints' 36
Avoid unused imports such as 'org.hibernate.validator.constraints' 37
The field name indicates a constant but its modifiers do not 79

fr/paris/lutece/plugins/transparency/business/AppointmentDAO.java

Violation Line
The class 'AppointmentDAO' has a Standard Cyclomatic Complexity of 4 (Highest = 12). 50–414
The class 'AppointmentDAO' has a Cyclomatic Complexity of 5 (Highest = 13). 50–414
The class 'AppointmentDAO' has a Modified Cyclomatic Complexity of 4 (Highest = 12). 50–414
The method 'selectAppointmentsList' has a Cyclomatic Complexity of 11. 193–245
Avoid variables with short names like i 200
Avoid using if statements without curly braces 205–206
Avoid using if statements without curly braces 207–208
Avoid using if statements without curly braces 209–210
Avoid using if statements without curly braces 211–212
Avoid using if statements without curly braces 213–214
Avoid using if statements without curly braces 215–216
The method 'selectAppointmentIdsList' has a Cyclomatic Complexity of 11. 251–288
Avoid variables with short names like i 259
Avoid using if statements without curly braces 264–265
Avoid using if statements without curly braces 266–267
Avoid using if statements without curly braces 268–269
Avoid using if statements without curly braces 270–271
Avoid using if statements without curly braces 272–273
Avoid using if statements without curly braces 274–275
The method 'buildSQL' has a Modified Cyclomatic Complexity of 12. 316–413
The method buildSQL() has an NPath complexity of 394 316–413
The method 'buildSQL' has a Cyclomatic Complexity of 13. 316–413
The method 'buildSQL' has a Standard Cyclomatic Complexity of 12. 316–413
Avoid variables with short names like id 349
Avoid using if statements without curly braces 379–380

fr/paris/lutece/plugins/transparency/business/ElectedOfficial.java

Violation Line
Avoid unused imports such as 'javax.validation.constraints' 36
Avoid unused imports such as 'org.hibernate.validator.constraints' 37

fr/paris/lutece/plugins/transparency/business/Lobby.java

Violation Line
Avoid unused imports such as 'javax.validation.constraints' 39
Avoid unused imports such as 'org.hibernate.validator.constraints' 40

fr/paris/lutece/plugins/transparency/business/LobbyDAO.java

Violation Line
Avoid using if statements without curly braces 193–194
Prefer StringBuffer over += for concatenating strings 194
Prefer StringBuffer over += for concatenating strings 195
Avoid using if statements without curly braces 198–199

fr/paris/lutece/plugins/transparency/rs/Constants.java

Violation Line
Avoid variables with short names like ID 45

fr/paris/lutece/plugins/transparency/rs/LobbyRest.java

Violation Line
The Logger variable declaration does not contain the static and final modifiers 63
A switch with less than three branches is inefficient, use a if statement instead. 78–84
A switch with less than three branches is inefficient, use a if statement instead. 102–108
Avoid variables with short names like id 160
A switch with less than three branches is inefficient, use a if statement instead. 162–168
Avoid variables with short names like id 181

fr/paris/lutece/plugins/transparency/rs/SwaggerRest.java

Violation Line
The Logger variable declaration does not contain the static and final modifiers 65
If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 135
Prefer StringBuffer over += for concatenating strings 145
Prefer StringBuffer over += for concatenating strings 148

fr/paris/lutece/plugins/transparency/service/ExportAppointmentService.java

Violation Line
Avoid unused imports such as 'org.apache.log4j.Logger' 24
Avoid unused imports such as 'org.apache.log4j.Logger' 24
All methods are static. Consider using a utility class instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning. 30–151
Avoid unused private fields such as 'CONSTANT_MIME_TYPE_TEXT_CSV'. 50
Avoid unused private fields such as 'CONSTANT_EXTENSION_CSV_FILE'. 52
Avoid using Literals in Conditional Statements 121
Avoid variables with short names like e 135
Avoid variables with short names like e 142

fr/paris/lutece/plugins/transparency/service/LobbyService.java

Violation Line
All methods are static. Consider using a utility class instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning. 62–186
Avoid variables with short names like ha 94
If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 96
If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 97
Avoid using if statements without curly braces 174–175
Avoid using if statements without curly braces 176–177
This statement may have some unnecessary parentheses 179

fr/paris/lutece/plugins/transparency/web/AbstractManageAppointementsJspBean.java

Violation Line
Perhaps '_nDefaultItemsPerPage' could be replaced by a local variable. 66

fr/paris/lutece/plugins/transparency/web/AbstractManageLobbiesJspBean.java

Violation Line
Perhaps '_nDefaultItemsPerPage' could be replaced by a local variable. 66

fr/paris/lutece/plugins/transparency/web/AppointmentJspBean.java

Violation Line
Avoid unused private fields such as 'INFO_APPOINTMENT_EXPORTED'. 121
Assigning an Object to null is a code smell. Consider refactoring. 136
Avoid unused local variables such as 'user'. 137
Avoid declaring a variable if it is unreferenced before a possible exit point. 137
This statement may have some unnecessary parentheses 218
This statement may have some unnecessary parentheses 335

fr/paris/lutece/plugins/transparency/web/AppointmentPublicXPage.java

Violation Line
Avoid unused imports such as 'fr.paris.lutece.portal.service.security.UserNotSignedException' 42
Avoid unused imports such as 'fr.paris.lutece.portal.service.security.UserNotSignedException' 42
Private field '_filter' could be made final; it is only initialized in the declaration or constructor. 93
Private field '_nItemsPerPage' could be made final; it is only initialized in the declaration or constructor. 95
The field name indicates a constant but its modifiers do not 99
Assigning an Object to null is a code smell. Consider refactoring. 113
Avoid using if statements without curly braces 169

fr/paris/lutece/plugins/transparency/web/AppointmentXPage.java

Violation Line
A high number of imports can indicate a high degree of coupling within an object. 35–562
The class 'AppointmentXPage' has a Cyclomatic Complexity of 5 (Highest = 11). 75–562
Private field '_filter' could be made final; it is only initialized in the declaration or constructor. 133
Private field '_nItemsPerPage' could be made final; it is only initialized in the declaration or constructor. 135
The field name indicates a constant but its modifiers do not 139
Avoid really long methods. 150–255
The method 'getManageAppointments' has a Cyclomatic Complexity of 11. 150–255
Assigning an Object to null is a code smell. Consider refactoring. 152
Avoid using if statements without curly braces 162–163
Avoid using if statements without curly braces 223
Avoid unused local variables such as 'idUser'. 322
Avoid declaring a variable if it is unreferenced before a possible exit point. 322
Avoid declaring a variable if it is unreferenced before a possible exit point. 333
This statement may have some unnecessary parentheses 370
Avoid unused local variables such as 'idUser'. 493
Avoid declaring a variable if it is unreferenced before a possible exit point. 493
This statement may have some unnecessary parentheses 526
Avoid using if statements without curly braces 550–551
Avoid using if statements without curly braces 556–557

fr/paris/lutece/plugins/transparency/web/LobbyJspBean.java

Violation Line
Avoid unused imports such as 'fr.paris.lutece.util.httpaccess.HttpAccess' 39
Avoid unused imports such as 'fr.paris.lutece.util.httpaccess.HttpAccess' 39
Avoid unused imports such as 'fr.paris.lutece.portal.service.util.AppPropertiesService' 43
Avoid unused imports such as 'fr.paris.lutece.portal.service.util.AppPropertiesService' 43
Avoid unused imports such as 'fr.paris.lutece.util.httpaccess.HttpAccessException' 47
Avoid unused imports such as 'fr.paris.lutece.util.httpaccess.HttpAccessException' 47
Avoid unused imports such as 'java.io.IOException' 49
Avoid unused imports such as 'java.io.IOException' 49
Avoid unused imports such as 'java.text.MessageFormat' 51
Avoid unused imports such as 'java.text.MessageFormat' 51
Avoid unused imports such as 'java.util.Iterator' 52
Avoid unused imports such as 'java.util.Iterator' 52
Avoid unused imports such as 'com.fasterxml.jackson.databind.JsonNode' 60
Avoid unused imports such as 'com.fasterxml.jackson.databind.JsonNode' 60
Avoid unused imports such as 'com.fasterxml.jackson.databind.ObjectMapper' 61
Avoid unused imports such as 'com.fasterxml.jackson.databind.ObjectMapper' 61
Avoid unused imports such as 'java.util.HashMap' 63
Avoid unused imports such as 'java.util.HashMap' 63
Avoid unused private fields such as 'MSG_SYNCHRO_KEY'. 92
Assigning an Object to null is a code smell. Consider refactoring. 127

fr/paris/lutece/plugins/transparency/web/LobbyXPage.java

Violation Line
Assigning an Object to null is a code smell. Consider refactoring. 86