The following document contains the results of PMD 6.13.0.
| Rule | Violation | Line |
|---|---|---|
| MissingOverride | The method 'insert(Catalog, Plugin)' is missing an @Override annotation. | 93–108 |
| MissingOverride | The method 'load(int, Plugin)' is missing an @Override annotation. | 116–139 |
| MissingOverride | The method 'delete(int, Plugin)' is missing an @Override annotation. | 146–152 |
| MissingOverride | The method 'store(Catalog, Plugin)' is missing an @Override annotation. | 159–173 |
| MissingOverride | The method 'selectCatalogsList(Plugin)' is missing an @Override annotation. | 180–203 |
| UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 182 |
| MissingOverride | The method 'selectPluginsEntries(int, Plugin)' is missing an @Override annotation. | 211–241 |
| UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 213 |
| MissingOverride | The method 'addRelease(int, int, Plugin)' is missing an @Override annotation. | 274–283 |
| MissingOverride | The method 'removeRelease(int, int, Plugin)' is missing an @Override annotation. | 291–300 |
| Rule | Violation | Line |
|---|---|---|
| ShortVariable | Avoid variables with short names like o | 144 |
| MissingOverride | The method 'compareTo(Object)' is missing an @Override annotation. | 144–149 |
| Rule | Violation | Line |
|---|---|---|
| MissingOverride | The method 'insert(CatalogPlugin, Plugin)' is missing an @Override annotation. | 66–78 |
| MissingOverride | The method 'load(String, String, Plugin)' is missing an @Override annotation. | 87–110 |
| MissingOverride | The method 'delete(String, String, Plugin)' is missing an @Override annotation. | 118–125 |
| MissingOverride | The method 'store(CatalogPlugin, Plugin)' is missing an @Override annotation. | 132–146 |
| MissingOverride | The method 'selectCatalogPluginsList(Plugin)' is missing an @Override annotation. | 153–175 |
| UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 155 |
| MissingOverride | The method 'selectPluginsListByLocale(Plugin, String)' is missing an @Override annotation. | 183–198 |
| MissingOverride | The method 'selectAvailablePluginsByLocale(Plugin, String)' is missing an @Override annotation. | 206–231 |
| UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 208 |
| MissingOverride | The method 'getPlugins(Plugin)' is missing an @Override annotation. | 238–253 |
| Rule | Violation | Line |
|---|---|---|
| UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 56 |
| ImmutableField | Private field '_listUpgrades' could be made final; it is only initialized in the declaration or constructor. | 56 |
| CommentDefaultAccessModifier | To avoid mistakes add a comment at the beginning of the addUpgrade method if you want a default access modifier | 251–254 |
| DefaultPackage | Use explicit scoping instead of the default package private level | 251–254 |
| Rule | Violation | Line |
|---|---|---|
| ImmutableField | Private field '_listUpgrades' could be made final; it is only initialized in the declaration or constructor. | 52 |
| UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 52 |
| DefaultPackage | Use explicit scoping instead of the default package private level | 166–169 |
| CommentDefaultAccessModifier | To avoid mistakes add a comment at the beginning of the addUpgrade method if you want a default access modifier | 166–169 |
| ShortVariable | Avoid variables with short names like o | 185 |
| MissingOverride | The method 'compareTo(Object)' is missing an @Override annotation. | 185–197 |
| Rule | Violation | Line |
|---|---|---|
| MissingOverride | The method 'insert(PluginRelease, Plugin)' is missing an @Override annotation. | 93–108 |
| MissingOverride | The method 'load(int, Plugin)' is missing an @Override annotation. | 116–144 |
| MissingOverride | The method 'delete(int, Plugin)' is missing an @Override annotation. | 151–172 |
| MissingOverride | The method 'store(PluginRelease, Plugin)' is missing an @Override annotation. | 179–193 |
| MissingOverride | The method 'selectPluginReleasesList(Plugin)' is missing an @Override annotation. | 200–223 |
| UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 202 |
| MissingOverride | The method 'addUpgrade(int, ReleaseUpgrade, Plugin)' is missing an @Override annotation. | 234–245 |
| MissingOverride | The method 'deleteUpgrade(int, String, Plugin)' is missing an @Override annotation. | 253–260 |
| Rule | Violation | Line |
|---|---|---|
| GodClass | Possible God Class (WMC=79, ATFD=104, TCC=19.251%) | 64–803 |
| MissingSerialVersionUID | Classes implementing Serializable should set a serialVersionUID | 64–803 |
| TooManyMethods | This class has too many methods, consider refactoring it. | 65–803 |
| UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 176 |
| ForLoopCanBeForeach | This for loop can be replaced by a foreach loop | 219–223 |
| CyclomaticComplexity | The method 'getData(HttpServletRequest, Catalog)' has a cyclomatic complexity of 11. | 329–352 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 497 |
| CyclomaticComplexity | The method 'getPluginData(HttpServletRequest, CatalogPlugin)' has a cyclomatic complexity of 11. | 644–666 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 725 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 752 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| MissingOverride | The method 'insert(Catalog, Plugin)' is missing an @Override annotation. | 3 | 93–108 |
| MissingOverride | The method 'load(int, Plugin)' is missing an @Override annotation. | 3 | 116–139 |
| MissingOverride | The method 'delete(int, Plugin)' is missing an @Override annotation. | 3 | 146–152 |
| MissingOverride | The method 'store(Catalog, Plugin)' is missing an @Override annotation. | 3 | 159–173 |
| MissingOverride | The method 'selectCatalogsList(Plugin)' is missing an @Override annotation. | 3 | 180–203 |
| UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 3 | 182 |
| MissingOverride | The method 'selectPluginsEntries(int, Plugin)' is missing an @Override annotation. | 3 | 211–241 |
| UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 3 | 213 |
| MissingOverride | The method 'addRelease(int, int, Plugin)' is missing an @Override annotation. | 3 | 274–283 |
| MissingOverride | The method 'removeRelease(int, int, Plugin)' is missing an @Override annotation. | 3 | 291–300 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| ShortVariable | Avoid variables with short names like o | 3 | 144 |
| MissingOverride | The method 'compareTo(Object)' is missing an @Override annotation. | 3 | 144–149 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| MissingOverride | The method 'insert(CatalogPlugin, Plugin)' is missing an @Override annotation. | 3 | 66–78 |
| MissingOverride | The method 'load(String, String, Plugin)' is missing an @Override annotation. | 3 | 87–110 |
| MissingOverride | The method 'delete(String, String, Plugin)' is missing an @Override annotation. | 3 | 118–125 |
| MissingOverride | The method 'store(CatalogPlugin, Plugin)' is missing an @Override annotation. | 3 | 132–146 |
| MissingOverride | The method 'selectCatalogPluginsList(Plugin)' is missing an @Override annotation. | 3 | 153–175 |
| UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 3 | 155 |
| MissingOverride | The method 'selectPluginsListByLocale(Plugin, String)' is missing an @Override annotation. | 3 | 183–198 |
| MissingOverride | The method 'selectAvailablePluginsByLocale(Plugin, String)' is missing an @Override annotation. | 3 | 206–231 |
| UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 3 | 208 |
| MissingOverride | The method 'getPlugins(Plugin)' is missing an @Override annotation. | 3 | 238–253 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 3 | 56 |
| ImmutableField | Private field '_listUpgrades' could be made final; it is only initialized in the declaration or constructor. | 3 | 56 |
| CommentDefaultAccessModifier | To avoid mistakes add a comment at the beginning of the addUpgrade method if you want a default access modifier | 3 | 251–254 |
| DefaultPackage | Use explicit scoping instead of the default package private level | 3 | 251–254 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| ImmutableField | Private field '_listUpgrades' could be made final; it is only initialized in the declaration or constructor. | 3 | 52 |
| UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 3 | 52 |
| DefaultPackage | Use explicit scoping instead of the default package private level | 3 | 166–169 |
| CommentDefaultAccessModifier | To avoid mistakes add a comment at the beginning of the addUpgrade method if you want a default access modifier | 3 | 166–169 |
| ShortVariable | Avoid variables with short names like o | 3 | 185 |
| MissingOverride | The method 'compareTo(Object)' is missing an @Override annotation. | 3 | 185–197 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| MissingOverride | The method 'insert(PluginRelease, Plugin)' is missing an @Override annotation. | 3 | 93–108 |
| MissingOverride | The method 'load(int, Plugin)' is missing an @Override annotation. | 3 | 116–144 |
| MissingOverride | The method 'delete(int, Plugin)' is missing an @Override annotation. | 3 | 151–172 |
| MissingOverride | The method 'store(PluginRelease, Plugin)' is missing an @Override annotation. | 3 | 179–193 |
| MissingOverride | The method 'selectPluginReleasesList(Plugin)' is missing an @Override annotation. | 3 | 200–223 |
| UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 3 | 202 |
| MissingOverride | The method 'addUpgrade(int, ReleaseUpgrade, Plugin)' is missing an @Override annotation. | 3 | 234–245 |
| MissingOverride | The method 'deleteUpgrade(int, String, Plugin)' is missing an @Override annotation. | 3 | 253–260 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| GodClass | Possible God Class (WMC=79, ATFD=104, TCC=19.251%) | 3 | 64–803 |
| MissingSerialVersionUID | Classes implementing Serializable should set a serialVersionUID | 3 | 64–803 |
| TooManyMethods | This class has too many methods, consider refactoring it. | 3 | 65–803 |
| UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 3 | 176 |
| ForLoopCanBeForeach | This for loop can be replaced by a foreach loop | 3 | 219–223 |
| CyclomaticComplexity | The method 'getData(HttpServletRequest, Catalog)' has a cyclomatic complexity of 11. | 3 | 329–352 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 497 |
| CyclomaticComplexity | The method 'getPluginData(HttpServletRequest, CatalogPlugin)' has a cyclomatic complexity of 11. | 3 | 644–666 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 725 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 752 |
