Fork me on GitHub

Résultats PMD

Le document suivant contient les résultats de PMD 6.13.0.

Violations By Priority

Priority 1

fr/paris/lutece/plugins/uploadimage/web/ManageUploadimageJspBean.java

Rule Violation Ligne
FieldNamingConventions The constant name 'PARAMETER_Modal' doesn't match '[A-Z][A-Z_0-9]*' 82

Priority 3

fr/paris/lutece/plugins/uploadimage/business/Options.java

Rule Violation Ligne
ExcessivePublicCount This class has a bunch of public methods and attributes 34–507
TooManyFields Too many fields 43–507
ShortVariable Avoid variables with short names like nX 450
ShortVariable Avoid variables with short names like nY 467

fr/paris/lutece/plugins/uploadimage/business/OptionsDAO.java

Rule Violation Ligne
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 222
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 268

fr/paris/lutece/plugins/uploadimage/service/IImageService.java

Rule Violation Ligne
CommentRequired Header comments are required 5–9
CommentRequired Public method and constructor comments are required 7
UnnecessaryModifier Unnecessary modifier 'public' on method 'createOption': the method is declared in an interface type 7

fr/paris/lutece/plugins/uploadimage/service/ImageService.java

Rule Violation Ligne
CommentRequired Header comments are required 6–15

fr/paris/lutece/plugins/uploadimage/service/UploadImageCacheService.java

Rule Violation Ligne
CallSuperInConstructor It is a good practice to call super() in a constructor 17–20

fr/paris/lutece/plugins/uploadimage/web/ManageUploadimageJspBean.java

Rule Violation Ligne
MissingSerialVersionUID Classes implementing Serializable should set a serialVersionUID 58–298
CommentRequired Protected method constructor comments are required 109–131
AddEmptyString Do not add empty strings 126
AddEmptyString Do not add empty strings 154
CommentRequired Public method and constructor comments are required 163–238
NcssCount The method 'manageOptions(HttpServletRequest)' has a NCSS line count of 61. 163–238
ShortVariable Avoid variables with short names like nX 185
ShortVariable Avoid variables with short names like nY 186
AvoidDuplicateLiterals The String literal "action" appears 4 times in this file; the first occurrence is on line 193 193
PositionLiteralsFirstInComparisons Position literals first in String comparisons 222
CommentRequired Public method and constructor comments are required 240–262
ConfusingTernary Avoid if (x != y) ..; else ..; 245–254
CommentRequired Public method and constructor comments are required 281–289

fr/paris/lutece/plugins/uploadimage/web/UploadimageApp.java

Rule Violation Ligne
MissingSerialVersionUID Classes implementing Serializable should set a serialVersionUID 58–156
UnusedPrivateField Avoid unused private fields such as 'IDOPTION'. 66
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 79
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 79
CommentRequired Public method and constructor comments are required 85–121
ConfusingTernary Avoid if (x != y) ..; else ..; 93–97
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 109
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 109

Priority 4

fr/paris/lutece/plugins/uploadimage/business/Options.java

Rule Violation Ligne
UnusedImports Avoid unused imports such as 'org.hibernate.validator.constraints' 37
BooleanGetMethodName A getX() method which returns a boolean should be named isX() 118–121
BooleanGetMethodName A getX() method which returns a boolean should be named isX() 135–138
BooleanGetMethodName A getX() method which returns a boolean should be named isX() 152–155
BooleanGetMethodName A getX() method which returns a boolean should be named isX() 169–172
BooleanGetMethodName A getX() method which returns a boolean should be named isX() 186–189
BooleanGetMethodName A getX() method which returns a boolean should be named isX() 203–206
BooleanGetMethodName A getX() method which returns a boolean should be named isX() 220–223
BooleanGetMethodName A getX() method which returns a boolean should be named isX() 237–240
BooleanGetMethodName A getX() method which returns a boolean should be named isX() 254–257
BooleanGetMethodName A getX() method which returns a boolean should be named isX() 271–274
BooleanGetMethodName A getX() method which returns a boolean should be named isX() 288–291
BooleanGetMethodName A getX() method which returns a boolean should be named isX() 305–308
BooleanGetMethodName A getX() method which returns a boolean should be named isX() 322–325
BooleanGetMethodName A getX() method which returns a boolean should be named isX() 339–342
BooleanGetMethodName A getX() method which returns a boolean should be named isX() 356–359
BooleanGetMethodName A getX() method which returns a boolean should be named isX() 373–376
BooleanGetMethodName A getX() method which returns a boolean should be named isX() 390–393

fr/paris/lutece/plugins/uploadimage/web/UploadimageApp.java

Rule Violation Ligne
UnusedImports Avoid unused imports such as 'org.apache.commons.lang3.util' 51

Fichiers

fr/paris/lutece/plugins/uploadimage/business/Options.java

Rule Violation Priority Ligne
ExcessivePublicCount This class has a bunch of public methods and attributes 3 34–507
UnusedImports Avoid unused imports such as 'org.hibernate.validator.constraints' 4 37
TooManyFields Too many fields 3 43–507
BooleanGetMethodName A getX() method which returns a boolean should be named isX() 4 118–121
BooleanGetMethodName A getX() method which returns a boolean should be named isX() 4 135–138
BooleanGetMethodName A getX() method which returns a boolean should be named isX() 4 152–155
BooleanGetMethodName A getX() method which returns a boolean should be named isX() 4 169–172
BooleanGetMethodName A getX() method which returns a boolean should be named isX() 4 186–189
BooleanGetMethodName A getX() method which returns a boolean should be named isX() 4 203–206
BooleanGetMethodName A getX() method which returns a boolean should be named isX() 4 220–223
BooleanGetMethodName A getX() method which returns a boolean should be named isX() 4 237–240
BooleanGetMethodName A getX() method which returns a boolean should be named isX() 4 254–257
BooleanGetMethodName A getX() method which returns a boolean should be named isX() 4 271–274
BooleanGetMethodName A getX() method which returns a boolean should be named isX() 4 288–291
BooleanGetMethodName A getX() method which returns a boolean should be named isX() 4 305–308
BooleanGetMethodName A getX() method which returns a boolean should be named isX() 4 322–325
BooleanGetMethodName A getX() method which returns a boolean should be named isX() 4 339–342
BooleanGetMethodName A getX() method which returns a boolean should be named isX() 4 356–359
BooleanGetMethodName A getX() method which returns a boolean should be named isX() 4 373–376
BooleanGetMethodName A getX() method which returns a boolean should be named isX() 4 390–393
ShortVariable Avoid variables with short names like nX 3 450
ShortVariable Avoid variables with short names like nY 3 467

fr/paris/lutece/plugins/uploadimage/business/OptionsDAO.java

Rule Violation Priority Ligne
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 3 222
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 3 268

fr/paris/lutece/plugins/uploadimage/service/IImageService.java

Rule Violation Priority Ligne
CommentRequired Header comments are required 3 5–9
CommentRequired Public method and constructor comments are required 3 7
UnnecessaryModifier Unnecessary modifier 'public' on method 'createOption': the method is declared in an interface type 3 7

fr/paris/lutece/plugins/uploadimage/service/ImageService.java

Rule Violation Priority Ligne
CommentRequired Header comments are required 3 6–15

fr/paris/lutece/plugins/uploadimage/service/UploadImageCacheService.java

Rule Violation Priority Ligne
CallSuperInConstructor It is a good practice to call super() in a constructor 3 17–20

fr/paris/lutece/plugins/uploadimage/web/ManageUploadimageJspBean.java

Rule Violation Priority Ligne
MissingSerialVersionUID Classes implementing Serializable should set a serialVersionUID 3 58–298
FieldNamingConventions The constant name 'PARAMETER_Modal' doesn't match '[A-Z][A-Z_0-9]*' 1 82
CommentRequired Protected method constructor comments are required 3 109–131
AddEmptyString Do not add empty strings 3 126
AddEmptyString Do not add empty strings 3 154
CommentRequired Public method and constructor comments are required 3 163–238
NcssCount The method 'manageOptions(HttpServletRequest)' has a NCSS line count of 61. 3 163–238
ShortVariable Avoid variables with short names like nX 3 185
ShortVariable Avoid variables with short names like nY 3 186
AvoidDuplicateLiterals The String literal "action" appears 4 times in this file; the first occurrence is on line 193 3 193
PositionLiteralsFirstInComparisons Position literals first in String comparisons 3 222
CommentRequired Public method and constructor comments are required 3 240–262
ConfusingTernary Avoid if (x != y) ..; else ..; 3 245–254
CommentRequired Public method and constructor comments are required 3 281–289

fr/paris/lutece/plugins/uploadimage/web/UploadimageApp.java

Rule Violation Priority Ligne
UnusedImports Avoid unused imports such as 'org.apache.commons.lang3.util' 4 51
MissingSerialVersionUID Classes implementing Serializable should set a serialVersionUID 3 58–156
UnusedPrivateField Avoid unused private fields such as 'IDOPTION'. 3 66
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 3 79
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 3 79
CommentRequired Public method and constructor comments are required 3 85–121
ConfusingTernary Avoid if (x != y) ..; else ..; 3 93–97
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 3 109
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 3 109