Fork me on GitHub

PMD Results

The following document contains the results of PMD 6.13.0.

Violations By Priority

Priority 1

fr/paris/lutece/plugins/uploadimage/web/ManageUploadimageJspBean.java

Rule Violation Line
FieldNamingConventions The constant name 'PARAMETER_Modal' doesn't match '[A-Z][A-Z_0-9]*' 82

Priority 3

fr/paris/lutece/plugins/uploadimage/business/Options.java

Rule Violation Line
ExcessivePublicCount This class has a bunch of public methods and attributes 34507
TooManyFields Too many fields 43507
ShortVariable Avoid variables with short names like nX 450
ShortVariable Avoid variables with short names like nY 467

fr/paris/lutece/plugins/uploadimage/business/OptionsDAO.java

Rule Violation Line
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 222
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 268

fr/paris/lutece/plugins/uploadimage/service/IImageService.java

Rule Violation Line
CommentRequired Header comments are required 59
CommentRequired Public method and constructor comments are required 7
UnnecessaryModifier Unnecessary modifier 'public' on method 'createOption': the method is declared in an interface type 7

fr/paris/lutece/plugins/uploadimage/service/ImageService.java

Rule Violation Line
CommentRequired Header comments are required 615

fr/paris/lutece/plugins/uploadimage/service/UploadImageCacheService.java

Rule Violation Line
CallSuperInConstructor It is a good practice to call super() in a constructor 1720

fr/paris/lutece/plugins/uploadimage/web/ManageUploadimageJspBean.java

Rule Violation Line
MissingSerialVersionUID Classes implementing Serializable should set a serialVersionUID 58298
CommentRequired Protected method constructor comments are required 109131
AddEmptyString Do not add empty strings 126
AddEmptyString Do not add empty strings 154
NcssCount The method 'manageOptions(HttpServletRequest)' has a NCSS line count of 61. 163238
CommentRequired Public method and constructor comments are required 163238
ShortVariable Avoid variables with short names like nX 185
ShortVariable Avoid variables with short names like nY 186
AvoidDuplicateLiterals The String literal "action" appears 4 times in this file; the first occurrence is on line 193 193
PositionLiteralsFirstInComparisons Position literals first in String comparisons 222
CommentRequired Public method and constructor comments are required 240262
ConfusingTernary Avoid if (x != y) ..; else ..; 245254
CommentRequired Public method and constructor comments are required 281289

fr/paris/lutece/plugins/uploadimage/web/UploadimageApp.java

Rule Violation Line
MissingSerialVersionUID Classes implementing Serializable should set a serialVersionUID 58156
UnusedPrivateField Avoid unused private fields such as 'IDOPTION'. 66
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 79
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 79
CommentRequired Public method and constructor comments are required 85121
ConfusingTernary Avoid if (x != y) ..; else ..; 9397
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 109
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 109

Priority 4

fr/paris/lutece/plugins/uploadimage/business/Options.java

Rule Violation Line
UnusedImports Avoid unused imports such as 'org.hibernate.validator.constraints' 37
BooleanGetMethodName A getX() method which returns a boolean should be named isX() 118121
BooleanGetMethodName A getX() method which returns a boolean should be named isX() 135138
BooleanGetMethodName A getX() method which returns a boolean should be named isX() 152155
BooleanGetMethodName A getX() method which returns a boolean should be named isX() 169172
BooleanGetMethodName A getX() method which returns a boolean should be named isX() 186189
BooleanGetMethodName A getX() method which returns a boolean should be named isX() 203206
BooleanGetMethodName A getX() method which returns a boolean should be named isX() 220223
BooleanGetMethodName A getX() method which returns a boolean should be named isX() 237240
BooleanGetMethodName A getX() method which returns a boolean should be named isX() 254257
BooleanGetMethodName A getX() method which returns a boolean should be named isX() 271274
BooleanGetMethodName A getX() method which returns a boolean should be named isX() 288291
BooleanGetMethodName A getX() method which returns a boolean should be named isX() 305308
BooleanGetMethodName A getX() method which returns a boolean should be named isX() 322325
BooleanGetMethodName A getX() method which returns a boolean should be named isX() 339342
BooleanGetMethodName A getX() method which returns a boolean should be named isX() 356359
BooleanGetMethodName A getX() method which returns a boolean should be named isX() 373376
BooleanGetMethodName A getX() method which returns a boolean should be named isX() 390393

fr/paris/lutece/plugins/uploadimage/web/UploadimageApp.java

Rule Violation Line
UnusedImports Avoid unused imports such as 'org.apache.commons.lang3.util' 51

Files

fr/paris/lutece/plugins/uploadimage/business/Options.java

Rule Violation Priority Line
ExcessivePublicCount This class has a bunch of public methods and attributes 3 34507
UnusedImports Avoid unused imports such as 'org.hibernate.validator.constraints' 4 37
TooManyFields Too many fields 3 43507
BooleanGetMethodName A getX() method which returns a boolean should be named isX() 4 118121
BooleanGetMethodName A getX() method which returns a boolean should be named isX() 4 135138
BooleanGetMethodName A getX() method which returns a boolean should be named isX() 4 152155
BooleanGetMethodName A getX() method which returns a boolean should be named isX() 4 169172
BooleanGetMethodName A getX() method which returns a boolean should be named isX() 4 186189
BooleanGetMethodName A getX() method which returns a boolean should be named isX() 4 203206
BooleanGetMethodName A getX() method which returns a boolean should be named isX() 4 220223
BooleanGetMethodName A getX() method which returns a boolean should be named isX() 4 237240
BooleanGetMethodName A getX() method which returns a boolean should be named isX() 4 254257
BooleanGetMethodName A getX() method which returns a boolean should be named isX() 4 271274
BooleanGetMethodName A getX() method which returns a boolean should be named isX() 4 288291
BooleanGetMethodName A getX() method which returns a boolean should be named isX() 4 305308
BooleanGetMethodName A getX() method which returns a boolean should be named isX() 4 322325
BooleanGetMethodName A getX() method which returns a boolean should be named isX() 4 339342
BooleanGetMethodName A getX() method which returns a boolean should be named isX() 4 356359
BooleanGetMethodName A getX() method which returns a boolean should be named isX() 4 373376
BooleanGetMethodName A getX() method which returns a boolean should be named isX() 4 390393
ShortVariable Avoid variables with short names like nX 3 450
ShortVariable Avoid variables with short names like nY 3 467

fr/paris/lutece/plugins/uploadimage/business/OptionsDAO.java

Rule Violation Priority Line
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 3 222
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 3 268

fr/paris/lutece/plugins/uploadimage/service/IImageService.java

Rule Violation Priority Line
CommentRequired Header comments are required 3 59
CommentRequired Public method and constructor comments are required 3 7
UnnecessaryModifier Unnecessary modifier 'public' on method 'createOption': the method is declared in an interface type 3 7

fr/paris/lutece/plugins/uploadimage/service/ImageService.java

Rule Violation Priority Line
CommentRequired Header comments are required 3 615

fr/paris/lutece/plugins/uploadimage/service/UploadImageCacheService.java

Rule Violation Priority Line
CallSuperInConstructor It is a good practice to call super() in a constructor 3 1720

fr/paris/lutece/plugins/uploadimage/web/ManageUploadimageJspBean.java

Rule Violation Priority Line
MissingSerialVersionUID Classes implementing Serializable should set a serialVersionUID 3 58298
FieldNamingConventions The constant name 'PARAMETER_Modal' doesn't match '[A-Z][A-Z_0-9]*' 1 82
CommentRequired Protected method constructor comments are required 3 109131
AddEmptyString Do not add empty strings 3 126
AddEmptyString Do not add empty strings 3 154
NcssCount The method 'manageOptions(HttpServletRequest)' has a NCSS line count of 61. 3 163238
CommentRequired Public method and constructor comments are required 3 163238
ShortVariable Avoid variables with short names like nX 3 185
ShortVariable Avoid variables with short names like nY 3 186
AvoidDuplicateLiterals The String literal "action" appears 4 times in this file; the first occurrence is on line 193 3 193
PositionLiteralsFirstInComparisons Position literals first in String comparisons 3 222
CommentRequired Public method and constructor comments are required 3 240262
ConfusingTernary Avoid if (x != y) ..; else ..; 3 245254
CommentRequired Public method and constructor comments are required 3 281289

fr/paris/lutece/plugins/uploadimage/web/UploadimageApp.java

Rule Violation Priority Line
UnusedImports Avoid unused imports such as 'org.apache.commons.lang3.util' 4 51
MissingSerialVersionUID Classes implementing Serializable should set a serialVersionUID 3 58156
UnusedPrivateField Avoid unused private fields such as 'IDOPTION'. 3 66
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 3 79
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 3 79
CommentRequired Public method and constructor comments are required 3 85121
ConfusingTernary Avoid if (x != y) ..; else ..; 3 9397
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 3 109
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 3 109