Fork me on GitHub

PMD Results

The following document contains the results of PMD 6.13.0.

Violations By Priority

Priority 1

fr/paris/lutece/plugins/urlrewriteradmin/service/AliasGeneratorService.java

Rule Violation Line
ClassWithOnlyPrivateConstructorsShouldBeFinal A class which only has private constructors should be final 49–158

Priority 3

fr/paris/lutece/plugins/urlrewriteradmin/business/UrlRewriterRuleDAO.java

Rule Violation Line
MissingOverride The method 'insert(UrlRewriterRule, Plugin)' is missing an @Override annotation. 85–97
MissingOverride The method 'load(int, Plugin)' is missing an @Override annotation. 105–125
MissingOverride The method 'delete(int, Plugin)' is missing an @Override annotation. 132–138
MissingOverride The method 'store(UrlRewriterRule, Plugin)' is missing an @Override annotation. 145–156
MissingOverride The method 'selectUrlRewriterRulesList(Plugin)' is missing an @Override annotation. 163–183
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 165

fr/paris/lutece/plugins/urlrewriteradmin/service/AliasGeneratorService.java

Rule Violation Line
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 53
AvoidSynchronizedAtMethodLevel Use block level rather than method level synchronization 67–77
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 87
ConfusingTernary Avoid if (x != y) ..; else ..; 123–142

fr/paris/lutece/plugins/urlrewriteradmin/service/AliasGeneratorUtils.java

Rule Violation Line
UseUtilityClass All methods are static. Consider using a utility class instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning. 43–58
UseLocaleWithCaseConversions When doing a String.toLowerCase()/toUpperCase() call, use a Locale 51

fr/paris/lutece/plugins/urlrewriteradmin/service/RuleFileService.java

Rule Violation Line
ShortVariable Avoid variables with short names like t 90

fr/paris/lutece/plugins/urlrewriteradmin/web/UrlRewriterAdminJspBean.java

Rule Violation Line
MissingSerialVersionUID Classes implementing Serializable should set a serialVersionUID 66–363
SingularField Perhaps '_nDefaultItemsPerPage' could be replaced by a local variable. 113
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 138
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 138
AddEmptyString Do not add empty strings 140
SimplifyBooleanReturns Avoid unnecessary if..then..else statements when returning booleans 356–359

Files

fr/paris/lutece/plugins/urlrewriteradmin/business/UrlRewriterRuleDAO.java

Rule Violation Priority Line
MissingOverride The method 'insert(UrlRewriterRule, Plugin)' is missing an @Override annotation. 3 85–97
MissingOverride The method 'load(int, Plugin)' is missing an @Override annotation. 3 105–125
MissingOverride The method 'delete(int, Plugin)' is missing an @Override annotation. 3 132–138
MissingOverride The method 'store(UrlRewriterRule, Plugin)' is missing an @Override annotation. 3 145–156
MissingOverride The method 'selectUrlRewriterRulesList(Plugin)' is missing an @Override annotation. 3 163–183
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 3 165

fr/paris/lutece/plugins/urlrewriteradmin/service/AliasGeneratorService.java

Rule Violation Priority Line
ClassWithOnlyPrivateConstructorsShouldBeFinal A class which only has private constructors should be final 1 49–158
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 3 53
AvoidSynchronizedAtMethodLevel Use block level rather than method level synchronization 3 67–77
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 3 87
ConfusingTernary Avoid if (x != y) ..; else ..; 3 123–142

fr/paris/lutece/plugins/urlrewriteradmin/service/AliasGeneratorUtils.java

Rule Violation Priority Line
UseUtilityClass All methods are static. Consider using a utility class instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning. 3 43–58
UseLocaleWithCaseConversions When doing a String.toLowerCase()/toUpperCase() call, use a Locale 3 51

fr/paris/lutece/plugins/urlrewriteradmin/service/RuleFileService.java

Rule Violation Priority Line
ShortVariable Avoid variables with short names like t 3 90

fr/paris/lutece/plugins/urlrewriteradmin/web/UrlRewriterAdminJspBean.java

Rule Violation Priority Line
MissingSerialVersionUID Classes implementing Serializable should set a serialVersionUID 3 66–363
SingularField Perhaps '_nDefaultItemsPerPage' could be replaced by a local variable. 3 113
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 3 138
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 3 138
AddEmptyString Do not add empty strings 3 140
SimplifyBooleanReturns Avoid unnecessary if..then..else statements when returning booleans 3 356–359