PMD Results
The following document contains the results of PMD 5.3.5.
Files
fr/paris/lutece/plugins/urlrewriteradmin/service/AliasGeneratorService.java
Violation |
Line |
A class which only has private constructors should be final |
49–158 |
Use block level rather than method level synchronization |
67–77 |
The method processRuleList() has an NPath complexity of 875 |
106–144 |
fr/paris/lutece/plugins/urlrewriteradmin/service/AliasGeneratorUtils.java
Violation |
Line |
All methods are static. Consider using a utility class instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning. |
43–58 |
When doing a String.toLowerCase()/toUpperCase() call, use a Locale |
51 |
fr/paris/lutece/plugins/urlrewriteradmin/service/PageAliasGenerator.java
Violation |
Line |
The method findPage() has an NPath complexity of 250 |
85–102 |
Prefer StringBuffer over += for concatenating strings |
93 |
fr/paris/lutece/plugins/urlrewriteradmin/service/RuleFileService.java
Violation |
Line |
Avoid variables with short names like t |
90 |
fr/paris/lutece/plugins/urlrewriteradmin/web/UrlRewriterAdminJspBean.java
Violation |
Line |
Perhaps '_nDefaultItemsPerPage' could be replaced by a local variable. |
113 |
If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation |
138 |
Do not add empty strings |
140 |
Avoid unnecessary if..then..else statements when returning booleans |
356–359 |