The following document contains the results of PMD 6.13.0.
Rule | Violation | Line |
---|---|---|
FormalParameterNamingConventions | The method parameter name '_strPath' doesn't match '[a-z][a-zA-Z0-9]*' | 166 |
FormalParameterNamingConventions | The method parameter name '_strType' doesn't match '[a-z][a-zA-Z0-9]*' | 187 |
FormalParameterNamingConventions | The method parameter name '_listProperties' doesn't match '[a-z][a-zA-Z0-9]*' | 208 |
Rule | Violation | Line |
---|---|---|
FormalParameterNamingConventions | The method parameter name '_plugin' doesn't match '[a-z][a-zA-Z0-9]*' | 128 |
Rule | Violation | Line |
---|---|---|
FormalParameterNamingConventions | The method parameter name '_plugin' doesn't match '[a-z][a-zA-Z0-9]*' | 127 |
Rule | Violation | Line |
---|---|---|
FormalParameterNamingConventions | The method parameter name '_plugin' doesn't match '[a-z][a-zA-Z0-9]*' | 127 |
Rule | Violation | Line |
---|---|---|
ClassNamingConventions | The utility class name 'VaultAPI' doesn't match '[A-Z][a-zA-Z0-9]+(Utils?|Helper|Home|Service)' | 52–170 |
Rule | Violation | Line |
---|---|---|
LocalVariableNamingConventions | The local variable name '_listNamesEnvironnements' doesn't match '[a-z][a-zA-Z0-9]*' | 65 |
Rule | Violation | Line |
---|---|---|
LocalVariableNamingConventions | The local variable name '_properties' doesn't match '[a-z][a-zA-Z0-9]*' | 401 |
Rule | Violation | Line |
---|---|---|
LocalVariableNamingConventions | The local variable name '_environnement' doesn't match '[a-z][a-zA-Z0-9]*' | 129 |
Rule | Violation | Line |
---|---|---|
SystemPrintln | System.out.println is used | 278 |
Rule | Violation | Line |
---|---|---|
ForLoopCanBeForeach | This for loop can be replaced by a foreach loop | 217–220 |
Rule | Violation | Line |
---|---|---|
ForLoopCanBeForeach | This for loop can be replaced by a foreach loop | 199–202 |
Rule | Violation | Line |
---|---|---|
UnusedPrivateField | Avoid unused private fields such as '_count'. | 60 |
Rule | Violation | Line |
---|---|---|
CommentRequired | Public method and constructor comments are required | 129 |
CommentRequired | Public method and constructor comments are required | 131 |
Rule | Violation | Line |
---|---|---|
CommentRequired | Public method and constructor comments are required | 129 |
Rule | Violation | Line |
---|---|---|
UnusedPrivateField | Avoid unused private fields such as '_plugin'. | 55 |
Rule | Violation | Line |
---|---|---|
CommentRequired | Header comments are required | 52–170 |
UseUtilityClass | All methods are static. Consider using a utility class instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning. | 53–170 |
CommentRequired | Public method and constructor comments are required | 55–93 |
AvoidDuplicateLiterals | The String literal "application/json" appears 4 times in this file; the first occurrence is on line 71 | 71 |
AvoidCatchingGenericException | Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 89 |
CommentRequired | Public method and constructor comments are required | 95–125 |
AvoidCatchingGenericException | Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 121 |
CommentRequired | Public method and constructor comments are required | 127–169 |
AvoidCatchingGenericException | Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 164 |
Rule | Violation | Line |
---|---|---|
UseUtilityClass | All methods are static. Consider using a utility class instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning. | 50–81 |
ForLoopCanBeForeach | This for loop can be replaced by a foreach loop | 67–70 |
CommentRequired | Public method and constructor comments are required | 76–79 |
Rule | Violation | Line |
---|---|---|
ImmutableField | Private field '_listEnvAccessor' could be made final; it is only initialized in the declaration or constructor. | 56 |
SingularField | Perhaps '_listEnvSecrets' could be replaced by a local variable. | 57 |
RedundantFieldInitializer | Avoid using redundant field initializer for '_instance' | 59 |
NonThreadSafeSingleton | Singleton is not thread safe | 83–88 |
UseLocaleWithCaseConversions | When doing a String.toLowerCase()/toUpperCase() call, use a Locale | 118 |
UseLocaleWithCaseConversions | When doing a String.toLowerCase()/toUpperCase() call, use a Locale | 118 |
UseLocaleWithCaseConversions | When doing a String.toLowerCase()/toUpperCase() call, use a Locale | 151 |
UseLocaleWithCaseConversions | When doing a String.toLowerCase()/toUpperCase() call, use a Locale | 151 |
CommentRequired | Public method and constructor comments are required | 167–193 |
UseLocaleWithCaseConversions | When doing a String.toLowerCase()/toUpperCase() call, use a Locale | 268 |
UseLocaleWithCaseConversions | When doing a String.toLowerCase()/toUpperCase() call, use a Locale | 268 |
UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 298 |
UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 298 |
UnnecessaryLocalBeforeReturn | Consider simply returning the value vs storing it in local variable 'listAllSecrets' | 367 |
ForLoopCanBeForeach | This for loop can be replaced by a foreach loop | 397–406 |
UnusedLocalVariable | Avoid unused local variables such as 'appId'. | 399 |
UnnecessaryLocalBeforeReturn | Consider simply returning the value vs storing it in local variable 'secretKV' | 436 |
AvoidPrintStackTrace | Avoid printStackTrace(); use a logger call instead. | 443 |
AvoidPrintStackTrace | Avoid printStackTrace(); use a logger call instead. | 480 |
Rule | Violation | Line |
---|---|---|
MissingSerialVersionUID | Classes implementing Serializable should set a serialVersionUID | 45–78 |
UseUtilityClass | All methods are static. Consider using a utility class instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning. | 46–78 |
RedundantFieldInitializer | Avoid using redundant field initializer for '_vault' | 47 |
Rule | Violation | Line |
---|---|---|
MissingSerialVersionUID | Classes implementing Serializable should set a serialVersionUID | 50–117 |
CommentDefaultAccessModifier | To avoid mistakes add a comment at the beginning of the getItemsFromIds method if you want a default access modifier | 116 |
DefaultPackage | Use explicit scoping instead of the default package private level | 116 |
Rule | Violation | Line |
---|---|---|
MissingSerialVersionUID | Classes implementing Serializable should set a serialVersionUID | 62–299 |
NullAssignment | Assigning an Object to null is a code smell. Consider refactoring. | 125 |
DefaultPackage | Use explicit scoping instead of the default package private level | 137–144 |
CommentDefaultAccessModifier | To avoid mistakes add a comment at the beginning of the getItemsFromIds method if you want a default access modifier | 138–144 |
ConfusingTernary | Avoid if (x != y) ..; else ..; | 164 |
Rule | Violation | Line |
---|---|---|
MissingSerialVersionUID | Classes implementing Serializable should set a serialVersionUID | 66–409 |
ConfusingTernary | Avoid if (x != y) ..; else ..; | 140 |
DefaultPackage | Use explicit scoping instead of the default package private level | 163–170 |
CommentDefaultAccessModifier | To avoid mistakes add a comment at the beginning of the getItemsFromIds method if you want a default access modifier | 164–170 |
ConfusingTernary | Avoid if (x != y) ..; else ..; | 192 |
PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 373 |
PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 374 |
PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 377 |
UnusedLocalVariable | Avoid unused local variables such as 'nIdApp'. | 377 |
Rule | Violation | Line |
---|---|---|
MissingSerialVersionUID | Classes implementing Serializable should set a serialVersionUID | 64–324 |
SingularField | Perhaps '_listIdProperties' could be replaced by a local variable. | 112 |
UnusedPrivateField | Avoid unused private fields such as '_listIdProperties'. | 112 |
SingularField | Perhaps '_listProperties' could be replaced by a local variable. | 113 |
NullAssignment | Assigning an Object to null is a code smell. Consider refactoring. | 125 |
ConfusingTernary | Avoid if (x != y) ..; else ..; | 165 |
UnusedLocalVariable | Avoid unused local variables such as 'nIdApp'. | 192 |
PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 192 |
EmptyIfStmt | Avoid empty if statements | 310–311 |
DefaultPackage | Use explicit scoping instead of the default package private level | 319–323 |
CommentDefaultAccessModifier | To avoid mistakes add a comment at the beginning of the getItemsFromIds method if you want a default access modifier | 320–323 |
Rule | Violation | Line |
---|---|---|
UnusedImports | Avoid unused imports such as 'fr.paris.lutece.plugins.vault.rs.VaultAPI' | 38 |
UnusedImports | Avoid unused imports such as 'fr.paris.lutece.plugins.vault.service.VaultUtil' | 41 |
UnusedImports | Avoid unused imports such as 'fr.paris.lutece.portal.service.i18n.I18nService' | 42 |
Rule | Violation | Line |
---|---|---|
UnusedImports | Avoid unused imports such as 'java.util.List' | 39 |
Rule | Violation | Line |
---|---|---|
UnusedImports | Avoid unused imports such as 'fr.paris.lutece.portal.service.spring.SpringContextService' | 41 |
UnusedImports | Avoid unused imports such as 'fr.paris.lutece.util.ReferenceList' | 42 |
UnusedImports | Avoid unused imports such as 'java.util.List' | 44 |
UnusedImports | Avoid unused imports such as 'java.util.Optional' | 45 |
UnusedImports | Avoid unused imports such as 'org.springframework.context.i18n.LocaleContextHolder.getLocale' | 47 |
Rule | Violation | Line |
---|---|---|
UnusedImports | Avoid unused imports such as 'fr.paris.lutece.portal.util.mvc.utils.MVCMessage' | 38 |
UnusedImports | Avoid unused imports such as 'fr.paris.lutece.util.ErrorMessage' | 39 |
UnusedImports | Avoid unused imports such as 'java.util.ArrayList' | 42 |
UnusedImports | Avoid unused imports such as 'java.util.List' | 43 |
Rule | Violation | Line |
---|---|---|
UnusedImports | Avoid unused imports such as 'fr.paris.lutece.plugins.vault.service.VaultUtil' | 42 |
Rule | Violation | Line |
---|---|---|
UnusedImports | Avoid unused imports such as 'fr.paris.lutece.plugins.vault.service.VaultService' | 39 |
UnusedImports | Avoid unused imports such as 'fr.paris.lutece.plugins.vault.service.VaultUtil' | 40 |
UnusedImports | Avoid unused imports such as 'fr.paris.lutece.util.html.AbstractPaginator' | 50 |
UnusedImports | Avoid unused imports such as 'java.util.Comparator' | 52 |
UnusedImports | Avoid unused imports such as 'java.util.stream.Collectors' | 57 |
Rule | Violation | Priority | Line |
---|---|---|---|
ForLoopCanBeForeach | This for loop can be replaced by a foreach loop | 3 | 217–220 |
Rule | Violation | Priority | Line |
---|---|---|---|
FormalParameterNamingConventions | The method parameter name '_strPath' doesn't match '[a-z][a-zA-Z0-9]*' | 1 | 166 |
FormalParameterNamingConventions | The method parameter name '_strType' doesn't match '[a-z][a-zA-Z0-9]*' | 1 | 187 |
FormalParameterNamingConventions | The method parameter name '_listProperties' doesn't match '[a-z][a-zA-Z0-9]*' | 1 | 208 |
Rule | Violation | Priority | Line |
---|---|---|---|
ForLoopCanBeForeach | This for loop can be replaced by a foreach loop | 3 | 199–202 |
Rule | Violation | Priority | Line |
---|---|---|---|
UnusedImports | Avoid unused imports such as 'fr.paris.lutece.plugins.vault.rs.VaultAPI' | 4 | 38 |
UnusedImports | Avoid unused imports such as 'fr.paris.lutece.plugins.vault.service.VaultUtil' | 4 | 41 |
UnusedImports | Avoid unused imports such as 'fr.paris.lutece.portal.service.i18n.I18nService' | 4 | 42 |
UnusedPrivateField | Avoid unused private fields such as '_count'. | 3 | 60 |
Rule | Violation | Priority | Line |
---|---|---|---|
FormalParameterNamingConventions | The method parameter name '_plugin' doesn't match '[a-z][a-zA-Z0-9]*' | 1 | 128 |
Rule | Violation | Priority | Line |
---|---|---|---|
FormalParameterNamingConventions | The method parameter name '_plugin' doesn't match '[a-z][a-zA-Z0-9]*' | 1 | 127 |
CommentRequired | Public method and constructor comments are required | 3 | 129 |
CommentRequired | Public method and constructor comments are required | 3 | 131 |
Rule | Violation | Priority | Line |
---|---|---|---|
FormalParameterNamingConventions | The method parameter name '_plugin' doesn't match '[a-z][a-zA-Z0-9]*' | 1 | 127 |
CommentRequired | Public method and constructor comments are required | 3 | 129 |
Rule | Violation | Priority | Line |
---|---|---|---|
UnusedImports | Avoid unused imports such as 'java.util.List' | 4 | 39 |
Rule | Violation | Priority | Line |
---|---|---|---|
UnusedImports | Avoid unused imports such as 'fr.paris.lutece.portal.service.spring.SpringContextService' | 4 | 41 |
UnusedImports | Avoid unused imports such as 'fr.paris.lutece.util.ReferenceList' | 4 | 42 |
UnusedImports | Avoid unused imports such as 'java.util.List' | 4 | 44 |
UnusedImports | Avoid unused imports such as 'java.util.Optional' | 4 | 45 |
UnusedImports | Avoid unused imports such as 'org.springframework.context.i18n.LocaleContextHolder.getLocale' | 4 | 47 |
UnusedPrivateField | Avoid unused private fields such as '_plugin'. | 3 | 55 |
Rule | Violation | Priority | Line |
---|---|---|---|
CommentRequired | Header comments are required | 3 | 52–170 |
ClassNamingConventions | The utility class name 'VaultAPI' doesn't match '[A-Z][a-zA-Z0-9]+(Utils?|Helper|Home|Service)' | 1 | 52–170 |
UseUtilityClass | All methods are static. Consider using a utility class instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning. | 3 | 53–170 |
CommentRequired | Public method and constructor comments are required | 3 | 55–93 |
AvoidDuplicateLiterals | The String literal "application/json" appears 4 times in this file; the first occurrence is on line 71 | 3 | 71 |
AvoidCatchingGenericException | Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 3 | 89 |
CommentRequired | Public method and constructor comments are required | 3 | 95–125 |
AvoidCatchingGenericException | Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 3 | 121 |
CommentRequired | Public method and constructor comments are required | 3 | 127–169 |
AvoidCatchingGenericException | Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 3 | 164 |
Rule | Violation | Priority | Line |
---|---|---|---|
UnusedImports | Avoid unused imports such as 'fr.paris.lutece.portal.util.mvc.utils.MVCMessage' | 4 | 38 |
UnusedImports | Avoid unused imports such as 'fr.paris.lutece.util.ErrorMessage' | 4 | 39 |
UnusedImports | Avoid unused imports such as 'java.util.ArrayList' | 4 | 42 |
UnusedImports | Avoid unused imports such as 'java.util.List' | 4 | 43 |
UseUtilityClass | All methods are static. Consider using a utility class instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning. | 3 | 50–81 |
LocalVariableNamingConventions | The local variable name '_listNamesEnvironnements' doesn't match '[a-z][a-zA-Z0-9]*' | 1 | 65 |
ForLoopCanBeForeach | This for loop can be replaced by a foreach loop | 3 | 67–70 |
CommentRequired | Public method and constructor comments are required | 3 | 76–79 |
Rule | Violation | Priority | Line |
---|---|---|---|
ImmutableField | Private field '_listEnvAccessor' could be made final; it is only initialized in the declaration or constructor. | 3 | 56 |
SingularField | Perhaps '_listEnvSecrets' could be replaced by a local variable. | 3 | 57 |
RedundantFieldInitializer | Avoid using redundant field initializer for '_instance' | 3 | 59 |
NonThreadSafeSingleton | Singleton is not thread safe | 3 | 83–88 |
UseLocaleWithCaseConversions | When doing a String.toLowerCase()/toUpperCase() call, use a Locale | 3 | 118 |
UseLocaleWithCaseConversions | When doing a String.toLowerCase()/toUpperCase() call, use a Locale | 3 | 118 |
UseLocaleWithCaseConversions | When doing a String.toLowerCase()/toUpperCase() call, use a Locale | 3 | 151 |
UseLocaleWithCaseConversions | When doing a String.toLowerCase()/toUpperCase() call, use a Locale | 3 | 151 |
CommentRequired | Public method and constructor comments are required | 3 | 167–193 |
UseLocaleWithCaseConversions | When doing a String.toLowerCase()/toUpperCase() call, use a Locale | 3 | 268 |
UseLocaleWithCaseConversions | When doing a String.toLowerCase()/toUpperCase() call, use a Locale | 3 | 268 |
UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 3 | 298 |
UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 3 | 298 |
UnnecessaryLocalBeforeReturn | Consider simply returning the value vs storing it in local variable 'listAllSecrets' | 3 | 367 |
ForLoopCanBeForeach | This for loop can be replaced by a foreach loop | 3 | 397–406 |
UnusedLocalVariable | Avoid unused local variables such as 'appId'. | 3 | 399 |
LocalVariableNamingConventions | The local variable name '_properties' doesn't match '[a-z][a-zA-Z0-9]*' | 1 | 401 |
UnnecessaryLocalBeforeReturn | Consider simply returning the value vs storing it in local variable 'secretKV' | 3 | 436 |
AvoidPrintStackTrace | Avoid printStackTrace(); use a logger call instead. | 3 | 443 |
AvoidPrintStackTrace | Avoid printStackTrace(); use a logger call instead. | 3 | 480 |
Rule | Violation | Priority | Line |
---|---|---|---|
MissingSerialVersionUID | Classes implementing Serializable should set a serialVersionUID | 3 | 45–78 |
UseUtilityClass | All methods are static. Consider using a utility class instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning. | 3 | 46–78 |
RedundantFieldInitializer | Avoid using redundant field initializer for '_vault' | 3 | 47 |
Rule | Violation | Priority | Line |
---|---|---|---|
MissingSerialVersionUID | Classes implementing Serializable should set a serialVersionUID | 3 | 50–117 |
CommentDefaultAccessModifier | To avoid mistakes add a comment at the beginning of the getItemsFromIds method if you want a default access modifier | 3 | 116 |
DefaultPackage | Use explicit scoping instead of the default package private level | 3 | 116 |
Rule | Violation | Priority | Line |
---|---|---|---|
MissingSerialVersionUID | Classes implementing Serializable should set a serialVersionUID | 3 | 62–299 |
NullAssignment | Assigning an Object to null is a code smell. Consider refactoring. | 3 | 125 |
DefaultPackage | Use explicit scoping instead of the default package private level | 3 | 137–144 |
CommentDefaultAccessModifier | To avoid mistakes add a comment at the beginning of the getItemsFromIds method if you want a default access modifier | 3 | 138–144 |
ConfusingTernary | Avoid if (x != y) ..; else ..; | 3 | 164 |
Rule | Violation | Priority | Line |
---|---|---|---|
UnusedImports | Avoid unused imports such as 'fr.paris.lutece.plugins.vault.service.VaultUtil' | 4 | 42 |
MissingSerialVersionUID | Classes implementing Serializable should set a serialVersionUID | 3 | 66–409 |
ConfusingTernary | Avoid if (x != y) ..; else ..; | 3 | 140 |
DefaultPackage | Use explicit scoping instead of the default package private level | 3 | 163–170 |
CommentDefaultAccessModifier | To avoid mistakes add a comment at the beginning of the getItemsFromIds method if you want a default access modifier | 3 | 164–170 |
ConfusingTernary | Avoid if (x != y) ..; else ..; | 3 | 192 |
PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 373 |
PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 374 |
PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 377 |
UnusedLocalVariable | Avoid unused local variables such as 'nIdApp'. | 3 | 377 |
Rule | Violation | Priority | Line |
---|---|---|---|
UnusedImports | Avoid unused imports such as 'fr.paris.lutece.plugins.vault.service.VaultService' | 4 | 39 |
UnusedImports | Avoid unused imports such as 'fr.paris.lutece.plugins.vault.service.VaultUtil' | 4 | 40 |
UnusedImports | Avoid unused imports such as 'fr.paris.lutece.util.html.AbstractPaginator' | 4 | 50 |
UnusedImports | Avoid unused imports such as 'java.util.Comparator' | 4 | 52 |
UnusedImports | Avoid unused imports such as 'java.util.stream.Collectors' | 4 | 57 |
MissingSerialVersionUID | Classes implementing Serializable should set a serialVersionUID | 3 | 64–324 |
SingularField | Perhaps '_listIdProperties' could be replaced by a local variable. | 3 | 112 |
UnusedPrivateField | Avoid unused private fields such as '_listIdProperties'. | 3 | 112 |
SingularField | Perhaps '_listProperties' could be replaced by a local variable. | 3 | 113 |
NullAssignment | Assigning an Object to null is a code smell. Consider refactoring. | 3 | 125 |
LocalVariableNamingConventions | The local variable name '_environnement' doesn't match '[a-z][a-zA-Z0-9]*' | 1 | 129 |
ConfusingTernary | Avoid if (x != y) ..; else ..; | 3 | 165 |
UnusedLocalVariable | Avoid unused local variables such as 'nIdApp'. | 3 | 192 |
PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 192 |
SystemPrintln | System.out.println is used | 2 | 278 |
EmptyIfStmt | Avoid empty if statements | 3 | 310–311 |
DefaultPackage | Use explicit scoping instead of the default package private level | 3 | 319–323 |
CommentDefaultAccessModifier | To avoid mistakes add a comment at the beginning of the getItemsFromIds method if you want a default access modifier | 3 | 320–323 |