Fork me on GitHub

PMD Results

The following document contains the results of PMD 6.13.0.

Violations By Priority

Priority 1

fr/paris/lutece/plugins/verifybackurl/business/AuthorizedUrl.java

Rule Violation Line
FormalParameterNamingConventions The method parameter name '_strApplicationCode' doesn't match '[a-z][a-zA-Z0-9]*' 123

fr/paris/lutece/plugins/verifybackurl/service/AuthorizedUrlService.java

Rule Violation Line
ClassWithOnlyPrivateConstructorsShouldBeFinal A class which only has private constructors should be final 55251

fr/paris/lutece/plugins/verifybackurl/utils/VerifyBackUrlConstants.java

Rule Violation Line
ClassNamingConventions The utility class name 'VerifyBackUrlConstants' doesn't match '[A-Z][a-zA-Z0-9]+(Utils?|Helper|Home|Service)' 3664

Priority 3

fr/paris/lutece/plugins/verifybackurl/business/AuthorizedUrlDAO.java

Rule Violation Line
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 163
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 192
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 221

fr/paris/lutece/plugins/verifybackurl/service/AuthorizedUrlDatabaseProvider.java

Rule Violation Line
CommentRequired Header comments are required 4160

fr/paris/lutece/plugins/verifybackurl/service/AuthorizedUrlService.java

Rule Violation Line
NonThreadSafeSingleton Singleton is not thread safe 6670
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 86
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 113

fr/paris/lutece/plugins/verifybackurl/service/DomainNameConstraint.java

Rule Violation Line
CommentRequired Header comments are required 3850

fr/paris/lutece/plugins/verifybackurl/service/IAuthorizedUrlProvider.java

Rule Violation Line
CommentRequired Header comments are required 3959
UnnecessaryModifier Unnecessary modifier 'public' on method 'getAuthorizedUrlsList': the method is declared in an interface type 47
UnnecessaryModifier Unnecessary modifier 'public' on method 'getAuthorizedUrlsByApplicationCode': the method is declared in an interface type 53

fr/paris/lutece/plugins/verifybackurl/service/IBackUrlConstraint.java

Rule Violation Line
CommentRequired Header comments are required 3644

fr/paris/lutece/plugins/verifybackurl/service/NoHTMLConstraint.java

Rule Violation Line
CommentRequired Header comments are required 3849

fr/paris/lutece/plugins/verifybackurl/service/ProcessConstraintsService.java

Rule Violation Line
CommentRequired Header comments are required 3959
UseUtilityClass All methods are static. Consider using a utility class instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning. 4059

fr/paris/lutece/plugins/verifybackurl/utils/VerifiyBackUrlUtils.java

Rule Violation Line
CommentRequired Header comments are required 50203
UseUtilityClass All methods are static. Consider using a utility class instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning. 51203
ForLoopCanBeForeach This for loop can be replaced by a foreach loop 7482
SimplifyBooleanReturns Avoid unnecessary if..then..else statements when returning booleans 129132
ConfusingTernary Avoid if (x != y) ..; else ..; 197

fr/paris/lutece/plugins/verifybackurl/utils/VerifyBackUrlConstants.java

Rule Violation Line
CommentRequired Header comments are required 3664

fr/paris/lutece/plugins/verifybackurl/web/AuthorizedUrlJspBean.java

Rule Violation Line
MissingSerialVersionUID Classes implementing Serializable should set a serialVersionUID 53233
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 107
ConfusingTernary Avoid if (x != y) ..; else ..; 123

fr/paris/lutece/plugins/verifybackurl/web/ManageVerifybackurlJspBean.java

Rule Violation Line
MissingSerialVersionUID Classes implementing Serializable should set a serialVersionUID 4998
SingularField Perhaps '_nDefaultItemsPerPage' could be replaced by a local variable. 65
AddEmptyString Do not add empty strings 92

Files

fr/paris/lutece/plugins/verifybackurl/business/AuthorizedUrl.java

Rule Violation Priority Line
FormalParameterNamingConventions The method parameter name '_strApplicationCode' doesn't match '[a-z][a-zA-Z0-9]*' 1 123

fr/paris/lutece/plugins/verifybackurl/business/AuthorizedUrlDAO.java

Rule Violation Priority Line
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 3 163
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 3 192
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 3 221

fr/paris/lutece/plugins/verifybackurl/service/AuthorizedUrlDatabaseProvider.java

Rule Violation Priority Line
CommentRequired Header comments are required 3 4160

fr/paris/lutece/plugins/verifybackurl/service/AuthorizedUrlService.java

Rule Violation Priority Line
ClassWithOnlyPrivateConstructorsShouldBeFinal A class which only has private constructors should be final 1 55251
NonThreadSafeSingleton Singleton is not thread safe 3 6670
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 3 86
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 3 113

fr/paris/lutece/plugins/verifybackurl/service/DomainNameConstraint.java

Rule Violation Priority Line
CommentRequired Header comments are required 3 3850

fr/paris/lutece/plugins/verifybackurl/service/IAuthorizedUrlProvider.java

Rule Violation Priority Line
CommentRequired Header comments are required 3 3959
UnnecessaryModifier Unnecessary modifier 'public' on method 'getAuthorizedUrlsList': the method is declared in an interface type 3 47
UnnecessaryModifier Unnecessary modifier 'public' on method 'getAuthorizedUrlsByApplicationCode': the method is declared in an interface type 3 53

fr/paris/lutece/plugins/verifybackurl/service/IBackUrlConstraint.java

Rule Violation Priority Line
CommentRequired Header comments are required 3 3644

fr/paris/lutece/plugins/verifybackurl/service/NoHTMLConstraint.java

Rule Violation Priority Line
CommentRequired Header comments are required 3 3849

fr/paris/lutece/plugins/verifybackurl/service/ProcessConstraintsService.java

Rule Violation Priority Line
CommentRequired Header comments are required 3 3959
UseUtilityClass All methods are static. Consider using a utility class instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning. 3 4059

fr/paris/lutece/plugins/verifybackurl/utils/VerifiyBackUrlUtils.java

Rule Violation Priority Line
CommentRequired Header comments are required 3 50203
UseUtilityClass All methods are static. Consider using a utility class instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning. 3 51203
ForLoopCanBeForeach This for loop can be replaced by a foreach loop 3 7482
SimplifyBooleanReturns Avoid unnecessary if..then..else statements when returning booleans 3 129132
ConfusingTernary Avoid if (x != y) ..; else ..; 3 197

fr/paris/lutece/plugins/verifybackurl/utils/VerifyBackUrlConstants.java

Rule Violation Priority Line
CommentRequired Header comments are required 3 3664
ClassNamingConventions The utility class name 'VerifyBackUrlConstants' doesn't match '[A-Z][a-zA-Z0-9]+(Utils?|Helper|Home|Service)' 1 3664

fr/paris/lutece/plugins/verifybackurl/web/AuthorizedUrlJspBean.java

Rule Violation Priority Line
MissingSerialVersionUID Classes implementing Serializable should set a serialVersionUID 3 53233
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 3 107
ConfusingTernary Avoid if (x != y) ..; else ..; 3 123

fr/paris/lutece/plugins/verifybackurl/web/ManageVerifybackurlJspBean.java

Rule Violation Priority Line
MissingSerialVersionUID Classes implementing Serializable should set a serialVersionUID 3 4998
SingularField Perhaps '_nDefaultItemsPerPage' could be replaced by a local variable. 3 65
AddEmptyString Do not add empty strings 3 92