The following document contains the results of PMD 5.3.5.
| Violation | Line |
|---|---|
| Avoid short class names like Site | 43–212 |
| Violation | Line |
|---|---|
| Return an empty array rather than null. | 56–65 |
| Consider using varargs for methods or constructors which take an array the last parameter. | 70 |
| Return an empty array rather than null. | 114–123 |
| Violation | Line |
|---|---|
| Document empty method | 50–51 |
| Violation | Line |
|---|---|
| The class 'HtmlDocumentWebappcontainer' has a Cyclomatic Complexity of 4 (Highest = 11). | 69–580 |
| The String literal "href" appears 4 times in this file; the first occurrence is on line 184 | 184 |
| Private field '_content' could be made final; it is only initialized in the declaration or constructor. | 197 |
| Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. | 197 |
| Avoid variables with short names like pw | 215 |
| The method 'convertUrls' has a Cyclomatic Complexity of 11. | 240–315 |
| The method convertUrls() has an NPath complexity of 290 | 240–315 |
| Use equals() to compare object references. | 243 |
| Use equals() to compare object references. | 284 |
| Avoid variables with short names like tf | 435 |
| Avoid variables with short names like tf | 488 |
| Private field '_strTagName' could be made final; it is only initialized in the declaration or constructor. | 520 |
| Private field '_strAttributeName' could be made final; it is only initialized in the declaration or constructor. | 521 |
| Private field '_strTestedAttributeName' could be made final; it is only initialized in the declaration or constructor. | 522 |
| Private field '_strTestedAttributeValue' could be made final; it is only initialized in the declaration or constructor. | 523 |
| Violation | Line |
|---|---|
| Avoid variables with short names like e | 48 |
| Violation | Line |
|---|---|
| A high number of imports can indicate a high degree of coupling within an object. | 34–515 |
| The class 'HttpAccess' has a Standard Cyclomatic Complexity of 4 (Highest = 10). | 73–515 |
| The class 'HttpAccess' has a Modified Cyclomatic Complexity of 4 (Highest = 10). | 73–515 |
| The class 'HttpAccess' has a Cyclomatic Complexity of 5 (Highest = 13). | 73–515 |
| debug logging that involves string concatenation should be guarded with isDebugEnabled() checks | 153 |
| Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 161 |
| debug logging that involves string concatenation should be guarded with isDebugEnabled() checks | 187 |
| Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 214 |
| Avoid variables with short names like i | 235 |
| The method 'doRequest' has a Standard Cyclomatic Complexity of 10. | 267–372 |
| Avoid really long methods. | 267–372 |
| The method 'doRequest' has a Modified Cyclomatic Complexity of 10. | 267–372 |
| The method 'doRequest' has a Cyclomatic Complexity of 11. | 267–372 |
| debug logging that involves string concatenation should be guarded with isDebugEnabled() checks | 300 |
| The method getHttpClient() has an NPath complexity of 240 | 381–446 |
| The method 'getHttpClient' has a Cyclomatic Complexity of 13. | 381–446 |
| Avoid declaring a variable if it is unreferenced before a possible exit point. | 383 |
| Avoid declaring a variable if it is unreferenced before a possible exit point. | 384 |
| Avoid declaring a variable if it is unreferenced before a possible exit point. | 385 |
| Avoid declaring a variable if it is unreferenced before a possible exit point. | 386 |
| Avoid declaring a variable if it is unreferenced before a possible exit point. | 387 |
| Avoid declaring a variable if it is unreferenced before a possible exit point. | 388 |
| Avoid declaring a variable if it is unreferenced before a possible exit point. | 389 |
| Avoid declaring a variable if it is unreferenced before a possible exit point. | 390 |
| Avoid declaring a variable if it is unreferenced before a possible exit point. | 391 |
| Avoid declaring a variable if it is unreferenced before a possible exit point. | 392 |
| debug logging that involves string concatenation should be guarded with isDebugEnabled() checks | 458 |
| debug logging that involves string concatenation should be guarded with isDebugEnabled() checks | 474 |
| debug logging that involves string concatenation should be guarded with isDebugEnabled() checks | 477 |
| debug logging that involves string concatenation should be guarded with isDebugEnabled() checks | 482 |
| Violation | Line |
|---|---|
| Avoid variables with short names like e | 48 |
| Violation | Line |
|---|---|
| Avoid importing anything from the sun.* packages | 40 |
| Avoid importing anything from the sun.* packages | 41 |
| debug logging that involves string concatenation should be guarded with isDebugEnabled() checks | 92 |
| debug logging that involves string concatenation should be guarded with isDebugEnabled() checks | 109 |
| Violation | Line |
|---|---|
| The Logger variable declaration does not contain the static and final modifiers | 103 |
| Avoid unused method parameters such as 'nMode'. | 178 |
| If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 186 |
| Avoid unused method parameters such as 'plugin'. | 206 |
| Avoid unused method parameters such as 'nMode'. | 206 |
| Avoid unused method parameters such as 'strCode'. | 206 |
| If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 210 |
| Violation | Line |
|---|---|
| The class 'WebappcontainerJspBean' has a Modified Cyclomatic Complexity of 4 (Highest = 11). | 64–438 |
| The class 'WebappcontainerJspBean' has a Standard Cyclomatic Complexity of 4 (Highest = 11). | 64–438 |
| The class 'WebappcontainerJspBean' has a Cyclomatic Complexity of 7 (Highest = 24). | 64–438 |
| If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 158 |
| If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 176 |
| The method doCreateSite() has an NPath complexity of 1944 | 196–271 |
| The method 'doCreateSite' has a Cyclomatic Complexity of 18. | 196–271 |
| Avoid declaring a variable if it is unreferenced before a possible exit point. | 201 |
| Avoid declaring a variable if it is unreferenced before a possible exit point. | 202 |
| Avoid declaring a variable if it is unreferenced before a possible exit point. | 204 |
| Avoid declaring a variable if it is unreferenced before a possible exit point. | 205 |
| Avoid declaring a variable if it is unreferenced before a possible exit point. | 206 |
| If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 286 |
| The method doModifySite() has an NPath complexity of 28512 | 307–403 |
| The method 'doModifySite' has a Standard Cyclomatic Complexity of 11. | 307–403 |
| The method 'doModifySite' has a Modified Cyclomatic Complexity of 11. | 307–403 |
| The method 'doModifySite' has a Cyclomatic Complexity of 24. | 307–403 |
| Avoid declaring a variable if it is unreferenced before a possible exit point. | 313 |
| Avoid declaring a variable if it is unreferenced before a possible exit point. | 314 |
| Avoid declaring a variable if it is unreferenced before a possible exit point. | 316 |
| Avoid declaring a variable if it is unreferenced before a possible exit point. | 317 |
| Avoid declaring a variable if it is unreferenced before a possible exit point. | 318 |
| Violation | Line |
|---|---|
| Avoid declaring a variable if it is unreferenced before a possible exit point. | 124 |
| Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 174 |
| If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 195 |
