PMD Results
The following document contains the results of PMD 5.3.5.
Files
fr/paris/lutece/plugins/whatsnew/business/WhatsNew.java
| Violation |
Line |
| Abstract classes should be named AbstractXXX |
53–274 |
| Avoid unnecessary constructors - the compiler will generate these for you |
76–78 |
| Document empty constructor |
76–78 |
fr/paris/lutece/plugins/whatsnew/business/WhatsNewDAO.java
| Violation |
Line |
| This statement may have some unnecessary parentheses |
89 |
| This statement may have some unnecessary parentheses |
121 |
| This statement may have some unnecessary parentheses |
158 |
| Substitute calls to size() == 0 (or size() != 0, size() > 0, size() < 1) with calls to isEmpty() |
195 |
| Substitute calls to size() == 0 (or size() != 0, size() > 0, size() < 1) with calls to isEmpty() |
245 |
| Substitute calls to size() == 0 (or size() != 0, size() > 0, size() < 1) with calls to isEmpty() |
302 |
| StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. |
355 |
| StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. |
356 |
| This statement may have some unnecessary parentheses |
361 |
| StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. |
384 |
| StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. |
385 |
| This statement may have some unnecessary parentheses |
390 |
| StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. |
414 |
| StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. |
415 |
| This statement may have some unnecessary parentheses |
420 |
fr/paris/lutece/plugins/whatsnew/business/WhatsNewTypeDocument.java
| Violation |
Line |
| Document empty constructor |
55–57 |
| Avoid unnecessary constructors - the compiler will generate these for you |
55–57 |
| It is a good practice to call super() in a constructor |
55–57 |
| StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. |
103 |
| StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. |
104 |
| StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. |
105 |
| StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. |
106 |
| StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. |
107 |
| StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. |
108 |
| StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. |
109 |
fr/paris/lutece/plugins/whatsnew/business/WhatsNewTypePage.java
| Violation |
Line |
| Avoid unnecessary constructors - the compiler will generate these for you |
54–56 |
| It is a good practice to call super() in a constructor |
54–56 |
| Document empty constructor |
54–56 |
| StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. |
84 |
| StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. |
85 |
| StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. |
86 |
fr/paris/lutece/plugins/whatsnew/business/WhatsNewTypePortlet.java
| Violation |
Line |
| It is a good practice to call super() in a constructor |
55–57 |
| Document empty constructor |
55–57 |
| Avoid unnecessary constructors - the compiler will generate these for you |
55–57 |
| StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. |
103 |
| StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. |
104 |
| StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. |
105 |
| StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. |
106 |
| StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. |
107 |
| StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. |
108 |
| StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. |
109 |
fr/paris/lutece/plugins/whatsnew/business/portlet/WhatsNewPortlet.java
| Violation |
Line |
| The class 'WhatsNewPortlet' has a Standard Cyclomatic Complexity of 2 (Highest = 11). |
62–359 |
| The class 'WhatsNewPortlet' has a Modified Cyclomatic Complexity of 2 (Highest = 11). |
62–359 |
| The class 'WhatsNewPortlet' has a Cyclomatic Complexity of 2 (Highest = 12). |
62–359 |
| It is a good practice to call super() in a constructor |
76–79 |
| A getX() method which returns a boolean should be named isX() |
85–88 |
| A getX() method which returns a boolean should be named isX() |
103–106 |
| A getX() method which returns a boolean should be named isX() |
121–124 |
| A getX() method which returns a boolean should be named isX() |
193–196 |
| A getX() method which returns a boolean should be named isX() |
221–224 |
| The method 'getXml' has a Modified Cyclomatic Complexity of 11. |
240–342 |
| The method getXml() has an NPath complexity of 576 |
240–342 |
| The method 'getXml' has a Cyclomatic Complexity of 12. |
240–342 |
| Avoid really long methods. |
240–342 |
| The method 'getXml' has a Standard Cyclomatic Complexity of 11. |
240–342 |
fr/paris/lutece/plugins/whatsnew/business/portlet/WhatsNewPortletDAO.java
| Violation |
Line |
| Avoid excessively long variable names like SQL_QUERY_DELETE_PAGE_WHATSNEW_FROM_ID_WHATSNEW_PORTLET |
62 |
| Avoid excessively long variable names like SQL_QUERY_DELETE_PORTLET_WHATSNEW_FROM_ID_WHATSNEW_PORTLET |
69 |
| Avoid excessively long variable names like SQL_QUERY_DELETE_DOCUMENT_WHATSNEW_FROM_ID_WHATSNEW_PORTLET |
76 |
| Avoid excessively long variable names like SQL_QUERY_DELETE_DOCUMENT_WHATSNEW_FROM_ID_DOCUMENT_ID_PORTLET |
77 |
| Avoid variables with short names like p |
88 |
| Avoid variables with short names like p |
155 |
fr/paris/lutece/plugins/whatsnew/business/portlet/WhatsNewPortletHome.java
| Violation |
Line |
| It is a good practice to call super() in a constructor |
63–65 |
| Avoid unnecessary constructors - the compiler will generate these for you |
63–65 |
| Document empty constructor |
63–65 |
| Singleton is not thread safe |
73–76 |
fr/paris/lutece/plugins/whatsnew/service/WhatsNewResourceIdService.java
| Violation |
Line |
| It is a good practice to call super() in a constructor |
61–64 |
| Avoid variables with short names like rt |
71 |
| Avoid variables with short names like p |
77 |
fr/paris/lutece/plugins/whatsnew/service/WhatsNewService.java
| Violation |
Line |
| Singleton is not thread safe |
84–87 |
| Document empty method |
96–97 |
| If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation |
371 |
fr/paris/lutece/plugins/whatsnew/service/parameter/WhatsNewParameterService.java
| Violation |
Line |
| Singleton is not thread safe |
57–60 |
| Document empty method |
69–70 |
fr/paris/lutece/plugins/whatsnew/service/portlet/WhatsNewPortletService.java
| Violation |
Line |
| Singleton is not thread safe |
63–66 |
| Document empty method |
75–76 |
fr/paris/lutece/plugins/whatsnew/utils/constants/WhatsNewConstants.java
| Violation |
Line |
| Avoid excessively long variable names like PROPERTY_DAEMON_MODERATED_ELEMENTS_CLEANER_LANGUAGE |
93 |
fr/paris/lutece/plugins/whatsnew/utils/sort/WhatsNewComparator.java
| Violation |
Line |
| The class 'WhatsNewComparator' has a Modified Cyclomatic Complexity of 6 (Highest = 11). |
49–122 |
| The class 'WhatsNewComparator' has a Cyclomatic Complexity of 10 (Highest = 19). |
49–122 |
| The class 'WhatsNewComparator' has a Standard Cyclomatic Complexity of 6 (Highest = 11). |
49–122 |
| Private field '_nOrder' could be made final; it is only initialized in the declaration or constructor. |
52 |
| Private field '_bIsAscSort' could be made final; it is only initialized in the declaration or constructor. |
53 |
| The method 'compare' has a Standard Cyclomatic Complexity of 11. |
77–121 |
| Avoid variables with short names like w1 |
77 |
| The method 'compare' has a Modified Cyclomatic Complexity of 11. |
77–121 |
| Avoid variables with short names like w2 |
77 |
| The method 'compare' has a Cyclomatic Complexity of 19. |
77–121 |
fr/paris/lutece/plugins/whatsnew/web/WhatsNewAdminDashboardComponent.java
| Violation |
Line |
| If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation |
82 |
fr/paris/lutece/plugins/whatsnew/web/portlet/WhatsNewPortletJspBean.java
| Violation |
Line |
| The class 'WhatsNewPortletJspBean' has a Cyclomatic Complexity of 4 (Highest = 11). |
68–420 |
| If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation |
92 |
| If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation |
120 |
| The method 'getPortletData' has a Cyclomatic Complexity of 11. |
251–324 |
