Fork me on GitHub

SpotBugs Bug Detector Report

The following document contains the results of SpotBugs

SpotBugs Version is 4.5.3

Threshold is medium

Effort is default

Summary

Classes Bugs Errors Missing Classes
43 20 0 0

Files

Class Bugs
fr.paris.lutece.plugins.wiki.business.Image 2
fr.paris.lutece.plugins.wiki.business.TopicVersion 3
fr.paris.lutece.plugins.wiki.business.TopicVersionDAO 1
fr.paris.lutece.plugins.wiki.search.WikiSearchEngine 1
fr.paris.lutece.plugins.wiki.service.DiffService 1
fr.paris.lutece.plugins.wiki.service.WikiDiff 2
fr.paris.lutece.plugins.wiki.service.WikiLocaleService 1
fr.paris.lutece.plugins.wiki.service.WikiService 1
fr.paris.lutece.plugins.wiki.service.parser.LuteceWikiParser 2
fr.paris.lutece.plugins.wiki.web.WikiApp 3
ys.wikiparser.MarkdownCustomInputs 1
ys.wikiparser.WikiParser 2

fr.paris.lutece.plugins.wiki.business.Image

Bug Category Details Line Priority
fr.paris.lutece.plugins.wiki.business.Image.getValue() may expose internal representation by returning Image._byValue MALICIOUS_CODE EI_EXPOSE_REP 99 Medium
fr.paris.lutece.plugins.wiki.business.Image.setValue(byte[]) may expose internal representation by storing an externally mutable object into Image._byValue MALICIOUS_CODE EI_EXPOSE_REP2 110 Medium

fr.paris.lutece.plugins.wiki.business.TopicVersion

Bug Category Details Line Priority
fr.paris.lutece.plugins.wiki.business.TopicVersion.getDateEdition() may expose internal representation by returning TopicVersion._strDateEdition MALICIOUS_CODE EI_EXPOSE_REP 184 Medium
fr.paris.lutece.plugins.wiki.business.TopicVersion.getWikiContents() may expose internal representation by returning TopicVersion._mapWikiContent MALICIOUS_CODE EI_EXPOSE_REP 119 Medium
fr.paris.lutece.plugins.wiki.business.TopicVersion.setDateEdition(Timestamp) may expose internal representation by storing an externally mutable object into TopicVersion._strDateEdition MALICIOUS_CODE EI_EXPOSE_REP2 195 Medium

fr.paris.lutece.plugins.wiki.business.TopicVersionDAO

Bug Category Details Line Priority
Dead store to topicVersion in fr.paris.lutece.plugins.wiki.business.TopicVersionDAO.selectTopicVersionsList(Plugin) STYLE DLS_DEAD_LOCAL_STORE 251 Medium

fr.paris.lutece.plugins.wiki.search.WikiSearchEngine

Bug Category Details Line Priority
Exception is caught when Exception is not thrown in fr.paris.lutece.plugins.wiki.search.WikiSearchEngine.getSearchResults(String, HttpServletRequest) STYLE REC_CATCH_EXCEPTION 122 Medium

fr.paris.lutece.plugins.wiki.service.DiffService

Bug Category Details Line Priority
Found reliance on default encoding in fr.paris.lutece.plugins.wiki.service.DiffService.getDiff(String, String): java.io.ByteArrayOutputStream.toString() I18N DM_DEFAULT_ENCODING 135 High

fr.paris.lutece.plugins.wiki.service.WikiDiff

Bug Category Details Line Priority
fr.paris.lutece.plugins.wiki.service.WikiDiff.getSubDiffs() may expose internal representation by returning WikiDiff._listSubDiffs MALICIOUS_CODE EI_EXPOSE_REP 156 Medium
fr.paris.lutece.plugins.wiki.service.WikiDiff.setSubDiffs(List) may expose internal representation by storing an externally mutable object into WikiDiff._listSubDiffs MALICIOUS_CODE EI_EXPOSE_REP2 167 Medium

fr.paris.lutece.plugins.wiki.service.WikiLocaleService

Bug Category Details Line Priority
Public static fr.paris.lutece.plugins.wiki.service.WikiLocaleService.getLanguages() may expose internal representation by returning WikiLocaleService._listLanguages MALICIOUS_CODE MS_EXPOSE_REP 68 Medium

fr.paris.lutece.plugins.wiki.service.WikiService

Bug Category Details Line Priority
Public static fr.paris.lutece.plugins.wiki.service.WikiService.instance() may expose internal representation by returning WikiService._singleton MALICIOUS_CODE MS_EXPOSE_REP 80 Medium

fr.paris.lutece.plugins.wiki.service.parser.LuteceWikiParser

Bug Category Details Line Priority
Switch statement found in fr.paris.lutece.plugins.wiki.service.parser.LuteceWikiParser.appendImage(String) where one case falls through to the next case STYLE SF_SWITCH_FALLTHROUGH 205-207 Medium
Switch statement found in fr.paris.lutece.plugins.wiki.service.parser.LuteceWikiParser.appendImage(String) where default case is missing STYLE SF_SWITCH_NO_DEFAULT 202-213 Medium

fr.paris.lutece.plugins.wiki.web.WikiApp

Bug Category Details Line Priority
fr.paris.lutece.plugins.wiki.web.WikiApp.getSearch(HttpServletRequest) might ignore java.io.UnsupportedEncodingException BAD_PRACTICE DE_MIGHT_IGNORE 382 Medium
Possible null pointer dereference of version in fr.paris.lutece.plugins.wiki.web.WikiApp.getTopic(HttpServletRequest) CORRECTNESS NP_NULL_ON_SOME_PATH 428 High
Possible null pointer dereference of null in fr.paris.lutece.plugins.wiki.web.WikiApp.getListImages(HttpServletRequest) CORRECTNESS NP_NULL_ON_SOME_PATH 1144 Medium

ys.wikiparser.MarkdownCustomInputs

Bug Category Details Line Priority
ys.wikiparser.MarkdownCustomInputs.fillTemplate(String, Map) makes inefficient use of keySet iterator instead of entrySet iterator PERFORMANCE WMI_WRONG_MAP_ITERATOR 65 Medium

ys.wikiparser.WikiParser

Bug Category Details Line Priority
ys.wikiparser.WikiParser.CUSTOM_INPUTS_TO_REEMPLACE isn't final but should be MALICIOUS_CODE MS_SHOULD_BE_FINAL 69 High
Field only ever set to null: ys.wikiparser.WikiParser.HEADING_ID_PREFIX CORRECTNESS UWF_NULL_FIELD 84 Medium