The following document contains the results of PMD 6.13.0.
| Rule | Violation | Line |
|---|---|---|
| ClassWithOnlyPrivateConstructorsShouldBeFinal | A class which only has private constructors should be final | 77–366 |
| LocalVariableNamingConventions | The local variable name 'StateBefore' doesn't match '[a-z][a-zA-Z0-9]*' | 268 |
| LocalVariableNamingConventions | The local variable name 'PrerequisiteTypeList' doesn't match '[a-z][a-zA-Z0-9]*' | 351 |
| Rule | Violation | Line |
|---|---|---|
| FieldNamingConventions | The final field name '_listMarkerProviders' doesn't match '[a-z][a-zA-Z0-9]*' | 53 |
| Rule | Violation | Line |
|---|---|---|
| EmptyMethodInAbstractClassShouldBeAbstract | An empty method in an abstract class should be abstract instead | 65–68 |
| EmptyMethodInAbstractClassShouldBeAbstract | An empty method in an abstract class should be abstract instead | 74–77 |
| Rule | Violation | Line |
|---|---|---|
| EmptyMethodInAbstractClassShouldBeAbstract | An empty method in an abstract class should be abstract instead | 53–56 |
| EmptyMethodInAbstractClassShouldBeAbstract | An empty method in an abstract class should be abstract instead | 62–65 |
| Rule | Violation | Line |
|---|---|---|
| AvoidReassigningParameters | Avoid reassigning parameters such as 'nPos' | 400 |
| AvoidReassigningParameters | Avoid reassigning parameters such as 'nPos' | 400 |
| AvoidReassigningParameters | Avoid reassigning parameters such as 'nPos' | 400 |
| AvoidReassigningParameters | Avoid reassigning parameters such as 'nPos' | 400 |
| AvoidReassigningParameters | Avoid reassigning parameters such as 'nPos' | 400 |
| AvoidReassigningParameters | Avoid reassigning parameters such as 'nPos' | 400 |
| AvoidReassigningParameters | Avoid reassigning parameters such as 'nPos' | 412 |
| AvoidReassigningParameters | Avoid reassigning parameters such as 'nPos' | 412 |
| AvoidReassigningParameters | Avoid reassigning parameters such as 'nPos' | 412 |
| AvoidReassigningParameters | Avoid reassigning parameters such as 'nPos' | 412 |
| AvoidReassigningParameters | Avoid reassigning parameters such as 'nPos' | 481 |
| AvoidReassigningParameters | Avoid reassigning parameters such as 'nPos' | 481 |
| AvoidReassigningParameters | Avoid reassigning parameters such as 'nPos' | 481 |
| AvoidReassigningParameters | Avoid reassigning parameters such as 'nPos' | 481 |
| AvoidReassigningParameters | Avoid reassigning parameters such as 'nPos' | 481 |
| Rule | Violation | Line |
|---|---|---|
| AvoidReassigningParameters | Avoid reassigning parameters such as 'listActions' | 124 |
| AvoidReassigningParameters | Avoid reassigning parameters such as 'user' | 378 |
| AvoidReassigningParameters | Avoid reassigning parameters such as 'user' | 399 |
| Rule | Violation | Line |
|---|---|---|
| TooManyMethods | This class has too many methods, consider refactoring it. | 57–530 |
| AvoidSynchronizedAtMethodLevel | Use block level rather than method level synchronization | 99–122 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 113–114 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 144–145 |
| CyclomaticComplexity | The method 'selectActionsByFilter(ActionFilter)' has a cyclomatic complexity of 16. | 212–301 |
| NPathComplexity | The method 'selectActionsByFilter(ActionFilter)' has an NPath complexity of 32896 | 212–301 |
| AvoidSynchronizedAtMethodLevel | Use block level rather than method level synchronization | 307–317 |
| Rule | Violation | Line |
|---|---|---|
| CommentRequired | Header comments are required | 44–129 |
| UnusedPrivateField | Avoid unused private fields such as 'SQL_QUERY_SELECT_ALL'. | 46 |
| AvoidSynchronizedAtMethodLevel | Use block level rather than method level synchronization | 58–73 |
| Rule | Violation | Line |
|---|---|---|
| AvoidSynchronizedAtMethodLevel | Use block level rather than method level synchronization | 63–81 |
| Rule | Violation | Line |
|---|---|---|
| AvoidSynchronizedAtMethodLevel | Use block level rather than method level synchronization | 86–100 |
| Rule | Violation | Line |
|---|---|---|
| CallSuperInConstructor | It is a good practice to call super() in a constructor | 56–63 |
| Rule | Violation | Line |
|---|---|---|
| TooManyMethods | This class has too many methods, consider refactoring it. | 58–528 |
| AvoidSynchronizedAtMethodLevel | Use block level rather than method level synchronization | 86–105 |
| ShortVariable | Avoid variables with short names like sb | 459 |
| ConsecutiveAppendsShouldReuse | StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 460 |
| ConsecutiveAppendsShouldReuse | StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 461 |
| ForLoopCanBeForeach | This for loop can be replaced by a foreach loop | 506–509 |
| Rule | Violation | Line |
|---|---|---|
| TooManyMethods | This class has too many methods, consider refactoring it. | 59–829 |
| AvoidSynchronizedAtMethodLevel | Use block level rather than method level synchronization | 102–124 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 112–119 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 140–147 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 605 |
| NPathComplexity | The method 'buildFilterQuerydFooter(DAOUtil, ResourceWorkflowFilter, List, Integer)' has an NPath complexity of 648 | 654–716 |
| CyclomaticComplexity | The method 'buildFilterQuerydFooter(DAOUtil, ResourceWorkflowFilter, List, Integer)' has a cyclomatic complexity of 12. | 654–716 |
| NPathComplexity | The method 'buildFilterQuerydHeader(ResourceWorkflowFilter, List, String, String)' has an NPath complexity of 432 | 731–801 |
| CyclomaticComplexity | The method 'buildFilterQuerydHeader(ResourceWorkflowFilter, List, String, String)' has a cyclomatic complexity of 11. | 731–801 |
| ShortVariable | Avoid variables with short names like sb | 770 |
| ConsecutiveAppendsShouldReuse | StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 771 |
| ConsecutiveAppendsShouldReuse | StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 772 |
| ShortVariable | Avoid variables with short names like sb | 786 |
| ConsecutiveAppendsShouldReuse | StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 787 |
| ConsecutiveAppendsShouldReuse | StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 788 |
| AssignmentInOperand | Avoid assignments in operands | 818 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 818–825 |
| Rule | Violation | Line |
|---|---|---|
| TooManyMethods | This class has too many methods, consider refactoring it. | 54–369 |
| AvoidSynchronizedAtMethodLevel | Use block level rather than method level synchronization | 78–107 |
| Rule | Violation | Line |
|---|---|---|
| AvoidSynchronizedAtMethodLevel | Use block level rather than method level synchronization | 77–93 |
| Rule | Violation | Line |
|---|---|---|
| AvoidSynchronizedAtMethodLevel | Use block level rather than method level synchronization | 71–89 |
| Rule | Violation | Line |
|---|---|---|
| CommentRequired | Enum comments are required | 36–40 |
| Rule | Violation | Line |
|---|---|---|
| CommentRequired | Header comments are required | 41–126 |
| AvoidSynchronizedAtMethodLevel | Use block level rather than method level synchronization | 56–68 |
| Rule | Violation | Line |
|---|---|---|
| CommentRequired | Header comments are required | 38–152 |
| NullAssignment | Assigning an Object to null is a code smell. Consider refactoring. | 100 |
| NullAssignment | Assigning an Object to null is a code smell. Consider refactoring. | 128 |
| Rule | Violation | Line |
|---|---|---|
| CommentRequired | Header comments are required | 41–167 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 58–65 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 67–74 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 109–116 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 118–125 |
| AssignmentInOperand | Avoid assignments in operands | 154 |
| AssignmentInOperand | Avoid assignments in operands | 159 |
| Rule | Violation | Line |
|---|---|---|
| CommentRequired | Header comments are required | 36–76 |
| Rule | Violation | Line |
|---|---|---|
| CommentRequired | Header comments are required | 67–142 |
| ImmutableField | Private field '_workflowService' could be made final; it is only initialized in the declaration or constructor. | 69 |
| ImmutableField | Private field '_actionService' could be made final; it is only initialized in the declaration or constructor. | 70 |
| ImmutableField | Private field '_taskService' could be made final; it is only initialized in the declaration or constructor. | 71 |
| ImmutableField | Private field '_resourceWorkflowService' could be made final; it is only initialized in the declaration or constructor. | 72 |
| ImmutableField | Private field '_archiveService' could be made final; it is only initialized in the declaration or constructor. | 73 |
| ShortVariable | Avoid variables with short names like wf | 98 |
| AvoidDeeplyNestedIfStmts | Deeply nested if..then statements are hard to read | 114–118 |
| Rule | Violation | Line |
|---|---|---|
| CommentRequired | Protected method constructor comments are required | 58–61 |
| CommentRequired | Protected method constructor comments are required | 63–67 |
| Rule | Violation | Line |
|---|---|---|
| CommentRequired | Header comments are required | 38–46 |
| Rule | Violation | Line |
|---|---|---|
| CommentRequired | Header comments are required | 50–105 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 63 |
| CommentRequired | Public method and constructor comments are required | 79–85 |
| Rule | Violation | Line |
|---|---|---|
| CommentRequired | Header comments are required | 66–236 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 111 |
| Rule | Violation | Line |
|---|---|---|
| ShortVariable | Avoid variables with short names like id | 62 |
| Rule | Violation | Line |
|---|---|---|
| AvoidSynchronizedAtMethodLevel | Use block level rather than method level synchronization | 59–71 |
| Rule | Violation | Line |
|---|---|---|
| AvoidSynchronizedAtMethodLevel | Use block level rather than method level synchronization | 59–75 |
| Rule | Violation | Line |
|---|---|---|
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 133–140 |
| Rule | Violation | Line |
|---|---|---|
| ForLoopCanBeForeach | This for loop can be replaced by a foreach loop | 121–136 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 159 |
| ShortVariable | Avoid variables with short names like t | 162 |
| Rule | Violation | Line |
|---|---|---|
| NPathComplexity | The method 'doSaveConfig(HttpServletRequest, Locale, ITask)' has an NPath complexity of 1152 | 115–205 |
| CyclomaticComplexity | The method 'doSaveConfig(HttpServletRequest, Locale, ITask)' has a cyclomatic complexity of 13. | 115–205 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 119 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 121 |
| ForLoopCanBeForeach | This for loop can be replaced by a foreach loop | 172–192 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 180–188 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 213 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 214 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 279 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 295 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 329 |
| Rule | Violation | Line |
|---|---|---|
| AvoidSynchronizedAtMethodLevel | Use block level rather than method level synchronization | 57–69 |
| Rule | Violation | Line |
|---|---|---|
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 82 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 94 |
| Rule | Violation | Line |
|---|---|---|
| ShortVariable | Avoid variables with short names like id | 66 |
| ShortVariable | Avoid variables with short names like sb | 115 |
| Rule | Violation | Line |
|---|---|---|
| AvoidSynchronizedAtMethodLevel | Use block level rather than method level synchronization | 56–68 |
| Rule | Violation | Line |
|---|---|---|
| AvoidSynchronizedAtMethodLevel | Use block level rather than method level synchronization | 58–71 |
| Rule | Violation | Line |
|---|---|---|
| CallSuperInConstructor | It is a good practice to call super() in a constructor | 61–64 |
| MissingOverride | The method 'register()' is missing an @Override annotation. | 69–83 |
| ShortVariable | Avoid variables with short names like rt | 71 |
| ShortVariable | Avoid variables with short names like p | 77 |
| MissingOverride | The method 'getResourceIdList(Locale)' is missing an @Override annotation. | 92–95 |
| MissingOverride | The method 'getTitle(String, Locale)' is missing an @Override annotation. | 100–103 |
| Rule | Violation | Line |
|---|---|---|
| ExcessiveImports | A high number of imports can indicate a high degree of coupling within an object. | 34–209 |
| ImmutableField | Private field '_commentValueService' could be made final; it is only initialized in the declaration or constructor. | 96 |
| ImmutableField | Private field '_resourceHistoryService' could be made final; it is only initialized in the declaration or constructor. | 97 |
| ImmutableField | Private field '_taskService' could be made final; it is only initialized in the declaration or constructor. | 98 |
| ImmutableField | Private field '_taskComponentManager' could be made final; it is only initialized in the declaration or constructor. | 99 |
| Rule | Violation | Line |
|---|---|---|
| CommentRequired | Public method and constructor comments are required | 99–102 |
| CommentRequired | Public method and constructor comments are required | 104–108 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 116 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 117 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 148 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 164 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 199 |
| Rule | Violation | Line |
|---|---|---|
| AvoidSynchronizedAtMethodLevel | Use block level rather than method level synchronization | 57–69 |
| Rule | Violation | Line |
|---|---|---|
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 80 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 92 |
| Rule | Violation | Line |
|---|---|---|
| CommentRequired | Header comments are required | 38–73 |
| CommentDefaultAccessModifier | To avoid mistakes add a comment at the beginning of the _nDuration field if you want a default access modifier | 46 |
| DefaultPackage | Use explicit scoping instead of the default package private level | 46 |
| Rule | Violation | Line |
|---|---|---|
| CommentRequired | Header comments are required | 42–111 |
| Rule | Violation | Line |
|---|---|---|
| CommentRequired | Header comments are required | 55–131 |
| MissingOverride | The method 'getPrerequisiteType()' is missing an @Override annotation. | 66–69 |
| CommentRequired | Public method and constructor comments are required | 66–69 |
| MissingOverride | The method 'getTitleI18nKey()' is missing an @Override annotation. | 71–74 |
| CommentRequired | Public method and constructor comments are required | 71–74 |
| MissingOverride | The method 'hasConfiguration()' is missing an @Override annotation. | 76–79 |
| CommentRequired | Public method and constructor comments are required | 76–79 |
| CommentRequired | Public method and constructor comments are required | 81–84 |
| MissingOverride | The method 'getEmptyConfiguration()' is missing an @Override annotation. | 81–84 |
| CommentRequired | Public method and constructor comments are required | 86–89 |
| MissingOverride | The method 'getConfigurationDaoBeanName()' is missing an @Override annotation. | 86–89 |
| CommentRequired | Public method and constructor comments are required | 91–99 |
| MissingOverride | The method 'getConfigHtml(IPrerequisiteConfig, HttpServletRequest, Locale)' is missing an @Override annotation. | 91–99 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 93 |
| Rule | Violation | Line |
|---|---|---|
| AvoidSynchronizedAtMethodLevel | Use block level rather than method level synchronization | 59–73 |
| Rule | Violation | Line |
|---|---|---|
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 96 |
| ShortVariable | Avoid variables with short names like t | 99 |
| Rule | Violation | Line |
|---|---|---|
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 80 |
| Rule | Violation | Line |
|---|---|---|
| CommentRequired | Header comments are required | 41–64 |
| Rule | Violation | Line |
|---|---|---|
| CommentRequired | Header comments are required | 39–106 |
| Rule | Violation | Line |
|---|---|---|
| CommentRequired | Header comments are required | 36–93 |
| Rule | Violation | Line |
|---|---|---|
| CommentRequired | Header comments are required | 38–96 |
| Rule | Violation | Line |
|---|---|---|
| CommentRequired | Header comments are required | 38–89 |
| Rule | Violation | Line |
|---|---|---|
| CommentRequired | Header comments are required | 41–104 |
| Rule | Violation | Line |
|---|---|---|
| CommentRequired | Header comments are required | 39–114 |
| Rule | Violation | Line |
|---|---|---|
| CommentRequired | Header comments are required | 36–93 |
| Rule | Violation | Line |
|---|---|---|
| CommentRequired | Header comments are required | 38–96 |
| Rule | Violation | Line |
|---|---|---|
| CommentRequired | Header comments are required | 38–89 |
| Rule | Violation | Line |
|---|---|---|
| CommentRequired | Header comments are required | 36–67 |
| Rule | Violation | Line |
|---|---|---|
| CommentRequired | Header comments are required | 36–67 |
| Rule | Violation | Line |
|---|---|---|
| CommentRequired | Header comments are required | 62–133 |
| ImmutableField | Private field '_changeStateTaskService' could be made final; it is only initialized in the declaration or constructor. | 65 |
| ImmutableField | Private field '_workflowService' could be made final; it is only initialized in the declaration or constructor. | 66 |
| ImmutableField | Private field '_resourceWorkflowService' could be made final; it is only initialized in the declaration or constructor. | 67 |
| ImmutableField | Private field '_actionService' could be made final; it is only initialized in the declaration or constructor. | 68 |
| ImmutableField | Private field '_taskService' could be made final; it is only initialized in the declaration or constructor. | 69 |
| AvoidCatchingGenericException | Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 112 |
| Rule | Violation | Line |
|---|---|---|
| CommentRequired | Header comments are required | 62–133 |
| ImmutableField | Private field '_chooseStateTaskService' could be made final; it is only initialized in the declaration or constructor. | 65 |
| ImmutableField | Private field '_workflowService' could be made final; it is only initialized in the declaration or constructor. | 66 |
| ImmutableField | Private field '_resourceWorkflowService' could be made final; it is only initialized in the declaration or constructor. | 67 |
| ImmutableField | Private field '_actionService' could be made final; it is only initialized in the declaration or constructor. | 68 |
| ImmutableField | Private field '_taskService' could be made final; it is only initialized in the declaration or constructor. | 69 |
| AvoidCatchingGenericException | Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 112 |
| Rule | Violation | Line |
|---|---|---|
| CommentRequired | Header comments are required | 58–136 |
| CommentRequired | Public method and constructor comments are required | 75–92 |
| CommentRequired | Public method and constructor comments are required | 94–103 |
| CommentRequired | Public method and constructor comments are required | 105–133 |
| CommentRequired | Protected method constructor comments are required | 135 |
| Rule | Violation | Line |
|---|---|---|
| CommentRequired | Header comments are required | 47–78 |
| Rule | Violation | Line |
|---|---|---|
| CommentRequired | Header comments are required | 46–75 |
| Rule | Violation | Line |
|---|---|---|
| CommentRequired | Header comments are required | 48–88 |
| Rule | Violation | Line |
|---|---|---|
| CommentRequired | Header comments are required | 41–80 |
| Rule | Violation | Line |
|---|---|---|
| CommentRequired | Header comments are required | 43–119 |
| UncommentedEmptyMethodBody | Document empty method body | 108–109 |
| UncommentedEmptyMethodBody | Document empty method body | 117–118 |
| Rule | Violation | Line |
|---|---|---|
| CommentRequired | Header comments are required | 52–94 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 70 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 82 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 82 |
| Rule | Violation | Line |
|---|---|---|
| CommentRequired | Header comments are required | 53–122 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 77 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 110 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 110 |
| Rule | Violation | Line |
|---|---|---|
| CallSuperInConstructor | It is a good practice to call super() in a constructor | 73–76 |
| ShortVariable | Avoid variables with short names like rt | 84 |
| ShortVariable | Avoid variables with short names like p | 90 |
| MissingOverride | The method 'getResourceIdList(Locale)' is missing an @Override annotation. | 110–125 |
| MissingOverride | The method 'getTitle(String, Locale)' is missing an @Override annotation. | 136–148 |
| ConsecutiveAppendsShouldReuse | StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 159 |
| AppendCharacterWithChar | Avoid appending characters as strings in StringBuffer.append. | 160 |
| ConsecutiveAppendsShouldReuse | StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 160 |
| ConsecutiveAppendsShouldReuse | StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 161 |
| AppendCharacterWithChar | Avoid appending characters as strings in StringBuffer.append. | 167 |
| ConsecutiveAppendsShouldReuse | StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 169 |
| ConsecutiveAppendsShouldReuse | StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 170 |
| Rule | Violation | Line |
|---|---|---|
| CallSuperInConstructor | It is a good practice to call super() in a constructor | 72–75 |
| ShortVariable | Avoid variables with short names like rt | 83 |
| ShortVariable | Avoid variables with short names like p | 89 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 139 |
| Rule | Violation | Line |
|---|---|---|
| UseUtilityClass | All methods are static. Consider using a utility class instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning. | 52–171 |
| CyclomaticComplexity | The method 'generate(Workflow, String)' has a cyclomatic complexity of 10. | 74–124 |
| ShortVariable | Avoid variables with short names like wf | 74 |
| ShortVariable | Avoid variables with short names like sb | 76 |
| AppendCharacterWithChar | Avoid appending characters as strings in StringBuffer.append. | 118 |
| AppendCharacterWithChar | Avoid appending characters as strings in StringBuffer.append. | 119 |
| ShortVariable | Avoid variables with short names like sb | 134 |
| ControlStatementBraces | This statement should have braces | 137 |
| Rule | Violation | Line |
|---|---|---|
| ExcessiveImports | A high number of imports can indicate a high degree of coupling within an object. | 34–645 |
| MissingOverride | The method 'getActions(int, String, Collection, User)' is missing an @Override annotation. | 124–129 |
| MissingOverride | The method 'getAuthorizedActions(Collection, User)' is missing an @Override annotation. | 135–138 |
| MissingOverride | The method 'getActions(String, Map, User)' is missing an @Override annotation. | 144–156 |
| AvoidLiteralsInIfCondition | Avoid using Literals in Conditional Statements | 200 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 211–237 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 261–272 |
| MissingOverride | The method 'getDisplayDocumentHistory(int, String, int, HttpServletRequest, Locale, Map, String, User)' is missing an @Override annotation. | 321–334 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 356 |
| MissingOverride | The method 'canProcessAction(int, String, int, HttpServletRequest, User)' is missing an @Override annotation. | 399–414 |
| CyclomaticComplexity | The method 'isAuthorized(int, String, int, User)' has a cyclomatic complexity of 10. | 420–470 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 426–443 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 536 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 548–555 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 591 |
| Rule | Violation | Line |
|---|---|---|
| CommentRequired | Header comments are required | 51–78 |
| ShortVariable | Avoid variables with short names like p | 55 |
| ShortVariable | Avoid variables with short names like oc | 57 |
| Rule | Violation | Line |
|---|---|---|
| CommentRequired | Header comments are required | 44–61 |
| Rule | Violation | Line |
|---|---|---|
| CommentRequired | Header comments are required | 46–58 |
| ImmutableField | Private field '_fmt' could be made final; it is only initialized in the declaration or constructor. | 48 |
| ShortVariable | Avoid variables with short names like dt | 54 |
| Rule | Violation | Line |
|---|---|---|
| CommentRequired | Header comments are required | 46–59 |
| ImmutableField | Private field '_fmt' could be made final; it is only initialized in the declaration or constructor. | 48 |
| ShortVariable | Avoid variables with short names like z | 54 |
| Rule | Violation | Line |
|---|---|---|
| CommentRequired | Header comments are required | 45–142 |
| DataClass | The class 'WorkflowJsonData' is suspected to be a Data Class (WOC=0.000%, NOPA=0, NOAM=10, WMC=10) | 45–142 |
| Rule | Violation | Line |
|---|---|---|
| ExcessiveImports | A high number of imports can indicate a high degree of coupling within an object. | 34–366 |
| CommentRequired | Header comments are required | 77–366 |
| TooManyMethods | This class has too many methods, consider refactoring it. | 78–366 |
| ImmutableField | Private field '_objectMapper' could be made final; it is only initialized in the declaration or constructor. | 83 |
| ImmutableField | Private field '_workflowService' could be made final; it is only initialized in the declaration or constructor. | 85 |
| ImmutableField | Private field '_stateService' could be made final; it is only initialized in the declaration or constructor. | 86 |
| ImmutableField | Private field '_actionService' could be made final; it is only initialized in the declaration or constructor. | 87 |
| ImmutableField | Private field '_taskService' could be made final; it is only initialized in the declaration or constructor. | 88 |
| ImmutableField | Private field '_taskFactory' could be made final; it is only initialized in the declaration or constructor. | 89 |
| ImmutableField | Private field '_prerequisiteManagementService' could be made final; it is only initialized in the declaration or constructor. | 90 |
| CommentRequired | Public method and constructor comments are required | 106–109 |
| NPathComplexity | The method 'jsonExportWorkflow(int)' has an NPath complexity of 768 | 117–199 |
| CommentRequired | Public method and constructor comments are required | 202–217 |
| CommentRequired | Public method and constructor comments are required | 219–232 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 236 |
| UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 268 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 279 |
| UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 351 |
| Rule | Violation | Line |
|---|---|---|
| InsufficientStringBufferDeclaration | StringBuffer constructor is initialized with size 16, but has at least 77 characters appended. | 106 |
| ConsecutiveAppendsShouldReuse | StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 107 |
| ConsecutiveLiteralAppends | StringBuffer (or StringBuilder).append is called 2 consecutive times with literals. Use a single append with a single combined String. | 107 |
| ControlStatementBraces | This statement should have braces | 109 |
| Rule | Violation | Line |
|---|---|---|
| AvoidCatchingGenericException | Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 73 |
| AvoidLiteralsInIfCondition | Avoid using Literals in Conditional Statements | 132 |
| Rule | Violation | Line |
|---|---|---|
| ShortVariable | Avoid variables with short names like e | 121 |
| Rule | Violation | Line |
|---|---|---|
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 138–145 |
| Rule | Violation | Line |
|---|---|---|
| AvoidLiteralsInIfCondition | Avoid using Literals in Conditional Statements | 194 |
| AssignmentInOperand | Avoid assignments in operands | 194 |
| Rule | Violation | Line |
|---|---|---|
| ImmutableField | Private field '_nDefaultItemsPerPage' could be made final; it is only initialized in the declaration or constructor. | 122 |
| ImmutableField | Private field '_iconService' could be made final; it is only initialized in the declaration or constructor. | 125 |
| ImmutableField | Private field '_actionService' could be made final; it is only initialized in the declaration or constructor. | 126 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 137 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 216 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 255–262 |
| CyclomaticComplexity | The method 'getIconData(HttpServletRequest, Icon)' has a cyclomatic complexity of 18. | 337–406 |
| NPathComplexity | The method 'getIconData(HttpServletRequest, Icon)' has an NPath complexity of 784 | 337–406 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 344 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 345 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 392–400 |
| Rule | Violation | Line |
|---|---|---|
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 109 |
| ShortVariable | Avoid variables with short names like t | 116 |
| Rule | Violation | Line |
|---|---|---|
| ExcessivePublicCount | This class has a bunch of public methods and attributes | 34–3081 |
| ExcessiveImports | A high number of imports can indicate a high degree of coupling within an object. | 34–3081 |
| GodClass | Possible God Class (WMC=333, ATFD=531, TCC=32.981%) | 130–3081 |
| CyclomaticComplexity | The class 'WorkflowJspBean' has a total cyclomatic complexity of 333 (highest 15). | 130–3081 |
| TooManyFields | Too many fields | 130–3081 |
| ExcessiveClassLength | Avoid really long classes. | 130–3081 |
| TooManyMethods | This class has too many methods, consider refactoring it. | 131–3081 |
| ImmutableField | Private field '_nDefaultItemsPerPage' could be made final; it is only initialized in the declaration or constructor. | 302 |
| RedundantFieldInitializer | Avoid using redundant field initializer for '_bIsAscSort' | 312 |
| ImmutableField | Private field '_workflowService' could be made final; it is only initialized in the declaration or constructor. | 313 |
| ImmutableField | Private field '_stateService' could be made final; it is only initialized in the declaration or constructor. | 314 |
| ImmutableField | Private field '_actionService' could be made final; it is only initialized in the declaration or constructor. | 315 |
| ImmutableField | Private field '_iconService' could be made final; it is only initialized in the declaration or constructor. | 316 |
| ImmutableField | Private field '_taskService' could be made final; it is only initialized in the declaration or constructor. | 317 |
| ImmutableField | Private field '_taskFactory' could be made final; it is only initialized in the declaration or constructor. | 318 |
| ImmutableField | Private field '_taskComponentManager' could be made final; it is only initialized in the declaration or constructor. | 319 |
| ImmutableField | Private field '_prerequisiteManagementService' could be made final; it is only initialized in the declaration or constructor. | 320 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 379 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 413 |
| NPathComplexity | The method 'getModifyWorkflow(HttpServletRequest)' has an NPath complexity of 864 | 468–586 |
| ExcessiveMethodLength | Avoid really long methods. | 468–586 |
| NcssCount | The method 'getModifyWorkflow(HttpServletRequest)' has a NCSS line count of 67. | 468–586 |
| CyclomaticComplexity | The method 'getModifyWorkflow(HttpServletRequest)' has a cyclomatic complexity of 13. | 468–586 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 470 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 472 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 473 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 549 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 562 |
| AvoidDeeplyNestedIfStmts | Deeply nested if..then statements are hard to read | 615–618 |
| AvoidDeeplyNestedIfStmts | Deeply nested if..then statements are hard to read | 622–625 |
| AvoidDeeplyNestedIfStmts | Deeply nested if..then statements are hard to read | 629–632 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 678 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 749 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 788 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 844 |
| CyclomaticComplexity | The method 'doCreateState(HttpServletRequest)' has a cyclomatic complexity of 10. | 865–924 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 957 |
| CyclomaticComplexity | The method 'doModifyState(HttpServletRequest)' has a cyclomatic complexity of 11. | 978–1033 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 1002 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 1149 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 1150 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 1151 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 1213 |
| NcssCount | The method 'getActionData(HttpServletRequest, Action)' has a NCSS line count of 66. | 1305–1414 |
| ExcessiveMethodLength | Avoid really long methods. | 1305–1414 |
| CyclomaticComplexity | The method 'getActionData(HttpServletRequest, Action)' has a cyclomatic complexity of 15. | 1305–1414 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 1317 |
| CyclomaticComplexity | The method 'getModifyAction(HttpServletRequest)' has a cyclomatic complexity of 10. | 1425–1512 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 1484 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 1701 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 1738 |
| ShortVariable | Avoid variables with short names like it | 1975 |
| CyclomaticComplexity | The method 'doChangeOrderState(HttpServletRequest)' has a cyclomatic complexity of 10. | 2124–2195 |
| CyclomaticComplexity | The method 'doChangeOrderAction(HttpServletRequest)' has a cyclomatic complexity of 10. | 2204–2272 |
| CyclomaticComplexity | The method 'doChangeOrderTask(HttpServletRequest)' has a cyclomatic complexity of 11. | 2281–2350 |
| CommentRequired | Public method and constructor comments are required | 2652–2659 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 2841 |
| CyclomaticComplexity | The method 'doRemoveTaskFromReflexiveAction(HttpServletRequest)' has a cyclomatic complexity of 11. | 2963–3001 |
| ShortVariable | Avoid variables with short names like os | 3034 |
| CommentRequired | Public method and constructor comments are required | 3048–3060 |
| CommentRequired | Public method and constructor comments are required | 3062–3080 |
| NullAssignment | Assigning an Object to null is a code smell. Consider refactoring. | 3077 |
| Rule | Violation | Line |
|---|---|---|
| ImmutableField | Private field '_prerequisiteManagementService' could be made final; it is only initialized in the declaration or constructor. | 88 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 129 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 137–147 |
| AvoidDeeplyNestedIfStmts | Deeply nested if..then statements are hard to read | 193–203 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 262 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 270–280 |
| Rule | Violation | Line |
|---|---|---|
| BooleanGetMethodName | A getX() method which returns a boolean should be named isX() | 91–94 |
| Rule | Violation | Line |
|---|---|---|
| UnusedImports | Avoid unused imports such as 'fr.paris.lutece.portal.service.message.AdminMessage' | 47 |
| UnusedImports | Avoid unused imports such as 'fr.paris.lutece.portal.service.message.AdminMessageService' | 48 |
| Rule | Violation | Line |
|---|---|---|
| UseVarargs | Consider using varargs for methods or constructors which take an array the last parameter. | 145 |
| UseVarargs | Consider using varargs for methods or constructors which take an array the last parameter. | 276 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| TooManyMethods | This class has too many methods, consider refactoring it. | 3 | 57–530 |
| AvoidSynchronizedAtMethodLevel | Use block level rather than method level synchronization | 3 | 99–122 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 3 | 113–114 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 3 | 144–145 |
| CyclomaticComplexity | The method 'selectActionsByFilter(ActionFilter)' has a cyclomatic complexity of 16. | 3 | 212–301 |
| NPathComplexity | The method 'selectActionsByFilter(ActionFilter)' has an NPath complexity of 32896 | 3 | 212–301 |
| AvoidSynchronizedAtMethodLevel | Use block level rather than method level synchronization | 3 | 307–317 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| CommentRequired | Header comments are required | 3 | 44–129 |
| UnusedPrivateField | Avoid unused private fields such as 'SQL_QUERY_SELECT_ALL'. | 3 | 46 |
| AvoidSynchronizedAtMethodLevel | Use block level rather than method level synchronization | 3 | 58–73 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| AvoidSynchronizedAtMethodLevel | Use block level rather than method level synchronization | 3 | 63–81 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| AvoidSynchronizedAtMethodLevel | Use block level rather than method level synchronization | 3 | 86–100 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| CallSuperInConstructor | It is a good practice to call super() in a constructor | 3 | 56–63 |
| BooleanGetMethodName | A getX() method which returns a boolean should be named isX() | 4 | 91–94 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| TooManyMethods | This class has too many methods, consider refactoring it. | 3 | 58–528 |
| AvoidSynchronizedAtMethodLevel | Use block level rather than method level synchronization | 3 | 86–105 |
| AvoidReassigningParameters | Avoid reassigning parameters such as 'nPos' | 2 | 400 |
| AvoidReassigningParameters | Avoid reassigning parameters such as 'nPos' | 2 | 400 |
| AvoidReassigningParameters | Avoid reassigning parameters such as 'nPos' | 2 | 400 |
| AvoidReassigningParameters | Avoid reassigning parameters such as 'nPos' | 2 | 400 |
| AvoidReassigningParameters | Avoid reassigning parameters such as 'nPos' | 2 | 400 |
| AvoidReassigningParameters | Avoid reassigning parameters such as 'nPos' | 2 | 400 |
| AvoidReassigningParameters | Avoid reassigning parameters such as 'nPos' | 2 | 412 |
| AvoidReassigningParameters | Avoid reassigning parameters such as 'nPos' | 2 | 412 |
| AvoidReassigningParameters | Avoid reassigning parameters such as 'nPos' | 2 | 412 |
| AvoidReassigningParameters | Avoid reassigning parameters such as 'nPos' | 2 | 412 |
| ShortVariable | Avoid variables with short names like sb | 3 | 459 |
| ConsecutiveAppendsShouldReuse | StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 3 | 460 |
| ConsecutiveAppendsShouldReuse | StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 3 | 461 |
| AvoidReassigningParameters | Avoid reassigning parameters such as 'nPos' | 2 | 481 |
| AvoidReassigningParameters | Avoid reassigning parameters such as 'nPos' | 2 | 481 |
| AvoidReassigningParameters | Avoid reassigning parameters such as 'nPos' | 2 | 481 |
| AvoidReassigningParameters | Avoid reassigning parameters such as 'nPos' | 2 | 481 |
| AvoidReassigningParameters | Avoid reassigning parameters such as 'nPos' | 2 | 481 |
| ForLoopCanBeForeach | This for loop can be replaced by a foreach loop | 3 | 506–509 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| TooManyMethods | This class has too many methods, consider refactoring it. | 3 | 59–829 |
| AvoidSynchronizedAtMethodLevel | Use block level rather than method level synchronization | 3 | 102–124 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 3 | 112–119 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 3 | 140–147 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 3 | 605 |
| NPathComplexity | The method 'buildFilterQuerydFooter(DAOUtil, ResourceWorkflowFilter, List, Integer)' has an NPath complexity of 648 | 3 | 654–716 |
| CyclomaticComplexity | The method 'buildFilterQuerydFooter(DAOUtil, ResourceWorkflowFilter, List, Integer)' has a cyclomatic complexity of 12. | 3 | 654–716 |
| NPathComplexity | The method 'buildFilterQuerydHeader(ResourceWorkflowFilter, List, String, String)' has an NPath complexity of 432 | 3 | 731–801 |
| CyclomaticComplexity | The method 'buildFilterQuerydHeader(ResourceWorkflowFilter, List, String, String)' has a cyclomatic complexity of 11. | 3 | 731–801 |
| ShortVariable | Avoid variables with short names like sb | 3 | 770 |
| ConsecutiveAppendsShouldReuse | StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 3 | 771 |
| ConsecutiveAppendsShouldReuse | StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 3 | 772 |
| ShortVariable | Avoid variables with short names like sb | 3 | 786 |
| ConsecutiveAppendsShouldReuse | StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 3 | 787 |
| ConsecutiveAppendsShouldReuse | StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 3 | 788 |
| AssignmentInOperand | Avoid assignments in operands | 3 | 818 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 3 | 818–825 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| TooManyMethods | This class has too many methods, consider refactoring it. | 3 | 54–369 |
| AvoidSynchronizedAtMethodLevel | Use block level rather than method level synchronization | 3 | 78–107 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| AvoidSynchronizedAtMethodLevel | Use block level rather than method level synchronization | 3 | 77–93 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| AvoidSynchronizedAtMethodLevel | Use block level rather than method level synchronization | 3 | 71–89 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| CommentRequired | Enum comments are required | 3 | 36–40 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| CommentRequired | Header comments are required | 3 | 41–126 |
| AvoidSynchronizedAtMethodLevel | Use block level rather than method level synchronization | 3 | 56–68 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| CommentRequired | Header comments are required | 3 | 38–152 |
| NullAssignment | Assigning an Object to null is a code smell. Consider refactoring. | 3 | 100 |
| NullAssignment | Assigning an Object to null is a code smell. Consider refactoring. | 3 | 128 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| CommentRequired | Header comments are required | 3 | 41–167 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 3 | 58–65 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 3 | 67–74 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 3 | 109–116 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 3 | 118–125 |
| AssignmentInOperand | Avoid assignments in operands | 3 | 154 |
| AssignmentInOperand | Avoid assignments in operands | 3 | 159 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| CommentRequired | Header comments are required | 3 | 36–76 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| CommentRequired | Header comments are required | 3 | 67–142 |
| ImmutableField | Private field '_workflowService' could be made final; it is only initialized in the declaration or constructor. | 3 | 69 |
| ImmutableField | Private field '_actionService' could be made final; it is only initialized in the declaration or constructor. | 3 | 70 |
| ImmutableField | Private field '_taskService' could be made final; it is only initialized in the declaration or constructor. | 3 | 71 |
| ImmutableField | Private field '_resourceWorkflowService' could be made final; it is only initialized in the declaration or constructor. | 3 | 72 |
| ImmutableField | Private field '_archiveService' could be made final; it is only initialized in the declaration or constructor. | 3 | 73 |
| ShortVariable | Avoid variables with short names like wf | 3 | 98 |
| AvoidDeeplyNestedIfStmts | Deeply nested if..then statements are hard to read | 3 | 114–118 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| CommentRequired | Protected method constructor comments are required | 3 | 58–61 |
| CommentRequired | Protected method constructor comments are required | 3 | 63–67 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| CommentRequired | Header comments are required | 3 | 38–46 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| CommentRequired | Header comments are required | 3 | 50–105 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 63 |
| CommentRequired | Public method and constructor comments are required | 3 | 79–85 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| CommentRequired | Header comments are required | 3 | 66–236 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 3 | 111 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| ShortVariable | Avoid variables with short names like id | 3 | 62 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| AvoidSynchronizedAtMethodLevel | Use block level rather than method level synchronization | 3 | 59–71 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| AvoidSynchronizedAtMethodLevel | Use block level rather than method level synchronization | 3 | 59–75 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 3 | 133–140 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| ForLoopCanBeForeach | This for loop can be replaced by a foreach loop | 3 | 121–136 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 3 | 159 |
| ShortVariable | Avoid variables with short names like t | 3 | 162 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| NPathComplexity | The method 'doSaveConfig(HttpServletRequest, Locale, ITask)' has an NPath complexity of 1152 | 3 | 115–205 |
| CyclomaticComplexity | The method 'doSaveConfig(HttpServletRequest, Locale, ITask)' has a cyclomatic complexity of 13. | 3 | 115–205 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 119 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 121 |
| ForLoopCanBeForeach | This for loop can be replaced by a foreach loop | 3 | 172–192 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 3 | 180–188 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 213 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 214 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 3 | 279 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 3 | 295 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 3 | 329 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| AvoidSynchronizedAtMethodLevel | Use block level rather than method level synchronization | 3 | 57–69 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UnusedImports | Avoid unused imports such as 'fr.paris.lutece.portal.service.message.AdminMessage' | 4 | 47 |
| UnusedImports | Avoid unused imports such as 'fr.paris.lutece.portal.service.message.AdminMessageService' | 4 | 48 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 3 | 82 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 3 | 94 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| ShortVariable | Avoid variables with short names like id | 3 | 66 |
| ShortVariable | Avoid variables with short names like sb | 3 | 115 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| AvoidSynchronizedAtMethodLevel | Use block level rather than method level synchronization | 3 | 56–68 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| AvoidSynchronizedAtMethodLevel | Use block level rather than method level synchronization | 3 | 58–71 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| CallSuperInConstructor | It is a good practice to call super() in a constructor | 3 | 61–64 |
| MissingOverride | The method 'register()' is missing an @Override annotation. | 3 | 69–83 |
| ShortVariable | Avoid variables with short names like rt | 3 | 71 |
| ShortVariable | Avoid variables with short names like p | 3 | 77 |
| MissingOverride | The method 'getResourceIdList(Locale)' is missing an @Override annotation. | 3 | 92–95 |
| MissingOverride | The method 'getTitle(String, Locale)' is missing an @Override annotation. | 3 | 100–103 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| ExcessiveImports | A high number of imports can indicate a high degree of coupling within an object. | 3 | 34–209 |
| ImmutableField | Private field '_commentValueService' could be made final; it is only initialized in the declaration or constructor. | 3 | 96 |
| ImmutableField | Private field '_resourceHistoryService' could be made final; it is only initialized in the declaration or constructor. | 3 | 97 |
| ImmutableField | Private field '_taskService' could be made final; it is only initialized in the declaration or constructor. | 3 | 98 |
| ImmutableField | Private field '_taskComponentManager' could be made final; it is only initialized in the declaration or constructor. | 3 | 99 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| CommentRequired | Public method and constructor comments are required | 3 | 99–102 |
| CommentRequired | Public method and constructor comments are required | 3 | 104–108 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 116 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 117 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 3 | 148 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 3 | 164 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 3 | 199 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| AvoidSynchronizedAtMethodLevel | Use block level rather than method level synchronization | 3 | 57–69 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 3 | 80 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 3 | 92 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| CommentRequired | Header comments are required | 3 | 38–73 |
| CommentDefaultAccessModifier | To avoid mistakes add a comment at the beginning of the _nDuration field if you want a default access modifier | 3 | 46 |
| DefaultPackage | Use explicit scoping instead of the default package private level | 3 | 46 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| CommentRequired | Header comments are required | 3 | 42–111 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| CommentRequired | Header comments are required | 3 | 55–131 |
| MissingOverride | The method 'getPrerequisiteType()' is missing an @Override annotation. | 3 | 66–69 |
| CommentRequired | Public method and constructor comments are required | 3 | 66–69 |
| MissingOverride | The method 'getTitleI18nKey()' is missing an @Override annotation. | 3 | 71–74 |
| CommentRequired | Public method and constructor comments are required | 3 | 71–74 |
| MissingOverride | The method 'hasConfiguration()' is missing an @Override annotation. | 3 | 76–79 |
| CommentRequired | Public method and constructor comments are required | 3 | 76–79 |
| CommentRequired | Public method and constructor comments are required | 3 | 81–84 |
| MissingOverride | The method 'getEmptyConfiguration()' is missing an @Override annotation. | 3 | 81–84 |
| CommentRequired | Public method and constructor comments are required | 3 | 86–89 |
| MissingOverride | The method 'getConfigurationDaoBeanName()' is missing an @Override annotation. | 3 | 86–89 |
| CommentRequired | Public method and constructor comments are required | 3 | 91–99 |
| MissingOverride | The method 'getConfigHtml(IPrerequisiteConfig, HttpServletRequest, Locale)' is missing an @Override annotation. | 3 | 91–99 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 3 | 93 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| AvoidSynchronizedAtMethodLevel | Use block level rather than method level synchronization | 3 | 59–73 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 3 | 96 |
| ShortVariable | Avoid variables with short names like t | 3 | 99 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 3 | 80 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| CommentRequired | Header comments are required | 3 | 41–64 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| CommentRequired | Header comments are required | 3 | 39–106 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| CommentRequired | Header comments are required | 3 | 36–93 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| CommentRequired | Header comments are required | 3 | 38–96 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| CommentRequired | Header comments are required | 3 | 38–89 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| CommentRequired | Header comments are required | 3 | 41–104 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| CommentRequired | Header comments are required | 3 | 39–114 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| CommentRequired | Header comments are required | 3 | 36–93 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| CommentRequired | Header comments are required | 3 | 38–96 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| CommentRequired | Header comments are required | 3 | 38–89 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| CommentRequired | Header comments are required | 3 | 36–67 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| CommentRequired | Header comments are required | 3 | 36–67 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| CommentRequired | Header comments are required | 3 | 62–133 |
| ImmutableField | Private field '_changeStateTaskService' could be made final; it is only initialized in the declaration or constructor. | 3 | 65 |
| ImmutableField | Private field '_workflowService' could be made final; it is only initialized in the declaration or constructor. | 3 | 66 |
| ImmutableField | Private field '_resourceWorkflowService' could be made final; it is only initialized in the declaration or constructor. | 3 | 67 |
| ImmutableField | Private field '_actionService' could be made final; it is only initialized in the declaration or constructor. | 3 | 68 |
| ImmutableField | Private field '_taskService' could be made final; it is only initialized in the declaration or constructor. | 3 | 69 |
| AvoidCatchingGenericException | Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 3 | 112 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| CommentRequired | Header comments are required | 3 | 62–133 |
| ImmutableField | Private field '_chooseStateTaskService' could be made final; it is only initialized in the declaration or constructor. | 3 | 65 |
| ImmutableField | Private field '_workflowService' could be made final; it is only initialized in the declaration or constructor. | 3 | 66 |
| ImmutableField | Private field '_resourceWorkflowService' could be made final; it is only initialized in the declaration or constructor. | 3 | 67 |
| ImmutableField | Private field '_actionService' could be made final; it is only initialized in the declaration or constructor. | 3 | 68 |
| ImmutableField | Private field '_taskService' could be made final; it is only initialized in the declaration or constructor. | 3 | 69 |
| AvoidCatchingGenericException | Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 3 | 112 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| CommentRequired | Header comments are required | 3 | 58–136 |
| CommentRequired | Public method and constructor comments are required | 3 | 75–92 |
| CommentRequired | Public method and constructor comments are required | 3 | 94–103 |
| CommentRequired | Public method and constructor comments are required | 3 | 105–133 |
| CommentRequired | Protected method constructor comments are required | 3 | 135 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| CommentRequired | Header comments are required | 3 | 47–78 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| CommentRequired | Header comments are required | 3 | 46–75 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| CommentRequired | Header comments are required | 3 | 48–88 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| CommentRequired | Header comments are required | 3 | 41–80 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| CommentRequired | Header comments are required | 3 | 43–119 |
| UncommentedEmptyMethodBody | Document empty method body | 3 | 108–109 |
| UncommentedEmptyMethodBody | Document empty method body | 3 | 117–118 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| CommentRequired | Header comments are required | 3 | 52–94 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 3 | 70 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 82 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 3 | 82 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| CommentRequired | Header comments are required | 3 | 53–122 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 3 | 77 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 110 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 3 | 110 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| CallSuperInConstructor | It is a good practice to call super() in a constructor | 3 | 73–76 |
| ShortVariable | Avoid variables with short names like rt | 3 | 84 |
| ShortVariable | Avoid variables with short names like p | 3 | 90 |
| MissingOverride | The method 'getResourceIdList(Locale)' is missing an @Override annotation. | 3 | 110–125 |
| MissingOverride | The method 'getTitle(String, Locale)' is missing an @Override annotation. | 3 | 136–148 |
| ConsecutiveAppendsShouldReuse | StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 3 | 159 |
| AppendCharacterWithChar | Avoid appending characters as strings in StringBuffer.append. | 3 | 160 |
| ConsecutiveAppendsShouldReuse | StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 3 | 160 |
| ConsecutiveAppendsShouldReuse | StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 3 | 161 |
| AppendCharacterWithChar | Avoid appending characters as strings in StringBuffer.append. | 3 | 167 |
| ConsecutiveAppendsShouldReuse | StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 3 | 169 |
| ConsecutiveAppendsShouldReuse | StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 3 | 170 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| CallSuperInConstructor | It is a good practice to call super() in a constructor | 3 | 72–75 |
| ShortVariable | Avoid variables with short names like rt | 3 | 83 |
| ShortVariable | Avoid variables with short names like p | 3 | 89 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 3 | 139 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UseUtilityClass | All methods are static. Consider using a utility class instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning. | 3 | 52–171 |
| CyclomaticComplexity | The method 'generate(Workflow, String)' has a cyclomatic complexity of 10. | 3 | 74–124 |
| ShortVariable | Avoid variables with short names like wf | 3 | 74 |
| ShortVariable | Avoid variables with short names like sb | 3 | 76 |
| AppendCharacterWithChar | Avoid appending characters as strings in StringBuffer.append. | 3 | 118 |
| AppendCharacterWithChar | Avoid appending characters as strings in StringBuffer.append. | 3 | 119 |
| ShortVariable | Avoid variables with short names like sb | 3 | 134 |
| ControlStatementBraces | This statement should have braces | 3 | 137 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| ExcessiveImports | A high number of imports can indicate a high degree of coupling within an object. | 3 | 34–645 |
| AvoidReassigningParameters | Avoid reassigning parameters such as 'listActions' | 2 | 124 |
| MissingOverride | The method 'getActions(int, String, Collection, User)' is missing an @Override annotation. | 3 | 124–129 |
| MissingOverride | The method 'getAuthorizedActions(Collection, User)' is missing an @Override annotation. | 3 | 135–138 |
| MissingOverride | The method 'getActions(String, Map, User)' is missing an @Override annotation. | 3 | 144–156 |
| AvoidLiteralsInIfCondition | Avoid using Literals in Conditional Statements | 3 | 200 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 3 | 211–237 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 3 | 261–272 |
| MissingOverride | The method 'getDisplayDocumentHistory(int, String, int, HttpServletRequest, Locale, Map, String, User)' is missing an @Override annotation. | 3 | 321–334 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 3 | 356 |
| AvoidReassigningParameters | Avoid reassigning parameters such as 'user' | 2 | 378 |
| MissingOverride | The method 'canProcessAction(int, String, int, HttpServletRequest, User)' is missing an @Override annotation. | 3 | 399–414 |
| AvoidReassigningParameters | Avoid reassigning parameters such as 'user' | 2 | 399 |
| CyclomaticComplexity | The method 'isAuthorized(int, String, int, User)' has a cyclomatic complexity of 10. | 3 | 420–470 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 3 | 426–443 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 3 | 536 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 3 | 548–555 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 3 | 591 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| CommentRequired | Header comments are required | 3 | 51–78 |
| ShortVariable | Avoid variables with short names like p | 3 | 55 |
| ShortVariable | Avoid variables with short names like oc | 3 | 57 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| CommentRequired | Header comments are required | 3 | 44–61 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| CommentRequired | Header comments are required | 3 | 46–58 |
| ImmutableField | Private field '_fmt' could be made final; it is only initialized in the declaration or constructor. | 3 | 48 |
| ShortVariable | Avoid variables with short names like dt | 3 | 54 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| CommentRequired | Header comments are required | 3 | 46–59 |
| ImmutableField | Private field '_fmt' could be made final; it is only initialized in the declaration or constructor. | 3 | 48 |
| ShortVariable | Avoid variables with short names like z | 3 | 54 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| CommentRequired | Header comments are required | 3 | 45–142 |
| DataClass | The class 'WorkflowJsonData' is suspected to be a Data Class (WOC=0.000%, NOPA=0, NOAM=10, WMC=10) | 3 | 45–142 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| ExcessiveImports | A high number of imports can indicate a high degree of coupling within an object. | 3 | 34–366 |
| ClassWithOnlyPrivateConstructorsShouldBeFinal | A class which only has private constructors should be final | 1 | 77–366 |
| CommentRequired | Header comments are required | 3 | 77–366 |
| TooManyMethods | This class has too many methods, consider refactoring it. | 3 | 78–366 |
| ImmutableField | Private field '_objectMapper' could be made final; it is only initialized in the declaration or constructor. | 3 | 83 |
| ImmutableField | Private field '_workflowService' could be made final; it is only initialized in the declaration or constructor. | 3 | 85 |
| ImmutableField | Private field '_stateService' could be made final; it is only initialized in the declaration or constructor. | 3 | 86 |
| ImmutableField | Private field '_actionService' could be made final; it is only initialized in the declaration or constructor. | 3 | 87 |
| ImmutableField | Private field '_taskService' could be made final; it is only initialized in the declaration or constructor. | 3 | 88 |
| ImmutableField | Private field '_taskFactory' could be made final; it is only initialized in the declaration or constructor. | 3 | 89 |
| ImmutableField | Private field '_prerequisiteManagementService' could be made final; it is only initialized in the declaration or constructor. | 3 | 90 |
| CommentRequired | Public method and constructor comments are required | 3 | 106–109 |
| NPathComplexity | The method 'jsonExportWorkflow(int)' has an NPath complexity of 768 | 3 | 117–199 |
| CommentRequired | Public method and constructor comments are required | 3 | 202–217 |
| CommentRequired | Public method and constructor comments are required | 3 | 219–232 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 3 | 236 |
| LocalVariableNamingConventions | The local variable name 'StateBefore' doesn't match '[a-z][a-zA-Z0-9]*' | 1 | 268 |
| UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 3 | 268 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 3 | 279 |
| UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 3 | 351 |
| LocalVariableNamingConventions | The local variable name 'PrerequisiteTypeList' doesn't match '[a-z][a-zA-Z0-9]*' | 1 | 351 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| InsufficientStringBufferDeclaration | StringBuffer constructor is initialized with size 16, but has at least 77 characters appended. | 3 | 106 |
| ConsecutiveAppendsShouldReuse | StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 3 | 107 |
| ConsecutiveLiteralAppends | StringBuffer (or StringBuilder).append is called 2 consecutive times with literals. Use a single append with a single combined String. | 3 | 107 |
| ControlStatementBraces | This statement should have braces | 3 | 109 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| FieldNamingConventions | The final field name '_listMarkerProviders' doesn't match '[a-z][a-zA-Z0-9]*' | 1 | 53 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| AvoidCatchingGenericException | Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 3 | 73 |
| AvoidLiteralsInIfCondition | Avoid using Literals in Conditional Statements | 3 | 132 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| ShortVariable | Avoid variables with short names like e | 3 | 121 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 3 | 138–145 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UseVarargs | Consider using varargs for methods or constructors which take an array the last parameter. | 4 | 145 |
| AvoidLiteralsInIfCondition | Avoid using Literals in Conditional Statements | 3 | 194 |
| AssignmentInOperand | Avoid assignments in operands | 3 | 194 |
| UseVarargs | Consider using varargs for methods or constructors which take an array the last parameter. | 4 | 276 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| ImmutableField | Private field '_nDefaultItemsPerPage' could be made final; it is only initialized in the declaration or constructor. | 3 | 122 |
| ImmutableField | Private field '_iconService' could be made final; it is only initialized in the declaration or constructor. | 3 | 125 |
| ImmutableField | Private field '_actionService' could be made final; it is only initialized in the declaration or constructor. | 3 | 126 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 3 | 137 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 3 | 216 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 3 | 255–262 |
| CyclomaticComplexity | The method 'getIconData(HttpServletRequest, Icon)' has a cyclomatic complexity of 18. | 3 | 337–406 |
| NPathComplexity | The method 'getIconData(HttpServletRequest, Icon)' has an NPath complexity of 784 | 3 | 337–406 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 344 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 345 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 3 | 392–400 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 3 | 109 |
| ShortVariable | Avoid variables with short names like t | 3 | 116 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| ExcessivePublicCount | This class has a bunch of public methods and attributes | 3 | 34–3081 |
| ExcessiveImports | A high number of imports can indicate a high degree of coupling within an object. | 3 | 34–3081 |
| GodClass | Possible God Class (WMC=333, ATFD=531, TCC=32.981%) | 3 | 130–3081 |
| CyclomaticComplexity | The class 'WorkflowJspBean' has a total cyclomatic complexity of 333 (highest 15). | 3 | 130–3081 |
| TooManyFields | Too many fields | 3 | 130–3081 |
| ExcessiveClassLength | Avoid really long classes. | 3 | 130–3081 |
| TooManyMethods | This class has too many methods, consider refactoring it. | 3 | 131–3081 |
| ImmutableField | Private field '_nDefaultItemsPerPage' could be made final; it is only initialized in the declaration or constructor. | 3 | 302 |
| RedundantFieldInitializer | Avoid using redundant field initializer for '_bIsAscSort' | 3 | 312 |
| ImmutableField | Private field '_workflowService' could be made final; it is only initialized in the declaration or constructor. | 3 | 313 |
| ImmutableField | Private field '_stateService' could be made final; it is only initialized in the declaration or constructor. | 3 | 314 |
| ImmutableField | Private field '_actionService' could be made final; it is only initialized in the declaration or constructor. | 3 | 315 |
| ImmutableField | Private field '_iconService' could be made final; it is only initialized in the declaration or constructor. | 3 | 316 |
| ImmutableField | Private field '_taskService' could be made final; it is only initialized in the declaration or constructor. | 3 | 317 |
| ImmutableField | Private field '_taskFactory' could be made final; it is only initialized in the declaration or constructor. | 3 | 318 |
| ImmutableField | Private field '_taskComponentManager' could be made final; it is only initialized in the declaration or constructor. | 3 | 319 |
| ImmutableField | Private field '_prerequisiteManagementService' could be made final; it is only initialized in the declaration or constructor. | 3 | 320 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 3 | 379 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 3 | 413 |
| NPathComplexity | The method 'getModifyWorkflow(HttpServletRequest)' has an NPath complexity of 864 | 3 | 468–586 |
| ExcessiveMethodLength | Avoid really long methods. | 3 | 468–586 |
| NcssCount | The method 'getModifyWorkflow(HttpServletRequest)' has a NCSS line count of 67. | 3 | 468–586 |
| CyclomaticComplexity | The method 'getModifyWorkflow(HttpServletRequest)' has a cyclomatic complexity of 13. | 3 | 468–586 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 470 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 472 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 473 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 3 | 549 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 3 | 562 |
| AvoidDeeplyNestedIfStmts | Deeply nested if..then statements are hard to read | 3 | 615–618 |
| AvoidDeeplyNestedIfStmts | Deeply nested if..then statements are hard to read | 3 | 622–625 |
| AvoidDeeplyNestedIfStmts | Deeply nested if..then statements are hard to read | 3 | 629–632 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 678 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 749 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 788 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 3 | 844 |
| CyclomaticComplexity | The method 'doCreateState(HttpServletRequest)' has a cyclomatic complexity of 10. | 3 | 865–924 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 3 | 957 |
| CyclomaticComplexity | The method 'doModifyState(HttpServletRequest)' has a cyclomatic complexity of 11. | 3 | 978–1033 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 1002 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 1149 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 1150 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 1151 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 3 | 1213 |
| NcssCount | The method 'getActionData(HttpServletRequest, Action)' has a NCSS line count of 66. | 3 | 1305–1414 |
| ExcessiveMethodLength | Avoid really long methods. | 3 | 1305–1414 |
| CyclomaticComplexity | The method 'getActionData(HttpServletRequest, Action)' has a cyclomatic complexity of 15. | 3 | 1305–1414 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 1317 |
| CyclomaticComplexity | The method 'getModifyAction(HttpServletRequest)' has a cyclomatic complexity of 10. | 3 | 1425–1512 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 3 | 1484 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 3 | 1701 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 1738 |
| ShortVariable | Avoid variables with short names like it | 3 | 1975 |
| CyclomaticComplexity | The method 'doChangeOrderState(HttpServletRequest)' has a cyclomatic complexity of 10. | 3 | 2124–2195 |
| CyclomaticComplexity | The method 'doChangeOrderAction(HttpServletRequest)' has a cyclomatic complexity of 10. | 3 | 2204–2272 |
| CyclomaticComplexity | The method 'doChangeOrderTask(HttpServletRequest)' has a cyclomatic complexity of 11. | 3 | 2281–2350 |
| CommentRequired | Public method and constructor comments are required | 3 | 2652–2659 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 3 | 2841 |
| CyclomaticComplexity | The method 'doRemoveTaskFromReflexiveAction(HttpServletRequest)' has a cyclomatic complexity of 11. | 3 | 2963–3001 |
| ShortVariable | Avoid variables with short names like os | 3 | 3034 |
| CommentRequired | Public method and constructor comments are required | 3 | 3048–3060 |
| CommentRequired | Public method and constructor comments are required | 3 | 3062–3080 |
| NullAssignment | Assigning an Object to null is a code smell. Consider refactoring. | 3 | 3077 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| ImmutableField | Private field '_prerequisiteManagementService' could be made final; it is only initialized in the declaration or constructor. | 3 | 88 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 3 | 129 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 3 | 137–147 |
| AvoidDeeplyNestedIfStmts | Deeply nested if..then statements are hard to read | 3 | 193–203 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 3 | 262 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 3 | 270–280 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| EmptyMethodInAbstractClassShouldBeAbstract | An empty method in an abstract class should be abstract instead | 1 | 65–68 |
| EmptyMethodInAbstractClassShouldBeAbstract | An empty method in an abstract class should be abstract instead | 1 | 74–77 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| EmptyMethodInAbstractClassShouldBeAbstract | An empty method in an abstract class should be abstract instead | 1 | 53–56 |
| EmptyMethodInAbstractClassShouldBeAbstract | An empty method in an abstract class should be abstract instead | 1 | 62–65 |
