Fork me on GitHub
Built by Maven

PMD Results

The following document contains the results of PMD 6.13.0.

Violations By Priority

Priority 1

fr/paris/lutece/plugins/xpageportlet/service/http/XPagePortletHttpServletRequest.java

Rule Violation Line
ReturnEmptyArrayRatherThanNull Return an empty array rather than null. 97–127

Priority 3

fr/paris/lutece/plugins/xpageportlet/business/portlet/XPagePortletDAO.java

Rule Violation Line
AvoidSynchronizedAtMethodLevel Use block level rather than method level synchronization 67–82
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 162
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 162
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 176
AvoidSynchronizedAtMethodLevel Use block level rather than method level synchronization 194–218

fr/paris/lutece/plugins/xpageportlet/business/portlet/XPagePortletHome.java

Rule Violation Line
UncommentedEmptyConstructor Document empty constructor 56–58
UnnecessaryConstructor Avoid unnecessary constructors - the compiler will generate these for you 56–58
CallSuperInConstructor It is a good practice to call super() in a constructor 56–58
NonThreadSafeSingleton Singleton is not thread safe 67–70

fr/paris/lutece/plugins/xpageportlet/service/http/XPagePortletHttpServletRequest.java

Rule Violation Line
ImmutableField Private field '_mapParameters' could be made final; it is only initialized in the declaration or constructor. 53
CollapsibleIfStatements These nested if statements could be combined 79–87
AvoidDeeplyNestedIfStmts Deeply nested if..then statements are hard to read 83–86
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 99

fr/paris/lutece/plugins/xpageportlet/web/portlet/XPagePortletJspBean.java

Rule Violation Line
MissingSerialVersionUID Classes implementing Serializable should set a serialVersionUID 62–256
ImmutableField Private field '_xPagePorletService' could be made final; it is only initialized in the declaration or constructor. 75
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 86
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 86
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 109
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 109
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 230
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 230
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 245

Files

fr/paris/lutece/plugins/xpageportlet/business/portlet/XPagePortletDAO.java

Rule Violation Priority Line
AvoidSynchronizedAtMethodLevel Use block level rather than method level synchronization 3 67–82
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 3 162
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 3 162
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 3 176
AvoidSynchronizedAtMethodLevel Use block level rather than method level synchronization 3 194–218

fr/paris/lutece/plugins/xpageportlet/business/portlet/XPagePortletHome.java

Rule Violation Priority Line
UncommentedEmptyConstructor Document empty constructor 3 56–58
UnnecessaryConstructor Avoid unnecessary constructors - the compiler will generate these for you 3 56–58
CallSuperInConstructor It is a good practice to call super() in a constructor 3 56–58
NonThreadSafeSingleton Singleton is not thread safe 3 67–70

fr/paris/lutece/plugins/xpageportlet/service/http/XPagePortletHttpServletRequest.java

Rule Violation Priority Line
ImmutableField Private field '_mapParameters' could be made final; it is only initialized in the declaration or constructor. 3 53
CollapsibleIfStatements These nested if statements could be combined 3 79–87
AvoidDeeplyNestedIfStmts Deeply nested if..then statements are hard to read 3 83–86
ReturnEmptyArrayRatherThanNull Return an empty array rather than null. 1 97–127
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 3 99

fr/paris/lutece/plugins/xpageportlet/web/portlet/XPagePortletJspBean.java

Rule Violation Priority Line
MissingSerialVersionUID Classes implementing Serializable should set a serialVersionUID 3 62–256
ImmutableField Private field '_xPagePorletService' could be made final; it is only initialized in the declaration or constructor. 3 75
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 3 86
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 3 86
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 3 109
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 3 109
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 3 230
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 3 230
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 3 245