FindBugs Bug Detector Report
The following document contains the results of FindBugs
FindBugs Version is 3.0.1
Threshold is
Effort is max
Summary
| Classes |
Bugs |
Errors |
Missing Classes |
| 12 |
11 |
0 |
0 |
fr.paris.lutece.plugins.geocode.v1.web.rs.dto.City
| Bug |
Category |
Details |
Line |
Priority |
| fr.paris.lutece.plugins.geocode.v1.web.rs.dto.City.getDateValidityEnd() may expose internal representation by returning City._dateValidityEnd |
MALICIOUS_CODE |
EI_EXPOSE_REP |
178 |
Medium |
| fr.paris.lutece.plugins.geocode.v1.web.rs.dto.City.getDateValidityStart() may expose internal representation by returning City._dateValidityStart |
MALICIOUS_CODE |
EI_EXPOSE_REP |
151 |
Medium |
| fr.paris.lutece.plugins.geocode.v1.web.rs.dto.City.setDateValidityEnd(Date) may expose internal representation by storing an externally mutable object into City._dateValidityEnd |
MALICIOUS_CODE |
EI_EXPOSE_REP2 |
196 |
Medium |
| fr.paris.lutece.plugins.geocode.v1.web.rs.dto.City.setDateValidityStart(Date) may expose internal representation by storing an externally mutable object into City._dateValidityStart |
MALICIOUS_CODE |
EI_EXPOSE_REP2 |
170 |
Medium |
fr.paris.lutece.plugins.geocode.v1.web.rs.dto.Country
| Bug |
Category |
Details |
Line |
Priority |
| fr.paris.lutece.plugins.geocode.v1.web.rs.dto.Country.getDateLastUpdate() may expose internal representation by returning Country._dateLastUpdate |
MALICIOUS_CODE |
EI_EXPOSE_REP |
91 |
Medium |
| fr.paris.lutece.plugins.geocode.v1.web.rs.dto.Country.setDateLastUpdate(Date) may expose internal representation by storing an externally mutable object into Country._dateLastUpdate |
MALICIOUS_CODE |
EI_EXPOSE_REP2 |
99 |
Medium |
fr.paris.lutece.plugins.geocode.v1.web.rs.service.AbstractTransportRest
| Bug |
Category |
Details |
Line |
Priority |
| fr.paris.lutece.plugins.geocode.v1.web.rs.service.AbstractTransportRest._mapper isn't final but should be |
MALICIOUS_CODE |
MS_SHOULD_BE_FINAL |
54 |
High |
fr.paris.lutece.plugins.geocode.v1.web.rs.service.GeoCodeTransportMockRest
| Bug |
Category |
Details |
Line |
Priority |
| Useless object stored in variable mapParams of method fr.paris.lutece.plugins.geocode.v1.web.rs.service.GeoCodeTransportMockRest.getCityByCodeAndDate(String, Date) |
STYLE |
UC_USELESS_OBJECT |
68 |
Medium |
fr.paris.lutece.plugins.geocode.v1.web.rs.service.HttpAccessTransport
| Bug |
Category |
Details |
Line |
Priority |
| instanceof will always return true for all non-null values in fr.paris.lutece.plugins.geocode.v1.web.rs.service.HttpAccessTransport.handleExceptionGeocode(Exception), since all Exception are instances of Exception |
STYLE |
BC_VACUOUS_INSTANCEOF |
146 |
Medium |
| fr.paris.lutece.plugins.geocode.v1.web.rs.service.HttpAccessTransport.doGet(String, Map, Map, Class, ObjectMapper) makes inefficient use of keySet iterator instead of entrySet iterator |
PERFORMANCE |
WMI_WRONG_MAP_ITERATOR |
84 |
Medium |
| fr.paris.lutece.plugins.geocode.v1.web.rs.service.HttpAccessTransport.doGetList(String, Map, Map, Class, ObjectMapper) makes inefficient use of keySet iterator instead of entrySet iterator |
PERFORMANCE |
WMI_WRONG_MAP_ITERATOR |
115 |
Medium |
