The following document contains the results of PMD 6.13.0.
| Rule | Violation | Line |
|---|---|---|
| FieldNamingConventions | The field name 'permissions' doesn't match '_[a-z][a-zA-Z0-9]*' | 59 |
| Rule | Violation | Line |
|---|---|---|
| FieldNamingConventions | The field name 'permissions' doesn't match '_[a-z][a-zA-Z0-9]*' | 54 |
| FormalParameterNamingConventions | The method parameter name '_strScmDeveloperConnection' doesn't match '[a-z][a-zA-Z0-9]*' | 464 |
| FormalParameterNamingConventions | The method parameter name '_bUpgrade' doesn't match '[a-z][a-zA-Z0-9]*' | 495 |
| FormalParameterNamingConventions | The method parameter name '_bDowngrade' doesn't match '[a-z][a-zA-Z0-9]*' | 516 |
| FormalParameterNamingConventions | The method parameter name '_strLastAvailableSnapshotVersion' doesn't match '[a-z][a-zA-Z0-9]*' | 547 |
| FormalParameterNamingConventions | The method parameter name '_bErrorLastRelease' doesn't match '[a-z][a-zA-Z0-9]*' | 568 |
| FormalParameterNamingConventions | The method parameter name '_strName' doesn't match '[a-z][a-zA-Z0-9]*' | 589 |
| FormalParameterNamingConventions | The method parameter name '_strCloneUrl' doesn't match '[a-z][a-zA-Z0-9]*' | 610 |
| FormalParameterNamingConventions | The method parameter name '_strTweetMessage' doesn't match '[a-z][a-zA-Z0-9]*' | 652 |
| FormalParameterNamingConventions | The method parameter name '_strBranchReleaseFrom' doesn't match '[a-z][a-zA-Z0-9]*' | 706 |
| FormalParameterNamingConventions | The method parameter name '_strBranchReleaseVersion' doesn't match '[a-z][a-zA-Z0-9]*' | 716 |
| Rule | Violation | Line |
|---|---|---|
| FieldNamingConventions | The field name 'permissions' doesn't match '_[a-z][a-zA-Z0-9]*' | 62 |
| FormalParameterNamingConventions | The method parameter name '_strTagInfotmation' doesn't match '[a-z][a-zA-Z0-9]*' | 493 |
| FormalParameterNamingConventions | The method parameter name '_strGroupId' doesn't match '[a-z][a-zA-Z0-9]*' | 514 |
| FormalParameterNamingConventions | The method parameter name '_bTheme' doesn't match '[a-z][a-zA-Z0-9]*' | 535 |
| FormalParameterNamingConventions | The method parameter name '_strBranchReleaseFrom' doesn't match '[a-z][a-zA-Z0-9]*' | 555 |
| Rule | Violation | Line |
|---|---|---|
| FormalParameterNamingConventions | The method parameter name '_dateBegin' doesn't match '[a-z][a-zA-Z0-9]*' | 181 |
| FormalParameterNamingConventions | The method parameter name '_dateEnd' doesn't match '[a-z][a-zA-Z0-9]*' | 202 |
| FormalParameterNamingConventions | The method parameter name '_strArtifactId' doesn't match '[a-z][a-zA-Z0-9]*' | 223 |
| Rule | Violation | Line |
|---|---|---|
| FormalParameterNamingConventions | The method parameter name '_nId' doesn't match '[a-z][a-zA-Z0-9]*' | 98 |
| FormalParameterNamingConventions | The method parameter name '_component' doesn't match '[a-z][a-zA-Z0-9]*' | 119 |
| FormalParameterNamingConventions | The method parameter name '_commandResult' doesn't match '[a-z][a-zA-Z0-9]*' | 140 |
| FormalParameterNamingConventions | The method parameter name '_releaserUser' doesn't match '[a-z][a-zA-Z0-9]*' | 194 |
| FormalParameterNamingConventions | The method parameter name '_strRefBranchRelease' doesn't match '[a-z][a-zA-Z0-9]*' | 215 |
| FormalParameterNamingConventions | The method parameter name '_strRefBranchReleaseFrom' doesn't match '[a-z][a-zA-Z0-9]*' | 236 |
| Rule | Violation | Line |
|---|---|---|
| MethodNamingConventions | The static method name 'IsAddClusterAuthorized' doesn't match '[a-z][a-zA-Z0-9]*' | 146–155 |
| MethodNamingConventions | The static method name 'IsUserAuthorized' doesn't match '[a-z][a-zA-Z0-9]*' | 157–168 |
| Rule | Violation | Line |
|---|---|---|
| AvoidFileStream | Avoid instantiating FileInputStream, FileOutputStream, FileReader, or FileWriter | 432 |
| MethodNamingConventions | The static method name 'IsSearchComponentAuthorized' doesn't match '[a-z][a-zA-Z0-9]*' | 473–482 |
| Rule | Violation | Line |
|---|---|---|
| FieldNamingConventions | The static field name 'URL_JIRA_SERVER' doesn't match '_[a-z][a-zA-Z0-9]*' | 87 |
| FieldNamingConventions | The static field name 'JIRA_USER' doesn't match '_[a-z][a-zA-Z0-9]*' | 90 |
| FieldNamingConventions | The static field name 'JIRA_USER_PWD' doesn't match '_[a-z][a-zA-Z0-9]*' | 93 |
| Rule | Violation | Line |
|---|---|---|
| ClassWithOnlyPrivateConstructorsShouldBeFinal | A class which only has private constructors should be final | 62–291 |
| Rule | Violation | Line |
|---|---|---|
| AvoidFileStream | Avoid instantiating FileInputStream, FileOutputStream, FileReader, or FileWriter | 764 |
| MethodNamingConventions | The static method name 'IsUserAuthorized' doesn't match '[a-z][a-zA-Z0-9]*' | 851–862 |
| MethodNamingConventions | The static method name 'IsSiteAlreadyExist' doesn't match '[a-z][a-zA-Z0-9]*' | 864–871 |
| Rule | Violation | Line |
|---|---|---|
| FieldNamingConventions | The static field name 'STATUS_ERROR' doesn't match '_[a-z][a-zA-Z0-9]*' | 52 |
| FieldNamingConventions | The static field name 'STATUS_OK' doesn't match '_[a-z][a-zA-Z0-9]*' | 55 |
| FieldNamingConventions | The static field name 'ERROR_TYPE_INFO' doesn't match '_[a-z][a-zA-Z0-9]*' | 58 |
| FieldNamingConventions | The static field name 'ERROR_TYPE_STOP' doesn't match '_[a-z][a-zA-Z0-9]*' | 61 |
| FieldNamingConventions | The field name 'progressValue' doesn't match '_[a-z][a-zA-Z0-9]*' | 82 |
| FormalParameterNamingConventions | The method parameter name '_mResultInformations' doesn't match '[a-z][a-zA-Z0-9]*' | 206 |
| FormalParameterNamingConventions | The method parameter name '_nErrorType' doesn't match '[a-z][a-zA-Z0-9]*' | 227 |
| FormalParameterNamingConventions | The method parameter name '_dBegin' doesn't match '[a-z][a-zA-Z0-9]*' | 248 |
| FormalParameterNamingConventions | The method parameter name '_dEnd' doesn't match '[a-z][a-zA-Z0-9]*' | 269 |
| Rule | Violation | Line |
|---|---|---|
| FieldNamingConventions | The constant name '_mapper' doesn't match '[A-Z][A-Z_0-9]*' | 50 |
| Rule | Violation | Line |
|---|---|---|
| AvoidFileStream | Avoid instantiating FileInputStream, FileOutputStream, FileReader, or FileWriter | 193 |
| AvoidFileStream | Avoid instantiating FileInputStream, FileOutputStream, FileReader, or FileWriter | 247 |
| AvoidFileStream | Avoid instantiating FileInputStream, FileOutputStream, FileReader, or FileWriter | 308 |
| Rule | Violation | Line |
|---|---|---|
| LocalVariableNamingConventions | The final local variable name 'TOKEN' doesn't match '[a-z][a-zA-Z0-9]*' | 621 |
| Rule | Violation | Line |
|---|---|---|
| FormalParameterNamingConventions | The method parameter name '_strName' doesn't match '[a-z][a-zA-Z0-9]*' | 73 |
| FormalParameterNamingConventions | The method parameter name '_strCloneUrl' doesn't match '[a-z][a-zA-Z0-9]*' | 96 |
| FormalParameterNamingConventions | The method parameter name '_strContentsUrl' doesn't match '[a-z][a-zA-Z0-9]*' | 119 |
| FormalParameterNamingConventions | The method parameter name '_strFullName' doesn't match '[a-z][a-zA-Z0-9]*' | 142 |
| Rule | Violation | Line |
|---|---|---|
| FieldNamingConventions | The field name 'bCancelled' doesn't match '_[a-z][a-zA-Z0-9]*' | 44 |
| Rule | Violation | Line |
|---|---|---|
| ClassNamingConventions | The utility class name 'PomUpdater' doesn't match '[A-Z][a-zA-Z0-9]+(Utils?|Helper|Home|Service)' | 64–274 |
| AvoidFileStream | Avoid instantiating FileInputStream, FileOutputStream, FileReader, or FileWriter | 87 |
| AvoidFileStream | Avoid instantiating FileInputStream, FileOutputStream, FileReader, or FileWriter | 124 |
| AvoidFileStream | Avoid instantiating FileInputStream, FileOutputStream, FileReader, or FileWriter | 172 |
| AvoidFileStream | Avoid instantiating FileInputStream, FileOutputStream, FileReader, or FileWriter | 201 |
| Rule | Violation | Line |
|---|---|---|
| FieldNamingConventions | The field name 'bCancelled' doesn't match '_[a-z][a-zA-Z0-9]*' | 49 |
| Rule | Violation | Line |
|---|---|---|
| FieldNamingConventions | The field name 'bCancelled' doesn't match '_[a-z][a-zA-Z0-9]*' | 48 |
| Rule | Violation | Line |
|---|---|---|
| FieldNamingConventions | The field name 'bCancelled' doesn't match '_[a-z][a-zA-Z0-9]*' | 48 |
| Rule | Violation | Line |
|---|---|---|
| FormalParameterNamingConventions | The method parameter name '_mUserContex' doesn't match '[a-z][a-zA-Z0-9]*' | 120 |
| Rule | Violation | Line |
|---|---|---|
| FieldNamingConventions | The constant name 'logger' doesn't match '[A-Z][A-Z_0-9]*' | 92 |
| Rule | Violation | Line |
|---|---|---|
| AvoidReassigningParameters | Avoid reassigning parameters such as 'component' | 365 |
| AvoidReassigningParameters | Avoid reassigning parameters such as 'component' | 365 |
| AvoidReassigningParameters | Avoid reassigning parameters such as 'component' | 525 |
| Rule | Violation | Line |
|---|---|---|
| SystemPrintln | System.out.println is used | 246 |
| Rule | Violation | Line |
|---|---|---|
| AvoidBranchingStatementAsLastInLoop | Avoid using a branching statement as the last in a loop. | 160 |
| Rule | Violation | Line |
|---|---|---|
| BooleanInstantiation | Avoid instantiating Boolean objects; reference Boolean.TRUE or Boolean.FALSE or call Boolean.valueOf() instead. | 339 |
| Rule | Violation | Line |
|---|---|---|
| LongInstantiation | Avoid instantiating Long objects.Call Long.valueOf() instead | 355 |
| Rule | Violation | Line |
|---|---|---|
| AvoidReassigningParameters | Avoid reassigning parameters such as 'strRepoUrl' | 689 |
| Rule | Violation | Line |
|---|---|---|
| AvoidReassigningParameters | Avoid reassigning parameters such as 'strRepoUrl' | 465 |
| Rule | Violation | Line |
|---|---|---|
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 57–75 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 100–107 |
| NullAssignment | Assigning an Object to null is a code smell. Consider refactoring. | 115 |
| Rule | Violation | Line |
|---|---|---|
| LooseCoupling | Avoid using implementation types like 'HashMap'; use the interface instead | 59 |
| LooseCoupling | Avoid using implementation types like 'HashMap'; use the interface instead | 170 |
| LooseCoupling | Avoid using implementation types like 'HashMap'; use the interface instead | 175 |
| Rule | Violation | Line |
|---|---|---|
| UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 158 |
| UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 184 |
| Rule | Violation | Line |
|---|---|---|
| ExcessivePublicCount | This class has a bunch of public methods and attributes | 34–721 |
| TooManyFields | Too many fields | 47–721 |
| LooseCoupling | Avoid using implementation types like 'HashMap'; use the interface instead | 54 |
| UnusedPrivateField | Avoid unused private fields such as '_strDescription'. | 82 |
| MissingOverride | The method 'getArtifactId()' is missing an @Override annotation. | 143–146 |
| MissingOverride | The method 'getTargetVersion()' is missing an @Override annotation. | 227–230 |
| SimplifyBooleanReturns | Avoid unnecessary if..then..else statements when returning booleans | 440–444 |
| LooseCoupling | Avoid using implementation types like 'HashMap'; use the interface instead | 681 |
| LooseCoupling | Avoid using implementation types like 'HashMap'; use the interface instead | 686 |
| CommentRequired | Public method and constructor comments are required | 691–694 |
| CommentRequired | Public method and constructor comments are required | 696–699 |
| CommentRequired | Public method and constructor comments are required | 701–704 |
| CommentRequired | Public method and constructor comments are required | 706–709 |
| CommentRequired | Public method and constructor comments are required | 711–714 |
| CommentRequired | Public method and constructor comments are required | 716–719 |
| Rule | Violation | Line |
|---|---|---|
| LooseCoupling | Avoid using implementation types like 'HashMap'; use the interface instead | 54 |
| ImmutableField | Private field '_mapCredential' could be made final; it is only initialized in the declaration or constructor. | 54 |
| ImmutableField | Private field '_strLogin' could be made final; it is only initialized in the declaration or constructor. | 115 |
| FieldDeclarationsShouldBeAtStartOfClass | Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. | 115 |
| ImmutableField | Private field '_strPassword' could be made final; it is only initialized in the declaration or constructor. | 118 |
| FieldDeclarationsShouldBeAtStartOfClass | Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. | 118 |
| Rule | Violation | Line |
|---|---|---|
| ExcessivePublicCount | This class has a bunch of public methods and attributes | 34–612 |
| TooManyFields | Too many fields | 51–612 |
| LooseCoupling | Avoid using implementation types like 'HashMap'; use the interface instead | 62 |
| ImmutableField | Private field '_listCurrentDependencies' could be made final; it is only initialized in the declaration or constructor. | 106 |
| ImmutableField | Private field '_listComponents' could be made final; it is only initialized in the declaration or constructor. | 109 |
| MissingOverride | The method 'getArtifactId()' is missing an @Override annotation. | 167–170 |
| MissingOverride | The method 'getScmUrl()' is missing an @Override annotation. | 209–212 |
| CommentRequired | Public method and constructor comments are required | 540–543 |
| CommentRequired | Public method and constructor comments are required | 545–548 |
| CommentRequired | Public method and constructor comments are required | 550–553 |
| CommentRequired | Public method and constructor comments are required | 555–558 |
| LooseCoupling | Avoid using implementation types like 'HashMap'; use the interface instead | 594 |
| LooseCoupling | Avoid using implementation types like 'HashMap'; use the interface instead | 599 |
| UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 602 |
| ControlStatementBraces | This statement should have braces | 602 |
| ControlStatementBraces | This statement should have braces | 604 |
| Rule | Violation | Line |
|---|---|---|
| UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 182 |
| UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 214 |
| UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 252 |
| UnusedLocalVariable | Avoid unused local variables such as 'nIndex'. | 294 |
| ControlStatementBraces | This statement should have braces | 296 |
| Rule | Violation | Line |
|---|---|---|
| CommentRequired | Header comments are required | 48–147 |
| DataClass | The class 'ClusterResourceIdService' is suspected to be a Data Class (WOC=0.000%, NOPA=4, NOAM=0, WMC=1) | 48–147 |
| CallSuperInConstructor | It is a good practice to call super() in a constructor | 71–74 |
| ShortVariable | Avoid variables with short names like rt | 80 |
| ShortVariable | Avoid variables with short names like p | 86 |
| Rule | Violation | Line |
|---|---|---|
| UseUtilityClass | All methods are static. Consider using a utility class instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning. | 51–169 |
| UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 82 |
| UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 86 |
| ControlStatementBraces | This statement should have braces | 140 |
| CommentRequired | Public method and constructor comments are required | 146–155 |
| SimplifyBooleanReturns | Avoid unnecessary if..then..else statements when returning booleans | 149–152 |
| CommentRequired | Public method and constructor comments are required | 157–168 |
| Rule | Violation | Line |
|---|---|---|
| CommentRequired | Header comments are required | 45–95 |
| CallSuperInConstructor | It is a good practice to call super() in a constructor | 56–59 |
| ShortVariable | Avoid variables with short names like rt | 65 |
| ShortVariable | Avoid variables with short names like p | 71 |
| Rule | Violation | Line |
|---|---|---|
| ExcessiveImports | A high number of imports can indicate a high degree of coupling within an object. | 34–574 |
| GodClass | Possible God Class (WMC=48, ATFD=64, TCC=0.526%) | 84–574 |
| UnusedPrivateField | Avoid unused private fields such as '_executor'. | 86 |
| SingularField | Perhaps '_executor' could be replaced by a local variable. | 86 |
| NonThreadSafeSingleton | Singleton is not thread safe | 109–113 |
| CommentRequired | Public method and constructor comments are required | 119–169 |
| NPathComplexity | The method 'setRemoteInformations(Component, boolean)' has an NPath complexity of 517 | 119–169 |
| MissingOverride | The method 'setRemoteInformations(Component, boolean)' is missing an @Override annotation. | 119–169 |
| CyclomaticComplexity | The method 'setRemoteInformations(Component, boolean)' has a cyclomatic complexity of 14. | 119–169 |
| AvoidDeeplyNestedIfStmts | Deeply nested if..then statements are hard to read | 138–141 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 150 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 151 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 152 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 153 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 154 |
| AvoidDeeplyNestedIfStmts | Deeply nested if..then statements are hard to read | 156–160 |
| MissingOverride | The method 'getLastReleaseVersion(String)' is missing an @Override annotation. | 176–181 |
| MissingOverride | The method 'setLastReleaseVersion(String, String)' is missing an @Override annotation. | 188–193 |
| MissingOverride | The method 'getLastReleaseNextSnapshotVersion(String)' is missing an @Override annotation. | 200–205 |
| MissingOverride | The method 'setLastReleaseNextSnapshotVersion(String, String)' is missing an @Override annotation. | 212–216 |
| CommentRequired | Public method and constructor comments are required | 242–245 |
| MissingOverride | The method 'release(Component, Locale, AdminUser, HttpServletRequest)' is missing an @Override annotation. | 242–245 |
| MissingOverride | The method 'isGitComponent(Component)' is missing an @Override annotation. | 247–251 |
| CommentRequired | Public method and constructor comments are required | 247–251 |
| CommentRequired | Public method and constructor comments are required | 253–259 |
| MissingOverride | The method 'init()' is missing an @Override annotation. | 253–259 |
| CyclomaticComplexity | The method 'updateRemoteInformations(Component)' has a cyclomatic complexity of 11. | 262–310 |
| MissingOverride | The method 'getSearchComponent(String, HttpServletRequest, Locale, String, String)' is missing an @Override annotation. | 312–340 |
| CommentRequired | Public method and constructor comments are required | 312–340 |
| UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 327–328 |
| UnusedFormalParameter | Avoid unused method parameters such as 'strPassword'. | 342 |
| UnusedFormalParameter | Avoid unused method parameters such as 'strUser'. | 342 |
| MissingOverride | The method 'loadComponent(Component, String, String, String)' is missing an @Override annotation. | 365–395 |
| CommentRequired | Public method and constructor comments are required | 365–395 |
| CommentRequired | Public method and constructor comments are required | 421–451 |
| MissingOverride | The method 'isErrorSnapshotComponentInformations(Component, String)' is missing an @Override annotation. | 421–451 |
| MissingOverride | The method 'changeNextReleaseVersion(Component)' is missing an @Override annotation. | 459–471 |
| CommentRequired | Public method and constructor comments are required | 473–482 |
| SimplifyBooleanReturns | Avoid unnecessary if..then..else statements when returning booleans | 476–479 |
| CommentRequired | Public method and constructor comments are required | 525–572 |
| MissingOverride | The method 'getLastBranchVersion(Component, String, ReleaserUser)' is missing an @Override annotation. | 525–572 |
| Rule | Violation | Line |
|---|---|---|
| DoNotUseThreads | To be compliant to J2EE, a webapp should not use any thread. | 46 |
| ImmutableField | Private field '_component' could be made final; it is only initialized in the declaration or constructor. | 49 |
| Rule | Violation | Line |
|---|---|---|
| CommentRequired | Public method and constructor comments are required | 231 |
| Rule | Violation | Line |
|---|---|---|
| UnnecessaryModifier | Unnecessary modifiers 'public abstract' on method 'init': the method is declared in an interface type | 48 |
| UnnecessaryModifier | Unnecessary modifiers 'public abstract' on method 'updateComponentVersions': the method is declared in an interface type | 58 |
| Rule | Violation | Line |
|---|---|---|
| UseObjectForClearerAPI | Rather than using a lot of String arguments, consider using a container object for those values. | 81–82 |
| Rule | Violation | Line |
|---|---|---|
| TooManyMethods | This class has too many methods, consider refactoring it. | 49–221 |
| Rule | Violation | Line |
|---|---|---|
| ExcessiveImports | A high number of imports can indicate a high degree of coupling within an object. | 34–286 |
| UncommentedEmptyConstructor | Document empty constructor | 110–113 |
| UnnecessaryConstructor | Avoid unnecessary constructors - the compiler will generate these for you | 110–113 |
| NonThreadSafeSingleton | Singleton is not thread safe | 122–126 |
| CyclomaticComplexity | The method 'updateComponentVersions(Component, CommandResult)' has a cyclomatic complexity of 12. | 185–284 |
| AvoidSynchronizedAtMethodLevel | Use block level rather than method level synchronization | 185–284 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 191–282 |
| UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 229 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 230 |
| UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 230 |
| AvoidCatchingGenericException | Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 259 |
| Rule | Violation | Line |
|---|---|---|
| NonThreadSafeSingleton | Singleton is not thread safe | 87–91 |
| MissingOverride | The method 'init()' is missing an @Override annotation. | 100–106 |
| MissingOverride | The method 'mvnSiteAssembly(String, String, String, SvnUser, CommandResult)' is missing an @Override annotation. | 128–138 |
| UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 133 |
| AvoidSynchronizedAtMethodLevel | Use block level rather than method level synchronization | 176–224 |
| AddEmptyString | Do not add empty strings | 195 |
| MissingOverride | The method 'consumeLine(String)' is missing an @Override annotation. | 206–209 |
| CommentRequired | Public method and constructor comments are required | 206–209 |
| InefficientStringBuffering | Avoid concatenating nonliterals in a StringBuffer/StringBuilder constructor or append(). | 208 |
| AvoidCatchingGenericException | Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 217 |
| MissingOverride | The method 'mvnReleasePerform(String, String, String, CommandResult, boolean)' is missing an @Override annotation. | 239–253 |
| UseObjectForClearerAPI | Rather than using a lot of String arguments, consider using a container object for those values. | 274–275 |
| MissingOverride | The method 'mvnReleasePrepare(String, String, String, String, String, String, CommandResult)' is missing an @Override annotation. | 274–289 |
| Rule | Violation | Line |
|---|---|---|
| DoNotUseThreads | To be compliant to J2EE, a webapp should not use any thread. | 59 |
| ImmutableField | Private field '_nIdWorkflow' could be made final; it is only initialized in the declaration or constructor. | 66 |
| ImmutableField | Private field '_wfContext' could be made final; it is only initialized in the declaration or constructor. | 69 |
| ImmutableField | Private field '_request' could be made final; it is only initialized in the declaration or constructor. | 72 |
| ImmutableField | Private field '_user' could be made final; it is only initialized in the declaration or constructor. | 75 |
| ImmutableField | Private field '_locale' could be made final; it is only initialized in the declaration or constructor. | 78 |
| MissingOverride | The method 'run()' is missing an @Override annotation. | 107–178 |
| UnusedLocalVariable | Avoid unused local variables such as 'state'. | 110 |
| Rule | Violation | Line |
|---|---|---|
| CallSuperInConstructor | It is a good practice to call super() in a constructor | 72–75 |
| ShortVariable | Avoid variables with short names like rt | 80 |
| ShortVariable | Avoid variables with short names like p | 86 |
| Rule | Violation | Line |
|---|---|---|
| ExcessiveImports | A high number of imports can indicate a high degree of coupling within an object. | 34–873 |
| GodClass | Possible God Class (WMC=95, ATFD=142, TCC=0.000%) | 83–873 |
| CyclomaticComplexity | The class 'SiteService' has a total cyclomatic complexity of 95 (highest 14). | 83–873 |
| TooManyMethods | This class has too many methods, consider refactoring it. | 84–873 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 127–143 |
| UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 227 |
| IdenticalCatchBranches | 'catch' branch identical to 'InterruptedException' branch | 246–250 |
| CyclomaticComplexity | The method 'buildReleaseComments(Component, Locale)' has a cyclomatic complexity of 14. | 428–501 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 439–500 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 472–488 |
| UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 630 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 630 |
| IdenticalCatchBranches | 'catch' branch identical to 'FileNotFoundException' branch | 781–785 |
| CommentRequired | Public method and constructor comments are required | 790–849 |
| UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 793 |
| UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 802 |
| CommentRequired | Public method and constructor comments are required | 851–862 |
| CommentRequired | Public method and constructor comments are required | 864–871 |
| SimplifyBooleanReturns | Avoid unnecessary if..then..else statements when returning booleans | 867–868 |
| ControlStatementBraces | This statement should have braces | 868 |
| Rule | Violation | Line |
|---|---|---|
| RedundantFieldInitializer | Avoid using redundant field initializer for '_twitter' | 89 |
| RedundantFieldInitializer | Avoid using redundant field initializer for '_instance' | 92 |
| NonThreadSafeSingleton | Singleton is not thread safe | 101–105 |
| UnnecessaryConstructor | Avoid unnecessary constructors - the compiler will generate these for you | 113–116 |
| MissingOverride | The method 'sendTweet(String, CommandResult)' is missing an @Override annotation. | 126–144 |
| MissingOverride | The method 'init()' is missing an @Override annotation. | 149–167 |
| Rule | Violation | Line |
|---|---|---|
| ExcessiveImports | A high number of imports can indicate a high degree of coupling within an object. | 34–870 |
| GodClass | Possible God Class (WMC=62, ATFD=100, TCC=2.632%) | 83–870 |
| TooManyMethods | This class has too many methods, consider refactoring it. | 84–870 |
| ImmutableField | Private field '_mapWorkflowReleaseContext' could be made final; it is only initialized in the declaration or constructor. | 90 |
| UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 90 |
| LooseCoupling | Avoid using implementation types like 'HashMap'; use the interface instead | 90 |
| ImmutableField | Private field '_releaseInProgress' could be made final; it is only initialized in the declaration or constructor. | 96 |
| UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 96 |
| LooseCoupling | Avoid using implementation types like 'HashSet'; use the interface instead | 96 |
| AvoidSynchronizedAtMethodLevel | Use block level rather than method level synchronization | 112–134 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 122 |
| MissingOverride | The method 'saveWorkflowReleaseContext(WorkflowReleaseContext)' is missing an @Override annotation. | 160–198 |
| AvoidSynchronizedAtMethodLevel | Use block level rather than method level synchronization | 160–198 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 170–191 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 187 |
| MissingOverride | The method 'getListWorkflowReleaseContextHistory(String)' is missing an @Override annotation. | 232–261 |
| UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 235 |
| MissingOverride | The method 'getIdWorkflow(WorkflowReleaseContext)' is missing an @Override annotation. | 270–286 |
| NonThreadSafeSingleton | Singleton is not thread safe | 295–300 |
| CyclomaticComplexity | The method 'mergeDevelopMaster(WorkflowReleaseContext, Locale)' has a cyclomatic complexity of 14. | 313–411 |
| MissingOverride | The method 'mergeDevelopMaster(WorkflowReleaseContext, Locale)' is missing an @Override annotation. | 313–411 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 335–371 |
| IdenticalCatchBranches | 'catch' branch identical to 'InvalidRemoteException' branch | 380–384 |
| IdenticalCatchBranches | 'catch' branch identical to 'InvalidRemoteException' branch | 385–388 |
| IdenticalCatchBranches | 'catch' branch identical to 'InvalidRemoteException' branch | 389–392 |
| NcssCount | The method 'releasePrepareComponent(WorkflowReleaseContext, Locale)' has a NCSS line count of 71. | 421–579 |
| ExcessiveMethodLength | Avoid really long methods. | 421–579 |
| CyclomaticComplexity | The method 'releasePrepareComponent(WorkflowReleaseContext, Locale)' has a cyclomatic complexity of 13. | 421–579 |
| MissingOverride | The method 'releasePrepareComponent(WorkflowReleaseContext, Locale)' is missing an @Override annotation. | 421–579 |
| AvoidDuplicateLiterals | The String literal " to " appears 4 times in this file; the first occurrence is on line 462 | 462 |
| MissingOverride | The method 'releasePerformComponent(WorkflowReleaseContext, Locale)' is missing an @Override annotation. | 589–619 |
| AvoidDuplicateLiterals | The String literal " Release Perform" appears 4 times in this file; the first occurrence is on line 597 | 597 |
| MissingOverride | The method 'checkoutRepository(WorkflowReleaseContext, Locale)' is missing an @Override annotation. | 629–642 |
| MissingOverride | The method 'releasePrepareSite(WorkflowReleaseContext, Locale)' is missing an @Override annotation. | 652–716 |
| AvoidDuplicateLiterals | The String literal "...\n" appears 4 times in this file; the first occurrence is on line 665 | 665 |
| MissingOverride | The method 'sendTweet(WorkflowReleaseContext, Locale)' is missing an @Override annotation. | 726–737 |
| MissingOverride | The method 'updateJiraVersions(WorkflowReleaseContext, Locale)' is missing an @Override annotation. | 747–758 |
| MissingOverride | The method 'startWorkflowReleaseContext(WorkflowReleaseContext, int, Locale, HttpServletRequest, AdminUser)' is missing an @Override annotation. | 774–777 |
| MissingOverride | The method 'init()' is missing an @Override annotation. | 782–787 |
| MissingOverride | The method 'startReleaseInProgress(String)' is missing an @Override annotation. | 795–799 |
| MissingOverride | The method 'stopReleaseInProgress(String)' is missing an @Override annotation. | 807–811 |
| MissingOverride | The method 'isReleaseInProgress(String)' is missing an @Override annotation. | 820–824 |
| Rule | Violation | Line |
|---|---|---|
| MissingOverride | The method 'fetchPom(Site, String, String)' is missing an @Override annotation. | 85–98 |
| MissingOverride | The method 'getLastRelease(Site, String, String)' is missing an @Override annotation. | 111–138 |
| CyclomaticComplexity | The method 'doCheckoutRepository(WorkflowReleaseContext, String, String)' has a cyclomatic complexity of 11. | 152–240 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 187–198 |
| AvoidDuplicateLiterals | The String literal "/.git" appears 4 times in this file; the first occurrence is on line 283 | 283 |
| IdenticalCatchBranches | 'catch' branch identical to 'InvalidRemoteException' branch | 297–301 |
| IdenticalCatchBranches | 'catch' branch identical to 'InvalidRemoteException' branch | 302–305 |
| IdenticalCatchBranches | 'catch' branch identical to 'InvalidRemoteException' branch | 306–309 |
| IdenticalCatchBranches | 'catch' branch identical to 'InvalidRemoteException' branch | 368–372 |
| IdenticalCatchBranches | 'catch' branch identical to 'InvalidRemoteException' branch | 373–376 |
| IdenticalCatchBranches | 'catch' branch identical to 'InvalidRemoteException' branch | 377–380 |
| ExcessiveMethodLength | Avoid really long methods. | 411–526 |
| CyclomaticComplexity | The method 'rollbackRelease(WorkflowReleaseContext, Locale)' has a cyclomatic complexity of 15. | 411–526 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 459–466 |
| IdenticalCatchBranches | 'catch' branch identical to 'InvalidRemoteException' branch | 493–497 |
| IdenticalCatchBranches | 'catch' branch identical to 'InvalidRemoteException' branch | 498–501 |
| IdenticalCatchBranches | 'catch' branch identical to 'InvalidRemoteException' branch | 502–505 |
| IdenticalCatchBranches | 'catch' branch identical to 'InvalidRemoteException' branch | 582–586 |
| IdenticalCatchBranches | 'catch' branch identical to 'InvalidRemoteException' branch | 587–590 |
| IdenticalCatchBranches | 'catch' branch identical to 'InvalidRemoteException' branch | 591–594 |
| Rule | Violation | Line |
|---|---|---|
| ExcessiveImports | A high number of imports can indicate a high degree of coupling within an object. | 34–412 |
| MissingOverride | The method 'fetchPom(Site, String, String)' is missing an @Override annotation. | 92–112 |
| AvoidLiteralsInIfCondition | Avoid using Literals in Conditional Statements | 106 |
| MissingOverride | The method 'getLastRelease(Site, String, String)' is missing an @Override annotation. | 125–160 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 146 |
| UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 173 |
| AvoidCatchingGenericException | Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 262 |
| AvoidCatchingGenericException | Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 310 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 355 |
| CompareObjectsWithEquals | Use equals() to compare object references. | 357 |
| AvoidCatchingGenericException | Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 371 |
| Rule | Violation | Line |
|---|---|---|
| UseUtilityClass | All methods are static. Consider using a utility class instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning. | 44–104 |
| UncommentedEmptyConstructor | Document empty constructor | 58–61 |
| UnnecessaryConstructor | Avoid unnecessary constructors - the compiler will generate these for you | 58–61 |
| Rule | Violation | Line |
|---|---|---|
| RedundantFieldInitializer | Avoid using redundant field initializer for 'STATUS_ERROR' | 52 |
| RedundantFieldInitializer | Avoid using redundant field initializer for 'ERROR_TYPE_INFO' | 58 |
| AvoidStringBufferField | StringBuffers can grow quite a lot, and so may become a source of memory leak (if the owning class has a long life time). | 64 |
| UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 88 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 88 |
| CloneMethodReturnTypeMustMatchClassName | The return type of the clone() method must be the class name when implements Cloneable | 158–167 |
| Rule | Violation | Line |
|---|---|---|
| ShortVariable | Avoid variables with short names like t | 78 |
| Rule | Violation | Line |
|---|---|---|
| UseUtilityClass | All methods are static. Consider using a utility class instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning. | 66–363 |
| CyclomaticComplexity | The method 'updateAppInfoFile(String, String, CommandResult)' has a cyclomatic complexity of 12. | 185–269 |
| ShortVariable | Avoid variables with short names like br | 188 |
| AvoidLiteralsInIfCondition | Avoid using Literals in Conditional Statements | 200 |
| CollapsibleIfStatements | These nested if statements could be combined | 200–213 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 203–212 |
| InefficientStringBuffering | Avoid concatenating nonliterals in a StringBuffer/StringBuilder constructor or append(). | 216 |
| AvoidCatchingGenericException | Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 220 |
| ShortVariable | Avoid variables with short names like fw | 244 |
| AvoidCatchingGenericException | Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 250 |
| ShortVariable | Avoid variables with short names like fw | 284 |
| ShortVariable | Avoid variables with short names like sw | 301 |
| ShortVariable | Avoid variables with short names like tf | 304 |
| AvoidCatchingGenericException | Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 319 |
| AvoidPrintStackTrace | Avoid printStackTrace(); use a logger call instead. | 334 |
| CommentDefaultAccessModifier | To avoid mistakes add a comment at the beginning of the ContextFileFilter nested class if you want a default access modifier | 345–361 |
| MissingOverride | The method 'accept(File, String)' is missing an @Override annotation. | 357–360 |
| Rule | Violation | Line |
|---|---|---|
| GodClass | Possible God Class (WMC=54, ATFD=68, TCC=0.000%) | 64–563 |
| UseUtilityClass | All methods are static. Consider using a utility class instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning. | 65–563 |
| TooManyMethods | This class has too many methods, consider refactoring it. | 65–563 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 118–129 |
| ShortVariable | Avoid variables with short names like e | 238 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 241–248 |
| AvoidUncheckedExceptionsInSignatures | A method or constructor should not explicitly declare unchecked exceptions in its 'throws' clause | 271 |
| ShortVariable | Avoid variables with short names like e | 271 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 274–281 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 291–298 |
| AvoidUncheckedExceptionsInSignatures | A method or constructor should not explicitly declare unchecked exceptions in its 'throws' clause | 311 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 332 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 377 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 439 |
| ForLoopCanBeForeach | This for loop can be replaced by a foreach loop | 463–473 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 487 |
| CommentRequired | Public method and constructor comments are required | 531–539 |
| CommentRequired | Public method and constructor comments are required | 541–561 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 546–558 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 551–558 |
| Rule | Violation | Line |
|---|---|---|
| UseUtilityClass | All methods are static. Consider using a utility class instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning. | 48–160 |
| InefficientStringBuffering | Avoid concatenating nonliterals in a StringBuffer/StringBuilder constructor or append(). | 82 |
| UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 141 |
| Rule | Violation | Line |
|---|---|---|
| ExcessiveImports | A high number of imports can indicate a high degree of coupling within an object. | 34–788 |
| GodClass | Possible God Class (WMC=69, ATFD=39, TCC=0.000%) | 89–788 |
| UseUtilityClass | All methods are static. Consider using a utility class instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning. | 90–788 |
| UseObjectForClearerAPI | Rather than using a lot of String arguments, consider using a container object for those values. | 118–119 |
| IdenticalCatchBranches | 'catch' branch identical to 'InvalidRemoteException' branch | 145–149 |
| IdenticalCatchBranches | 'catch' branch identical to 'InvalidRemoteException' branch | 150–153 |
| IdenticalCatchBranches | 'catch' branch identical to 'InvalidRemoteException' branch | 154–158 |
| IdenticalCatchBranches | 'catch' branch identical to 'InvalidRemoteException' branch | 193–197 |
| IdenticalCatchBranches | 'catch' branch identical to 'InvalidRemoteException' branch | 199–202 |
| IdenticalCatchBranches | 'catch' branch identical to 'InvalidRemoteException' branch | 229–233 |
| IdenticalCatchBranches | 'catch' branch identical to 'InvalidRemoteException' branch | 235–238 |
| IdenticalCatchBranches | 'catch' branch identical to 'RefAlreadyExistsException' branch | 267–270 |
| IdenticalCatchBranches | 'catch' branch identical to 'RefAlreadyExistsException' branch | 271–274 |
| IdenticalCatchBranches | 'catch' branch identical to 'RefAlreadyExistsException' branch | 275–278 |
| IdenticalCatchBranches | 'catch' branch identical to 'RefAlreadyExistsException' branch | 279–282 |
| UnnecessaryLocalBeforeReturn | Consider simply returning the value vs storing it in local variable 'mergeResult' | 400 |
| ShortVariable | Avoid variables with short names like i | 419 |
| UseStringBufferForStringAppends | Prefer StringBuilder (non-synchronized) or StringBuffer (synchronized) over += for concatenating strings | 424 |
| UseStringBufferForStringAppends | Prefer StringBuilder (non-synchronized) or StringBuffer (synchronized) over += for concatenating strings | 425 |
| UseStringBufferForStringAppends | Prefer StringBuilder (non-synchronized) or StringBuffer (synchronized) over += for concatenating strings | 426 |
| ShortVariable | Avoid variables with short names like i | 445 |
| UseObjectForClearerAPI | Rather than using a lot of String arguments, consider using a container object for those values. | 527 |
| UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 550 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 550 |
| IdenticalCatchBranches | 'catch' branch identical to 'HttpAccessException' branch | 565–568 |
| UseObjectForClearerAPI | Rather than using a lot of String arguments, consider using a container object for those values. | 588 |
| ShortVariable | Avoid variables with short names like i | 626 |
| ForLoopCanBeForeach | This for loop can be replaced by a foreach loop | 644–653 |
| UnusedLocalVariable | Avoid unused local variables such as 'tagName'. | 647 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 711 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 712 |
| CommentRequired | Public method and constructor comments are required | 736–787 |
| UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 747 |
| Rule | Violation | Line |
|---|---|---|
| UnusedPrivateField | Avoid unused private fields such as 'bCancelled'. | 44 |
| SingularField | Perhaps 'bCancelled' could be replaced by a local variable. | 44 |
| UnnecessaryConstructor | Avoid unnecessary constructors - the compiler will generate these for you | 49–51 |
| UncommentedEmptyConstructor | Document empty constructor | 49–51 |
| Rule | Violation | Line |
|---|---|---|
| UseObjectForClearerAPI | Rather than using a lot of String arguments, consider using a container object for those values. | 76–77 |
| UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 85 |
| Rule | Violation | Line |
|---|---|---|
| UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 66 |
| LooseCoupling | Avoid using implementation types like 'ArrayList'; use the interface instead | 66 |
| ImmutableField | Private field '_listDependencies' could be made final; it is only initialized in the declaration or constructor. | 66 |
| LinguisticNaming | Linguistics Antipattern - The variable 'isPOM' indicates linguistically it is a boolean, but it is 'InputSource' | 90 |
| LinguisticNaming | Linguistics Antipattern - The variable 'isPOM' indicates linguistically it is a boolean, but it is 'InputSource' | 125 |
| ShortVariable | Avoid variables with short names like jc | 238 |
| ShortVariable | Avoid variables with short names like u | 239 |
| Rule | Violation | Line |
|---|---|---|
| UseUtilityClass | All methods are static. Consider using a utility class instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning. | 65–274 |
| CyclomaticComplexity | The method 'updateSiteAfterTag(Site, String)' has a cyclomatic complexity of 10. | 163–227 |
| CollapsibleIfStatements | These nested if statements could be combined | 190–193 |
| AvoidDeeplyNestedIfStmts | Deeply nested if..then statements are hard to read | 190–193 |
| ShortVariable | Avoid variables with short names like jc | 245 |
| ShortVariable | Avoid variables with short names like m | 246 |
| ShortVariable | Avoid variables with short names like jc | 268 |
| ShortVariable | Avoid variables with short names like u | 269 |
| Rule | Violation | Line |
|---|---|---|
| UnusedPrivateField | Avoid unused private fields such as 'bCancelled'. | 49 |
| SingularField | Perhaps 'bCancelled' could be replaced by a local variable. | 49 |
| Rule | Violation | Line |
|---|---|---|
| SingularField | Perhaps 'bCancelled' could be replaced by a local variable. | 48 |
| UnusedPrivateField | Avoid unused private fields such as 'bCancelled'. | 48 |
| Rule | Violation | Line |
|---|---|---|
| UnusedPrivateField | Avoid unused private fields such as 'bCancelled'. | 48 |
| SingularField | Perhaps 'bCancelled' could be replaced by a local variable. | 48 |
| Rule | Violation | Line |
|---|---|---|
| ExcessiveImports | A high number of imports can indicate a high degree of coupling within an object. | 34–508 |
| UnusedPrivateField | Avoid unused private fields such as 'MESSAGE_ERROR_SVN'. | 86 |
| UnusedPrivateField | Avoid unused private fields such as 'CONSTANTE_SLASH'. | 89 |
| UnusedPrivateField | Avoid unused private fields such as 'logger'. | 92 |
| UseObjectForClearerAPI | Rather than using a lot of String arguments, consider using a container object for those values. | 163 |
| CollapsibleIfStatements | These nested if statements could be combined | 207–212 |
| CommentRequired | Public method and constructor comments are required | 222–225 |
| MissingOverride | The method 'checkCancelled()' is missing an @Override annotation. | 222–225 |
| CommentRequired | Public method and constructor comments are required | 227–230 |
| MissingOverride | The method 'handleEvent(SVNEvent, double)' is missing an @Override annotation. | 227–230 |
| ShortVariable | Avoid variables with short names like sw | 245 |
| ShortVariable | Avoid variables with short names like pw | 246 |
| UnusedLocalVariable | Avoid unused local variables such as 'errorLog'. | 249 |
| EmptyCatchBlock | Avoid empty catch blocks | 258–262 |
| AvoidCatchingGenericException | Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 269 |
| ShortVariable | Avoid variables with short names like sw | 273 |
| ShortVariable | Avoid variables with short names like pw | 274 |
| UnusedLocalVariable | Avoid unused local variables such as 'errorLog'. | 277 |
| EmptyCatchBlock | Avoid empty catch blocks | 286–290 |
| CommentRequired | Public method and constructor comments are required | 321–331 |
| MissingOverride | The method 'handleDirEntry(SVNDirEntry)' is missing an @Override annotation. | 321–331 |
| CollapsibleIfStatements | These nested if statements could be combined | 326–329 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 350 |
| UseObjectForClearerAPI | Rather than using a lot of String arguments, consider using a container object for those values. | 413 |
| Rule | Violation | Line |
|---|---|---|
| GodClass | Possible God Class (WMC=47, ATFD=10, TCC=30.333%) | 47–542 |
| UncommentedEmptyConstructor | Document empty constructor | 86–88 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 238–245 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 277 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 297–308 |
| AvoidCatchingGenericException | Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 310 |
| AvoidDuplicateLiterals | The String literal "Error parsing version " appears 5 times in this file; the first occurrence is on line 440 | 440 |
| AvoidDuplicateLiterals | The String literal " : " appears 5 times in this file; the first occurrence is on line 440 | 440 |
| Rule | Violation | Line |
|---|---|---|
| MissingSerialVersionUID | Classes implementing Serializable should set a serialVersionUID | 40–55 |
| Rule | Violation | Line |
|---|---|---|
| MissingSerialVersionUID | Classes implementing Serializable should set a serialVersionUID | 70–615 |
| NullAssignment | Assigning an Object to null is a code smell. Consider refactoring. | 165 |
| NullAssignment | Assigning an Object to null is a code smell. Consider refactoring. | 166 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 207 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 449 |
| Rule | Violation | Line |
|---|---|---|
| MissingSerialVersionUID | Classes implementing Serializable should set a serialVersionUID | 65–316 |
| CommentDefaultAccessModifier | To avoid mistakes add a comment at the beginning of the _paginatorComponents field if you want a default access modifier | 126 |
| DefaultPackage | Use explicit scoping instead of the default package private level | 126 |
| CyclomaticComplexity | The method 'getManageComponent(HttpServletRequest)' has a cyclomatic complexity of 11. | 137–173 |
| UnusedLocalVariable | Avoid unused local variables such as 'user'. | 145 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 145 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 147 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 167 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 169 |
| UnnecessaryAnnotationValueElement | Avoid the use of value in annotations when its the only element | 247 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 255 |
| UnusedLocalVariable | Avoid unused local variables such as 'component'. | 255 |
| UnusedLocalVariable | Avoid unused local variables such as 'component'. | 277 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 277 |
| LinguisticNaming | Linguistics Antipattern - The setter 'setReleaserUser' should not return any type except void linguistically | 282–295 |
| Rule | Violation | Line |
|---|---|---|
| ExcessiveImports | A high number of imports can indicate a high degree of coupling within an object. | 34–701 |
| MissingSerialVersionUID | Classes implementing Serializable should set a serialVersionUID | 74–701 |
| TooManyMethods | This class has too many methods, consider refactoring it. | 75–701 |
| NullAssignment | Assigning an Object to null is a code smell. Consider refactoring. | 217 |
| UnnecessaryAnnotationValueElement | Avoid the use of value in annotations when its the only element | 266 |
| CyclomaticComplexity | The method 'getConfirmReleaseSite(HttpServletRequest)' has a cyclomatic complexity of 11. | 267–313 |
| NPathComplexity | The method 'getConfirmReleaseSite(HttpServletRequest)' has an NPath complexity of 324 | 267–313 |
| UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 272 |
| UnnecessaryAnnotationValueElement | Avoid the use of value in annotations when its the only element | 322 |
| UnnecessaryAnnotationValueElement | Avoid the use of value in annotations when its the only element | 349 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 357–376 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 361–370 |
| UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 505 |
| UnnecessaryAnnotationValueElement | Avoid the use of value in annotations when its the only element | 562 |
| UnnecessaryLocalBeforeReturn | Consider simply returning the value vs storing it in local variable 'strTemplate' | 575 |
| UnnecessaryAnnotationValueElement | Avoid the use of value in annotations when its the only element | 633 |
| UnusedLocalVariable | Avoid unused local variables such as 'component'. | 641 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 641 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 662 |
| UnusedLocalVariable | Avoid unused local variables such as 'component'. | 662 |
| LinguisticNaming | Linguistics Antipattern - The setter 'setReleaserUser' should not return any type except void linguistically | 668–681 |
| Rule | Violation | Line |
|---|---|---|
| MissingSerialVersionUID | Classes implementing Serializable should set a serialVersionUID | 49–99 |
| SingularField | Perhaps '_nDefaultItemsPerPage' could be replaced by a local variable. | 62 |
| Rule | Violation | Line |
|---|---|---|
| UnusedImports | Avoid unused imports such as 'fr.paris.lutece.plugins.releaser.util.github.GitUtils' | 39 |
| Rule | Violation | Line |
|---|---|---|
| UnusedImports | Avoid unused imports such as 'org.apache.commons.lang3.StringUtils' | 36 |
| Rule | Violation | Line |
|---|---|---|
| UnusedImports | Avoid unused imports such as 'fr.paris.lutece.util.ReferenceList' | 72 |
| Rule | Violation | Line |
|---|---|---|
| ShortClassName | Avoid short class names like Site | 51–612 |
| Rule | Violation | Line |
|---|---|---|
| UnusedImports | Avoid unused imports such as 'fr.paris.lutece.util.ReferenceList' | 72 |
| Rule | Violation | Line |
|---|---|---|
| UnusedImports | Avoid unused imports such as 'fr.paris.lutece.util.ReferenceList' | 73 |
| Rule | Violation | Line |
|---|---|---|
| UnusedImports | Avoid unused imports such as 'fr.paris.lutece.plugins.releaser.business.Site' | 44 |
| Rule | Violation | Line |
|---|---|---|
| UnusedImports | Avoid unused imports such as 'com.atlassian.jira.rest.client.api.domain.IssueField' | 51 |
| Rule | Violation | Line |
|---|---|---|
| UnusedImports | Avoid unused imports such as 'fr.paris.lutece.util.string.StringUtil' | 56 |
| Rule | Violation | Line |
|---|---|---|
| UnusedImports | Avoid unused imports such as 'fr.paris.lutece.portal.service.plugin.Plugin' | 72 |
| Rule | Violation | Line |
|---|---|---|
| UnusedImports | Avoid unused imports such as 'java.io.IOException' | 37 |
| UnusedImports | Avoid unused imports such as 'java.io.PrintWriter' | 38 |
| UnusedImports | Avoid unused imports such as 'java.io.StringWriter' | 39 |
| UnusedImports | Avoid unused imports such as 'org.apache.commons.lang3.ObjectUtils' | 44 |
| UnusedImports | Avoid unused imports such as 'org.apache.commons.lang3.StringUtils' | 45 |
| UnusedImports | Avoid unused imports such as 'org.tmatesoft.svn.core.SVNCancelException' | 46 |
| UnusedImports | Avoid unused imports such as 'org.tmatesoft.svn.core.SVNException' | 47 |
| UnusedImports | Avoid unused imports such as 'org.tmatesoft.svn.core.wc.ISVNEventHandler' | 49 |
| UnusedImports | Avoid unused imports such as 'org.tmatesoft.svn.core.wc.SVNEvent' | 50 |
| UnusedImports | Avoid unused imports such as 'org.tmatesoft.svn.core.wc.SVNEventAction' | 51 |
| UnusedImports | Avoid unused imports such as 'fr.paris.lutece.plugins.releaser.business.RepositoryType' | 54 |
| UnusedImports | Avoid unused imports such as 'fr.paris.lutece.plugins.releaser.util.svn.ReleaseSvnCopyClient' | 65 |
| Rule | Violation | Line |
|---|---|---|
| UnusedImports | Avoid unused imports such as 'javax.xml.parsers.ParserConfigurationException' | 48 |
| UnusedImports | Avoid unused imports such as 'javax.xml.transform.TransformerException' | 50 |
| UnusedImports | Avoid unused imports such as 'org.eclipse.jgit.api.errors.NoFilepatternException' | 55 |
| UnusedImports | Avoid unused imports such as 'org.xml.sax.SAXException' | 59 |
| Rule | Violation | Line |
|---|---|---|
| UnusedImports | Avoid unused imports such as 'java.io.FileInputStream' | 36 |
| UnusedImports | Avoid unused imports such as 'java.io.FileNotFoundException' | 37 |
| UnnecessaryFullyQualifiedName | Unnecessary use of fully qualified name 'fr.paris.lutece.plugins.releaser.business.jaxb.maven.Model.Dependencies' due to existing import 'fr.paris.lutece.plugins.releaser.business.jaxb.maven.Model' | 95 |
| Rule | Violation | Line |
|---|---|---|
| UnusedImports | Avoid unused imports such as 'java.util.Iterator' | 42 |
| UnusedImports | Avoid unused imports such as 'fr.paris.lutece.portal.service.i18n.I18nService' | 56 |
| UnnecessaryFullyQualifiedName | Unnecessary use of fully qualified name 'fr.paris.lutece.plugins.releaser.business.jaxb.maven.Model.Dependencies' due to existing import 'fr.paris.lutece.plugins.releaser.business.jaxb.maven.Model' | 92 |
| UnnecessaryFullyQualifiedName | Unnecessary use of fully qualified name 'fr.paris.lutece.plugins.releaser.business.jaxb.maven.Model.Dependencies' due to existing import 'fr.paris.lutece.plugins.releaser.business.jaxb.maven.Model' | 178 |
| Rule | Violation | Line |
|---|---|---|
| UnusedImports | Avoid unused imports such as 'fr.paris.lutece.portal.service.i18n.I18nService' | 49 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 3 | 57–75 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 3 | 100–107 |
| NullAssignment | Assigning an Object to null is a code smell. Consider refactoring. | 3 | 115 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| FieldNamingConventions | The field name 'permissions' doesn't match '_[a-z][a-zA-Z0-9]*' | 1 | 59 |
| LooseCoupling | Avoid using implementation types like 'HashMap'; use the interface instead | 3 | 59 |
| LooseCoupling | Avoid using implementation types like 'HashMap'; use the interface instead | 3 | 170 |
| LooseCoupling | Avoid using implementation types like 'HashMap'; use the interface instead | 3 | 175 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 3 | 158 |
| UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 3 | 184 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| ExcessivePublicCount | This class has a bunch of public methods and attributes | 3 | 34–721 |
| UnusedImports | Avoid unused imports such as 'fr.paris.lutece.plugins.releaser.util.github.GitUtils' | 4 | 39 |
| TooManyFields | Too many fields | 3 | 47–721 |
| FieldNamingConventions | The field name 'permissions' doesn't match '_[a-z][a-zA-Z0-9]*' | 1 | 54 |
| LooseCoupling | Avoid using implementation types like 'HashMap'; use the interface instead | 3 | 54 |
| UnusedPrivateField | Avoid unused private fields such as '_strDescription'. | 3 | 82 |
| MissingOverride | The method 'getArtifactId()' is missing an @Override annotation. | 3 | 143–146 |
| MissingOverride | The method 'getTargetVersion()' is missing an @Override annotation. | 3 | 227–230 |
| SimplifyBooleanReturns | Avoid unnecessary if..then..else statements when returning booleans | 3 | 440–444 |
| FormalParameterNamingConventions | The method parameter name '_strScmDeveloperConnection' doesn't match '[a-z][a-zA-Z0-9]*' | 1 | 464 |
| FormalParameterNamingConventions | The method parameter name '_bUpgrade' doesn't match '[a-z][a-zA-Z0-9]*' | 1 | 495 |
| FormalParameterNamingConventions | The method parameter name '_bDowngrade' doesn't match '[a-z][a-zA-Z0-9]*' | 1 | 516 |
| FormalParameterNamingConventions | The method parameter name '_strLastAvailableSnapshotVersion' doesn't match '[a-z][a-zA-Z0-9]*' | 1 | 547 |
| FormalParameterNamingConventions | The method parameter name '_bErrorLastRelease' doesn't match '[a-z][a-zA-Z0-9]*' | 1 | 568 |
| FormalParameterNamingConventions | The method parameter name '_strName' doesn't match '[a-z][a-zA-Z0-9]*' | 1 | 589 |
| FormalParameterNamingConventions | The method parameter name '_strCloneUrl' doesn't match '[a-z][a-zA-Z0-9]*' | 1 | 610 |
| FormalParameterNamingConventions | The method parameter name '_strTweetMessage' doesn't match '[a-z][a-zA-Z0-9]*' | 1 | 652 |
| LooseCoupling | Avoid using implementation types like 'HashMap'; use the interface instead | 3 | 681 |
| LooseCoupling | Avoid using implementation types like 'HashMap'; use the interface instead | 3 | 686 |
| CommentRequired | Public method and constructor comments are required | 3 | 691–694 |
| CommentRequired | Public method and constructor comments are required | 3 | 696–699 |
| CommentRequired | Public method and constructor comments are required | 3 | 701–704 |
| FormalParameterNamingConventions | The method parameter name '_strBranchReleaseFrom' doesn't match '[a-z][a-zA-Z0-9]*' | 1 | 706 |
| CommentRequired | Public method and constructor comments are required | 3 | 706–709 |
| CommentRequired | Public method and constructor comments are required | 3 | 711–714 |
| FormalParameterNamingConventions | The method parameter name '_strBranchReleaseVersion' doesn't match '[a-z][a-zA-Z0-9]*' | 1 | 716 |
| CommentRequired | Public method and constructor comments are required | 3 | 716–719 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UnusedImports | Avoid unused imports such as 'org.apache.commons.lang3.StringUtils' | 4 | 36 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UnusedImports | Avoid unused imports such as 'fr.paris.lutece.util.ReferenceList' | 4 | 72 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| LooseCoupling | Avoid using implementation types like 'HashMap'; use the interface instead | 3 | 54 |
| ImmutableField | Private field '_mapCredential' could be made final; it is only initialized in the declaration or constructor. | 3 | 54 |
| ImmutableField | Private field '_strLogin' could be made final; it is only initialized in the declaration or constructor. | 3 | 115 |
| FieldDeclarationsShouldBeAtStartOfClass | Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. | 3 | 115 |
| ImmutableField | Private field '_strPassword' could be made final; it is only initialized in the declaration or constructor. | 3 | 118 |
| FieldDeclarationsShouldBeAtStartOfClass | Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. | 3 | 118 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| ExcessivePublicCount | This class has a bunch of public methods and attributes | 3 | 34–612 |
| TooManyFields | Too many fields | 3 | 51–612 |
| ShortClassName | Avoid short class names like Site | 4 | 51–612 |
| LooseCoupling | Avoid using implementation types like 'HashMap'; use the interface instead | 3 | 62 |
| FieldNamingConventions | The field name 'permissions' doesn't match '_[a-z][a-zA-Z0-9]*' | 1 | 62 |
| ImmutableField | Private field '_listCurrentDependencies' could be made final; it is only initialized in the declaration or constructor. | 3 | 106 |
| ImmutableField | Private field '_listComponents' could be made final; it is only initialized in the declaration or constructor. | 3 | 109 |
| MissingOverride | The method 'getArtifactId()' is missing an @Override annotation. | 3 | 167–170 |
| MissingOverride | The method 'getScmUrl()' is missing an @Override annotation. | 3 | 209–212 |
| FormalParameterNamingConventions | The method parameter name '_strTagInfotmation' doesn't match '[a-z][a-zA-Z0-9]*' | 1 | 493 |
| FormalParameterNamingConventions | The method parameter name '_strGroupId' doesn't match '[a-z][a-zA-Z0-9]*' | 1 | 514 |
| FormalParameterNamingConventions | The method parameter name '_bTheme' doesn't match '[a-z][a-zA-Z0-9]*' | 1 | 535 |
| CommentRequired | Public method and constructor comments are required | 3 | 540–543 |
| CommentRequired | Public method and constructor comments are required | 3 | 545–548 |
| CommentRequired | Public method and constructor comments are required | 3 | 550–553 |
| CommentRequired | Public method and constructor comments are required | 3 | 555–558 |
| FormalParameterNamingConventions | The method parameter name '_strBranchReleaseFrom' doesn't match '[a-z][a-zA-Z0-9]*' | 1 | 555 |
| LooseCoupling | Avoid using implementation types like 'HashMap'; use the interface instead | 3 | 594 |
| LooseCoupling | Avoid using implementation types like 'HashMap'; use the interface instead | 3 | 599 |
| UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 3 | 602 |
| ControlStatementBraces | This statement should have braces | 3 | 602 |
| ControlStatementBraces | This statement should have braces | 3 | 604 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 3 | 182 |
| UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 3 | 214 |
| UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 3 | 252 |
| UnusedLocalVariable | Avoid unused local variables such as 'nIndex'. | 3 | 294 |
| ControlStatementBraces | This statement should have braces | 3 | 296 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| FormalParameterNamingConventions | The method parameter name '_dateBegin' doesn't match '[a-z][a-zA-Z0-9]*' | 1 | 181 |
| FormalParameterNamingConventions | The method parameter name '_dateEnd' doesn't match '[a-z][a-zA-Z0-9]*' | 1 | 202 |
| FormalParameterNamingConventions | The method parameter name '_strArtifactId' doesn't match '[a-z][a-zA-Z0-9]*' | 1 | 223 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UnusedImports | Avoid unused imports such as 'fr.paris.lutece.util.ReferenceList' | 4 | 72 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UnusedImports | Avoid unused imports such as 'fr.paris.lutece.util.ReferenceList' | 4 | 73 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| FormalParameterNamingConventions | The method parameter name '_nId' doesn't match '[a-z][a-zA-Z0-9]*' | 1 | 98 |
| FormalParameterNamingConventions | The method parameter name '_component' doesn't match '[a-z][a-zA-Z0-9]*' | 1 | 119 |
| FormalParameterNamingConventions | The method parameter name '_commandResult' doesn't match '[a-z][a-zA-Z0-9]*' | 1 | 140 |
| FormalParameterNamingConventions | The method parameter name '_releaserUser' doesn't match '[a-z][a-zA-Z0-9]*' | 1 | 194 |
| FormalParameterNamingConventions | The method parameter name '_strRefBranchRelease' doesn't match '[a-z][a-zA-Z0-9]*' | 1 | 215 |
| FormalParameterNamingConventions | The method parameter name '_strRefBranchReleaseFrom' doesn't match '[a-z][a-zA-Z0-9]*' | 1 | 236 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| CommentRequired | Header comments are required | 3 | 48–147 |
| DataClass | The class 'ClusterResourceIdService' is suspected to be a Data Class (WOC=0.000%, NOPA=4, NOAM=0, WMC=1) | 3 | 48–147 |
| CallSuperInConstructor | It is a good practice to call super() in a constructor | 3 | 71–74 |
| ShortVariable | Avoid variables with short names like rt | 3 | 80 |
| ShortVariable | Avoid variables with short names like p | 3 | 86 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UseUtilityClass | All methods are static. Consider using a utility class instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning. | 3 | 51–169 |
| UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 3 | 82 |
| UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 3 | 86 |
| ControlStatementBraces | This statement should have braces | 3 | 140 |
| MethodNamingConventions | The static method name 'IsAddClusterAuthorized' doesn't match '[a-z][a-zA-Z0-9]*' | 1 | 146–155 |
| CommentRequired | Public method and constructor comments are required | 3 | 146–155 |
| SimplifyBooleanReturns | Avoid unnecessary if..then..else statements when returning booleans | 3 | 149–152 |
| MethodNamingConventions | The static method name 'IsUserAuthorized' doesn't match '[a-z][a-zA-Z0-9]*' | 1 | 157–168 |
| CommentRequired | Public method and constructor comments are required | 3 | 157–168 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| CommentRequired | Header comments are required | 3 | 45–95 |
| CallSuperInConstructor | It is a good practice to call super() in a constructor | 3 | 56–59 |
| ShortVariable | Avoid variables with short names like rt | 3 | 65 |
| ShortVariable | Avoid variables with short names like p | 3 | 71 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| ExcessiveImports | A high number of imports can indicate a high degree of coupling within an object. | 3 | 34–574 |
| GodClass | Possible God Class (WMC=48, ATFD=64, TCC=0.526%) | 3 | 84–574 |
| UnusedPrivateField | Avoid unused private fields such as '_executor'. | 3 | 86 |
| SingularField | Perhaps '_executor' could be replaced by a local variable. | 3 | 86 |
| NonThreadSafeSingleton | Singleton is not thread safe | 3 | 109–113 |
| CommentRequired | Public method and constructor comments are required | 3 | 119–169 |
| NPathComplexity | The method 'setRemoteInformations(Component, boolean)' has an NPath complexity of 517 | 3 | 119–169 |
| MissingOverride | The method 'setRemoteInformations(Component, boolean)' is missing an @Override annotation. | 3 | 119–169 |
| CyclomaticComplexity | The method 'setRemoteInformations(Component, boolean)' has a cyclomatic complexity of 14. | 3 | 119–169 |
| AvoidDeeplyNestedIfStmts | Deeply nested if..then statements are hard to read | 3 | 138–141 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 3 | 150 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 3 | 151 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 3 | 152 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 3 | 153 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 3 | 154 |
| AvoidDeeplyNestedIfStmts | Deeply nested if..then statements are hard to read | 3 | 156–160 |
| MissingOverride | The method 'getLastReleaseVersion(String)' is missing an @Override annotation. | 3 | 176–181 |
| MissingOverride | The method 'setLastReleaseVersion(String, String)' is missing an @Override annotation. | 3 | 188–193 |
| MissingOverride | The method 'getLastReleaseNextSnapshotVersion(String)' is missing an @Override annotation. | 3 | 200–205 |
| MissingOverride | The method 'setLastReleaseNextSnapshotVersion(String, String)' is missing an @Override annotation. | 3 | 212–216 |
| CommentRequired | Public method and constructor comments are required | 3 | 242–245 |
| MissingOverride | The method 'release(Component, Locale, AdminUser, HttpServletRequest)' is missing an @Override annotation. | 3 | 242–245 |
| MissingOverride | The method 'isGitComponent(Component)' is missing an @Override annotation. | 3 | 247–251 |
| CommentRequired | Public method and constructor comments are required | 3 | 247–251 |
| CommentRequired | Public method and constructor comments are required | 3 | 253–259 |
| MissingOverride | The method 'init()' is missing an @Override annotation. | 3 | 253–259 |
| CyclomaticComplexity | The method 'updateRemoteInformations(Component)' has a cyclomatic complexity of 11. | 3 | 262–310 |
| MissingOverride | The method 'getSearchComponent(String, HttpServletRequest, Locale, String, String)' is missing an @Override annotation. | 3 | 312–340 |
| CommentRequired | Public method and constructor comments are required | 3 | 312–340 |
| UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 3 | 327–328 |
| UnusedFormalParameter | Avoid unused method parameters such as 'strPassword'. | 3 | 342 |
| UnusedFormalParameter | Avoid unused method parameters such as 'strUser'. | 3 | 342 |
| AvoidReassigningParameters | Avoid reassigning parameters such as 'component' | 2 | 365 |
| MissingOverride | The method 'loadComponent(Component, String, String, String)' is missing an @Override annotation. | 3 | 365–395 |
| CommentRequired | Public method and constructor comments are required | 3 | 365–395 |
| AvoidReassigningParameters | Avoid reassigning parameters such as 'component' | 2 | 365 |
| CommentRequired | Public method and constructor comments are required | 3 | 421–451 |
| MissingOverride | The method 'isErrorSnapshotComponentInformations(Component, String)' is missing an @Override annotation. | 3 | 421–451 |
| AvoidFileStream | Avoid instantiating FileInputStream, FileOutputStream, FileReader, or FileWriter | 1 | 432 |
| MissingOverride | The method 'changeNextReleaseVersion(Component)' is missing an @Override annotation. | 3 | 459–471 |
| CommentRequired | Public method and constructor comments are required | 3 | 473–482 |
| MethodNamingConventions | The static method name 'IsSearchComponentAuthorized' doesn't match '[a-z][a-zA-Z0-9]*' | 1 | 473–482 |
| SimplifyBooleanReturns | Avoid unnecessary if..then..else statements when returning booleans | 3 | 476–479 |
| CommentRequired | Public method and constructor comments are required | 3 | 525–572 |
| AvoidReassigningParameters | Avoid reassigning parameters such as 'component' | 2 | 525 |
| MissingOverride | The method 'getLastBranchVersion(Component, String, ReleaserUser)' is missing an @Override annotation. | 3 | 525–572 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| DoNotUseThreads | To be compliant to J2EE, a webapp should not use any thread. | 3 | 46 |
| ImmutableField | Private field '_component' could be made final; it is only initialized in the declaration or constructor. | 3 | 49 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UnusedImports | Avoid unused imports such as 'fr.paris.lutece.plugins.releaser.business.Site' | 4 | 44 |
| CommentRequired | Public method and constructor comments are required | 3 | 231 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UnnecessaryModifier | Unnecessary modifiers 'public abstract' on method 'init': the method is declared in an interface type | 3 | 48 |
| UnnecessaryModifier | Unnecessary modifiers 'public abstract' on method 'updateComponentVersions': the method is declared in an interface type | 3 | 58 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UseObjectForClearerAPI | Rather than using a lot of String arguments, consider using a container object for those values. | 3 | 81–82 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| TooManyMethods | This class has too many methods, consider refactoring it. | 3 | 49–221 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| ExcessiveImports | A high number of imports can indicate a high degree of coupling within an object. | 3 | 34–286 |
| UnusedImports | Avoid unused imports such as 'com.atlassian.jira.rest.client.api.domain.IssueField' | 4 | 51 |
| FieldNamingConventions | The static field name 'URL_JIRA_SERVER' doesn't match '_[a-z][a-zA-Z0-9]*' | 1 | 87 |
| FieldNamingConventions | The static field name 'JIRA_USER' doesn't match '_[a-z][a-zA-Z0-9]*' | 1 | 90 |
| FieldNamingConventions | The static field name 'JIRA_USER_PWD' doesn't match '_[a-z][a-zA-Z0-9]*' | 1 | 93 |
| UncommentedEmptyConstructor | Document empty constructor | 3 | 110–113 |
| UnnecessaryConstructor | Avoid unnecessary constructors - the compiler will generate these for you | 3 | 110–113 |
| NonThreadSafeSingleton | Singleton is not thread safe | 3 | 122–126 |
| CyclomaticComplexity | The method 'updateComponentVersions(Component, CommandResult)' has a cyclomatic complexity of 12. | 3 | 185–284 |
| AvoidSynchronizedAtMethodLevel | Use block level rather than method level synchronization | 3 | 185–284 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 3 | 191–282 |
| UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 3 | 229 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 3 | 230 |
| UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 3 | 230 |
| AvoidCatchingGenericException | Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 3 | 259 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UnusedImports | Avoid unused imports such as 'fr.paris.lutece.util.string.StringUtil' | 4 | 56 |
| ClassWithOnlyPrivateConstructorsShouldBeFinal | A class which only has private constructors should be final | 1 | 62–291 |
| NonThreadSafeSingleton | Singleton is not thread safe | 3 | 87–91 |
| MissingOverride | The method 'init()' is missing an @Override annotation. | 3 | 100–106 |
| MissingOverride | The method 'mvnSiteAssembly(String, String, String, SvnUser, CommandResult)' is missing an @Override annotation. | 3 | 128–138 |
| UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 3 | 133 |
| AvoidSynchronizedAtMethodLevel | Use block level rather than method level synchronization | 3 | 176–224 |
| AddEmptyString | Do not add empty strings | 3 | 195 |
| MissingOverride | The method 'consumeLine(String)' is missing an @Override annotation. | 3 | 206–209 |
| CommentRequired | Public method and constructor comments are required | 3 | 206–209 |
| InefficientStringBuffering | Avoid concatenating nonliterals in a StringBuffer/StringBuilder constructor or append(). | 3 | 208 |
| AvoidCatchingGenericException | Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 3 | 217 |
| MissingOverride | The method 'mvnReleasePerform(String, String, String, CommandResult, boolean)' is missing an @Override annotation. | 3 | 239–253 |
| SystemPrintln | System.out.println is used | 2 | 246 |
| UseObjectForClearerAPI | Rather than using a lot of String arguments, consider using a container object for those values. | 3 | 274–275 |
| MissingOverride | The method 'mvnReleasePrepare(String, String, String, String, String, String, CommandResult)' is missing an @Override annotation. | 3 | 274–289 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| DoNotUseThreads | To be compliant to J2EE, a webapp should not use any thread. | 3 | 59 |
| ImmutableField | Private field '_nIdWorkflow' could be made final; it is only initialized in the declaration or constructor. | 3 | 66 |
| ImmutableField | Private field '_wfContext' could be made final; it is only initialized in the declaration or constructor. | 3 | 69 |
| ImmutableField | Private field '_request' could be made final; it is only initialized in the declaration or constructor. | 3 | 72 |
| ImmutableField | Private field '_user' could be made final; it is only initialized in the declaration or constructor. | 3 | 75 |
| ImmutableField | Private field '_locale' could be made final; it is only initialized in the declaration or constructor. | 3 | 78 |
| MissingOverride | The method 'run()' is missing an @Override annotation. | 3 | 107–178 |
| UnusedLocalVariable | Avoid unused local variables such as 'state'. | 3 | 110 |
| AvoidBranchingStatementAsLastInLoop | Avoid using a branching statement as the last in a loop. | 2 | 160 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| CallSuperInConstructor | It is a good practice to call super() in a constructor | 3 | 72–75 |
| ShortVariable | Avoid variables with short names like rt | 3 | 80 |
| ShortVariable | Avoid variables with short names like p | 3 | 86 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| ExcessiveImports | A high number of imports can indicate a high degree of coupling within an object. | 3 | 34–873 |
| UnusedImports | Avoid unused imports such as 'fr.paris.lutece.portal.service.plugin.Plugin' | 4 | 72 |
| GodClass | Possible God Class (WMC=95, ATFD=142, TCC=0.000%) | 3 | 83–873 |
| CyclomaticComplexity | The class 'SiteService' has a total cyclomatic complexity of 95 (highest 14). | 3 | 83–873 |
| TooManyMethods | This class has too many methods, consider refactoring it. | 3 | 84–873 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 3 | 127–143 |
| UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 3 | 227 |
| IdenticalCatchBranches | 'catch' branch identical to 'InterruptedException' branch | 3 | 246–250 |
| BooleanInstantiation | Avoid instantiating Boolean objects; reference Boolean.TRUE or Boolean.FALSE or call Boolean.valueOf() instead. | 2 | 339 |
| CyclomaticComplexity | The method 'buildReleaseComments(Component, Locale)' has a cyclomatic complexity of 14. | 3 | 428–501 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 3 | 439–500 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 3 | 472–488 |
| UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 3 | 630 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 3 | 630 |
| AvoidFileStream | Avoid instantiating FileInputStream, FileOutputStream, FileReader, or FileWriter | 1 | 764 |
| IdenticalCatchBranches | 'catch' branch identical to 'FileNotFoundException' branch | 3 | 781–785 |
| CommentRequired | Public method and constructor comments are required | 3 | 790–849 |
| UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 3 | 793 |
| UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 3 | 802 |
| MethodNamingConventions | The static method name 'IsUserAuthorized' doesn't match '[a-z][a-zA-Z0-9]*' | 1 | 851–862 |
| CommentRequired | Public method and constructor comments are required | 3 | 851–862 |
| MethodNamingConventions | The static method name 'IsSiteAlreadyExist' doesn't match '[a-z][a-zA-Z0-9]*' | 1 | 864–871 |
| CommentRequired | Public method and constructor comments are required | 3 | 864–871 |
| SimplifyBooleanReturns | Avoid unnecessary if..then..else statements when returning booleans | 3 | 867–868 |
| ControlStatementBraces | This statement should have braces | 3 | 868 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| RedundantFieldInitializer | Avoid using redundant field initializer for '_twitter' | 3 | 89 |
| RedundantFieldInitializer | Avoid using redundant field initializer for '_instance' | 3 | 92 |
| NonThreadSafeSingleton | Singleton is not thread safe | 3 | 101–105 |
| UnnecessaryConstructor | Avoid unnecessary constructors - the compiler will generate these for you | 3 | 113–116 |
| MissingOverride | The method 'sendTweet(String, CommandResult)' is missing an @Override annotation. | 3 | 126–144 |
| MissingOverride | The method 'init()' is missing an @Override annotation. | 3 | 149–167 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| ExcessiveImports | A high number of imports can indicate a high degree of coupling within an object. | 3 | 34–870 |
| GodClass | Possible God Class (WMC=62, ATFD=100, TCC=2.632%) | 3 | 83–870 |
| TooManyMethods | This class has too many methods, consider refactoring it. | 3 | 84–870 |
| ImmutableField | Private field '_mapWorkflowReleaseContext' could be made final; it is only initialized in the declaration or constructor. | 3 | 90 |
| UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 3 | 90 |
| LooseCoupling | Avoid using implementation types like 'HashMap'; use the interface instead | 3 | 90 |
| ImmutableField | Private field '_releaseInProgress' could be made final; it is only initialized in the declaration or constructor. | 3 | 96 |
| UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 3 | 96 |
| LooseCoupling | Avoid using implementation types like 'HashSet'; use the interface instead | 3 | 96 |
| AvoidSynchronizedAtMethodLevel | Use block level rather than method level synchronization | 3 | 112–134 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 3 | 122 |
| MissingOverride | The method 'saveWorkflowReleaseContext(WorkflowReleaseContext)' is missing an @Override annotation. | 3 | 160–198 |
| AvoidSynchronizedAtMethodLevel | Use block level rather than method level synchronization | 3 | 160–198 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 3 | 170–191 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 3 | 187 |
| MissingOverride | The method 'getListWorkflowReleaseContextHistory(String)' is missing an @Override annotation. | 3 | 232–261 |
| UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 3 | 235 |
| MissingOverride | The method 'getIdWorkflow(WorkflowReleaseContext)' is missing an @Override annotation. | 3 | 270–286 |
| NonThreadSafeSingleton | Singleton is not thread safe | 3 | 295–300 |
| CyclomaticComplexity | The method 'mergeDevelopMaster(WorkflowReleaseContext, Locale)' has a cyclomatic complexity of 14. | 3 | 313–411 |
| MissingOverride | The method 'mergeDevelopMaster(WorkflowReleaseContext, Locale)' is missing an @Override annotation. | 3 | 313–411 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 3 | 335–371 |
| IdenticalCatchBranches | 'catch' branch identical to 'InvalidRemoteException' branch | 3 | 380–384 |
| IdenticalCatchBranches | 'catch' branch identical to 'InvalidRemoteException' branch | 3 | 385–388 |
| IdenticalCatchBranches | 'catch' branch identical to 'InvalidRemoteException' branch | 3 | 389–392 |
| NcssCount | The method 'releasePrepareComponent(WorkflowReleaseContext, Locale)' has a NCSS line count of 71. | 3 | 421–579 |
| ExcessiveMethodLength | Avoid really long methods. | 3 | 421–579 |
| CyclomaticComplexity | The method 'releasePrepareComponent(WorkflowReleaseContext, Locale)' has a cyclomatic complexity of 13. | 3 | 421–579 |
| MissingOverride | The method 'releasePrepareComponent(WorkflowReleaseContext, Locale)' is missing an @Override annotation. | 3 | 421–579 |
| AvoidDuplicateLiterals | The String literal " to " appears 4 times in this file; the first occurrence is on line 462 | 3 | 462 |
| MissingOverride | The method 'releasePerformComponent(WorkflowReleaseContext, Locale)' is missing an @Override annotation. | 3 | 589–619 |
| AvoidDuplicateLiterals | The String literal " Release Perform" appears 4 times in this file; the first occurrence is on line 597 | 3 | 597 |
| MissingOverride | The method 'checkoutRepository(WorkflowReleaseContext, Locale)' is missing an @Override annotation. | 3 | 629–642 |
| MissingOverride | The method 'releasePrepareSite(WorkflowReleaseContext, Locale)' is missing an @Override annotation. | 3 | 652–716 |
| AvoidDuplicateLiterals | The String literal "...\n" appears 4 times in this file; the first occurrence is on line 665 | 3 | 665 |
| MissingOverride | The method 'sendTweet(WorkflowReleaseContext, Locale)' is missing an @Override annotation. | 3 | 726–737 |
| MissingOverride | The method 'updateJiraVersions(WorkflowReleaseContext, Locale)' is missing an @Override annotation. | 3 | 747–758 |
| MissingOverride | The method 'startWorkflowReleaseContext(WorkflowReleaseContext, int, Locale, HttpServletRequest, AdminUser)' is missing an @Override annotation. | 3 | 774–777 |
| MissingOverride | The method 'init()' is missing an @Override annotation. | 3 | 782–787 |
| MissingOverride | The method 'startReleaseInProgress(String)' is missing an @Override annotation. | 3 | 795–799 |
| MissingOverride | The method 'stopReleaseInProgress(String)' is missing an @Override annotation. | 3 | 807–811 |
| MissingOverride | The method 'isReleaseInProgress(String)' is missing an @Override annotation. | 3 | 820–824 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| MissingOverride | The method 'fetchPom(Site, String, String)' is missing an @Override annotation. | 3 | 85–98 |
| MissingOverride | The method 'getLastRelease(Site, String, String)' is missing an @Override annotation. | 3 | 111–138 |
| CyclomaticComplexity | The method 'doCheckoutRepository(WorkflowReleaseContext, String, String)' has a cyclomatic complexity of 11. | 3 | 152–240 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 3 | 187–198 |
| AvoidDuplicateLiterals | The String literal "/.git" appears 4 times in this file; the first occurrence is on line 283 | 3 | 283 |
| IdenticalCatchBranches | 'catch' branch identical to 'InvalidRemoteException' branch | 3 | 297–301 |
| IdenticalCatchBranches | 'catch' branch identical to 'InvalidRemoteException' branch | 3 | 302–305 |
| IdenticalCatchBranches | 'catch' branch identical to 'InvalidRemoteException' branch | 3 | 306–309 |
| IdenticalCatchBranches | 'catch' branch identical to 'InvalidRemoteException' branch | 3 | 368–372 |
| IdenticalCatchBranches | 'catch' branch identical to 'InvalidRemoteException' branch | 3 | 373–376 |
| IdenticalCatchBranches | 'catch' branch identical to 'InvalidRemoteException' branch | 3 | 377–380 |
| ExcessiveMethodLength | Avoid really long methods. | 3 | 411–526 |
| CyclomaticComplexity | The method 'rollbackRelease(WorkflowReleaseContext, Locale)' has a cyclomatic complexity of 15. | 3 | 411–526 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 3 | 459–466 |
| IdenticalCatchBranches | 'catch' branch identical to 'InvalidRemoteException' branch | 3 | 493–497 |
| IdenticalCatchBranches | 'catch' branch identical to 'InvalidRemoteException' branch | 3 | 498–501 |
| IdenticalCatchBranches | 'catch' branch identical to 'InvalidRemoteException' branch | 3 | 502–505 |
| IdenticalCatchBranches | 'catch' branch identical to 'InvalidRemoteException' branch | 3 | 582–586 |
| IdenticalCatchBranches | 'catch' branch identical to 'InvalidRemoteException' branch | 3 | 587–590 |
| IdenticalCatchBranches | 'catch' branch identical to 'InvalidRemoteException' branch | 3 | 591–594 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| ExcessiveImports | A high number of imports can indicate a high degree of coupling within an object. | 3 | 34–412 |
| UnusedImports | Avoid unused imports such as 'java.io.IOException' | 4 | 37 |
| UnusedImports | Avoid unused imports such as 'java.io.PrintWriter' | 4 | 38 |
| UnusedImports | Avoid unused imports such as 'java.io.StringWriter' | 4 | 39 |
| UnusedImports | Avoid unused imports such as 'org.apache.commons.lang3.ObjectUtils' | 4 | 44 |
| UnusedImports | Avoid unused imports such as 'org.apache.commons.lang3.StringUtils' | 4 | 45 |
| UnusedImports | Avoid unused imports such as 'org.tmatesoft.svn.core.SVNCancelException' | 4 | 46 |
| UnusedImports | Avoid unused imports such as 'org.tmatesoft.svn.core.SVNException' | 4 | 47 |
| UnusedImports | Avoid unused imports such as 'org.tmatesoft.svn.core.wc.ISVNEventHandler' | 4 | 49 |
| UnusedImports | Avoid unused imports such as 'org.tmatesoft.svn.core.wc.SVNEvent' | 4 | 50 |
| UnusedImports | Avoid unused imports such as 'org.tmatesoft.svn.core.wc.SVNEventAction' | 4 | 51 |
| UnusedImports | Avoid unused imports such as 'fr.paris.lutece.plugins.releaser.business.RepositoryType' | 4 | 54 |
| UnusedImports | Avoid unused imports such as 'fr.paris.lutece.plugins.releaser.util.svn.ReleaseSvnCopyClient' | 4 | 65 |
| MissingOverride | The method 'fetchPom(Site, String, String)' is missing an @Override annotation. | 3 | 92–112 |
| AvoidLiteralsInIfCondition | Avoid using Literals in Conditional Statements | 3 | 106 |
| MissingOverride | The method 'getLastRelease(Site, String, String)' is missing an @Override annotation. | 3 | 125–160 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 3 | 146 |
| UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 3 | 173 |
| AvoidCatchingGenericException | Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 3 | 262 |
| AvoidCatchingGenericException | Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 3 | 310 |
| LongInstantiation | Avoid instantiating Long objects.Call Long.valueOf() instead | 2 | 355 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 3 | 355 |
| CompareObjectsWithEquals | Use equals() to compare object references. | 3 | 357 |
| AvoidCatchingGenericException | Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 3 | 371 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UseUtilityClass | All methods are static. Consider using a utility class instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning. | 3 | 44–104 |
| UncommentedEmptyConstructor | Document empty constructor | 3 | 58–61 |
| UnnecessaryConstructor | Avoid unnecessary constructors - the compiler will generate these for you | 3 | 58–61 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| RedundantFieldInitializer | Avoid using redundant field initializer for 'STATUS_ERROR' | 3 | 52 |
| FieldNamingConventions | The static field name 'STATUS_ERROR' doesn't match '_[a-z][a-zA-Z0-9]*' | 1 | 52 |
| FieldNamingConventions | The static field name 'STATUS_OK' doesn't match '_[a-z][a-zA-Z0-9]*' | 1 | 55 |
| RedundantFieldInitializer | Avoid using redundant field initializer for 'ERROR_TYPE_INFO' | 3 | 58 |
| FieldNamingConventions | The static field name 'ERROR_TYPE_INFO' doesn't match '_[a-z][a-zA-Z0-9]*' | 1 | 58 |
| FieldNamingConventions | The static field name 'ERROR_TYPE_STOP' doesn't match '_[a-z][a-zA-Z0-9]*' | 1 | 61 |
| AvoidStringBufferField | StringBuffers can grow quite a lot, and so may become a source of memory leak (if the owning class has a long life time). | 3 | 64 |
| FieldNamingConventions | The field name 'progressValue' doesn't match '_[a-z][a-zA-Z0-9]*' | 1 | 82 |
| UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 3 | 88 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 3 | 88 |
| CloneMethodReturnTypeMustMatchClassName | The return type of the clone() method must be the class name when implements Cloneable | 3 | 158–167 |
| FormalParameterNamingConventions | The method parameter name '_mResultInformations' doesn't match '[a-z][a-zA-Z0-9]*' | 1 | 206 |
| FormalParameterNamingConventions | The method parameter name '_nErrorType' doesn't match '[a-z][a-zA-Z0-9]*' | 1 | 227 |
| FormalParameterNamingConventions | The method parameter name '_dBegin' doesn't match '[a-z][a-zA-Z0-9]*' | 1 | 248 |
| FormalParameterNamingConventions | The method parameter name '_dEnd' doesn't match '[a-z][a-zA-Z0-9]*' | 1 | 269 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| FieldNamingConventions | The constant name '_mapper' doesn't match '[A-Z][A-Z_0-9]*' | 1 | 50 |
| ShortVariable | Avoid variables with short names like t | 3 | 78 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UnusedImports | Avoid unused imports such as 'javax.xml.parsers.ParserConfigurationException' | 4 | 48 |
| UnusedImports | Avoid unused imports such as 'javax.xml.transform.TransformerException' | 4 | 50 |
| UnusedImports | Avoid unused imports such as 'org.eclipse.jgit.api.errors.NoFilepatternException' | 4 | 55 |
| UnusedImports | Avoid unused imports such as 'org.xml.sax.SAXException' | 4 | 59 |
| UseUtilityClass | All methods are static. Consider using a utility class instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning. | 3 | 66–363 |
| CyclomaticComplexity | The method 'updateAppInfoFile(String, String, CommandResult)' has a cyclomatic complexity of 12. | 3 | 185–269 |
| ShortVariable | Avoid variables with short names like br | 3 | 188 |
| AvoidFileStream | Avoid instantiating FileInputStream, FileOutputStream, FileReader, or FileWriter | 1 | 193 |
| AvoidLiteralsInIfCondition | Avoid using Literals in Conditional Statements | 3 | 200 |
| CollapsibleIfStatements | These nested if statements could be combined | 3 | 200–213 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 3 | 203–212 |
| InefficientStringBuffering | Avoid concatenating nonliterals in a StringBuffer/StringBuilder constructor or append(). | 3 | 216 |
| AvoidCatchingGenericException | Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 3 | 220 |
| ShortVariable | Avoid variables with short names like fw | 3 | 244 |
| AvoidFileStream | Avoid instantiating FileInputStream, FileOutputStream, FileReader, or FileWriter | 1 | 247 |
| AvoidCatchingGenericException | Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 3 | 250 |
| ShortVariable | Avoid variables with short names like fw | 3 | 284 |
| ShortVariable | Avoid variables with short names like sw | 3 | 301 |
| ShortVariable | Avoid variables with short names like tf | 3 | 304 |
| AvoidFileStream | Avoid instantiating FileInputStream, FileOutputStream, FileReader, or FileWriter | 1 | 308 |
| AvoidCatchingGenericException | Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 3 | 319 |
| AvoidPrintStackTrace | Avoid printStackTrace(); use a logger call instead. | 3 | 334 |
| CommentDefaultAccessModifier | To avoid mistakes add a comment at the beginning of the ContextFileFilter nested class if you want a default access modifier | 3 | 345–361 |
| MissingOverride | The method 'accept(File, String)' is missing an @Override annotation. | 3 | 357–360 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| GodClass | Possible God Class (WMC=54, ATFD=68, TCC=0.000%) | 3 | 64–563 |
| UseUtilityClass | All methods are static. Consider using a utility class instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning. | 3 | 65–563 |
| TooManyMethods | This class has too many methods, consider refactoring it. | 3 | 65–563 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 3 | 118–129 |
| ShortVariable | Avoid variables with short names like e | 3 | 238 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 3 | 241–248 |
| AvoidUncheckedExceptionsInSignatures | A method or constructor should not explicitly declare unchecked exceptions in its 'throws' clause | 3 | 271 |
| ShortVariable | Avoid variables with short names like e | 3 | 271 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 3 | 274–281 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 3 | 291–298 |
| AvoidUncheckedExceptionsInSignatures | A method or constructor should not explicitly declare unchecked exceptions in its 'throws' clause | 3 | 311 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 3 | 332 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 3 | 377 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 3 | 439 |
| ForLoopCanBeForeach | This for loop can be replaced by a foreach loop | 3 | 463–473 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 3 | 487 |
| CommentRequired | Public method and constructor comments are required | 3 | 531–539 |
| CommentRequired | Public method and constructor comments are required | 3 | 541–561 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 3 | 546–558 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 3 | 551–558 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UseUtilityClass | All methods are static. Consider using a utility class instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning. | 3 | 48–160 |
| InefficientStringBuffering | Avoid concatenating nonliterals in a StringBuffer/StringBuilder constructor or append(). | 3 | 82 |
| UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 3 | 141 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| ExcessiveImports | A high number of imports can indicate a high degree of coupling within an object. | 3 | 34–788 |
| GodClass | Possible God Class (WMC=69, ATFD=39, TCC=0.000%) | 3 | 89–788 |
| UseUtilityClass | All methods are static. Consider using a utility class instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning. | 3 | 90–788 |
| UseObjectForClearerAPI | Rather than using a lot of String arguments, consider using a container object for those values. | 3 | 118–119 |
| IdenticalCatchBranches | 'catch' branch identical to 'InvalidRemoteException' branch | 3 | 145–149 |
| IdenticalCatchBranches | 'catch' branch identical to 'InvalidRemoteException' branch | 3 | 150–153 |
| IdenticalCatchBranches | 'catch' branch identical to 'InvalidRemoteException' branch | 3 | 154–158 |
| IdenticalCatchBranches | 'catch' branch identical to 'InvalidRemoteException' branch | 3 | 193–197 |
| IdenticalCatchBranches | 'catch' branch identical to 'InvalidRemoteException' branch | 3 | 199–202 |
| IdenticalCatchBranches | 'catch' branch identical to 'InvalidRemoteException' branch | 3 | 229–233 |
| IdenticalCatchBranches | 'catch' branch identical to 'InvalidRemoteException' branch | 3 | 235–238 |
| IdenticalCatchBranches | 'catch' branch identical to 'RefAlreadyExistsException' branch | 3 | 267–270 |
| IdenticalCatchBranches | 'catch' branch identical to 'RefAlreadyExistsException' branch | 3 | 271–274 |
| IdenticalCatchBranches | 'catch' branch identical to 'RefAlreadyExistsException' branch | 3 | 275–278 |
| IdenticalCatchBranches | 'catch' branch identical to 'RefAlreadyExistsException' branch | 3 | 279–282 |
| UnnecessaryLocalBeforeReturn | Consider simply returning the value vs storing it in local variable 'mergeResult' | 3 | 400 |
| ShortVariable | Avoid variables with short names like i | 3 | 419 |
| UseStringBufferForStringAppends | Prefer StringBuilder (non-synchronized) or StringBuffer (synchronized) over += for concatenating strings | 3 | 424 |
| UseStringBufferForStringAppends | Prefer StringBuilder (non-synchronized) or StringBuffer (synchronized) over += for concatenating strings | 3 | 425 |
| UseStringBufferForStringAppends | Prefer StringBuilder (non-synchronized) or StringBuffer (synchronized) over += for concatenating strings | 3 | 426 |
| ShortVariable | Avoid variables with short names like i | 3 | 445 |
| UseObjectForClearerAPI | Rather than using a lot of String arguments, consider using a container object for those values. | 3 | 527 |
| UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 3 | 550 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 3 | 550 |
| IdenticalCatchBranches | 'catch' branch identical to 'HttpAccessException' branch | 3 | 565–568 |
| UseObjectForClearerAPI | Rather than using a lot of String arguments, consider using a container object for those values. | 3 | 588 |
| LocalVariableNamingConventions | The final local variable name 'TOKEN' doesn't match '[a-z][a-zA-Z0-9]*' | 1 | 621 |
| ShortVariable | Avoid variables with short names like i | 3 | 626 |
| ForLoopCanBeForeach | This for loop can be replaced by a foreach loop | 3 | 644–653 |
| UnusedLocalVariable | Avoid unused local variables such as 'tagName'. | 3 | 647 |
| AvoidReassigningParameters | Avoid reassigning parameters such as 'strRepoUrl' | 2 | 689 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 711 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 712 |
| CommentRequired | Public method and constructor comments are required | 3 | 736–787 |
| UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 3 | 747 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| FormalParameterNamingConventions | The method parameter name '_strName' doesn't match '[a-z][a-zA-Z0-9]*' | 1 | 73 |
| FormalParameterNamingConventions | The method parameter name '_strCloneUrl' doesn't match '[a-z][a-zA-Z0-9]*' | 1 | 96 |
| FormalParameterNamingConventions | The method parameter name '_strContentsUrl' doesn't match '[a-z][a-zA-Z0-9]*' | 1 | 119 |
| FormalParameterNamingConventions | The method parameter name '_strFullName' doesn't match '[a-z][a-zA-Z0-9]*' | 1 | 142 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| FieldNamingConventions | The field name 'bCancelled' doesn't match '_[a-z][a-zA-Z0-9]*' | 1 | 44 |
| UnusedPrivateField | Avoid unused private fields such as 'bCancelled'. | 3 | 44 |
| SingularField | Perhaps 'bCancelled' could be replaced by a local variable. | 3 | 44 |
| UnnecessaryConstructor | Avoid unnecessary constructors - the compiler will generate these for you | 3 | 49–51 |
| UncommentedEmptyConstructor | Document empty constructor | 3 | 49–51 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UseObjectForClearerAPI | Rather than using a lot of String arguments, consider using a container object for those values. | 3 | 76–77 |
| UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 3 | 85 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UnusedImports | Avoid unused imports such as 'java.io.FileInputStream' | 4 | 36 |
| UnusedImports | Avoid unused imports such as 'java.io.FileNotFoundException' | 4 | 37 |
| UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 3 | 66 |
| LooseCoupling | Avoid using implementation types like 'ArrayList'; use the interface instead | 3 | 66 |
| ImmutableField | Private field '_listDependencies' could be made final; it is only initialized in the declaration or constructor. | 3 | 66 |
| LinguisticNaming | Linguistics Antipattern - The variable 'isPOM' indicates linguistically it is a boolean, but it is 'InputSource' | 3 | 90 |
| UnnecessaryFullyQualifiedName | Unnecessary use of fully qualified name 'fr.paris.lutece.plugins.releaser.business.jaxb.maven.Model.Dependencies' due to existing import 'fr.paris.lutece.plugins.releaser.business.jaxb.maven.Model' | 4 | 95 |
| LinguisticNaming | Linguistics Antipattern - The variable 'isPOM' indicates linguistically it is a boolean, but it is 'InputSource' | 3 | 125 |
| ShortVariable | Avoid variables with short names like jc | 3 | 238 |
| ShortVariable | Avoid variables with short names like u | 3 | 239 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UnusedImports | Avoid unused imports such as 'java.util.Iterator' | 4 | 42 |
| UnusedImports | Avoid unused imports such as 'fr.paris.lutece.portal.service.i18n.I18nService' | 4 | 56 |
| ClassNamingConventions | The utility class name 'PomUpdater' doesn't match '[A-Z][a-zA-Z0-9]+(Utils?|Helper|Home|Service)' | 1 | 64–274 |
| UseUtilityClass | All methods are static. Consider using a utility class instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning. | 3 | 65–274 |
| AvoidFileStream | Avoid instantiating FileInputStream, FileOutputStream, FileReader, or FileWriter | 1 | 87 |
| UnnecessaryFullyQualifiedName | Unnecessary use of fully qualified name 'fr.paris.lutece.plugins.releaser.business.jaxb.maven.Model.Dependencies' due to existing import 'fr.paris.lutece.plugins.releaser.business.jaxb.maven.Model' | 4 | 92 |
| AvoidFileStream | Avoid instantiating FileInputStream, FileOutputStream, FileReader, or FileWriter | 1 | 124 |
| CyclomaticComplexity | The method 'updateSiteAfterTag(Site, String)' has a cyclomatic complexity of 10. | 3 | 163–227 |
| AvoidFileStream | Avoid instantiating FileInputStream, FileOutputStream, FileReader, or FileWriter | 1 | 172 |
| UnnecessaryFullyQualifiedName | Unnecessary use of fully qualified name 'fr.paris.lutece.plugins.releaser.business.jaxb.maven.Model.Dependencies' due to existing import 'fr.paris.lutece.plugins.releaser.business.jaxb.maven.Model' | 4 | 178 |
| CollapsibleIfStatements | These nested if statements could be combined | 3 | 190–193 |
| AvoidDeeplyNestedIfStmts | Deeply nested if..then statements are hard to read | 3 | 190–193 |
| AvoidFileStream | Avoid instantiating FileInputStream, FileOutputStream, FileReader, or FileWriter | 1 | 201 |
| ShortVariable | Avoid variables with short names like jc | 3 | 245 |
| ShortVariable | Avoid variables with short names like m | 3 | 246 |
| ShortVariable | Avoid variables with short names like jc | 3 | 268 |
| ShortVariable | Avoid variables with short names like u | 3 | 269 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| FieldNamingConventions | The field name 'bCancelled' doesn't match '_[a-z][a-zA-Z0-9]*' | 1 | 49 |
| UnusedPrivateField | Avoid unused private fields such as 'bCancelled'. | 3 | 49 |
| SingularField | Perhaps 'bCancelled' could be replaced by a local variable. | 3 | 49 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| SingularField | Perhaps 'bCancelled' could be replaced by a local variable. | 3 | 48 |
| FieldNamingConventions | The field name 'bCancelled' doesn't match '_[a-z][a-zA-Z0-9]*' | 1 | 48 |
| UnusedPrivateField | Avoid unused private fields such as 'bCancelled'. | 3 | 48 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UnusedPrivateField | Avoid unused private fields such as 'bCancelled'. | 3 | 48 |
| FieldNamingConventions | The field name 'bCancelled' doesn't match '_[a-z][a-zA-Z0-9]*' | 1 | 48 |
| SingularField | Perhaps 'bCancelled' could be replaced by a local variable. | 3 | 48 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| FormalParameterNamingConventions | The method parameter name '_mUserContex' doesn't match '[a-z][a-zA-Z0-9]*' | 1 | 120 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| ExcessiveImports | A high number of imports can indicate a high degree of coupling within an object. | 3 | 34–508 |
| UnusedPrivateField | Avoid unused private fields such as 'MESSAGE_ERROR_SVN'. | 3 | 86 |
| UnusedPrivateField | Avoid unused private fields such as 'CONSTANTE_SLASH'. | 3 | 89 |
| FieldNamingConventions | The constant name 'logger' doesn't match '[A-Z][A-Z_0-9]*' | 1 | 92 |
| UnusedPrivateField | Avoid unused private fields such as 'logger'. | 3 | 92 |
| UseObjectForClearerAPI | Rather than using a lot of String arguments, consider using a container object for those values. | 3 | 163 |
| CollapsibleIfStatements | These nested if statements could be combined | 3 | 207–212 |
| CommentRequired | Public method and constructor comments are required | 3 | 222–225 |
| MissingOverride | The method 'checkCancelled()' is missing an @Override annotation. | 3 | 222–225 |
| CommentRequired | Public method and constructor comments are required | 3 | 227–230 |
| MissingOverride | The method 'handleEvent(SVNEvent, double)' is missing an @Override annotation. | 3 | 227–230 |
| ShortVariable | Avoid variables with short names like sw | 3 | 245 |
| ShortVariable | Avoid variables with short names like pw | 3 | 246 |
| UnusedLocalVariable | Avoid unused local variables such as 'errorLog'. | 3 | 249 |
| EmptyCatchBlock | Avoid empty catch blocks | 3 | 258–262 |
| AvoidCatchingGenericException | Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 3 | 269 |
| ShortVariable | Avoid variables with short names like sw | 3 | 273 |
| ShortVariable | Avoid variables with short names like pw | 3 | 274 |
| UnusedLocalVariable | Avoid unused local variables such as 'errorLog'. | 3 | 277 |
| EmptyCatchBlock | Avoid empty catch blocks | 3 | 286–290 |
| CommentRequired | Public method and constructor comments are required | 3 | 321–331 |
| MissingOverride | The method 'handleDirEntry(SVNDirEntry)' is missing an @Override annotation. | 3 | 321–331 |
| CollapsibleIfStatements | These nested if statements could be combined | 3 | 326–329 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 350 |
| UseObjectForClearerAPI | Rather than using a lot of String arguments, consider using a container object for those values. | 3 | 413 |
| AvoidReassigningParameters | Avoid reassigning parameters such as 'strRepoUrl' | 2 | 465 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| GodClass | Possible God Class (WMC=47, ATFD=10, TCC=30.333%) | 3 | 47–542 |
| UncommentedEmptyConstructor | Document empty constructor | 3 | 86–88 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 3 | 238–245 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 3 | 277 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 3 | 297–308 |
| AvoidCatchingGenericException | Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 3 | 310 |
| AvoidDuplicateLiterals | The String literal "Error parsing version " appears 5 times in this file; the first occurrence is on line 440 | 3 | 440 |
| AvoidDuplicateLiterals | The String literal " : " appears 5 times in this file; the first occurrence is on line 440 | 3 | 440 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| MissingSerialVersionUID | Classes implementing Serializable should set a serialVersionUID | 3 | 40–55 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| MissingSerialVersionUID | Classes implementing Serializable should set a serialVersionUID | 3 | 70–615 |
| NullAssignment | Assigning an Object to null is a code smell. Consider refactoring. | 3 | 165 |
| NullAssignment | Assigning an Object to null is a code smell. Consider refactoring. | 3 | 166 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 3 | 207 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 3 | 449 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| MissingSerialVersionUID | Classes implementing Serializable should set a serialVersionUID | 3 | 65–316 |
| CommentDefaultAccessModifier | To avoid mistakes add a comment at the beginning of the _paginatorComponents field if you want a default access modifier | 3 | 126 |
| DefaultPackage | Use explicit scoping instead of the default package private level | 3 | 126 |
| CyclomaticComplexity | The method 'getManageComponent(HttpServletRequest)' has a cyclomatic complexity of 11. | 3 | 137–173 |
| UnusedLocalVariable | Avoid unused local variables such as 'user'. | 3 | 145 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 145 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 3 | 147 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 3 | 167 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 3 | 169 |
| UnnecessaryAnnotationValueElement | Avoid the use of value in annotations when its the only element | 3 | 247 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 255 |
| UnusedLocalVariable | Avoid unused local variables such as 'component'. | 3 | 255 |
| UnusedLocalVariable | Avoid unused local variables such as 'component'. | 3 | 277 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 277 |
| LinguisticNaming | Linguistics Antipattern - The setter 'setReleaserUser' should not return any type except void linguistically | 3 | 282–295 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| ExcessiveImports | A high number of imports can indicate a high degree of coupling within an object. | 3 | 34–701 |
| UnusedImports | Avoid unused imports such as 'fr.paris.lutece.portal.service.i18n.I18nService' | 4 | 49 |
| MissingSerialVersionUID | Classes implementing Serializable should set a serialVersionUID | 3 | 74–701 |
| TooManyMethods | This class has too many methods, consider refactoring it. | 3 | 75–701 |
| NullAssignment | Assigning an Object to null is a code smell. Consider refactoring. | 3 | 217 |
| UnnecessaryAnnotationValueElement | Avoid the use of value in annotations when its the only element | 3 | 266 |
| CyclomaticComplexity | The method 'getConfirmReleaseSite(HttpServletRequest)' has a cyclomatic complexity of 11. | 3 | 267–313 |
| NPathComplexity | The method 'getConfirmReleaseSite(HttpServletRequest)' has an NPath complexity of 324 | 3 | 267–313 |
| UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 3 | 272 |
| UnnecessaryAnnotationValueElement | Avoid the use of value in annotations when its the only element | 3 | 322 |
| UnnecessaryAnnotationValueElement | Avoid the use of value in annotations when its the only element | 3 | 349 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 3 | 357–376 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 3 | 361–370 |
| UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 3 | 505 |
| UnnecessaryAnnotationValueElement | Avoid the use of value in annotations when its the only element | 3 | 562 |
| UnnecessaryLocalBeforeReturn | Consider simply returning the value vs storing it in local variable 'strTemplate' | 3 | 575 |
| UnnecessaryAnnotationValueElement | Avoid the use of value in annotations when its the only element | 3 | 633 |
| UnusedLocalVariable | Avoid unused local variables such as 'component'. | 3 | 641 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 641 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 662 |
| UnusedLocalVariable | Avoid unused local variables such as 'component'. | 3 | 662 |
| LinguisticNaming | Linguistics Antipattern - The setter 'setReleaserUser' should not return any type except void linguistically | 3 | 668–681 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| MissingSerialVersionUID | Classes implementing Serializable should set a serialVersionUID | 3 | 49–99 |
| SingularField | Perhaps '_nDefaultItemsPerPage' could be replaced by a local variable. | 3 | 62 |
