Fork me on GitHub

PMD Results

The following document contains the results of PMD 5.3.5.

Files

fr/paris/lutece/plugins/document/modules/ckan/business/Error.java

Violation Line
Method names should not contain underscores 70
Method names should not contain underscores 78

fr/paris/lutece/plugins/document/modules/ckan/business/PackageOrganization.java

Violation Line
Avoid variables with short names like id 65
Method names should not contain underscores 137
Method names should not contain underscores 145
Method names should not contain underscores 169
Method names should not contain underscores 177
Method names should not contain underscores 201
Method names should not contain underscores 209
Method names should not contain underscores 217
Method names should not contain underscores 225

fr/paris/lutece/plugins/document/modules/ckan/business/PackageResource.java

Violation Line
Method names should not contain underscores 120
Method names should not contain underscores 128
Method names should not contain underscores 152
Method names should not contain underscores 160
Method names should not contain underscores 184
Method names should not contain underscores 192
Avoid variables with short names like id 208

fr/paris/lutece/plugins/document/modules/ckan/business/PackageShowResult.java

Violation Line
This class has a bunch of public methods and attributes 34557
Too many fields 42557
Avoid variables with short names like id 87
Method names should not contain underscores 143
Method names should not contain underscores 151
Method names should not contain underscores 303
Method names should not contain underscores 311
Method names should not contain underscores 319
Method names should not contain underscores 327
Method names should not contain underscores 335
Method names should not contain underscores 343
Method names should not contain underscores 351
Method names should not contain underscores 359
Method names should not contain underscores 367
Method names should not contain underscores 375
Method names should not contain underscores 399
Method names should not contain underscores 407
Method names should not contain underscores 415
Method names should not contain underscores 423
Method names should not contain underscores 431
Method names should not contain underscores 439
Method names should not contain underscores 495
Method names should not contain underscores 503
Method names should not contain underscores 511
Method names should not contain underscores 519
Method names should not contain underscores 527
Method names should not contain underscores 535
Method names should not contain underscores 543
Method names should not contain underscores 551

fr/paris/lutece/plugins/document/modules/ckan/business/PackageTag.java

Violation Line
Method names should not contain underscores 52
Method names should not contain underscores 60
Method names should not contain underscores 68
Method names should not contain underscores 76
Method names should not contain underscores 100
Method names should not contain underscores 108

fr/paris/lutece/plugins/document/modules/ckan/business/WSBase.java

Violation Line
This abstract class does not have any abstract methods 4076
Abstract classes should be named AbstractXXX 4076

fr/paris/lutece/plugins/document/modules/ckan/business/WSError.java

Violation Line
It is a good practice to call super() in a constructor 5459
Avoid throwing raw exception types. 56

fr/paris/lutece/plugins/document/modules/ckan/business/WSResult.java

Violation Line
Abstract classes should be named AbstractXXX 4160

fr/paris/lutece/plugins/document/modules/ckan/rs/CkanRest.java

Violation Line
The Logger variable declaration does not contain the static and final modifiers 63
Private field '_logger' could be made final; it is only initialized in the declaration or constructor. 63
debug logging that involves string concatenation should be guarded with isDebugEnabled() checks 76
A switch with less than three branches is inefficient, use a if statement instead. 7885
debug logging that involves string concatenation should be guarded with isDebugEnabled() checks 115
A switch with less than three branches is inefficient, use a if statement instead. 117124
String.indexOf(char) is faster than String.indexOf(String). 141

fr/paris/lutece/plugins/document/modules/ckan/service/CkanService.java

Violation Line
Do not add empty strings 136

fr/paris/lutece/plugins/document/modules/ckan/service/DocumentParser.java

Violation Line
When instantiating a SimpleDateFormat object, specify a Locale 75
When instantiating a SimpleDateFormat object, specify a Locale 76
Avoid really long methods. 91208
Avoid variables with short names like po 137
Avoid using Literals in Conditional Statements 159
Avoid variables with short names like pr 161
Avoid using Literals in Conditional Statements 168
Avoid variables with short names like st 182
Avoid variables with short names like pr 241
Avoid variables with short names like pr 259
Static DateFormatter objects should be accessed in a synchronized manner 325
Static DateFormatter objects should be accessed in a synchronized manner 326

fr/paris/lutece/plugins/document/modules/ckan/service/MapperService.java

Violation Line
Avoid variables with short names like sw 63
Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 69
Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 92

fr/paris/lutece/plugins/document/modules/ckan/service/PackageServiceV3.java

Violation Line
Avoid variables with short names like pl 74
Avoid declaring a variable if it is unreferenced before a possible exit point. 117
Avoid variables with short names like ps 127