The following document contains the results of PMD 5.3.5.
| Violation | Line |
|---|---|
| Avoid unnecessary constructors - the compiler will generate these for you | 69–71 |
| Document empty constructor | 69–71 |
| It is a good practice to call super() in a constructor | 69–71 |
| Document empty method | 128–129 |
| Deeply nested if..then statements are hard to read | 207–210 |
| Violation | Line |
|---|---|
| Use explicit scoping instead of the default package private level | 67–70 |
| Violation | Line |
|---|---|
| Singleton is not thread safe | 61–65 |
| Violation | Line |
|---|---|
| Use explicit scoping instead of the default package private level | 73–76 |
| Violation | Line |
|---|---|
| Use explicit scoping instead of the default package private level | 69–72 |
| Violation | Line |
|---|---|
| Substitute calls to size() == 0 (or size() != 0, size() > 0, size() < 1) with calls to isEmpty() | 67 |
| Avoid unnecessary if..then..else statements when returning booleans | 67–70 |
| Violation | Line |
|---|---|
| Document empty method | 67–68 |
| Deeply nested if..then statements are hard to read | 100–110 |
| Violation | Line |
|---|---|
| The class 'WssoDatabaseService' has a Standard Cyclomatic Complexity of 6 (Highest = 10). | 62–227 |
| The class 'WssoDatabaseService' has a Cyclomatic Complexity of 6 (Highest = 10). | 62–227 |
| The class 'WssoDatabaseService' has a Modified Cyclomatic Complexity of 6 (Highest = 10). | 62–227 |
| The field name indicates a constant but its modifiers do not | 70 |
| The method 'init' has a Standard Cyclomatic Complexity of 10. | 79–143 |
| The method 'init' has a Cyclomatic Complexity of 10. | 79–143 |
| The method 'init' has a Modified Cyclomatic Complexity of 10. | 79–143 |
| Deeply nested if..then statements are hard to read | 106–128 |
| Violation | Line |
|---|---|
| The class 'LdapBrowser' has a Standard Cyclomatic Complexity of 2 (Highest = 10). | 59–479 |
| The class 'LdapBrowser' has a Modified Cyclomatic Complexity of 2 (Highest = 10). | 59–479 |
| The class 'LdapBrowser' has a Cyclomatic Complexity of 3 (Highest = 11). | 59–479 |
| Avoid excessively long variable names like PROPERTY_USER_DN_SEARCH_FILTER_BY_CRITERIA_GIVENNAME | 69 |
| Document empty constructor | 113–115 |
| Avoid unnecessary constructors - the compiler will generate these for you | 113–115 |
| Avoid really long methods. | 124–225 |
| The method 'getUserList' has a Cyclomatic Complexity of 10. | 124–225 |
| Avoid variables with short names like sr | 127 |
| The method 'getUserPublicData' has a Cyclomatic Complexity of 11. | 232–334 |
| Avoid really long methods. | 232–334 |
| The method 'getUserPublicData' has a Modified Cyclomatic Complexity of 10. | 232–334 |
| The method 'getUserPublicData' has a Standard Cyclomatic Complexity of 10. | 232–334 |
| Avoid variables with short names like sr | 235 |
| Avoid using Literals in Conditional Statements | 301 |
| Avoid variables with short names like in | 341 |
| Avoid prefixing parameters by in, out or inOut. Uses Javadoc to document this behavior. | 341 |
| Avoid variables with short names like sb | 353 |
| StringBuffer constructor is initialized with size 16, but has at least 26 characters appended. | 353 |
| StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 354 |
| StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 355 |
| StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 356 |
| Position literals first in String comparisons for EqualsIgnoreCase | 433 |
| Consider using varargs for methods or constructors which take an array the last parameter. | 463 |
| Prefer StringBuffer over += for concatenating strings | 471 |
| Prefer StringBuffer over += for concatenating strings | 475 |
| Violation | Line |
|---|---|
| Rather than using a lot of String arguments, consider using a container object for those values. | 68–69 |
| Consider replacing this Hashtable with the newer java.util.Map | 71 |
| Rather than using a lot of String arguments, consider using a container object for those values. | 106 |
| Consider replacing this Hashtable with the newer java.util.Map | 111 |
| Avoid variables with short names like sc | 134 |
| Violation | Line |
|---|---|
| Avoid unnecessary constructors - the compiler will generate these for you | 117–119 |
| Document empty constructor | 117–119 |
| It is a good practice to call super() in a constructor | 117–119 |
| Position literals first in String comparisons | 163 |
| Position literals first in String comparisons | 163 |
| Position literals first in String comparisons | 163 |
| Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 170 |
| Avoid declaring a variable if it is unreferenced before a possible exit point. | 196 |
| Avoid declaring a variable if it is unreferenced before a possible exit point. | 197 |
| Avoid declaring a variable if it is unreferenced before a possible exit point. | 198 |
| Substitute calls to size() == 0 (or size() != 0, size() > 0, size() < 1) with calls to isEmpty() | 215 |
| Violation | Line |
|---|---|
| All methods are static. Consider using a utility class instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning. | 44–66 |
| Document empty constructor | 51–53 |
| Avoid unnecessary constructors - the compiler will generate these for you | 51–53 |
| Use block level rather than method level synchronization | 60–65 |
| Violation | Line |
|---|---|
| All methods are static. Consider using a utility class instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning. | 61–216 |
| Avoid excessively long variable names like PROPERTY_XMLFILEFORMAT_ATTR_APPLICATION_WSSO_APP_ID | 74 |
| Document empty constructor | 88–90 |
| Avoid unnecessary constructors - the compiler will generate these for you | 88–90 |
| When instantiating a SimpleDateFormat object, specify a Locale | 116 |
| Avoid catching NullPointerException; consider removing the cause of the NPE. | 191 |
| Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 191 |
