The following document contains the results of PMD 6.13.0.
| Rule | Violation | Line |
|---|---|---|
| FieldNamingConventions | The field name 'ATTRIBUTE_USER_MAPPING' doesn't match '_[a-z][a-zA-Z0-9]*' | 70 |
| Rule | Violation | Line |
|---|---|---|
| ClassNamingConventions | The utility class name 'AutoExportWssoUsersFile' doesn't match '[A-Z][a-zA-Z0-9]+(Utils?|Helper|Home|Service)' | 43–66 |
| Rule | Violation | Line |
|---|---|---|
| AvoidFileStream | Avoid instantiating FileInputStream, FileOutputStream, FileReader, or FileWriter | 176 |
| Rule | Violation | Line |
|---|---|---|
| UnnecessaryConstructor | Avoid unnecessary constructors - the compiler will generate these for you | 69–71 |
| CallSuperInConstructor | It is a good practice to call super() in a constructor | 69–71 |
| UncommentedEmptyConstructor | Document empty constructor | 69–71 |
| MissingOverride | The method 'getAuthServiceName()' is missing an @Override annotation. | 77–80 |
| MissingOverride | The method 'getAuthType(HttpServletRequest)' is missing an @Override annotation. | 87–103 |
| ForLoopCanBeForeach | This for loop can be replaced by a foreach loop | 92–100 |
| MissingOverride | The method 'login(String, String, HttpServletRequest)' is missing an @Override annotation. | 114–121 |
| UnnecessaryLocalBeforeReturn | Consider simply returning the value vs storing it in local variable 'luteceUser' | 120 |
| MissingOverride | The method 'logout(LuteceUser)' is missing an @Override annotation. | 127–129 |
| UncommentedEmptyMethodBody | Document empty method body | 128–129 |
| MissingOverride | The method 'getAnonymousUser()' is missing an @Override annotation. | 136–140 |
| MissingOverride | The method 'isUserInRole(LuteceUser, HttpServletRequest, String)' is missing an @Override annotation. | 149–170 |
| ForLoopCanBeForeach | This for loop can be replaced by a foreach loop | 160–166 |
| MissingOverride | The method 'getHttpAuthenticatedUser(HttpServletRequest)' is missing an @Override annotation. | 177–215 |
| ForLoopCanBeForeach | This for loop can be replaced by a foreach loop | 185–193 |
| AvoidDeeplyNestedIfStmts | Deeply nested if..then statements are hard to read | 207–210 |
| MissingOverride | The method 'isUsersListAvailable()' is missing an @Override annotation. | 221–224 |
| MissingOverride | The method 'getUsers()' is missing an @Override annotation. | 230–243 |
| UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 235 |
| MissingOverride | The method 'getUser(String)' is missing an @Override annotation. | 250–258 |
| UnnecessaryLocalBeforeReturn | Consider simply returning the value vs storing it in local variable 'user' | 257 |
| MissingOverride | The method 'getRolesByUser(LuteceUser)' is missing an @Override annotation. | 266–269 |
| MissingOverride | The method 'getIconUrl()' is missing an @Override annotation. | 275–278 |
| MissingOverride | The method 'getName()' is missing an @Override annotation. | 284–287 |
| MissingOverride | The method 'getPluginName()' is missing an @Override annotation. | 293–296 |
| MissingOverride | The method 'isMultiAuthenticationSupported()' is missing an @Override annotation. | 302–305 |
| Rule | Violation | Line |
|---|---|---|
| MissingSerialVersionUID | Classes implementing Serializable should set a serialVersionUID | 44–55 |
| Rule | Violation | Line |
|---|---|---|
| CommentDefaultAccessModifier | To avoid mistakes add a comment at the beginning of the getInstance method if you want a default access modifier | 67–70 |
| DefaultPackage | Use explicit scoping instead of the default package private level | 67–70 |
| MissingOverride | The method 'findUserByGuid(String, Plugin, LuteceAuthentication)' is missing an @Override annotation. | 80–104 |
| MissingOverride | The method 'findUserRolesFromGuid(String, Plugin, LuteceAuthentication)' is missing an @Override annotation. | 114–129 |
| UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 116 |
| MissingOverride | The method 'findUsersList(Plugin, LuteceAuthentication)' is missing an @Override annotation. | 153–180 |
| UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 155 |
| Rule | Violation | Line |
|---|---|---|
| NonThreadSafeSingleton | Singleton is not thread safe | 61–65 |
| Rule | Violation | Line |
|---|---|---|
| DefaultPackage | Use explicit scoping instead of the default package private level | 73–76 |
| CommentDefaultAccessModifier | To avoid mistakes add a comment at the beginning of the getInstance method if you want a default access modifier | 73–76 |
| MissingOverride | The method 'newPrimaryKey(Plugin)' is missing an @Override annotation. | 83–101 |
| MissingOverride | The method 'insert(WssoUser, Plugin)' is missing an @Override annotation. | 109–121 |
| MissingOverride | The method 'load(int, Plugin)' is missing an @Override annotation. | 130–152 |
| MissingOverride | The method 'delete(WssoUser, Plugin)' is missing an @Override annotation. | 159–166 |
| MissingOverride | The method 'store(WssoUser, Plugin)' is missing an @Override annotation. | 173–185 |
| MissingOverride | The method 'selectWssoUserList(Plugin)' is missing an @Override annotation. | 192–214 |
| UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 194 |
| MissingOverride | The method 'selectWssoUsersListForRole(int, Plugin)' is missing an @Override annotation. | 222–245 |
| UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 224 |
| MissingOverride | The method 'selectWssoUserListForGuid(String, Plugin)' is missing an @Override annotation. | 253–276 |
| UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 255 |
| Rule | Violation | Line |
|---|---|---|
| CommentDefaultAccessModifier | To avoid mistakes add a comment at the beginning of the getInstance method if you want a default access modifier | 69–72 |
| DefaultPackage | Use explicit scoping instead of the default package private level | 69–72 |
| MissingOverride | The method 'selectRoleListForUser(int, Plugin)' is missing an @Override annotation. | 80–95 |
| MissingOverride | The method 'selectUserListForRole(String, Plugin)' is missing an @Override annotation. | 103–118 |
| UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 105 |
| MissingOverride | The method 'deleteRolesForUser(int, Plugin)' is missing an @Override annotation. | 125–132 |
| MissingOverride | The method 'createRoleForUser(int, String, Plugin)' is missing an @Override annotation. | 140–148 |
| Rule | Violation | Line |
|---|---|---|
| MissingOverride | The method 'canBeRemoved(String)' is missing an @Override annotation. | 57–73 |
| UseCollectionIsEmpty | Substitute calls to size() == 0 (or size() != 0, size() > 0, size() < 1) with calls to isEmpty() | 67 |
| SimplifyBooleanReturns | Avoid unnecessary if..then..else statements when returning booleans | 67–70 |
| MissingOverride | The method 'getRemovalRefusedMessage(String, Locale)' is missing an @Override annotation. | 81–85 |
| Rule | Violation | Line |
|---|---|---|
| UncommentedEmptyMethodBody | Document empty method body | 67–68 |
| ForLoopCanBeForeach | This for loop can be replaced by a foreach loop | 96–111 |
| AvoidDeeplyNestedIfStmts | Deeply nested if..then statements are hard to read | 100–110 |
| Rule | Violation | Line |
|---|---|---|
| MissingOverride | The method 'init()' is missing an @Override annotation. | 49–53 |
| Rule | Violation | Line |
|---|---|---|
| CyclomaticComplexity | The method 'init()' has a cyclomatic complexity of 10. | 79–143 |
| UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 91 |
| AvoidDeeplyNestedIfStmts | Deeply nested if..then statements are hard to read | 106–128 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 135–142 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 158–205 |
| ForLoopCanBeForeach | This for loop can be replaced by a foreach loop | 169–201 |
| Rule | Violation | Line |
|---|---|---|
| MissingOverride | The method 'compare(Object, Object)' is missing an @Override annotation. | 84–102 |
| CommentRequired | Public method and constructor comments are required | 84–102 |
| UseLocaleWithCaseConversions | When doing a String.toLowerCase()/toUpperCase() call, use a Locale | 89 |
| UseLocaleWithCaseConversions | When doing a String.toLowerCase()/toUpperCase() call, use a Locale | 89 |
| UseLocaleWithCaseConversions | When doing a String.toLowerCase()/toUpperCase() call, use a Locale | 93 |
| UseLocaleWithCaseConversions | When doing a String.toLowerCase()/toUpperCase() call, use a Locale | 93 |
| UseLocaleWithCaseConversions | When doing a String.toLowerCase()/toUpperCase() call, use a Locale | 97 |
| UseLocaleWithCaseConversions | When doing a String.toLowerCase()/toUpperCase() call, use a Locale | 97 |
| UnnecessaryConstructor | Avoid unnecessary constructors - the compiler will generate these for you | 113–115 |
| UncommentedEmptyConstructor | Document empty constructor | 113–115 |
| CyclomaticComplexity | The method 'getUserList(String, String, String)' has a cyclomatic complexity of 10. | 124–225 |
| ExcessiveMethodLength | Avoid really long methods. | 124–225 |
| ShortVariable | Avoid variables with short names like sr | 127 |
| CyclomaticComplexity | The method 'getUserPublicData(String)' has a cyclomatic complexity of 11. | 232–334 |
| ExcessiveMethodLength | Avoid really long methods. | 232–334 |
| ShortVariable | Avoid variables with short names like sr | 235 |
| AvoidLiteralsInIfCondition | Avoid using Literals in Conditional Statements | 301 |
| ShortVariable | Avoid variables with short names like in | 341 |
| InsufficientStringBufferDeclaration | StringBuffer constructor is initialized with size 16, but has at least 26 characters appended. | 353 |
| ShortVariable | Avoid variables with short names like sb | 353 |
| ConsecutiveAppendsShouldReuse | StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 354 |
| ConsecutiveAppendsShouldReuse | StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 355 |
| ConsecutiveAppendsShouldReuse | StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 356 |
| PositionLiteralsFirstInCaseInsensitiveComparisons | Position literals first in String comparisons for EqualsIgnoreCase | 433 |
| UseStringBufferForStringAppends | Prefer StringBuilder (non-synchronized) or StringBuffer (synchronized) over += for concatenating strings | 471 |
| UseStringBufferForStringAppends | Prefer StringBuilder (non-synchronized) or StringBuffer (synchronized) over += for concatenating strings | 475 |
| Rule | Violation | Line |
|---|---|---|
| UseObjectForClearerAPI | Rather than using a lot of String arguments, consider using a container object for those values. | 68–69 |
| ReplaceHashtableWithMap | Consider replacing this Hashtable with the newer java.util.Map | 71 |
| UnnecessaryLocalBeforeReturn | Consider simply returning the value vs storing it in local variable 'context' | 80 |
| UseObjectForClearerAPI | Rather than using a lot of String arguments, consider using a container object for those values. | 106 |
| ReplaceHashtableWithMap | Consider replacing this Hashtable with the newer java.util.Map | 111 |
| ShortVariable | Avoid variables with short names like sc | 134 |
| UnnecessaryLocalBeforeReturn | Consider simply returning the value vs storing it in local variable 'enumeration' | 138 |
| Rule | Violation | Line |
|---|---|---|
| MissingSerialVersionUID | Classes implementing Serializable should set a serialVersionUID | 65–388 |
| CallSuperInConstructor | It is a good practice to call super() in a constructor | 117–119 |
| UnnecessaryConstructor | Avoid unnecessary constructors - the compiler will generate these for you | 117–119 |
| UncommentedEmptyConstructor | Document empty constructor | 117–119 |
| PositionLiteralsFirstInComparisons | Position literals first in String comparisons | 163 |
| PositionLiteralsFirstInComparisons | Position literals first in String comparisons | 163 |
| PositionLiteralsFirstInComparisons | Position literals first in String comparisons | 163 |
| AvoidCatchingGenericException | Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 170 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 196 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 197 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 198 |
| UseCollectionIsEmpty | Substitute calls to size() == 0 (or size() != 0, size() > 0, size() < 1) with calls to isEmpty() | 215 |
| ForLoopCanBeForeach | This for loop can be replaced by a foreach loop | 380–383 |
| Rule | Violation | Line |
|---|---|---|
| UseUtilityClass | All methods are static. Consider using a utility class instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning. | 44–66 |
| UnnecessaryConstructor | Avoid unnecessary constructors - the compiler will generate these for you | 51–53 |
| UncommentedEmptyConstructor | Document empty constructor | 51–53 |
| AvoidSynchronizedAtMethodLevel | Use block level rather than method level synchronization | 60–65 |
| Rule | Violation | Line |
|---|---|---|
| UseUtilityClass | All methods are static. Consider using a utility class instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning. | 61–216 |
| UnnecessaryConstructor | Avoid unnecessary constructors - the compiler will generate these for you | 88–90 |
| UncommentedEmptyConstructor | Document empty constructor | 88–90 |
| SimpleDateFormatNeedsLocale | When instantiating a SimpleDateFormat object, specify a Locale | 116 |
| AvoidCatchingNPE | Avoid catching NullPointerException; consider removing the cause of the NPE. | 191 |
| IdenticalCatchBranches | 'catch' branch identical to 'IOException' branch | 191–195 |
| AvoidCatchingGenericException | Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 191 |
| Rule | Violation | Line |
|---|---|---|
| CallSuperInConstructor | It is a good practice to call super() in a constructor | 53–55 |
| UnnecessaryConstructor | Avoid unnecessary constructors - the compiler will generate these for you | 53–55 |
| UncommentedEmptyConstructor | Document empty constructor | 53–55 |
| MissingOverride | The method 'run()' is missing an @Override annotation. | 60–65 |
| Rule | Violation | Line |
|---|---|---|
| UnnecessaryFullyQualifiedName | Unnecessary use of fully qualified name 'java.lang.UnsupportedOperationException' due to existing implicit import 'java.lang.*' | 139 |
| Rule | Violation | Line |
|---|---|---|
| UseVarargs | Consider using varargs for methods or constructors which take an array the last parameter. | 463 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UnnecessaryConstructor | Avoid unnecessary constructors - the compiler will generate these for you | 3 | 69–71 |
| CallSuperInConstructor | It is a good practice to call super() in a constructor | 3 | 69–71 |
| UncommentedEmptyConstructor | Document empty constructor | 3 | 69–71 |
| MissingOverride | The method 'getAuthServiceName()' is missing an @Override annotation. | 3 | 77–80 |
| MissingOverride | The method 'getAuthType(HttpServletRequest)' is missing an @Override annotation. | 3 | 87–103 |
| ForLoopCanBeForeach | This for loop can be replaced by a foreach loop | 3 | 92–100 |
| MissingOverride | The method 'login(String, String, HttpServletRequest)' is missing an @Override annotation. | 3 | 114–121 |
| UnnecessaryLocalBeforeReturn | Consider simply returning the value vs storing it in local variable 'luteceUser' | 3 | 120 |
| MissingOverride | The method 'logout(LuteceUser)' is missing an @Override annotation. | 3 | 127–129 |
| UncommentedEmptyMethodBody | Document empty method body | 3 | 128–129 |
| MissingOverride | The method 'getAnonymousUser()' is missing an @Override annotation. | 3 | 136–140 |
| UnnecessaryFullyQualifiedName | Unnecessary use of fully qualified name 'java.lang.UnsupportedOperationException' due to existing implicit import 'java.lang.*' | 4 | 139 |
| MissingOverride | The method 'isUserInRole(LuteceUser, HttpServletRequest, String)' is missing an @Override annotation. | 3 | 149–170 |
| ForLoopCanBeForeach | This for loop can be replaced by a foreach loop | 3 | 160–166 |
| MissingOverride | The method 'getHttpAuthenticatedUser(HttpServletRequest)' is missing an @Override annotation. | 3 | 177–215 |
| ForLoopCanBeForeach | This for loop can be replaced by a foreach loop | 3 | 185–193 |
| AvoidDeeplyNestedIfStmts | Deeply nested if..then statements are hard to read | 3 | 207–210 |
| MissingOverride | The method 'isUsersListAvailable()' is missing an @Override annotation. | 3 | 221–224 |
| MissingOverride | The method 'getUsers()' is missing an @Override annotation. | 3 | 230–243 |
| UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 3 | 235 |
| MissingOverride | The method 'getUser(String)' is missing an @Override annotation. | 3 | 250–258 |
| UnnecessaryLocalBeforeReturn | Consider simply returning the value vs storing it in local variable 'user' | 3 | 257 |
| MissingOverride | The method 'getRolesByUser(LuteceUser)' is missing an @Override annotation. | 3 | 266–269 |
| MissingOverride | The method 'getIconUrl()' is missing an @Override annotation. | 3 | 275–278 |
| MissingOverride | The method 'getName()' is missing an @Override annotation. | 3 | 284–287 |
| MissingOverride | The method 'getPluginName()' is missing an @Override annotation. | 3 | 293–296 |
| MissingOverride | The method 'isMultiAuthenticationSupported()' is missing an @Override annotation. | 3 | 302–305 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| MissingSerialVersionUID | Classes implementing Serializable should set a serialVersionUID | 3 | 44–55 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| CommentDefaultAccessModifier | To avoid mistakes add a comment at the beginning of the getInstance method if you want a default access modifier | 3 | 67–70 |
| DefaultPackage | Use explicit scoping instead of the default package private level | 3 | 67–70 |
| MissingOverride | The method 'findUserByGuid(String, Plugin, LuteceAuthentication)' is missing an @Override annotation. | 3 | 80–104 |
| MissingOverride | The method 'findUserRolesFromGuid(String, Plugin, LuteceAuthentication)' is missing an @Override annotation. | 3 | 114–129 |
| UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 3 | 116 |
| MissingOverride | The method 'findUsersList(Plugin, LuteceAuthentication)' is missing an @Override annotation. | 3 | 153–180 |
| UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 3 | 155 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| NonThreadSafeSingleton | Singleton is not thread safe | 3 | 61–65 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| DefaultPackage | Use explicit scoping instead of the default package private level | 3 | 73–76 |
| CommentDefaultAccessModifier | To avoid mistakes add a comment at the beginning of the getInstance method if you want a default access modifier | 3 | 73–76 |
| MissingOverride | The method 'newPrimaryKey(Plugin)' is missing an @Override annotation. | 3 | 83–101 |
| MissingOverride | The method 'insert(WssoUser, Plugin)' is missing an @Override annotation. | 3 | 109–121 |
| MissingOverride | The method 'load(int, Plugin)' is missing an @Override annotation. | 3 | 130–152 |
| MissingOverride | The method 'delete(WssoUser, Plugin)' is missing an @Override annotation. | 3 | 159–166 |
| MissingOverride | The method 'store(WssoUser, Plugin)' is missing an @Override annotation. | 3 | 173–185 |
| MissingOverride | The method 'selectWssoUserList(Plugin)' is missing an @Override annotation. | 3 | 192–214 |
| UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 3 | 194 |
| MissingOverride | The method 'selectWssoUsersListForRole(int, Plugin)' is missing an @Override annotation. | 3 | 222–245 |
| UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 3 | 224 |
| MissingOverride | The method 'selectWssoUserListForGuid(String, Plugin)' is missing an @Override annotation. | 3 | 253–276 |
| UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 3 | 255 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| CommentDefaultAccessModifier | To avoid mistakes add a comment at the beginning of the getInstance method if you want a default access modifier | 3 | 69–72 |
| DefaultPackage | Use explicit scoping instead of the default package private level | 3 | 69–72 |
| MissingOverride | The method 'selectRoleListForUser(int, Plugin)' is missing an @Override annotation. | 3 | 80–95 |
| MissingOverride | The method 'selectUserListForRole(String, Plugin)' is missing an @Override annotation. | 3 | 103–118 |
| UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 3 | 105 |
| MissingOverride | The method 'deleteRolesForUser(int, Plugin)' is missing an @Override annotation. | 3 | 125–132 |
| MissingOverride | The method 'createRoleForUser(int, String, Plugin)' is missing an @Override annotation. | 3 | 140–148 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| MissingOverride | The method 'canBeRemoved(String)' is missing an @Override annotation. | 3 | 57–73 |
| UseCollectionIsEmpty | Substitute calls to size() == 0 (or size() != 0, size() > 0, size() < 1) with calls to isEmpty() | 3 | 67 |
| SimplifyBooleanReturns | Avoid unnecessary if..then..else statements when returning booleans | 3 | 67–70 |
| MissingOverride | The method 'getRemovalRefusedMessage(String, Locale)' is missing an @Override annotation. | 3 | 81–85 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UncommentedEmptyMethodBody | Document empty method body | 3 | 67–68 |
| ForLoopCanBeForeach | This for loop can be replaced by a foreach loop | 3 | 96–111 |
| AvoidDeeplyNestedIfStmts | Deeply nested if..then statements are hard to read | 3 | 100–110 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| MissingOverride | The method 'init()' is missing an @Override annotation. | 3 | 49–53 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| FieldNamingConventions | The field name 'ATTRIBUTE_USER_MAPPING' doesn't match '_[a-z][a-zA-Z0-9]*' | 1 | 70 |
| CyclomaticComplexity | The method 'init()' has a cyclomatic complexity of 10. | 3 | 79–143 |
| UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 3 | 91 |
| AvoidDeeplyNestedIfStmts | Deeply nested if..then statements are hard to read | 3 | 106–128 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 3 | 135–142 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 3 | 158–205 |
| ForLoopCanBeForeach | This for loop can be replaced by a foreach loop | 3 | 169–201 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| MissingOverride | The method 'compare(Object, Object)' is missing an @Override annotation. | 3 | 84–102 |
| CommentRequired | Public method and constructor comments are required | 3 | 84–102 |
| UseLocaleWithCaseConversions | When doing a String.toLowerCase()/toUpperCase() call, use a Locale | 3 | 89 |
| UseLocaleWithCaseConversions | When doing a String.toLowerCase()/toUpperCase() call, use a Locale | 3 | 89 |
| UseLocaleWithCaseConversions | When doing a String.toLowerCase()/toUpperCase() call, use a Locale | 3 | 93 |
| UseLocaleWithCaseConversions | When doing a String.toLowerCase()/toUpperCase() call, use a Locale | 3 | 93 |
| UseLocaleWithCaseConversions | When doing a String.toLowerCase()/toUpperCase() call, use a Locale | 3 | 97 |
| UseLocaleWithCaseConversions | When doing a String.toLowerCase()/toUpperCase() call, use a Locale | 3 | 97 |
| UnnecessaryConstructor | Avoid unnecessary constructors - the compiler will generate these for you | 3 | 113–115 |
| UncommentedEmptyConstructor | Document empty constructor | 3 | 113–115 |
| CyclomaticComplexity | The method 'getUserList(String, String, String)' has a cyclomatic complexity of 10. | 3 | 124–225 |
| ExcessiveMethodLength | Avoid really long methods. | 3 | 124–225 |
| ShortVariable | Avoid variables with short names like sr | 3 | 127 |
| CyclomaticComplexity | The method 'getUserPublicData(String)' has a cyclomatic complexity of 11. | 3 | 232–334 |
| ExcessiveMethodLength | Avoid really long methods. | 3 | 232–334 |
| ShortVariable | Avoid variables with short names like sr | 3 | 235 |
| AvoidLiteralsInIfCondition | Avoid using Literals in Conditional Statements | 3 | 301 |
| ShortVariable | Avoid variables with short names like in | 3 | 341 |
| InsufficientStringBufferDeclaration | StringBuffer constructor is initialized with size 16, but has at least 26 characters appended. | 3 | 353 |
| ShortVariable | Avoid variables with short names like sb | 3 | 353 |
| ConsecutiveAppendsShouldReuse | StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 3 | 354 |
| ConsecutiveAppendsShouldReuse | StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 3 | 355 |
| ConsecutiveAppendsShouldReuse | StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 3 | 356 |
| PositionLiteralsFirstInCaseInsensitiveComparisons | Position literals first in String comparisons for EqualsIgnoreCase | 3 | 433 |
| UseVarargs | Consider using varargs for methods or constructors which take an array the last parameter. | 4 | 463 |
| UseStringBufferForStringAppends | Prefer StringBuilder (non-synchronized) or StringBuffer (synchronized) over += for concatenating strings | 3 | 471 |
| UseStringBufferForStringAppends | Prefer StringBuilder (non-synchronized) or StringBuffer (synchronized) over += for concatenating strings | 3 | 475 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UseObjectForClearerAPI | Rather than using a lot of String arguments, consider using a container object for those values. | 3 | 68–69 |
| ReplaceHashtableWithMap | Consider replacing this Hashtable with the newer java.util.Map | 3 | 71 |
| UnnecessaryLocalBeforeReturn | Consider simply returning the value vs storing it in local variable 'context' | 3 | 80 |
| UseObjectForClearerAPI | Rather than using a lot of String arguments, consider using a container object for those values. | 3 | 106 |
| ReplaceHashtableWithMap | Consider replacing this Hashtable with the newer java.util.Map | 3 | 111 |
| ShortVariable | Avoid variables with short names like sc | 3 | 134 |
| UnnecessaryLocalBeforeReturn | Consider simply returning the value vs storing it in local variable 'enumeration' | 3 | 138 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| MissingSerialVersionUID | Classes implementing Serializable should set a serialVersionUID | 3 | 65–388 |
| CallSuperInConstructor | It is a good practice to call super() in a constructor | 3 | 117–119 |
| UnnecessaryConstructor | Avoid unnecessary constructors - the compiler will generate these for you | 3 | 117–119 |
| UncommentedEmptyConstructor | Document empty constructor | 3 | 117–119 |
| PositionLiteralsFirstInComparisons | Position literals first in String comparisons | 3 | 163 |
| PositionLiteralsFirstInComparisons | Position literals first in String comparisons | 3 | 163 |
| PositionLiteralsFirstInComparisons | Position literals first in String comparisons | 3 | 163 |
| AvoidCatchingGenericException | Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 3 | 170 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 196 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 197 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 198 |
| UseCollectionIsEmpty | Substitute calls to size() == 0 (or size() != 0, size() > 0, size() < 1) with calls to isEmpty() | 3 | 215 |
| ForLoopCanBeForeach | This for loop can be replaced by a foreach loop | 3 | 380–383 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| ClassNamingConventions | The utility class name 'AutoExportWssoUsersFile' doesn't match '[A-Z][a-zA-Z0-9]+(Utils?|Helper|Home|Service)' | 1 | 43–66 |
| UseUtilityClass | All methods are static. Consider using a utility class instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning. | 3 | 44–66 |
| UnnecessaryConstructor | Avoid unnecessary constructors - the compiler will generate these for you | 3 | 51–53 |
| UncommentedEmptyConstructor | Document empty constructor | 3 | 51–53 |
| AvoidSynchronizedAtMethodLevel | Use block level rather than method level synchronization | 3 | 60–65 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UseUtilityClass | All methods are static. Consider using a utility class instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning. | 3 | 61–216 |
| UnnecessaryConstructor | Avoid unnecessary constructors - the compiler will generate these for you | 3 | 88–90 |
| UncommentedEmptyConstructor | Document empty constructor | 3 | 88–90 |
| SimpleDateFormatNeedsLocale | When instantiating a SimpleDateFormat object, specify a Locale | 3 | 116 |
| AvoidFileStream | Avoid instantiating FileInputStream, FileOutputStream, FileReader, or FileWriter | 1 | 176 |
| AvoidCatchingNPE | Avoid catching NullPointerException; consider removing the cause of the NPE. | 3 | 191 |
| IdenticalCatchBranches | 'catch' branch identical to 'IOException' branch | 3 | 191–195 |
| AvoidCatchingGenericException | Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 3 | 191 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| CallSuperInConstructor | It is a good practice to call super() in a constructor | 3 | 53–55 |
| UnnecessaryConstructor | Avoid unnecessary constructors - the compiler will generate these for you | 3 | 53–55 |
| UncommentedEmptyConstructor | Document empty constructor | 3 | 53–55 |
| MissingOverride | The method 'run()' is missing an @Override annotation. | 3 | 60–65 |
