SpotBugs Bug Detector Report
The following document contains the results of SpotBugs
SpotBugs Version is 4.5.3
Threshold is medium
Effort is default
Summary
| Classes |
Bugs |
Errors |
Missing Classes |
| 23 |
17 |
0 |
0 |
fr.paris.lutece.plugins.mylutece.modules.wssodatabase.authentication.business.WssoUser
| Bug |
Category |
Details |
Line |
Priority |
| fr.paris.lutece.plugins.mylutece.modules.wssodatabase.authentication.business.WssoUser.getDateLastLogin() may expose internal representation by returning WssoUser._dateLastLogin |
MALICIOUS_CODE |
EI_EXPOSE_REP |
174 |
Medium |
| fr.paris.lutece.plugins.mylutece.modules.wssodatabase.authentication.business.WssoUser.setDateLastLogin(Date) may expose internal representation by storing an externally mutable object into WssoUser._dateLastLogin |
MALICIOUS_CODE |
EI_EXPOSE_REP2 |
183 |
Medium |
| Incorrect lazy initialization and update of static field fr.paris.lutece.plugins.mylutece.modules.wssodatabase.authentication.business.WssoUser._listenerRole in fr.paris.lutece.plugins.mylutece.modules.wssodatabase.authentication.business.WssoUser.init() |
MT_CORRECTNESS |
LI_LAZY_INIT_UPDATE_STATIC |
61-63 |
Medium |
fr.paris.lutece.plugins.mylutece.modules.wssodatabase.authentication.service.WssoDatabaseService
| Bug |
Category |
Details |
Line |
Priority |
| instanceof will always return false in fr.paris.lutece.plugins.mylutece.modules.wssodatabase.authentication.service.WssoDatabaseService.loadIdxWSSOUser(String, HttpServletRequest, LuteceAuthentication, Plugin), since a String can't be a java.util.ArrayList |
CORRECTNESS |
BC_IMPOSSIBLE_INSTANCEOF |
177 |
Medium |
fr.paris.lutece.plugins.mylutece.modules.wssodatabase.authentication.web.WssodatabaseJspBean
| Bug |
Category |
Details |
Line |
Priority |
| Write to static field fr.paris.lutece.plugins.mylutece.modules.wssodatabase.authentication.web.WssodatabaseJspBean._plugin from instance method fr.paris.lutece.plugins.mylutece.modules.wssodatabase.authentication.web.WssodatabaseJspBean.doAssignRoleUser(HttpServletRequest) |
STYLE |
ST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD |
368 |
Medium |
| Write to static field fr.paris.lutece.plugins.mylutece.modules.wssodatabase.authentication.web.WssodatabaseJspBean._plugin from instance method fr.paris.lutece.plugins.mylutece.modules.wssodatabase.authentication.web.WssodatabaseJspBean.doCreateUser(HttpServletRequest) |
STYLE |
ST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD |
203 |
Medium |
| Write to static field fr.paris.lutece.plugins.mylutece.modules.wssodatabase.authentication.web.WssodatabaseJspBean._plugin from instance method fr.paris.lutece.plugins.mylutece.modules.wssodatabase.authentication.web.WssodatabaseJspBean.doRemoveUser(HttpServletRequest) |
STYLE |
ST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD |
269 |
Medium |
| Write to static field fr.paris.lutece.plugins.mylutece.modules.wssodatabase.authentication.web.WssodatabaseJspBean._plugin from instance method fr.paris.lutece.plugins.mylutece.modules.wssodatabase.authentication.web.WssodatabaseJspBean.getCreateUser(HttpServletRequest) |
STYLE |
ST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD |
135 |
Medium |
| Write to static field fr.paris.lutece.plugins.mylutece.modules.wssodatabase.authentication.web.WssodatabaseJspBean._plugin from instance method fr.paris.lutece.plugins.mylutece.modules.wssodatabase.authentication.web.WssodatabaseJspBean.getManageRolesUser(HttpServletRequest) |
STYLE |
ST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD |
331 |
Medium |
| Write to static field fr.paris.lutece.plugins.mylutece.modules.wssodatabase.authentication.web.WssodatabaseJspBean._plugin from instance method fr.paris.lutece.plugins.mylutece.modules.wssodatabase.authentication.web.WssodatabaseJspBean.getManageUsers(HttpServletRequest) |
STYLE |
ST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD |
303 |
Medium |
| Write to static field fr.paris.lutece.plugins.mylutece.modules.wssodatabase.authentication.web.WssodatabaseJspBean._plugin from instance method fr.paris.lutece.plugins.mylutece.modules.wssodatabase.authentication.web.WssodatabaseJspBean.getRemoveUser(HttpServletRequest) |
STYLE |
ST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD |
245 |
Medium |
fr.paris.lutece.plugins.mylutece.modules.wssodatabase.service.WssoUsersFileGeneratorService
| Bug |
Category |
Details |
Line |
Priority |
| Do not catch NullPointerException like in fr.paris.lutece.plugins.mylutece.modules.wssodatabase.service.WssoUsersFileGeneratorService.createXmlFile(Plugin) |
STYLE |
DCN_NULLPOINTER_EXCEPTION |
191 |
Medium |
| Found reliance on default encoding in fr.paris.lutece.plugins.mylutece.modules.wssodatabase.service.WssoUsersFileGeneratorService.createXmlFile(Plugin): new java.io.FileWriter(File) |
I18N |
DM_DEFAULT_ENCODING |
176 |
High |
| fr.paris.lutece.plugins.mylutece.modules.wssodatabase.service.WssoUsersFileGeneratorService.createXmlFile(Plugin) may fail to clean up java.io.Writer on checked exception |
EXPERIMENTAL |
OBL_UNSATISFIED_OBLIGATION_EXCEPTION_EDGE |
176 |
Medium |
| Exceptional return value of java.io.File.mkdir() ignored in fr.paris.lutece.plugins.mylutece.modules.wssodatabase.service.WssoUsersFileGeneratorService.createXmlFile(Plugin) |
BAD_PRACTICE |
RV_RETURN_VALUE_IGNORED_BAD_PRACTICE |
169 |
Medium |
| Exceptional return value of java.io.File.renameTo(File) ignored in fr.paris.lutece.plugins.mylutece.modules.wssodatabase.service.WssoUsersFileGeneratorService.createXmlFile(Plugin) |
BAD_PRACTICE |
RV_RETURN_VALUE_IGNORED_BAD_PRACTICE |
183 |
Medium |
| Exceptional return value of java.io.File.delete() ignored in fr.paris.lutece.plugins.mylutece.modules.wssodatabase.service.WssoUsersFileGeneratorService.removeXmlFile() |
BAD_PRACTICE |
RV_RETURN_VALUE_IGNORED_BAD_PRACTICE |
213 |
Medium |
