Fork me on GitHub

PMD Results

The following document contains the results of PMD 6.13.0.

Violations By Priority

Priority 1

fr/paris/lutece/plugins/notifygru/modules/ticketing/Constants.java

Rule Violation Line
ClassNamingConventions The utility class name 'Constants' doesn't match '[A-Z][a-zA-Z0-9]+(Utils?|Helper|Home|Service)' 41–78

fr/paris/lutece/plugins/notifygru/modules/ticketing/service/provider/TicketProvider.java

Rule Violation Line
FieldNamingConventions The field name 'nIdActionRelance' doesn't match '_[a-z][a-zA-Z0-9]*' 101

Priority 3

fr/paris/lutece/plugins/notifygru/modules/ticketing/service/provider/TicketProvider.java

Rule Violation Line
TooManyMethods This class has too many methods, consider refactoring it. 67–511
ImmutableField Private field 'nIdActionRelance' could be made final; it is only initialized in the declaration or constructor. 101
ImmutableField Private field '_ticket' could be made final; it is only initialized in the declaration or constructor. 105
RedundantFieldInitializer Avoid using redundant field initializer for '_bTicketingUnitChanged' 107
NPathComplexity The method 'provideMarkerValues()' has an NPath complexity of 5760 227–317
CyclomaticComplexity The method 'provideMarkerValues()' has a cyclomatic complexity of 16. 227–317
ShortVariable Avoid variables with short names like sb 246
ShortVariable Avoid variables with short names like ns 247
UseStringBufferLength This is an inefficient use of StringBuffer.toString; call StringBuffer.length instead. 286
ConfusingTernary Avoid if (x != y) ..; else ..; 327–345
ConfusingTernary Avoid if (x != y) ..; else ..; 332–345
AppendCharacterWithChar Avoid appending characters as strings in StringBuffer.append. 357
CyclomaticComplexity The method 'getNomServiceBasedOnDomaine(TicketCategory)' has a cyclomatic complexity of 12. 372–398
ConfusingTernary Avoid if (x != y) ..; else ..; 375–396
ConfusingTernary Avoid if (x != y) ..; else ..; 380–395
ConfusingTernary Avoid if (x != y) ..; else ..; 384–395
CyclomaticComplexity The method 'getSignatureBasedOnDomaine(TicketCategory)' has a cyclomatic complexity of 12. 405–431
ConfusingTernary Avoid if (x != y) ..; else ..; 408–429
ConfusingTernary Avoid if (x != y) ..; else ..; 413–428
ConfusingTernary Avoid if (x != y) ..; else ..; 417–428

Files

fr/paris/lutece/plugins/notifygru/modules/ticketing/Constants.java

Rule Violation Priority Line
ClassNamingConventions The utility class name 'Constants' doesn't match '[A-Z][a-zA-Z0-9]+(Utils?|Helper|Home|Service)' 1 41–78

fr/paris/lutece/plugins/notifygru/modules/ticketing/service/provider/TicketProvider.java

Rule Violation Priority Line
TooManyMethods This class has too many methods, consider refactoring it. 3 67–511
ImmutableField Private field 'nIdActionRelance' could be made final; it is only initialized in the declaration or constructor. 3 101
FieldNamingConventions The field name 'nIdActionRelance' doesn't match '_[a-z][a-zA-Z0-9]*' 1 101
ImmutableField Private field '_ticket' could be made final; it is only initialized in the declaration or constructor. 3 105
RedundantFieldInitializer Avoid using redundant field initializer for '_bTicketingUnitChanged' 3 107
NPathComplexity The method 'provideMarkerValues()' has an NPath complexity of 5760 3 227–317
CyclomaticComplexity The method 'provideMarkerValues()' has a cyclomatic complexity of 16. 3 227–317
ShortVariable Avoid variables with short names like sb 3 246
ShortVariable Avoid variables with short names like ns 3 247
UseStringBufferLength This is an inefficient use of StringBuffer.toString; call StringBuffer.length instead. 3 286
ConfusingTernary Avoid if (x != y) ..; else ..; 3 327–345
ConfusingTernary Avoid if (x != y) ..; else ..; 3 332–345
AppendCharacterWithChar Avoid appending characters as strings in StringBuffer.append. 3 357
CyclomaticComplexity The method 'getNomServiceBasedOnDomaine(TicketCategory)' has a cyclomatic complexity of 12. 3 372–398
ConfusingTernary Avoid if (x != y) ..; else ..; 3 375–396
ConfusingTernary Avoid if (x != y) ..; else ..; 3 380–395
ConfusingTernary Avoid if (x != y) ..; else ..; 3 384–395
CyclomaticComplexity The method 'getSignatureBasedOnDomaine(TicketCategory)' has a cyclomatic complexity of 12. 3 405–431
ConfusingTernary Avoid if (x != y) ..; else ..; 3 408–429
ConfusingTernary Avoid if (x != y) ..; else ..; 3 413–428
ConfusingTernary Avoid if (x != y) ..; else ..; 3 417–428