Fork me on GitHub

PMD Results

The following document contains the results of PMD 6.13.0.

Violations By Priority

Priority 1

fr/paris/lutece/plugins/workflow/modules/formscarto/business/AbstractFilterDao.java

Rule Violation Line
FieldNamingConventions The constant name '_listPrefixToRemove' doesn't match '[A-Z][A-Z_0-9]*' 70
FieldNamingConventions The constant name '_listTypeAllowedForSearch' doesn't match '[A-Z][A-Z_0-9]*' 71
FormalParameterNamingConventions The method parameter name 'SQL_QUERY_SELECTALL_ID' doesn't match '[a-z][a-zA-Z0-9]*' 84
LocalVariableNamingConventions The local variable name 'WhereClauses' doesn't match '[a-z][a-zA-Z0-9]*' 104

fr/paris/lutece/plugins/workflow/modules/formscarto/business/EditFormResponseConfigValueCartoHome.java

Rule Violation Line
ClassWithOnlyPrivateConstructorsShouldBeFinal A class which only has private constructors should be final 42–116

fr/paris/lutece/plugins/workflow/modules/formscarto/business/EditFormsCartoUnitTree.java

Rule Violation Line
FormalParameterNamingConventions The method parameter name '_nIdConfig' doesn't match '[a-z][a-zA-Z0-9]*' 148

fr/paris/lutece/plugins/workflow/modules/formscarto/business/FormsCartoTaskConfig.java

Rule Violation Line
FormalParameterNamingConventions The method parameter name '_listEditFormsCartoUnitTree' doesn't match '[a-z][a-zA-Z0-9]*' 146
FormalParameterNamingConventions The method parameter name '_questionUnitTree' doesn't match '[a-z][a-zA-Z0-9]*' 210

fr/paris/lutece/plugins/workflow/modules/formscarto/business/IEditFormsCartoUnitTreeDAO.java

Rule Violation Line
FormalParameterNamingConventions The method parameter name '_plugin' doesn't match '[a-z][a-zA-Z0-9]*' 118

fr/paris/lutece/plugins/workflow/modules/formscarto/web/FormsCartoTaskComponent.java

Rule Violation Line
LocalVariableNamingConventions The local variable name 'id_affectation' doesn't match '[a-z][a-zA-Z0-9]*' 196
LocalVariableNamingConventions The local variable name 'field_carto' doesn't match '[a-z][a-zA-Z0-9]*' 317
LocalVariableNamingConventions The local variable name '_unitService' doesn't match '[a-z][a-zA-Z0-9]*' 678

Priority 3

fr/paris/lutece/plugins/workflow/modules/formscarto/business/AbstractFilterDao.java

Rule Violation Line
CommentRequired Header comments are required 45–251
AbstractClassWithoutAbstractMethod This abstract class does not have any abstract methods 45–251
LooseCoupling Avoid using implementation types like 'HashMap'; use the interface instead 48
UnusedPrivateField Avoid unused private fields such as 'SQL_ASC'. 60
UnusedPrivateField Avoid unused private fields such as 'SQL_DESC'. 61
ConsecutiveAppendsShouldReuse StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 88
ConsecutiveAppendsShouldReuse StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 89
AvoidDeeplyNestedIfStmts Deeply nested if..then statements are hard to read 116–121
CollapsibleIfStatements These nested if statements could be combined 116–121
ConsecutiveAppendsShouldReuse StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 144
ConsecutiveAppendsShouldReuse StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 145

fr/paris/lutece/plugins/workflow/modules/formscarto/business/EditFormResponseConfigCarto.java

Rule Violation Line
CommentRequired Header comments are required 42–103
RedundantFieldInitializer Avoid using redundant field initializer for '_bMultiform' 45
CommentRequired Public method and constructor comments are required 82–85

fr/paris/lutece/plugins/workflow/modules/formscarto/business/EditFormResponseConfigCartoDao.java

Rule Violation Line
CommentRequired Header comments are required 41–123

fr/paris/lutece/plugins/workflow/modules/formscarto/business/EditFormResponseConfigValueCarto.java

Rule Violation Line
CommentRequired Header comments are required 7–128

fr/paris/lutece/plugins/workflow/modules/formscarto/business/EditFormResponseConfigValueCartoDao.java

Rule Violation Line
ConfusingTernary Avoid if (x != y) ..; else ..; 71–78
ConfusingTernary Avoid if (x != y) ..; else ..; 79–86
ConfusingTernary Avoid if (x != y) ..; else ..; 87–94
ConfusingTernary Avoid if (x != y) ..; else ..; 95–102
ConfusingTernary Avoid if (x != y) ..; else ..; 122–129
ConfusingTernary Avoid if (x != y) ..; else ..; 130–137
ConfusingTernary Avoid if (x != y) ..; else ..; 138–145
ConfusingTernary Avoid if (x != y) ..; else ..; 146–153

fr/paris/lutece/plugins/workflow/modules/formscarto/business/EditFormResponseConfigValueCartoHome.java

Rule Violation Line
CommentRequired Header comments are required 42–116

fr/paris/lutece/plugins/workflow/modules/formscarto/business/EditFormsCartoUnitTree.java

Rule Violation Line
CommentRequired Public method and constructor comments are required 144–146
CommentRequired Public method and constructor comments are required 148–150

fr/paris/lutece/plugins/workflow/modules/formscarto/business/EditFormsCartoUnitTreeDAO.java

Rule Violation Line
TooManyMethods This class has too many methods, consider refactoring it. 55–318
CallSuperInConstructor It is a good practice to call super() in a constructor 72–75
ForLoopCanBeForeach This for loop can be replaced by a foreach loop 254–257

fr/paris/lutece/plugins/workflow/modules/formscarto/business/FormsCartoTaskConfig.java

Rule Violation Line
RedundantFieldInitializer Avoid using redundant field initializer for '_bMultiform' 54
CommentRequired Public method and constructor comments are required 120–123
CommentRequired Public method and constructor comments are required 150–153

fr/paris/lutece/plugins/workflow/modules/formscarto/business/FormsCartoTaskConfigDAO.java

Rule Violation Line
ConfusingTernary Avoid if (x != y) ..; else ..; 70–77
ConfusingTernary Avoid if (x != y) ..; else ..; 78–85
ConfusingTernary Avoid if (x != y) ..; else ..; 86–93
ConfusingTernary Avoid if (x != y) ..; else ..; 94–101
ConfusingTernary Avoid if (x != y) ..; else ..; 102–109
ConfusingTernary Avoid if (x != y) ..; else ..; 127–134
ConfusingTernary Avoid if (x != y) ..; else ..; 135–142
ConfusingTernary Avoid if (x != y) ..; else ..; 143–150
ConfusingTernary Avoid if (x != y) ..; else ..; 151–158
ConfusingTernary Avoid if (x != y) ..; else ..; 159–166

fr/paris/lutece/plugins/workflow/modules/formscarto/service/EditFormResponseCartoTask.java

Rule Violation Line
CommentRequired Header comments are required 3–5

fr/paris/lutece/plugins/workflow/modules/formscarto/service/FormsCartoTask.java

Rule Violation Line
ExcessiveImports A high number of imports can indicate a high degree of coupling within an object. 35–374
CyclomaticComplexity The method 'processTaskWithResult(int, String, int, HttpServletRequest, Locale, User)' has a cyclomatic complexity of 25. 135–314
NPathComplexity The method 'processTaskWithResult(int, String, int, HttpServletRequest, Locale, User)' has an NPath complexity of 3084 135–314
NcssCount The method 'processTaskWithResult(int, String, int, HttpServletRequest, Locale, User)' has a NCSS line count of 76. 135–314
ExcessiveMethodLength Avoid really long methods. 135–314
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 144
UnusedLocalVariable Avoid unused local variables such as 'questionListLayerCarto'. 144
UnusedLocalVariable Avoid unused local variables such as 'uid'. 206
AvoidDeeplyNestedIfStmts Deeply nested if..then statements are hard to read 211–214
UnusedLocalVariable Avoid unused local variables such as 'h'. 215
ShortVariable Avoid variables with short names like h 215
AvoidPrintStackTrace Avoid printStackTrace(); use a logger call instead. 234
AvoidDeeplyNestedIfStmts Deeply nested if..then statements are hard to read 243–244
ControlStatementBraces This statement should have braces 244
AvoidDeeplyNestedIfStmts Deeply nested if..then statements are hard to read 245–248
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 254
AvoidDeeplyNestedIfStmts Deeply nested if..then statements are hard to read 257–260
AvoidDeeplyNestedIfStmts Deeply nested if..then statements are hard to read 270–271
ControlStatementBraces This statement should have braces 271
CommentRequired Public method and constructor comments are required 328–370
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 331
UnusedLocalVariable Avoid unused local variables such as 'strValueResponse'. 331
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 338
UseCollectionIsEmpty Substitute calls to size() == 0 (or size() != 0, size() > 0, size() < 1) with calls to isEmpty() 360
ControlStatementBraces This statement should have braces 361
ControlStatementBraces This statement should have braces 363

fr/paris/lutece/plugins/workflow/modules/formscarto/service/FormsCartoTaskService.java

Rule Violation Line
UnusedPrivateField Avoid unused private fields such as '_formService'. 70
UnnecessaryLocalBeforeReturn Consider simply returning the value vs storing it in local variable 'config' 85
UnusedLocalVariable Avoid unused local variables such as 'conf'. 120
CommentRequired Public method and constructor comments are required 144–153

fr/paris/lutece/plugins/workflow/modules/formscarto/web/FormsCartoTaskComponent.java

Rule Violation Line
ExcessiveImports A high number of imports can indicate a high degree of coupling within an object. 34–690
UnusedPrivateField Avoid unused private fields such as 'TEMPLATE_TASK_INFORMATION'. 85
UnusedPrivateField Avoid unused private fields such as 'MARK_MAPPING_LIST'. 96
UnusedPrivateField Avoid unused private fields such as 'MARK_MULTIFORM'. 97
UnusedPrivateField Avoid unused private fields such as 'MARK_CODE_LIST'. 98
UnusedPrivateField Avoid unused private fields such as 'MARK_ID_FORM_CARTO'. 107
UnusedPrivateField Avoid unused private fields such as 'MARK_MAPPING_LIST_CARTO'. 113
UnusedPrivateField Avoid unused private fields such as 'MARK_MULTIFORM_CARTO'. 114
UnusedPrivateField Avoid unused private fields such as 'MARK_CODE_LIST_CARTO'. 115
UnusedPrivateField Avoid unused private fields such as 'MARK_STEP_LIST_CARTO'. 117
UnusedPrivateField Avoid unused private fields such as 'PARAMETER_MULTIFORM'. 124
UnusedPrivateField Avoid unused private fields such as 'PARAMETER_MAPPING_ID'. 128
UnusedPrivateField Avoid unused private fields such as 'PARAMETER_CODE'. 129
UnusedPrivateField Avoid unused private fields such as 'PARAMETER_RESPONSE'. 130
UnusedPrivateField Avoid unused private fields such as 'PARAMETER_ACTION_CARTO'. 132
UnusedPrivateField Avoid unused private fields such as 'PARAMETER_MULTIFORM_CARTO'. 133
UnusedPrivateField Avoid unused private fields such as 'PARAMETER_FORM_CARTO'. 134
UnusedPrivateField Avoid unused private fields such as 'PARAMETER_STEP_CARTO'. 135
UnusedPrivateField Avoid unused private fields such as 'PARAMETER_MAPPING_ID_CARTO'. 138
UnusedPrivateField Avoid unused private fields such as 'PARAMETER_CODE_CARTO'. 139
UnusedPrivateField Avoid unused private fields such as 'PARAMETER_RESPONSE_CARTO'. 140
UnusedPrivateField Avoid unused private fields such as 'ACTION_SELECT_MULTIFORM'. 151
UnusedPrivateField Avoid unused private fields such as 'ACTION_SELECT_RESPONSE'. 154
UnusedPrivateField Avoid unused private fields such as 'ACTION_REMOVE_MAPPING'. 155
UnusedPrivateField Avoid unused private fields such as 'ACTION_SELECT_CODE'. 156
UnusedPrivateField Avoid unused private fields such as 'ACTION_SELECT_FORM_CARTO'. 158
UnusedPrivateField Avoid unused private fields such as 'ACTION_SELECT_MULTIFORM_CARTO'. 159
UnusedPrivateField Avoid unused private fields such as 'ACTION_SELECT_STEP_CARTO'. 160
UnusedPrivateField Avoid unused private fields such as 'ACTION_SELECT_RESPONSE_CARTO'. 163
UnusedPrivateField Avoid unused private fields such as 'ACTION_REMOVE_MAPPING_CARTO'. 164
UnusedPrivateField Avoid unused private fields such as 'ACTION_SELECT_CODE_CARTO'. 165
UnusedPrivateField Avoid unused private fields such as 'MESSAGE_INFORMATION_TASK'. 169
CyclomaticComplexity The method 'getDisplayConfigForm(HttpServletRequest, Locale, ITask)' has a cyclomatic complexity of 16. 190–302
NPathComplexity The method 'getDisplayConfigForm(HttpServletRequest, Locale, ITask)' has an NPath complexity of 16384 190–302
ExcessiveMethodLength Avoid really long methods. 190–302
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 192
UnusedLocalVariable Avoid unused local variables such as 'config'. 192
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 230
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 230
ControlStatementBraces This statement should have braces 292
CommentRequired Protected method constructor comments are required 433–436
ControlStatementBraces This statement should have braces 464
ControlStatementBraces This statement should have braces 472
MissingBreakInSwitch A switch statement does not contain a break 536–606
CommentRequired Public method and constructor comments are required 609–625
CommentRequired Public method and constructor comments are required 627–651
ControlStatementBraces This statement should have braces 644
CommentRequired Public method and constructor comments are required 653–670
CommentRequired Public method and constructor comments are required 672–688

Priority 4

fr/paris/lutece/plugins/workflow/modules/formscarto/business/AbstractFilterDao.java

Rule Violation Line
UnusedImports Avoid unused imports such as 'java.util.ArrayList' 37

fr/paris/lutece/plugins/workflow/modules/formscarto/service/FormsCartoTaskService.java

Rule Violation Line
UnusedImports Avoid unused imports such as 'fr.paris.lutece.plugins.workflow.modules.forms.business.EditFormResponseConfigValue' 51
UnusedImports Avoid unused imports such as 'fr.paris.lutece.plugins.workflow.modules.forms.business.EditFormResponseConfigValueHome' 52
UnusedImports Avoid unused imports such as 'fr.paris.lutece.plugins.workflow.modules.formscarto.business.EditFormResponseConfigValueCarto' 54
UnusedImports Avoid unused imports such as 'fr.paris.lutece.plugins.workflow.modules.formscarto.business.EditFormsCartoUnitTreeHome' 57

fr/paris/lutece/plugins/workflow/modules/formscarto/web/FormsCartoTaskComponent.java

Rule Violation Line
UnusedImports Avoid unused imports such as 'fr.paris.lutece.plugins.carto.business.DataLayerHome' 42
UnusedImports Avoid unused imports such as 'fr.paris.lutece.plugins.forms.business.Form' 44
UnusedImports Avoid unused imports such as 'fr.paris.lutece.plugins.unittree.service.unit.IUnitUserService' 53
UnusedImports Avoid unused imports such as 'fr.paris.lutece.plugins.workflow.modules.formscarto.business.EditFormResponseConfigValueCarto' 56
UnusedImports Avoid unused imports such as 'fr.paris.lutece.plugins.workflow.modules.formscarto.business.EditFormResponseConfigValueCartoHome' 57
UnusedImports Avoid unused imports such as 'fr.paris.lutece.plugins.workflow.web.task.AbstractTaskComponent' 61

Files

fr/paris/lutece/plugins/workflow/modules/formscarto/business/AbstractFilterDao.java

Rule Violation Priority Line
UnusedImports Avoid unused imports such as 'java.util.ArrayList' 4 37
CommentRequired Header comments are required 3 45–251
AbstractClassWithoutAbstractMethod This abstract class does not have any abstract methods 3 45–251
LooseCoupling Avoid using implementation types like 'HashMap'; use the interface instead 3 48
UnusedPrivateField Avoid unused private fields such as 'SQL_ASC'. 3 60
UnusedPrivateField Avoid unused private fields such as 'SQL_DESC'. 3 61
FieldNamingConventions The constant name '_listPrefixToRemove' doesn't match '[A-Z][A-Z_0-9]*' 1 70
FieldNamingConventions The constant name '_listTypeAllowedForSearch' doesn't match '[A-Z][A-Z_0-9]*' 1 71
FormalParameterNamingConventions The method parameter name 'SQL_QUERY_SELECTALL_ID' doesn't match '[a-z][a-zA-Z0-9]*' 1 84
ConsecutiveAppendsShouldReuse StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 3 88
ConsecutiveAppendsShouldReuse StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 3 89
LocalVariableNamingConventions The local variable name 'WhereClauses' doesn't match '[a-z][a-zA-Z0-9]*' 1 104
AvoidDeeplyNestedIfStmts Deeply nested if..then statements are hard to read 3 116–121
CollapsibleIfStatements These nested if statements could be combined 3 116–121
ConsecutiveAppendsShouldReuse StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 3 144
ConsecutiveAppendsShouldReuse StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 3 145

fr/paris/lutece/plugins/workflow/modules/formscarto/business/EditFormResponseConfigCarto.java

Rule Violation Priority Line
CommentRequired Header comments are required 3 42–103
RedundantFieldInitializer Avoid using redundant field initializer for '_bMultiform' 3 45
CommentRequired Public method and constructor comments are required 3 82–85

fr/paris/lutece/plugins/workflow/modules/formscarto/business/EditFormResponseConfigCartoDao.java

Rule Violation Priority Line
CommentRequired Header comments are required 3 41–123

fr/paris/lutece/plugins/workflow/modules/formscarto/business/EditFormResponseConfigValueCarto.java

Rule Violation Priority Line
CommentRequired Header comments are required 3 7–128

fr/paris/lutece/plugins/workflow/modules/formscarto/business/EditFormResponseConfigValueCartoDao.java

Rule Violation Priority Line
ConfusingTernary Avoid if (x != y) ..; else ..; 3 71–78
ConfusingTernary Avoid if (x != y) ..; else ..; 3 79–86
ConfusingTernary Avoid if (x != y) ..; else ..; 3 87–94
ConfusingTernary Avoid if (x != y) ..; else ..; 3 95–102
ConfusingTernary Avoid if (x != y) ..; else ..; 3 122–129
ConfusingTernary Avoid if (x != y) ..; else ..; 3 130–137
ConfusingTernary Avoid if (x != y) ..; else ..; 3 138–145
ConfusingTernary Avoid if (x != y) ..; else ..; 3 146–153

fr/paris/lutece/plugins/workflow/modules/formscarto/business/EditFormResponseConfigValueCartoHome.java

Rule Violation Priority Line
CommentRequired Header comments are required 3 42–116
ClassWithOnlyPrivateConstructorsShouldBeFinal A class which only has private constructors should be final 1 42–116

fr/paris/lutece/plugins/workflow/modules/formscarto/business/EditFormsCartoUnitTree.java

Rule Violation Priority Line
CommentRequired Public method and constructor comments are required 3 144–146
FormalParameterNamingConventions The method parameter name '_nIdConfig' doesn't match '[a-z][a-zA-Z0-9]*' 1 148
CommentRequired Public method and constructor comments are required 3 148–150

fr/paris/lutece/plugins/workflow/modules/formscarto/business/EditFormsCartoUnitTreeDAO.java

Rule Violation Priority Line
TooManyMethods This class has too many methods, consider refactoring it. 3 55–318
CallSuperInConstructor It is a good practice to call super() in a constructor 3 72–75
ForLoopCanBeForeach This for loop can be replaced by a foreach loop 3 254–257

fr/paris/lutece/plugins/workflow/modules/formscarto/business/FormsCartoTaskConfig.java

Rule Violation Priority Line
RedundantFieldInitializer Avoid using redundant field initializer for '_bMultiform' 3 54
CommentRequired Public method and constructor comments are required 3 120–123
FormalParameterNamingConventions The method parameter name '_listEditFormsCartoUnitTree' doesn't match '[a-z][a-zA-Z0-9]*' 1 146
CommentRequired Public method and constructor comments are required 3 150–153
FormalParameterNamingConventions The method parameter name '_questionUnitTree' doesn't match '[a-z][a-zA-Z0-9]*' 1 210

fr/paris/lutece/plugins/workflow/modules/formscarto/business/FormsCartoTaskConfigDAO.java

Rule Violation Priority Line
ConfusingTernary Avoid if (x != y) ..; else ..; 3 70–77
ConfusingTernary Avoid if (x != y) ..; else ..; 3 78–85
ConfusingTernary Avoid if (x != y) ..; else ..; 3 86–93
ConfusingTernary Avoid if (x != y) ..; else ..; 3 94–101
ConfusingTernary Avoid if (x != y) ..; else ..; 3 102–109
ConfusingTernary Avoid if (x != y) ..; else ..; 3 127–134
ConfusingTernary Avoid if (x != y) ..; else ..; 3 135–142
ConfusingTernary Avoid if (x != y) ..; else ..; 3 143–150
ConfusingTernary Avoid if (x != y) ..; else ..; 3 151–158
ConfusingTernary Avoid if (x != y) ..; else ..; 3 159–166

fr/paris/lutece/plugins/workflow/modules/formscarto/business/IEditFormsCartoUnitTreeDAO.java

Rule Violation Priority Line
FormalParameterNamingConventions The method parameter name '_plugin' doesn't match '[a-z][a-zA-Z0-9]*' 1 118

fr/paris/lutece/plugins/workflow/modules/formscarto/service/EditFormResponseCartoTask.java

Rule Violation Priority Line
CommentRequired Header comments are required 3 3–5

fr/paris/lutece/plugins/workflow/modules/formscarto/service/FormsCartoTask.java

Rule Violation Priority Line
ExcessiveImports A high number of imports can indicate a high degree of coupling within an object. 3 35–374
CyclomaticComplexity The method 'processTaskWithResult(int, String, int, HttpServletRequest, Locale, User)' has a cyclomatic complexity of 25. 3 135–314
NPathComplexity The method 'processTaskWithResult(int, String, int, HttpServletRequest, Locale, User)' has an NPath complexity of 3084 3 135–314
NcssCount The method 'processTaskWithResult(int, String, int, HttpServletRequest, Locale, User)' has a NCSS line count of 76. 3 135–314
ExcessiveMethodLength Avoid really long methods. 3 135–314
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 3 144
UnusedLocalVariable Avoid unused local variables such as 'questionListLayerCarto'. 3 144
UnusedLocalVariable Avoid unused local variables such as 'uid'. 3 206
AvoidDeeplyNestedIfStmts Deeply nested if..then statements are hard to read 3 211–214
UnusedLocalVariable Avoid unused local variables such as 'h'. 3 215
ShortVariable Avoid variables with short names like h 3 215
AvoidPrintStackTrace Avoid printStackTrace(); use a logger call instead. 3 234
AvoidDeeplyNestedIfStmts Deeply nested if..then statements are hard to read 3 243–244
ControlStatementBraces This statement should have braces 3 244
AvoidDeeplyNestedIfStmts Deeply nested if..then statements are hard to read 3 245–248
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 3 254
AvoidDeeplyNestedIfStmts Deeply nested if..then statements are hard to read 3 257–260
AvoidDeeplyNestedIfStmts Deeply nested if..then statements are hard to read 3 270–271
ControlStatementBraces This statement should have braces 3 271
CommentRequired Public method and constructor comments are required 3 328–370
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 3 331
UnusedLocalVariable Avoid unused local variables such as 'strValueResponse'. 3 331
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 3 338
UseCollectionIsEmpty Substitute calls to size() == 0 (or size() != 0, size() > 0, size() < 1) with calls to isEmpty() 3 360
ControlStatementBraces This statement should have braces 3 361
ControlStatementBraces This statement should have braces 3 363

fr/paris/lutece/plugins/workflow/modules/formscarto/service/FormsCartoTaskService.java

Rule Violation Priority Line
UnusedImports Avoid unused imports such as 'fr.paris.lutece.plugins.workflow.modules.forms.business.EditFormResponseConfigValue' 4 51
UnusedImports Avoid unused imports such as 'fr.paris.lutece.plugins.workflow.modules.forms.business.EditFormResponseConfigValueHome' 4 52
UnusedImports Avoid unused imports such as 'fr.paris.lutece.plugins.workflow.modules.formscarto.business.EditFormResponseConfigValueCarto' 4 54
UnusedImports Avoid unused imports such as 'fr.paris.lutece.plugins.workflow.modules.formscarto.business.EditFormsCartoUnitTreeHome' 4 57
UnusedPrivateField Avoid unused private fields such as '_formService'. 3 70
UnnecessaryLocalBeforeReturn Consider simply returning the value vs storing it in local variable 'config' 3 85
UnusedLocalVariable Avoid unused local variables such as 'conf'. 3 120
CommentRequired Public method and constructor comments are required 3 144–153

fr/paris/lutece/plugins/workflow/modules/formscarto/web/FormsCartoTaskComponent.java

Rule Violation Priority Line
ExcessiveImports A high number of imports can indicate a high degree of coupling within an object. 3 34–690
UnusedImports Avoid unused imports such as 'fr.paris.lutece.plugins.carto.business.DataLayerHome' 4 42
UnusedImports Avoid unused imports such as 'fr.paris.lutece.plugins.forms.business.Form' 4 44
UnusedImports Avoid unused imports such as 'fr.paris.lutece.plugins.unittree.service.unit.IUnitUserService' 4 53
UnusedImports Avoid unused imports such as 'fr.paris.lutece.plugins.workflow.modules.formscarto.business.EditFormResponseConfigValueCarto' 4 56
UnusedImports Avoid unused imports such as 'fr.paris.lutece.plugins.workflow.modules.formscarto.business.EditFormResponseConfigValueCartoHome' 4 57
UnusedImports Avoid unused imports such as 'fr.paris.lutece.plugins.workflow.web.task.AbstractTaskComponent' 4 61
UnusedPrivateField Avoid unused private fields such as 'TEMPLATE_TASK_INFORMATION'. 3 85
UnusedPrivateField Avoid unused private fields such as 'MARK_MAPPING_LIST'. 3 96
UnusedPrivateField Avoid unused private fields such as 'MARK_MULTIFORM'. 3 97
UnusedPrivateField Avoid unused private fields such as 'MARK_CODE_LIST'. 3 98
UnusedPrivateField Avoid unused private fields such as 'MARK_ID_FORM_CARTO'. 3 107
UnusedPrivateField Avoid unused private fields such as 'MARK_MAPPING_LIST_CARTO'. 3 113
UnusedPrivateField Avoid unused private fields such as 'MARK_MULTIFORM_CARTO'. 3 114
UnusedPrivateField Avoid unused private fields such as 'MARK_CODE_LIST_CARTO'. 3 115
UnusedPrivateField Avoid unused private fields such as 'MARK_STEP_LIST_CARTO'. 3 117
UnusedPrivateField Avoid unused private fields such as 'PARAMETER_MULTIFORM'. 3 124
UnusedPrivateField Avoid unused private fields such as 'PARAMETER_MAPPING_ID'. 3 128
UnusedPrivateField Avoid unused private fields such as 'PARAMETER_CODE'. 3 129
UnusedPrivateField Avoid unused private fields such as 'PARAMETER_RESPONSE'. 3 130
UnusedPrivateField Avoid unused private fields such as 'PARAMETER_ACTION_CARTO'. 3 132
UnusedPrivateField Avoid unused private fields such as 'PARAMETER_MULTIFORM_CARTO'. 3 133
UnusedPrivateField Avoid unused private fields such as 'PARAMETER_FORM_CARTO'. 3 134
UnusedPrivateField Avoid unused private fields such as 'PARAMETER_STEP_CARTO'. 3 135
UnusedPrivateField Avoid unused private fields such as 'PARAMETER_MAPPING_ID_CARTO'. 3 138
UnusedPrivateField Avoid unused private fields such as 'PARAMETER_CODE_CARTO'. 3 139
UnusedPrivateField Avoid unused private fields such as 'PARAMETER_RESPONSE_CARTO'. 3 140
UnusedPrivateField Avoid unused private fields such as 'ACTION_SELECT_MULTIFORM'. 3 151
UnusedPrivateField Avoid unused private fields such as 'ACTION_SELECT_RESPONSE'. 3 154
UnusedPrivateField Avoid unused private fields such as 'ACTION_REMOVE_MAPPING'. 3 155
UnusedPrivateField Avoid unused private fields such as 'ACTION_SELECT_CODE'. 3 156
UnusedPrivateField Avoid unused private fields such as 'ACTION_SELECT_FORM_CARTO'. 3 158
UnusedPrivateField Avoid unused private fields such as 'ACTION_SELECT_MULTIFORM_CARTO'. 3 159
UnusedPrivateField Avoid unused private fields such as 'ACTION_SELECT_STEP_CARTO'. 3 160
UnusedPrivateField Avoid unused private fields such as 'ACTION_SELECT_RESPONSE_CARTO'. 3 163
UnusedPrivateField Avoid unused private fields such as 'ACTION_REMOVE_MAPPING_CARTO'. 3 164
UnusedPrivateField Avoid unused private fields such as 'ACTION_SELECT_CODE_CARTO'. 3 165
UnusedPrivateField Avoid unused private fields such as 'MESSAGE_INFORMATION_TASK'. 3 169
CyclomaticComplexity The method 'getDisplayConfigForm(HttpServletRequest, Locale, ITask)' has a cyclomatic complexity of 16. 3 190–302
NPathComplexity The method 'getDisplayConfigForm(HttpServletRequest, Locale, ITask)' has an NPath complexity of 16384 3 190–302
ExcessiveMethodLength Avoid really long methods. 3 190–302
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 3 192
UnusedLocalVariable Avoid unused local variables such as 'config'. 3 192
LocalVariableNamingConventions The local variable name 'id_affectation' doesn't match '[a-z][a-zA-Z0-9]*' 1 196
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 3 230
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 3 230
ControlStatementBraces This statement should have braces 3 292
LocalVariableNamingConventions The local variable name 'field_carto' doesn't match '[a-z][a-zA-Z0-9]*' 1 317
CommentRequired Protected method constructor comments are required 3 433–436
ControlStatementBraces This statement should have braces 3 464
ControlStatementBraces This statement should have braces 3 472
MissingBreakInSwitch A switch statement does not contain a break 3 536–606
CommentRequired Public method and constructor comments are required 3 609–625
CommentRequired Public method and constructor comments are required 3 627–651
ControlStatementBraces This statement should have braces 3 644
CommentRequired Public method and constructor comments are required 3 653–670
CommentRequired Public method and constructor comments are required 3 672–688
LocalVariableNamingConventions The local variable name '_unitService' doesn't match '[a-z][a-zA-Z0-9]*' 1 678