Fork me on GitHub

SpotBugs Bug Detector Report

The following document contains the results of SpotBugs

SpotBugs Version is 4.5.3

Threshold is medium

Effort is default

Summary

Classes Bugs Errors Missing Classes
17 30 0 0

Files

Class Bugs
fr.paris.lutece.plugins.workflow.modules.formscarto.business.AbstractFilterDao 1
fr.paris.lutece.plugins.workflow.modules.formscarto.business.EditFormResponseConfigValueCarto 6
fr.paris.lutece.plugins.workflow.modules.formscarto.business.FormsCartoTaskConfig 12
fr.paris.lutece.plugins.workflow.modules.formscarto.service.FormsCartoTask 4
fr.paris.lutece.plugins.workflow.modules.formscarto.service.FormsCartoTaskService 1
fr.paris.lutece.plugins.workflow.modules.formscarto.web.FormsCartoTaskComponent 6

fr.paris.lutece.plugins.workflow.modules.formscarto.business.AbstractFilterDao

Bug Category Details Line Priority
fr.paris.lutece.plugins.workflow.modules.formscarto.business.AbstractFilterDao._listTypeAllowedForSearch is a mutable collection which should be package protected MALICIOUS_CODE MS_MUTABLE_COLLECTION_PKGPROTECT 71 Medium

fr.paris.lutece.plugins.workflow.modules.formscarto.business.EditFormResponseConfigValueCarto

Bug Category Details Line Priority
fr.paris.lutece.plugins.workflow.modules.formscarto.business.EditFormResponseConfigValueCarto.getForm() may expose internal representation by returning EditFormResponseConfigValueCarto._form MALICIOUS_CODE EI_EXPOSE_REP 87 Medium
fr.paris.lutece.plugins.workflow.modules.formscarto.business.EditFormResponseConfigValueCarto.getQuestion() may expose internal representation by returning EditFormResponseConfigValueCarto._question MALICIOUS_CODE EI_EXPOSE_REP 73 Medium
fr.paris.lutece.plugins.workflow.modules.formscarto.business.EditFormResponseConfigValueCarto.getStep() may expose internal representation by returning EditFormResponseConfigValueCarto._step MALICIOUS_CODE EI_EXPOSE_REP 56 Medium
fr.paris.lutece.plugins.workflow.modules.formscarto.business.EditFormResponseConfigValueCarto.setForm(Form) may expose internal representation by storing an externally mutable object into EditFormResponseConfigValueCarto._form MALICIOUS_CODE EI_EXPOSE_REP2 92 Medium
fr.paris.lutece.plugins.workflow.modules.formscarto.business.EditFormResponseConfigValueCarto.setQuestion(Question) may expose internal representation by storing an externally mutable object into EditFormResponseConfigValueCarto._question MALICIOUS_CODE EI_EXPOSE_REP2 82 Medium
fr.paris.lutece.plugins.workflow.modules.formscarto.business.EditFormResponseConfigValueCarto.setStep(Step) may expose internal representation by storing an externally mutable object into EditFormResponseConfigValueCarto._step MALICIOUS_CODE EI_EXPOSE_REP2 65 Medium

fr.paris.lutece.plugins.workflow.modules.formscarto.business.FormsCartoTaskConfig

Bug Category Details Line Priority
fr.paris.lutece.plugins.workflow.modules.formscarto.business.FormsCartoTaskConfig.getForm() may expose internal representation by returning FormsCartoTaskConfig._form MALICIOUS_CODE EI_EXPOSE_REP 216 Medium
fr.paris.lutece.plugins.workflow.modules.formscarto.business.FormsCartoTaskConfig.getListEditFormsCartoUnitTree() may expose internal representation by returning FormsCartoTaskConfig._listEditFormsCartoUnitTree MALICIOUS_CODE EI_EXPOSE_REP 143 Medium
fr.paris.lutece.plugins.workflow.modules.formscarto.business.FormsCartoTaskConfig.getQuestionListLayerCarto() may expose internal representation by returning FormsCartoTaskConfig._questionListLayerCarto MALICIOUS_CODE EI_EXPOSE_REP 194 Medium
fr.paris.lutece.plugins.workflow.modules.formscarto.business.FormsCartoTaskConfig.getQuestionListValueClosed() may expose internal representation by returning FormsCartoTaskConfig._questionListValueClosed MALICIOUS_CODE EI_EXPOSE_REP 177 Medium
fr.paris.lutece.plugins.workflow.modules.formscarto.business.FormsCartoTaskConfig.getQuestionUnitTree() may expose internal representation by returning FormsCartoTaskConfig._questionUnitTree MALICIOUS_CODE EI_EXPOSE_REP 207 Medium
fr.paris.lutece.plugins.workflow.modules.formscarto.business.FormsCartoTaskConfig.getStep() may expose internal representation by returning FormsCartoTaskConfig._step MALICIOUS_CODE EI_EXPOSE_REP 160 Medium
fr.paris.lutece.plugins.workflow.modules.formscarto.business.FormsCartoTaskConfig.setForm(Form) may expose internal representation by storing an externally mutable object into FormsCartoTaskConfig._form MALICIOUS_CODE EI_EXPOSE_REP2 221 Medium
fr.paris.lutece.plugins.workflow.modules.formscarto.business.FormsCartoTaskConfig.setListEditFormsCartoUnitTree(List) may expose internal representation by storing an externally mutable object into FormsCartoTaskConfig._listEditFormsCartoUnitTree MALICIOUS_CODE EI_EXPOSE_REP2 147 Medium
fr.paris.lutece.plugins.workflow.modules.formscarto.business.FormsCartoTaskConfig.setQuestionListLayerCarto(Question) may expose internal representation by storing an externally mutable object into FormsCartoTaskConfig._questionListLayerCarto MALICIOUS_CODE EI_EXPOSE_REP2 203 Medium
fr.paris.lutece.plugins.workflow.modules.formscarto.business.FormsCartoTaskConfig.setQuestionListValueClosed(Question) may expose internal representation by storing an externally mutable object into FormsCartoTaskConfig._questionListValueClosed MALICIOUS_CODE EI_EXPOSE_REP2 186 Medium
fr.paris.lutece.plugins.workflow.modules.formscarto.business.FormsCartoTaskConfig.setQuestionUnitTree(Question) may expose internal representation by storing an externally mutable object into FormsCartoTaskConfig._questionUnitTree MALICIOUS_CODE EI_EXPOSE_REP2 211 Medium
fr.paris.lutece.plugins.workflow.modules.formscarto.business.FormsCartoTaskConfig.setStep(Step) may expose internal representation by storing an externally mutable object into FormsCartoTaskConfig._step MALICIOUS_CODE EI_EXPOSE_REP2 169 Medium

fr.paris.lutece.plugins.workflow.modules.formscarto.service.FormsCartoTask

Bug Category Details Line Priority
Dead store to h in fr.paris.lutece.plugins.workflow.modules.formscarto.service.FormsCartoTask.processTaskWithResult(int, String, int, HttpServletRequest, Locale, User) STYLE DLS_DEAD_LOCAL_STORE 215 Medium
Dead store to questionListLayerCarto in fr.paris.lutece.plugins.workflow.modules.formscarto.service.FormsCartoTask.processTaskWithResult(int, String, int, HttpServletRequest, Locale, User) STYLE DLS_DEAD_LOCAL_STORE 144 Medium
Boxing/unboxing to parse a primitive fr.paris.lutece.plugins.workflow.modules.formscarto.service.FormsCartoTask.processTaskWithResult(int, String, int, HttpServletRequest, Locale, User) PERFORMANCE DM_BOXED_PRIMITIVE_FOR_PARSING 196 High
Useless object stored in variable idEntryList of method fr.paris.lutece.plugins.workflow.modules.formscarto.service.FormsCartoTask.getResponseValue(int) STYLE UC_USELESS_OBJECT 338 Medium

fr.paris.lutece.plugins.workflow.modules.formscarto.service.FormsCartoTaskService

Bug Category Details Line Priority
Dead store to conf in fr.paris.lutece.plugins.workflow.modules.formscarto.service.FormsCartoTaskService.update(ITaskConfig) STYLE DLS_DEAD_LOCAL_STORE 120 Medium

fr.paris.lutece.plugins.workflow.modules.formscarto.web.FormsCartoTaskComponent

Bug Category Details Line Priority
Dead store to config in fr.paris.lutece.plugins.workflow.modules.formscarto.web.FormsCartoTaskComponent.getDisplayConfigForm(HttpServletRequest, Locale, ITask) STYLE DLS_DEAD_LOCAL_STORE 192 Medium
Boxing/unboxing to parse a primitive fr.paris.lutece.plugins.workflow.modules.formscarto.web.FormsCartoTaskComponent.doProcessAction(String, HttpServletRequest) PERFORMANCE DM_BOXED_PRIMITIVE_FOR_PARSING 550 High
Boxing/unboxing to parse a primitive fr.paris.lutece.plugins.workflow.modules.formscarto.web.FormsCartoTaskComponent.doSaveConfig(HttpServletRequest, Locale, ITask) PERFORMANCE DM_BOXED_PRIMITIVE_FOR_PARSING 470 High
Boxing/unboxing to parse a primitive fr.paris.lutece.plugins.workflow.modules.formscarto.web.FormsCartoTaskComponent.getDisplayConfigForm(HttpServletRequest, Locale, ITask) PERFORMANCE DM_BOXED_PRIMITIVE_FOR_PARSING 196 High
Boxing/unboxing to parse a primitive fr.paris.lutece.plugins.workflow.modules.formscarto.web.FormsCartoTaskComponent.getLayerCartoReferenceList(int) PERFORMANCE DM_BOXED_PRIMITIVE_FOR_PARSING 639 High
Switch statement found in fr.paris.lutece.plugins.workflow.modules.formscarto.web.FormsCartoTaskComponent.doProcessAction(String, HttpServletRequest) where default case is missing STYLE SF_SWITCH_NO_DEFAULT 536-603 Medium