Violation |
Line |
The class 'AdminSqlJspBean' has a Cyclomatic Complexity of 5 (Highest = 23). |
64–1346 |
Too many fields |
64–1346 |
The class 'AdminSqlJspBean' has a Modified Cyclomatic Complexity of 3 (Highest = 18). |
64–1346 |
Avoid really long classes. |
64–1346 |
The class 'AdminSqlJspBean' has a Standard Cyclomatic Complexity of 3 (Highest = 18). |
64–1346 |
Avoid unused private fields such as 'MESSAGE_TITLE_INVALID_CHARACTERS'. |
70 |
Avoid unused private fields such as 'PROPERTY_CONFIRM_MODIFY_FIELD'. |
86 |
Avoid unused private fields such as 'PARAMETER_DATA_ID'. |
99 |
Avoid unused private fields such as 'PARAMETER_LABEL_TYPE_VALUE'. |
101 |
Avoid unused private fields such as 'PARAMETER_NULL_VALUE'. |
102 |
Avoid unused private fields such as 'PARAMETER_FIELD_LABEL_TYPE'. |
103 |
Avoid unused private fields such as 'PARAMETER_FIELD_NULL'. |
106 |
Avoid unused private fields such as 'PARAMETER_FIELD_COMMENT'. |
107 |
Avoid unused private fields such as 'PARAMETER_FIELD_KEY'. |
108 |
Avoid unused private fields such as 'PARAMETER_FIELDS_NUMBER_ADDING'. |
114 |
Avoid unused private fields such as 'PARAMETER_NUMBER_FIELDS_TABLE'. |
117 |
Avoid unused private fields such as 'PARAMETER_DATA'. |
118 |
Avoid unused private fields such as 'PARAMETER_CONCAT_FIELDNAME_DATA'. |
119 |
Avoid unused private fields such as 'PARAMETER_DB_TYPE_NAME'. |
121 |
Avoid unused private fields such as 'PARAMETER_IDENTIFIANT_USER'. |
122 |
Avoid unused private fields such as 'PARAMETER_PASSWORD_USER'. |
123 |
Avoid unused private fields such as 'PARAMETER_ROW_TO_MODIFY'. |
124 |
Avoid unused private fields such as 'MARK_DATA_LIST_TO_MODIFY'. |
135 |
Avoid unused private fields such as 'MARK_PRIMARY_KEY_LIST'. |
136 |
Avoid unused private fields such as 'MARK_FIELD_NAME_REFERENCE_LIST'. |
143 |
Avoid unused private fields such as 'MARK_NUMBER_FIELDS_TABLE'. |
146 |
Avoid unused private fields such as 'MARK_CONCAT_PRIMARY_KEY_AND_VALUE'. |
147 |
Avoid unused private fields such as 'MARK_DATABASE_TYPE_LIST'. |
151 |
Avoid unused private fields such as 'MARK_DB_TYPE_NAME'. |
152 |
Avoid unused private fields such as 'MARK_SQL_ERROR'. |
153 |
Avoid unused private fields such as 'MARK_DUMP_SCRIPT'. |
154 |
Avoid unused private fields such as 'JSP_DO_MODIFY_FIELD_STRUCTURE'. |
167 |
Avoid unused private fields such as 'PROPERTY_DATABASE_TYPE_LIST'. |
174 |
Avoid unused private fields such as 'URL_MODIFY_DATA'. |
180 |
Avoid unused private fields such as 'URL_DO_USER_REQUEST_ERROR'. |
182 |
The field name indicates a constant but its modifiers do not |
186 |
Private field 'TEMPLATE_MANAGE_POOL_SQL' could be made final; it is only initialized in the declaration or constructor. |
186 |
Private field 'TEMPLATE_MANAGE_TABLE_SQL' could be made final; it is only initialized in the declaration or constructor. |
187 |
The field name indicates a constant but its modifiers do not |
187 |
Private field 'TEMPLATE_MANAGE_DATA_SQL' could be made final; it is only initialized in the declaration or constructor. |
188 |
The field name indicates a constant but its modifiers do not |
188 |
The field name indicates a constant but its modifiers do not |
189 |
Private field 'TEMPLATE_CREATE_DATA' could be made final; it is only initialized in the declaration or constructor. |
189 |
The field name indicates a constant but its modifiers do not |
190 |
Private field 'TEMPLATE_MANAGE_STRUCTURE_SQL' could be made final; it is only initialized in the declaration or constructor. |
190 |
The field name indicates a constant but its modifiers do not |
191 |
Private field 'TEMPLATE_MODIFY_DATA' could be made final; it is only initialized in the declaration or constructor. |
191 |
The field name indicates a constant but its modifiers do not |
192 |
Private field 'TEMPLATE_MODIFY_STRUCTURE' could be made final; it is only initialized in the declaration or constructor. |
192 |
The field name indicates a constant but its modifiers do not |
193 |
Private field 'TEMPLATE_CREATE_STRUCTURE' could be made final; it is only initialized in the declaration or constructor. |
193 |
Private field 'TEMPLATE_CREATE_TABLE' could be made final; it is only initialized in the declaration or constructor. |
194 |
The field name indicates a constant but its modifiers do not |
194 |
The field name indicates a constant but its modifiers do not |
195 |
Private field 'TEMPLATE_MODIFY_TABLE_NAME' could be made final; it is only initialized in the declaration or constructor. |
195 |
Private field 'TEMPLATE_CHOOSE_FONCTIONNALITIES_LIST' could be made final; it is only initialized in the declaration or constructor. |
196 |
The field name indicates a constant but its modifiers do not |
196 |
The field name indicates a constant but its modifiers do not |
197 |
Private field 'TEMPLATE_USER_REQUEST' could be made final; it is only initialized in the declaration or constructor. |
197 |
Private field 'TEMPLATE_RESULT_OF_USER_REQUEST' could be made final; it is only initialized in the declaration or constructor. |
198 |
The field name indicates a constant but its modifiers do not |
198 |
Avoid unused private fields such as 'TEMPLATE_EXPORT_DATABASE'. |
199 |
Private field 'TEMPLATE_EXPORT_DATABASE' could be made final; it is only initialized in the declaration or constructor. |
199 |
The field name indicates a constant but its modifiers do not |
199 |
Avoid unused private fields such as 'TEMPLATE_SQL_ERROR_PAGE'. |
200 |
Private field 'TEMPLATE_SQL_ERROR_PAGE' could be made final; it is only initialized in the declaration or constructor. |
200 |
The field name indicates a constant but its modifiers do not |
200 |
The field name indicates a constant but its modifiers do not |
201 |
Private field 'TEMPLATE_PARAMETER_TO_EXPORT_DATABASE' could be made final; it is only initialized in the declaration or constructor. |
201 |
The field name indicates a constant but its modifiers do not |
202 |
Private field 'TEMPLATE_DUMP_DATABASE' could be made final; it is only initialized in the declaration or constructor. |
202 |
The field name indicates a constant but its modifiers do not |
203 |
Private field 'TEMPLATE_USER_REQUEST_ERROR' could be made final; it is only initialized in the declaration or constructor. |
203 |
If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation |
257 |
If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation |
277 |
When doing a String.toLowerCase()/toUpperCase() call, use a Locale |
299 |
If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation |
317 |
If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation |
339 |
Avoid using equals() to compare against null |
351 |
The method 'doExportDatabase' has a Modified Cyclomatic Complexity of 18. |
407–571 |
Avoid really long methods. |
407–571 |
The method doExportDatabase() has an NPath complexity of 2907 |
407–571 |
The method 'doExportDatabase' has a Cyclomatic Complexity of 23. |
407–571 |
The method 'doExportDatabase' has a Standard Cyclomatic Complexity of 18. |
407–571 |
Avoid unused local variables such as 'DumpCommandslist'. |
416 |
Avoid declaring a variable if it is unreferenced before a possible exit point. |
416 |
Avoid unused local variables such as 'listRows'. |
417 |
Avoid declaring a variable if it is unreferenced before a possible exit point. |
417 |
StringBuffer constructor is initialized with size 16, but has at least 134 characters appended. |
418 |
StringBuffer (or StringBuilder).append is called 3 consecutive times with literal Strings. Use a single append with a single combined String. |
423 |
The String literal "\n--\n\n" appears 4 times in this file; the first occurrence is on line 423 |
423 |
StringBuffer (or StringBuilder).append is called 2 consecutive times with literal Strings. Use a single append with a single combined String. |
423 |
StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. |
423 |
StringBuffer (or StringBuilder).append is called 4 consecutive times with literal Strings. Use a single append with a single combined String. |
442 |
StringBuffer (or StringBuilder).append is called 2 consecutive times with literal Strings. Use a single append with a single combined String. |
442 |
StringBuffer (or StringBuilder).append is called 3 consecutive times with literal Strings. Use a single append with a single combined String. |
443 |
Prefer StringBuffer over += for concatenating strings |
450 |
Position literals first in String comparisons |
455 |
Position literals first in String comparisons |
466 |
Position literals first in String comparisons |
489 |
Prefer StringBuffer over += for concatenating strings |
491 |
Prefer StringBuffer over += for concatenating strings |
495 |
Use equals() to compare strings instead of '==' or '!=' |
498 |
Avoid using Literals in Conditional Statements |
498 |
Prefer StringBuffer over += for concatenating strings |
501 |
Avoid concatenating nonliterals in a StringBuffer/StringBuilder constructor or append(). |
510 |
Prefer StringBuffer over += for concatenating strings |
523 |
StringBuffer (or StringBuilder).append is called 2 consecutive times with literal Strings. Use a single append with a single combined String. |
533 |
StringBuffer (or StringBuilder).append is called 2 consecutive times with literal Strings. Use a single append with a single combined String. |
533 |
StringBuffer (or StringBuilder).append is called 2 consecutive times with literal Strings. Use a single append with a single combined String. |
537 |
StringBuffer (or StringBuilder).append is called 2 consecutive times with literal Strings. Use a single append with a single combined String. |
537 |
Prefer StringBuffer over += for concatenating strings |
548 |
StringBuffer (or StringBuilder).append is called 2 consecutive times with literal Strings. Use a single append with a single combined String. |
552–553 |
Avoid appending characters as strings in StringBuffer.append. |
557 |
Avoid declaring a variable if it is unreferenced before a possible exit point. |
602 |
Avoid declaring a variable if it is unreferenced before a possible exit point. |
604 |
Avoid declaring a variable if it is unreferenced before a possible exit point. |
606 |
Avoid declaring a variable if it is unreferenced before a possible exit point. |
607 |
Avoid declaring a variable if it is unreferenced before a possible exit point. |
608 |
Position literals first in String comparisons |
610 |
Avoid using equals() to compare against null |
610 |
Avoid using equals() to compare against null |
615 |
Position literals first in String comparisons |
615 |
Avoid declaring a variable if it is unreferenced before a possible exit point. |
697 |
Avoid declaring a variable if it is unreferenced before a possible exit point. |
698 |
Avoid using equals() to compare against null |
701 |
Position literals first in String comparisons |
701 |
The method doCreateFieldStructure() has an NPath complexity of 864 |
815–890 |
The method 'doCreateFieldStructure' has a Cyclomatic Complexity of 22. |
815–890 |
Avoid declaring a variable if it is unreferenced before a possible exit point. |
817 |
Avoid declaring a variable if it is unreferenced before a possible exit point. |
818 |
Avoid declaring a variable if it is unreferenced before a possible exit point. |
820 |
Avoid declaring a variable if it is unreferenced before a possible exit point. |
821 |
Avoid declaring a variable if it is unreferenced before a possible exit point. |
822 |
Avoid declaring a variable if it is unreferenced before a possible exit point. |
823 |
Position literals first in String comparisons |
825 |
Avoid using equals() to compare against null |
825 |
Avoid declaring a variable if it is unreferenced before a possible exit point. |
832 |
Avoid declaring a variable if it is unreferenced before a possible exit point. |
833 |
Avoid declaring a variable if it is unreferenced before a possible exit point. |
847 |
The method 'doModifyFieldStructure' has a Cyclomatic Complexity of 23. |
925–1003 |
The method doModifyFieldStructure() has an NPath complexity of 1728 |
925–1003 |
Avoid declaring a variable if it is unreferenced before a possible exit point. |
927 |
Avoid declaring a variable if it is unreferenced before a possible exit point. |
928 |
Avoid declaring a variable if it is unreferenced before a possible exit point. |
930 |
Avoid declaring a variable if it is unreferenced before a possible exit point. |
931 |
Avoid declaring a variable if it is unreferenced before a possible exit point. |
932 |
Avoid declaring a variable if it is unreferenced before a possible exit point. |
935 |
Position literals first in String comparisons |
937 |
Avoid using equals() to compare against null |
937 |
Avoid declaring a variable if it is unreferenced before a possible exit point. |
944 |
Avoid declaring a variable if it is unreferenced before a possible exit point. |
945 |
Avoid declaring a variable if it is unreferenced before a possible exit point. |
1065 |
Avoid unused local variables such as 'nNumberFields'. |
1065 |
Avoid declaring a variable if it is unreferenced before a possible exit point. |
1067 |
Avoid unused local variables such as 'nNumberData'. |
1067 |
Avoid declaring a variable if it is unreferenced before a possible exit point. |
1068 |
Avoid unused local variables such as 'nNumberOfRow'. |
1068 |
Avoid variables with short names like n |
1069 |
Prefer StringBuffer over += for concatenating strings |
1081 |
Avoid using Literals in Conditional Statements |
1163 |
Prefer StringBuffer over += for concatenating strings |
1165 |
Avoid unused local variables such as 'listConcatFieldNameAndData'. |
1238 |
Avoid declaring a variable if it is unreferenced before a possible exit point. |
1238 |
Avoid declaring a variable if it is unreferenced before a possible exit point. |
1239 |
Avoid unused local variables such as 'listConcatFieldNameAndOldData'. |
1239 |
Prefer StringBuffer over += for concatenating strings |
1299 |
Avoid unused local variables such as 'listFieldsNames'. |
1323 |
Avoid declaring a variable if it is unreferenced before a possible exit point. |
1323 |
Avoid declaring a variable if it is unreferenced before a possible exit point. |
1327 |
Avoid unused local variables such as 'strConcatFieldNameAndData'. |
1327 |