The following document contains the results of PMD 6.13.0.
| Rule | Violation | Line |
|---|---|---|
| FieldNamingConventions | The field name 'strFieldName' doesn't match '_[a-z][a-zA-Z0-9]*' | 43 |
| FieldNamingConventions | The field name 'strOldValue' doesn't match '_[a-z][a-zA-Z0-9]*' | 44 |
| FieldNamingConventions | The field name 'strNewValue' doesn't match '_[a-z][a-zA-Z0-9]*' | 45 |
| Rule | Violation | Line |
|---|---|---|
| FieldNamingConventions | The field name 'TEMPLATE_MANAGE_POOL_SQL' doesn't match '_[a-z][a-zA-Z0-9]*' | 186 |
| FieldNamingConventions | The field name 'TEMPLATE_MANAGE_TABLE_SQL' doesn't match '_[a-z][a-zA-Z0-9]*' | 187 |
| FieldNamingConventions | The field name 'TEMPLATE_MANAGE_DATA_SQL' doesn't match '_[a-z][a-zA-Z0-9]*' | 188 |
| FieldNamingConventions | The field name 'TEMPLATE_CREATE_DATA' doesn't match '_[a-z][a-zA-Z0-9]*' | 189 |
| FieldNamingConventions | The field name 'TEMPLATE_MANAGE_STRUCTURE_SQL' doesn't match '_[a-z][a-zA-Z0-9]*' | 190 |
| FieldNamingConventions | The field name 'TEMPLATE_MODIFY_DATA' doesn't match '_[a-z][a-zA-Z0-9]*' | 191 |
| FieldNamingConventions | The field name 'TEMPLATE_MODIFY_STRUCTURE' doesn't match '_[a-z][a-zA-Z0-9]*' | 192 |
| FieldNamingConventions | The field name 'TEMPLATE_CREATE_STRUCTURE' doesn't match '_[a-z][a-zA-Z0-9]*' | 193 |
| FieldNamingConventions | The field name 'TEMPLATE_CREATE_TABLE' doesn't match '_[a-z][a-zA-Z0-9]*' | 194 |
| FieldNamingConventions | The field name 'TEMPLATE_MODIFY_TABLE_NAME' doesn't match '_[a-z][a-zA-Z0-9]*' | 195 |
| FieldNamingConventions | The field name 'TEMPLATE_CHOOSE_FONCTIONNALITIES_LIST' doesn't match '_[a-z][a-zA-Z0-9]*' | 196 |
| FieldNamingConventions | The field name 'TEMPLATE_USER_REQUEST' doesn't match '_[a-z][a-zA-Z0-9]*' | 197 |
| FieldNamingConventions | The field name 'TEMPLATE_RESULT_OF_USER_REQUEST' doesn't match '_[a-z][a-zA-Z0-9]*' | 198 |
| FieldNamingConventions | The field name 'TEMPLATE_EXPORT_DATABASE' doesn't match '_[a-z][a-zA-Z0-9]*' | 199 |
| FieldNamingConventions | The field name 'TEMPLATE_SQL_ERROR_PAGE' doesn't match '_[a-z][a-zA-Z0-9]*' | 200 |
| FieldNamingConventions | The field name 'TEMPLATE_PARAMETER_TO_EXPORT_DATABASE' doesn't match '_[a-z][a-zA-Z0-9]*' | 201 |
| FieldNamingConventions | The field name 'TEMPLATE_DUMP_DATABASE' doesn't match '_[a-z][a-zA-Z0-9]*' | 202 |
| FieldNamingConventions | The field name 'TEMPLATE_USER_REQUEST_ERROR' doesn't match '_[a-z][a-zA-Z0-9]*' | 203 |
| EqualsNull | Avoid using equals() to compare against null | 351 |
| LocalVariableNamingConventions | The local variable name 'DumpCommandslist' doesn't match '[a-z][a-zA-Z0-9]*' | 416 |
| EqualsNull | Avoid using equals() to compare against null | 610 |
| EqualsNull | Avoid using equals() to compare against null | 615 |
| EqualsNull | Avoid using equals() to compare against null | 701 |
| EqualsNull | Avoid using equals() to compare against null | 825 |
| EqualsNull | Avoid using equals() to compare against null | 937 |
| Rule | Violation | Line |
|---|---|---|
| AvoidReassigningParameters | Avoid reassigning parameters such as 'connectionService' | 105 |
| Rule | Violation | Line |
|---|---|---|
| AvoidReassigningParameters | Avoid reassigning parameters such as 'plugin' | 407 |
| AvoidReassigningParameters | Avoid reassigning parameters such as 'plugin' | 434 |
| AvoidReassigningParameters | Avoid reassigning parameters such as 'plugin' | 488 |
| AvoidReassigningParameters | Avoid reassigning parameters such as 'plugin' | 514 |
| AvoidReassigningParameters | Avoid reassigning parameters such as 'plugin' | 540 |
| AvoidReassigningParameters | Avoid reassigning parameters such as 'plugin' | 566 |
| AvoidReassigningParameters | Avoid reassigning parameters such as 'plugin' | 592 |
| AvoidReassigningParameters | Avoid reassigning parameters such as 'plugin' | 618 |
| Rule | Violation | Line |
|---|---|---|
| SystemPrintln | System.out.println is used | 172 |
| AvoidReassigningParameters | Avoid reassigning parameters such as 'plugin' | 342 |
| AvoidReassigningParameters | Avoid reassigning parameters such as 'plugin' | 368 |
| AvoidReassigningParameters | Avoid reassigning parameters such as 'plugin' | 394 |
| AvoidReassigningParameters | Avoid reassigning parameters such as 'plugin' | 420 |
| AvoidReassigningParameters | Avoid reassigning parameters such as 'plugin' | 446 |
| AvoidReassigningParameters | Avoid reassigning parameters such as 'plugin' | 472 |
| Rule | Violation | Line |
|---|---|---|
| TooManyMethods | This class has too many methods, consider refactoring it. | 58–400 |
| UnusedPrivateField | Avoid unused private fields such as 'SELECT'. | 62 |
| UnusedPrivateField | Avoid unused private fields such as 'FROM'. | 63 |
| MissingOverride | The method 'selectDataList(String, PluginConnectionService)' is missing an @Override annotation. | 81–95 |
| UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 83 |
| MissingOverride | The method 'selectDataListUserRequest(String, String, PluginConnectionService)' is missing an @Override annotation. | 104–121 |
| UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 107 |
| MissingOverride | The method 'insert(String, String, List, List, PluginConnectionService)' is missing an @Override annotation. | 131–158 |
| UseStringBufferForStringAppends | Prefer StringBuilder (non-synchronized) or StringBuffer (synchronized) over += for concatenating strings | 139 |
| UseStringBufferForStringAppends | Prefer StringBuilder (non-synchronized) or StringBuffer (synchronized) over += for concatenating strings | 148 |
| MissingOverride | The method 'store(String, String, List, PluginConnectionService)' is missing an @Override annotation. | 167–188 |
| UseStringBufferForStringAppends | Prefer StringBuilder (non-synchronized) or StringBuffer (synchronized) over += for concatenating strings | 175 |
| UseStringBufferForStringAppends | Prefer StringBuilder (non-synchronized) or StringBuffer (synchronized) over += for concatenating strings | 177 |
| MissingOverride | The method 'delete(String, String, List, PluginConnectionService)' is missing an @Override annotation. | 197–213 |
| UseStringBufferForStringAppends | Prefer StringBuilder (non-synchronized) or StringBuffer (synchronized) over += for concatenating strings | 204 |
| MissingOverride | The method 'insertWithUserRequest(String, PluginConnectionService, String)' is missing an @Override annotation. | 221–227 |
| MissingOverride | The method 'load(String, String, List, PluginConnectionService)' is missing an @Override annotation. | 237–244 |
| UnnecessaryLocalBeforeReturn | Consider simply returning the value vs storing it in local variable 'listDataValueSelectedByPK' | 243 |
| CloseResource | Ensure that resources like this Connection object are closed after use | 255 |
| CloseResource | Ensure that resources like this ResultSet object are closed after use | 263 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 275–282 |
| NullAssignment | Assigning an Object to null is a code smell. Consider refactoring. | 291 |
| PreserveStackTrace | New exception is thrown in catch block, original stack trace may be lost | 306 |
| MissingOverride | The method 'findResultOfUserRequest(String, PluginConnectionService)' is missing an @Override annotation. | 319–334 |
| UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 321 |
| UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 322 |
| UnusedLocalVariable | Avoid unused local variables such as 'listFields'. | 322 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 322 |
| MissingOverride | The method 'selectColumnNames(String, PluginConnectionService, String)' is missing an @Override annotation. | 343–359 |
| PreserveStackTrace | New exception is thrown in catch block, original stack trace may be lost | 372 |
| PreserveStackTrace | New exception is thrown in catch block, original stack trace may be lost | 387 |
| Rule | Violation | Line |
|---|---|---|
| UseUtilityClass | All methods are static. Consider using a utility class instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning. | 55–174 |
| Rule | Violation | Line |
|---|---|---|
| TooManyFields | Too many fields | 40–350 |
| UnusedPrivateField | Avoid unused private fields such as '_strCommentValue'. | 52 |
| Rule | Violation | Line |
|---|---|---|
| GodClass | Possible God Class (WMC=59, ATFD=74, TCC=5.000%) | 52–656 |
| TooManyMethods | This class has too many methods, consider refactoring it. | 53–656 |
| UnusedPrivateField | Avoid unused private fields such as 'FOREIGN_KEY'. | 61 |
| UnusedPrivateField | Avoid unused private fields such as 'INDEX_KEY'. | 62 |
| UnusedPrivateField | Avoid unused private fields such as 'UNIQUE_KEY'. | 63 |
| UnusedPrivateField | Avoid unused private fields such as 'POOL_ADMINSQL'. | 66 |
| CyclomaticComplexity | The method 'load(String, String, String, Plugin)' has a cyclomatic complexity of 16. | 91–153 |
| MissingOverride | The method 'load(String, String, String, Plugin)' is missing an @Override annotation. | 91–153 |
| PositionLiteralsFirstInComparisons | Position literals first in String comparisons | 106 |
| PositionLiteralsFirstInComparisons | Position literals first in String comparisons | 106 |
| PositionLiteralsFirstInComparisons | Position literals first in String comparisons | 106 |
| PositionLiteralsFirstInComparisons | Position literals first in String comparisons | 107 |
| PositionLiteralsFirstInComparisons | Position literals first in String comparisons | 107 |
| PositionLiteralsFirstInComparisons | Position literals first in String comparisons | 108 |
| PositionLiteralsFirstInComparisons | Position literals first in String comparisons | 108 |
| PositionLiteralsFirstInComparisons | Position literals first in String comparisons | 109 |
| PositionLiteralsFirstInComparisons | Position literals first in String comparisons | 109 |
| PositionLiteralsFirstInComparisons | Position literals first in String comparisons | 110 |
| PositionLiteralsFirstInComparisons | Position literals first in String comparisons | 110 |
| PositionLiteralsFirstInComparisons | Position literals first in String comparisons | 111 |
| PositionLiteralsFirstInComparisons | Position literals first in String comparisons | 132 |
| CyclomaticComplexity | The method 'store(String, String, Field, String, int, Plugin)' has a cyclomatic complexity of 10. | 164–236 |
| MissingOverride | The method 'store(String, String, Field, String, int, Plugin)' is missing an @Override annotation. | 164–236 |
| PositionLiteralsFirstInComparisons | Position literals first in String comparisons | 178 |
| PositionLiteralsFirstInComparisons | Position literals first in String comparisons | 192 |
| PositionLiteralsFirstInComparisons | Position literals first in String comparisons | 219 |
| MissingOverride | The method 'insert(String, String, Field, Plugin)' is missing an @Override annotation. | 245–342 |
| PositionLiteralsFirstInComparisons | Position literals first in String comparisons | 258 |
| PositionLiteralsFirstInComparisons | Position literals first in String comparisons | 272 |
| UnusedLocalVariable | Avoid unused local variables such as 'strFieldLabelKeyValue'. | 284 |
| AvoidLiteralsInIfCondition | Avoid using Literals in Conditional Statements | 287 |
| PositionLiteralsFirstInComparisons | Position literals first in String comparisons | 299 |
| UseStringBufferForStringAppends | Prefer StringBuilder (non-synchronized) or StringBuffer (synchronized) over += for concatenating strings | 306 |
| UnusedLocalVariable | Avoid unused local variables such as 'nAddFieldEndOfTable'. | 309 |
| UnusedLocalVariable | Avoid unused local variables such as 'nAddFieldBeginningOfTable'. | 310 |
| UnusedLocalVariable | Avoid unused local variables such as 'nAddFieldAfterAField'. | 311 |
| AvoidLiteralsInIfCondition | Avoid using Literals in Conditional Statements | 315 |
| AvoidLiteralsInIfCondition | Avoid using Literals in Conditional Statements | 327 |
| MissingOverride | The method 'delete(String, String, Plugin)' is missing an @Override annotation. | 350–355 |
| MissingOverride | The method 'selectFieldList(String, String, Plugin)' is missing an @Override annotation. | 364–399 |
| UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 366 |
| MissingOverride | The method 'selectFieldTypeList(String, Plugin)' is missing an @Override annotation. | 407–426 |
| MissingOverride | The method 'selectFieldKeyList(String, Plugin)' is missing an @Override annotation. | 434–453 |
| MissingOverride | The method 'selectFieldNullList(String, Plugin)' is missing an @Override annotation. | 461–479 |
| Rule | Violation | Line |
|---|---|---|
| UseUtilityClass | All methods are static. Consider using a utility class instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning. | 46–150 |
| Rule | Violation | Line |
|---|---|---|
| UnnecessaryConstructor | Avoid unnecessary constructors - the compiler will generate these for you | 48–50 |
| UncommentedEmptyConstructor | Document empty constructor | 48–50 |
| Rule | Violation | Line |
|---|---|---|
| ImportFromSamePackage | No need to import a type that lives in the same package | 44 |
| UnnecessaryModifier | Unnecessary modifier 'public' on method 'load': the method is declared in an interface type | 105–106 |
| UnnecessaryModifier | Unnecessary modifier 'public' on method 'selectColumnNames': the method is declared in an interface type | 123–124 |
| Rule | Violation | Line |
|---|---|---|
| ImportFromSamePackage | No need to import a type that lives in the same package | 36 |
| Rule | Violation | Line |
|---|---|---|
| CommentRequired | Public method and constructor comments are required | 55 |
| CommentRequired | Public method and constructor comments are required | 57 |
| CommentRequired | Public method and constructor comments are required | 59 |
| CommentRequired | Public method and constructor comments are required | 61 |
| Rule | Violation | Line |
|---|---|---|
| UnusedPrivateField | Avoid unused private fields such as 'SQL_QUERY_NEW_PK'. | 59 |
| UnusedPrivateField | Avoid unused private fields such as 'SQL_QUERY_SELECT'. | 60 |
| UnusedPrivateField | Avoid unused private fields such as 'SQL_QUERY_INSERT'. | 61 |
| UnusedPrivateField | Avoid unused private fields such as 'SQL_QUERY_DELETE'. | 62 |
| UnusedPrivateField | Avoid unused private fields such as 'SQL_QUERY_UPDATE'. | 63 |
| CommentRequired | Public method and constructor comments are required | 72–86 |
| MissingOverride | The method 'selectAllTables(PluginConnectionService)' is missing an @Override annotation. | 72–86 |
| UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 74 |
| MissingOverride | The method 'selectAllColumns(PluginConnectionService, String)' is missing an @Override annotation. | 88–102 |
| CommentRequired | Public method and constructor comments are required | 88–102 |
| UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 90 |
| CommentRequired | Public method and constructor comments are required | 104–164 |
| CloseResource | Ensure that resources like this Connection object are closed after use | 107 |
| CloseResource | Ensure that resources like this ResultSet object are closed after use | 116 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 128–135 |
| NullAssignment | Assigning an Object to null is a code smell. Consider refactoring. | 144 |
| PreserveStackTrace | New exception is thrown in catch block, original stack trace may be lost | 159 |
| CommentRequired | Public method and constructor comments are required | 166–180 |
| MissingOverride | The method 'selectAllData(PluginConnectionService, String)' is missing an @Override annotation. | 166–180 |
| UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 168 |
| CommentRequired | Public method and constructor comments are required | 182–196 |
| MissingOverride | The method 'selectAllFields(PluginConnectionService, String)' is missing an @Override annotation. | 182–196 |
| UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 184 |
| MissingOverride | The method 'selectAField(PluginConnectionService, String, String)' is missing an @Override annotation. | 198–214 |
| CommentRequired | Public method and constructor comments are required | 198–214 |
| UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 201 |
| Rule | Violation | Line |
|---|---|---|
| CommentRequired | Public method and constructor comments are required | 60–63 |
| CommentRequired | Public method and constructor comments are required | 65–68 |
| CommentRequired | Public method and constructor comments are required | 70–73 |
| CommentRequired | Public method and constructor comments are required | 75–78 |
| CommentRequired | Public method and constructor comments are required | 80–84 |
| Rule | Violation | Line |
|---|---|---|
| CommentRequired | Public method and constructor comments are required | 69–72 |
| UncommentedEmptyMethodBody | Document empty method body | 70–72 |
| CommentRequired | Public method and constructor comments are required | 74–77 |
| UncommentedEmptyMethodBody | Document empty method body | 75–77 |
| Rule | Violation | Line |
|---|---|---|
| TooManyMethods | This class has too many methods, consider refactoring it. | 53–511 |
| UnusedPrivateField | Avoid unused private fields such as 'CHANGE'. | 57 |
| UnusedPrivateField | Avoid unused private fields such as 'ADD'. | 58 |
| UnusedPrivateField | Avoid unused private fields such as 'FOREIGN_KEY'. | 60 |
| UnusedPrivateField | Avoid unused private fields such as 'INDEX_KEY'. | 61 |
| UnusedPrivateField | Avoid unused private fields such as 'UNIQUE_KEY'. | 62 |
| UnusedPrivateField | Avoid unused private fields such as 'DROP'. | 63 |
| UnusedPrivateField | Avoid unused private fields such as 'WHERE'. | 65 |
| UnusedPrivateField | Avoid unused private fields such as 'SPACE'. | 66 |
| UnusedPrivateField | Avoid unused private fields such as 'USER'. | 67 |
| UnusedPrivateField | Avoid unused private fields such as 'PASSWORD'. | 68 |
| UnusedPrivateField | Avoid unused private fields such as 'SQL_QUERY_SELECT'. | 80 |
| UnusedPrivateField | Avoid unused private fields such as 'SQL_QUERY_SHOW_DATABASE_TABLES_BY_POOL'. | 82 |
| UnusedPrivateField | Avoid unused private fields such as 'SQL_QUERY_SELECT_A_TABLE_ON_DATABASE'. | 83 |
| MissingOverride | The method 'load(String, String, Plugin)' is missing an @Override annotation. | 96–113 |
| MissingOverride | The method 'insert(String, Table, Field, Plugin)' is missing an @Override annotation. | 122–182 |
| PositionLiteralsFirstInComparisons | Position literals first in String comparisons | 135 |
| UnusedLocalVariable | Avoid unused local variables such as 'strFieldLabelKeyValue'. | 147 |
| AvoidLiteralsInIfCondition | Avoid using Literals in Conditional Statements | 150 |
| PositionLiteralsFirstInComparisons | Position literals first in String comparisons | 162 |
| UseStringBufferForStringAppends | Prefer StringBuilder (non-synchronized) or StringBuffer (synchronized) over += for concatenating strings | 169 |
| MissingOverride | The method 'store(String, Table)' is missing an @Override annotation. | 189–195 |
| MissingOverride | The method 'delete(String, Plugin)' is missing an @Override annotation. | 202–207 |
| MissingOverride | The method 'selectTableList(Plugin)' is missing an @Override annotation. | 214–230 |
| UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 216 |
| MissingOverride | The method 'selectTableListByPool(String, Plugin)' is missing an @Override annotation. | 238–256 |
| UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 242 |
| Rule | Violation | Line |
|---|---|---|
| UseUtilityClass | All methods are static. Consider using a utility class instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning. | 47–115 |
| Rule | Violation | Line |
|---|---|---|
| ReplaceHashtableWithMap | Consider replacing this Hashtable with the newer java.util.Map | 49 |
| LooseCoupling | Avoid using implementation types like 'Hashtable'; use the interface instead | 49 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 69–84 |
| Rule | Violation | Line |
|---|---|---|
| UseUtilityClass | All methods are static. Consider using a utility class instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning. | 49–59 |
| CommentRequired | Public method and constructor comments are required | 50–58 |
| UseIndexOfChar | String.indexOf(char) is faster than String.indexOf(String). | 53 |
| UseIndexOfChar | String.indexOf(char) is faster than String.indexOf(String). | 54 |
| UseIndexOfChar | String.indexOf(char) is faster than String.indexOf(String). | 55 |
| Rule | Violation | Line |
|---|---|---|
| CyclomaticComplexity | The class 'AdminSqlJspBean' has a total cyclomatic complexity of 126 (highest 23). | 64–1346 |
| TooManyFields | Too many fields | 64–1346 |
| ExcessiveClassLength | Avoid really long classes. | 64–1346 |
| MissingSerialVersionUID | Classes implementing Serializable should set a serialVersionUID | 64–1346 |
| TooManyMethods | This class has too many methods, consider refactoring it. | 65–1346 |
| UnusedPrivateField | Avoid unused private fields such as 'MESSAGE_TITLE_INVALID_CHARACTERS'. | 70 |
| UnusedPrivateField | Avoid unused private fields such as 'PROPERTY_CONFIRM_MODIFY_FIELD'. | 86 |
| UnusedPrivateField | Avoid unused private fields such as 'PARAMETER_DATA_ID'. | 99 |
| UnusedPrivateField | Avoid unused private fields such as 'PARAMETER_LABEL_TYPE_VALUE'. | 101 |
| UnusedPrivateField | Avoid unused private fields such as 'PARAMETER_NULL_VALUE'. | 102 |
| UnusedPrivateField | Avoid unused private fields such as 'PARAMETER_FIELD_LABEL_TYPE'. | 103 |
| UnusedPrivateField | Avoid unused private fields such as 'PARAMETER_FIELD_NULL'. | 106 |
| UnusedPrivateField | Avoid unused private fields such as 'PARAMETER_FIELD_COMMENT'. | 107 |
| UnusedPrivateField | Avoid unused private fields such as 'PARAMETER_FIELD_KEY'. | 108 |
| UnusedPrivateField | Avoid unused private fields such as 'PARAMETER_FIELDS_NUMBER_ADDING'. | 114 |
| UnusedPrivateField | Avoid unused private fields such as 'PARAMETER_NUMBER_FIELDS_TABLE'. | 117 |
| UnusedPrivateField | Avoid unused private fields such as 'PARAMETER_DATA'. | 118 |
| UnusedPrivateField | Avoid unused private fields such as 'PARAMETER_CONCAT_FIELDNAME_DATA'. | 119 |
| UnusedPrivateField | Avoid unused private fields such as 'PARAMETER_DB_TYPE_NAME'. | 121 |
| UnusedPrivateField | Avoid unused private fields such as 'PARAMETER_IDENTIFIANT_USER'. | 122 |
| UnusedPrivateField | Avoid unused private fields such as 'PARAMETER_PASSWORD_USER'. | 123 |
| UnusedPrivateField | Avoid unused private fields such as 'PARAMETER_ROW_TO_MODIFY'. | 124 |
| UnusedPrivateField | Avoid unused private fields such as 'MARK_DATA_LIST_TO_MODIFY'. | 135 |
| UnusedPrivateField | Avoid unused private fields such as 'MARK_PRIMARY_KEY_LIST'. | 136 |
| UnusedPrivateField | Avoid unused private fields such as 'MARK_FIELD_NAME_REFERENCE_LIST'. | 143 |
| UnusedPrivateField | Avoid unused private fields such as 'MARK_NUMBER_FIELDS_TABLE'. | 146 |
| UnusedPrivateField | Avoid unused private fields such as 'MARK_CONCAT_PRIMARY_KEY_AND_VALUE'. | 147 |
| UnusedPrivateField | Avoid unused private fields such as 'MARK_DATABASE_TYPE_LIST'. | 151 |
| UnusedPrivateField | Avoid unused private fields such as 'MARK_DB_TYPE_NAME'. | 152 |
| UnusedPrivateField | Avoid unused private fields such as 'MARK_SQL_ERROR'. | 153 |
| UnusedPrivateField | Avoid unused private fields such as 'MARK_DUMP_SCRIPT'. | 154 |
| UnusedPrivateField | Avoid unused private fields such as 'JSP_DO_MODIFY_FIELD_STRUCTURE'. | 167 |
| UnusedPrivateField | Avoid unused private fields such as 'PROPERTY_DATABASE_TYPE_LIST'. | 174 |
| UnusedPrivateField | Avoid unused private fields such as 'URL_MODIFY_DATA'. | 180 |
| UnusedPrivateField | Avoid unused private fields such as 'URL_DO_USER_REQUEST_ERROR'. | 182 |
| ImmutableField | Private field 'TEMPLATE_MANAGE_POOL_SQL' could be made final; it is only initialized in the declaration or constructor. | 186 |
| ImmutableField | Private field 'TEMPLATE_MANAGE_TABLE_SQL' could be made final; it is only initialized in the declaration or constructor. | 187 |
| ImmutableField | Private field 'TEMPLATE_MANAGE_DATA_SQL' could be made final; it is only initialized in the declaration or constructor. | 188 |
| ImmutableField | Private field 'TEMPLATE_CREATE_DATA' could be made final; it is only initialized in the declaration or constructor. | 189 |
| ImmutableField | Private field 'TEMPLATE_MANAGE_STRUCTURE_SQL' could be made final; it is only initialized in the declaration or constructor. | 190 |
| ImmutableField | Private field 'TEMPLATE_MODIFY_DATA' could be made final; it is only initialized in the declaration or constructor. | 191 |
| ImmutableField | Private field 'TEMPLATE_MODIFY_STRUCTURE' could be made final; it is only initialized in the declaration or constructor. | 192 |
| ImmutableField | Private field 'TEMPLATE_CREATE_STRUCTURE' could be made final; it is only initialized in the declaration or constructor. | 193 |
| ImmutableField | Private field 'TEMPLATE_CREATE_TABLE' could be made final; it is only initialized in the declaration or constructor. | 194 |
| ImmutableField | Private field 'TEMPLATE_MODIFY_TABLE_NAME' could be made final; it is only initialized in the declaration or constructor. | 195 |
| ImmutableField | Private field 'TEMPLATE_CHOOSE_FONCTIONNALITIES_LIST' could be made final; it is only initialized in the declaration or constructor. | 196 |
| ImmutableField | Private field 'TEMPLATE_USER_REQUEST' could be made final; it is only initialized in the declaration or constructor. | 197 |
| ImmutableField | Private field 'TEMPLATE_RESULT_OF_USER_REQUEST' could be made final; it is only initialized in the declaration or constructor. | 198 |
| UnusedPrivateField | Avoid unused private fields such as 'TEMPLATE_EXPORT_DATABASE'. | 199 |
| ImmutableField | Private field 'TEMPLATE_EXPORT_DATABASE' could be made final; it is only initialized in the declaration or constructor. | 199 |
| UnusedPrivateField | Avoid unused private fields such as 'TEMPLATE_SQL_ERROR_PAGE'. | 200 |
| ImmutableField | Private field 'TEMPLATE_SQL_ERROR_PAGE' could be made final; it is only initialized in the declaration or constructor. | 200 |
| ImmutableField | Private field 'TEMPLATE_PARAMETER_TO_EXPORT_DATABASE' could be made final; it is only initialized in the declaration or constructor. | 201 |
| ImmutableField | Private field 'TEMPLATE_DUMP_DATABASE' could be made final; it is only initialized in the declaration or constructor. | 202 |
| ImmutableField | Private field 'TEMPLATE_USER_REQUEST_ERROR' could be made final; it is only initialized in the declaration or constructor. | 203 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 257 |
| UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 257 |
| UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 277 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 277 |
| UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 294 |
| UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 295 |
| UseLocaleWithCaseConversions | When doing a String.toLowerCase()/toUpperCase() call, use a Locale | 299 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 316 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 317 |
| UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 317 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 338 |
| UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 339 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 339 |
| UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 360 |
| CommentRequired | Public method and constructor comments are required | 373–383 |
| UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 393 |
| CyclomaticComplexity | The method 'doExportDatabase(HttpServletRequest)' has a cyclomatic complexity of 23. | 407–571 |
| ExcessiveMethodLength | Avoid really long methods. | 407–571 |
| NPathComplexity | The method 'doExportDatabase(HttpServletRequest)' has an NPath complexity of 2907 | 407–571 |
| NcssCount | The method 'doExportDatabase(HttpServletRequest)' has a NCSS line count of 95. | 407–571 |
| UnusedLocalVariable | Avoid unused local variables such as 'DumpCommandslist'. | 416 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 416 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 417 |
| UnusedLocalVariable | Avoid unused local variables such as 'listRows'. | 417 |
| InsufficientStringBufferDeclaration | StringBuffer constructor is initialized with size 16, but has at least 134 characters appended. | 418 |
| UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 419 |
| UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 420 |
| UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 421 |
| ConsecutiveLiteralAppends | StringBuffer (or StringBuilder).append is called 2 consecutive times with literals. Use a single append with a single combined String. | 423 |
| AvoidDuplicateLiterals | The String literal "\n--\n\n" appears 4 times in this file; the first occurrence is on line 423 | 423 |
| ConsecutiveLiteralAppends | StringBuffer (or StringBuilder).append is called 3 consecutive times with literals. Use a single append with a single combined String. | 423 |
| ConsecutiveAppendsShouldReuse | StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 423 |
| ConsecutiveLiteralAppends | StringBuffer (or StringBuilder).append is called 2 consecutive times with literals. Use a single append with a single combined String. | 442 |
| ConsecutiveLiteralAppends | StringBuffer (or StringBuilder).append is called 4 consecutive times with literals. Use a single append with a single combined String. | 442 |
| ConsecutiveLiteralAppends | StringBuffer (or StringBuilder).append is called 3 consecutive times with literals. Use a single append with a single combined String. | 443 |
| UseStringBufferForStringAppends | Prefer StringBuilder (non-synchronized) or StringBuffer (synchronized) over += for concatenating strings | 450 |
| PositionLiteralsFirstInComparisons | Position literals first in String comparisons | 455 |
| PositionLiteralsFirstInComparisons | Position literals first in String comparisons | 466 |
| PositionLiteralsFirstInComparisons | Position literals first in String comparisons | 489 |
| UseStringBufferForStringAppends | Prefer StringBuilder (non-synchronized) or StringBuffer (synchronized) over += for concatenating strings | 491 |
| UseStringBufferForStringAppends | Prefer StringBuilder (non-synchronized) or StringBuffer (synchronized) over += for concatenating strings | 495 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 498–507 |
| AvoidLiteralsInIfCondition | Avoid using Literals in Conditional Statements | 498 |
| UseEqualsToCompareStrings | Use equals() to compare strings instead of '==' or '!=' | 498 |
| UseStringBufferForStringAppends | Prefer StringBuilder (non-synchronized) or StringBuffer (synchronized) over += for concatenating strings | 501 |
| InefficientStringBuffering | Avoid concatenating nonliterals in a StringBuffer/StringBuilder constructor or append(). | 510 |
| UseStringBufferForStringAppends | Prefer StringBuilder (non-synchronized) or StringBuffer (synchronized) over += for concatenating strings | 523 |
| ConsecutiveLiteralAppends | StringBuffer (or StringBuilder).append is called 2 consecutive times with literals. Use a single append with a single combined String. | 533 |
| ConsecutiveLiteralAppends | StringBuffer (or StringBuilder).append is called 2 consecutive times with literals. Use a single append with a single combined String. | 533 |
| ConsecutiveLiteralAppends | StringBuffer (or StringBuilder).append is called 2 consecutive times with literals. Use a single append with a single combined String. | 537 |
| ConsecutiveLiteralAppends | StringBuffer (or StringBuilder).append is called 2 consecutive times with literals. Use a single append with a single combined String. | 537 |
| AvoidReassigningLoopVariables | Avoid reassigning the loop control variable 'strData' | 545 |
| UseStringBufferForStringAppends | Prefer StringBuilder (non-synchronized) or StringBuffer (synchronized) over += for concatenating strings | 548 |
| ConsecutiveLiteralAppends | StringBuffer (or StringBuilder).append is called 2 consecutive times with literals. Use a single append with a single combined String. | 552–553 |
| AppendCharacterWithChar | Avoid appending characters as strings in StringBuffer.append. | 557 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 602 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 604 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 606 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 607 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 608 |
| PositionLiteralsFirstInComparisons | Position literals first in String comparisons | 610 |
| PositionLiteralsFirstInComparisons | Position literals first in String comparisons | 615 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 654 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 697 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 698 |
| PositionLiteralsFirstInComparisons | Position literals first in String comparisons | 701 |
| CyclomaticComplexity | The method 'doCreateFieldStructure(HttpServletRequest)' has a cyclomatic complexity of 22. | 815–890 |
| NPathComplexity | The method 'doCreateFieldStructure(HttpServletRequest)' has an NPath complexity of 432 | 815–890 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 817 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 818 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 820 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 821 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 822 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 823 |
| PositionLiteralsFirstInComparisons | Position literals first in String comparisons | 825 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 832 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 833 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 847 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 879 |
| CyclomaticComplexity | The method 'doModifyFieldStructure(HttpServletRequest)' has a cyclomatic complexity of 23. | 925–1003 |
| NPathComplexity | The method 'doModifyFieldStructure(HttpServletRequest)' has an NPath complexity of 864 | 925–1003 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 927 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 928 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 930 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 931 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 932 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 935 |
| PositionLiteralsFirstInComparisons | Position literals first in String comparisons | 937 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 944 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 945 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 992 |
| UnusedLocalVariable | Avoid unused local variables such as 'nNumberFields'. | 1065 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 1065 |
| UnusedLocalVariable | Avoid unused local variables such as 'nNumberData'. | 1067 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 1067 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 1068 |
| UnusedLocalVariable | Avoid unused local variables such as 'nNumberOfRow'. | 1068 |
| ShortVariable | Avoid variables with short names like n | 1069 |
| UseStringBufferForStringAppends | Prefer StringBuilder (non-synchronized) or StringBuffer (synchronized) over += for concatenating strings | 1081 |
| AvoidLiteralsInIfCondition | Avoid using Literals in Conditional Statements | 1163 |
| UseStringBufferForStringAppends | Prefer StringBuilder (non-synchronized) or StringBuffer (synchronized) over += for concatenating strings | 1165 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 1181 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 1238 |
| UnusedLocalVariable | Avoid unused local variables such as 'listConcatFieldNameAndData'. | 1238 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 1239 |
| UnusedLocalVariable | Avoid unused local variables such as 'listConcatFieldNameAndOldData'. | 1239 |
| UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 1240 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 1268 |
| UseStringBufferForStringAppends | Prefer StringBuilder (non-synchronized) or StringBuffer (synchronized) over += for concatenating strings | 1299 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 1323 |
| UnusedLocalVariable | Avoid unused local variables such as 'listFieldsNames'. | 1323 |
| UnusedLocalVariable | Avoid unused local variables such as 'strConcatFieldNameAndData'. | 1327 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 1327 |
| Rule | Violation | Line |
|---|---|---|
| UnusedImports | Avoid unused imports such as 'java.util.StringTokenizer' | 51 |
| DoNotThrowExceptionInFinally | A throw statement in a finally block makes the control flow hard to understand. | 295–310 |
| Rule | Violation | Line |
|---|---|---|
| UnusedImports | Avoid unused imports such as 'fr.paris.lutece.portal.service.plugin.Plugin' | 46 |
| UnusedImports | Avoid unused imports such as 'fr.paris.lutece.util.ReferenceList' | 47 |
| UnusedImports | Avoid unused imports such as 'java.sql.SQLException' | 49 |
| Rule | Violation | Line |
|---|---|---|
| UnusedImports | Avoid unused imports such as 'java.sql.SQLException' | 40 |
| Rule | Violation | Line |
|---|---|---|
| UnusedImports | Avoid unused imports such as 'fr.paris.lutece.portal.service.plugin.Plugin' | 37 |
| UnusedImports | Avoid unused imports such as 'java.util.Collection' | 39 |
| Rule | Violation | Line |
|---|---|---|
| UnusedImports | Avoid unused imports such as 'java.sql.ResultSet' | 38 |
| UnusedImports | Avoid unused imports such as 'java.sql.SQLException' | 39 |
| Rule | Violation | Line |
|---|---|---|
| UnusedImports | Avoid unused imports such as 'fr.paris.lutece.portal.service.plugin.Plugin' | 37 |
| UnusedImports | Avoid unused imports such as 'fr.paris.lutece.util.sql.DAOUtil' | 40 |
| UnusedImports | Avoid unused imports such as 'java.util.Collection' | 49 |
| DoNotThrowExceptionInFinally | A throw statement in a finally block makes the control flow hard to understand. | 148–163 |
| Rule | Violation | Line |
|---|---|---|
| UnusedImports | Avoid unused imports such as 'fr.paris.lutece.portal.service.plugin.Plugin' | 37 |
| UnusedImports | Avoid unused imports such as 'java.util.Collection' | 40 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UnusedImports | Avoid unused imports such as 'java.util.StringTokenizer' | 4 | 51 |
| TooManyMethods | This class has too many methods, consider refactoring it. | 3 | 58–400 |
| UnusedPrivateField | Avoid unused private fields such as 'SELECT'. | 3 | 62 |
| UnusedPrivateField | Avoid unused private fields such as 'FROM'. | 3 | 63 |
| MissingOverride | The method 'selectDataList(String, PluginConnectionService)' is missing an @Override annotation. | 3 | 81–95 |
| UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 3 | 83 |
| MissingOverride | The method 'selectDataListUserRequest(String, String, PluginConnectionService)' is missing an @Override annotation. | 3 | 104–121 |
| AvoidReassigningParameters | Avoid reassigning parameters such as 'connectionService' | 2 | 105 |
| UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 3 | 107 |
| MissingOverride | The method 'insert(String, String, List, List, PluginConnectionService)' is missing an @Override annotation. | 3 | 131–158 |
| UseStringBufferForStringAppends | Prefer StringBuilder (non-synchronized) or StringBuffer (synchronized) over += for concatenating strings | 3 | 139 |
| UseStringBufferForStringAppends | Prefer StringBuilder (non-synchronized) or StringBuffer (synchronized) over += for concatenating strings | 3 | 148 |
| MissingOverride | The method 'store(String, String, List, PluginConnectionService)' is missing an @Override annotation. | 3 | 167–188 |
| UseStringBufferForStringAppends | Prefer StringBuilder (non-synchronized) or StringBuffer (synchronized) over += for concatenating strings | 3 | 175 |
| UseStringBufferForStringAppends | Prefer StringBuilder (non-synchronized) or StringBuffer (synchronized) over += for concatenating strings | 3 | 177 |
| MissingOverride | The method 'delete(String, String, List, PluginConnectionService)' is missing an @Override annotation. | 3 | 197–213 |
| UseStringBufferForStringAppends | Prefer StringBuilder (non-synchronized) or StringBuffer (synchronized) over += for concatenating strings | 3 | 204 |
| MissingOverride | The method 'insertWithUserRequest(String, PluginConnectionService, String)' is missing an @Override annotation. | 3 | 221–227 |
| MissingOverride | The method 'load(String, String, List, PluginConnectionService)' is missing an @Override annotation. | 3 | 237–244 |
| UnnecessaryLocalBeforeReturn | Consider simply returning the value vs storing it in local variable 'listDataValueSelectedByPK' | 3 | 243 |
| CloseResource | Ensure that resources like this Connection object are closed after use | 3 | 255 |
| CloseResource | Ensure that resources like this ResultSet object are closed after use | 3 | 263 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 3 | 275–282 |
| NullAssignment | Assigning an Object to null is a code smell. Consider refactoring. | 3 | 291 |
| DoNotThrowExceptionInFinally | A throw statement in a finally block makes the control flow hard to understand. | 4 | 295–310 |
| PreserveStackTrace | New exception is thrown in catch block, original stack trace may be lost | 3 | 306 |
| MissingOverride | The method 'findResultOfUserRequest(String, PluginConnectionService)' is missing an @Override annotation. | 3 | 319–334 |
| UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 3 | 321 |
| UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 3 | 322 |
| UnusedLocalVariable | Avoid unused local variables such as 'listFields'. | 3 | 322 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 322 |
| MissingOverride | The method 'selectColumnNames(String, PluginConnectionService, String)' is missing an @Override annotation. | 3 | 343–359 |
| PreserveStackTrace | New exception is thrown in catch block, original stack trace may be lost | 3 | 372 |
| PreserveStackTrace | New exception is thrown in catch block, original stack trace may be lost | 3 | 387 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UseUtilityClass | All methods are static. Consider using a utility class instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning. | 3 | 55–174 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| TooManyFields | Too many fields | 3 | 40–350 |
| UnusedPrivateField | Avoid unused private fields such as '_strCommentValue'. | 3 | 52 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| GodClass | Possible God Class (WMC=59, ATFD=74, TCC=5.000%) | 3 | 52–656 |
| TooManyMethods | This class has too many methods, consider refactoring it. | 3 | 53–656 |
| UnusedPrivateField | Avoid unused private fields such as 'FOREIGN_KEY'. | 3 | 61 |
| UnusedPrivateField | Avoid unused private fields such as 'INDEX_KEY'. | 3 | 62 |
| UnusedPrivateField | Avoid unused private fields such as 'UNIQUE_KEY'. | 3 | 63 |
| UnusedPrivateField | Avoid unused private fields such as 'POOL_ADMINSQL'. | 3 | 66 |
| CyclomaticComplexity | The method 'load(String, String, String, Plugin)' has a cyclomatic complexity of 16. | 3 | 91–153 |
| MissingOverride | The method 'load(String, String, String, Plugin)' is missing an @Override annotation. | 3 | 91–153 |
| PositionLiteralsFirstInComparisons | Position literals first in String comparisons | 3 | 106 |
| PositionLiteralsFirstInComparisons | Position literals first in String comparisons | 3 | 106 |
| PositionLiteralsFirstInComparisons | Position literals first in String comparisons | 3 | 106 |
| PositionLiteralsFirstInComparisons | Position literals first in String comparisons | 3 | 107 |
| PositionLiteralsFirstInComparisons | Position literals first in String comparisons | 3 | 107 |
| PositionLiteralsFirstInComparisons | Position literals first in String comparisons | 3 | 108 |
| PositionLiteralsFirstInComparisons | Position literals first in String comparisons | 3 | 108 |
| PositionLiteralsFirstInComparisons | Position literals first in String comparisons | 3 | 109 |
| PositionLiteralsFirstInComparisons | Position literals first in String comparisons | 3 | 109 |
| PositionLiteralsFirstInComparisons | Position literals first in String comparisons | 3 | 110 |
| PositionLiteralsFirstInComparisons | Position literals first in String comparisons | 3 | 110 |
| PositionLiteralsFirstInComparisons | Position literals first in String comparisons | 3 | 111 |
| PositionLiteralsFirstInComparisons | Position literals first in String comparisons | 3 | 132 |
| CyclomaticComplexity | The method 'store(String, String, Field, String, int, Plugin)' has a cyclomatic complexity of 10. | 3 | 164–236 |
| MissingOverride | The method 'store(String, String, Field, String, int, Plugin)' is missing an @Override annotation. | 3 | 164–236 |
| PositionLiteralsFirstInComparisons | Position literals first in String comparisons | 3 | 178 |
| PositionLiteralsFirstInComparisons | Position literals first in String comparisons | 3 | 192 |
| PositionLiteralsFirstInComparisons | Position literals first in String comparisons | 3 | 219 |
| MissingOverride | The method 'insert(String, String, Field, Plugin)' is missing an @Override annotation. | 3 | 245–342 |
| PositionLiteralsFirstInComparisons | Position literals first in String comparisons | 3 | 258 |
| PositionLiteralsFirstInComparisons | Position literals first in String comparisons | 3 | 272 |
| UnusedLocalVariable | Avoid unused local variables such as 'strFieldLabelKeyValue'. | 3 | 284 |
| AvoidLiteralsInIfCondition | Avoid using Literals in Conditional Statements | 3 | 287 |
| PositionLiteralsFirstInComparisons | Position literals first in String comparisons | 3 | 299 |
| UseStringBufferForStringAppends | Prefer StringBuilder (non-synchronized) or StringBuffer (synchronized) over += for concatenating strings | 3 | 306 |
| UnusedLocalVariable | Avoid unused local variables such as 'nAddFieldEndOfTable'. | 3 | 309 |
| UnusedLocalVariable | Avoid unused local variables such as 'nAddFieldBeginningOfTable'. | 3 | 310 |
| UnusedLocalVariable | Avoid unused local variables such as 'nAddFieldAfterAField'. | 3 | 311 |
| AvoidLiteralsInIfCondition | Avoid using Literals in Conditional Statements | 3 | 315 |
| AvoidLiteralsInIfCondition | Avoid using Literals in Conditional Statements | 3 | 327 |
| MissingOverride | The method 'delete(String, String, Plugin)' is missing an @Override annotation. | 3 | 350–355 |
| MissingOverride | The method 'selectFieldList(String, String, Plugin)' is missing an @Override annotation. | 3 | 364–399 |
| UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 3 | 366 |
| MissingOverride | The method 'selectFieldTypeList(String, Plugin)' is missing an @Override annotation. | 3 | 407–426 |
| AvoidReassigningParameters | Avoid reassigning parameters such as 'plugin' | 2 | 407 |
| MissingOverride | The method 'selectFieldKeyList(String, Plugin)' is missing an @Override annotation. | 3 | 434–453 |
| AvoidReassigningParameters | Avoid reassigning parameters such as 'plugin' | 2 | 434 |
| MissingOverride | The method 'selectFieldNullList(String, Plugin)' is missing an @Override annotation. | 3 | 461–479 |
| AvoidReassigningParameters | Avoid reassigning parameters such as 'plugin' | 2 | 488 |
| AvoidReassigningParameters | Avoid reassigning parameters such as 'plugin' | 2 | 514 |
| AvoidReassigningParameters | Avoid reassigning parameters such as 'plugin' | 2 | 540 |
| AvoidReassigningParameters | Avoid reassigning parameters such as 'plugin' | 2 | 566 |
| AvoidReassigningParameters | Avoid reassigning parameters such as 'plugin' | 2 | 592 |
| AvoidReassigningParameters | Avoid reassigning parameters such as 'plugin' | 2 | 618 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UseUtilityClass | All methods are static. Consider using a utility class instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning. | 3 | 46–150 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| FieldNamingConventions | The field name 'strFieldName' doesn't match '_[a-z][a-zA-Z0-9]*' | 1 | 43 |
| FieldNamingConventions | The field name 'strOldValue' doesn't match '_[a-z][a-zA-Z0-9]*' | 1 | 44 |
| FieldNamingConventions | The field name 'strNewValue' doesn't match '_[a-z][a-zA-Z0-9]*' | 1 | 45 |
| UnnecessaryConstructor | Avoid unnecessary constructors - the compiler will generate these for you | 3 | 48–50 |
| UncommentedEmptyConstructor | Document empty constructor | 3 | 48–50 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| ImportFromSamePackage | No need to import a type that lives in the same package | 3 | 44 |
| UnusedImports | Avoid unused imports such as 'fr.paris.lutece.portal.service.plugin.Plugin' | 4 | 46 |
| UnusedImports | Avoid unused imports such as 'fr.paris.lutece.util.ReferenceList' | 4 | 47 |
| UnusedImports | Avoid unused imports such as 'java.sql.SQLException' | 4 | 49 |
| UnnecessaryModifier | Unnecessary modifier 'public' on method 'load': the method is declared in an interface type | 3 | 105–106 |
| UnnecessaryModifier | Unnecessary modifier 'public' on method 'selectColumnNames': the method is declared in an interface type | 3 | 123–124 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| ImportFromSamePackage | No need to import a type that lives in the same package | 3 | 36 |
| UnusedImports | Avoid unused imports such as 'java.sql.SQLException' | 4 | 40 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UnusedImports | Avoid unused imports such as 'fr.paris.lutece.portal.service.plugin.Plugin' | 4 | 37 |
| UnusedImports | Avoid unused imports such as 'java.util.Collection' | 4 | 39 |
| CommentRequired | Public method and constructor comments are required | 3 | 55 |
| CommentRequired | Public method and constructor comments are required | 3 | 57 |
| CommentRequired | Public method and constructor comments are required | 3 | 59 |
| CommentRequired | Public method and constructor comments are required | 3 | 61 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UnusedImports | Avoid unused imports such as 'java.sql.ResultSet' | 4 | 38 |
| UnusedImports | Avoid unused imports such as 'java.sql.SQLException' | 4 | 39 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UnusedImports | Avoid unused imports such as 'fr.paris.lutece.portal.service.plugin.Plugin' | 4 | 37 |
| UnusedImports | Avoid unused imports such as 'fr.paris.lutece.util.sql.DAOUtil' | 4 | 40 |
| UnusedImports | Avoid unused imports such as 'java.util.Collection' | 4 | 49 |
| UnusedPrivateField | Avoid unused private fields such as 'SQL_QUERY_NEW_PK'. | 3 | 59 |
| UnusedPrivateField | Avoid unused private fields such as 'SQL_QUERY_SELECT'. | 3 | 60 |
| UnusedPrivateField | Avoid unused private fields such as 'SQL_QUERY_INSERT'. | 3 | 61 |
| UnusedPrivateField | Avoid unused private fields such as 'SQL_QUERY_DELETE'. | 3 | 62 |
| UnusedPrivateField | Avoid unused private fields such as 'SQL_QUERY_UPDATE'. | 3 | 63 |
| CommentRequired | Public method and constructor comments are required | 3 | 72–86 |
| MissingOverride | The method 'selectAllTables(PluginConnectionService)' is missing an @Override annotation. | 3 | 72–86 |
| UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 3 | 74 |
| MissingOverride | The method 'selectAllColumns(PluginConnectionService, String)' is missing an @Override annotation. | 3 | 88–102 |
| CommentRequired | Public method and constructor comments are required | 3 | 88–102 |
| UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 3 | 90 |
| CommentRequired | Public method and constructor comments are required | 3 | 104–164 |
| CloseResource | Ensure that resources like this Connection object are closed after use | 3 | 107 |
| CloseResource | Ensure that resources like this ResultSet object are closed after use | 3 | 116 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 3 | 128–135 |
| NullAssignment | Assigning an Object to null is a code smell. Consider refactoring. | 3 | 144 |
| DoNotThrowExceptionInFinally | A throw statement in a finally block makes the control flow hard to understand. | 4 | 148–163 |
| PreserveStackTrace | New exception is thrown in catch block, original stack trace may be lost | 3 | 159 |
| CommentRequired | Public method and constructor comments are required | 3 | 166–180 |
| MissingOverride | The method 'selectAllData(PluginConnectionService, String)' is missing an @Override annotation. | 3 | 166–180 |
| UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 3 | 168 |
| CommentRequired | Public method and constructor comments are required | 3 | 182–196 |
| MissingOverride | The method 'selectAllFields(PluginConnectionService, String)' is missing an @Override annotation. | 3 | 182–196 |
| UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 3 | 184 |
| MissingOverride | The method 'selectAField(PluginConnectionService, String, String)' is missing an @Override annotation. | 3 | 198–214 |
| CommentRequired | Public method and constructor comments are required | 3 | 198–214 |
| UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 3 | 201 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UnusedImports | Avoid unused imports such as 'fr.paris.lutece.portal.service.plugin.Plugin' | 4 | 37 |
| UnusedImports | Avoid unused imports such as 'java.util.Collection' | 4 | 40 |
| CommentRequired | Public method and constructor comments are required | 3 | 60–63 |
| CommentRequired | Public method and constructor comments are required | 3 | 65–68 |
| CommentRequired | Public method and constructor comments are required | 3 | 70–73 |
| CommentRequired | Public method and constructor comments are required | 3 | 75–78 |
| CommentRequired | Public method and constructor comments are required | 3 | 80–84 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| CommentRequired | Public method and constructor comments are required | 3 | 69–72 |
| UncommentedEmptyMethodBody | Document empty method body | 3 | 70–72 |
| CommentRequired | Public method and constructor comments are required | 3 | 74–77 |
| UncommentedEmptyMethodBody | Document empty method body | 3 | 75–77 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| TooManyMethods | This class has too many methods, consider refactoring it. | 3 | 53–511 |
| UnusedPrivateField | Avoid unused private fields such as 'CHANGE'. | 3 | 57 |
| UnusedPrivateField | Avoid unused private fields such as 'ADD'. | 3 | 58 |
| UnusedPrivateField | Avoid unused private fields such as 'FOREIGN_KEY'. | 3 | 60 |
| UnusedPrivateField | Avoid unused private fields such as 'INDEX_KEY'. | 3 | 61 |
| UnusedPrivateField | Avoid unused private fields such as 'UNIQUE_KEY'. | 3 | 62 |
| UnusedPrivateField | Avoid unused private fields such as 'DROP'. | 3 | 63 |
| UnusedPrivateField | Avoid unused private fields such as 'WHERE'. | 3 | 65 |
| UnusedPrivateField | Avoid unused private fields such as 'SPACE'. | 3 | 66 |
| UnusedPrivateField | Avoid unused private fields such as 'USER'. | 3 | 67 |
| UnusedPrivateField | Avoid unused private fields such as 'PASSWORD'. | 3 | 68 |
| UnusedPrivateField | Avoid unused private fields such as 'SQL_QUERY_SELECT'. | 3 | 80 |
| UnusedPrivateField | Avoid unused private fields such as 'SQL_QUERY_SHOW_DATABASE_TABLES_BY_POOL'. | 3 | 82 |
| UnusedPrivateField | Avoid unused private fields such as 'SQL_QUERY_SELECT_A_TABLE_ON_DATABASE'. | 3 | 83 |
| MissingOverride | The method 'load(String, String, Plugin)' is missing an @Override annotation. | 3 | 96–113 |
| MissingOverride | The method 'insert(String, Table, Field, Plugin)' is missing an @Override annotation. | 3 | 122–182 |
| PositionLiteralsFirstInComparisons | Position literals first in String comparisons | 3 | 135 |
| UnusedLocalVariable | Avoid unused local variables such as 'strFieldLabelKeyValue'. | 3 | 147 |
| AvoidLiteralsInIfCondition | Avoid using Literals in Conditional Statements | 3 | 150 |
| PositionLiteralsFirstInComparisons | Position literals first in String comparisons | 3 | 162 |
| UseStringBufferForStringAppends | Prefer StringBuilder (non-synchronized) or StringBuffer (synchronized) over += for concatenating strings | 3 | 169 |
| SystemPrintln | System.out.println is used | 2 | 172 |
| MissingOverride | The method 'store(String, Table)' is missing an @Override annotation. | 3 | 189–195 |
| MissingOverride | The method 'delete(String, Plugin)' is missing an @Override annotation. | 3 | 202–207 |
| MissingOverride | The method 'selectTableList(Plugin)' is missing an @Override annotation. | 3 | 214–230 |
| UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 3 | 216 |
| MissingOverride | The method 'selectTableListByPool(String, Plugin)' is missing an @Override annotation. | 3 | 238–256 |
| UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 3 | 242 |
| AvoidReassigningParameters | Avoid reassigning parameters such as 'plugin' | 2 | 342 |
| AvoidReassigningParameters | Avoid reassigning parameters such as 'plugin' | 2 | 368 |
| AvoidReassigningParameters | Avoid reassigning parameters such as 'plugin' | 2 | 394 |
| AvoidReassigningParameters | Avoid reassigning parameters such as 'plugin' | 2 | 420 |
| AvoidReassigningParameters | Avoid reassigning parameters such as 'plugin' | 2 | 446 |
| AvoidReassigningParameters | Avoid reassigning parameters such as 'plugin' | 2 | 472 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UseUtilityClass | All methods are static. Consider using a utility class instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning. | 3 | 47–115 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| ReplaceHashtableWithMap | Consider replacing this Hashtable with the newer java.util.Map | 3 | 49 |
| LooseCoupling | Avoid using implementation types like 'Hashtable'; use the interface instead | 3 | 49 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 3 | 69–84 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UseUtilityClass | All methods are static. Consider using a utility class instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning. | 3 | 49–59 |
| CommentRequired | Public method and constructor comments are required | 3 | 50–58 |
| UseIndexOfChar | String.indexOf(char) is faster than String.indexOf(String). | 3 | 53 |
| UseIndexOfChar | String.indexOf(char) is faster than String.indexOf(String). | 3 | 54 |
| UseIndexOfChar | String.indexOf(char) is faster than String.indexOf(String). | 3 | 55 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| CyclomaticComplexity | The class 'AdminSqlJspBean' has a total cyclomatic complexity of 126 (highest 23). | 3 | 64–1346 |
| TooManyFields | Too many fields | 3 | 64–1346 |
| ExcessiveClassLength | Avoid really long classes. | 3 | 64–1346 |
| MissingSerialVersionUID | Classes implementing Serializable should set a serialVersionUID | 3 | 64–1346 |
| TooManyMethods | This class has too many methods, consider refactoring it. | 3 | 65–1346 |
| UnusedPrivateField | Avoid unused private fields such as 'MESSAGE_TITLE_INVALID_CHARACTERS'. | 3 | 70 |
| UnusedPrivateField | Avoid unused private fields such as 'PROPERTY_CONFIRM_MODIFY_FIELD'. | 3 | 86 |
| UnusedPrivateField | Avoid unused private fields such as 'PARAMETER_DATA_ID'. | 3 | 99 |
| UnusedPrivateField | Avoid unused private fields such as 'PARAMETER_LABEL_TYPE_VALUE'. | 3 | 101 |
| UnusedPrivateField | Avoid unused private fields such as 'PARAMETER_NULL_VALUE'. | 3 | 102 |
| UnusedPrivateField | Avoid unused private fields such as 'PARAMETER_FIELD_LABEL_TYPE'. | 3 | 103 |
| UnusedPrivateField | Avoid unused private fields such as 'PARAMETER_FIELD_NULL'. | 3 | 106 |
| UnusedPrivateField | Avoid unused private fields such as 'PARAMETER_FIELD_COMMENT'. | 3 | 107 |
| UnusedPrivateField | Avoid unused private fields such as 'PARAMETER_FIELD_KEY'. | 3 | 108 |
| UnusedPrivateField | Avoid unused private fields such as 'PARAMETER_FIELDS_NUMBER_ADDING'. | 3 | 114 |
| UnusedPrivateField | Avoid unused private fields such as 'PARAMETER_NUMBER_FIELDS_TABLE'. | 3 | 117 |
| UnusedPrivateField | Avoid unused private fields such as 'PARAMETER_DATA'. | 3 | 118 |
| UnusedPrivateField | Avoid unused private fields such as 'PARAMETER_CONCAT_FIELDNAME_DATA'. | 3 | 119 |
| UnusedPrivateField | Avoid unused private fields such as 'PARAMETER_DB_TYPE_NAME'. | 3 | 121 |
| UnusedPrivateField | Avoid unused private fields such as 'PARAMETER_IDENTIFIANT_USER'. | 3 | 122 |
| UnusedPrivateField | Avoid unused private fields such as 'PARAMETER_PASSWORD_USER'. | 3 | 123 |
| UnusedPrivateField | Avoid unused private fields such as 'PARAMETER_ROW_TO_MODIFY'. | 3 | 124 |
| UnusedPrivateField | Avoid unused private fields such as 'MARK_DATA_LIST_TO_MODIFY'. | 3 | 135 |
| UnusedPrivateField | Avoid unused private fields such as 'MARK_PRIMARY_KEY_LIST'. | 3 | 136 |
| UnusedPrivateField | Avoid unused private fields such as 'MARK_FIELD_NAME_REFERENCE_LIST'. | 3 | 143 |
| UnusedPrivateField | Avoid unused private fields such as 'MARK_NUMBER_FIELDS_TABLE'. | 3 | 146 |
| UnusedPrivateField | Avoid unused private fields such as 'MARK_CONCAT_PRIMARY_KEY_AND_VALUE'. | 3 | 147 |
| UnusedPrivateField | Avoid unused private fields such as 'MARK_DATABASE_TYPE_LIST'. | 3 | 151 |
| UnusedPrivateField | Avoid unused private fields such as 'MARK_DB_TYPE_NAME'. | 3 | 152 |
| UnusedPrivateField | Avoid unused private fields such as 'MARK_SQL_ERROR'. | 3 | 153 |
| UnusedPrivateField | Avoid unused private fields such as 'MARK_DUMP_SCRIPT'. | 3 | 154 |
| UnusedPrivateField | Avoid unused private fields such as 'JSP_DO_MODIFY_FIELD_STRUCTURE'. | 3 | 167 |
| UnusedPrivateField | Avoid unused private fields such as 'PROPERTY_DATABASE_TYPE_LIST'. | 3 | 174 |
| UnusedPrivateField | Avoid unused private fields such as 'URL_MODIFY_DATA'. | 3 | 180 |
| UnusedPrivateField | Avoid unused private fields such as 'URL_DO_USER_REQUEST_ERROR'. | 3 | 182 |
| FieldNamingConventions | The field name 'TEMPLATE_MANAGE_POOL_SQL' doesn't match '_[a-z][a-zA-Z0-9]*' | 1 | 186 |
| ImmutableField | Private field 'TEMPLATE_MANAGE_POOL_SQL' could be made final; it is only initialized in the declaration or constructor. | 3 | 186 |
| ImmutableField | Private field 'TEMPLATE_MANAGE_TABLE_SQL' could be made final; it is only initialized in the declaration or constructor. | 3 | 187 |
| FieldNamingConventions | The field name 'TEMPLATE_MANAGE_TABLE_SQL' doesn't match '_[a-z][a-zA-Z0-9]*' | 1 | 187 |
| FieldNamingConventions | The field name 'TEMPLATE_MANAGE_DATA_SQL' doesn't match '_[a-z][a-zA-Z0-9]*' | 1 | 188 |
| ImmutableField | Private field 'TEMPLATE_MANAGE_DATA_SQL' could be made final; it is only initialized in the declaration or constructor. | 3 | 188 |
| ImmutableField | Private field 'TEMPLATE_CREATE_DATA' could be made final; it is only initialized in the declaration or constructor. | 3 | 189 |
| FieldNamingConventions | The field name 'TEMPLATE_CREATE_DATA' doesn't match '_[a-z][a-zA-Z0-9]*' | 1 | 189 |
| ImmutableField | Private field 'TEMPLATE_MANAGE_STRUCTURE_SQL' could be made final; it is only initialized in the declaration or constructor. | 3 | 190 |
| FieldNamingConventions | The field name 'TEMPLATE_MANAGE_STRUCTURE_SQL' doesn't match '_[a-z][a-zA-Z0-9]*' | 1 | 190 |
| FieldNamingConventions | The field name 'TEMPLATE_MODIFY_DATA' doesn't match '_[a-z][a-zA-Z0-9]*' | 1 | 191 |
| ImmutableField | Private field 'TEMPLATE_MODIFY_DATA' could be made final; it is only initialized in the declaration or constructor. | 3 | 191 |
| ImmutableField | Private field 'TEMPLATE_MODIFY_STRUCTURE' could be made final; it is only initialized in the declaration or constructor. | 3 | 192 |
| FieldNamingConventions | The field name 'TEMPLATE_MODIFY_STRUCTURE' doesn't match '_[a-z][a-zA-Z0-9]*' | 1 | 192 |
| ImmutableField | Private field 'TEMPLATE_CREATE_STRUCTURE' could be made final; it is only initialized in the declaration or constructor. | 3 | 193 |
| FieldNamingConventions | The field name 'TEMPLATE_CREATE_STRUCTURE' doesn't match '_[a-z][a-zA-Z0-9]*' | 1 | 193 |
| ImmutableField | Private field 'TEMPLATE_CREATE_TABLE' could be made final; it is only initialized in the declaration or constructor. | 3 | 194 |
| FieldNamingConventions | The field name 'TEMPLATE_CREATE_TABLE' doesn't match '_[a-z][a-zA-Z0-9]*' | 1 | 194 |
| ImmutableField | Private field 'TEMPLATE_MODIFY_TABLE_NAME' could be made final; it is only initialized in the declaration or constructor. | 3 | 195 |
| FieldNamingConventions | The field name 'TEMPLATE_MODIFY_TABLE_NAME' doesn't match '_[a-z][a-zA-Z0-9]*' | 1 | 195 |
| FieldNamingConventions | The field name 'TEMPLATE_CHOOSE_FONCTIONNALITIES_LIST' doesn't match '_[a-z][a-zA-Z0-9]*' | 1 | 196 |
| ImmutableField | Private field 'TEMPLATE_CHOOSE_FONCTIONNALITIES_LIST' could be made final; it is only initialized in the declaration or constructor. | 3 | 196 |
| ImmutableField | Private field 'TEMPLATE_USER_REQUEST' could be made final; it is only initialized in the declaration or constructor. | 3 | 197 |
| FieldNamingConventions | The field name 'TEMPLATE_USER_REQUEST' doesn't match '_[a-z][a-zA-Z0-9]*' | 1 | 197 |
| FieldNamingConventions | The field name 'TEMPLATE_RESULT_OF_USER_REQUEST' doesn't match '_[a-z][a-zA-Z0-9]*' | 1 | 198 |
| ImmutableField | Private field 'TEMPLATE_RESULT_OF_USER_REQUEST' could be made final; it is only initialized in the declaration or constructor. | 3 | 198 |
| FieldNamingConventions | The field name 'TEMPLATE_EXPORT_DATABASE' doesn't match '_[a-z][a-zA-Z0-9]*' | 1 | 199 |
| UnusedPrivateField | Avoid unused private fields such as 'TEMPLATE_EXPORT_DATABASE'. | 3 | 199 |
| ImmutableField | Private field 'TEMPLATE_EXPORT_DATABASE' could be made final; it is only initialized in the declaration or constructor. | 3 | 199 |
| UnusedPrivateField | Avoid unused private fields such as 'TEMPLATE_SQL_ERROR_PAGE'. | 3 | 200 |
| ImmutableField | Private field 'TEMPLATE_SQL_ERROR_PAGE' could be made final; it is only initialized in the declaration or constructor. | 3 | 200 |
| FieldNamingConventions | The field name 'TEMPLATE_SQL_ERROR_PAGE' doesn't match '_[a-z][a-zA-Z0-9]*' | 1 | 200 |
| ImmutableField | Private field 'TEMPLATE_PARAMETER_TO_EXPORT_DATABASE' could be made final; it is only initialized in the declaration or constructor. | 3 | 201 |
| FieldNamingConventions | The field name 'TEMPLATE_PARAMETER_TO_EXPORT_DATABASE' doesn't match '_[a-z][a-zA-Z0-9]*' | 1 | 201 |
| ImmutableField | Private field 'TEMPLATE_DUMP_DATABASE' could be made final; it is only initialized in the declaration or constructor. | 3 | 202 |
| FieldNamingConventions | The field name 'TEMPLATE_DUMP_DATABASE' doesn't match '_[a-z][a-zA-Z0-9]*' | 1 | 202 |
| ImmutableField | Private field 'TEMPLATE_USER_REQUEST_ERROR' could be made final; it is only initialized in the declaration or constructor. | 3 | 203 |
| FieldNamingConventions | The field name 'TEMPLATE_USER_REQUEST_ERROR' doesn't match '_[a-z][a-zA-Z0-9]*' | 1 | 203 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 3 | 257 |
| UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 3 | 257 |
| UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 3 | 277 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 3 | 277 |
| UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 3 | 294 |
| UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 3 | 295 |
| UseLocaleWithCaseConversions | When doing a String.toLowerCase()/toUpperCase() call, use a Locale | 3 | 299 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 3 | 316 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 3 | 317 |
| UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 3 | 317 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 3 | 338 |
| UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 3 | 339 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 3 | 339 |
| EqualsNull | Avoid using equals() to compare against null | 1 | 351 |
| UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 3 | 360 |
| CommentRequired | Public method and constructor comments are required | 3 | 373–383 |
| UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 3 | 393 |
| CyclomaticComplexity | The method 'doExportDatabase(HttpServletRequest)' has a cyclomatic complexity of 23. | 3 | 407–571 |
| ExcessiveMethodLength | Avoid really long methods. | 3 | 407–571 |
| NPathComplexity | The method 'doExportDatabase(HttpServletRequest)' has an NPath complexity of 2907 | 3 | 407–571 |
| NcssCount | The method 'doExportDatabase(HttpServletRequest)' has a NCSS line count of 95. | 3 | 407–571 |
| UnusedLocalVariable | Avoid unused local variables such as 'DumpCommandslist'. | 3 | 416 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 416 |
| LocalVariableNamingConventions | The local variable name 'DumpCommandslist' doesn't match '[a-z][a-zA-Z0-9]*' | 1 | 416 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 417 |
| UnusedLocalVariable | Avoid unused local variables such as 'listRows'. | 3 | 417 |
| InsufficientStringBufferDeclaration | StringBuffer constructor is initialized with size 16, but has at least 134 characters appended. | 3 | 418 |
| UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 3 | 419 |
| UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 3 | 420 |
| UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 3 | 421 |
| ConsecutiveLiteralAppends | StringBuffer (or StringBuilder).append is called 2 consecutive times with literals. Use a single append with a single combined String. | 3 | 423 |
| AvoidDuplicateLiterals | The String literal "\n--\n\n" appears 4 times in this file; the first occurrence is on line 423 | 3 | 423 |
| ConsecutiveLiteralAppends | StringBuffer (or StringBuilder).append is called 3 consecutive times with literals. Use a single append with a single combined String. | 3 | 423 |
| ConsecutiveAppendsShouldReuse | StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 3 | 423 |
| ConsecutiveLiteralAppends | StringBuffer (or StringBuilder).append is called 2 consecutive times with literals. Use a single append with a single combined String. | 3 | 442 |
| ConsecutiveLiteralAppends | StringBuffer (or StringBuilder).append is called 4 consecutive times with literals. Use a single append with a single combined String. | 3 | 442 |
| ConsecutiveLiteralAppends | StringBuffer (or StringBuilder).append is called 3 consecutive times with literals. Use a single append with a single combined String. | 3 | 443 |
| UseStringBufferForStringAppends | Prefer StringBuilder (non-synchronized) or StringBuffer (synchronized) over += for concatenating strings | 3 | 450 |
| PositionLiteralsFirstInComparisons | Position literals first in String comparisons | 3 | 455 |
| PositionLiteralsFirstInComparisons | Position literals first in String comparisons | 3 | 466 |
| PositionLiteralsFirstInComparisons | Position literals first in String comparisons | 3 | 489 |
| UseStringBufferForStringAppends | Prefer StringBuilder (non-synchronized) or StringBuffer (synchronized) over += for concatenating strings | 3 | 491 |
| UseStringBufferForStringAppends | Prefer StringBuilder (non-synchronized) or StringBuffer (synchronized) over += for concatenating strings | 3 | 495 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 3 | 498–507 |
| AvoidLiteralsInIfCondition | Avoid using Literals in Conditional Statements | 3 | 498 |
| UseEqualsToCompareStrings | Use equals() to compare strings instead of '==' or '!=' | 3 | 498 |
| UseStringBufferForStringAppends | Prefer StringBuilder (non-synchronized) or StringBuffer (synchronized) over += for concatenating strings | 3 | 501 |
| InefficientStringBuffering | Avoid concatenating nonliterals in a StringBuffer/StringBuilder constructor or append(). | 3 | 510 |
| UseStringBufferForStringAppends | Prefer StringBuilder (non-synchronized) or StringBuffer (synchronized) over += for concatenating strings | 3 | 523 |
| ConsecutiveLiteralAppends | StringBuffer (or StringBuilder).append is called 2 consecutive times with literals. Use a single append with a single combined String. | 3 | 533 |
| ConsecutiveLiteralAppends | StringBuffer (or StringBuilder).append is called 2 consecutive times with literals. Use a single append with a single combined String. | 3 | 533 |
| ConsecutiveLiteralAppends | StringBuffer (or StringBuilder).append is called 2 consecutive times with literals. Use a single append with a single combined String. | 3 | 537 |
| ConsecutiveLiteralAppends | StringBuffer (or StringBuilder).append is called 2 consecutive times with literals. Use a single append with a single combined String. | 3 | 537 |
| AvoidReassigningLoopVariables | Avoid reassigning the loop control variable 'strData' | 3 | 545 |
| UseStringBufferForStringAppends | Prefer StringBuilder (non-synchronized) or StringBuffer (synchronized) over += for concatenating strings | 3 | 548 |
| ConsecutiveLiteralAppends | StringBuffer (or StringBuilder).append is called 2 consecutive times with literals. Use a single append with a single combined String. | 3 | 552–553 |
| AppendCharacterWithChar | Avoid appending characters as strings in StringBuffer.append. | 3 | 557 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 602 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 604 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 606 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 607 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 608 |
| PositionLiteralsFirstInComparisons | Position literals first in String comparisons | 3 | 610 |
| EqualsNull | Avoid using equals() to compare against null | 1 | 610 |
| EqualsNull | Avoid using equals() to compare against null | 1 | 615 |
| PositionLiteralsFirstInComparisons | Position literals first in String comparisons | 3 | 615 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 3 | 654 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 697 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 698 |
| EqualsNull | Avoid using equals() to compare against null | 1 | 701 |
| PositionLiteralsFirstInComparisons | Position literals first in String comparisons | 3 | 701 |
| CyclomaticComplexity | The method 'doCreateFieldStructure(HttpServletRequest)' has a cyclomatic complexity of 22. | 3 | 815–890 |
| NPathComplexity | The method 'doCreateFieldStructure(HttpServletRequest)' has an NPath complexity of 432 | 3 | 815–890 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 817 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 818 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 820 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 821 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 822 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 823 |
| PositionLiteralsFirstInComparisons | Position literals first in String comparisons | 3 | 825 |
| EqualsNull | Avoid using equals() to compare against null | 1 | 825 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 832 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 833 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 847 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 3 | 879 |
| CyclomaticComplexity | The method 'doModifyFieldStructure(HttpServletRequest)' has a cyclomatic complexity of 23. | 3 | 925–1003 |
| NPathComplexity | The method 'doModifyFieldStructure(HttpServletRequest)' has an NPath complexity of 864 | 3 | 925–1003 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 927 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 928 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 930 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 931 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 932 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 935 |
| EqualsNull | Avoid using equals() to compare against null | 1 | 937 |
| PositionLiteralsFirstInComparisons | Position literals first in String comparisons | 3 | 937 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 944 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 945 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 3 | 992 |
| UnusedLocalVariable | Avoid unused local variables such as 'nNumberFields'. | 3 | 1065 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 1065 |
| UnusedLocalVariable | Avoid unused local variables such as 'nNumberData'. | 3 | 1067 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 1067 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 1068 |
| UnusedLocalVariable | Avoid unused local variables such as 'nNumberOfRow'. | 3 | 1068 |
| ShortVariable | Avoid variables with short names like n | 3 | 1069 |
| UseStringBufferForStringAppends | Prefer StringBuilder (non-synchronized) or StringBuffer (synchronized) over += for concatenating strings | 3 | 1081 |
| AvoidLiteralsInIfCondition | Avoid using Literals in Conditional Statements | 3 | 1163 |
| UseStringBufferForStringAppends | Prefer StringBuilder (non-synchronized) or StringBuffer (synchronized) over += for concatenating strings | 3 | 1165 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 3 | 1181 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 1238 |
| UnusedLocalVariable | Avoid unused local variables such as 'listConcatFieldNameAndData'. | 3 | 1238 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 1239 |
| UnusedLocalVariable | Avoid unused local variables such as 'listConcatFieldNameAndOldData'. | 3 | 1239 |
| UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 3 | 1240 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 3 | 1268 |
| UseStringBufferForStringAppends | Prefer StringBuilder (non-synchronized) or StringBuffer (synchronized) over += for concatenating strings | 3 | 1299 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 1323 |
| UnusedLocalVariable | Avoid unused local variables such as 'listFieldsNames'. | 3 | 1323 |
| UnusedLocalVariable | Avoid unused local variables such as 'strConcatFieldNameAndData'. | 3 | 1327 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 1327 |
