Fork me on GitHub

Checkstyle Results

The following document contains the results of Checkstyle 8.19 with build-config/lutece_checks.xml ruleset. 

rss feed

Summary

Files
 Info
 Warnings
 Errors
21 0 0 142

Files

File
 I
 W
 E
fr/paris/lutece/plugins/adminsql/business/DataDAO.java 0 0 9
fr/paris/lutece/plugins/adminsql/business/DataHome.java 0 0 2
fr/paris/lutece/plugins/adminsql/business/Field.java 0 0 1
fr/paris/lutece/plugins/adminsql/business/FieldDAO.java 0 0 11
fr/paris/lutece/plugins/adminsql/business/FieldHome.java 0 0 2
fr/paris/lutece/plugins/adminsql/business/FieldValues.java 0 0 13
fr/paris/lutece/plugins/adminsql/business/IDataDAO.java 0 0 7
fr/paris/lutece/plugins/adminsql/business/IFieldDAO.java 0 0 3
fr/paris/lutece/plugins/adminsql/business/IStructureTableDAO.java 0 0 10
fr/paris/lutece/plugins/adminsql/business/ITableDAO.java 0 0 3
fr/paris/lutece/plugins/adminsql/business/StructureTable.java 0 0 1
fr/paris/lutece/plugins/adminsql/business/StructureTableDAO.java 0 0 11
fr/paris/lutece/plugins/adminsql/business/StructureTableHome.java 0 0 13
fr/paris/lutece/plugins/adminsql/business/Table.java 0 0 3
fr/paris/lutece/plugins/adminsql/business/TableDAO.java 0 0 12
fr/paris/lutece/plugins/adminsql/business/TableHome.java 0 0 4
fr/paris/lutece/plugins/adminsql/service/AdminSqlConnectionService.java 0 0 1
fr/paris/lutece/plugins/adminsql/util/AdminSqlUtil.java 0 0 3
fr/paris/lutece/plugins/adminsql/web/AdminSqlJspBean.java 0 0 33

Rules

Category Rule Violations Severity
coding HiddenField 3
 Error
ParameterAssignment 15
 Error
StringLiteralEquality 1
 Error
design HideUtilityClassConstructor 4
 Error
header Header
  • fileExtensions: "java"
  • headerFile: "/var/jenkins_home/jobs/admin-github-build/workspace/target/checkstyle-header.txt"
19
 Error
imports RedundantImport 2
 Error
UnusedImports 14
 Error
javadoc JavadocMethod 38
 Error
modifier ModifierOrder 5
 Error
RedundantModifier 2
 Error
naming LocalVariableName
  • format: "^[a-z][a-zA-Z0-9]*$"
1
 Error
MemberName
  • format: "^_[a-z](_?[a-zA-Z0-9])*$"
21
 Error
regexp RegexpSinglelineJava
  • format: "System\.exit"
4
 Error
RegexpSinglelineJava
  • format: "System\.out\.println"
4
 Error
whitespace ParenPad
  • option: "space"
7
 Error
WhitespaceAround
  • tokens: "ASSIGN,EQUAL"
6
 Error

Details

fr/paris/lutece/plugins/adminsql/business/DataDAO.java

Severity Category Rule Message Line
 Error
header Header Line does not match expected header line of ' * Copyright (c) 2002-2020, City of Paris'. 2
 Error
imports UnusedImports Unused import - java.util.StringTokenizer. 51
 Error
regexp RegexpSinglelineJava Line matches the illegal pattern 'SELECT *'. 71
 Error
regexp RegexpSinglelineJava Line matches the illegal pattern 'SELECT *'. 72
 Error
coding ParameterAssignment Assignment of parameter 'connectionService' is not allowed. 108
 Error
javadoc JavadocMethod Expected @throws tag for 'SQLException'. 253
 Error
javadoc JavadocMethod Missing a Javadoc comment. 361
 Error
javadoc JavadocMethod Missing a Javadoc comment. 376
 Error
javadoc JavadocMethod Missing a Javadoc comment. 391

fr/paris/lutece/plugins/adminsql/business/DataHome.java

Severity Category Rule Message Line
 Error
header Header Line does not match expected header line of ' * Copyright (c) 2002-2020, City of Paris'. 2
 Error
design HideUtilityClassConstructor Utility classes should not have a public or default constructor. 54

fr/paris/lutece/plugins/adminsql/business/Field.java

Severity Category Rule Message Line
 Error
header Header Line does not match expected header line of ' * Copyright (c) 2002-2020, City of Paris'. 2

fr/paris/lutece/plugins/adminsql/business/FieldDAO.java

Severity Category Rule Message Line
 Error
header Header Line does not match expected header line of ' * Copyright (c) 2002-2020, City of Paris'. 2
 Error
coding ParameterAssignment Assignment of parameter 'plugin' is not allowed. 423
 Error
coding ParameterAssignment Assignment of parameter 'plugin' is not allowed. 450
 Error
coding ParameterAssignment Assignment of parameter 'plugin' is not allowed. 502
 Error
coding ParameterAssignment Assignment of parameter 'plugin' is not allowed. 528
 Error
coding ParameterAssignment Assignment of parameter 'plugin' is not allowed. 554
 Error
coding ParameterAssignment Assignment of parameter 'plugin' is not allowed. 580
 Error
coding ParameterAssignment Assignment of parameter 'plugin' is not allowed. 606
 Error
coding ParameterAssignment Assignment of parameter 'plugin' is not allowed. 632
 Error
javadoc JavadocMethod Missing a Javadoc comment. 637
 Error
javadoc JavadocMethod Missing a Javadoc comment. 648

fr/paris/lutece/plugins/adminsql/business/FieldHome.java

Severity Category Rule Message Line
 Error
header Header Line does not match expected header line of ' * Copyright (c) 2002-2020, City of Paris'. 2
 Error
design HideUtilityClassConstructor Utility classes should not have a public or default constructor. 45

fr/paris/lutece/plugins/adminsql/business/FieldValues.java

Severity Category Rule Message Line
 Error
header Header Line does not match expected header line of ' * Copyright (c) 2002-2020, City of Paris'. 2
 Error
naming MemberName Name 'strFieldName' must match pattern '^_[a-z](_?[a-zA-Z0-9])*$'. 43
 Error
naming MemberName Name 'strOldValue' must match pattern '^_[a-z](_?[a-zA-Z0-9])*$'. 44
 Error
naming MemberName Name 'strNewValue' must match pattern '^_[a-z](_?[a-zA-Z0-9])*$'. 45
 Error
javadoc JavadocMethod Expected @return tag. 56
 Error
coding HiddenField 'strFieldName' hides a field. 65
 Error
javadoc JavadocMethod Expected @param tag for 'strFieldName'. 65
 Error
javadoc JavadocMethod Expected @return tag. 74
 Error
coding HiddenField 'strOldValue' hides a field. 83
 Error
javadoc JavadocMethod Expected @param tag for 'strOldValue'. 83
 Error
javadoc JavadocMethod Expected @return tag. 92
 Error
coding HiddenField 'strNewValue' hides a field. 101
 Error
javadoc JavadocMethod Expected @param tag for 'strNewValue'. 101

fr/paris/lutece/plugins/adminsql/business/IDataDAO.java

Severity Category Rule Message Line
 Error
header Header Line does not match expected header line of ' * Copyright (c) 2002-2020, City of Paris'. 2
 Error
imports RedundantImport Redundant import from the same package - fr.paris.lutece.plugins.adminsql.business.Field. 44
 Error
imports UnusedImports Unused import - fr.paris.lutece.portal.service.plugin.Plugin. 46
 Error
imports UnusedImports Unused import - fr.paris.lutece.util.ReferenceList. 47
 Error
imports UnusedImports Unused import - java.sql.SQLException. 49
 Error
modifier RedundantModifier Redundant 'public' modifier. 105
 Error
modifier RedundantModifier Redundant 'public' modifier. 123

fr/paris/lutece/plugins/adminsql/business/IFieldDAO.java

Severity Category Rule Message Line
 Error
header Header Line does not match expected header line of ' * Copyright (c) 2002-2020, City of Paris'. 2
 Error
imports RedundantImport Redundant import from the same package - fr.paris.lutece.plugins.adminsql.business.Field. 36
 Error
imports UnusedImports Unused import - java.sql.SQLException. 40

fr/paris/lutece/plugins/adminsql/business/IStructureTableDAO.java

Severity Category Rule Message Line
 Error
header Header Line does not match expected header line of ' * Copyright (c) 2002-2020, City of Paris'. 2
 Error
imports UnusedImports Unused import - fr.paris.lutece.portal.service.plugin.Plugin. 37
 Error
imports UnusedImports Unused import - java.util.Collection. 39
 Error
javadoc JavadocMethod Unused @param tag for 'plugin'. 50
 Error
javadoc JavadocMethod Expected @param tag for 'connectionService'. 53
 Error
javadoc JavadocMethod Expected @param tag for 'strTableName'. 53
 Error
javadoc JavadocMethod Missing a Javadoc comment. 55
 Error
javadoc JavadocMethod Missing a Javadoc comment. 57
 Error
javadoc JavadocMethod Missing a Javadoc comment. 59
 Error
javadoc JavadocMethod Missing a Javadoc comment. 61

fr/paris/lutece/plugins/adminsql/business/ITableDAO.java

Severity Category Rule Message Line
 Error
header Header Line does not match expected header line of ' * Copyright (c) 2002-2020, City of Paris'. 2
 Error
imports UnusedImports Unused import - java.sql.ResultSet. 38
 Error
imports UnusedImports Unused import - java.sql.SQLException. 39

fr/paris/lutece/plugins/adminsql/business/StructureTable.java

Severity Category Rule Message Line
 Error
header Header Line does not match expected header line of ' * Copyright (c) 2002-2020, City of Paris'. 2

fr/paris/lutece/plugins/adminsql/business/StructureTableDAO.java

Severity Category Rule Message Line
 Error
header Header Line does not match expected header line of ' * Copyright (c) 2002-2020, City of Paris'. 2
 Error
imports UnusedImports Unused import - fr.paris.lutece.portal.service.plugin.Plugin. 37
 Error
imports UnusedImports Unused import - fr.paris.lutece.util.sql.DAOUtil. 40
 Error
imports UnusedImports Unused import - java.util.Collection. 49
 Error
regexp RegexpSinglelineJava Line matches the illegal pattern 'SELECT *'. 68
 Error
javadoc JavadocMethod Missing a Javadoc comment. 72
 Error
javadoc JavadocMethod Missing a Javadoc comment. 88
 Error
javadoc JavadocMethod Missing a Javadoc comment. 104
 Error
javadoc JavadocMethod Missing a Javadoc comment. 166
 Error
javadoc JavadocMethod Missing a Javadoc comment. 182
 Error
javadoc JavadocMethod Missing a Javadoc comment. 198

fr/paris/lutece/plugins/adminsql/business/StructureTableHome.java

Severity Category Rule Message Line
 Error
header Header Line does not match expected header line of ' * Copyright (c) 2002-2020, City of Paris'. 2
 Error
imports UnusedImports Unused import - fr.paris.lutece.portal.service.plugin.Plugin. 37
 Error
imports UnusedImports Unused import - java.util.Collection. 40
 Error
javadoc JavadocMethod Missing a Javadoc comment. 60
 Error
modifier ModifierOrder 'public' modifier out of order with the JLS suggestions. 60
 Error
javadoc JavadocMethod Missing a Javadoc comment. 65
 Error
modifier ModifierOrder 'public' modifier out of order with the JLS suggestions. 65
 Error
javadoc JavadocMethod Missing a Javadoc comment. 70
 Error
modifier ModifierOrder 'public' modifier out of order with the JLS suggestions. 70
 Error
javadoc JavadocMethod Missing a Javadoc comment. 75
 Error
modifier ModifierOrder 'public' modifier out of order with the JLS suggestions. 75
 Error
javadoc JavadocMethod Missing a Javadoc comment. 80
 Error
modifier ModifierOrder 'public' modifier out of order with the JLS suggestions. 80

fr/paris/lutece/plugins/adminsql/business/Table.java

Severity Category Rule Message Line
 Error
header Header Line does not match expected header line of ' * Copyright (c) 2002-2020, City of Paris'. 2
 Error
javadoc JavadocMethod Missing a Javadoc comment. 69
 Error
javadoc JavadocMethod Missing a Javadoc comment. 74

fr/paris/lutece/plugins/adminsql/business/TableDAO.java

Severity Category Rule Message Line
 Error
header Header Line does not match expected header line of ' * Copyright (c) 2002-2020, City of Paris'. 2
 Error
regexp RegexpSinglelineJava Line matches the illegal pattern 'System\.out\.println'. 172
 Error
whitespace ParenPad '(' is not followed by whitespace. 172
 Error
whitespace ParenPad ')' is not preceded with whitespace. 174
 Error
coding ParameterAssignment Assignment of parameter 'plugin' is not allowed. 356
 Error
coding ParameterAssignment Assignment of parameter 'plugin' is not allowed. 382
 Error
coding ParameterAssignment Assignment of parameter 'plugin' is not allowed. 408
 Error
coding ParameterAssignment Assignment of parameter 'plugin' is not allowed. 434
 Error
coding ParameterAssignment Assignment of parameter 'plugin' is not allowed. 460
 Error
coding ParameterAssignment Assignment of parameter 'plugin' is not allowed. 486
 Error
javadoc JavadocMethod Missing a Javadoc comment. 491
 Error
javadoc JavadocMethod Missing a Javadoc comment. 503

fr/paris/lutece/plugins/adminsql/business/TableHome.java

Severity Category Rule Message Line
 Error
header Header Line does not match expected header line of ' * Copyright (c) 2002-2020, City of Paris'. 2
 Error
design HideUtilityClassConstructor Utility classes should not have a public or default constructor. 46
 Error
javadoc JavadocMethod Unused Javadoc tag. 89
 Error
javadoc JavadocMethod Expected @param tag for 'strTableNameToModify'. 111

fr/paris/lutece/plugins/adminsql/service/AdminSqlConnectionService.java

Severity Category Rule Message Line
 Error
header Header Line does not match expected header line of ' * Copyright (c) 2002-2020, City of Paris'. 2

fr/paris/lutece/plugins/adminsql/util/AdminSqlUtil.java

Severity Category Rule Message Line
 Error
header Header Line does not match expected header line of ' * Copyright (c) 2002-2020, City of Paris'. 2
 Error
design HideUtilityClassConstructor Utility classes should not have a public or default constructor. 48
 Error
javadoc JavadocMethod Missing a Javadoc comment. 50

fr/paris/lutece/plugins/adminsql/web/AdminSqlJspBean.java

Severity Category Rule Message Line
 Error
header Header Line does not match expected header line of ' * Copyright (c) 2002-2020, City of Paris'. 2
 Error
naming MemberName Name 'TEMPLATE_MANAGE_POOL_SQL' must match pattern '^_[a-z](_?[a-zA-Z0-9])*$'. 186
 Error
naming MemberName Name 'TEMPLATE_MANAGE_TABLE_SQL' must match pattern '^_[a-z](_?[a-zA-Z0-9])*$'. 187
 Error
naming MemberName Name 'TEMPLATE_MANAGE_DATA_SQL' must match pattern '^_[a-z](_?[a-zA-Z0-9])*$'. 188
 Error
naming MemberName Name 'TEMPLATE_CREATE_DATA' must match pattern '^_[a-z](_?[a-zA-Z0-9])*$'. 189
 Error
naming MemberName Name 'TEMPLATE_MANAGE_STRUCTURE_SQL' must match pattern '^_[a-z](_?[a-zA-Z0-9])*$'. 190
 Error
naming MemberName Name 'TEMPLATE_MODIFY_DATA' must match pattern '^_[a-z](_?[a-zA-Z0-9])*$'. 191
 Error
naming MemberName Name 'TEMPLATE_MODIFY_STRUCTURE' must match pattern '^_[a-z](_?[a-zA-Z0-9])*$'. 192
 Error
naming MemberName Name 'TEMPLATE_CREATE_STRUCTURE' must match pattern '^_[a-z](_?[a-zA-Z0-9])*$'. 193
 Error
naming MemberName Name 'TEMPLATE_CREATE_TABLE' must match pattern '^_[a-z](_?[a-zA-Z0-9])*$'. 194
 Error
naming MemberName Name 'TEMPLATE_MODIFY_TABLE_NAME' must match pattern '^_[a-z](_?[a-zA-Z0-9])*$'. 195
 Error
naming MemberName Name 'TEMPLATE_CHOOSE_FONCTIONNALITIES_LIST' must match pattern '^_[a-z](_?[a-zA-Z0-9])*$'. 196
 Error
naming MemberName Name 'TEMPLATE_USER_REQUEST' must match pattern '^_[a-z](_?[a-zA-Z0-9])*$'. 197
 Error
naming MemberName Name 'TEMPLATE_RESULT_OF_USER_REQUEST' must match pattern '^_[a-z](_?[a-zA-Z0-9])*$'. 198
 Error
naming MemberName Name 'TEMPLATE_EXPORT_DATABASE' must match pattern '^_[a-z](_?[a-zA-Z0-9])*$'. 199
 Error
naming MemberName Name 'TEMPLATE_SQL_ERROR_PAGE' must match pattern '^_[a-z](_?[a-zA-Z0-9])*$'. 200
 Error
naming MemberName Name 'TEMPLATE_PARAMETER_TO_EXPORT_DATABASE' must match pattern '^_[a-z](_?[a-zA-Z0-9])*$'. 201
 Error
naming MemberName Name 'TEMPLATE_DUMP_DATABASE' must match pattern '^_[a-z](_?[a-zA-Z0-9])*$'. 202
 Error
naming MemberName Name 'TEMPLATE_USER_REQUEST_ERROR' must match pattern '^_[a-z](_?[a-zA-Z0-9])*$'. 203
 Error
javadoc JavadocMethod Missing a Javadoc comment. 373
 Error
naming LocalVariableName Name 'DumpCommandslist' must match pattern '^[a-z][a-zA-Z0-9]*$'. 416
 Error
coding StringLiteralEquality Literal Strings should be compared using equals(), not '!='. 498
 Error
whitespace WhitespaceAround '=' is not followed by whitespace. 1139
 Error
whitespace WhitespaceAround '=' is not preceded with whitespace. 1139
 Error
whitespace WhitespaceAround '=' is not followed by whitespace. 1140
 Error
whitespace WhitespaceAround '=' is not preceded with whitespace. 1140
 Error
whitespace ParenPad '(' is not followed by whitespace. 1151
 Error
whitespace ParenPad ')' is not preceded with whitespace. 1151
 Error
whitespace ParenPad '(' is not followed by whitespace. 1152
 Error
whitespace ParenPad ')' is not preceded with whitespace. 1152
 Error
whitespace WhitespaceAround '=' is not followed by whitespace. 1153
 Error
whitespace WhitespaceAround '=' is not preceded with whitespace. 1153
 Error
whitespace ParenPad ')' is not preceded with whitespace. 1154