Fork me on GitHub

PMD Results

The following document contains the results of PMD 6.13.0.

Violations By Priority

Priority 1

fr/paris/lutece/plugins/appointment/log/LogUtilities.java

Rule Violation Line
ClassNamingConventions The utility class name 'LogUtilities' doesn't match '[A-Z][a-zA-Z0-9]+(Utils?|Helper|Home|Service)' 4267

fr/paris/lutece/plugins/appointment/service/AppointmentExecutorService.java

Rule Violation Line
FieldNamingConventions The final field name '_executorService' doesn't match '[a-z][a-zA-Z0-9]*' 51

fr/paris/lutece/plugins/appointment/service/AppointmentUtilities.java

Rule Violation Line
ClassNamingConventions The utility class name 'AppointmentUtilities' doesn't match '[A-Z][a-zA-Z0-9]+(Utils?|Helper|Home|Service)' 1011322
FieldNamingConventions The constant name '_secheduledExecutor' doesn't match '[A-Z][A-Z_0-9]*' 123

fr/paris/lutece/plugins/appointment/service/CalendarBuilder.java

Rule Violation Line
ClassWithOnlyPrivateConstructorsShouldBeFinal A class which only has private constructors should be final 51428

fr/paris/lutece/plugins/appointment/service/CommentService.java

Rule Violation Line
ClassWithOnlyPrivateConstructorsShouldBeFinal A class which only has private constructors should be final 60264

fr/paris/lutece/plugins/appointment/service/SlotSafeService.java

Rule Violation Line
FieldNamingConventions The constant name '_listSlot' doesn't match '[A-Z][A-Z_0-9]*' 89
FieldNamingConventions The constant name '_lockFormId' doesn't match '[A-Z][A-Z_0-9]*' 90

fr/paris/lutece/plugins/appointment/service/Utilities.java

Rule Violation Line
ClassNamingConventions The utility class name 'Utilities' doesn't match '[A-Z][a-zA-Z0-9]+(Utils?|Helper|Home|Service)' 48128

fr/paris/lutece/plugins/appointment/service/addon/AppointmentAddOnManager.java

Rule Violation Line
ClassNamingConventions The utility class name 'AppointmentAddOnManager' doesn't match '[A-Z][a-zA-Z0-9]+(Utils?|Helper|Home|Service)' 4777

fr/paris/lutece/plugins/appointment/service/export/ExcelAppointmentGenerator.java

Rule Violation Line
FieldNamingConventions The final field name '_fileName' doesn't match '[a-z][a-zA-Z0-9]*' 60
FieldNamingConventions The final field name '_fileDescription' doesn't match '[a-z][a-zA-Z0-9]*' 61
FieldNamingConventions The final field name '_defaultColumnList' doesn't match '[a-z][a-zA-Z0-9]*' 62
FieldNamingConventions The final field name '_locale' doesn't match '[a-z][a-zA-Z0-9]*' 63
FieldNamingConventions The final field name '_listAppointmentsDTO' doesn't match '[a-z][a-zA-Z0-9]*' 64
FieldNamingConventions The final field name '_entryList' doesn't match '[a-z][a-zA-Z0-9]*' 65

fr/paris/lutece/plugins/appointment/service/listeners/AppointmentListenerManager.java

Rule Violation Line
ClassNamingConventions The utility class name 'AppointmentListenerManager' doesn't match '[A-Z][a-zA-Z0-9]+(Utils?|Helper|Home|Service)' 51174

fr/paris/lutece/plugins/appointment/service/listeners/FormListenerManager.java

Rule Violation Line
ClassNamingConventions The utility class name 'FormListenerManager' doesn't match '[A-Z][a-zA-Z0-9]+(Utils?|Helper|Home|Service)' 3998

fr/paris/lutece/plugins/appointment/service/listeners/SlotListenerManager.java

Rule Violation Line
ClassNamingConventions The utility class name 'SlotListenerManager' doesn't match '[A-Z][a-zA-Z0-9]+(Utils?|Helper|Home|Service)' 48126

fr/paris/lutece/plugins/appointment/service/listeners/WeekDefinitionManagerListener.java

Rule Violation Line
ClassNamingConventions The utility class name 'WeekDefinitionManagerListener' doesn't match '[A-Z][a-zA-Z0-9]+(Utils?|Helper|Home|Service)' 42103

fr/paris/lutece/plugins/appointment/web/AbstractAppointmentFormAndSlotJspBean.java

Rule Violation Line
FieldNamingConventions The constant name '_captchaSecurityService' doesn't match '[A-Z][A-Z_0-9]*' 113

fr/paris/lutece/plugins/appointment/web/AppointmentJspBean.java

Rule Violation Line
FieldNamingConventions The field name 'listFormErrors' doesn't match '_[a-z][a-zA-Z0-9]*' 326

fr/paris/lutece/plugins/appointment/web/file/AppointmentFormIconService.java

Rule Violation Line
ClassWithOnlyPrivateConstructorsShouldBeFinal A class which only has private constructors should be final 1496

Priority 2

fr/paris/lutece/plugins/appointment/business/appointment/AppointmentDAO.java

Rule Violation Line
AvoidReassigningParameters Avoid reassigning parameters such as 'nIndex' 746
AvoidReassigningParameters Avoid reassigning parameters such as 'nIndex' 746
AvoidReassigningParameters Avoid reassigning parameters such as 'nIndex' 746
AvoidReassigningParameters Avoid reassigning parameters such as 'nIndex' 746
AvoidReassigningParameters Avoid reassigning parameters such as 'nIndex' 746
AvoidReassigningParameters Avoid reassigning parameters such as 'nIndex' 746
AvoidReassigningParameters Avoid reassigning parameters such as 'nIndex' 746
AvoidReassigningParameters Avoid reassigning parameters such as 'nIndex' 746
AvoidReassigningParameters Avoid reassigning parameters such as 'nIndex' 746
AvoidReassigningParameters Avoid reassigning parameters such as 'nIndex' 769
AvoidReassigningParameters Avoid reassigning parameters such as 'nIndex' 769
AvoidReassigningParameters Avoid reassigning parameters such as 'nIndex' 769
AvoidReassigningParameters Avoid reassigning parameters such as 'nIndex' 769
AvoidReassigningParameters Avoid reassigning parameters such as 'nIndex' 769

fr/paris/lutece/plugins/appointment/service/FormService.java

Rule Violation Line
AvoidReassigningParameters Avoid reassigning parameters such as 'reservationRule' 411

fr/paris/lutece/plugins/appointment/web/AppointmentApp.java

Rule Violation Line
AvoidReassigningParameters Avoid reassigning parameters such as 'model' 1436
AvoidReassigningParameters Avoid reassigning parameters such as 'model' 1481

fr/paris/lutece/plugins/appointment/web/SpecificWeekJspBean.java

Rule Violation Line
GuardLogStatement Logger calls should be surrounded by log level guards. 450

fr/paris/lutece/plugins/appointment/web/TypicalWeekJspBean.java

Rule Violation Line
GuardLogStatement Logger calls should be surrounded by log level guards. 661
AvoidReassigningParameters Avoid reassigning parameters such as 'nMaxCapacity' 902
AvoidReassigningParameters Avoid reassigning parameters such as 'slot' 975
AvoidReassigningParameters Avoid reassigning parameters such as 'nNewNbMaxCapacity' 975

Priority 3

fr/paris/lutece/plugins/appointment/business/AbstractDateConversion.java

Rule Violation Line
CommentRequired Header comments are required 39159
ConfusingTernary Avoid if (x != y) ..; else ..; 96103
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 102
ConfusingTernary Avoid if (x != y) ..; else ..; 150157
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 156

fr/paris/lutece/plugins/appointment/business/appointment/Appointment.java

Rule Violation Line
CommentRequired Public method and constructor comments are required 342352
CommentRequired Public method and constructor comments are required 354368
ConfusingTernary Avoid if (x != y) ..; else ..; 456463
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 462

fr/paris/lutece/plugins/appointment/business/appointment/AppointmentDAO.java

Rule Violation Line
TooManyMethods This class has too many methods, consider refactoring it. 62830
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 374
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 444
CyclomaticComplexity The method 'addFilterParametersToDAOUtil(AppointmentFilterDTO, DAOUtil)' has a cyclomatic complexity of 13. 497561
NPathComplexity The method 'addFilterParametersToDAOUtil(AppointmentFilterDTO, DAOUtil)' has an NPath complexity of 2304 497561
UseLocaleWithCaseConversions When doing a String.toLowerCase()/toUpperCase() call, use a Locale 506
UseLocaleWithCaseConversions When doing a String.toLowerCase()/toUpperCase() call, use a Locale 510
UseLocaleWithCaseConversions When doing a String.toLowerCase()/toUpperCase() call, use a Locale 514
UseLocaleWithCaseConversions When doing a String.toLowerCase()/toUpperCase() call, use a Locale 518
NPathComplexity The method 'getSqlQueryFromFilter(AppointmentFilterDTO, String)' has an NPath complexity of 1024 570629
CyclomaticComplexity The method 'getSqlQueryFromFilter(AppointmentFilterDTO, String)' has a cyclomatic complexity of 11. 570629
CyclomaticComplexity The method 'getOrderQuery(AppointmentFilterDTO, String)' has a cyclomatic complexity of 11. 631680
MissingBreakInSwitch A switch statement does not contain a break 642670

fr/paris/lutece/plugins/appointment/business/appointment/AppointmentHome.java

Rule Violation Line
TooManyMethods This class has too many methods, consider refactoring it. 51243
CommentRequired Public method and constructor comments are required 214217

fr/paris/lutece/plugins/appointment/business/appointment/AppointmentSlot.java

Rule Violation Line
CommentRequired Header comments are required 38112

fr/paris/lutece/plugins/appointment/business/appointment/IAppointmentDAO.java

Rule Violation Line
TooManyMethods This class has too many methods, consider refactoring it. 48209

fr/paris/lutece/plugins/appointment/business/comment/CommentDAO.java

Rule Violation Line
ConfusingTernary Avoid if (x != y) ..; else ..; 7380
ConfusingTernary Avoid if (x != y) ..; else ..; 8289

fr/paris/lutece/plugins/appointment/business/comment/ICommentNotificationConfigDAO.java

Rule Violation Line
CommentRequired Header comments are required 4073

fr/paris/lutece/plugins/appointment/business/form/Form.java

Rule Violation Line
TooManyFields Too many fields 58541
ConfusingTernary Avoid if (x != y) ..; else ..; 306313
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 312
ConfusingTernary Avoid if (x != y) ..; else ..; 360367
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 366
CommentRequired Public method and constructor comments are required 521524
CommentRequired Public method and constructor comments are required 526529
CommentRequired Public method and constructor comments are required 531534
CommentRequired Public method and constructor comments are required 536539

fr/paris/lutece/plugins/appointment/business/form/FormDAO.java

Rule Violation Line
TooManyMethods This class has too many methods, consider refactoring it. 50276

fr/paris/lutece/plugins/appointment/business/localization/LocalizationDAO.java

Rule Violation Line
CommentRequired Header comments are required 41195
ConfusingTernary Avoid if (x != y) ..; else ..; 171178
ConfusingTernary Avoid if (x != y) ..; else ..; 179186

fr/paris/lutece/plugins/appointment/business/message/FormMessage.java

Rule Violation Line
TooManyFields Too many fields 44543

fr/paris/lutece/plugins/appointment/business/planning/ClosingDay.java

Rule Violation Line
ConfusingTernary Avoid if (x != y) ..; else ..; 134141
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 140

fr/paris/lutece/plugins/appointment/business/planning/ClosingDayDAO.java

Rule Violation Line
TooManyMethods This class has too many methods, consider refactoring it. 52237

fr/paris/lutece/plugins/appointment/business/planning/WeekDefinitionDAO.java

Rule Violation Line
TooManyMethods This class has too many methods, consider refactoring it. 52245

fr/paris/lutece/plugins/appointment/business/portlet/AppointmentFormListPortlet.java

Rule Violation Line
CallSuperInConstructor It is a good practice to call super() in a constructor 5457

fr/paris/lutece/plugins/appointment/business/portlet/AppointmentFormPortlet.java

Rule Violation Line
CallSuperInConstructor It is a good practice to call super() in a constructor 5659

fr/paris/lutece/plugins/appointment/business/portlet/AppointmentFormPortletDAO.java

Rule Violation Line
ShortVariable Avoid variables with short names like p 68
ShortVariable Avoid variables with short names like p 105

fr/paris/lutece/plugins/appointment/business/portlet/AppointmentPortlet.java

Rule Violation Line
CallSuperInConstructor It is a good practice to call super() in a constructor 5861

fr/paris/lutece/plugins/appointment/business/rule/FormRuleDAO.java

Rule Violation Line
AvoidSynchronizedAtMethodLevel Use block level rather than method level synchronization 5969

fr/paris/lutece/plugins/appointment/business/slot/ISlotDAO.java

Rule Violation Line
TooManyMethods This class has too many methods, consider refactoring it. 49229
UnnecessaryModifier Unnecessary modifier 'public' on method 'deleteByIdForm': the method is declared in an interface type 88

fr/paris/lutece/plugins/appointment/business/slot/Period.java

Rule Violation Line
DataClass The class 'Period' is suspected to be a Data Class (WOC=0.000%, NOPA=0, NOAM=4, WMC=5) 39105
CommentRequired Header comments are required 39105
CommentRequired Public method and constructor comments are required 5761

fr/paris/lutece/plugins/appointment/business/slot/Slot.java

Rule Violation Line
AvoidLiteralsInIfCondition Avoid using Literals in Conditional Statements 492

fr/paris/lutece/plugins/appointment/business/slot/SlotDAO.java

Rule Violation Line
TooManyMethods This class has too many methods, consider refactoring it. 53375

fr/paris/lutece/plugins/appointment/business/slot/SlotHome.java

Rule Violation Line
TooManyMethods This class has too many methods, consider refactoring it. 52280

fr/paris/lutece/plugins/appointment/business/user/UserDAO.java

Rule Violation Line
UseLocaleWithCaseConversions When doing a String.toLowerCase()/toUpperCase() call, use a Locale 148
UseLocaleWithCaseConversions When doing a String.toLowerCase()/toUpperCase() call, use a Locale 149
UseLocaleWithCaseConversions When doing a String.toLowerCase()/toUpperCase() call, use a Locale 150

fr/paris/lutece/plugins/appointment/exception/AppointmentSavedException.java

Rule Violation Line
CommentRequired Header comments are required 3658
CommentRequired Public method and constructor comments are required 5357
ShortVariable Avoid variables with short names like e 53

fr/paris/lutece/plugins/appointment/exception/SlotEditTaskExpiredTimeException.java

Rule Violation Line
CommentRequired Header comments are required 3658
ShortVariable Avoid variables with short names like e 53
CommentRequired Public method and constructor comments are required 5357

fr/paris/lutece/plugins/appointment/exception/SlotFullException.java

Rule Violation Line
CommentRequired Header comments are required 3658
CommentRequired Public method and constructor comments are required 5357
ShortVariable Avoid variables with short names like e 53

fr/paris/lutece/plugins/appointment/log/LogUtilities.java

Rule Violation Line
CommentRequired Header comments are required 4267
ShortVariable Avoid variables with short names like BY 46
CommentRequired Public method and constructor comments are required 5665

fr/paris/lutece/plugins/appointment/service/AppointmentExecutorService.java

Rule Violation Line
CommentRequired Enum comments are required 47113
DoNotUseThreads To be compliant to J2EE, a webapp should not use any thread. 66
DoNotUseThreads To be compliant to J2EE, a webapp should not use any thread. 83

fr/paris/lutece/plugins/appointment/service/AppointmentResourceIdService.java

Rule Violation Line
DataClass The class 'AppointmentResourceIdService' is suspected to be a Data Class (WOC=0.000%, NOPA=16, NOAM=0, WMC=1) 57237
CallSuperInConstructor It is a good practice to call super() in a constructor 112115
NcssCount The method 'register()' has a NCSS line count of 65. 121202

fr/paris/lutece/plugins/appointment/service/AppointmentService.java

Rule Violation Line
GodClass Possible God Class (WMC=58, ATFD=104, TCC=0.000%) 75618
TooManyMethods This class has too many methods, consider refactoring it. 76618
CommentDefaultAccessModifier To avoid mistakes add a comment at the beginning of the buildAndCreateAppointment method if you want a default access modifier 177221
DefaultPackage Use explicit scoping instead of the default package private level 177221
UseStringBufferForStringAppends Prefer StringBuilder (non-synchronized) or StringBuffer (synchronized) over += for concatenating strings 210
ConfusingTernary Avoid if (x != y) ..; else ..; 342355
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 408
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 424
CyclomaticComplexity The method 'updateAppointment(Appointment)' has a cyclomatic complexity of 11. 515561
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 554
CommentRequired Public method and constructor comments are required 591616
AvoidLiteralsInIfCondition Avoid using Literals in Conditional Statements 599

fr/paris/lutece/plugins/appointment/service/AppointmentShutdownService.java

Rule Violation Line
CommentRequired Header comments are required 3963

fr/paris/lutece/plugins/appointment/service/AppointmentUtilities.java

Rule Violation Line
ExcessiveImports A high number of imports can indicate a high degree of coupling within an object. 341322
GodClass Possible God Class (WMC=147, ATFD=239, TCC=0.891%) 1011322
ExcessiveClassLength Avoid really long classes. 1011322
CyclomaticComplexity The class 'AppointmentUtilities' has a total cyclomatic complexity of 147 (highest 12). 1011322
TooManyMethods This class has too many methods, consider refactoring it. 1021322
DoNotUseThreads To be compliant to J2EE, a webapp should not use any thread. 124
AvoidDeeplyNestedIfStmts Deeply nested if..then statements are hard to read 221234
AvoidDeeplyNestedIfStmts Deeply nested if..then statements are hard to read 275279
AvoidDeeplyNestedIfStmts Deeply nested if..then statements are hard to read 313316
AvoidDeeplyNestedIfStmts Deeply nested if..then statements are hard to read 346349
CyclomaticComplexity The method 'checkNbMaxAppointmentsOnAGivenPeriod(AppointmentDTO, String, AppointmentFormDTO)' has a cyclomatic complexity of 11. 369430
AvoidDeeplyNestedIfStmts Deeply nested if..then statements are hard to read 414418
AvoidDeeplyNestedIfStmts Deeply nested if..then statements are hard to read 421425
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 504
AvoidCatchingNPE Avoid catching NullPointerException; consider removing the cause of the NPE. 504
UseObjectForClearerAPI Rather than using a lot of String arguments, consider using a container object for those values. 547
CommentRequired Public method and constructor comments are required 594606
ControlStatementBraces This statement should have braces 659
CommentRequired Public method and constructor comments are required 664668
ShortVariable Avoid variables with short names like nI 725
EmptyIfStmt Avoid empty if statements 836838
EmptyIfStmt Avoid empty if statements 904906
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 924
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 925
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 926
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 927
ConfusingTernary Avoid if (x != y) ..; else ..; 955970
CommentRequired Public method and constructor comments are required 10551066
CommentRequired Public method and constructor comments are required 10681080
CyclomaticComplexity The method 'weekIsOpenInFO(AppointmentFormDTO, List, Locale)' has a cyclomatic complexity of 12. 11371179
AvoidCatchingNPE Avoid catching NullPointerException; consider removing the cause of the NPE. 1316
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 1316

fr/paris/lutece/plugins/appointment/service/CalendarBuilder.java

Rule Violation Line
CommentRequired Header comments are required 51428
ExcessiveMethodLength Avoid really long methods. 74218
NcssCount The method 'buildListSlot(int, Map, LocalDate, LocalDate)' has a NCSS line count of 78. 74218
CyclomaticComplexity The method 'buildListSlot(int, Map, LocalDate, LocalDate)' has a cyclomatic complexity of 19. 74218
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 112
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 124
ConfusingTernary Avoid if (x != y) ..; else ..; 131214
ConfusingTernary Avoid if (x != y) ..; else ..; 160171
NPathComplexity The method 'buildListSlot(int, Map, LocalDate, LocalDate, int, boolean)' has an NPath complexity of 699 237402
NcssCount The method 'buildListSlot(int, Map, LocalDate, LocalDate, int, boolean)' has a NCSS line count of 96. 237402
ExcessiveMethodLength Avoid really long methods. 237402
CyclomaticComplexity The method 'buildListSlot(int, Map, LocalDate, LocalDate, int, boolean)' has a cyclomatic complexity of 17. 237402
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 287
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 298
ConfusingTernary Avoid if (x != y) ..; else ..; 341352

fr/paris/lutece/plugins/appointment/service/ClosingDayService.java

Rule Violation Line
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 208
AvoidLiteralsInIfCondition Avoid using Literals in Conditional Statements 227

fr/paris/lutece/plugins/appointment/service/CommentService.java

Rule Violation Line
CommentRequired Header comments are required 60264
CommentRequired Public method and constructor comments are required 195231
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 244

fr/paris/lutece/plugins/appointment/service/EntryService.java

Rule Violation Line
ExcessiveImports A high number of imports can indicate a high degree of coupling within an object. 34752
GodClass Possible God Class (WMC=83, ATFD=177, TCC=0.000%) 76752
CyclomaticComplexity The class 'EntryService' has a total cyclomatic complexity of 83 (highest 16). 76752
CyclomaticComplexity The method 'moveDownEntryOrder(int, Entry)' has a cyclomatic complexity of 16. 139234
ForLoopCanBeForeach This for loop can be replaced by a foreach loop 166199
CyclomaticComplexity The method 'moveUpEntryOrder(int, Entry)' has a cyclomatic complexity of 13. 244318
ForLoopCanBeForeach This for loop can be replaced by a foreach loop 269299
CyclomaticComplexity The method 'getHtmlEntry(Map, int, StringBuilder, Locale, boolean, AppointmentDTO)' has a cyclomatic complexity of 13. 509571
LinguisticNaming Linguistics Antipattern - The getter 'getHtmlEntry' should not return void linguistically 509571
NPathComplexity The method 'getHtmlEntry(Map, int, StringBuilder, Locale, boolean, AppointmentDTO)' has an NPath complexity of 210 509571
CyclomaticComplexity The method 'getResponseEntry(HttpServletRequest, int, List, boolean, Locale, AppointmentDTO)' has a cyclomatic complexity of 11. 611683
AvoidReassigningLoopVariables Avoid reassigning the loop control variable 'field' 621
ConfusingTernary Avoid if (x != y) ..; else ..; 642656

fr/paris/lutece/plugins/appointment/service/FormMessageService.java

Rule Violation Line
FieldDeclarationsShouldBeAtStartOfClass Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. 61
FieldDeclarationsShouldBeAtStartOfClass Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. 63
FieldDeclarationsShouldBeAtStartOfClass Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. 64
FieldDeclarationsShouldBeAtStartOfClass Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. 65
FieldDeclarationsShouldBeAtStartOfClass Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. 66
FieldDeclarationsShouldBeAtStartOfClass Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. 67
FieldDeclarationsShouldBeAtStartOfClass Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. 68
FieldDeclarationsShouldBeAtStartOfClass Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. 69
FieldDeclarationsShouldBeAtStartOfClass Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. 70
FieldDeclarationsShouldBeAtStartOfClass Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. 71
FieldDeclarationsShouldBeAtStartOfClass Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. 72
FieldDeclarationsShouldBeAtStartOfClass Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. 73
FieldDeclarationsShouldBeAtStartOfClass Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. 74
FieldDeclarationsShouldBeAtStartOfClass Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. 75
FieldDeclarationsShouldBeAtStartOfClass Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. 76
FieldDeclarationsShouldBeAtStartOfClass Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. 77
FieldDeclarationsShouldBeAtStartOfClass Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. 78
FieldDeclarationsShouldBeAtStartOfClass Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. 79

fr/paris/lutece/plugins/appointment/service/FormService.java

Rule Violation Line
ExcessiveImports A high number of imports can indicate a high degree of coupling within an object. 34809
GodClass Possible God Class (WMC=72, ATFD=155, TCC=0.000%) 86809
TooManyMethods This class has too many methods, consider refactoring it. 87809
NcssCount The method 'copyForm(int, String)' has a NCSS line count of 88. 105226
ExcessiveMethodLength Avoid really long methods. 105226
ConfusingTernary Avoid if (x != y) ..; else ..; 258
ConfusingTernary Avoid if (x != y) ..; else ..; 259
CyclomaticComplexity The method 'fillAppointmentFormWithReservationRulePart(AppointmentFormDTO, ReservationRule)' has a cyclomatic complexity of 10. 468515
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 746

fr/paris/lutece/plugins/appointment/service/ReservationRuleService.java

Rule Violation Line
TooManyMethods This class has too many methods, consider refactoring it. 67426
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 154
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 367

fr/paris/lutece/plugins/appointment/service/SlotDaemon.java

Rule Violation Line
CommentRequired Header comments are required 3849

fr/paris/lutece/plugins/appointment/service/SlotSafeService.java

Rule Violation Line
ExcessiveImports A high number of imports can indicate a high degree of coupling within an object. 341171
ExcessiveClassLength Avoid really long classes. 861171
CyclomaticComplexity The class 'SlotSafeService' has a total cyclomatic complexity of 116 (highest 20). 861171
GodClass Possible God Class (WMC=116, ATFD=232, TCC=1.709%) 861171
CommentRequired Header comments are required 861171
TooManyMethods This class has too many methods, consider refactoring it. 871171
ConfusingTernary Avoid if (x != y) ..; else ..; 166175
ConfusingTernary Avoid if (x != y) ..; else ..; 208219
NPathComplexity The method 'saveAppointment(AppointmentDTO, HttpServletRequest)' has an NPath complexity of 216 336406
CyclomaticComplexity The method 'saveAppointment(AppointmentDTO, HttpServletRequest)' has a cyclomatic complexity of 16. 336406
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 338
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 339
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 340
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 342
ControlStatementBraces This statement should have braces 354
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 393
ConfusingTernary Avoid if (x != y) ..; else ..; 468
DefaultPackage Use explicit scoping instead of the default package private level 485526
CommentDefaultAccessModifier To avoid mistakes add a comment at the beginning of the updateRemaningPlacesWithAppointmentMovedDeletedOrCanceled method if you want a default access modifier 485526
DefaultPackage Use explicit scoping instead of the default package private level 537560
CommentDefaultAccessModifier To avoid mistakes add a comment at the beginning of the updateRemaningPlacesWithAppointmentReactivated method if you want a default access modifier 537560
ConfusingTernary Avoid if (x != y) ..; else ..; 582591
ConfusingTernary Avoid if (x != y) ..; else ..; 638657
CyclomaticComplexity The method 'updateSlotWithShift(Slot, LocalTime)' has a cyclomatic complexity of 11. 683824
NcssCount The method 'updateSlotWithShift(Slot, LocalTime)' has a NCSS line count of 65. 683824
ExcessiveMethodLength Avoid really long methods. 683824
ConfusingTernary Avoid if (x != y) ..; else ..; 727734
ConfusingTernary Avoid if (x != y) ..; else ..; 844852
ConfusingTernary Avoid if (x != y) ..; else ..; 894921
ShortVariable Avoid variables with short names like it 982
NPathComplexity The method 'saveSlots(AppointmentDTO, List, HttpServletRequest)' has an NPath complexity of 441 10051084
CyclomaticComplexity The method 'saveSlots(AppointmentDTO, List, HttpServletRequest)' has a cyclomatic complexity of 20. 10051084
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 1009
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 1010

fr/paris/lutece/plugins/appointment/service/SlotService.java

Rule Violation Line
TooManyMethods This class has too many methods, consider refactoring it. 62518
LooseCoupling Avoid using implementation types like 'HashMap'; use the interface instead 141
LooseCoupling Avoid using implementation types like 'HashMap'; use the interface instead 222
AvoidLiteralsInIfCondition Avoid using Literals in Conditional Statements 286

fr/paris/lutece/plugins/appointment/service/TimeSlotService.java

Rule Violation Line
TooManyMethods This class has too many methods, consider refactoring it. 64576
ConfusingTernary Avoid if (x != y) ..; else ..; 217224
ExcessiveMethodLength Avoid really long methods. 253376

fr/paris/lutece/plugins/appointment/service/Utilities.java

Rule Violation Line
NonThreadSafeSingleton Singleton is not thread safe 6669
DefaultPackage Use explicit scoping instead of the default package private level 7679
CommentDefaultAccessModifier To avoid mistakes add a comment at the beginning of the resetFormatter method if you want a default access modifier 7679
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 78

fr/paris/lutece/plugins/appointment/service/WeekDefinitionService.java

Rule Violation Line
GodClass Possible God Class (WMC=60, ATFD=45, TCC=0.000%) 63568
TooManyMethods This class has too many methods, consider refactoring it. 64568
LooseCoupling Avoid using implementation types like 'HashMap'; use the interface instead 301
CyclomaticComplexity The method 'assignWeekDefinition(int, WeekDefinition)' has a cyclomatic complexity of 11. 470534
UnusedFormalParameter Avoid unused method parameters such as 'nIdForm'. 536
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 559

fr/paris/lutece/plugins/appointment/service/WorkingDayService.java

Rule Violation Line
LooseCoupling Avoid using implementation types like 'HashSet'; use the interface instead 341

fr/paris/lutece/plugins/appointment/service/anonymization/FormIdAnonymizationService.java

Rule Violation Line
CommentRequired Header comments are required 715

fr/paris/lutece/plugins/appointment/service/entrytype/EntryTypeImage.java

Rule Violation Line
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 107

fr/paris/lutece/plugins/appointment/service/export/AppointmentExportService.java

Rule Violation Line
ExcessiveImports A high number of imports can indicate a high degree of coupling within an object. 34380
CommentRequired Header comments are required 81380
GodClass Possible God Class (WMC=51, ATFD=49, TCC=0.000%) 81380
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 141
UnnecessaryModifier Unnecessary modifier 'final' on method 'writeWorkbook': private methods cannot be overridden 151191
ShortVariable Avoid variables with short names like os 154
UnnecessaryModifier Unnecessary modifier 'final' on method 'createHeaderContent': private methods cannot be overridden 193209
UnnecessaryModifier Unnecessary modifier 'final' on method 'createLineContent': private methods cannot be overridden 211233
CyclomaticComplexity The method 'addDefaultColumnValues(AppointmentDTO, Form, List, List, StateService, Locale)' has a cyclomatic complexity of 16. 235300
NPathComplexity The method 'addDefaultColumnValues(AppointmentDTO, Form, List, List, StateService, Locale)' has an NPath complexity of 24576 235300
UnnecessaryModifier Unnecessary modifier 'final' on method 'addDefaultColumnValues': private methods cannot be overridden 235300
UnnecessaryModifier Unnecessary modifier 'final' on method 'getEntryValue': private methods cannot be overridden 327352
ShortVariable Avoid variables with short names like e 327
ShortVariable Avoid variables with short names like f 338
InefficientStringBuffering Avoid concatenating nonliterals in a StringBuffer/StringBuilder constructor or append(). 347
CommentRequired Public method and constructor comments are required 354362
CommentRequired Public method and constructor comments are required 364379

fr/paris/lutece/plugins/appointment/service/export/ExcelAppointmentGenerator.java

Rule Violation Line
CommentRequired Header comments are required 51111
CommentRequired Public method and constructor comments are required 6777
SimpleDateFormatNeedsLocale When instantiating a SimpleDateFormat object, specify a Locale 70

fr/paris/lutece/plugins/appointment/service/listeners/AppointmentSessionListener.java

Rule Violation Line
ShortVariable Avoid variables with short names like se 51
ShortVariable Avoid variables with short names like se 60

fr/paris/lutece/plugins/appointment/service/listeners/FormListenerManager.java

Rule Violation Line
CommentRequired Header comments are required 3998

fr/paris/lutece/plugins/appointment/service/listeners/WeekDefinitionManagerListener.java

Rule Violation Line
CommentRequired Header comments are required 42103

fr/paris/lutece/plugins/appointment/service/lock/SlotEditTask.java

Rule Violation Line
DataClass The class 'SlotEditTask' is suspected to be a Data Class (WOC=0.000%, NOPA=0, NOAM=4, WMC=5) 47113
CommentRequired Public method and constructor comments are required 6064

fr/paris/lutece/plugins/appointment/service/lock/TimerForLockOnSlot.java

Rule Violation Line
CommentRequired Header comments are required 3849
UnnecessaryConstructor Avoid unnecessary constructors - the compiler will generate these for you 4447

fr/paris/lutece/plugins/appointment/web/AbstractAppointmentFormAndSlotJspBean.java

Rule Violation Line
CommentRequired Header comments are required 67364

fr/paris/lutece/plugins/appointment/web/AppointmentAnnualCalendarJspBean.java

Rule Violation Line
ExcessiveImports A high number of imports can indicate a high degree of coupling within an object. 34512
UnnecessaryAnnotationValueElement Avoid the use of value in annotations when its the only element 147
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 192
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 193
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 194
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 254
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 255
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 256
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 313
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 315
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 316
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 317
AvoidReassigningLoopVariables Avoid reassigning the loop control variable 'slotImpacted' 402
AppendCharacterWithChar Avoid appending characters as strings in StringBuffer.append. 438

fr/paris/lutece/plugins/appointment/web/AppointmentApp.java

Rule Violation Line
ExcessiveImports A high number of imports can indicate a high degree of coupling within an object. 341840
ExcessiveClassLength Avoid really long classes. 1321840
SingularField Perhaps '_strNbPlacesToTakeLength' could be replaced by a local variable. 297
NPathComplexity The method 'getViewAppointmentCalendar(HttpServletRequest)' has an NPath complexity of 116161920 311591
CyclomaticComplexity The method 'getViewAppointmentCalendar(HttpServletRequest)' has a cyclomatic complexity of 38. 311591
NcssCount The method 'getViewAppointmentCalendar(HttpServletRequest)' has a NCSS line count of 158. 311591
ExcessiveMethodLength Avoid really long methods. 311591
AvoidSynchronizedAtMethodLevel Use block level rather than method level synchronization 311591
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 330
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 411
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 413
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 416417
ConfusingTernary Avoid if (x != y) ..; else ..; 464475
CyclomaticComplexity The method 'getViewAppointmentForm(HttpServletRequest)' has a cyclomatic complexity of 38. 602829
ExcessiveMethodLength Avoid really long methods. 602829
NPathComplexity The method 'getViewAppointmentForm(HttpServletRequest)' has an NPath complexity of 76800000 602829
AvoidSynchronizedAtMethodLevel Use block level rather than method level synchronization 602829
NcssCount The method 'getViewAppointmentForm(HttpServletRequest)' has a NCSS line count of 124. 602829
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 604
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 605
LinguisticNaming Linguistics Antipattern - The variable 'isModification' indicates linguistically it is a boolean, but it is 'String' 653
ConfusingTernary Avoid if (x != y) ..; else ..; 656689
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 665
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 700
ConfusingTernary Avoid if (x != y) ..; else ..; 708770
AvoidReassigningLoopVariables Avoid reassigning the loop control variable 'slot' 721
AvoidReassigningLoopVariables Avoid reassigning the loop control variable 'slot' 725
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 732
ConfusingTernary Avoid if (x != y) ..; else ..; 796804
ExcessiveMethodLength Avoid really long methods. 842945
CyclomaticComplexity The method 'doValidateForm(HttpServletRequest)' has a cyclomatic complexity of 16. 842945
AvoidSynchronizedAtMethodLevel Use block level rather than method level synchronization 842945
NPathComplexity The method 'doValidateForm(HttpServletRequest)' has an NPath complexity of 3456 842945
NcssCount The method 'doValidateForm(HttpServletRequest)' has a NCSS line count of 69. 842945
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 845
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 850
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 851
ShortVariable Avoid variables with short names like lf 894
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 931
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 936
AvoidSynchronizedAtMethodLevel Use block level rather than method level synchronization 9571008
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 961
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 965
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 973
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 974
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 977
ShortVariable Avoid variables with short names like t 1003
AvoidSynchronizedAtMethodLevel Use block level rather than method level synchronization 10201099
CyclomaticComplexity The method 'doMakeAppointment(HttpServletRequest)' has a cyclomatic complexity of 13. 10201099
NPathComplexity The method 'doMakeAppointment(HttpServletRequest)' has an NPath complexity of 512 10201099
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 1026
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 1027
AvoidSynchronizedAtMethodLevel Use block level rather than method level synchronization 11091141
AvoidLiteralsInIfCondition Avoid using Literals in Conditional Statements 1120
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 1129
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 1138
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 1139
CyclomaticComplexity The method 'getViewChangeDateAppointment(HttpServletRequest)' has a cyclomatic complexity of 16. 11541242
AvoidSynchronizedAtMethodLevel Use block level rather than method level synchronization 11541242
NPathComplexity The method 'getViewChangeDateAppointment(HttpServletRequest)' has an NPath complexity of 2160 11541242
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 1165
AvoidReassigningLoopVariables Avoid reassigning the loop control variable 'slot' 1192
AvoidReassigningLoopVariables Avoid reassigning the loop control variable 'slot' 1198
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 1238
AvoidSynchronizedAtMethodLevel Use block level rather than method level synchronization 12521263
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 1255
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 1256
AvoidSynchronizedAtMethodLevel Use block level rather than method level synchronization 12721319
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 1280
ConfusingTernary Avoid if (x != y) ..; else ..; 12821313
AvoidSynchronizedAtMethodLevel Use block level rather than method level synchronization 13281374
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 1348
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 1359
AvoidSynchronizedAtMethodLevel Use block level rather than method level synchronization 13841400
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 1390
AvoidSynchronizedAtMethodLevel Use block level rather than method level synchronization 14121423
AvoidSynchronizedAtMethodLevel Use block level rather than method level synchronization 15261565
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 1546
CyclomaticComplexity The method 'doProcessWorkflowAction(HttpServletRequest)' has a cyclomatic complexity of 15. 15751661
AvoidSynchronizedAtMethodLevel Use block level rather than method level synchronization 15751661
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 1582
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 1653
CyclomaticComplexity The method 'checkMyLuteceAuthentication(AppointmentFormDTO, HttpServletRequest)' has a cyclomatic complexity of 14. 17731812

fr/paris/lutece/plugins/appointment/web/AppointmentCategoryJspBean.java

Rule Violation Line
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 124

fr/paris/lutece/plugins/appointment/web/AppointmentFormDashboardComponent.java

Rule Violation Line
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 98

fr/paris/lutece/plugins/appointment/web/AppointmentFormEntryJspBean.java

Rule Violation Line
ExcessiveImports A high number of imports can indicate a high degree of coupling within an object. 34774
TooManyMethods This class has too many methods, consider refactoring it. 88774
ImmutableField Private field '_entryService' could be made final; it is only initialized in the declaration or constructor. 151
UnnecessaryAnnotationValueElement Avoid the use of value in annotations when its the only element 187
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 217
CyclomaticComplexity The method 'doCreateEntry(HttpServletRequest)' has a cyclomatic complexity of 13. 240292
NPathComplexity The method 'doCreateEntry(HttpServletRequest)' has an NPath complexity of 234 240292
AvoidReassigningLoopVariables Avoid reassigning the loop control variable 'field' 317
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 322
CyclomaticComplexity The method 'doModifyEntry(HttpServletRequest)' has a cyclomatic complexity of 11. 351405
AvoidDeeplyNestedIfStmts Deeply nested if..then statements are hard to read 365368
AvoidDeeplyNestedIfStmts Deeply nested if..then statements are hard to read 376385
ConfusingTernary Avoid if (x != y) ..; else ..; 376385
ConfusingTernary Avoid if (x != y) ..; else ..; 394401
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 450
CyclomaticComplexity The method 'doChangeOrderEntry(HttpServletRequest)' has a cyclomatic complexity of 11. 602652

fr/paris/lutece/plugins/appointment/web/AppointmentFormFieldJspBean.java

Rule Violation Line
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 136
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 456
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 457
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 458

fr/paris/lutece/plugins/appointment/web/AppointmentFormJspBean.java

Rule Violation Line
ExcessiveImports A high number of imports can indicate a high degree of coupling within an object. 34814
ImmutableField Private field '_nDefaultItemsPerPage' could be made final; it is only initialized in the declaration or constructor. 188
CallSuperInConstructor It is a good practice to call super() in a constructor 196199
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 212
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 367
NPathComplexity The method 'doModifyAppointmentForm(HttpServletRequest)' has an NPath complexity of 384 448503
CyclomaticComplexity The method 'doModifyAppointmentForm(HttpServletRequest)' has a cyclomatic complexity of 13. 448503
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 499
CyclomaticComplexity The method 'doChangeFormActivation(HttpServletRequest)' has a cyclomatic complexity of 11. 515559
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 617
CyclomaticComplexity The method 'importClosingDayFile(MultipartHttpServletRequest, int)' has a cyclomatic complexity of 11. 722793

fr/paris/lutece/plugins/appointment/web/AppointmentJspBean.java

Rule Violation Line
ExcessiveImports A high number of imports can indicate a high degree of coupling within an object. 341786
ExcessiveClassLength Avoid really long classes. 1491786
TooManyMethods This class has too many methods, consider refactoring it. 1501786
ImmutableField Private field '_nDefaultItemsPerPage' could be made final; it is only initialized in the declaration or constructor. 319
CommentDefaultAccessModifier To avoid mistakes add a comment at the beginning of the listFormErrors field if you want a default access modifier 326
DefaultPackage Use explicit scoping instead of the default package private level 326
DefaultPackage Use explicit scoping instead of the default package private level 327
CommentDefaultAccessModifier To avoid mistakes add a comment at the beginning of the _moduleAppointmentDesk field if you want a default access modifier 327
CyclomaticComplexity The method 'getViewCalendarManageAppointments(HttpServletRequest)' has a cyclomatic complexity of 24. 338505
AvoidSynchronizedAtMethodLevel Use block level rather than method level synchronization 338505
NcssCount The method 'getViewCalendarManageAppointments(HttpServletRequest)' has a NCSS line count of 94. 338505
ExcessiveMethodLength Avoid really long methods. 338505
NPathComplexity The method 'getViewCalendarManageAppointments(HttpServletRequest)' has an NPath complexity of 62400 338505
ConfusingTernary Avoid if (x != y) ..; else ..; 449458
UnnecessaryAnnotationValueElement Avoid the use of value in annotations when its the only element 515
ExcessiveMethodLength Avoid really long methods. 516649
NcssCount The method 'getManageAppointments(HttpServletRequest)' has a NCSS line count of 86. 516649
NPathComplexity The method 'getManageAppointments(HttpServletRequest)' has an NPath complexity of 10080 516649
CyclomaticComplexity The method 'getManageAppointments(HttpServletRequest)' has a cyclomatic complexity of 21. 516649
AvoidSynchronizedAtMethodLevel Use block level rather than method level synchronization 516649
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 531
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 532
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 533
ConfusingTernary Avoid if (x != y) ..; else ..; 537560
AvoidSynchronizedAtMethodLevel Use block level rather than method level synchronization 659666
AvoidSynchronizedAtMethodLevel Use block level rather than method level synchronization 679693
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 681
AvoidSynchronizedAtMethodLevel Use block level rather than method level synchronization 703710
AvoidSynchronizedAtMethodLevel Use block level rather than method level synchronization 722743
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 724
AvoidSynchronizedAtMethodLevel Use block level rather than method level synchronization 755827
NPathComplexity The method 'getViewAppointment(HttpServletRequest)' has an NPath complexity of 240 755827
CyclomaticComplexity The method 'getViewAppointment(HttpServletRequest)' has a cyclomatic complexity of 12. 755827
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 760
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 761
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 763
AvoidSynchronizedAtMethodLevel Use block level rather than method level synchronization 841879
NcssCount The method 'getViewCreateAppointment(HttpServletRequest)' has a NCSS line count of 90. 8911068
CyclomaticComplexity The method 'getViewCreateAppointment(HttpServletRequest)' has a cyclomatic complexity of 29. 8911068
ExcessiveMethodLength Avoid really long methods. 8911068
AvoidSynchronizedAtMethodLevel Use block level rather than method level synchronization 8911068
NPathComplexity The method 'getViewCreateAppointment(HttpServletRequest)' has an NPath complexity of 201480 8911068
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 895
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 897
LinguisticNaming Linguistics Antipattern - The variable 'isModification' indicates linguistically it is a boolean, but it is 'String' 906
ConfusingTernary Avoid if (x != y) ..; else ..; 909951
ConfusingTernary Avoid if (x != y) ..; else ..; 958972
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 965
AvoidReassigningLoopVariables Avoid reassigning the loop control variable 'slot' 991
AvoidReassigningLoopVariables Avoid reassigning the loop control variable 'slot' 997
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 1005
AvoidSynchronizedAtMethodLevel Use block level rather than method level synchronization 10801155
CyclomaticComplexity The method 'doValidateForm(HttpServletRequest)' has a cyclomatic complexity of 12. 10801155
NPathComplexity The method 'doValidateForm(HttpServletRequest)' has an NPath complexity of 432 10801155
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 1083
ShortVariable Avoid variables with short names like lf 1121
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 1153
CyclomaticComplexity The method 'getViewChangeDateAppointment(HttpServletRequest)' has a cyclomatic complexity of 14. 11661256
AvoidSynchronizedAtMethodLevel Use block level rather than method level synchronization 11661256
NPathComplexity The method 'getViewChangeDateAppointment(HttpServletRequest)' has an NPath complexity of 612 11661256
AvoidReassigningLoopVariables Avoid reassigning the loop control variable 'slot' 1205
AvoidReassigningLoopVariables Avoid reassigning the loop control variable 'slot' 1209
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 1252
AvoidSynchronizedAtMethodLevel Use block level rather than method level synchronization 12661284
AvoidSynchronizedAtMethodLevel Use block level rather than method level synchronization 12961351
CyclomaticComplexity The method 'doMakeAppointment(HttpServletRequest)' has a cyclomatic complexity of 11. 12961351
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 1298
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 1346
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 1349
AvoidSynchronizedAtMethodLevel Use block level rather than method level synchronization 13641412
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 1367
ShortVariable Avoid variables with short names like os 1399
AvoidSynchronizedAtMethodLevel Use block level rather than method level synchronization 14251461
ShortVariable Avoid variables with short names like os 1448
CallSuperInConstructor It is a good practice to call super() in a constructor 14661469
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 1473
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 1474
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 1475
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 1476
CyclomaticComplexity The method 'orderList(List)' has a cyclomatic complexity of 11. 15011546
MissingBreakInSwitch A switch statement does not contain a break 15101539
AvoidSynchronizedAtMethodLevel Use block level rather than method level synchronization 15781616
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 1598
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 1607
AvoidSynchronizedAtMethodLevel Use block level rather than method level synchronization 16261693
CyclomaticComplexity The method 'doProcessWorkflowAction(HttpServletRequest)' has a cyclomatic complexity of 14. 16261693
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 1682
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 1686
CyclomaticComplexity The method 'doChangeAppointmentStatus(HttpServletRequest)' has a cyclomatic complexity of 11. 17051745
AvoidSynchronizedAtMethodLevel Use block level rather than method level synchronization 17051745
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 1712

fr/paris/lutece/plugins/appointment/web/CalendarTemplateJspBean.java

Rule Violation Line
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 159
CyclomaticComplexity The method 'getCreateModifyTemplate(HttpServletRequest)' has a cyclomatic complexity of 10. 191249

fr/paris/lutece/plugins/appointment/web/CommentJspBean.java

Rule Violation Line
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 147
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 166
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 196
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 198
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 199
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 200
ConfusingTernary Avoid if (x != y) ..; else ..; 228237
CyclomaticComplexity The method 'doModifyComment(HttpServletRequest)' has a cyclomatic complexity of 11. 287337
NPathComplexity The method 'doModifyComment(HttpServletRequest)' has an NPath complexity of 216 287337
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 291
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 292
ConfusingTernary Avoid if (x != y) ..; else ..; 320328
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 383

fr/paris/lutece/plugins/appointment/web/CommentNotificationJspBean.java

Rule Violation Line
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 103
UnnecessaryAnnotationValueElement Avoid the use of value in annotations when its the only element 118

fr/paris/lutece/plugins/appointment/web/SpecificWeekJspBean.java

Rule Violation Line
ExcessiveImports A high number of imports can indicate a high degree of coupling within an object. 34736
CyclomaticComplexity The method 'getViewManageSpecificWeek(HttpServletRequest)' has a cyclomatic complexity of 10. 180243
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 182
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 184
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 257
NPathComplexity The method 'doModifySlot(HttpServletRequest)' has an NPath complexity of 2898 299387
CyclomaticComplexity The method 'doModifySlot(HttpServletRequest)' has a cyclomatic complexity of 16. 299387
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 301
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 302
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 303
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 304
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 305
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 306
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 308
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 383
CyclomaticComplexity The method 'doModifyListSlots(HttpServletRequest)' has a cyclomatic complexity of 16. 398514
ExcessiveMethodLength Avoid really long methods. 398514
NPathComplexity The method 'doModifyListSlots(HttpServletRequest)' has an NPath complexity of 1440 398514
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 400
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 401
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 402
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 403
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 406
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 407
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 408
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 409
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 411
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 412
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 413
ConfusingTernary Avoid if (x != y) ..; else ..; 465478
ConfusingTernary Avoid if (x != y) ..; else ..; 499509
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 510
CyclomaticComplexity The method 'updateListSlots(List, int, int, boolean, boolean, boolean, LocalTime)' has a cyclomatic complexity of 27. 597705
ExcessiveMethodLength Avoid really long methods. 597705
NPathComplexity The method 'updateListSlots(List, int, int, boolean, boolean, boolean, LocalTime)' has an NPath complexity of 34056 597705
ConfusingTernary Avoid if (x != y) ..; else ..; 630
AppendCharacterWithChar Avoid appending characters as strings in StringBuffer.append. 669
ControlStatementBraces This statement should have braces 692
ControlStatementBraces This statement should have braces 695

fr/paris/lutece/plugins/appointment/web/TypicalWeekJspBean.java

Rule Violation Line
ExcessiveImports A high number of imports can indicate a high degree of coupling within an object. 341010
TooManyMethods This class has too many methods, consider refactoring it. 941010
UnnecessaryAnnotationValueElement Avoid the use of value in annotations when its the only element 180
CyclomaticComplexity The method 'getViewManageTypicalWeek(HttpServletRequest)' has a cyclomatic complexity of 11. 181249
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 183
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 184
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 186
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 187
ConfusingTernary Avoid if (x != y) ..; else ..; 200214
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 263
CyclomaticComplexity The method 'doModifyAdvancedParameters(HttpServletRequest)' has a cyclomatic complexity of 12. 293366
NPathComplexity The method 'doModifyAdvancedParameters(HttpServletRequest)' has an NPath complexity of 256 293366
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 302
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 303
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 433
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 470
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 471
NPathComplexity The method 'doModifyTimeSlot(HttpServletRequest)' has an NPath complexity of 6336 515635
ExcessiveMethodLength Avoid really long methods. 515635
NcssCount The method 'doModifyTimeSlot(HttpServletRequest)' has a NCSS line count of 69. 515635
CyclomaticComplexity The method 'doModifyTimeSlot(HttpServletRequest)' has a cyclomatic complexity of 18. 515635
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 518
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 520
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 534
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 535
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 536
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 537
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 538
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 539
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 540
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 573
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 608
ExcessiveMethodLength Avoid really long methods. 646820
NPathComplexity The method 'doModifyListTimeSlot(HttpServletRequest)' has an NPath complexity of 114048 646820
CyclomaticComplexity The method 'doModifyListTimeSlot(HttpServletRequest)' has a cyclomatic complexity of 25. 646820
NcssCount The method 'doModifyListTimeSlot(HttpServletRequest)' has a NCSS line count of 86. 646820
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 649
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 650
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 652
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 653
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 654
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 666
PositionLiteralsFirstInCaseInsensitiveComparisons Position literals first in String comparisons for EqualsIgnoreCase 689
PositionLiteralsFirstInCaseInsensitiveComparisons Position literals first in String comparisons for EqualsIgnoreCase 689
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 695
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 795
AvoidReassigningLoopVariables Avoid reassigning the loop control variable 'slotImpacted' 880
CyclomaticComplexity The method 'manageTheSlotsAndAppointmentsImpacted(List, List, int, int, boolean, boolean)' has a cyclomatic complexity of 10. 902959
ConfusingTernary Avoid if (x != y) ..; else ..; 924936
AvoidReassigningLoopVariables Avoid reassigning the loop control variable 'slotImpacted' 943

fr/paris/lutece/plugins/appointment/web/dto/AppointmentDTO.java

Rule Violation Line
TooManyFields Too many fields 57519
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 132
CommentRequired Public method and constructor comments are required 429432

fr/paris/lutece/plugins/appointment/web/dto/AppointmentFilterDTO.java

Rule Violation Line
CommentRequired Header comments are required 42301
ConfusingTernary Avoid if (x != y) ..; else ..; 121128
ConfusingTernary Avoid if (x != y) ..; else ..; 139146
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 145
ConfusingTernary Avoid if (x != y) ..; else ..; 156163
ConfusingTernary Avoid if (x != y) ..; else ..; 175182
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 181

fr/paris/lutece/plugins/appointment/web/dto/AppointmentFormDTO.java

Rule Violation Line
ExcessivePublicCount This class has a bunch of public methods and attributes 341169
ExcessiveClassLength Avoid really long classes. 541169
TooManyFields Too many fields 541169
CyclomaticComplexity The class 'AppointmentFormDTO' has a total cyclomatic complexity of 87 (highest 2). 541169
AvoidDuplicateLiterals The String literal "#i18n{portal.validation.message.notEmpty}" appears 7 times in this file; the first occurrence is on line 97 97
ConfusingTernary Avoid if (x != y) ..; else ..; 355362
ConfusingTernary Avoid if (x != y) ..; else ..; 373380
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 379
CommentRequired Public method and constructor comments are required 478481
ConfusingTernary Avoid if (x != y) ..; else ..; 637644
ConfusingTernary Avoid if (x != y) ..; else ..; 655662
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 661
ConfusingTernary Avoid if (x != y) ..; else ..; 672679
ConfusingTernary Avoid if (x != y) ..; else ..; 690697
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 696
CommentRequired Public method and constructor comments are required 11511153
CommentRequired Public method and constructor comments are required 11551157
CommentRequired Public method and constructor comments are required 11591162
CommentRequired Public method and constructor comments are required 11641167

fr/paris/lutece/plugins/appointment/web/dto/AppointmentPackageDTO.java

Rule Violation Line
CommentRequired Header comments are required 4099
CommentRequired Public method and constructor comments are required 9598

fr/paris/lutece/plugins/appointment/web/dto/ReservationRuleDTO.java

Rule Violation Line
AvoidDuplicateLiterals The String literal "#i18n{portal.validation.message.notEmpty}" appears 6 times in this file; the first occurrence is on line 82 82

fr/paris/lutece/plugins/appointment/web/dto/ResponseRecapDTO.java

Rule Violation Line
ImmutableField Private field '_response' could be made final; it is only initialized in the declaration or constructor. 64
CallSuperInConstructor It is a good practice to call super() in a constructor 7275
CallSuperInConstructor It is a good practice to call super() in a constructor 8589
ShortVariable Avoid variables with short names like o 176
ShortVariable Avoid variables with short names like o 187

fr/paris/lutece/plugins/appointment/web/file/AppointmentFormIconService.java

Rule Violation Line
AvoidSynchronizedAtMethodLevel Use block level rather than method level synchronization 3235
MissingOverride The method 'getResourceTypeId()' is missing an @Override annotation. 7982

fr/paris/lutece/plugins/appointment/web/portlet/AbstractPortletJspBean.java

Rule Violation Line
CommentRequired Header comments are required 4377

fr/paris/lutece/plugins/appointment/web/portlet/AppointmentFormListPortletJspBean.java

Rule Violation Line
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 65

fr/paris/lutece/plugins/appointment/web/portlet/AppointmentFormPortletJspBean.java

Rule Violation Line
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 94
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 121
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 139

fr/paris/lutece/plugins/appointment/web/portlet/AppointmentPortletJspBean.java

Rule Violation Line
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 65

Priority 4

fr/paris/lutece/plugins/appointment/business/appointment/Appointment.java

Rule Violation Line
BooleanGetMethodName A getX() method which returns a boolean should be named isX() 181184
BooleanGetMethodName A getX() method which returns a boolean should be named isX() 471474

fr/paris/lutece/plugins/appointment/business/form/Form.java

Rule Violation Line
ShortClassName Avoid short class names like Form 58541
BooleanGetMethodName A getX() method which returns a boolean should be named isX() 375378
BooleanGetMethodName A getX() method which returns a boolean should be named isX() 446449

fr/paris/lutece/plugins/appointment/business/planning/TimeSlot.java

Rule Violation Line
BooleanGetMethodName A getX() method which returns a boolean should be named isX() 223226

fr/paris/lutece/plugins/appointment/business/rule/FormRule.java

Rule Violation Line
BooleanGetMethodName A getX() method which returns a boolean should be named isX() 127130
BooleanGetMethodName A getX() method which returns a boolean should be named isX() 148151
BooleanGetMethodName A getX() method which returns a boolean should be named isX() 169172
BooleanGetMethodName A getX() method which returns a boolean should be named isX() 274277

fr/paris/lutece/plugins/appointment/business/rule/ReservationRule.java

Rule Violation Line
BooleanGetMethodName A getX() method which returns a boolean should be named isX() 191194

fr/paris/lutece/plugins/appointment/business/slot/Slot.java

Rule Violation Line
ShortClassName Avoid short class names like Slot 51514
BooleanGetMethodName A getX() method which returns a boolean should be named isX() 322325
BooleanGetMethodName A getX() method which returns a boolean should be named isX() 343346
BooleanGetMethodName A getX() method which returns a boolean should be named isX() 364367
BooleanGetMethodName A getX() method which returns a boolean should be named isX() 490498

fr/paris/lutece/plugins/appointment/business/user/User.java

Rule Violation Line
ShortClassName Avoid short class names like User 51247

fr/paris/lutece/plugins/appointment/service/AppointmentService.java

Rule Violation Line
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'org.apache.commons.lang3.StringUtils.SPACE' due to existing import 'org.apache.commons.lang3.StringUtils' 349

fr/paris/lutece/plugins/appointment/service/AppointmentUtilities.java

Rule Violation Line
UnusedImports Avoid unused imports such as 'fr.paris.lutece.portal.business.user.AdminUserHome' 88

fr/paris/lutece/plugins/appointment/web/AppointmentApp.java

Rule Violation Line
UnusedImports Avoid unused imports such as 'fr.paris.lutece.portal.service.datastore.DatastoreService' 101

fr/paris/lutece/plugins/appointment/web/dto/AppointmentDTO.java

Rule Violation Line
BooleanGetMethodName A getX() method which returns a boolean should be named isX() 439442
BooleanGetMethodName A getX() method which returns a boolean should be named isX() 460463

fr/paris/lutece/plugins/appointment/web/dto/AppointmentFormDTO.java

Rule Violation Line
BooleanGetMethodName A getX() method which returns a boolean should be named isX() 488491
BooleanGetMethodName A getX() method which returns a boolean should be named isX() 509512
BooleanGetMethodName A getX() method which returns a boolean should be named isX() 530533
BooleanGetMethodName A getX() method which returns a boolean should be named isX() 551554
BooleanGetMethodName A getX() method which returns a boolean should be named isX() 572575
BooleanGetMethodName A getX() method which returns a boolean should be named isX() 593596
BooleanGetMethodName A getX() method which returns a boolean should be named isX() 614617
BooleanGetMethodName A getX() method which returns a boolean should be named isX() 705708
BooleanGetMethodName A getX() method which returns a boolean should be named isX() 726729
BooleanGetMethodName A getX() method which returns a boolean should be named isX() 747750
BooleanGetMethodName A getX() method which returns a boolean should be named isX() 810813
BooleanGetMethodName A getX() method which returns a boolean should be named isX() 852855
BooleanGetMethodName A getX() method which returns a boolean should be named isX() 936939
BooleanGetMethodName A getX() method which returns a boolean should be named isX() 10551058
BooleanGetMethodName A getX() method which returns a boolean should be named isX() 10761079

fr/paris/lutece/plugins/appointment/web/dto/ReservationRuleDTO.java

Rule Violation Line
BooleanGetMethodName A getX() method which returns a boolean should be named isX() 209212

Files

fr/paris/lutece/plugins/appointment/business/AbstractDateConversion.java

Rule Violation Priority Line
CommentRequired Header comments are required 3 39159
ConfusingTernary Avoid if (x != y) ..; else ..; 3 96103
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 3 102
ConfusingTernary Avoid if (x != y) ..; else ..; 3 150157
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 3 156

fr/paris/lutece/plugins/appointment/business/appointment/Appointment.java

Rule Violation Priority Line
BooleanGetMethodName A getX() method which returns a boolean should be named isX() 4 181184
CommentRequired Public method and constructor comments are required 3 342352
CommentRequired Public method and constructor comments are required 3 354368
ConfusingTernary Avoid if (x != y) ..; else ..; 3 456463
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 3 462
BooleanGetMethodName A getX() method which returns a boolean should be named isX() 4 471474

fr/paris/lutece/plugins/appointment/business/appointment/AppointmentDAO.java

Rule Violation Priority Line
TooManyMethods This class has too many methods, consider refactoring it. 3 62830
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 3 374
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 3 444
CyclomaticComplexity The method 'addFilterParametersToDAOUtil(AppointmentFilterDTO, DAOUtil)' has a cyclomatic complexity of 13. 3 497561
NPathComplexity The method 'addFilterParametersToDAOUtil(AppointmentFilterDTO, DAOUtil)' has an NPath complexity of 2304 3 497561
UseLocaleWithCaseConversions When doing a String.toLowerCase()/toUpperCase() call, use a Locale 3 506
UseLocaleWithCaseConversions When doing a String.toLowerCase()/toUpperCase() call, use a Locale 3 510
UseLocaleWithCaseConversions When doing a String.toLowerCase()/toUpperCase() call, use a Locale 3 514
UseLocaleWithCaseConversions When doing a String.toLowerCase()/toUpperCase() call, use a Locale 3 518
NPathComplexity The method 'getSqlQueryFromFilter(AppointmentFilterDTO, String)' has an NPath complexity of 1024 3 570629
CyclomaticComplexity The method 'getSqlQueryFromFilter(AppointmentFilterDTO, String)' has a cyclomatic complexity of 11. 3 570629
CyclomaticComplexity The method 'getOrderQuery(AppointmentFilterDTO, String)' has a cyclomatic complexity of 11. 3 631680
MissingBreakInSwitch A switch statement does not contain a break 3 642670
AvoidReassigningParameters Avoid reassigning parameters such as 'nIndex' 2 746
AvoidReassigningParameters Avoid reassigning parameters such as 'nIndex' 2 746
AvoidReassigningParameters Avoid reassigning parameters such as 'nIndex' 2 746
AvoidReassigningParameters Avoid reassigning parameters such as 'nIndex' 2 746
AvoidReassigningParameters Avoid reassigning parameters such as 'nIndex' 2 746
AvoidReassigningParameters Avoid reassigning parameters such as 'nIndex' 2 746
AvoidReassigningParameters Avoid reassigning parameters such as 'nIndex' 2 746
AvoidReassigningParameters Avoid reassigning parameters such as 'nIndex' 2 746
AvoidReassigningParameters Avoid reassigning parameters such as 'nIndex' 2 746
AvoidReassigningParameters Avoid reassigning parameters such as 'nIndex' 2 769
AvoidReassigningParameters Avoid reassigning parameters such as 'nIndex' 2 769
AvoidReassigningParameters Avoid reassigning parameters such as 'nIndex' 2 769
AvoidReassigningParameters Avoid reassigning parameters such as 'nIndex' 2 769
AvoidReassigningParameters Avoid reassigning parameters such as 'nIndex' 2 769

fr/paris/lutece/plugins/appointment/business/appointment/AppointmentHome.java

Rule Violation Priority Line
TooManyMethods This class has too many methods, consider refactoring it. 3 51243
CommentRequired Public method and constructor comments are required 3 214217

fr/paris/lutece/plugins/appointment/business/appointment/AppointmentSlot.java

Rule Violation Priority Line
CommentRequired Header comments are required 3 38112

fr/paris/lutece/plugins/appointment/business/appointment/IAppointmentDAO.java

Rule Violation Priority Line
TooManyMethods This class has too many methods, consider refactoring it. 3 48209

fr/paris/lutece/plugins/appointment/business/comment/CommentDAO.java

Rule Violation Priority Line
ConfusingTernary Avoid if (x != y) ..; else ..; 3 7380
ConfusingTernary Avoid if (x != y) ..; else ..; 3 8289

fr/paris/lutece/plugins/appointment/business/comment/ICommentNotificationConfigDAO.java

Rule Violation Priority Line
CommentRequired Header comments are required 3 4073

fr/paris/lutece/plugins/appointment/business/form/Form.java

Rule Violation Priority Line
ShortClassName Avoid short class names like Form 4 58541
TooManyFields Too many fields 3 58541
ConfusingTernary Avoid if (x != y) ..; else ..; 3 306313
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 3 312
ConfusingTernary Avoid if (x != y) ..; else ..; 3 360367
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 3 366
BooleanGetMethodName A getX() method which returns a boolean should be named isX() 4 375378
BooleanGetMethodName A getX() method which returns a boolean should be named isX() 4 446449
CommentRequired Public method and constructor comments are required 3 521524
CommentRequired Public method and constructor comments are required 3 526529
CommentRequired Public method and constructor comments are required 3 531534
CommentRequired Public method and constructor comments are required 3 536539

fr/paris/lutece/plugins/appointment/business/form/FormDAO.java

Rule Violation Priority Line
TooManyMethods This class has too many methods, consider refactoring it. 3 50276

fr/paris/lutece/plugins/appointment/business/localization/LocalizationDAO.java

Rule Violation Priority Line
CommentRequired Header comments are required 3 41195
ConfusingTernary Avoid if (x != y) ..; else ..; 3 171178
ConfusingTernary Avoid if (x != y) ..; else ..; 3 179186

fr/paris/lutece/plugins/appointment/business/message/FormMessage.java

Rule Violation Priority Line
TooManyFields Too many fields 3 44543

fr/paris/lutece/plugins/appointment/business/planning/ClosingDay.java

Rule Violation Priority Line
ConfusingTernary Avoid if (x != y) ..; else ..; 3 134141
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 3 140

fr/paris/lutece/plugins/appointment/business/planning/ClosingDayDAO.java

Rule Violation Priority Line
TooManyMethods This class has too many methods, consider refactoring it. 3 52237

fr/paris/lutece/plugins/appointment/business/planning/TimeSlot.java

Rule Violation Priority Line
BooleanGetMethodName A getX() method which returns a boolean should be named isX() 4 223226

fr/paris/lutece/plugins/appointment/business/planning/WeekDefinitionDAO.java

Rule Violation Priority Line
TooManyMethods This class has too many methods, consider refactoring it. 3 52245

fr/paris/lutece/plugins/appointment/business/portlet/AppointmentFormListPortlet.java

Rule Violation Priority Line
CallSuperInConstructor It is a good practice to call super() in a constructor 3 5457

fr/paris/lutece/plugins/appointment/business/portlet/AppointmentFormPortlet.java

Rule Violation Priority Line
CallSuperInConstructor It is a good practice to call super() in a constructor 3 5659

fr/paris/lutece/plugins/appointment/business/portlet/AppointmentFormPortletDAO.java

Rule Violation Priority Line
ShortVariable Avoid variables with short names like p 3 68
ShortVariable Avoid variables with short names like p 3 105

fr/paris/lutece/plugins/appointment/business/portlet/AppointmentPortlet.java

Rule Violation Priority Line
CallSuperInConstructor It is a good practice to call super() in a constructor 3 5861

fr/paris/lutece/plugins/appointment/business/rule/FormRule.java

Rule Violation Priority Line
BooleanGetMethodName A getX() method which returns a boolean should be named isX() 4 127130
BooleanGetMethodName A getX() method which returns a boolean should be named isX() 4 148151
BooleanGetMethodName A getX() method which returns a boolean should be named isX() 4 169172
BooleanGetMethodName A getX() method which returns a boolean should be named isX() 4 274277

fr/paris/lutece/plugins/appointment/business/rule/FormRuleDAO.java

Rule Violation Priority Line
AvoidSynchronizedAtMethodLevel Use block level rather than method level synchronization 3 5969

fr/paris/lutece/plugins/appointment/business/rule/ReservationRule.java

Rule Violation Priority Line
BooleanGetMethodName A getX() method which returns a boolean should be named isX() 4 191194

fr/paris/lutece/plugins/appointment/business/slot/ISlotDAO.java

Rule Violation Priority Line
TooManyMethods This class has too many methods, consider refactoring it. 3 49229
UnnecessaryModifier Unnecessary modifier 'public' on method 'deleteByIdForm': the method is declared in an interface type 3 88

fr/paris/lutece/plugins/appointment/business/slot/Period.java

Rule Violation Priority Line
DataClass The class 'Period' is suspected to be a Data Class (WOC=0.000%, NOPA=0, NOAM=4, WMC=5) 3 39105
CommentRequired Header comments are required 3 39105
CommentRequired Public method and constructor comments are required 3 5761

fr/paris/lutece/plugins/appointment/business/slot/Slot.java

Rule Violation Priority Line
ShortClassName Avoid short class names like Slot 4 51514
BooleanGetMethodName A getX() method which returns a boolean should be named isX() 4 322325
BooleanGetMethodName A getX() method which returns a boolean should be named isX() 4 343346
BooleanGetMethodName A getX() method which returns a boolean should be named isX() 4 364367
BooleanGetMethodName A getX() method which returns a boolean should be named isX() 4 490498
AvoidLiteralsInIfCondition Avoid using Literals in Conditional Statements 3 492

fr/paris/lutece/plugins/appointment/business/slot/SlotDAO.java

Rule Violation Priority Line
TooManyMethods This class has too many methods, consider refactoring it. 3 53375

fr/paris/lutece/plugins/appointment/business/slot/SlotHome.java

Rule Violation Priority Line
TooManyMethods This class has too many methods, consider refactoring it. 3 52280

fr/paris/lutece/plugins/appointment/business/user/User.java

Rule Violation Priority Line
ShortClassName Avoid short class names like User 4 51247

fr/paris/lutece/plugins/appointment/business/user/UserDAO.java

Rule Violation Priority Line
UseLocaleWithCaseConversions When doing a String.toLowerCase()/toUpperCase() call, use a Locale 3 148
UseLocaleWithCaseConversions When doing a String.toLowerCase()/toUpperCase() call, use a Locale 3 149
UseLocaleWithCaseConversions When doing a String.toLowerCase()/toUpperCase() call, use a Locale 3 150

fr/paris/lutece/plugins/appointment/exception/AppointmentSavedException.java

Rule Violation Priority Line
CommentRequired Header comments are required 3 3658
CommentRequired Public method and constructor comments are required 3 5357
ShortVariable Avoid variables with short names like e 3 53

fr/paris/lutece/plugins/appointment/exception/SlotEditTaskExpiredTimeException.java

Rule Violation Priority Line
CommentRequired Header comments are required 3 3658
ShortVariable Avoid variables with short names like e 3 53
CommentRequired Public method and constructor comments are required 3 5357

fr/paris/lutece/plugins/appointment/exception/SlotFullException.java

Rule Violation Priority Line
CommentRequired Header comments are required 3 3658
CommentRequired Public method and constructor comments are required 3 5357
ShortVariable Avoid variables with short names like e 3 53

fr/paris/lutece/plugins/appointment/log/LogUtilities.java

Rule Violation Priority Line
CommentRequired Header comments are required 3 4267
ClassNamingConventions The utility class name 'LogUtilities' doesn't match '[A-Z][a-zA-Z0-9]+(Utils?|Helper|Home|Service)' 1 4267
ShortVariable Avoid variables with short names like BY 3 46
CommentRequired Public method and constructor comments are required 3 5665

fr/paris/lutece/plugins/appointment/service/AppointmentExecutorService.java

Rule Violation Priority Line
CommentRequired Enum comments are required 3 47113
FieldNamingConventions The final field name '_executorService' doesn't match '[a-z][a-zA-Z0-9]*' 1 51
DoNotUseThreads To be compliant to J2EE, a webapp should not use any thread. 3 66
DoNotUseThreads To be compliant to J2EE, a webapp should not use any thread. 3 83

fr/paris/lutece/plugins/appointment/service/AppointmentResourceIdService.java

Rule Violation Priority Line
DataClass The class 'AppointmentResourceIdService' is suspected to be a Data Class (WOC=0.000%, NOPA=16, NOAM=0, WMC=1) 3 57237
CallSuperInConstructor It is a good practice to call super() in a constructor 3 112115
NcssCount The method 'register()' has a NCSS line count of 65. 3 121202

fr/paris/lutece/plugins/appointment/service/AppointmentService.java

Rule Violation Priority Line
GodClass Possible God Class (WMC=58, ATFD=104, TCC=0.000%) 3 75618
TooManyMethods This class has too many methods, consider refactoring it. 3 76618
CommentDefaultAccessModifier To avoid mistakes add a comment at the beginning of the buildAndCreateAppointment method if you want a default access modifier 3 177221
DefaultPackage Use explicit scoping instead of the default package private level 3 177221
UseStringBufferForStringAppends Prefer StringBuilder (non-synchronized) or StringBuffer (synchronized) over += for concatenating strings 3 210
ConfusingTernary Avoid if (x != y) ..; else ..; 3 342355
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'org.apache.commons.lang3.StringUtils.SPACE' due to existing import 'org.apache.commons.lang3.StringUtils' 4 349
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 3 408
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 3 424
CyclomaticComplexity The method 'updateAppointment(Appointment)' has a cyclomatic complexity of 11. 3 515561
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 3 554
CommentRequired Public method and constructor comments are required 3 591616
AvoidLiteralsInIfCondition Avoid using Literals in Conditional Statements 3 599

fr/paris/lutece/plugins/appointment/service/AppointmentShutdownService.java

Rule Violation Priority Line
CommentRequired Header comments are required 3 3963

fr/paris/lutece/plugins/appointment/service/AppointmentUtilities.java

Rule Violation Priority Line
ExcessiveImports A high number of imports can indicate a high degree of coupling within an object. 3 341322
UnusedImports Avoid unused imports such as 'fr.paris.lutece.portal.business.user.AdminUserHome' 4 88
GodClass Possible God Class (WMC=147, ATFD=239, TCC=0.891%) 3 1011322
ClassNamingConventions The utility class name 'AppointmentUtilities' doesn't match '[A-Z][a-zA-Z0-9]+(Utils?|Helper|Home|Service)' 1 1011322
ExcessiveClassLength Avoid really long classes. 3 1011322
CyclomaticComplexity The class 'AppointmentUtilities' has a total cyclomatic complexity of 147 (highest 12). 3 1011322
TooManyMethods This class has too many methods, consider refactoring it. 3 1021322
FieldNamingConventions The constant name '_secheduledExecutor' doesn't match '[A-Z][A-Z_0-9]*' 1 123
DoNotUseThreads To be compliant to J2EE, a webapp should not use any thread. 3 124
AvoidDeeplyNestedIfStmts Deeply nested if..then statements are hard to read 3 221234
AvoidDeeplyNestedIfStmts Deeply nested if..then statements are hard to read 3 275279
AvoidDeeplyNestedIfStmts Deeply nested if..then statements are hard to read 3 313316
AvoidDeeplyNestedIfStmts Deeply nested if..then statements are hard to read 3 346349
CyclomaticComplexity The method 'checkNbMaxAppointmentsOnAGivenPeriod(AppointmentDTO, String, AppointmentFormDTO)' has a cyclomatic complexity of 11. 3 369430
AvoidDeeplyNestedIfStmts Deeply nested if..then statements are hard to read 3 414418
AvoidDeeplyNestedIfStmts Deeply nested if..then statements are hard to read 3 421425
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 3 504
AvoidCatchingNPE Avoid catching NullPointerException; consider removing the cause of the NPE. 3 504
UseObjectForClearerAPI Rather than using a lot of String arguments, consider using a container object for those values. 3 547
CommentRequired Public method and constructor comments are required 3 594606
ControlStatementBraces This statement should have braces 3 659
CommentRequired Public method and constructor comments are required 3 664668
ShortVariable Avoid variables with short names like nI 3 725
EmptyIfStmt Avoid empty if statements 3 836838
EmptyIfStmt Avoid empty if statements 3 904906
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 3 924
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 3 925
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 3 926
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 3 927
ConfusingTernary Avoid if (x != y) ..; else ..; 3 955970
CommentRequired Public method and constructor comments are required 3 10551066
CommentRequired Public method and constructor comments are required 3 10681080
CyclomaticComplexity The method 'weekIsOpenInFO(AppointmentFormDTO, List, Locale)' has a cyclomatic complexity of 12. 3 11371179
AvoidCatchingNPE Avoid catching NullPointerException; consider removing the cause of the NPE. 3 1316
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 3 1316

fr/paris/lutece/plugins/appointment/service/CalendarBuilder.java

Rule Violation Priority Line
CommentRequired Header comments are required 3 51428
ClassWithOnlyPrivateConstructorsShouldBeFinal A class which only has private constructors should be final 1 51428
ExcessiveMethodLength Avoid really long methods. 3 74218
NcssCount The method 'buildListSlot(int, Map, LocalDate, LocalDate)' has a NCSS line count of 78. 3 74218
CyclomaticComplexity The method 'buildListSlot(int, Map, LocalDate, LocalDate)' has a cyclomatic complexity of 19. 3 74218
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 3 112
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 3 124
ConfusingTernary Avoid if (x != y) ..; else ..; 3 131214
ConfusingTernary Avoid if (x != y) ..; else ..; 3 160171
NPathComplexity The method 'buildListSlot(int, Map, LocalDate, LocalDate, int, boolean)' has an NPath complexity of 699 3 237402
NcssCount The method 'buildListSlot(int, Map, LocalDate, LocalDate, int, boolean)' has a NCSS line count of 96. 3 237402
ExcessiveMethodLength Avoid really long methods. 3 237402
CyclomaticComplexity The method 'buildListSlot(int, Map, LocalDate, LocalDate, int, boolean)' has a cyclomatic complexity of 17. 3 237402
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 3 287
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 3 298
ConfusingTernary Avoid if (x != y) ..; else ..; 3 341352

fr/paris/lutece/plugins/appointment/service/ClosingDayService.java

Rule Violation Priority Line
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 3 208
AvoidLiteralsInIfCondition Avoid using Literals in Conditional Statements 3 227

fr/paris/lutece/plugins/appointment/service/CommentService.java

Rule Violation Priority Line
ClassWithOnlyPrivateConstructorsShouldBeFinal A class which only has private constructors should be final 1 60264
CommentRequired Header comments are required 3 60264
CommentRequired Public method and constructor comments are required 3 195231
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 3 244

fr/paris/lutece/plugins/appointment/service/EntryService.java

Rule Violation Priority Line
ExcessiveImports A high number of imports can indicate a high degree of coupling within an object. 3 34752
GodClass Possible God Class (WMC=83, ATFD=177, TCC=0.000%) 3 76752
CyclomaticComplexity The class 'EntryService' has a total cyclomatic complexity of 83 (highest 16). 3 76752
CyclomaticComplexity The method 'moveDownEntryOrder(int, Entry)' has a cyclomatic complexity of 16. 3 139234
ForLoopCanBeForeach This for loop can be replaced by a foreach loop 3 166199
CyclomaticComplexity The method 'moveUpEntryOrder(int, Entry)' has a cyclomatic complexity of 13. 3 244318
ForLoopCanBeForeach This for loop can be replaced by a foreach loop 3 269299
CyclomaticComplexity The method 'getHtmlEntry(Map, int, StringBuilder, Locale, boolean, AppointmentDTO)' has a cyclomatic complexity of 13. 3 509571
LinguisticNaming Linguistics Antipattern - The getter 'getHtmlEntry' should not return void linguistically 3 509571
NPathComplexity The method 'getHtmlEntry(Map, int, StringBuilder, Locale, boolean, AppointmentDTO)' has an NPath complexity of 210 3 509571
CyclomaticComplexity The method 'getResponseEntry(HttpServletRequest, int, List, boolean, Locale, AppointmentDTO)' has a cyclomatic complexity of 11. 3 611683
AvoidReassigningLoopVariables Avoid reassigning the loop control variable 'field' 3 621
ConfusingTernary Avoid if (x != y) ..; else ..; 3 642656

fr/paris/lutece/plugins/appointment/service/FormMessageService.java

Rule Violation Priority Line
FieldDeclarationsShouldBeAtStartOfClass Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. 3 61
FieldDeclarationsShouldBeAtStartOfClass Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. 3 63
FieldDeclarationsShouldBeAtStartOfClass Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. 3 64
FieldDeclarationsShouldBeAtStartOfClass Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. 3 65
FieldDeclarationsShouldBeAtStartOfClass Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. 3 66
FieldDeclarationsShouldBeAtStartOfClass Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. 3 67
FieldDeclarationsShouldBeAtStartOfClass Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. 3 68
FieldDeclarationsShouldBeAtStartOfClass Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. 3 69
FieldDeclarationsShouldBeAtStartOfClass Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. 3 70
FieldDeclarationsShouldBeAtStartOfClass Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. 3 71
FieldDeclarationsShouldBeAtStartOfClass Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. 3 72
FieldDeclarationsShouldBeAtStartOfClass Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. 3 73
FieldDeclarationsShouldBeAtStartOfClass Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. 3 74
FieldDeclarationsShouldBeAtStartOfClass Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. 3 75
FieldDeclarationsShouldBeAtStartOfClass Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. 3 76
FieldDeclarationsShouldBeAtStartOfClass Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. 3 77
FieldDeclarationsShouldBeAtStartOfClass Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. 3 78
FieldDeclarationsShouldBeAtStartOfClass Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. 3 79

fr/paris/lutece/plugins/appointment/service/FormService.java

Rule Violation Priority Line
ExcessiveImports A high number of imports can indicate a high degree of coupling within an object. 3 34809
GodClass Possible God Class (WMC=72, ATFD=155, TCC=0.000%) 3 86809
TooManyMethods This class has too many methods, consider refactoring it. 3 87809
NcssCount The method 'copyForm(int, String)' has a NCSS line count of 88. 3 105226
ExcessiveMethodLength Avoid really long methods. 3 105226
ConfusingTernary Avoid if (x != y) ..; else ..; 3 258
ConfusingTernary Avoid if (x != y) ..; else ..; 3 259
AvoidReassigningParameters Avoid reassigning parameters such as 'reservationRule' 2 411
CyclomaticComplexity The method 'fillAppointmentFormWithReservationRulePart(AppointmentFormDTO, ReservationRule)' has a cyclomatic complexity of 10. 3 468515
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 3 746

fr/paris/lutece/plugins/appointment/service/ReservationRuleService.java

Rule Violation Priority Line
TooManyMethods This class has too many methods, consider refactoring it. 3 67426
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 3 154
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 3 367

fr/paris/lutece/plugins/appointment/service/SlotDaemon.java

Rule Violation Priority Line
CommentRequired Header comments are required 3 3849

fr/paris/lutece/plugins/appointment/service/SlotSafeService.java

Rule Violation Priority Line
ExcessiveImports A high number of imports can indicate a high degree of coupling within an object. 3 341171
ExcessiveClassLength Avoid really long classes. 3 861171
CyclomaticComplexity The class 'SlotSafeService' has a total cyclomatic complexity of 116 (highest 20). 3 861171
GodClass Possible God Class (WMC=116, ATFD=232, TCC=1.709%) 3 861171
CommentRequired Header comments are required 3 861171
TooManyMethods This class has too many methods, consider refactoring it. 3 871171
FieldNamingConventions The constant name '_listSlot' doesn't match '[A-Z][A-Z_0-9]*' 1 89
FieldNamingConventions The constant name '_lockFormId' doesn't match '[A-Z][A-Z_0-9]*' 1 90
ConfusingTernary Avoid if (x != y) ..; else ..; 3 166175
ConfusingTernary Avoid if (x != y) ..; else ..; 3 208219
NPathComplexity The method 'saveAppointment(AppointmentDTO, HttpServletRequest)' has an NPath complexity of 216 3 336406
CyclomaticComplexity The method 'saveAppointment(AppointmentDTO, HttpServletRequest)' has a cyclomatic complexity of 16. 3 336406
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 3 338
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 3 339
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 3 340
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 3 342
ControlStatementBraces This statement should have braces 3 354
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 3 393
ConfusingTernary Avoid if (x != y) ..; else ..; 3 468
DefaultPackage Use explicit scoping instead of the default package private level 3 485526
CommentDefaultAccessModifier To avoid mistakes add a comment at the beginning of the updateRemaningPlacesWithAppointmentMovedDeletedOrCanceled method if you want a default access modifier 3 485526
DefaultPackage Use explicit scoping instead of the default package private level 3 537560
CommentDefaultAccessModifier To avoid mistakes add a comment at the beginning of the updateRemaningPlacesWithAppointmentReactivated method if you want a default access modifier 3 537560
ConfusingTernary Avoid if (x != y) ..; else ..; 3 582591
ConfusingTernary Avoid if (x != y) ..; else ..; 3 638657
CyclomaticComplexity The method 'updateSlotWithShift(Slot, LocalTime)' has a cyclomatic complexity of 11. 3 683824
NcssCount The method 'updateSlotWithShift(Slot, LocalTime)' has a NCSS line count of 65. 3 683824
ExcessiveMethodLength Avoid really long methods. 3 683824
ConfusingTernary Avoid if (x != y) ..; else ..; 3 727734
ConfusingTernary Avoid if (x != y) ..; else ..; 3 844852
ConfusingTernary Avoid if (x != y) ..; else ..; 3 894921
ShortVariable Avoid variables with short names like it 3 982
NPathComplexity The method 'saveSlots(AppointmentDTO, List, HttpServletRequest)' has an NPath complexity of 441 3 10051084
CyclomaticComplexity The method 'saveSlots(AppointmentDTO, List, HttpServletRequest)' has a cyclomatic complexity of 20. 3 10051084
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 3 1009
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 3 1010

fr/paris/lutece/plugins/appointment/service/SlotService.java

Rule Violation Priority Line
TooManyMethods This class has too many methods, consider refactoring it. 3 62518
LooseCoupling Avoid using implementation types like 'HashMap'; use the interface instead 3 141
LooseCoupling Avoid using implementation types like 'HashMap'; use the interface instead 3 222
AvoidLiteralsInIfCondition Avoid using Literals in Conditional Statements 3 286

fr/paris/lutece/plugins/appointment/service/TimeSlotService.java

Rule Violation Priority Line
TooManyMethods This class has too many methods, consider refactoring it. 3 64576
ConfusingTernary Avoid if (x != y) ..; else ..; 3 217224
ExcessiveMethodLength Avoid really long methods. 3 253376

fr/paris/lutece/plugins/appointment/service/Utilities.java

Rule Violation Priority Line
ClassNamingConventions The utility class name 'Utilities' doesn't match '[A-Z][a-zA-Z0-9]+(Utils?|Helper|Home|Service)' 1 48128
NonThreadSafeSingleton Singleton is not thread safe 3 6669
DefaultPackage Use explicit scoping instead of the default package private level 3 7679
CommentDefaultAccessModifier To avoid mistakes add a comment at the beginning of the resetFormatter method if you want a default access modifier 3 7679
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 3 78

fr/paris/lutece/plugins/appointment/service/WeekDefinitionService.java

Rule Violation Priority Line
GodClass Possible God Class (WMC=60, ATFD=45, TCC=0.000%) 3 63568
TooManyMethods This class has too many methods, consider refactoring it. 3 64568
LooseCoupling Avoid using implementation types like 'HashMap'; use the interface instead 3 301
CyclomaticComplexity The method 'assignWeekDefinition(int, WeekDefinition)' has a cyclomatic complexity of 11. 3 470534
UnusedFormalParameter Avoid unused method parameters such as 'nIdForm'. 3 536
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 3 559

fr/paris/lutece/plugins/appointment/service/WorkingDayService.java

Rule Violation Priority Line
LooseCoupling Avoid using implementation types like 'HashSet'; use the interface instead 3 341

fr/paris/lutece/plugins/appointment/service/addon/AppointmentAddOnManager.java

Rule Violation Priority Line
ClassNamingConventions The utility class name 'AppointmentAddOnManager' doesn't match '[A-Z][a-zA-Z0-9]+(Utils?|Helper|Home|Service)' 1 4777

fr/paris/lutece/plugins/appointment/service/anonymization/FormIdAnonymizationService.java

Rule Violation Priority Line
CommentRequired Header comments are required 3 715

fr/paris/lutece/plugins/appointment/service/entrytype/EntryTypeImage.java

Rule Violation Priority Line
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 3 107

fr/paris/lutece/plugins/appointment/service/export/AppointmentExportService.java

Rule Violation Priority Line
ExcessiveImports A high number of imports can indicate a high degree of coupling within an object. 3 34380
CommentRequired Header comments are required 3 81380
GodClass Possible God Class (WMC=51, ATFD=49, TCC=0.000%) 3 81380
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 3 141
UnnecessaryModifier Unnecessary modifier 'final' on method 'writeWorkbook': private methods cannot be overridden 3 151191
ShortVariable Avoid variables with short names like os 3 154
UnnecessaryModifier Unnecessary modifier 'final' on method 'createHeaderContent': private methods cannot be overridden 3 193209
UnnecessaryModifier Unnecessary modifier 'final' on method 'createLineContent': private methods cannot be overridden 3 211233
CyclomaticComplexity The method 'addDefaultColumnValues(AppointmentDTO, Form, List, List, StateService, Locale)' has a cyclomatic complexity of 16. 3 235300
NPathComplexity The method 'addDefaultColumnValues(AppointmentDTO, Form, List, List, StateService, Locale)' has an NPath complexity of 24576 3 235300
UnnecessaryModifier Unnecessary modifier 'final' on method 'addDefaultColumnValues': private methods cannot be overridden 3 235300
UnnecessaryModifier Unnecessary modifier 'final' on method 'getEntryValue': private methods cannot be overridden 3 327352
ShortVariable Avoid variables with short names like e 3 327
ShortVariable Avoid variables with short names like f 3 338
InefficientStringBuffering Avoid concatenating nonliterals in a StringBuffer/StringBuilder constructor or append(). 3 347
CommentRequired Public method and constructor comments are required 3 354362
CommentRequired Public method and constructor comments are required 3 364379

fr/paris/lutece/plugins/appointment/service/export/ExcelAppointmentGenerator.java

Rule Violation Priority Line
CommentRequired Header comments are required 3 51111
FieldNamingConventions The final field name '_fileName' doesn't match '[a-z][a-zA-Z0-9]*' 1 60
FieldNamingConventions The final field name '_fileDescription' doesn't match '[a-z][a-zA-Z0-9]*' 1 61
FieldNamingConventions The final field name '_defaultColumnList' doesn't match '[a-z][a-zA-Z0-9]*' 1 62
FieldNamingConventions The final field name '_locale' doesn't match '[a-z][a-zA-Z0-9]*' 1 63
FieldNamingConventions The final field name '_listAppointmentsDTO' doesn't match '[a-z][a-zA-Z0-9]*' 1 64
FieldNamingConventions The final field name '_entryList' doesn't match '[a-z][a-zA-Z0-9]*' 1 65
CommentRequired Public method and constructor comments are required 3 6777
SimpleDateFormatNeedsLocale When instantiating a SimpleDateFormat object, specify a Locale 3 70

fr/paris/lutece/plugins/appointment/service/listeners/AppointmentListenerManager.java

Rule Violation Priority Line
ClassNamingConventions The utility class name 'AppointmentListenerManager' doesn't match '[A-Z][a-zA-Z0-9]+(Utils?|Helper|Home|Service)' 1 51174

fr/paris/lutece/plugins/appointment/service/listeners/AppointmentSessionListener.java

Rule Violation Priority Line
ShortVariable Avoid variables with short names like se 3 51
ShortVariable Avoid variables with short names like se 3 60

fr/paris/lutece/plugins/appointment/service/listeners/FormListenerManager.java

Rule Violation Priority Line
ClassNamingConventions The utility class name 'FormListenerManager' doesn't match '[A-Z][a-zA-Z0-9]+(Utils?|Helper|Home|Service)' 1 3998
CommentRequired Header comments are required 3 3998

fr/paris/lutece/plugins/appointment/service/listeners/SlotListenerManager.java

Rule Violation Priority Line
ClassNamingConventions The utility class name 'SlotListenerManager' doesn't match '[A-Z][a-zA-Z0-9]+(Utils?|Helper|Home|Service)' 1 48126

fr/paris/lutece/plugins/appointment/service/listeners/WeekDefinitionManagerListener.java

Rule Violation Priority Line
CommentRequired Header comments are required 3 42103
ClassNamingConventions The utility class name 'WeekDefinitionManagerListener' doesn't match '[A-Z][a-zA-Z0-9]+(Utils?|Helper|Home|Service)' 1 42103

fr/paris/lutece/plugins/appointment/service/lock/SlotEditTask.java

Rule Violation Priority Line
DataClass The class 'SlotEditTask' is suspected to be a Data Class (WOC=0.000%, NOPA=0, NOAM=4, WMC=5) 3 47113
CommentRequired Public method and constructor comments are required 3 6064

fr/paris/lutece/plugins/appointment/service/lock/TimerForLockOnSlot.java

Rule Violation Priority Line
CommentRequired Header comments are required 3 3849
UnnecessaryConstructor Avoid unnecessary constructors - the compiler will generate these for you 3 4447

fr/paris/lutece/plugins/appointment/web/AbstractAppointmentFormAndSlotJspBean.java

Rule Violation Priority Line
CommentRequired Header comments are required 3 67364
FieldNamingConventions The constant name '_captchaSecurityService' doesn't match '[A-Z][A-Z_0-9]*' 1 113

fr/paris/lutece/plugins/appointment/web/AppointmentAnnualCalendarJspBean.java

Rule Violation Priority Line
ExcessiveImports A high number of imports can indicate a high degree of coupling within an object. 3 34512
UnnecessaryAnnotationValueElement Avoid the use of value in annotations when its the only element 3 147
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 3 192
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 3 193
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 3 194
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 3 254
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 3 255
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 3 256
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 3 313
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 3 315
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 3 316
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 3 317
AvoidReassigningLoopVariables Avoid reassigning the loop control variable 'slotImpacted' 3 402
AppendCharacterWithChar Avoid appending characters as strings in StringBuffer.append. 3 438

fr/paris/lutece/plugins/appointment/web/AppointmentApp.java

Rule Violation Priority Line
ExcessiveImports A high number of imports can indicate a high degree of coupling within an object. 3 341840
UnusedImports Avoid unused imports such as 'fr.paris.lutece.portal.service.datastore.DatastoreService' 4 101
ExcessiveClassLength Avoid really long classes. 3 1321840
SingularField Perhaps '_strNbPlacesToTakeLength' could be replaced by a local variable. 3 297
NPathComplexity The method 'getViewAppointmentCalendar(HttpServletRequest)' has an NPath complexity of 116161920 3 311591
CyclomaticComplexity The method 'getViewAppointmentCalendar(HttpServletRequest)' has a cyclomatic complexity of 38. 3 311591
NcssCount The method 'getViewAppointmentCalendar(HttpServletRequest)' has a NCSS line count of 158. 3 311591
ExcessiveMethodLength Avoid really long methods. 3 311591
AvoidSynchronizedAtMethodLevel Use block level rather than method level synchronization 3 311591
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 3 330
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 3 411
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 3 413
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 3 416417
ConfusingTernary Avoid if (x != y) ..; else ..; 3 464475
CyclomaticComplexity The method 'getViewAppointmentForm(HttpServletRequest)' has a cyclomatic complexity of 38. 3 602829
ExcessiveMethodLength Avoid really long methods. 3 602829
NPathComplexity The method 'getViewAppointmentForm(HttpServletRequest)' has an NPath complexity of 76800000 3 602829
AvoidSynchronizedAtMethodLevel Use block level rather than method level synchronization 3 602829
NcssCount The method 'getViewAppointmentForm(HttpServletRequest)' has a NCSS line count of 124. 3 602829
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 3 604
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 3 605
LinguisticNaming Linguistics Antipattern - The variable 'isModification' indicates linguistically it is a boolean, but it is 'String' 3 653
ConfusingTernary Avoid if (x != y) ..; else ..; 3 656689
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 3 665
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 3 700
ConfusingTernary Avoid if (x != y) ..; else ..; 3 708770
AvoidReassigningLoopVariables Avoid reassigning the loop control variable 'slot' 3 721
AvoidReassigningLoopVariables Avoid reassigning the loop control variable 'slot' 3 725
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 3 732
ConfusingTernary Avoid if (x != y) ..; else ..; 3 796804
ExcessiveMethodLength Avoid really long methods. 3 842945
CyclomaticComplexity The method 'doValidateForm(HttpServletRequest)' has a cyclomatic complexity of 16. 3 842945
AvoidSynchronizedAtMethodLevel Use block level rather than method level synchronization 3 842945
NPathComplexity The method 'doValidateForm(HttpServletRequest)' has an NPath complexity of 3456 3 842945
NcssCount The method 'doValidateForm(HttpServletRequest)' has a NCSS line count of 69. 3 842945
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 3 845
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 3 850
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 3 851
ShortVariable Avoid variables with short names like lf 3 894
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 3 931
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 3 936
AvoidSynchronizedAtMethodLevel Use block level rather than method level synchronization 3 9571008
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 3 961
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 3 965
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 3 973
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 3 974
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 3 977
ShortVariable Avoid variables with short names like t 3 1003
AvoidSynchronizedAtMethodLevel Use block level rather than method level synchronization 3 10201099
CyclomaticComplexity The method 'doMakeAppointment(HttpServletRequest)' has a cyclomatic complexity of 13. 3 10201099
NPathComplexity The method 'doMakeAppointment(HttpServletRequest)' has an NPath complexity of 512 3 10201099
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 3 1026
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 3 1027
AvoidSynchronizedAtMethodLevel Use block level rather than method level synchronization 3 11091141
AvoidLiteralsInIfCondition Avoid using Literals in Conditional Statements 3 1120
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 3 1129
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 3 1138
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 3 1139
CyclomaticComplexity The method 'getViewChangeDateAppointment(HttpServletRequest)' has a cyclomatic complexity of 16. 3 11541242
AvoidSynchronizedAtMethodLevel Use block level rather than method level synchronization 3 11541242
NPathComplexity The method 'getViewChangeDateAppointment(HttpServletRequest)' has an NPath complexity of 2160 3 11541242
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 3 1165
AvoidReassigningLoopVariables Avoid reassigning the loop control variable 'slot' 3 1192
AvoidReassigningLoopVariables Avoid reassigning the loop control variable 'slot' 3 1198
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 3 1238
AvoidSynchronizedAtMethodLevel Use block level rather than method level synchronization 3 12521263
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 3 1255
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 3 1256
AvoidSynchronizedAtMethodLevel Use block level rather than method level synchronization 3 12721319
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 3 1280
ConfusingTernary Avoid if (x != y) ..; else ..; 3 12821313
AvoidSynchronizedAtMethodLevel Use block level rather than method level synchronization 3 13281374
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 3 1348
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 3 1359
AvoidSynchronizedAtMethodLevel Use block level rather than method level synchronization 3 13841400
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 3 1390
AvoidSynchronizedAtMethodLevel Use block level rather than method level synchronization 3 14121423
AvoidReassigningParameters Avoid reassigning parameters such as 'model' 2 1436
AvoidReassigningParameters Avoid reassigning parameters such as 'model' 2 1481
AvoidSynchronizedAtMethodLevel Use block level rather than method level synchronization 3 15261565
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 3 1546
CyclomaticComplexity The method 'doProcessWorkflowAction(HttpServletRequest)' has a cyclomatic complexity of 15. 3 15751661
AvoidSynchronizedAtMethodLevel Use block level rather than method level synchronization 3 15751661
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 3 1582
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 3 1653
CyclomaticComplexity The method 'checkMyLuteceAuthentication(AppointmentFormDTO, HttpServletRequest)' has a cyclomatic complexity of 14. 3 17731812

fr/paris/lutece/plugins/appointment/web/AppointmentCategoryJspBean.java

Rule Violation Priority Line
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 3 124

fr/paris/lutece/plugins/appointment/web/AppointmentFormDashboardComponent.java

Rule Violation Priority Line
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 3 98

fr/paris/lutece/plugins/appointment/web/AppointmentFormEntryJspBean.java

Rule Violation Priority Line
ExcessiveImports A high number of imports can indicate a high degree of coupling within an object. 3 34774
TooManyMethods This class has too many methods, consider refactoring it. 3 88774
ImmutableField Private field '_entryService' could be made final; it is only initialized in the declaration or constructor. 3 151
UnnecessaryAnnotationValueElement Avoid the use of value in annotations when its the only element 3 187
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 3 217
CyclomaticComplexity The method 'doCreateEntry(HttpServletRequest)' has a cyclomatic complexity of 13. 3 240292
NPathComplexity The method 'doCreateEntry(HttpServletRequest)' has an NPath complexity of 234 3 240292
AvoidReassigningLoopVariables Avoid reassigning the loop control variable 'field' 3 317
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 3 322
CyclomaticComplexity The method 'doModifyEntry(HttpServletRequest)' has a cyclomatic complexity of 11. 3 351405
AvoidDeeplyNestedIfStmts Deeply nested if..then statements are hard to read 3 365368
AvoidDeeplyNestedIfStmts Deeply nested if..then statements are hard to read 3 376385
ConfusingTernary Avoid if (x != y) ..; else ..; 3 376385
ConfusingTernary Avoid if (x != y) ..; else ..; 3 394401
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 3 450
CyclomaticComplexity The method 'doChangeOrderEntry(HttpServletRequest)' has a cyclomatic complexity of 11. 3 602652

fr/paris/lutece/plugins/appointment/web/AppointmentFormFieldJspBean.java

Rule Violation Priority Line
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 3 136
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 3 456
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 3 457
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 3 458

fr/paris/lutece/plugins/appointment/web/AppointmentFormJspBean.java

Rule Violation Priority Line
ExcessiveImports A high number of imports can indicate a high degree of coupling within an object. 3 34814
ImmutableField Private field '_nDefaultItemsPerPage' could be made final; it is only initialized in the declaration or constructor. 3 188
CallSuperInConstructor It is a good practice to call super() in a constructor 3 196199
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 3 212
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 3 367
NPathComplexity The method 'doModifyAppointmentForm(HttpServletRequest)' has an NPath complexity of 384 3 448503
CyclomaticComplexity The method 'doModifyAppointmentForm(HttpServletRequest)' has a cyclomatic complexity of 13. 3 448503
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 3 499
CyclomaticComplexity The method 'doChangeFormActivation(HttpServletRequest)' has a cyclomatic complexity of 11. 3 515559
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 3 617
CyclomaticComplexity The method 'importClosingDayFile(MultipartHttpServletRequest, int)' has a cyclomatic complexity of 11. 3 722793

fr/paris/lutece/plugins/appointment/web/AppointmentJspBean.java

Rule Violation Priority Line
ExcessiveImports A high number of imports can indicate a high degree of coupling within an object. 3 341786
ExcessiveClassLength Avoid really long classes. 3 1491786
TooManyMethods This class has too many methods, consider refactoring it. 3 1501786
ImmutableField Private field '_nDefaultItemsPerPage' could be made final; it is only initialized in the declaration or constructor. 3 319
FieldNamingConventions The field name 'listFormErrors' doesn't match '_[a-z][a-zA-Z0-9]*' 1 326
CommentDefaultAccessModifier To avoid mistakes add a comment at the beginning of the listFormErrors field if you want a default access modifier 3 326
DefaultPackage Use explicit scoping instead of the default package private level 3 326
DefaultPackage Use explicit scoping instead of the default package private level 3 327
CommentDefaultAccessModifier To avoid mistakes add a comment at the beginning of the _moduleAppointmentDesk field if you want a default access modifier 3 327
CyclomaticComplexity The method 'getViewCalendarManageAppointments(HttpServletRequest)' has a cyclomatic complexity of 24. 3 338505
AvoidSynchronizedAtMethodLevel Use block level rather than method level synchronization 3 338505
NcssCount The method 'getViewCalendarManageAppointments(HttpServletRequest)' has a NCSS line count of 94. 3 338505
ExcessiveMethodLength Avoid really long methods. 3 338505
NPathComplexity The method 'getViewCalendarManageAppointments(HttpServletRequest)' has an NPath complexity of 62400 3 338505
ConfusingTernary Avoid if (x != y) ..; else ..; 3 449458
UnnecessaryAnnotationValueElement Avoid the use of value in annotations when its the only element 3 515
ExcessiveMethodLength Avoid really long methods. 3 516649
NcssCount The method 'getManageAppointments(HttpServletRequest)' has a NCSS line count of 86. 3 516649
NPathComplexity The method 'getManageAppointments(HttpServletRequest)' has an NPath complexity of 10080 3 516649
CyclomaticComplexity The method 'getManageAppointments(HttpServletRequest)' has a cyclomatic complexity of 21. 3 516649
AvoidSynchronizedAtMethodLevel Use block level rather than method level synchronization 3 516649
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 3 531
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 3 532
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 3 533
ConfusingTernary Avoid if (x != y) ..; else ..; 3 537560
AvoidSynchronizedAtMethodLevel Use block level rather than method level synchronization 3 659666
AvoidSynchronizedAtMethodLevel Use block level rather than method level synchronization 3 679693
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 3 681
AvoidSynchronizedAtMethodLevel Use block level rather than method level synchronization 3 703710
AvoidSynchronizedAtMethodLevel Use block level rather than method level synchronization 3 722743
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 3 724
AvoidSynchronizedAtMethodLevel Use block level rather than method level synchronization 3 755827
NPathComplexity The method 'getViewAppointment(HttpServletRequest)' has an NPath complexity of 240 3 755827
CyclomaticComplexity The method 'getViewAppointment(HttpServletRequest)' has a cyclomatic complexity of 12. 3 755827
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 3 760
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 3 761
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 3 763
AvoidSynchronizedAtMethodLevel Use block level rather than method level synchronization 3 841879
NcssCount The method 'getViewCreateAppointment(HttpServletRequest)' has a NCSS line count of 90. 3 8911068
CyclomaticComplexity The method 'getViewCreateAppointment(HttpServletRequest)' has a cyclomatic complexity of 29. 3 8911068
ExcessiveMethodLength Avoid really long methods. 3 8911068
AvoidSynchronizedAtMethodLevel Use block level rather than method level synchronization 3 8911068
NPathComplexity The method 'getViewCreateAppointment(HttpServletRequest)' has an NPath complexity of 201480 3 8911068
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 3 895
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 3 897
LinguisticNaming Linguistics Antipattern - The variable 'isModification' indicates linguistically it is a boolean, but it is 'String' 3 906
ConfusingTernary Avoid if (x != y) ..; else ..; 3 909951
ConfusingTernary Avoid if (x != y) ..; else ..; 3 958972
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 3 965
AvoidReassigningLoopVariables Avoid reassigning the loop control variable 'slot' 3 991
AvoidReassigningLoopVariables Avoid reassigning the loop control variable 'slot' 3 997
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 3 1005
AvoidSynchronizedAtMethodLevel Use block level rather than method level synchronization 3 10801155
CyclomaticComplexity The method 'doValidateForm(HttpServletRequest)' has a cyclomatic complexity of 12. 3 10801155
NPathComplexity The method 'doValidateForm(HttpServletRequest)' has an NPath complexity of 432 3 10801155
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 3 1083
ShortVariable Avoid variables with short names like lf 3 1121
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 3 1153
CyclomaticComplexity The method 'getViewChangeDateAppointment(HttpServletRequest)' has a cyclomatic complexity of 14. 3 11661256
AvoidSynchronizedAtMethodLevel Use block level rather than method level synchronization 3 11661256
NPathComplexity The method 'getViewChangeDateAppointment(HttpServletRequest)' has an NPath complexity of 612 3 11661256
AvoidReassigningLoopVariables Avoid reassigning the loop control variable 'slot' 3 1205
AvoidReassigningLoopVariables Avoid reassigning the loop control variable 'slot' 3 1209
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 3 1252
AvoidSynchronizedAtMethodLevel Use block level rather than method level synchronization 3 12661284
AvoidSynchronizedAtMethodLevel Use block level rather than method level synchronization 3 12961351
CyclomaticComplexity The method 'doMakeAppointment(HttpServletRequest)' has a cyclomatic complexity of 11. 3 12961351
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 3 1298
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 3 1346
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 3 1349
AvoidSynchronizedAtMethodLevel Use block level rather than method level synchronization 3 13641412
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 3 1367
ShortVariable Avoid variables with short names like os 3 1399
AvoidSynchronizedAtMethodLevel Use block level rather than method level synchronization 3 14251461
ShortVariable Avoid variables with short names like os 3 1448
CallSuperInConstructor It is a good practice to call super() in a constructor 3 14661469
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 3 1473
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 3 1474
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 3 1475
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 3 1476
CyclomaticComplexity The method 'orderList(List)' has a cyclomatic complexity of 11. 3 15011546
MissingBreakInSwitch A switch statement does not contain a break 3 15101539
AvoidSynchronizedAtMethodLevel Use block level rather than method level synchronization 3 15781616
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 3 1598
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 3 1607
AvoidSynchronizedAtMethodLevel Use block level rather than method level synchronization 3 16261693
CyclomaticComplexity The method 'doProcessWorkflowAction(HttpServletRequest)' has a cyclomatic complexity of 14. 3 16261693
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 3 1682
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 3 1686
CyclomaticComplexity The method 'doChangeAppointmentStatus(HttpServletRequest)' has a cyclomatic complexity of 11. 3 17051745
AvoidSynchronizedAtMethodLevel Use block level rather than method level synchronization 3 17051745
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 3 1712

fr/paris/lutece/plugins/appointment/web/CalendarTemplateJspBean.java

Rule Violation Priority Line
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 3 159
CyclomaticComplexity The method 'getCreateModifyTemplate(HttpServletRequest)' has a cyclomatic complexity of 10. 3 191249

fr/paris/lutece/plugins/appointment/web/CommentJspBean.java

Rule Violation Priority Line
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 3 147
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 3 166
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 3 196
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 3 198
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 3 199
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 3 200
ConfusingTernary Avoid if (x != y) ..; else ..; 3 228237
CyclomaticComplexity The method 'doModifyComment(HttpServletRequest)' has a cyclomatic complexity of 11. 3 287337
NPathComplexity The method 'doModifyComment(HttpServletRequest)' has an NPath complexity of 216 3 287337
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 3 291
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 3 292
ConfusingTernary Avoid if (x != y) ..; else ..; 3 320328
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 3 383

fr/paris/lutece/plugins/appointment/web/CommentNotificationJspBean.java

Rule Violation Priority Line
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 3 103
UnnecessaryAnnotationValueElement Avoid the use of value in annotations when its the only element 3 118

fr/paris/lutece/plugins/appointment/web/SpecificWeekJspBean.java

Rule Violation Priority Line
ExcessiveImports A high number of imports can indicate a high degree of coupling within an object. 3 34736
CyclomaticComplexity The method 'getViewManageSpecificWeek(HttpServletRequest)' has a cyclomatic complexity of 10. 3 180243
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 3 182
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 3 184
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 3 257
NPathComplexity The method 'doModifySlot(HttpServletRequest)' has an NPath complexity of 2898 3 299387
CyclomaticComplexity The method 'doModifySlot(HttpServletRequest)' has a cyclomatic complexity of 16. 3 299387
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 3 301
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 3 302
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 3 303
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 3 304
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 3 305
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 3 306
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 3 308
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 3 383
CyclomaticComplexity The method 'doModifyListSlots(HttpServletRequest)' has a cyclomatic complexity of 16. 3 398514
ExcessiveMethodLength Avoid really long methods. 3 398514
NPathComplexity The method 'doModifyListSlots(HttpServletRequest)' has an NPath complexity of 1440 3 398514
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 3 400
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 3 401
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 3 402
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 3 403
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 3 406
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 3 407
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 3 408
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 3 409
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 3 411
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 3 412
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 3 413
GuardLogStatement Logger calls should be surrounded by log level guards. 2 450
ConfusingTernary Avoid if (x != y) ..; else ..; 3 465478
ConfusingTernary Avoid if (x != y) ..; else ..; 3 499509
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 3 510
CyclomaticComplexity The method 'updateListSlots(List, int, int, boolean, boolean, boolean, LocalTime)' has a cyclomatic complexity of 27. 3 597705
ExcessiveMethodLength Avoid really long methods. 3 597705
NPathComplexity The method 'updateListSlots(List, int, int, boolean, boolean, boolean, LocalTime)' has an NPath complexity of 34056 3 597705
ConfusingTernary Avoid if (x != y) ..; else ..; 3 630
AppendCharacterWithChar Avoid appending characters as strings in StringBuffer.append. 3 669
ControlStatementBraces This statement should have braces 3 692
ControlStatementBraces This statement should have braces 3 695

fr/paris/lutece/plugins/appointment/web/TypicalWeekJspBean.java

Rule Violation Priority Line
ExcessiveImports A high number of imports can indicate a high degree of coupling within an object. 3 341010
TooManyMethods This class has too many methods, consider refactoring it. 3 941010
UnnecessaryAnnotationValueElement Avoid the use of value in annotations when its the only element 3 180
CyclomaticComplexity The method 'getViewManageTypicalWeek(HttpServletRequest)' has a cyclomatic complexity of 11. 3 181249
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 3 183
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 3 184
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 3 186
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 3 187
ConfusingTernary Avoid if (x != y) ..; else ..; 3 200214
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 3 263
CyclomaticComplexity The method 'doModifyAdvancedParameters(HttpServletRequest)' has a cyclomatic complexity of 12. 3 293366
NPathComplexity The method 'doModifyAdvancedParameters(HttpServletRequest)' has an NPath complexity of 256 3 293366
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 3 302
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 3 303
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 3 433
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 3 470
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 3 471
NPathComplexity The method 'doModifyTimeSlot(HttpServletRequest)' has an NPath complexity of 6336 3 515635
ExcessiveMethodLength Avoid really long methods. 3 515635
NcssCount The method 'doModifyTimeSlot(HttpServletRequest)' has a NCSS line count of 69. 3 515635
CyclomaticComplexity The method 'doModifyTimeSlot(HttpServletRequest)' has a cyclomatic complexity of 18. 3 515635
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 3 518
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 3 520
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 3 534
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 3 535
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 3 536
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 3 537
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 3 538
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 3 539
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 3 540
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 3 573
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 3 608
ExcessiveMethodLength Avoid really long methods. 3 646820
NPathComplexity The method 'doModifyListTimeSlot(HttpServletRequest)' has an NPath complexity of 114048 3 646820
CyclomaticComplexity The method 'doModifyListTimeSlot(HttpServletRequest)' has a cyclomatic complexity of 25. 3 646820
NcssCount The method 'doModifyListTimeSlot(HttpServletRequest)' has a NCSS line count of 86. 3 646820
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 3 649
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 3 650
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 3 652
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 3 653
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 3 654
GuardLogStatement Logger calls should be surrounded by log level guards. 2 661
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 3 666
PositionLiteralsFirstInCaseInsensitiveComparisons Position literals first in String comparisons for EqualsIgnoreCase 3 689
PositionLiteralsFirstInCaseInsensitiveComparisons Position literals first in String comparisons for EqualsIgnoreCase 3 689
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 3 695
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 3 795
AvoidReassigningLoopVariables Avoid reassigning the loop control variable 'slotImpacted' 3 880
AvoidReassigningParameters Avoid reassigning parameters such as 'nMaxCapacity' 2 902
CyclomaticComplexity The method 'manageTheSlotsAndAppointmentsImpacted(List, List, int, int, boolean, boolean)' has a cyclomatic complexity of 10. 3 902959
ConfusingTernary Avoid if (x != y) ..; else ..; 3 924936
AvoidReassigningLoopVariables Avoid reassigning the loop control variable 'slotImpacted' 3 943
AvoidReassigningParameters Avoid reassigning parameters such as 'slot' 2 975
AvoidReassigningParameters Avoid reassigning parameters such as 'nNewNbMaxCapacity' 2 975

fr/paris/lutece/plugins/appointment/web/dto/AppointmentDTO.java

Rule Violation Priority Line
TooManyFields Too many fields 3 57519
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 3 132
CommentRequired Public method and constructor comments are required 3 429432
BooleanGetMethodName A getX() method which returns a boolean should be named isX() 4 439442
BooleanGetMethodName A getX() method which returns a boolean should be named isX() 4 460463

fr/paris/lutece/plugins/appointment/web/dto/AppointmentFilterDTO.java

Rule Violation Priority Line
CommentRequired Header comments are required 3 42301
ConfusingTernary Avoid if (x != y) ..; else ..; 3 121128
ConfusingTernary Avoid if (x != y) ..; else ..; 3 139146
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 3 145
ConfusingTernary Avoid if (x != y) ..; else ..; 3 156163
ConfusingTernary Avoid if (x != y) ..; else ..; 3 175182
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 3 181

fr/paris/lutece/plugins/appointment/web/dto/AppointmentFormDTO.java

Rule Violation Priority Line
ExcessivePublicCount This class has a bunch of public methods and attributes 3 341169
ExcessiveClassLength Avoid really long classes. 3 541169
TooManyFields Too many fields 3 541169
CyclomaticComplexity The class 'AppointmentFormDTO' has a total cyclomatic complexity of 87 (highest 2). 3 541169
AvoidDuplicateLiterals The String literal "#i18n{portal.validation.message.notEmpty}" appears 7 times in this file; the first occurrence is on line 97 3 97
ConfusingTernary Avoid if (x != y) ..; else ..; 3 355362
ConfusingTernary Avoid if (x != y) ..; else ..; 3 373380
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 3 379
CommentRequired Public method and constructor comments are required 3 478481
BooleanGetMethodName A getX() method which returns a boolean should be named isX() 4 488491
BooleanGetMethodName A getX() method which returns a boolean should be named isX() 4 509512
BooleanGetMethodName A getX() method which returns a boolean should be named isX() 4 530533
BooleanGetMethodName A getX() method which returns a boolean should be named isX() 4 551554
BooleanGetMethodName A getX() method which returns a boolean should be named isX() 4 572575
BooleanGetMethodName A getX() method which returns a boolean should be named isX() 4 593596
BooleanGetMethodName A getX() method which returns a boolean should be named isX() 4 614617
ConfusingTernary Avoid if (x != y) ..; else ..; 3 637644
ConfusingTernary Avoid if (x != y) ..; else ..; 3 655662
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 3 661
ConfusingTernary Avoid if (x != y) ..; else ..; 3 672679
ConfusingTernary Avoid if (x != y) ..; else ..; 3 690697
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 3 696
BooleanGetMethodName A getX() method which returns a boolean should be named isX() 4 705708
BooleanGetMethodName A getX() method which returns a boolean should be named isX() 4 726729
BooleanGetMethodName A getX() method which returns a boolean should be named isX() 4 747750
BooleanGetMethodName A getX() method which returns a boolean should be named isX() 4 810813
BooleanGetMethodName A getX() method which returns a boolean should be named isX() 4 852855
BooleanGetMethodName A getX() method which returns a boolean should be named isX() 4 936939
BooleanGetMethodName A getX() method which returns a boolean should be named isX() 4 10551058
BooleanGetMethodName A getX() method which returns a boolean should be named isX() 4 10761079
CommentRequired Public method and constructor comments are required 3 11511153
CommentRequired Public method and constructor comments are required 3 11551157
CommentRequired Public method and constructor comments are required 3 11591162
CommentRequired Public method and constructor comments are required 3 11641167

fr/paris/lutece/plugins/appointment/web/dto/AppointmentPackageDTO.java

Rule Violation Priority Line
CommentRequired Header comments are required 3 4099
CommentRequired Public method and constructor comments are required 3 9598

fr/paris/lutece/plugins/appointment/web/dto/ReservationRuleDTO.java

Rule Violation Priority Line
AvoidDuplicateLiterals The String literal "#i18n{portal.validation.message.notEmpty}" appears 6 times in this file; the first occurrence is on line 82 3 82
BooleanGetMethodName A getX() method which returns a boolean should be named isX() 4 209212

fr/paris/lutece/plugins/appointment/web/dto/ResponseRecapDTO.java

Rule Violation Priority Line
ImmutableField Private field '_response' could be made final; it is only initialized in the declaration or constructor. 3 64
CallSuperInConstructor It is a good practice to call super() in a constructor 3 7275
CallSuperInConstructor It is a good practice to call super() in a constructor 3 8589
ShortVariable Avoid variables with short names like o 3 176
ShortVariable Avoid variables with short names like o 3 187

fr/paris/lutece/plugins/appointment/web/file/AppointmentFormIconService.java

Rule Violation Priority Line
ClassWithOnlyPrivateConstructorsShouldBeFinal A class which only has private constructors should be final 1 1496
AvoidSynchronizedAtMethodLevel Use block level rather than method level synchronization 3 3235
MissingOverride The method 'getResourceTypeId()' is missing an @Override annotation. 3 7982

fr/paris/lutece/plugins/appointment/web/portlet/AbstractPortletJspBean.java

Rule Violation Priority Line
CommentRequired Header comments are required 3 4377

fr/paris/lutece/plugins/appointment/web/portlet/AppointmentFormListPortletJspBean.java

Rule Violation Priority Line
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 3 65

fr/paris/lutece/plugins/appointment/web/portlet/AppointmentFormPortletJspBean.java

Rule Violation Priority Line
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 3 94
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 3 121
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 3 139

fr/paris/lutece/plugins/appointment/web/portlet/AppointmentPortletJspBean.java

Rule Violation Priority Line
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 3 65