The following document contains the results of PMD 6.13.0.
| Rule | Violation | Line |
|---|---|---|
| ClassNamingConventions | The utility class name 'LogUtilities' doesn't match '[A-Z][a-zA-Z0-9]+(Utils?|Helper|Home|Service)' | 42–67 |
| Rule | Violation | Line |
|---|---|---|
| FieldNamingConventions | The final field name '_executorService' doesn't match '[a-z][a-zA-Z0-9]*' | 51 |
| Rule | Violation | Line |
|---|---|---|
| ClassNamingConventions | The utility class name 'AppointmentUtilities' doesn't match '[A-Z][a-zA-Z0-9]+(Utils?|Helper|Home|Service)' | 101–1327 |
| FieldNamingConventions | The constant name '_secheduledExecutor' doesn't match '[A-Z][A-Z_0-9]*' | 123 |
| Rule | Violation | Line |
|---|---|---|
| ClassWithOnlyPrivateConstructorsShouldBeFinal | A class which only has private constructors should be final | 51–428 |
| Rule | Violation | Line |
|---|---|---|
| ClassWithOnlyPrivateConstructorsShouldBeFinal | A class which only has private constructors should be final | 60–264 |
| Rule | Violation | Line |
|---|---|---|
| FieldNamingConventions | The constant name '_listSlot' doesn't match '[A-Z][A-Z_0-9]*' | 89 |
| FieldNamingConventions | The constant name '_lockFormId' doesn't match '[A-Z][A-Z_0-9]*' | 90 |
| Rule | Violation | Line |
|---|---|---|
| ClassNamingConventions | The utility class name 'Utilities' doesn't match '[A-Z][a-zA-Z0-9]+(Utils?|Helper|Home|Service)' | 48–128 |
| Rule | Violation | Line |
|---|---|---|
| ClassNamingConventions | The utility class name 'AppointmentAddOnManager' doesn't match '[A-Z][a-zA-Z0-9]+(Utils?|Helper|Home|Service)' | 47–77 |
| Rule | Violation | Line |
|---|---|---|
| FieldNamingConventions | The final field name '_fileName' doesn't match '[a-z][a-zA-Z0-9]*' | 60 |
| FieldNamingConventions | The final field name '_fileDescription' doesn't match '[a-z][a-zA-Z0-9]*' | 61 |
| FieldNamingConventions | The final field name '_defaultColumnList' doesn't match '[a-z][a-zA-Z0-9]*' | 62 |
| FieldNamingConventions | The final field name '_locale' doesn't match '[a-z][a-zA-Z0-9]*' | 63 |
| FieldNamingConventions | The final field name '_listAppointmentsDTO' doesn't match '[a-z][a-zA-Z0-9]*' | 64 |
| FieldNamingConventions | The final field name '_entryList' doesn't match '[a-z][a-zA-Z0-9]*' | 65 |
| Rule | Violation | Line |
|---|---|---|
| ClassNamingConventions | The utility class name 'AppointmentListenerManager' doesn't match '[A-Z][a-zA-Z0-9]+(Utils?|Helper|Home|Service)' | 51–174 |
| Rule | Violation | Line |
|---|---|---|
| ClassNamingConventions | The utility class name 'FormListenerManager' doesn't match '[A-Z][a-zA-Z0-9]+(Utils?|Helper|Home|Service)' | 39–98 |
| Rule | Violation | Line |
|---|---|---|
| ClassNamingConventions | The utility class name 'SlotListenerManager' doesn't match '[A-Z][a-zA-Z0-9]+(Utils?|Helper|Home|Service)' | 48–126 |
| Rule | Violation | Line |
|---|---|---|
| ClassNamingConventions | The utility class name 'WeekDefinitionManagerListener' doesn't match '[A-Z][a-zA-Z0-9]+(Utils?|Helper|Home|Service)' | 42–103 |
| Rule | Violation | Line |
|---|---|---|
| FieldNamingConventions | The constant name '_captchaSecurityService' doesn't match '[A-Z][A-Z_0-9]*' | 113 |
| Rule | Violation | Line |
|---|---|---|
| FieldNamingConventions | The field name 'listFormErrors' doesn't match '_[a-z][a-zA-Z0-9]*' | 326 |
| Rule | Violation | Line |
|---|---|---|
| ClassWithOnlyPrivateConstructorsShouldBeFinal | A class which only has private constructors should be final | 14–96 |
| Rule | Violation | Line |
|---|---|---|
| AvoidReassigningParameters | Avoid reassigning parameters such as 'nIndex' | 746 |
| AvoidReassigningParameters | Avoid reassigning parameters such as 'nIndex' | 746 |
| AvoidReassigningParameters | Avoid reassigning parameters such as 'nIndex' | 746 |
| AvoidReassigningParameters | Avoid reassigning parameters such as 'nIndex' | 746 |
| AvoidReassigningParameters | Avoid reassigning parameters such as 'nIndex' | 746 |
| AvoidReassigningParameters | Avoid reassigning parameters such as 'nIndex' | 746 |
| AvoidReassigningParameters | Avoid reassigning parameters such as 'nIndex' | 746 |
| AvoidReassigningParameters | Avoid reassigning parameters such as 'nIndex' | 746 |
| AvoidReassigningParameters | Avoid reassigning parameters such as 'nIndex' | 746 |
| AvoidReassigningParameters | Avoid reassigning parameters such as 'nIndex' | 769 |
| AvoidReassigningParameters | Avoid reassigning parameters such as 'nIndex' | 769 |
| AvoidReassigningParameters | Avoid reassigning parameters such as 'nIndex' | 769 |
| AvoidReassigningParameters | Avoid reassigning parameters such as 'nIndex' | 769 |
| AvoidReassigningParameters | Avoid reassigning parameters such as 'nIndex' | 769 |
| Rule | Violation | Line |
|---|---|---|
| AvoidReassigningParameters | Avoid reassigning parameters such as 'reservationRule' | 411 |
| Rule | Violation | Line |
|---|---|---|
| AvoidReassigningParameters | Avoid reassigning parameters such as 'model' | 1457 |
| AvoidReassigningParameters | Avoid reassigning parameters such as 'model' | 1502 |
| AvoidReassigningParameters | Avoid reassigning parameters such as 'model' | 1543 |
| Rule | Violation | Line |
|---|---|---|
| GuardLogStatement | Logger calls should be surrounded by log level guards. | 450 |
| Rule | Violation | Line |
|---|---|---|
| GuardLogStatement | Logger calls should be surrounded by log level guards. | 661 |
| AvoidReassigningParameters | Avoid reassigning parameters such as 'nMaxCapacity' | 902 |
| AvoidReassigningParameters | Avoid reassigning parameters such as 'nNewNbMaxCapacity' | 975 |
| AvoidReassigningParameters | Avoid reassigning parameters such as 'slot' | 975 |
| Rule | Violation | Line |
|---|---|---|
| CommentRequired | Header comments are required | 39–159 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 96–103 |
| NullAssignment | Assigning an Object to null is a code smell. Consider refactoring. | 102 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 150–157 |
| NullAssignment | Assigning an Object to null is a code smell. Consider refactoring. | 156 |
| Rule | Violation | Line |
|---|---|---|
| CommentRequired | Public method and constructor comments are required | 342–352 |
| CommentRequired | Public method and constructor comments are required | 354–368 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 456–463 |
| NullAssignment | Assigning an Object to null is a code smell. Consider refactoring. | 462 |
| Rule | Violation | Line |
|---|---|---|
| TooManyMethods | This class has too many methods, consider refactoring it. | 62–830 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 374 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 444 |
| CyclomaticComplexity | The method 'addFilterParametersToDAOUtil(AppointmentFilterDTO, DAOUtil)' has a cyclomatic complexity of 13. | 497–561 |
| NPathComplexity | The method 'addFilterParametersToDAOUtil(AppointmentFilterDTO, DAOUtil)' has an NPath complexity of 2304 | 497–561 |
| UseLocaleWithCaseConversions | When doing a String.toLowerCase()/toUpperCase() call, use a Locale | 506 |
| UseLocaleWithCaseConversions | When doing a String.toLowerCase()/toUpperCase() call, use a Locale | 510 |
| UseLocaleWithCaseConversions | When doing a String.toLowerCase()/toUpperCase() call, use a Locale | 514 |
| UseLocaleWithCaseConversions | When doing a String.toLowerCase()/toUpperCase() call, use a Locale | 518 |
| CyclomaticComplexity | The method 'getSqlQueryFromFilter(AppointmentFilterDTO, String)' has a cyclomatic complexity of 11. | 570–629 |
| NPathComplexity | The method 'getSqlQueryFromFilter(AppointmentFilterDTO, String)' has an NPath complexity of 1024 | 570–629 |
| CyclomaticComplexity | The method 'getOrderQuery(AppointmentFilterDTO, String)' has a cyclomatic complexity of 11. | 631–680 |
| MissingBreakInSwitch | A switch statement does not contain a break | 642–670 |
| Rule | Violation | Line |
|---|---|---|
| TooManyMethods | This class has too many methods, consider refactoring it. | 51–243 |
| CommentRequired | Public method and constructor comments are required | 214–217 |
| Rule | Violation | Line |
|---|---|---|
| CommentRequired | Header comments are required | 38–112 |
| Rule | Violation | Line |
|---|---|---|
| TooManyMethods | This class has too many methods, consider refactoring it. | 48–209 |
| Rule | Violation | Line |
|---|---|---|
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 73–80 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 82–89 |
| Rule | Violation | Line |
|---|---|---|
| CommentRequired | Header comments are required | 40–73 |
| Rule | Violation | Line |
|---|---|---|
| TooManyFields | Too many fields | 58–541 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 306–313 |
| NullAssignment | Assigning an Object to null is a code smell. Consider refactoring. | 312 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 360–367 |
| NullAssignment | Assigning an Object to null is a code smell. Consider refactoring. | 366 |
| CommentRequired | Public method and constructor comments are required | 521–524 |
| CommentRequired | Public method and constructor comments are required | 526–529 |
| CommentRequired | Public method and constructor comments are required | 531–534 |
| CommentRequired | Public method and constructor comments are required | 536–539 |
| Rule | Violation | Line |
|---|---|---|
| TooManyMethods | This class has too many methods, consider refactoring it. | 50–276 |
| Rule | Violation | Line |
|---|---|---|
| CommentRequired | Header comments are required | 41–195 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 171–178 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 179–186 |
| Rule | Violation | Line |
|---|---|---|
| TooManyFields | Too many fields | 44–543 |
| Rule | Violation | Line |
|---|---|---|
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 134–141 |
| NullAssignment | Assigning an Object to null is a code smell. Consider refactoring. | 140 |
| Rule | Violation | Line |
|---|---|---|
| TooManyMethods | This class has too many methods, consider refactoring it. | 52–237 |
| Rule | Violation | Line |
|---|---|---|
| TooManyMethods | This class has too many methods, consider refactoring it. | 52–245 |
| Rule | Violation | Line |
|---|---|---|
| CallSuperInConstructor | It is a good practice to call super() in a constructor | 61–64 |
| Rule | Violation | Line |
|---|---|---|
| CallSuperInConstructor | It is a good practice to call super() in a constructor | 56–59 |
| Rule | Violation | Line |
|---|---|---|
| ShortVariable | Avoid variables with short names like p | 68 |
| ShortVariable | Avoid variables with short names like p | 105 |
| Rule | Violation | Line |
|---|---|---|
| CallSuperInConstructor | It is a good practice to call super() in a constructor | 58–61 |
| Rule | Violation | Line |
|---|---|---|
| AvoidSynchronizedAtMethodLevel | Use block level rather than method level synchronization | 59–69 |
| Rule | Violation | Line |
|---|---|---|
| TooManyMethods | This class has too many methods, consider refactoring it. | 49–229 |
| UnnecessaryModifier | Unnecessary modifier 'public' on method 'deleteByIdForm': the method is declared in an interface type | 88 |
| Rule | Violation | Line |
|---|---|---|
| DataClass | The class 'Period' is suspected to be a Data Class (WOC=0.000%, NOPA=0, NOAM=4, WMC=5) | 39–105 |
| CommentRequired | Header comments are required | 39–105 |
| CommentRequired | Public method and constructor comments are required | 57–61 |
| Rule | Violation | Line |
|---|---|---|
| AvoidLiteralsInIfCondition | Avoid using Literals in Conditional Statements | 492 |
| Rule | Violation | Line |
|---|---|---|
| TooManyMethods | This class has too many methods, consider refactoring it. | 53–375 |
| Rule | Violation | Line |
|---|---|---|
| TooManyMethods | This class has too many methods, consider refactoring it. | 52–280 |
| Rule | Violation | Line |
|---|---|---|
| UseLocaleWithCaseConversions | When doing a String.toLowerCase()/toUpperCase() call, use a Locale | 148 |
| UseLocaleWithCaseConversions | When doing a String.toLowerCase()/toUpperCase() call, use a Locale | 149 |
| UseLocaleWithCaseConversions | When doing a String.toLowerCase()/toUpperCase() call, use a Locale | 150 |
| Rule | Violation | Line |
|---|---|---|
| CommentRequired | Header comments are required | 36–58 |
| CommentRequired | Public method and constructor comments are required | 53–57 |
| ShortVariable | Avoid variables with short names like e | 53 |
| Rule | Violation | Line |
|---|---|---|
| CommentRequired | Header comments are required | 36–58 |
| ShortVariable | Avoid variables with short names like e | 53 |
| CommentRequired | Public method and constructor comments are required | 53–57 |
| Rule | Violation | Line |
|---|---|---|
| CommentRequired | Header comments are required | 36–58 |
| CommentRequired | Public method and constructor comments are required | 53–57 |
| ShortVariable | Avoid variables with short names like e | 53 |
| Rule | Violation | Line |
|---|---|---|
| CommentRequired | Header comments are required | 42–67 |
| ShortVariable | Avoid variables with short names like BY | 46 |
| CommentRequired | Public method and constructor comments are required | 56–65 |
| Rule | Violation | Line |
|---|---|---|
| CommentRequired | Enum comments are required | 47–113 |
| DoNotUseThreads | To be compliant to J2EE, a webapp should not use any thread. | 66 |
| DoNotUseThreads | To be compliant to J2EE, a webapp should not use any thread. | 83 |
| Rule | Violation | Line |
|---|---|---|
| DataClass | The class 'AppointmentResourceIdService' is suspected to be a Data Class (WOC=0.000%, NOPA=16, NOAM=0, WMC=1) | 57–237 |
| CallSuperInConstructor | It is a good practice to call super() in a constructor | 112–115 |
| NcssCount | The method 'register()' has a NCSS line count of 65. | 121–202 |
| Rule | Violation | Line |
|---|---|---|
| ExcessiveImports | A high number of imports can indicate a high degree of coupling within an object. | 34–627 |
| GodClass | Possible God Class (WMC=60, ATFD=106, TCC=0.000%) | 77–627 |
| TooManyMethods | This class has too many methods, consider refactoring it. | 78–627 |
| CommentDefaultAccessModifier | To avoid mistakes add a comment at the beginning of the buildAndCreateAppointment method if you want a default access modifier | 179–223 |
| DefaultPackage | Use explicit scoping instead of the default package private level | 179–223 |
| UseStringBufferForStringAppends | Prefer StringBuilder (non-synchronized) or StringBuffer (synchronized) over += for concatenating strings | 212 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 344–357 |
| AvoidCatchingGenericException | Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 410 |
| AvoidCatchingGenericException | Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 426 |
| CyclomaticComplexity | The method 'updateAppointment(Appointment)' has a cyclomatic complexity of 11. | 524–570 |
| AvoidCatchingGenericException | Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 563 |
| CommentRequired | Public method and constructor comments are required | 600–625 |
| AvoidLiteralsInIfCondition | Avoid using Literals in Conditional Statements | 608 |
| Rule | Violation | Line |
|---|---|---|
| CommentRequired | Header comments are required | 39–63 |
| Rule | Violation | Line |
|---|---|---|
| ExcessiveImports | A high number of imports can indicate a high degree of coupling within an object. | 34–1327 |
| CyclomaticComplexity | The class 'AppointmentUtilities' has a total cyclomatic complexity of 147 (highest 12). | 101–1327 |
| GodClass | Possible God Class (WMC=147, ATFD=240, TCC=0.891%) | 101–1327 |
| ExcessiveClassLength | Avoid really long classes. | 101–1327 |
| TooManyMethods | This class has too many methods, consider refactoring it. | 102–1327 |
| DoNotUseThreads | To be compliant to J2EE, a webapp should not use any thread. | 124 |
| AvoidDeeplyNestedIfStmts | Deeply nested if..then statements are hard to read | 221–234 |
| AvoidDeeplyNestedIfStmts | Deeply nested if..then statements are hard to read | 275–279 |
| AvoidDeeplyNestedIfStmts | Deeply nested if..then statements are hard to read | 313–316 |
| AvoidDeeplyNestedIfStmts | Deeply nested if..then statements are hard to read | 346–349 |
| CyclomaticComplexity | The method 'checkNbMaxAppointmentsOnAGivenPeriod(AppointmentDTO, String, AppointmentFormDTO)' has a cyclomatic complexity of 11. | 369–430 |
| AvoidDeeplyNestedIfStmts | Deeply nested if..then statements are hard to read | 414–418 |
| AvoidDeeplyNestedIfStmts | Deeply nested if..then statements are hard to read | 421–425 |
| AvoidCatchingGenericException | Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 504 |
| AvoidCatchingNPE | Avoid catching NullPointerException; consider removing the cause of the NPE. | 504 |
| UseObjectForClearerAPI | Rather than using a lot of String arguments, consider using a container object for those values. | 547 |
| CommentRequired | Public method and constructor comments are required | 594–606 |
| ControlStatementBraces | This statement should have braces | 659 |
| CommentRequired | Public method and constructor comments are required | 664–668 |
| ShortVariable | Avoid variables with short names like nI | 725 |
| EmptyIfStmt | Avoid empty if statements | 836–838 |
| EmptyIfStmt | Avoid empty if statements | 904–906 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 924 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 925 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 926 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 927 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 955–970 |
| CommentRequired | Public method and constructor comments are required | 1055–1066 |
| CommentRequired | Public method and constructor comments are required | 1068–1080 |
| CyclomaticComplexity | The method 'weekIsOpenInFO(AppointmentFormDTO, List, Locale)' has a cyclomatic complexity of 12. | 1137–1179 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 1309–1319 |
| AvoidCatchingGenericException | Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 1321 |
| AvoidCatchingNPE | Avoid catching NullPointerException; consider removing the cause of the NPE. | 1321 |
| Rule | Violation | Line |
|---|---|---|
| CommentRequired | Header comments are required | 51–428 |
| ExcessiveMethodLength | Avoid really long methods. | 74–218 |
| CyclomaticComplexity | The method 'buildListSlot(int, Map, LocalDate, LocalDate)' has a cyclomatic complexity of 19. | 74–218 |
| NcssCount | The method 'buildListSlot(int, Map, LocalDate, LocalDate)' has a NCSS line count of 78. | 74–218 |
| NullAssignment | Assigning an Object to null is a code smell. Consider refactoring. | 112 |
| NullAssignment | Assigning an Object to null is a code smell. Consider refactoring. | 124 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 131–214 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 160–171 |
| NcssCount | The method 'buildListSlot(int, Map, LocalDate, LocalDate, int, boolean)' has a NCSS line count of 96. | 237–402 |
| ExcessiveMethodLength | Avoid really long methods. | 237–402 |
| CyclomaticComplexity | The method 'buildListSlot(int, Map, LocalDate, LocalDate, int, boolean)' has a cyclomatic complexity of 17. | 237–402 |
| NPathComplexity | The method 'buildListSlot(int, Map, LocalDate, LocalDate, int, boolean)' has an NPath complexity of 699 | 237–402 |
| NullAssignment | Assigning an Object to null is a code smell. Consider refactoring. | 287 |
| NullAssignment | Assigning an Object to null is a code smell. Consider refactoring. | 298 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 341–352 |
| Rule | Violation | Line |
|---|---|---|
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 208 |
| AvoidLiteralsInIfCondition | Avoid using Literals in Conditional Statements | 227 |
| Rule | Violation | Line |
|---|---|---|
| CommentRequired | Header comments are required | 60–264 |
| CommentRequired | Public method and constructor comments are required | 195–231 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 244 |
| Rule | Violation | Line |
|---|---|---|
| ExcessiveImports | A high number of imports can indicate a high degree of coupling within an object. | 34–806 |
| CyclomaticComplexity | The class 'EntryService' has a total cyclomatic complexity of 90 (highest 16). | 76–806 |
| GodClass | Possible God Class (WMC=90, ATFD=184, TCC=0.585%) | 76–806 |
| TooManyMethods | This class has too many methods, consider refactoring it. | 77–806 |
| CyclomaticComplexity | The method 'moveDownEntryOrder(int, Entry)' has a cyclomatic complexity of 16. | 139–234 |
| ForLoopCanBeForeach | This for loop can be replaced by a foreach loop | 166–199 |
| CyclomaticComplexity | The method 'moveUpEntryOrder(int, Entry)' has a cyclomatic complexity of 13. | 244–318 |
| ForLoopCanBeForeach | This for loop can be replaced by a foreach loop | 269–299 |
| LinguisticNaming | Linguistics Antipattern - The getter 'getHtmlEntry' should not return void linguistically | 518–581 |
| CyclomaticComplexity | The method 'getHtmlEntry(Map, int, StringBuilder, Locale, boolean, AppointmentDTO)' has a cyclomatic complexity of 14. | 518–581 |
| CyclomaticComplexity | The method 'getResponseEntry(HttpServletRequest, int, List, boolean, Locale, AppointmentDTO)' has a cyclomatic complexity of 13. | 621–696 |
| AvoidReassigningLoopVariables | Avoid reassigning the loop control variable 'field' | 631 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 655–669 |
| UnusedFormalParameter | Avoid unused method parameters such as 'stringBuffer'. | 796 |
| Rule | Violation | Line |
|---|---|---|
| FieldDeclarationsShouldBeAtStartOfClass | Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. | 61 |
| FieldDeclarationsShouldBeAtStartOfClass | Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. | 63 |
| FieldDeclarationsShouldBeAtStartOfClass | Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. | 64 |
| FieldDeclarationsShouldBeAtStartOfClass | Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. | 65 |
| FieldDeclarationsShouldBeAtStartOfClass | Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. | 66 |
| FieldDeclarationsShouldBeAtStartOfClass | Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. | 67 |
| FieldDeclarationsShouldBeAtStartOfClass | Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. | 68 |
| FieldDeclarationsShouldBeAtStartOfClass | Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. | 69 |
| FieldDeclarationsShouldBeAtStartOfClass | Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. | 70 |
| FieldDeclarationsShouldBeAtStartOfClass | Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. | 71 |
| FieldDeclarationsShouldBeAtStartOfClass | Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. | 72 |
| FieldDeclarationsShouldBeAtStartOfClass | Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. | 73 |
| FieldDeclarationsShouldBeAtStartOfClass | Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. | 74 |
| FieldDeclarationsShouldBeAtStartOfClass | Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. | 75 |
| FieldDeclarationsShouldBeAtStartOfClass | Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. | 76 |
| FieldDeclarationsShouldBeAtStartOfClass | Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. | 77 |
| FieldDeclarationsShouldBeAtStartOfClass | Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. | 78 |
| FieldDeclarationsShouldBeAtStartOfClass | Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. | 79 |
| Rule | Violation | Line |
|---|---|---|
| ExcessiveImports | A high number of imports can indicate a high degree of coupling within an object. | 34–809 |
| GodClass | Possible God Class (WMC=72, ATFD=155, TCC=0.000%) | 86–809 |
| TooManyMethods | This class has too many methods, consider refactoring it. | 87–809 |
| NcssCount | The method 'copyForm(int, String)' has a NCSS line count of 88. | 105–226 |
| ExcessiveMethodLength | Avoid really long methods. | 105–226 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 258 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 259 |
| CyclomaticComplexity | The method 'fillAppointmentFormWithReservationRulePart(AppointmentFormDTO, ReservationRule)' has a cyclomatic complexity of 10. | 468–515 |
| AvoidCatchingGenericException | Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 746 |
| Rule | Violation | Line |
|---|---|---|
| TooManyMethods | This class has too many methods, consider refactoring it. | 67–426 |
| AvoidCatchingGenericException | Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 154 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 367 |
| Rule | Violation | Line |
|---|---|---|
| CommentRequired | Header comments are required | 38–49 |
| Rule | Violation | Line |
|---|---|---|
| ExcessiveImports | A high number of imports can indicate a high degree of coupling within an object. | 34–1171 |
| CommentRequired | Header comments are required | 86–1171 |
| GodClass | Possible God Class (WMC=116, ATFD=232, TCC=1.709%) | 86–1171 |
| CyclomaticComplexity | The class 'SlotSafeService' has a total cyclomatic complexity of 116 (highest 20). | 86–1171 |
| ExcessiveClassLength | Avoid really long classes. | 86–1171 |
| TooManyMethods | This class has too many methods, consider refactoring it. | 87–1171 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 166–175 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 208–219 |
| CyclomaticComplexity | The method 'saveAppointment(AppointmentDTO, HttpServletRequest)' has a cyclomatic complexity of 16. | 336–406 |
| NPathComplexity | The method 'saveAppointment(AppointmentDTO, HttpServletRequest)' has an NPath complexity of 216 | 336–406 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 338 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 339 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 340 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 342 |
| ControlStatementBraces | This statement should have braces | 354 |
| AvoidCatchingGenericException | Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 393 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 468 |
| DefaultPackage | Use explicit scoping instead of the default package private level | 485–526 |
| CommentDefaultAccessModifier | To avoid mistakes add a comment at the beginning of the updateRemaningPlacesWithAppointmentMovedDeletedOrCanceled method if you want a default access modifier | 485–526 |
| CommentDefaultAccessModifier | To avoid mistakes add a comment at the beginning of the updateRemaningPlacesWithAppointmentReactivated method if you want a default access modifier | 537–560 |
| DefaultPackage | Use explicit scoping instead of the default package private level | 537–560 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 582–591 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 638–657 |
| CyclomaticComplexity | The method 'updateSlotWithShift(Slot, LocalTime)' has a cyclomatic complexity of 11. | 683–824 |
| NcssCount | The method 'updateSlotWithShift(Slot, LocalTime)' has a NCSS line count of 65. | 683–824 |
| ExcessiveMethodLength | Avoid really long methods. | 683–824 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 727–734 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 844–852 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 894–921 |
| ShortVariable | Avoid variables with short names like it | 982 |
| NPathComplexity | The method 'saveSlots(AppointmentDTO, List, HttpServletRequest)' has an NPath complexity of 441 | 1005–1084 |
| CyclomaticComplexity | The method 'saveSlots(AppointmentDTO, List, HttpServletRequest)' has a cyclomatic complexity of 20. | 1005–1084 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 1009 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 1010 |
| Rule | Violation | Line |
|---|---|---|
| TooManyMethods | This class has too many methods, consider refactoring it. | 62–518 |
| LooseCoupling | Avoid using implementation types like 'HashMap'; use the interface instead | 141 |
| LooseCoupling | Avoid using implementation types like 'HashMap'; use the interface instead | 222 |
| AvoidLiteralsInIfCondition | Avoid using Literals in Conditional Statements | 286 |
| Rule | Violation | Line |
|---|---|---|
| TooManyMethods | This class has too many methods, consider refactoring it. | 64–576 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 217–224 |
| ExcessiveMethodLength | Avoid really long methods. | 253–376 |
| Rule | Violation | Line |
|---|---|---|
| NonThreadSafeSingleton | Singleton is not thread safe | 66–69 |
| DefaultPackage | Use explicit scoping instead of the default package private level | 76–79 |
| CommentDefaultAccessModifier | To avoid mistakes add a comment at the beginning of the resetFormatter method if you want a default access modifier | 76–79 |
| NullAssignment | Assigning an Object to null is a code smell. Consider refactoring. | 78 |
| Rule | Violation | Line |
|---|---|---|
| GodClass | Possible God Class (WMC=60, ATFD=45, TCC=0.000%) | 63–568 |
| TooManyMethods | This class has too many methods, consider refactoring it. | 64–568 |
| LooseCoupling | Avoid using implementation types like 'HashMap'; use the interface instead | 301 |
| CyclomaticComplexity | The method 'assignWeekDefinition(int, WeekDefinition)' has a cyclomatic complexity of 11. | 470–534 |
| UnusedFormalParameter | Avoid unused method parameters such as 'nIdForm'. | 536 |
| AvoidCatchingGenericException | Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 559 |
| Rule | Violation | Line |
|---|---|---|
| LooseCoupling | Avoid using implementation types like 'HashSet'; use the interface instead | 341 |
| Rule | Violation | Line |
|---|---|---|
| CommentRequired | Header comments are required | 7–15 |
| Rule | Violation | Line |
|---|---|---|
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 107 |
| Rule | Violation | Line |
|---|---|---|
| ExcessiveImports | A high number of imports can indicate a high degree of coupling within an object. | 34–380 |
| CommentRequired | Header comments are required | 81–380 |
| GodClass | Possible God Class (WMC=51, ATFD=49, TCC=0.000%) | 81–380 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 141 |
| UnnecessaryModifier | Unnecessary modifier 'final' on method 'writeWorkbook': private methods cannot be overridden | 151–191 |
| ShortVariable | Avoid variables with short names like os | 154 |
| UnnecessaryModifier | Unnecessary modifier 'final' on method 'createHeaderContent': private methods cannot be overridden | 193–209 |
| UnnecessaryModifier | Unnecessary modifier 'final' on method 'createLineContent': private methods cannot be overridden | 211–233 |
| NPathComplexity | The method 'addDefaultColumnValues(AppointmentDTO, Form, List, List, StateService, Locale)' has an NPath complexity of 24576 | 235–300 |
| CyclomaticComplexity | The method 'addDefaultColumnValues(AppointmentDTO, Form, List, List, StateService, Locale)' has a cyclomatic complexity of 16. | 235–300 |
| UnnecessaryModifier | Unnecessary modifier 'final' on method 'addDefaultColumnValues': private methods cannot be overridden | 235–300 |
| UnnecessaryModifier | Unnecessary modifier 'final' on method 'getEntryValue': private methods cannot be overridden | 327–352 |
| ShortVariable | Avoid variables with short names like e | 327 |
| ShortVariable | Avoid variables with short names like f | 338 |
| InefficientStringBuffering | Avoid concatenating nonliterals in a StringBuffer/StringBuilder constructor or append(). | 347 |
| CommentRequired | Public method and constructor comments are required | 354–362 |
| CommentRequired | Public method and constructor comments are required | 364–379 |
| Rule | Violation | Line |
|---|---|---|
| CommentRequired | Header comments are required | 51–111 |
| CommentRequired | Public method and constructor comments are required | 67–77 |
| SimpleDateFormatNeedsLocale | When instantiating a SimpleDateFormat object, specify a Locale | 70 |
| Rule | Violation | Line |
|---|---|---|
| ShortVariable | Avoid variables with short names like se | 51 |
| ShortVariable | Avoid variables with short names like se | 60 |
| Rule | Violation | Line |
|---|---|---|
| CommentRequired | Header comments are required | 39–98 |
| Rule | Violation | Line |
|---|---|---|
| CommentRequired | Header comments are required | 42–103 |
| Rule | Violation | Line |
|---|---|---|
| DataClass | The class 'SlotEditTask' is suspected to be a Data Class (WOC=0.000%, NOPA=0, NOAM=4, WMC=5) | 47–113 |
| CommentRequired | Public method and constructor comments are required | 60–64 |
| Rule | Violation | Line |
|---|---|---|
| CommentRequired | Header comments are required | 38–49 |
| UnnecessaryConstructor | Avoid unnecessary constructors - the compiler will generate these for you | 44–47 |
| Rule | Violation | Line |
|---|---|---|
| CommentRequired | Header comments are required | 67–364 |
| Rule | Violation | Line |
|---|---|---|
| ExcessiveImports | A high number of imports can indicate a high degree of coupling within an object. | 34–512 |
| UnnecessaryAnnotationValueElement | Avoid the use of value in annotations when its the only element | 147 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 192 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 193 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 194 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 254 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 255 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 256 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 313 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 315 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 316 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 317 |
| AvoidReassigningLoopVariables | Avoid reassigning the loop control variable 'slotImpacted' | 402 |
| AppendCharacterWithChar | Avoid appending characters as strings in StringBuffer.append. | 438 |
| Rule | Violation | Line |
|---|---|---|
| ExcessiveImports | A high number of imports can indicate a high degree of coupling within an object. | 34–1902 |
| ExcessiveClassLength | Avoid really long classes. | 134–1902 |
| SingularField | Perhaps '_strNbPlacesToTakeLength' could be replaced by a local variable. | 301 |
| ExcessiveMethodLength | Avoid really long methods. | 315–595 |
| NPathComplexity | The method 'getViewAppointmentCalendar(HttpServletRequest)' has an NPath complexity of 116161920 | 315–595 |
| NcssCount | The method 'getViewAppointmentCalendar(HttpServletRequest)' has a NCSS line count of 158. | 315–595 |
| AvoidSynchronizedAtMethodLevel | Use block level rather than method level synchronization | 315–595 |
| CyclomaticComplexity | The method 'getViewAppointmentCalendar(HttpServletRequest)' has a cyclomatic complexity of 38. | 315–595 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 334 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 415 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 417 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 420–421 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 468–479 |
| AvoidSynchronizedAtMethodLevel | Use block level rather than method level synchronization | 606–832 |
| ExcessiveMethodLength | Avoid really long methods. | 606–832 |
| NcssCount | The method 'getViewAppointmentForm(HttpServletRequest)' has a NCSS line count of 122. | 606–832 |
| NPathComplexity | The method 'getViewAppointmentForm(HttpServletRequest)' has an NPath complexity of 76800000 | 606–832 |
| CyclomaticComplexity | The method 'getViewAppointmentForm(HttpServletRequest)' has a cyclomatic complexity of 38. | 606–832 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 608 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 609 |
| LinguisticNaming | Linguistics Antipattern - The variable 'isModification' indicates linguistically it is a boolean, but it is 'String' | 657 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 660–693 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 669 |
| NullAssignment | Assigning an Object to null is a code smell. Consider refactoring. | 704 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 712–774 |
| AvoidReassigningLoopVariables | Avoid reassigning the loop control variable 'slot' | 725 |
| AvoidReassigningLoopVariables | Avoid reassigning the loop control variable 'slot' | 729 |
| NullAssignment | Assigning an Object to null is a code smell. Consider refactoring. | 736 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 800–808 |
| AvoidSynchronizedAtMethodLevel | Use block level rather than method level synchronization | 845–952 |
| NcssCount | The method 'doValidateForm(HttpServletRequest)' has a NCSS line count of 69. | 845–952 |
| CyclomaticComplexity | The method 'doValidateForm(HttpServletRequest)' has a cyclomatic complexity of 18. | 845–952 |
| ExcessiveMethodLength | Avoid really long methods. | 845–952 |
| NPathComplexity | The method 'doValidateForm(HttpServletRequest)' has an NPath complexity of 6912 | 845–952 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 853 |
| NullAssignment | Assigning an Object to null is a code smell. Consider refactoring. | 858 |
| NullAssignment | Assigning an Object to null is a code smell. Consider refactoring. | 859 |
| ShortVariable | Avoid variables with short names like lf | 902 |
| NullAssignment | Assigning an Object to null is a code smell. Consider refactoring. | 939 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 943 |
| AvoidSynchronizedAtMethodLevel | Use block level rather than method level synchronization | 964–1011 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 968 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 972 |
| NullAssignment | Assigning an Object to null is a code smell. Consider refactoring. | 980 |
| NullAssignment | Assigning an Object to null is a code smell. Consider refactoring. | 981 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 984 |
| CyclomaticComplexity | The method 'doMakeAppointment(HttpServletRequest)' has a cyclomatic complexity of 15. | 1023–1105 |
| NPathComplexity | The method 'doMakeAppointment(HttpServletRequest)' has an NPath complexity of 1024 | 1023–1105 |
| AvoidSynchronizedAtMethodLevel | Use block level rather than method level synchronization | 1023–1105 |
| NullAssignment | Assigning an Object to null is a code smell. Consider refactoring. | 1034 |
| NullAssignment | Assigning an Object to null is a code smell. Consider refactoring. | 1035 |
| AvoidSynchronizedAtMethodLevel | Use block level rather than method level synchronization | 1115–1147 |
| AvoidLiteralsInIfCondition | Avoid using Literals in Conditional Statements | 1126 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 1135 |
| NullAssignment | Assigning an Object to null is a code smell. Consider refactoring. | 1144 |
| NullAssignment | Assigning an Object to null is a code smell. Consider refactoring. | 1145 |
| NPathComplexity | The method 'getViewChangeDateAppointment(HttpServletRequest)' has an NPath complexity of 2880 | 1160–1255 |
| CyclomaticComplexity | The method 'getViewChangeDateAppointment(HttpServletRequest)' has a cyclomatic complexity of 17. | 1160–1255 |
| AvoidSynchronizedAtMethodLevel | Use block level rather than method level synchronization | 1160–1255 |
| NullAssignment | Assigning an Object to null is a code smell. Consider refactoring. | 1171 |
| AvoidReassigningLoopVariables | Avoid reassigning the loop control variable 'slot' | 1198 |
| AvoidReassigningLoopVariables | Avoid reassigning the loop control variable 'slot' | 1204 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 1251 |
| AvoidSynchronizedAtMethodLevel | Use block level rather than method level synchronization | 1265–1275 |
| NullAssignment | Assigning an Object to null is a code smell. Consider refactoring. | 1268 |
| NullAssignment | Assigning an Object to null is a code smell. Consider refactoring. | 1269 |
| AvoidSynchronizedAtMethodLevel | Use block level rather than method level synchronization | 1284–1332 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 1292 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 1295–1326 |
| AvoidSynchronizedAtMethodLevel | Use block level rather than method level synchronization | 1341–1393 |
| CyclomaticComplexity | The method 'doCancelAppointment(HttpServletRequest)' has a cyclomatic complexity of 10. | 1341–1393 |
| AvoidCatchingGenericException | Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 1367 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 1378 |
| AvoidSynchronizedAtMethodLevel | Use block level rather than method level synchronization | 1403–1419 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 1409 |
| AvoidSynchronizedAtMethodLevel | Use block level rather than method level synchronization | 1431–1442 |
| AvoidSynchronizedAtMethodLevel | Use block level rather than method level synchronization | 1588–1627 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 1608 |
| AvoidSynchronizedAtMethodLevel | Use block level rather than method level synchronization | 1637–1723 |
| CyclomaticComplexity | The method 'doProcessWorkflowAction(HttpServletRequest)' has a cyclomatic complexity of 15. | 1637–1723 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 1644 |
| AvoidCatchingGenericException | Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 1715 |
| CyclomaticComplexity | The method 'checkMyLuteceAuthentication(AppointmentFormDTO, HttpServletRequest)' has a cyclomatic complexity of 14. | 1835–1874 |
| Rule | Violation | Line |
|---|---|---|
| NullAssignment | Assigning an Object to null is a code smell. Consider refactoring. | 124 |
| Rule | Violation | Line |
|---|---|---|
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 98 |
| Rule | Violation | Line |
|---|---|---|
| ExcessiveImports | A high number of imports can indicate a high degree of coupling within an object. | 34–797 |
| TooManyMethods | This class has too many methods, consider refactoring it. | 89–797 |
| ImmutableField | Private field '_entryService' could be made final; it is only initialized in the declaration or constructor. | 153 |
| UnnecessaryAnnotationValueElement | Avoid the use of value in annotations when its the only element | 189 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 219 |
| NPathComplexity | The method 'doCreateEntry(HttpServletRequest)' has an NPath complexity of 234 | 242–291 |
| CyclomaticComplexity | The method 'doCreateEntry(HttpServletRequest)' has a cyclomatic complexity of 13. | 242–291 |
| AvoidReassigningLoopVariables | Avoid reassigning the loop control variable 'field' | 316 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 321 |
| CyclomaticComplexity | The method 'doModifyEntry(HttpServletRequest)' has a cyclomatic complexity of 11. | 350–404 |
| AvoidDeeplyNestedIfStmts | Deeply nested if..then statements are hard to read | 364–367 |
| AvoidDeeplyNestedIfStmts | Deeply nested if..then statements are hard to read | 375–384 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 375–384 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 393–400 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 449 |
| CyclomaticComplexity | The method 'doChangeOrderEntry(HttpServletRequest)' has a cyclomatic complexity of 11. | 601–651 |
| CommentRequired | Public method and constructor comments are required | 726–747 |
| Rule | Violation | Line |
|---|---|---|
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 136 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 456 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 457 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 458 |
| Rule | Violation | Line |
|---|---|---|
| ExcessiveImports | A high number of imports can indicate a high degree of coupling within an object. | 34–814 |
| ImmutableField | Private field '_nDefaultItemsPerPage' could be made final; it is only initialized in the declaration or constructor. | 188 |
| CallSuperInConstructor | It is a good practice to call super() in a constructor | 196–199 |
| NullAssignment | Assigning an Object to null is a code smell. Consider refactoring. | 212 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 367 |
| NPathComplexity | The method 'doModifyAppointmentForm(HttpServletRequest)' has an NPath complexity of 384 | 448–503 |
| CyclomaticComplexity | The method 'doModifyAppointmentForm(HttpServletRequest)' has a cyclomatic complexity of 13. | 448–503 |
| NullAssignment | Assigning an Object to null is a code smell. Consider refactoring. | 499 |
| CyclomaticComplexity | The method 'doChangeFormActivation(HttpServletRequest)' has a cyclomatic complexity of 11. | 515–559 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 617 |
| CyclomaticComplexity | The method 'importClosingDayFile(MultipartHttpServletRequest, int)' has a cyclomatic complexity of 11. | 722–793 |
| Rule | Violation | Line |
|---|---|---|
| ExcessiveImports | A high number of imports can indicate a high degree of coupling within an object. | 34–1816 |
| ExcessiveClassLength | Avoid really long classes. | 149–1816 |
| TooManyMethods | This class has too many methods, consider refactoring it. | 150–1816 |
| ImmutableField | Private field '_nDefaultItemsPerPage' could be made final; it is only initialized in the declaration or constructor. | 319 |
| DefaultPackage | Use explicit scoping instead of the default package private level | 326 |
| CommentDefaultAccessModifier | To avoid mistakes add a comment at the beginning of the listFormErrors field if you want a default access modifier | 326 |
| DefaultPackage | Use explicit scoping instead of the default package private level | 327 |
| CommentDefaultAccessModifier | To avoid mistakes add a comment at the beginning of the _moduleAppointmentDesk field if you want a default access modifier | 327 |
| ExcessiveMethodLength | Avoid really long methods. | 338–505 |
| NcssCount | The method 'getViewCalendarManageAppointments(HttpServletRequest)' has a NCSS line count of 94. | 338–505 |
| NPathComplexity | The method 'getViewCalendarManageAppointments(HttpServletRequest)' has an NPath complexity of 62400 | 338–505 |
| AvoidSynchronizedAtMethodLevel | Use block level rather than method level synchronization | 338–505 |
| CyclomaticComplexity | The method 'getViewCalendarManageAppointments(HttpServletRequest)' has a cyclomatic complexity of 24. | 338–505 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 449–458 |
| UnnecessaryAnnotationValueElement | Avoid the use of value in annotations when its the only element | 515 |
| CyclomaticComplexity | The method 'getManageAppointments(HttpServletRequest)' has a cyclomatic complexity of 21. | 516–649 |
| NPathComplexity | The method 'getManageAppointments(HttpServletRequest)' has an NPath complexity of 10080 | 516–649 |
| AvoidSynchronizedAtMethodLevel | Use block level rather than method level synchronization | 516–649 |
| NcssCount | The method 'getManageAppointments(HttpServletRequest)' has a NCSS line count of 86. | 516–649 |
| ExcessiveMethodLength | Avoid really long methods. | 516–649 |
| NullAssignment | Assigning an Object to null is a code smell. Consider refactoring. | 531 |
| NullAssignment | Assigning an Object to null is a code smell. Consider refactoring. | 532 |
| NullAssignment | Assigning an Object to null is a code smell. Consider refactoring. | 533 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 537–560 |
| AvoidSynchronizedAtMethodLevel | Use block level rather than method level synchronization | 659–666 |
| AvoidSynchronizedAtMethodLevel | Use block level rather than method level synchronization | 679–693 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 681 |
| AvoidSynchronizedAtMethodLevel | Use block level rather than method level synchronization | 703–710 |
| AvoidSynchronizedAtMethodLevel | Use block level rather than method level synchronization | 722–743 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 724 |
| AvoidSynchronizedAtMethodLevel | Use block level rather than method level synchronization | 757–840 |
| CyclomaticComplexity | The method 'getViewAppointment(HttpServletRequest)' has a cyclomatic complexity of 13. | 757–840 |
| NPathComplexity | The method 'getViewAppointment(HttpServletRequest)' has an NPath complexity of 336 | 757–840 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 762 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 763 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 765 |
| AvoidSynchronizedAtMethodLevel | Use block level rather than method level synchronization | 854–892 |
| AvoidSynchronizedAtMethodLevel | Use block level rather than method level synchronization | 904–1081 |
| NPathComplexity | The method 'getViewCreateAppointment(HttpServletRequest)' has an NPath complexity of 201480 | 904–1081 |
| CyclomaticComplexity | The method 'getViewCreateAppointment(HttpServletRequest)' has a cyclomatic complexity of 29. | 904–1081 |
| ExcessiveMethodLength | Avoid really long methods. | 904–1081 |
| NcssCount | The method 'getViewCreateAppointment(HttpServletRequest)' has a NCSS line count of 90. | 904–1081 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 908 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 910 |
| LinguisticNaming | Linguistics Antipattern - The variable 'isModification' indicates linguistically it is a boolean, but it is 'String' | 919 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 922–964 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 971–985 |
| NullAssignment | Assigning an Object to null is a code smell. Consider refactoring. | 978 |
| AvoidReassigningLoopVariables | Avoid reassigning the loop control variable 'slot' | 1004 |
| AvoidReassigningLoopVariables | Avoid reassigning the loop control variable 'slot' | 1010 |
| NullAssignment | Assigning an Object to null is a code smell. Consider refactoring. | 1018 |
| CyclomaticComplexity | The method 'doValidateForm(HttpServletRequest)' has a cyclomatic complexity of 12. | 1093–1168 |
| AvoidSynchronizedAtMethodLevel | Use block level rather than method level synchronization | 1093–1168 |
| NPathComplexity | The method 'doValidateForm(HttpServletRequest)' has an NPath complexity of 432 | 1093–1168 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 1096 |
| ShortVariable | Avoid variables with short names like lf | 1134 |
| NullAssignment | Assigning an Object to null is a code smell. Consider refactoring. | 1166 |
| NPathComplexity | The method 'getViewChangeDateAppointment(HttpServletRequest)' has an NPath complexity of 816 | 1180–1277 |
| CyclomaticComplexity | The method 'getViewChangeDateAppointment(HttpServletRequest)' has a cyclomatic complexity of 15. | 1180–1277 |
| AvoidSynchronizedAtMethodLevel | Use block level rather than method level synchronization | 1180–1277 |
| AvoidReassigningLoopVariables | Avoid reassigning the loop control variable 'slot' | 1219 |
| AvoidReassigningLoopVariables | Avoid reassigning the loop control variable 'slot' | 1223 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 1273 |
| AvoidSynchronizedAtMethodLevel | Use block level rather than method level synchronization | 1287–1305 |
| CyclomaticComplexity | The method 'doMakeAppointment(HttpServletRequest)' has a cyclomatic complexity of 11. | 1317–1372 |
| AvoidSynchronizedAtMethodLevel | Use block level rather than method level synchronization | 1317–1372 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 1319 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 1367 |
| NullAssignment | Assigning an Object to null is a code smell. Consider refactoring. | 1370 |
| AvoidSynchronizedAtMethodLevel | Use block level rather than method level synchronization | 1385–1433 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 1388 |
| ShortVariable | Avoid variables with short names like os | 1420 |
| AvoidSynchronizedAtMethodLevel | Use block level rather than method level synchronization | 1448–1491 |
| ShortVariable | Avoid variables with short names like os | 1478 |
| CallSuperInConstructor | It is a good practice to call super() in a constructor | 1496–1499 |
| NullAssignment | Assigning an Object to null is a code smell. Consider refactoring. | 1503 |
| NullAssignment | Assigning an Object to null is a code smell. Consider refactoring. | 1504 |
| NullAssignment | Assigning an Object to null is a code smell. Consider refactoring. | 1505 |
| NullAssignment | Assigning an Object to null is a code smell. Consider refactoring. | 1506 |
| CyclomaticComplexity | The method 'orderList(List)' has a cyclomatic complexity of 11. | 1531–1576 |
| MissingBreakInSwitch | A switch statement does not contain a break | 1540–1569 |
| AvoidSynchronizedAtMethodLevel | Use block level rather than method level synchronization | 1608–1646 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 1628 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 1637 |
| AvoidSynchronizedAtMethodLevel | Use block level rather than method level synchronization | 1656–1723 |
| CyclomaticComplexity | The method 'doProcessWorkflowAction(HttpServletRequest)' has a cyclomatic complexity of 14. | 1656–1723 |
| AvoidCatchingGenericException | Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 1712 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 1716 |
| AvoidSynchronizedAtMethodLevel | Use block level rather than method level synchronization | 1735–1775 |
| CyclomaticComplexity | The method 'doChangeAppointmentStatus(HttpServletRequest)' has a cyclomatic complexity of 11. | 1735–1775 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 1742 |
| Rule | Violation | Line |
|---|---|---|
| NullAssignment | Assigning an Object to null is a code smell. Consider refactoring. | 159 |
| CyclomaticComplexity | The method 'getCreateModifyTemplate(HttpServletRequest)' has a cyclomatic complexity of 10. | 191–249 |
| Rule | Violation | Line |
|---|---|---|
| NullAssignment | Assigning an Object to null is a code smell. Consider refactoring. | 147 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 166 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 196 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 198 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 199 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 200 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 228–237 |
| NPathComplexity | The method 'doModifyComment(HttpServletRequest)' has an NPath complexity of 216 | 287–337 |
| CyclomaticComplexity | The method 'doModifyComment(HttpServletRequest)' has a cyclomatic complexity of 11. | 287–337 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 291 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 292 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 320–328 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 383 |
| Rule | Violation | Line |
|---|---|---|
| NullAssignment | Assigning an Object to null is a code smell. Consider refactoring. | 103 |
| UnnecessaryAnnotationValueElement | Avoid the use of value in annotations when its the only element | 118 |
| Rule | Violation | Line |
|---|---|---|
| ExcessiveImports | A high number of imports can indicate a high degree of coupling within an object. | 34–736 |
| CyclomaticComplexity | The method 'getViewManageSpecificWeek(HttpServletRequest)' has a cyclomatic complexity of 10. | 180–243 |
| NullAssignment | Assigning an Object to null is a code smell. Consider refactoring. | 182 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 184 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 257 |
| CyclomaticComplexity | The method 'doModifySlot(HttpServletRequest)' has a cyclomatic complexity of 16. | 299–387 |
| NPathComplexity | The method 'doModifySlot(HttpServletRequest)' has an NPath complexity of 2898 | 299–387 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 301 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 302 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 303 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 304 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 305 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 306 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 308 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 383 |
| CyclomaticComplexity | The method 'doModifyListSlots(HttpServletRequest)' has a cyclomatic complexity of 16. | 398–514 |
| NPathComplexity | The method 'doModifyListSlots(HttpServletRequest)' has an NPath complexity of 1440 | 398–514 |
| ExcessiveMethodLength | Avoid really long methods. | 398–514 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 400 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 401 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 402 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 403 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 406 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 407 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 408 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 409 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 411 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 412 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 413 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 465–478 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 499–509 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 510 |
| ExcessiveMethodLength | Avoid really long methods. | 597–705 |
| CyclomaticComplexity | The method 'updateListSlots(List, int, int, boolean, boolean, boolean, LocalTime)' has a cyclomatic complexity of 27. | 597–705 |
| NPathComplexity | The method 'updateListSlots(List, int, int, boolean, boolean, boolean, LocalTime)' has an NPath complexity of 34056 | 597–705 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 630 |
| AppendCharacterWithChar | Avoid appending characters as strings in StringBuffer.append. | 669 |
| ControlStatementBraces | This statement should have braces | 692 |
| ControlStatementBraces | This statement should have braces | 695 |
| Rule | Violation | Line |
|---|---|---|
| ExcessiveImports | A high number of imports can indicate a high degree of coupling within an object. | 34–1010 |
| TooManyMethods | This class has too many methods, consider refactoring it. | 94–1010 |
| UnnecessaryAnnotationValueElement | Avoid the use of value in annotations when its the only element | 180 |
| CyclomaticComplexity | The method 'getViewManageTypicalWeek(HttpServletRequest)' has a cyclomatic complexity of 11. | 181–249 |
| NullAssignment | Assigning an Object to null is a code smell. Consider refactoring. | 183 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 184 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 186 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 187 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 200–214 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 263 |
| CyclomaticComplexity | The method 'doModifyAdvancedParameters(HttpServletRequest)' has a cyclomatic complexity of 12. | 293–366 |
| NPathComplexity | The method 'doModifyAdvancedParameters(HttpServletRequest)' has an NPath complexity of 256 | 293–366 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 302 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 303 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 433 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 470 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 471 |
| CyclomaticComplexity | The method 'doModifyTimeSlot(HttpServletRequest)' has a cyclomatic complexity of 18. | 515–635 |
| NPathComplexity | The method 'doModifyTimeSlot(HttpServletRequest)' has an NPath complexity of 6336 | 515–635 |
| ExcessiveMethodLength | Avoid really long methods. | 515–635 |
| NcssCount | The method 'doModifyTimeSlot(HttpServletRequest)' has a NCSS line count of 69. | 515–635 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 518 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 520 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 534 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 535 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 536 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 537 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 538 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 539 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 540 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 573 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 608 |
| NPathComplexity | The method 'doModifyListTimeSlot(HttpServletRequest)' has an NPath complexity of 114048 | 646–820 |
| NcssCount | The method 'doModifyListTimeSlot(HttpServletRequest)' has a NCSS line count of 86. | 646–820 |
| CyclomaticComplexity | The method 'doModifyListTimeSlot(HttpServletRequest)' has a cyclomatic complexity of 25. | 646–820 |
| ExcessiveMethodLength | Avoid really long methods. | 646–820 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 649 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 650 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 652 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 653 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 654 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 666 |
| PositionLiteralsFirstInCaseInsensitiveComparisons | Position literals first in String comparisons for EqualsIgnoreCase | 689 |
| PositionLiteralsFirstInCaseInsensitiveComparisons | Position literals first in String comparisons for EqualsIgnoreCase | 689 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 695 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 795 |
| AvoidReassigningLoopVariables | Avoid reassigning the loop control variable 'slotImpacted' | 880 |
| CyclomaticComplexity | The method 'manageTheSlotsAndAppointmentsImpacted(List, List, int, int, boolean, boolean)' has a cyclomatic complexity of 10. | 902–959 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 924–936 |
| AvoidReassigningLoopVariables | Avoid reassigning the loop control variable 'slotImpacted' | 943 |
| Rule | Violation | Line |
|---|---|---|
| TooManyFields | Too many fields | 57–519 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 132 |
| CommentRequired | Public method and constructor comments are required | 429–432 |
| Rule | Violation | Line |
|---|---|---|
| CommentRequired | Header comments are required | 42–301 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 121–128 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 139–146 |
| NullAssignment | Assigning an Object to null is a code smell. Consider refactoring. | 145 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 156–163 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 175–182 |
| NullAssignment | Assigning an Object to null is a code smell. Consider refactoring. | 181 |
| Rule | Violation | Line |
|---|---|---|
| ExcessivePublicCount | This class has a bunch of public methods and attributes | 34–1169 |
| ExcessiveClassLength | Avoid really long classes. | 54–1169 |
| CyclomaticComplexity | The class 'AppointmentFormDTO' has a total cyclomatic complexity of 87 (highest 2). | 54–1169 |
| TooManyFields | Too many fields | 54–1169 |
| AvoidDuplicateLiterals | The String literal "#i18n{portal.validation.message.notEmpty}" appears 7 times in this file; the first occurrence is on line 97 | 97 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 355–362 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 373–380 |
| NullAssignment | Assigning an Object to null is a code smell. Consider refactoring. | 379 |
| CommentRequired | Public method and constructor comments are required | 478–481 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 637–644 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 655–662 |
| NullAssignment | Assigning an Object to null is a code smell. Consider refactoring. | 661 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 672–679 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 690–697 |
| NullAssignment | Assigning an Object to null is a code smell. Consider refactoring. | 696 |
| CommentRequired | Public method and constructor comments are required | 1151–1153 |
| CommentRequired | Public method and constructor comments are required | 1155–1157 |
| CommentRequired | Public method and constructor comments are required | 1159–1162 |
| CommentRequired | Public method and constructor comments are required | 1164–1167 |
| Rule | Violation | Line |
|---|---|---|
| CommentRequired | Header comments are required | 40–99 |
| CommentRequired | Public method and constructor comments are required | 95–98 |
| Rule | Violation | Line |
|---|---|---|
| AvoidDuplicateLiterals | The String literal "#i18n{portal.validation.message.notEmpty}" appears 6 times in this file; the first occurrence is on line 82 | 82 |
| Rule | Violation | Line |
|---|---|---|
| ImmutableField | Private field '_response' could be made final; it is only initialized in the declaration or constructor. | 64 |
| CallSuperInConstructor | It is a good practice to call super() in a constructor | 72–75 |
| CallSuperInConstructor | It is a good practice to call super() in a constructor | 85–89 |
| ShortVariable | Avoid variables with short names like o | 176 |
| ShortVariable | Avoid variables with short names like o | 187 |
| Rule | Violation | Line |
|---|---|---|
| AvoidSynchronizedAtMethodLevel | Use block level rather than method level synchronization | 32–35 |
| MissingOverride | The method 'getResourceTypeId()' is missing an @Override annotation. | 79–82 |
| Rule | Violation | Line |
|---|---|---|
| CommentRequired | Header comments are required | 43–77 |
| Rule | Violation | Line |
|---|---|---|
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 65 |
| Rule | Violation | Line |
|---|---|---|
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 94 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 121 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 139 |
| Rule | Violation | Line |
|---|---|---|
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 65 |
| Rule | Violation | Line |
|---|---|---|
| BooleanGetMethodName | A getX() method which returns a boolean should be named isX() | 181–184 |
| BooleanGetMethodName | A getX() method which returns a boolean should be named isX() | 471–474 |
| Rule | Violation | Line |
|---|---|---|
| ShortClassName | Avoid short class names like Form | 58–541 |
| BooleanGetMethodName | A getX() method which returns a boolean should be named isX() | 375–378 |
| BooleanGetMethodName | A getX() method which returns a boolean should be named isX() | 446–449 |
| Rule | Violation | Line |
|---|---|---|
| BooleanGetMethodName | A getX() method which returns a boolean should be named isX() | 223–226 |
| Rule | Violation | Line |
|---|---|---|
| BooleanGetMethodName | A getX() method which returns a boolean should be named isX() | 127–130 |
| BooleanGetMethodName | A getX() method which returns a boolean should be named isX() | 148–151 |
| BooleanGetMethodName | A getX() method which returns a boolean should be named isX() | 169–172 |
| BooleanGetMethodName | A getX() method which returns a boolean should be named isX() | 274–277 |
| Rule | Violation | Line |
|---|---|---|
| BooleanGetMethodName | A getX() method which returns a boolean should be named isX() | 191–194 |
| Rule | Violation | Line |
|---|---|---|
| ShortClassName | Avoid short class names like Slot | 51–514 |
| BooleanGetMethodName | A getX() method which returns a boolean should be named isX() | 322–325 |
| BooleanGetMethodName | A getX() method which returns a boolean should be named isX() | 343–346 |
| BooleanGetMethodName | A getX() method which returns a boolean should be named isX() | 364–367 |
| BooleanGetMethodName | A getX() method which returns a boolean should be named isX() | 490–498 |
| Rule | Violation | Line |
|---|---|---|
| ShortClassName | Avoid short class names like User | 51–247 |
| Rule | Violation | Line |
|---|---|---|
| UnnecessaryFullyQualifiedName | Unnecessary use of fully qualified name 'org.apache.commons.lang3.StringUtils.SPACE' due to existing import 'org.apache.commons.lang3.StringUtils' | 351 |
| Rule | Violation | Line |
|---|---|---|
| UnusedImports | Avoid unused imports such as 'fr.paris.lutece.portal.business.user.AdminUserHome' | 88 |
| Rule | Violation | Line |
|---|---|---|
| UnusedImports | Avoid unused imports such as 'fr.paris.lutece.plugins.appointment.service.EntryTypeService' | 48 |
| UnusedImports | Avoid unused imports such as 'fr.paris.lutece.plugins.genericattributes.business.EntryType' | 54 |
| Rule | Violation | Line |
|---|---|---|
| BooleanGetMethodName | A getX() method which returns a boolean should be named isX() | 439–442 |
| BooleanGetMethodName | A getX() method which returns a boolean should be named isX() | 460–463 |
| Rule | Violation | Line |
|---|---|---|
| BooleanGetMethodName | A getX() method which returns a boolean should be named isX() | 488–491 |
| BooleanGetMethodName | A getX() method which returns a boolean should be named isX() | 509–512 |
| BooleanGetMethodName | A getX() method which returns a boolean should be named isX() | 530–533 |
| BooleanGetMethodName | A getX() method which returns a boolean should be named isX() | 551–554 |
| BooleanGetMethodName | A getX() method which returns a boolean should be named isX() | 572–575 |
| BooleanGetMethodName | A getX() method which returns a boolean should be named isX() | 593–596 |
| BooleanGetMethodName | A getX() method which returns a boolean should be named isX() | 614–617 |
| BooleanGetMethodName | A getX() method which returns a boolean should be named isX() | 705–708 |
| BooleanGetMethodName | A getX() method which returns a boolean should be named isX() | 726–729 |
| BooleanGetMethodName | A getX() method which returns a boolean should be named isX() | 747–750 |
| BooleanGetMethodName | A getX() method which returns a boolean should be named isX() | 810–813 |
| BooleanGetMethodName | A getX() method which returns a boolean should be named isX() | 852–855 |
| BooleanGetMethodName | A getX() method which returns a boolean should be named isX() | 936–939 |
| BooleanGetMethodName | A getX() method which returns a boolean should be named isX() | 1055–1058 |
| BooleanGetMethodName | A getX() method which returns a boolean should be named isX() | 1076–1079 |
| Rule | Violation | Line |
|---|---|---|
| BooleanGetMethodName | A getX() method which returns a boolean should be named isX() | 209–212 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| CommentRequired | Header comments are required | 3 | 39–159 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 3 | 96–103 |
| NullAssignment | Assigning an Object to null is a code smell. Consider refactoring. | 3 | 102 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 3 | 150–157 |
| NullAssignment | Assigning an Object to null is a code smell. Consider refactoring. | 3 | 156 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| BooleanGetMethodName | A getX() method which returns a boolean should be named isX() | 4 | 181–184 |
| CommentRequired | Public method and constructor comments are required | 3 | 342–352 |
| CommentRequired | Public method and constructor comments are required | 3 | 354–368 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 3 | 456–463 |
| NullAssignment | Assigning an Object to null is a code smell. Consider refactoring. | 3 | 462 |
| BooleanGetMethodName | A getX() method which returns a boolean should be named isX() | 4 | 471–474 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| TooManyMethods | This class has too many methods, consider refactoring it. | 3 | 62–830 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 3 | 374 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 3 | 444 |
| CyclomaticComplexity | The method 'addFilterParametersToDAOUtil(AppointmentFilterDTO, DAOUtil)' has a cyclomatic complexity of 13. | 3 | 497–561 |
| NPathComplexity | The method 'addFilterParametersToDAOUtil(AppointmentFilterDTO, DAOUtil)' has an NPath complexity of 2304 | 3 | 497–561 |
| UseLocaleWithCaseConversions | When doing a String.toLowerCase()/toUpperCase() call, use a Locale | 3 | 506 |
| UseLocaleWithCaseConversions | When doing a String.toLowerCase()/toUpperCase() call, use a Locale | 3 | 510 |
| UseLocaleWithCaseConversions | When doing a String.toLowerCase()/toUpperCase() call, use a Locale | 3 | 514 |
| UseLocaleWithCaseConversions | When doing a String.toLowerCase()/toUpperCase() call, use a Locale | 3 | 518 |
| CyclomaticComplexity | The method 'getSqlQueryFromFilter(AppointmentFilterDTO, String)' has a cyclomatic complexity of 11. | 3 | 570–629 |
| NPathComplexity | The method 'getSqlQueryFromFilter(AppointmentFilterDTO, String)' has an NPath complexity of 1024 | 3 | 570–629 |
| CyclomaticComplexity | The method 'getOrderQuery(AppointmentFilterDTO, String)' has a cyclomatic complexity of 11. | 3 | 631–680 |
| MissingBreakInSwitch | A switch statement does not contain a break | 3 | 642–670 |
| AvoidReassigningParameters | Avoid reassigning parameters such as 'nIndex' | 2 | 746 |
| AvoidReassigningParameters | Avoid reassigning parameters such as 'nIndex' | 2 | 746 |
| AvoidReassigningParameters | Avoid reassigning parameters such as 'nIndex' | 2 | 746 |
| AvoidReassigningParameters | Avoid reassigning parameters such as 'nIndex' | 2 | 746 |
| AvoidReassigningParameters | Avoid reassigning parameters such as 'nIndex' | 2 | 746 |
| AvoidReassigningParameters | Avoid reassigning parameters such as 'nIndex' | 2 | 746 |
| AvoidReassigningParameters | Avoid reassigning parameters such as 'nIndex' | 2 | 746 |
| AvoidReassigningParameters | Avoid reassigning parameters such as 'nIndex' | 2 | 746 |
| AvoidReassigningParameters | Avoid reassigning parameters such as 'nIndex' | 2 | 746 |
| AvoidReassigningParameters | Avoid reassigning parameters such as 'nIndex' | 2 | 769 |
| AvoidReassigningParameters | Avoid reassigning parameters such as 'nIndex' | 2 | 769 |
| AvoidReassigningParameters | Avoid reassigning parameters such as 'nIndex' | 2 | 769 |
| AvoidReassigningParameters | Avoid reassigning parameters such as 'nIndex' | 2 | 769 |
| AvoidReassigningParameters | Avoid reassigning parameters such as 'nIndex' | 2 | 769 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| TooManyMethods | This class has too many methods, consider refactoring it. | 3 | 51–243 |
| CommentRequired | Public method and constructor comments are required | 3 | 214–217 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| CommentRequired | Header comments are required | 3 | 38–112 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| TooManyMethods | This class has too many methods, consider refactoring it. | 3 | 48–209 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 3 | 73–80 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 3 | 82–89 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| CommentRequired | Header comments are required | 3 | 40–73 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| ShortClassName | Avoid short class names like Form | 4 | 58–541 |
| TooManyFields | Too many fields | 3 | 58–541 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 3 | 306–313 |
| NullAssignment | Assigning an Object to null is a code smell. Consider refactoring. | 3 | 312 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 3 | 360–367 |
| NullAssignment | Assigning an Object to null is a code smell. Consider refactoring. | 3 | 366 |
| BooleanGetMethodName | A getX() method which returns a boolean should be named isX() | 4 | 375–378 |
| BooleanGetMethodName | A getX() method which returns a boolean should be named isX() | 4 | 446–449 |
| CommentRequired | Public method and constructor comments are required | 3 | 521–524 |
| CommentRequired | Public method and constructor comments are required | 3 | 526–529 |
| CommentRequired | Public method and constructor comments are required | 3 | 531–534 |
| CommentRequired | Public method and constructor comments are required | 3 | 536–539 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| TooManyMethods | This class has too many methods, consider refactoring it. | 3 | 50–276 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| CommentRequired | Header comments are required | 3 | 41–195 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 3 | 171–178 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 3 | 179–186 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| TooManyFields | Too many fields | 3 | 44–543 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 3 | 134–141 |
| NullAssignment | Assigning an Object to null is a code smell. Consider refactoring. | 3 | 140 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| TooManyMethods | This class has too many methods, consider refactoring it. | 3 | 52–237 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| BooleanGetMethodName | A getX() method which returns a boolean should be named isX() | 4 | 223–226 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| TooManyMethods | This class has too many methods, consider refactoring it. | 3 | 52–245 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| CallSuperInConstructor | It is a good practice to call super() in a constructor | 3 | 61–64 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| CallSuperInConstructor | It is a good practice to call super() in a constructor | 3 | 56–59 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| ShortVariable | Avoid variables with short names like p | 3 | 68 |
| ShortVariable | Avoid variables with short names like p | 3 | 105 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| CallSuperInConstructor | It is a good practice to call super() in a constructor | 3 | 58–61 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| BooleanGetMethodName | A getX() method which returns a boolean should be named isX() | 4 | 127–130 |
| BooleanGetMethodName | A getX() method which returns a boolean should be named isX() | 4 | 148–151 |
| BooleanGetMethodName | A getX() method which returns a boolean should be named isX() | 4 | 169–172 |
| BooleanGetMethodName | A getX() method which returns a boolean should be named isX() | 4 | 274–277 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| AvoidSynchronizedAtMethodLevel | Use block level rather than method level synchronization | 3 | 59–69 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| BooleanGetMethodName | A getX() method which returns a boolean should be named isX() | 4 | 191–194 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| TooManyMethods | This class has too many methods, consider refactoring it. | 3 | 49–229 |
| UnnecessaryModifier | Unnecessary modifier 'public' on method 'deleteByIdForm': the method is declared in an interface type | 3 | 88 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| DataClass | The class 'Period' is suspected to be a Data Class (WOC=0.000%, NOPA=0, NOAM=4, WMC=5) | 3 | 39–105 |
| CommentRequired | Header comments are required | 3 | 39–105 |
| CommentRequired | Public method and constructor comments are required | 3 | 57–61 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| ShortClassName | Avoid short class names like Slot | 4 | 51–514 |
| BooleanGetMethodName | A getX() method which returns a boolean should be named isX() | 4 | 322–325 |
| BooleanGetMethodName | A getX() method which returns a boolean should be named isX() | 4 | 343–346 |
| BooleanGetMethodName | A getX() method which returns a boolean should be named isX() | 4 | 364–367 |
| BooleanGetMethodName | A getX() method which returns a boolean should be named isX() | 4 | 490–498 |
| AvoidLiteralsInIfCondition | Avoid using Literals in Conditional Statements | 3 | 492 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| TooManyMethods | This class has too many methods, consider refactoring it. | 3 | 53–375 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| TooManyMethods | This class has too many methods, consider refactoring it. | 3 | 52–280 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| ShortClassName | Avoid short class names like User | 4 | 51–247 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UseLocaleWithCaseConversions | When doing a String.toLowerCase()/toUpperCase() call, use a Locale | 3 | 148 |
| UseLocaleWithCaseConversions | When doing a String.toLowerCase()/toUpperCase() call, use a Locale | 3 | 149 |
| UseLocaleWithCaseConversions | When doing a String.toLowerCase()/toUpperCase() call, use a Locale | 3 | 150 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| CommentRequired | Header comments are required | 3 | 36–58 |
| CommentRequired | Public method and constructor comments are required | 3 | 53–57 |
| ShortVariable | Avoid variables with short names like e | 3 | 53 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| CommentRequired | Header comments are required | 3 | 36–58 |
| ShortVariable | Avoid variables with short names like e | 3 | 53 |
| CommentRequired | Public method and constructor comments are required | 3 | 53–57 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| CommentRequired | Header comments are required | 3 | 36–58 |
| CommentRequired | Public method and constructor comments are required | 3 | 53–57 |
| ShortVariable | Avoid variables with short names like e | 3 | 53 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| ClassNamingConventions | The utility class name 'LogUtilities' doesn't match '[A-Z][a-zA-Z0-9]+(Utils?|Helper|Home|Service)' | 1 | 42–67 |
| CommentRequired | Header comments are required | 3 | 42–67 |
| ShortVariable | Avoid variables with short names like BY | 3 | 46 |
| CommentRequired | Public method and constructor comments are required | 3 | 56–65 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| CommentRequired | Enum comments are required | 3 | 47–113 |
| FieldNamingConventions | The final field name '_executorService' doesn't match '[a-z][a-zA-Z0-9]*' | 1 | 51 |
| DoNotUseThreads | To be compliant to J2EE, a webapp should not use any thread. | 3 | 66 |
| DoNotUseThreads | To be compliant to J2EE, a webapp should not use any thread. | 3 | 83 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| DataClass | The class 'AppointmentResourceIdService' is suspected to be a Data Class (WOC=0.000%, NOPA=16, NOAM=0, WMC=1) | 3 | 57–237 |
| CallSuperInConstructor | It is a good practice to call super() in a constructor | 3 | 112–115 |
| NcssCount | The method 'register()' has a NCSS line count of 65. | 3 | 121–202 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| ExcessiveImports | A high number of imports can indicate a high degree of coupling within an object. | 3 | 34–627 |
| GodClass | Possible God Class (WMC=60, ATFD=106, TCC=0.000%) | 3 | 77–627 |
| TooManyMethods | This class has too many methods, consider refactoring it. | 3 | 78–627 |
| CommentDefaultAccessModifier | To avoid mistakes add a comment at the beginning of the buildAndCreateAppointment method if you want a default access modifier | 3 | 179–223 |
| DefaultPackage | Use explicit scoping instead of the default package private level | 3 | 179–223 |
| UseStringBufferForStringAppends | Prefer StringBuilder (non-synchronized) or StringBuffer (synchronized) over += for concatenating strings | 3 | 212 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 3 | 344–357 |
| UnnecessaryFullyQualifiedName | Unnecessary use of fully qualified name 'org.apache.commons.lang3.StringUtils.SPACE' due to existing import 'org.apache.commons.lang3.StringUtils' | 4 | 351 |
| AvoidCatchingGenericException | Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 3 | 410 |
| AvoidCatchingGenericException | Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 3 | 426 |
| CyclomaticComplexity | The method 'updateAppointment(Appointment)' has a cyclomatic complexity of 11. | 3 | 524–570 |
| AvoidCatchingGenericException | Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 3 | 563 |
| CommentRequired | Public method and constructor comments are required | 3 | 600–625 |
| AvoidLiteralsInIfCondition | Avoid using Literals in Conditional Statements | 3 | 608 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| CommentRequired | Header comments are required | 3 | 39–63 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| ExcessiveImports | A high number of imports can indicate a high degree of coupling within an object. | 3 | 34–1327 |
| UnusedImports | Avoid unused imports such as 'fr.paris.lutece.portal.business.user.AdminUserHome' | 4 | 88 |
| CyclomaticComplexity | The class 'AppointmentUtilities' has a total cyclomatic complexity of 147 (highest 12). | 3 | 101–1327 |
| ClassNamingConventions | The utility class name 'AppointmentUtilities' doesn't match '[A-Z][a-zA-Z0-9]+(Utils?|Helper|Home|Service)' | 1 | 101–1327 |
| GodClass | Possible God Class (WMC=147, ATFD=240, TCC=0.891%) | 3 | 101–1327 |
| ExcessiveClassLength | Avoid really long classes. | 3 | 101–1327 |
| TooManyMethods | This class has too many methods, consider refactoring it. | 3 | 102–1327 |
| FieldNamingConventions | The constant name '_secheduledExecutor' doesn't match '[A-Z][A-Z_0-9]*' | 1 | 123 |
| DoNotUseThreads | To be compliant to J2EE, a webapp should not use any thread. | 3 | 124 |
| AvoidDeeplyNestedIfStmts | Deeply nested if..then statements are hard to read | 3 | 221–234 |
| AvoidDeeplyNestedIfStmts | Deeply nested if..then statements are hard to read | 3 | 275–279 |
| AvoidDeeplyNestedIfStmts | Deeply nested if..then statements are hard to read | 3 | 313–316 |
| AvoidDeeplyNestedIfStmts | Deeply nested if..then statements are hard to read | 3 | 346–349 |
| CyclomaticComplexity | The method 'checkNbMaxAppointmentsOnAGivenPeriod(AppointmentDTO, String, AppointmentFormDTO)' has a cyclomatic complexity of 11. | 3 | 369–430 |
| AvoidDeeplyNestedIfStmts | Deeply nested if..then statements are hard to read | 3 | 414–418 |
| AvoidDeeplyNestedIfStmts | Deeply nested if..then statements are hard to read | 3 | 421–425 |
| AvoidCatchingGenericException | Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 3 | 504 |
| AvoidCatchingNPE | Avoid catching NullPointerException; consider removing the cause of the NPE. | 3 | 504 |
| UseObjectForClearerAPI | Rather than using a lot of String arguments, consider using a container object for those values. | 3 | 547 |
| CommentRequired | Public method and constructor comments are required | 3 | 594–606 |
| ControlStatementBraces | This statement should have braces | 3 | 659 |
| CommentRequired | Public method and constructor comments are required | 3 | 664–668 |
| ShortVariable | Avoid variables with short names like nI | 3 | 725 |
| EmptyIfStmt | Avoid empty if statements | 3 | 836–838 |
| EmptyIfStmt | Avoid empty if statements | 3 | 904–906 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 924 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 925 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 926 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 927 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 3 | 955–970 |
| CommentRequired | Public method and constructor comments are required | 3 | 1055–1066 |
| CommentRequired | Public method and constructor comments are required | 3 | 1068–1080 |
| CyclomaticComplexity | The method 'weekIsOpenInFO(AppointmentFormDTO, List, Locale)' has a cyclomatic complexity of 12. | 3 | 1137–1179 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 3 | 1309–1319 |
| AvoidCatchingGenericException | Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 3 | 1321 |
| AvoidCatchingNPE | Avoid catching NullPointerException; consider removing the cause of the NPE. | 3 | 1321 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| CommentRequired | Header comments are required | 3 | 51–428 |
| ClassWithOnlyPrivateConstructorsShouldBeFinal | A class which only has private constructors should be final | 1 | 51–428 |
| ExcessiveMethodLength | Avoid really long methods. | 3 | 74–218 |
| CyclomaticComplexity | The method 'buildListSlot(int, Map, LocalDate, LocalDate)' has a cyclomatic complexity of 19. | 3 | 74–218 |
| NcssCount | The method 'buildListSlot(int, Map, LocalDate, LocalDate)' has a NCSS line count of 78. | 3 | 74–218 |
| NullAssignment | Assigning an Object to null is a code smell. Consider refactoring. | 3 | 112 |
| NullAssignment | Assigning an Object to null is a code smell. Consider refactoring. | 3 | 124 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 3 | 131–214 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 3 | 160–171 |
| NcssCount | The method 'buildListSlot(int, Map, LocalDate, LocalDate, int, boolean)' has a NCSS line count of 96. | 3 | 237–402 |
| ExcessiveMethodLength | Avoid really long methods. | 3 | 237–402 |
| CyclomaticComplexity | The method 'buildListSlot(int, Map, LocalDate, LocalDate, int, boolean)' has a cyclomatic complexity of 17. | 3 | 237–402 |
| NPathComplexity | The method 'buildListSlot(int, Map, LocalDate, LocalDate, int, boolean)' has an NPath complexity of 699 | 3 | 237–402 |
| NullAssignment | Assigning an Object to null is a code smell. Consider refactoring. | 3 | 287 |
| NullAssignment | Assigning an Object to null is a code smell. Consider refactoring. | 3 | 298 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 3 | 341–352 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 208 |
| AvoidLiteralsInIfCondition | Avoid using Literals in Conditional Statements | 3 | 227 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| CommentRequired | Header comments are required | 3 | 60–264 |
| ClassWithOnlyPrivateConstructorsShouldBeFinal | A class which only has private constructors should be final | 1 | 60–264 |
| CommentRequired | Public method and constructor comments are required | 3 | 195–231 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 3 | 244 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| ExcessiveImports | A high number of imports can indicate a high degree of coupling within an object. | 3 | 34–806 |
| CyclomaticComplexity | The class 'EntryService' has a total cyclomatic complexity of 90 (highest 16). | 3 | 76–806 |
| GodClass | Possible God Class (WMC=90, ATFD=184, TCC=0.585%) | 3 | 76–806 |
| TooManyMethods | This class has too many methods, consider refactoring it. | 3 | 77–806 |
| CyclomaticComplexity | The method 'moveDownEntryOrder(int, Entry)' has a cyclomatic complexity of 16. | 3 | 139–234 |
| ForLoopCanBeForeach | This for loop can be replaced by a foreach loop | 3 | 166–199 |
| CyclomaticComplexity | The method 'moveUpEntryOrder(int, Entry)' has a cyclomatic complexity of 13. | 3 | 244–318 |
| ForLoopCanBeForeach | This for loop can be replaced by a foreach loop | 3 | 269–299 |
| LinguisticNaming | Linguistics Antipattern - The getter 'getHtmlEntry' should not return void linguistically | 3 | 518–581 |
| CyclomaticComplexity | The method 'getHtmlEntry(Map, int, StringBuilder, Locale, boolean, AppointmentDTO)' has a cyclomatic complexity of 14. | 3 | 518–581 |
| CyclomaticComplexity | The method 'getResponseEntry(HttpServletRequest, int, List, boolean, Locale, AppointmentDTO)' has a cyclomatic complexity of 13. | 3 | 621–696 |
| AvoidReassigningLoopVariables | Avoid reassigning the loop control variable 'field' | 3 | 631 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 3 | 655–669 |
| UnusedFormalParameter | Avoid unused method parameters such as 'stringBuffer'. | 3 | 796 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| FieldDeclarationsShouldBeAtStartOfClass | Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. | 3 | 61 |
| FieldDeclarationsShouldBeAtStartOfClass | Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. | 3 | 63 |
| FieldDeclarationsShouldBeAtStartOfClass | Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. | 3 | 64 |
| FieldDeclarationsShouldBeAtStartOfClass | Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. | 3 | 65 |
| FieldDeclarationsShouldBeAtStartOfClass | Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. | 3 | 66 |
| FieldDeclarationsShouldBeAtStartOfClass | Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. | 3 | 67 |
| FieldDeclarationsShouldBeAtStartOfClass | Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. | 3 | 68 |
| FieldDeclarationsShouldBeAtStartOfClass | Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. | 3 | 69 |
| FieldDeclarationsShouldBeAtStartOfClass | Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. | 3 | 70 |
| FieldDeclarationsShouldBeAtStartOfClass | Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. | 3 | 71 |
| FieldDeclarationsShouldBeAtStartOfClass | Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. | 3 | 72 |
| FieldDeclarationsShouldBeAtStartOfClass | Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. | 3 | 73 |
| FieldDeclarationsShouldBeAtStartOfClass | Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. | 3 | 74 |
| FieldDeclarationsShouldBeAtStartOfClass | Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. | 3 | 75 |
| FieldDeclarationsShouldBeAtStartOfClass | Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. | 3 | 76 |
| FieldDeclarationsShouldBeAtStartOfClass | Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. | 3 | 77 |
| FieldDeclarationsShouldBeAtStartOfClass | Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. | 3 | 78 |
| FieldDeclarationsShouldBeAtStartOfClass | Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. | 3 | 79 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| ExcessiveImports | A high number of imports can indicate a high degree of coupling within an object. | 3 | 34–809 |
| GodClass | Possible God Class (WMC=72, ATFD=155, TCC=0.000%) | 3 | 86–809 |
| TooManyMethods | This class has too many methods, consider refactoring it. | 3 | 87–809 |
| NcssCount | The method 'copyForm(int, String)' has a NCSS line count of 88. | 3 | 105–226 |
| ExcessiveMethodLength | Avoid really long methods. | 3 | 105–226 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 3 | 258 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 3 | 259 |
| AvoidReassigningParameters | Avoid reassigning parameters such as 'reservationRule' | 2 | 411 |
| CyclomaticComplexity | The method 'fillAppointmentFormWithReservationRulePart(AppointmentFormDTO, ReservationRule)' has a cyclomatic complexity of 10. | 3 | 468–515 |
| AvoidCatchingGenericException | Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 3 | 746 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| TooManyMethods | This class has too many methods, consider refactoring it. | 3 | 67–426 |
| AvoidCatchingGenericException | Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 3 | 154 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 3 | 367 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| CommentRequired | Header comments are required | 3 | 38–49 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| ExcessiveImports | A high number of imports can indicate a high degree of coupling within an object. | 3 | 34–1171 |
| CommentRequired | Header comments are required | 3 | 86–1171 |
| GodClass | Possible God Class (WMC=116, ATFD=232, TCC=1.709%) | 3 | 86–1171 |
| CyclomaticComplexity | The class 'SlotSafeService' has a total cyclomatic complexity of 116 (highest 20). | 3 | 86–1171 |
| ExcessiveClassLength | Avoid really long classes. | 3 | 86–1171 |
| TooManyMethods | This class has too many methods, consider refactoring it. | 3 | 87–1171 |
| FieldNamingConventions | The constant name '_listSlot' doesn't match '[A-Z][A-Z_0-9]*' | 1 | 89 |
| FieldNamingConventions | The constant name '_lockFormId' doesn't match '[A-Z][A-Z_0-9]*' | 1 | 90 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 3 | 166–175 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 3 | 208–219 |
| CyclomaticComplexity | The method 'saveAppointment(AppointmentDTO, HttpServletRequest)' has a cyclomatic complexity of 16. | 3 | 336–406 |
| NPathComplexity | The method 'saveAppointment(AppointmentDTO, HttpServletRequest)' has an NPath complexity of 216 | 3 | 336–406 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 338 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 339 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 340 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 342 |
| ControlStatementBraces | This statement should have braces | 3 | 354 |
| AvoidCatchingGenericException | Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 3 | 393 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 3 | 468 |
| DefaultPackage | Use explicit scoping instead of the default package private level | 3 | 485–526 |
| CommentDefaultAccessModifier | To avoid mistakes add a comment at the beginning of the updateRemaningPlacesWithAppointmentMovedDeletedOrCanceled method if you want a default access modifier | 3 | 485–526 |
| CommentDefaultAccessModifier | To avoid mistakes add a comment at the beginning of the updateRemaningPlacesWithAppointmentReactivated method if you want a default access modifier | 3 | 537–560 |
| DefaultPackage | Use explicit scoping instead of the default package private level | 3 | 537–560 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 3 | 582–591 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 3 | 638–657 |
| CyclomaticComplexity | The method 'updateSlotWithShift(Slot, LocalTime)' has a cyclomatic complexity of 11. | 3 | 683–824 |
| NcssCount | The method 'updateSlotWithShift(Slot, LocalTime)' has a NCSS line count of 65. | 3 | 683–824 |
| ExcessiveMethodLength | Avoid really long methods. | 3 | 683–824 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 3 | 727–734 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 3 | 844–852 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 3 | 894–921 |
| ShortVariable | Avoid variables with short names like it | 3 | 982 |
| NPathComplexity | The method 'saveSlots(AppointmentDTO, List, HttpServletRequest)' has an NPath complexity of 441 | 3 | 1005–1084 |
| CyclomaticComplexity | The method 'saveSlots(AppointmentDTO, List, HttpServletRequest)' has a cyclomatic complexity of 20. | 3 | 1005–1084 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 1009 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 1010 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| TooManyMethods | This class has too many methods, consider refactoring it. | 3 | 62–518 |
| LooseCoupling | Avoid using implementation types like 'HashMap'; use the interface instead | 3 | 141 |
| LooseCoupling | Avoid using implementation types like 'HashMap'; use the interface instead | 3 | 222 |
| AvoidLiteralsInIfCondition | Avoid using Literals in Conditional Statements | 3 | 286 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| TooManyMethods | This class has too many methods, consider refactoring it. | 3 | 64–576 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 3 | 217–224 |
| ExcessiveMethodLength | Avoid really long methods. | 3 | 253–376 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| ClassNamingConventions | The utility class name 'Utilities' doesn't match '[A-Z][a-zA-Z0-9]+(Utils?|Helper|Home|Service)' | 1 | 48–128 |
| NonThreadSafeSingleton | Singleton is not thread safe | 3 | 66–69 |
| DefaultPackage | Use explicit scoping instead of the default package private level | 3 | 76–79 |
| CommentDefaultAccessModifier | To avoid mistakes add a comment at the beginning of the resetFormatter method if you want a default access modifier | 3 | 76–79 |
| NullAssignment | Assigning an Object to null is a code smell. Consider refactoring. | 3 | 78 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| GodClass | Possible God Class (WMC=60, ATFD=45, TCC=0.000%) | 3 | 63–568 |
| TooManyMethods | This class has too many methods, consider refactoring it. | 3 | 64–568 |
| LooseCoupling | Avoid using implementation types like 'HashMap'; use the interface instead | 3 | 301 |
| CyclomaticComplexity | The method 'assignWeekDefinition(int, WeekDefinition)' has a cyclomatic complexity of 11. | 3 | 470–534 |
| UnusedFormalParameter | Avoid unused method parameters such as 'nIdForm'. | 3 | 536 |
| AvoidCatchingGenericException | Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 3 | 559 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| LooseCoupling | Avoid using implementation types like 'HashSet'; use the interface instead | 3 | 341 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| ClassNamingConventions | The utility class name 'AppointmentAddOnManager' doesn't match '[A-Z][a-zA-Z0-9]+(Utils?|Helper|Home|Service)' | 1 | 47–77 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| CommentRequired | Header comments are required | 3 | 7–15 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 3 | 107 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| ExcessiveImports | A high number of imports can indicate a high degree of coupling within an object. | 3 | 34–380 |
| CommentRequired | Header comments are required | 3 | 81–380 |
| GodClass | Possible God Class (WMC=51, ATFD=49, TCC=0.000%) | 3 | 81–380 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 3 | 141 |
| UnnecessaryModifier | Unnecessary modifier 'final' on method 'writeWorkbook': private methods cannot be overridden | 3 | 151–191 |
| ShortVariable | Avoid variables with short names like os | 3 | 154 |
| UnnecessaryModifier | Unnecessary modifier 'final' on method 'createHeaderContent': private methods cannot be overridden | 3 | 193–209 |
| UnnecessaryModifier | Unnecessary modifier 'final' on method 'createLineContent': private methods cannot be overridden | 3 | 211–233 |
| NPathComplexity | The method 'addDefaultColumnValues(AppointmentDTO, Form, List, List, StateService, Locale)' has an NPath complexity of 24576 | 3 | 235–300 |
| CyclomaticComplexity | The method 'addDefaultColumnValues(AppointmentDTO, Form, List, List, StateService, Locale)' has a cyclomatic complexity of 16. | 3 | 235–300 |
| UnnecessaryModifier | Unnecessary modifier 'final' on method 'addDefaultColumnValues': private methods cannot be overridden | 3 | 235–300 |
| UnnecessaryModifier | Unnecessary modifier 'final' on method 'getEntryValue': private methods cannot be overridden | 3 | 327–352 |
| ShortVariable | Avoid variables with short names like e | 3 | 327 |
| ShortVariable | Avoid variables with short names like f | 3 | 338 |
| InefficientStringBuffering | Avoid concatenating nonliterals in a StringBuffer/StringBuilder constructor or append(). | 3 | 347 |
| CommentRequired | Public method and constructor comments are required | 3 | 354–362 |
| CommentRequired | Public method and constructor comments are required | 3 | 364–379 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| CommentRequired | Header comments are required | 3 | 51–111 |
| FieldNamingConventions | The final field name '_fileName' doesn't match '[a-z][a-zA-Z0-9]*' | 1 | 60 |
| FieldNamingConventions | The final field name '_fileDescription' doesn't match '[a-z][a-zA-Z0-9]*' | 1 | 61 |
| FieldNamingConventions | The final field name '_defaultColumnList' doesn't match '[a-z][a-zA-Z0-9]*' | 1 | 62 |
| FieldNamingConventions | The final field name '_locale' doesn't match '[a-z][a-zA-Z0-9]*' | 1 | 63 |
| FieldNamingConventions | The final field name '_listAppointmentsDTO' doesn't match '[a-z][a-zA-Z0-9]*' | 1 | 64 |
| FieldNamingConventions | The final field name '_entryList' doesn't match '[a-z][a-zA-Z0-9]*' | 1 | 65 |
| CommentRequired | Public method and constructor comments are required | 3 | 67–77 |
| SimpleDateFormatNeedsLocale | When instantiating a SimpleDateFormat object, specify a Locale | 3 | 70 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| ClassNamingConventions | The utility class name 'AppointmentListenerManager' doesn't match '[A-Z][a-zA-Z0-9]+(Utils?|Helper|Home|Service)' | 1 | 51–174 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| ShortVariable | Avoid variables with short names like se | 3 | 51 |
| ShortVariable | Avoid variables with short names like se | 3 | 60 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| CommentRequired | Header comments are required | 3 | 39–98 |
| ClassNamingConventions | The utility class name 'FormListenerManager' doesn't match '[A-Z][a-zA-Z0-9]+(Utils?|Helper|Home|Service)' | 1 | 39–98 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| ClassNamingConventions | The utility class name 'SlotListenerManager' doesn't match '[A-Z][a-zA-Z0-9]+(Utils?|Helper|Home|Service)' | 1 | 48–126 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| CommentRequired | Header comments are required | 3 | 42–103 |
| ClassNamingConventions | The utility class name 'WeekDefinitionManagerListener' doesn't match '[A-Z][a-zA-Z0-9]+(Utils?|Helper|Home|Service)' | 1 | 42–103 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| DataClass | The class 'SlotEditTask' is suspected to be a Data Class (WOC=0.000%, NOPA=0, NOAM=4, WMC=5) | 3 | 47–113 |
| CommentRequired | Public method and constructor comments are required | 3 | 60–64 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| CommentRequired | Header comments are required | 3 | 38–49 |
| UnnecessaryConstructor | Avoid unnecessary constructors - the compiler will generate these for you | 3 | 44–47 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| CommentRequired | Header comments are required | 3 | 67–364 |
| FieldNamingConventions | The constant name '_captchaSecurityService' doesn't match '[A-Z][A-Z_0-9]*' | 1 | 113 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| ExcessiveImports | A high number of imports can indicate a high degree of coupling within an object. | 3 | 34–512 |
| UnnecessaryAnnotationValueElement | Avoid the use of value in annotations when its the only element | 3 | 147 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 192 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 193 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 194 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 254 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 255 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 256 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 313 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 315 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 316 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 317 |
| AvoidReassigningLoopVariables | Avoid reassigning the loop control variable 'slotImpacted' | 3 | 402 |
| AppendCharacterWithChar | Avoid appending characters as strings in StringBuffer.append. | 3 | 438 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| ExcessiveImports | A high number of imports can indicate a high degree of coupling within an object. | 3 | 34–1902 |
| ExcessiveClassLength | Avoid really long classes. | 3 | 134–1902 |
| SingularField | Perhaps '_strNbPlacesToTakeLength' could be replaced by a local variable. | 3 | 301 |
| ExcessiveMethodLength | Avoid really long methods. | 3 | 315–595 |
| NPathComplexity | The method 'getViewAppointmentCalendar(HttpServletRequest)' has an NPath complexity of 116161920 | 3 | 315–595 |
| NcssCount | The method 'getViewAppointmentCalendar(HttpServletRequest)' has a NCSS line count of 158. | 3 | 315–595 |
| AvoidSynchronizedAtMethodLevel | Use block level rather than method level synchronization | 3 | 315–595 |
| CyclomaticComplexity | The method 'getViewAppointmentCalendar(HttpServletRequest)' has a cyclomatic complexity of 38. | 3 | 315–595 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 334 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 415 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 417 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 420–421 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 3 | 468–479 |
| AvoidSynchronizedAtMethodLevel | Use block level rather than method level synchronization | 3 | 606–832 |
| ExcessiveMethodLength | Avoid really long methods. | 3 | 606–832 |
| NcssCount | The method 'getViewAppointmentForm(HttpServletRequest)' has a NCSS line count of 122. | 3 | 606–832 |
| NPathComplexity | The method 'getViewAppointmentForm(HttpServletRequest)' has an NPath complexity of 76800000 | 3 | 606–832 |
| CyclomaticComplexity | The method 'getViewAppointmentForm(HttpServletRequest)' has a cyclomatic complexity of 38. | 3 | 606–832 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 608 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 609 |
| LinguisticNaming | Linguistics Antipattern - The variable 'isModification' indicates linguistically it is a boolean, but it is 'String' | 3 | 657 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 3 | 660–693 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 669 |
| NullAssignment | Assigning an Object to null is a code smell. Consider refactoring. | 3 | 704 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 3 | 712–774 |
| AvoidReassigningLoopVariables | Avoid reassigning the loop control variable 'slot' | 3 | 725 |
| AvoidReassigningLoopVariables | Avoid reassigning the loop control variable 'slot' | 3 | 729 |
| NullAssignment | Assigning an Object to null is a code smell. Consider refactoring. | 3 | 736 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 3 | 800–808 |
| AvoidSynchronizedAtMethodLevel | Use block level rather than method level synchronization | 3 | 845–952 |
| NcssCount | The method 'doValidateForm(HttpServletRequest)' has a NCSS line count of 69. | 3 | 845–952 |
| CyclomaticComplexity | The method 'doValidateForm(HttpServletRequest)' has a cyclomatic complexity of 18. | 3 | 845–952 |
| ExcessiveMethodLength | Avoid really long methods. | 3 | 845–952 |
| NPathComplexity | The method 'doValidateForm(HttpServletRequest)' has an NPath complexity of 6912 | 3 | 845–952 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 853 |
| NullAssignment | Assigning an Object to null is a code smell. Consider refactoring. | 3 | 858 |
| NullAssignment | Assigning an Object to null is a code smell. Consider refactoring. | 3 | 859 |
| ShortVariable | Avoid variables with short names like lf | 3 | 902 |
| NullAssignment | Assigning an Object to null is a code smell. Consider refactoring. | 3 | 939 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 3 | 943 |
| AvoidSynchronizedAtMethodLevel | Use block level rather than method level synchronization | 3 | 964–1011 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 968 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 3 | 972 |
| NullAssignment | Assigning an Object to null is a code smell. Consider refactoring. | 3 | 980 |
| NullAssignment | Assigning an Object to null is a code smell. Consider refactoring. | 3 | 981 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 3 | 984 |
| CyclomaticComplexity | The method 'doMakeAppointment(HttpServletRequest)' has a cyclomatic complexity of 15. | 3 | 1023–1105 |
| NPathComplexity | The method 'doMakeAppointment(HttpServletRequest)' has an NPath complexity of 1024 | 3 | 1023–1105 |
| AvoidSynchronizedAtMethodLevel | Use block level rather than method level synchronization | 3 | 1023–1105 |
| NullAssignment | Assigning an Object to null is a code smell. Consider refactoring. | 3 | 1034 |
| NullAssignment | Assigning an Object to null is a code smell. Consider refactoring. | 3 | 1035 |
| AvoidSynchronizedAtMethodLevel | Use block level rather than method level synchronization | 3 | 1115–1147 |
| AvoidLiteralsInIfCondition | Avoid using Literals in Conditional Statements | 3 | 1126 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 3 | 1135 |
| NullAssignment | Assigning an Object to null is a code smell. Consider refactoring. | 3 | 1144 |
| NullAssignment | Assigning an Object to null is a code smell. Consider refactoring. | 3 | 1145 |
| NPathComplexity | The method 'getViewChangeDateAppointment(HttpServletRequest)' has an NPath complexity of 2880 | 3 | 1160–1255 |
| CyclomaticComplexity | The method 'getViewChangeDateAppointment(HttpServletRequest)' has a cyclomatic complexity of 17. | 3 | 1160–1255 |
| AvoidSynchronizedAtMethodLevel | Use block level rather than method level synchronization | 3 | 1160–1255 |
| NullAssignment | Assigning an Object to null is a code smell. Consider refactoring. | 3 | 1171 |
| AvoidReassigningLoopVariables | Avoid reassigning the loop control variable 'slot' | 3 | 1198 |
| AvoidReassigningLoopVariables | Avoid reassigning the loop control variable 'slot' | 3 | 1204 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 3 | 1251 |
| AvoidSynchronizedAtMethodLevel | Use block level rather than method level synchronization | 3 | 1265–1275 |
| NullAssignment | Assigning an Object to null is a code smell. Consider refactoring. | 3 | 1268 |
| NullAssignment | Assigning an Object to null is a code smell. Consider refactoring. | 3 | 1269 |
| AvoidSynchronizedAtMethodLevel | Use block level rather than method level synchronization | 3 | 1284–1332 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 3 | 1292 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 3 | 1295–1326 |
| AvoidSynchronizedAtMethodLevel | Use block level rather than method level synchronization | 3 | 1341–1393 |
| CyclomaticComplexity | The method 'doCancelAppointment(HttpServletRequest)' has a cyclomatic complexity of 10. | 3 | 1341–1393 |
| AvoidCatchingGenericException | Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 3 | 1367 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 3 | 1378 |
| AvoidSynchronizedAtMethodLevel | Use block level rather than method level synchronization | 3 | 1403–1419 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 3 | 1409 |
| AvoidSynchronizedAtMethodLevel | Use block level rather than method level synchronization | 3 | 1431–1442 |
| AvoidReassigningParameters | Avoid reassigning parameters such as 'model' | 2 | 1457 |
| AvoidReassigningParameters | Avoid reassigning parameters such as 'model' | 2 | 1502 |
| AvoidReassigningParameters | Avoid reassigning parameters such as 'model' | 2 | 1543 |
| AvoidSynchronizedAtMethodLevel | Use block level rather than method level synchronization | 3 | 1588–1627 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 3 | 1608 |
| AvoidSynchronizedAtMethodLevel | Use block level rather than method level synchronization | 3 | 1637–1723 |
| CyclomaticComplexity | The method 'doProcessWorkflowAction(HttpServletRequest)' has a cyclomatic complexity of 15. | 3 | 1637–1723 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 1644 |
| AvoidCatchingGenericException | Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 3 | 1715 |
| CyclomaticComplexity | The method 'checkMyLuteceAuthentication(AppointmentFormDTO, HttpServletRequest)' has a cyclomatic complexity of 14. | 3 | 1835–1874 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| NullAssignment | Assigning an Object to null is a code smell. Consider refactoring. | 3 | 124 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 3 | 98 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| ExcessiveImports | A high number of imports can indicate a high degree of coupling within an object. | 3 | 34–797 |
| UnusedImports | Avoid unused imports such as 'fr.paris.lutece.plugins.appointment.service.EntryTypeService' | 4 | 48 |
| UnusedImports | Avoid unused imports such as 'fr.paris.lutece.plugins.genericattributes.business.EntryType' | 4 | 54 |
| TooManyMethods | This class has too many methods, consider refactoring it. | 3 | 89–797 |
| ImmutableField | Private field '_entryService' could be made final; it is only initialized in the declaration or constructor. | 3 | 153 |
| UnnecessaryAnnotationValueElement | Avoid the use of value in annotations when its the only element | 3 | 189 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 3 | 219 |
| NPathComplexity | The method 'doCreateEntry(HttpServletRequest)' has an NPath complexity of 234 | 3 | 242–291 |
| CyclomaticComplexity | The method 'doCreateEntry(HttpServletRequest)' has a cyclomatic complexity of 13. | 3 | 242–291 |
| AvoidReassigningLoopVariables | Avoid reassigning the loop control variable 'field' | 3 | 316 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 3 | 321 |
| CyclomaticComplexity | The method 'doModifyEntry(HttpServletRequest)' has a cyclomatic complexity of 11. | 3 | 350–404 |
| AvoidDeeplyNestedIfStmts | Deeply nested if..then statements are hard to read | 3 | 364–367 |
| AvoidDeeplyNestedIfStmts | Deeply nested if..then statements are hard to read | 3 | 375–384 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 3 | 375–384 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 3 | 393–400 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 449 |
| CyclomaticComplexity | The method 'doChangeOrderEntry(HttpServletRequest)' has a cyclomatic complexity of 11. | 3 | 601–651 |
| CommentRequired | Public method and constructor comments are required | 3 | 726–747 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 3 | 136 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 456 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 457 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 458 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| ExcessiveImports | A high number of imports can indicate a high degree of coupling within an object. | 3 | 34–814 |
| ImmutableField | Private field '_nDefaultItemsPerPage' could be made final; it is only initialized in the declaration or constructor. | 3 | 188 |
| CallSuperInConstructor | It is a good practice to call super() in a constructor | 3 | 196–199 |
| NullAssignment | Assigning an Object to null is a code smell. Consider refactoring. | 3 | 212 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 367 |
| NPathComplexity | The method 'doModifyAppointmentForm(HttpServletRequest)' has an NPath complexity of 384 | 3 | 448–503 |
| CyclomaticComplexity | The method 'doModifyAppointmentForm(HttpServletRequest)' has a cyclomatic complexity of 13. | 3 | 448–503 |
| NullAssignment | Assigning an Object to null is a code smell. Consider refactoring. | 3 | 499 |
| CyclomaticComplexity | The method 'doChangeFormActivation(HttpServletRequest)' has a cyclomatic complexity of 11. | 3 | 515–559 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 3 | 617 |
| CyclomaticComplexity | The method 'importClosingDayFile(MultipartHttpServletRequest, int)' has a cyclomatic complexity of 11. | 3 | 722–793 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| ExcessiveImports | A high number of imports can indicate a high degree of coupling within an object. | 3 | 34–1816 |
| ExcessiveClassLength | Avoid really long classes. | 3 | 149–1816 |
| TooManyMethods | This class has too many methods, consider refactoring it. | 3 | 150–1816 |
| ImmutableField | Private field '_nDefaultItemsPerPage' could be made final; it is only initialized in the declaration or constructor. | 3 | 319 |
| DefaultPackage | Use explicit scoping instead of the default package private level | 3 | 326 |
| CommentDefaultAccessModifier | To avoid mistakes add a comment at the beginning of the listFormErrors field if you want a default access modifier | 3 | 326 |
| FieldNamingConventions | The field name 'listFormErrors' doesn't match '_[a-z][a-zA-Z0-9]*' | 1 | 326 |
| DefaultPackage | Use explicit scoping instead of the default package private level | 3 | 327 |
| CommentDefaultAccessModifier | To avoid mistakes add a comment at the beginning of the _moduleAppointmentDesk field if you want a default access modifier | 3 | 327 |
| ExcessiveMethodLength | Avoid really long methods. | 3 | 338–505 |
| NcssCount | The method 'getViewCalendarManageAppointments(HttpServletRequest)' has a NCSS line count of 94. | 3 | 338–505 |
| NPathComplexity | The method 'getViewCalendarManageAppointments(HttpServletRequest)' has an NPath complexity of 62400 | 3 | 338–505 |
| AvoidSynchronizedAtMethodLevel | Use block level rather than method level synchronization | 3 | 338–505 |
| CyclomaticComplexity | The method 'getViewCalendarManageAppointments(HttpServletRequest)' has a cyclomatic complexity of 24. | 3 | 338–505 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 3 | 449–458 |
| UnnecessaryAnnotationValueElement | Avoid the use of value in annotations when its the only element | 3 | 515 |
| CyclomaticComplexity | The method 'getManageAppointments(HttpServletRequest)' has a cyclomatic complexity of 21. | 3 | 516–649 |
| NPathComplexity | The method 'getManageAppointments(HttpServletRequest)' has an NPath complexity of 10080 | 3 | 516–649 |
| AvoidSynchronizedAtMethodLevel | Use block level rather than method level synchronization | 3 | 516–649 |
| NcssCount | The method 'getManageAppointments(HttpServletRequest)' has a NCSS line count of 86. | 3 | 516–649 |
| ExcessiveMethodLength | Avoid really long methods. | 3 | 516–649 |
| NullAssignment | Assigning an Object to null is a code smell. Consider refactoring. | 3 | 531 |
| NullAssignment | Assigning an Object to null is a code smell. Consider refactoring. | 3 | 532 |
| NullAssignment | Assigning an Object to null is a code smell. Consider refactoring. | 3 | 533 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 3 | 537–560 |
| AvoidSynchronizedAtMethodLevel | Use block level rather than method level synchronization | 3 | 659–666 |
| AvoidSynchronizedAtMethodLevel | Use block level rather than method level synchronization | 3 | 679–693 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 681 |
| AvoidSynchronizedAtMethodLevel | Use block level rather than method level synchronization | 3 | 703–710 |
| AvoidSynchronizedAtMethodLevel | Use block level rather than method level synchronization | 3 | 722–743 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 724 |
| AvoidSynchronizedAtMethodLevel | Use block level rather than method level synchronization | 3 | 757–840 |
| CyclomaticComplexity | The method 'getViewAppointment(HttpServletRequest)' has a cyclomatic complexity of 13. | 3 | 757–840 |
| NPathComplexity | The method 'getViewAppointment(HttpServletRequest)' has an NPath complexity of 336 | 3 | 757–840 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 762 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 763 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 765 |
| AvoidSynchronizedAtMethodLevel | Use block level rather than method level synchronization | 3 | 854–892 |
| AvoidSynchronizedAtMethodLevel | Use block level rather than method level synchronization | 3 | 904–1081 |
| NPathComplexity | The method 'getViewCreateAppointment(HttpServletRequest)' has an NPath complexity of 201480 | 3 | 904–1081 |
| CyclomaticComplexity | The method 'getViewCreateAppointment(HttpServletRequest)' has a cyclomatic complexity of 29. | 3 | 904–1081 |
| ExcessiveMethodLength | Avoid really long methods. | 3 | 904–1081 |
| NcssCount | The method 'getViewCreateAppointment(HttpServletRequest)' has a NCSS line count of 90. | 3 | 904–1081 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 908 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 910 |
| LinguisticNaming | Linguistics Antipattern - The variable 'isModification' indicates linguistically it is a boolean, but it is 'String' | 3 | 919 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 3 | 922–964 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 3 | 971–985 |
| NullAssignment | Assigning an Object to null is a code smell. Consider refactoring. | 3 | 978 |
| AvoidReassigningLoopVariables | Avoid reassigning the loop control variable 'slot' | 3 | 1004 |
| AvoidReassigningLoopVariables | Avoid reassigning the loop control variable 'slot' | 3 | 1010 |
| NullAssignment | Assigning an Object to null is a code smell. Consider refactoring. | 3 | 1018 |
| CyclomaticComplexity | The method 'doValidateForm(HttpServletRequest)' has a cyclomatic complexity of 12. | 3 | 1093–1168 |
| AvoidSynchronizedAtMethodLevel | Use block level rather than method level synchronization | 3 | 1093–1168 |
| NPathComplexity | The method 'doValidateForm(HttpServletRequest)' has an NPath complexity of 432 | 3 | 1093–1168 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 1096 |
| ShortVariable | Avoid variables with short names like lf | 3 | 1134 |
| NullAssignment | Assigning an Object to null is a code smell. Consider refactoring. | 3 | 1166 |
| NPathComplexity | The method 'getViewChangeDateAppointment(HttpServletRequest)' has an NPath complexity of 816 | 3 | 1180–1277 |
| CyclomaticComplexity | The method 'getViewChangeDateAppointment(HttpServletRequest)' has a cyclomatic complexity of 15. | 3 | 1180–1277 |
| AvoidSynchronizedAtMethodLevel | Use block level rather than method level synchronization | 3 | 1180–1277 |
| AvoidReassigningLoopVariables | Avoid reassigning the loop control variable 'slot' | 3 | 1219 |
| AvoidReassigningLoopVariables | Avoid reassigning the loop control variable 'slot' | 3 | 1223 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 3 | 1273 |
| AvoidSynchronizedAtMethodLevel | Use block level rather than method level synchronization | 3 | 1287–1305 |
| CyclomaticComplexity | The method 'doMakeAppointment(HttpServletRequest)' has a cyclomatic complexity of 11. | 3 | 1317–1372 |
| AvoidSynchronizedAtMethodLevel | Use block level rather than method level synchronization | 3 | 1317–1372 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 1319 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 3 | 1367 |
| NullAssignment | Assigning an Object to null is a code smell. Consider refactoring. | 3 | 1370 |
| AvoidSynchronizedAtMethodLevel | Use block level rather than method level synchronization | 3 | 1385–1433 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 1388 |
| ShortVariable | Avoid variables with short names like os | 3 | 1420 |
| AvoidSynchronizedAtMethodLevel | Use block level rather than method level synchronization | 3 | 1448–1491 |
| ShortVariable | Avoid variables with short names like os | 3 | 1478 |
| CallSuperInConstructor | It is a good practice to call super() in a constructor | 3 | 1496–1499 |
| NullAssignment | Assigning an Object to null is a code smell. Consider refactoring. | 3 | 1503 |
| NullAssignment | Assigning an Object to null is a code smell. Consider refactoring. | 3 | 1504 |
| NullAssignment | Assigning an Object to null is a code smell. Consider refactoring. | 3 | 1505 |
| NullAssignment | Assigning an Object to null is a code smell. Consider refactoring. | 3 | 1506 |
| CyclomaticComplexity | The method 'orderList(List)' has a cyclomatic complexity of 11. | 3 | 1531–1576 |
| MissingBreakInSwitch | A switch statement does not contain a break | 3 | 1540–1569 |
| AvoidSynchronizedAtMethodLevel | Use block level rather than method level synchronization | 3 | 1608–1646 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 3 | 1628 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 3 | 1637 |
| AvoidSynchronizedAtMethodLevel | Use block level rather than method level synchronization | 3 | 1656–1723 |
| CyclomaticComplexity | The method 'doProcessWorkflowAction(HttpServletRequest)' has a cyclomatic complexity of 14. | 3 | 1656–1723 |
| AvoidCatchingGenericException | Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 3 | 1712 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 3 | 1716 |
| AvoidSynchronizedAtMethodLevel | Use block level rather than method level synchronization | 3 | 1735–1775 |
| CyclomaticComplexity | The method 'doChangeAppointmentStatus(HttpServletRequest)' has a cyclomatic complexity of 11. | 3 | 1735–1775 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 1742 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| NullAssignment | Assigning an Object to null is a code smell. Consider refactoring. | 3 | 159 |
| CyclomaticComplexity | The method 'getCreateModifyTemplate(HttpServletRequest)' has a cyclomatic complexity of 10. | 3 | 191–249 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| NullAssignment | Assigning an Object to null is a code smell. Consider refactoring. | 3 | 147 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 166 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 196 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 198 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 199 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 200 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 3 | 228–237 |
| NPathComplexity | The method 'doModifyComment(HttpServletRequest)' has an NPath complexity of 216 | 3 | 287–337 |
| CyclomaticComplexity | The method 'doModifyComment(HttpServletRequest)' has a cyclomatic complexity of 11. | 3 | 287–337 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 291 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 292 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 3 | 320–328 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 383 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| NullAssignment | Assigning an Object to null is a code smell. Consider refactoring. | 3 | 103 |
| UnnecessaryAnnotationValueElement | Avoid the use of value in annotations when its the only element | 3 | 118 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| ExcessiveImports | A high number of imports can indicate a high degree of coupling within an object. | 3 | 34–736 |
| CyclomaticComplexity | The method 'getViewManageSpecificWeek(HttpServletRequest)' has a cyclomatic complexity of 10. | 3 | 180–243 |
| NullAssignment | Assigning an Object to null is a code smell. Consider refactoring. | 3 | 182 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 184 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 257 |
| CyclomaticComplexity | The method 'doModifySlot(HttpServletRequest)' has a cyclomatic complexity of 16. | 3 | 299–387 |
| NPathComplexity | The method 'doModifySlot(HttpServletRequest)' has an NPath complexity of 2898 | 3 | 299–387 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 301 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 302 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 303 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 304 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 305 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 306 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 308 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 3 | 383 |
| CyclomaticComplexity | The method 'doModifyListSlots(HttpServletRequest)' has a cyclomatic complexity of 16. | 3 | 398–514 |
| NPathComplexity | The method 'doModifyListSlots(HttpServletRequest)' has an NPath complexity of 1440 | 3 | 398–514 |
| ExcessiveMethodLength | Avoid really long methods. | 3 | 398–514 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 400 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 401 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 402 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 403 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 406 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 407 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 408 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 409 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 411 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 412 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 413 |
| GuardLogStatement | Logger calls should be surrounded by log level guards. | 2 | 450 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 3 | 465–478 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 3 | 499–509 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 3 | 510 |
| ExcessiveMethodLength | Avoid really long methods. | 3 | 597–705 |
| CyclomaticComplexity | The method 'updateListSlots(List, int, int, boolean, boolean, boolean, LocalTime)' has a cyclomatic complexity of 27. | 3 | 597–705 |
| NPathComplexity | The method 'updateListSlots(List, int, int, boolean, boolean, boolean, LocalTime)' has an NPath complexity of 34056 | 3 | 597–705 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 3 | 630 |
| AppendCharacterWithChar | Avoid appending characters as strings in StringBuffer.append. | 3 | 669 |
| ControlStatementBraces | This statement should have braces | 3 | 692 |
| ControlStatementBraces | This statement should have braces | 3 | 695 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| ExcessiveImports | A high number of imports can indicate a high degree of coupling within an object. | 3 | 34–1010 |
| TooManyMethods | This class has too many methods, consider refactoring it. | 3 | 94–1010 |
| UnnecessaryAnnotationValueElement | Avoid the use of value in annotations when its the only element | 3 | 180 |
| CyclomaticComplexity | The method 'getViewManageTypicalWeek(HttpServletRequest)' has a cyclomatic complexity of 11. | 3 | 181–249 |
| NullAssignment | Assigning an Object to null is a code smell. Consider refactoring. | 3 | 183 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 184 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 186 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 187 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 3 | 200–214 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 263 |
| CyclomaticComplexity | The method 'doModifyAdvancedParameters(HttpServletRequest)' has a cyclomatic complexity of 12. | 3 | 293–366 |
| NPathComplexity | The method 'doModifyAdvancedParameters(HttpServletRequest)' has an NPath complexity of 256 | 3 | 293–366 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 302 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 303 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 433 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 470 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 471 |
| CyclomaticComplexity | The method 'doModifyTimeSlot(HttpServletRequest)' has a cyclomatic complexity of 18. | 3 | 515–635 |
| NPathComplexity | The method 'doModifyTimeSlot(HttpServletRequest)' has an NPath complexity of 6336 | 3 | 515–635 |
| ExcessiveMethodLength | Avoid really long methods. | 3 | 515–635 |
| NcssCount | The method 'doModifyTimeSlot(HttpServletRequest)' has a NCSS line count of 69. | 3 | 515–635 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 518 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 520 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 534 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 535 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 536 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 537 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 538 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 539 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 540 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 3 | 573 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 3 | 608 |
| NPathComplexity | The method 'doModifyListTimeSlot(HttpServletRequest)' has an NPath complexity of 114048 | 3 | 646–820 |
| NcssCount | The method 'doModifyListTimeSlot(HttpServletRequest)' has a NCSS line count of 86. | 3 | 646–820 |
| CyclomaticComplexity | The method 'doModifyListTimeSlot(HttpServletRequest)' has a cyclomatic complexity of 25. | 3 | 646–820 |
| ExcessiveMethodLength | Avoid really long methods. | 3 | 646–820 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 649 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 650 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 652 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 653 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 654 |
| GuardLogStatement | Logger calls should be surrounded by log level guards. | 2 | 661 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 666 |
| PositionLiteralsFirstInCaseInsensitiveComparisons | Position literals first in String comparisons for EqualsIgnoreCase | 3 | 689 |
| PositionLiteralsFirstInCaseInsensitiveComparisons | Position literals first in String comparisons for EqualsIgnoreCase | 3 | 689 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 695 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 3 | 795 |
| AvoidReassigningLoopVariables | Avoid reassigning the loop control variable 'slotImpacted' | 3 | 880 |
| CyclomaticComplexity | The method 'manageTheSlotsAndAppointmentsImpacted(List, List, int, int, boolean, boolean)' has a cyclomatic complexity of 10. | 3 | 902–959 |
| AvoidReassigningParameters | Avoid reassigning parameters such as 'nMaxCapacity' | 2 | 902 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 3 | 924–936 |
| AvoidReassigningLoopVariables | Avoid reassigning the loop control variable 'slotImpacted' | 3 | 943 |
| AvoidReassigningParameters | Avoid reassigning parameters such as 'nNewNbMaxCapacity' | 2 | 975 |
| AvoidReassigningParameters | Avoid reassigning parameters such as 'slot' | 2 | 975 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| TooManyFields | Too many fields | 3 | 57–519 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 3 | 132 |
| CommentRequired | Public method and constructor comments are required | 3 | 429–432 |
| BooleanGetMethodName | A getX() method which returns a boolean should be named isX() | 4 | 439–442 |
| BooleanGetMethodName | A getX() method which returns a boolean should be named isX() | 4 | 460–463 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| CommentRequired | Header comments are required | 3 | 42–301 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 3 | 121–128 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 3 | 139–146 |
| NullAssignment | Assigning an Object to null is a code smell. Consider refactoring. | 3 | 145 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 3 | 156–163 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 3 | 175–182 |
| NullAssignment | Assigning an Object to null is a code smell. Consider refactoring. | 3 | 181 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| ExcessivePublicCount | This class has a bunch of public methods and attributes | 3 | 34–1169 |
| ExcessiveClassLength | Avoid really long classes. | 3 | 54–1169 |
| CyclomaticComplexity | The class 'AppointmentFormDTO' has a total cyclomatic complexity of 87 (highest 2). | 3 | 54–1169 |
| TooManyFields | Too many fields | 3 | 54–1169 |
| AvoidDuplicateLiterals | The String literal "#i18n{portal.validation.message.notEmpty}" appears 7 times in this file; the first occurrence is on line 97 | 3 | 97 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 3 | 355–362 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 3 | 373–380 |
| NullAssignment | Assigning an Object to null is a code smell. Consider refactoring. | 3 | 379 |
| CommentRequired | Public method and constructor comments are required | 3 | 478–481 |
| BooleanGetMethodName | A getX() method which returns a boolean should be named isX() | 4 | 488–491 |
| BooleanGetMethodName | A getX() method which returns a boolean should be named isX() | 4 | 509–512 |
| BooleanGetMethodName | A getX() method which returns a boolean should be named isX() | 4 | 530–533 |
| BooleanGetMethodName | A getX() method which returns a boolean should be named isX() | 4 | 551–554 |
| BooleanGetMethodName | A getX() method which returns a boolean should be named isX() | 4 | 572–575 |
| BooleanGetMethodName | A getX() method which returns a boolean should be named isX() | 4 | 593–596 |
| BooleanGetMethodName | A getX() method which returns a boolean should be named isX() | 4 | 614–617 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 3 | 637–644 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 3 | 655–662 |
| NullAssignment | Assigning an Object to null is a code smell. Consider refactoring. | 3 | 661 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 3 | 672–679 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 3 | 690–697 |
| NullAssignment | Assigning an Object to null is a code smell. Consider refactoring. | 3 | 696 |
| BooleanGetMethodName | A getX() method which returns a boolean should be named isX() | 4 | 705–708 |
| BooleanGetMethodName | A getX() method which returns a boolean should be named isX() | 4 | 726–729 |
| BooleanGetMethodName | A getX() method which returns a boolean should be named isX() | 4 | 747–750 |
| BooleanGetMethodName | A getX() method which returns a boolean should be named isX() | 4 | 810–813 |
| BooleanGetMethodName | A getX() method which returns a boolean should be named isX() | 4 | 852–855 |
| BooleanGetMethodName | A getX() method which returns a boolean should be named isX() | 4 | 936–939 |
| BooleanGetMethodName | A getX() method which returns a boolean should be named isX() | 4 | 1055–1058 |
| BooleanGetMethodName | A getX() method which returns a boolean should be named isX() | 4 | 1076–1079 |
| CommentRequired | Public method and constructor comments are required | 3 | 1151–1153 |
| CommentRequired | Public method and constructor comments are required | 3 | 1155–1157 |
| CommentRequired | Public method and constructor comments are required | 3 | 1159–1162 |
| CommentRequired | Public method and constructor comments are required | 3 | 1164–1167 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| CommentRequired | Header comments are required | 3 | 40–99 |
| CommentRequired | Public method and constructor comments are required | 3 | 95–98 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| AvoidDuplicateLiterals | The String literal "#i18n{portal.validation.message.notEmpty}" appears 6 times in this file; the first occurrence is on line 82 | 3 | 82 |
| BooleanGetMethodName | A getX() method which returns a boolean should be named isX() | 4 | 209–212 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| ImmutableField | Private field '_response' could be made final; it is only initialized in the declaration or constructor. | 3 | 64 |
| CallSuperInConstructor | It is a good practice to call super() in a constructor | 3 | 72–75 |
| CallSuperInConstructor | It is a good practice to call super() in a constructor | 3 | 85–89 |
| ShortVariable | Avoid variables with short names like o | 3 | 176 |
| ShortVariable | Avoid variables with short names like o | 3 | 187 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| ClassWithOnlyPrivateConstructorsShouldBeFinal | A class which only has private constructors should be final | 1 | 14–96 |
| AvoidSynchronizedAtMethodLevel | Use block level rather than method level synchronization | 3 | 32–35 |
| MissingOverride | The method 'getResourceTypeId()' is missing an @Override annotation. | 3 | 79–82 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| CommentRequired | Header comments are required | 3 | 43–77 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 65 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 3 | 94 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 3 | 121 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 139 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 65 |
