Fork me on GitHub
Produit par Maven

Résultats PMD

Le document suivant contient les résultats de PMD 6.13.0.

Violations By Priority

Priority 1

fr/paris/lutece/plugins/botpress/service/BotRegistrationService.java

Rule Violation Ligne
ClassWithOnlyPrivateConstructorsShouldBeFinal A class which only has private constructors should be final 47–138

Priority 3

fr/paris/lutece/plugins/botpress/business/BPBotDAO.java

Rule Violation Ligne
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 181

fr/paris/lutece/plugins/botpress/business/RequestMessage.java

Rule Violation Ligne
CommentRequired Public method and constructor comments are required 81–85

fr/paris/lutece/plugins/botpress/service/BotInstance.java

Rule Violation Ligne
MissingSerialVersionUID Classes implementing Serializable should set a serialVersionUID 46–120
ImmutableField Private field '_strErrorMessage' could be made final; it is only initialized in the declaration or constructor. 51
UncommentedEmptyMethodBody Document empty method body 116–118

fr/paris/lutece/plugins/botpress/service/BotRegistrationService.java

Rule Violation Ligne
AvoidSynchronizedAtMethodLevel Use block level rather than method level synchronization 86–95

fr/paris/lutece/plugins/botpress/service/ConverseService.java

Rule Violation Ligne
UseObjectForClearerAPI Rather than using a lot of String arguments, consider using a container object for those values. 91–92
InsufficientStringBufferDeclaration StringBuffer constructor is initialized with size 16, but has at least 43 characters appended. 118
CommentDefaultAccessModifier To avoid mistakes add a comment at the beginning of the parseJsonResponse method if you want a default access modifier 148–177
DefaultPackage Use explicit scoping instead of the default package private level 148–177
ConfusingTernary Avoid if (x != y) ..; else ..; 152–175
TooFewBranchesForASwitchStatement A switch with less than three branches is inefficient, use a if statement instead. 207–218
ConsecutiveLiteralAppends StringBuffer (or StringBuilder).append is called 2 consecutive times with literals. Use a single append with a single combined String. 210

fr/paris/lutece/plugins/botpress/service/LanguageService.java

Rule Violation Ligne
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 50

fr/paris/lutece/plugins/botpress/service/renderers/BotMessageRenderer.java

Rule Violation Ligne
UnnecessaryModifier Unnecessary modifier 'final' on field 'FIELD_TYPE': the field is declared in an interface type 46
UnnecessaryModifier Unnecessary modifier 'final' on field 'TYPE_TEXT': the field is declared in an interface type 47
UnnecessaryModifier Unnecessary modifier 'final' on field 'TYPE_FILE': the field is declared in an interface type 48
UnnecessaryModifier Unnecessary modifier 'final' on field 'FIELD_TEXT': the field is declared in an interface type 49
UnnecessaryModifier Unnecessary modifier 'final' on field 'FIELD_URL': the field is declared in an interface type 50

fr/paris/lutece/plugins/botpress/service/renderers/FileRenderer.java

Rule Violation Ligne
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 77

fr/paris/lutece/plugins/botpress/service/renderers/QuickRepliesRenderer.java

Rule Violation Ligne
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 69

fr/paris/lutece/plugins/botpress/web/BPBotJspBean.java

Rule Violation Ligne
MissingSerialVersionUID Classes implementing Serializable should set a serialVersionUID 64–326
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 149
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 170
ConfusingTernary Avoid if (x != y) ..; else ..; 187

Fichiers

fr/paris/lutece/plugins/botpress/business/BPBotDAO.java

Rule Violation Priority Ligne
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 3 181

fr/paris/lutece/plugins/botpress/business/RequestMessage.java

Rule Violation Priority Ligne
CommentRequired Public method and constructor comments are required 3 81–85

fr/paris/lutece/plugins/botpress/service/BotInstance.java

Rule Violation Priority Ligne
MissingSerialVersionUID Classes implementing Serializable should set a serialVersionUID 3 46–120
ImmutableField Private field '_strErrorMessage' could be made final; it is only initialized in the declaration or constructor. 3 51
UncommentedEmptyMethodBody Document empty method body 3 116–118

fr/paris/lutece/plugins/botpress/service/BotRegistrationService.java

Rule Violation Priority Ligne
ClassWithOnlyPrivateConstructorsShouldBeFinal A class which only has private constructors should be final 1 47–138
AvoidSynchronizedAtMethodLevel Use block level rather than method level synchronization 3 86–95

fr/paris/lutece/plugins/botpress/service/ConverseService.java

Rule Violation Priority Ligne
UseObjectForClearerAPI Rather than using a lot of String arguments, consider using a container object for those values. 3 91–92
InsufficientStringBufferDeclaration StringBuffer constructor is initialized with size 16, but has at least 43 characters appended. 3 118
CommentDefaultAccessModifier To avoid mistakes add a comment at the beginning of the parseJsonResponse method if you want a default access modifier 3 148–177
DefaultPackage Use explicit scoping instead of the default package private level 3 148–177
ConfusingTernary Avoid if (x != y) ..; else ..; 3 152–175
TooFewBranchesForASwitchStatement A switch with less than three branches is inefficient, use a if statement instead. 3 207–218
ConsecutiveLiteralAppends StringBuffer (or StringBuilder).append is called 2 consecutive times with literals. Use a single append with a single combined String. 3 210

fr/paris/lutece/plugins/botpress/service/LanguageService.java

Rule Violation Priority Ligne
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 3 50

fr/paris/lutece/plugins/botpress/service/renderers/BotMessageRenderer.java

Rule Violation Priority Ligne
UnnecessaryModifier Unnecessary modifier 'final' on field 'FIELD_TYPE': the field is declared in an interface type 3 46
UnnecessaryModifier Unnecessary modifier 'final' on field 'TYPE_TEXT': the field is declared in an interface type 3 47
UnnecessaryModifier Unnecessary modifier 'final' on field 'TYPE_FILE': the field is declared in an interface type 3 48
UnnecessaryModifier Unnecessary modifier 'final' on field 'FIELD_TEXT': the field is declared in an interface type 3 49
UnnecessaryModifier Unnecessary modifier 'final' on field 'FIELD_URL': the field is declared in an interface type 3 50

fr/paris/lutece/plugins/botpress/service/renderers/FileRenderer.java

Rule Violation Priority Ligne
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 3 77

fr/paris/lutece/plugins/botpress/service/renderers/QuickRepliesRenderer.java

Rule Violation Priority Ligne
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 3 69

fr/paris/lutece/plugins/botpress/web/BPBotJspBean.java

Rule Violation Priority Ligne
MissingSerialVersionUID Classes implementing Serializable should set a serialVersionUID 3 64–326
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 3 149
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 3 170
ConfusingTernary Avoid if (x != y) ..; else ..; 3 187