Fork me on GitHub

Résultats PMD

Le document suivant contient les résultats de PMD 6.13.0.

Violations By Priority

Priority 1

fr/paris/lutece/plugins/broadcastproxy/business/Feed.java

Rule Violation Ligne
FormalParameterNamingConventions The method parameter name '_type' doesn't match '[a-z][a-zA-Z0-9]*' 71
FormalParameterNamingConventions The method parameter name '_id' doesn't match '[a-z][a-zA-Z0-9]*' 71
FormalParameterNamingConventions The method parameter name '_name' doesn't match '[a-z][a-zA-Z0-9]*' 71
FormalParameterNamingConventions The method parameter name '_name' doesn't match '[a-z][a-zA-Z0-9]*' 94
FormalParameterNamingConventions The method parameter name '_id' doesn't match '[a-z][a-zA-Z0-9]*' 114
FormalParameterNamingConventions The method parameter name '_description' doesn't match '[a-z][a-zA-Z0-9]*' 134
FormalParameterNamingConventions The method parameter name '_type' doesn't match '[a-z][a-zA-Z0-9]*' 154
FormalParameterNamingConventions The method parameter name '_data' doesn't match '[a-z][a-zA-Z0-9]*' 174
FormalParameterNamingConventions The method parameter name '_active' doesn't match '[a-z][a-zA-Z0-9]*' 194

fr/paris/lutece/plugins/broadcastproxy/business/Subscription.java

Rule Violation Ligne
FormalParameterNamingConventions The method parameter name '_description' doesn't match '[a-z][a-zA-Z0-9]*' 228

fr/paris/lutece/plugins/broadcastproxy/business/providers/dolist/DolistConstants.java

Rule Violation Ligne
ClassNamingConventions The utility class name 'DolistConstants' doesn't match '[A-Z][a-zA-Z0-9]+(Utils?|Helper|Home|Service)' 3643
FieldNamingConventions The static field name 'TYPE_SUBSCRIPTION' doesn't match '_[a-z][a-zA-Z0-9]*' 38
FieldNamingConventions The static field name 'TYPE_INTEREST' doesn't match '_[a-z][a-zA-Z0-9]*' 39
FieldNamingConventions The static field name 'NO_GROUP_NAME' doesn't match '_[a-z][a-zA-Z0-9]*' 41

fr/paris/lutece/plugins/broadcastproxy/business/providers/dolist/DolistProvider.java

Rule Violation Ligne
LocalVariableNamingConventions The local variable name 'SubscriptionsName' doesn't match '[a-z][a-zA-Z0-9]*' 314
LocalVariableNamingConventions The local variable name 'SubscriptionsNamesList' doesn't match '[a-z][a-zA-Z0-9]*' 337

fr/paris/lutece/plugins/broadcastproxy/service/BroadcastService.java

Rule Violation Ligne
ClassWithOnlyPrivateConstructorsShouldBeFinal A class which only has private constructors should be final 46207

fr/paris/lutece/plugins/broadcastproxy/service/Constants.java

Rule Violation Ligne
ClassNamingConventions The utility class name 'Constants' doesn't match '[A-Z][a-zA-Z0-9]+(Utils?|Helper|Home|Service)' 3643
FieldNamingConventions The static field name 'TYPE_ALERT' doesn't match '_[a-z][a-zA-Z0-9]*' 38
FieldNamingConventions The static field name 'TYPE_NEWSLETTER' doesn't match '_[a-z][a-zA-Z0-9]*' 39
FieldNamingConventions The static field name 'ACTION_ADD' doesn't match '_[a-z][a-zA-Z0-9]*' 40
FieldNamingConventions The static field name 'ACTION_DELETE' doesn't match '_[a-z][a-zA-Z0-9]*' 41

Priority 3

fr/paris/lutece/plugins/broadcastproxy/business/Feed.java

Rule Violation Ligne
DataClass The class 'Feed' is suspected to be a Data Class (WOC=0.000%, NOPA=0, NOAM=12, WMC=14) 47199

fr/paris/lutece/plugins/broadcastproxy/business/IBroadcastProvider.java

Rule Violation Ligne
CommentRequired Header comments are required 39134
SignatureDeclareThrowsException A method/constructor should not explicitly throw java.lang.Exception 58
SignatureDeclareThrowsException A method/constructor should not explicitly throw java.lang.Exception 69
SignatureDeclareThrowsException A method/constructor should not explicitly throw java.lang.Exception 79
SignatureDeclareThrowsException A method/constructor should not explicitly throw java.lang.Exception 91
SignatureDeclareThrowsException A method/constructor should not explicitly throw java.lang.Exception 100
SignatureDeclareThrowsException A method/constructor should not explicitly throw java.lang.Exception 109
SignatureDeclareThrowsException A method/constructor should not explicitly throw java.lang.Exception 118
UnnecessaryModifier Unnecessary modifier 'public' on method 'getSubscriptionViewOrder': the method is declared in an interface type 132

fr/paris/lutece/plugins/broadcastproxy/business/Subscription.java

Rule Violation Ligne
DataClass The class 'Subscription' is suspected to be a Data Class (WOC=17.647%, NOPA=0, NOAM=14, WMC=18) 48233
ControlStatementBraces This statement should have braces 209

fr/paris/lutece/plugins/broadcastproxy/business/providers/dolist/DolistAPI.java

Rule Violation Ligne
CommentRequired Header comments are required 55512
ControlStatementBraces This statement should have braces 116
ControlStatementBraces This statement should have braces 119
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 122
AvoidDuplicateLiterals The String literal "\":" appears 4 times in this file; the first occurrence is on line 139 139
AvoidLiteralsInIfCondition Avoid using Literals in Conditional Statements 147
AvoidDuplicateLiterals The String literal "' : " appears 5 times in this file; the first occurrence is on line 164 164
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 181
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 182
SignatureDeclareThrowsException A method/constructor should not explicitly throw java.lang.Exception 315
PositionLiteralsFirstInComparisons Position literals first in String comparisons 324
ControlStatementBraces This statement should have braces 325
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 336
UnnecessaryLocalBeforeReturn Consider simply returning the value vs storing it in local variable 'response' 347
SignatureDeclareThrowsException A method/constructor should not explicitly throw java.lang.Exception 350
CommentRequired Public method and constructor comments are required 350385
PositionLiteralsFirstInComparisons Position literals first in String comparisons 359
ControlStatementBraces This statement should have braces 360
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 477
AssignmentInOperand Avoid assignments in operands 503

fr/paris/lutece/plugins/broadcastproxy/business/providers/dolist/DolistConstants.java

Rule Violation Ligne
CommentRequired Header comments are required 3643

fr/paris/lutece/plugins/broadcastproxy/business/providers/dolist/DolistHttpAccess.java

Rule Violation Ligne
CommentRequired Header comments are required 54225
CommentRequired Public method and constructor comments are required 6099
AvoidDuplicateLiterals The String literal "' : " appears 4 times in this file; the first occurrence is on line 88 88
AvoidDuplicateLiterals The String literal "strError" appears 4 times in this file; the first occurrence is on line 90 90
CommentRequired Public method and constructor comments are required 101141
CommentRequired Public method and constructor comments are required 143183
CommentRequired Public method and constructor comments are required 185224

fr/paris/lutece/plugins/broadcastproxy/business/providers/dolist/DolistProvider.java

Rule Violation Ligne
CommentRequired Header comments are required 58602
GodClass Possible God Class (WMC=60, ATFD=51, TCC=11.696%) 58602
ImmutableField Private field '_dolistAPI' could be made final; it is only initialized in the declaration or constructor. 80
ImmutableField Private field '_groupViewRang' could be made final; it is only initialized in the declaration or constructor. 82
LooseCoupling Avoid using implementation types like 'TreeMap'; use the interface instead 82
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 83
ImmutableField Private field '_groupsMapIdName' could be made final; it is only initialized in the declaration or constructor. 83
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 84
ImmutableField Private field '_interestsMapIdName' could be made final; it is only initialized in the declaration or constructor. 84
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 85
ImmutableField Private field '_subscriptionsMapIdName' could be made final; it is only initialized in the declaration or constructor. 85
UnnecessaryLocalBeforeReturn Consider simply returning the value vs storing it in local variable 'userSubscriptions' 124
UnnecessaryLocalBeforeReturn Consider simply returning the value vs storing it in local variable 'jsonUserSubscriptions' 134
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 146
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 183
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 195
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 195
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 220
SignatureDeclareThrowsException A method/constructor should not explicitly throw java.lang.Exception 230
CommentRequired Public method and constructor comments are required 230303
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 232
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 232
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 233
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 234
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 234
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 235
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 235
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 236
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 236
ControlStatementBraces This statement should have braces 261
ControlStatementBraces This statement should have braces 263
PositionLiteralsFirstInComparisons Position literals first in String comparisons 270
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 296
CommentRequired Public method and constructor comments are required 305309
SignatureDeclareThrowsException A method/constructor should not explicitly throw java.lang.Exception 305
CommentRequired Public method and constructor comments are required 311359
SignatureDeclareThrowsException A method/constructor should not explicitly throw java.lang.Exception 311
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 314
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 314
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 314
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 315
ControlStatementBraces This statement should have braces 319
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 337
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 352
CyclomaticComplexity The method 'getUserSubscriptionsNamesAsList(String, String)' has a cyclomatic complexity of 11. 361408
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 364
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 365
ControlStatementBraces This statement should have braces 377
ControlStatementBraces This statement should have braces 388
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 401
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 421
CommentRequired Public method and constructor comments are required 443478
SignatureDeclareThrowsException A method/constructor should not explicitly throw java.lang.Exception 443
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 446
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 471
CyclomaticComplexity The method 'initMapIdName()' has a cyclomatic complexity of 13. 483551
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 506
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 507
PositionLiteralsFirstInComparisons Position literals first in String comparisons 527
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 546
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 561
ControlStatementBraces This statement should have braces 574
ControlStatementBraces This statement should have braces 576

fr/paris/lutece/plugins/broadcastproxy/business/providers/mock/MockProvider.java

Rule Violation Ligne
CommentRequired Header comments are required 46171
UnusedPrivateField Avoid unused private fields such as 'DEFAULT_USER_SUBSCRIPTIONS_MAP'. 50
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 59
CommentRequired Public method and constructor comments are required 7780
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 97
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 97
UnnecessaryLocalBeforeReturn Consider simply returning the value vs storing it in local variable 'map' 111
CommentRequired Public method and constructor comments are required 121148
MissingOverride The method 'getFeeds()' is missing an @Override annotation. 121148
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 131

fr/paris/lutece/plugins/broadcastproxy/service/BroadcastService.java

Rule Violation Ligne
CommentRequired Header comments are required 46207
AvoidSynchronizedAtMethodLevel Use block level rather than method level synchronization 7685
AvoidSynchronizedAtMethodLevel Use block level rather than method level synchronization 93100
SignatureDeclareThrowsException A method/constructor should not explicitly throw java.lang.Exception 111
SignatureDeclareThrowsException A method/constructor should not explicitly throw java.lang.Exception 123
SignatureDeclareThrowsException A method/constructor should not explicitly throw java.lang.Exception 135
SignatureDeclareThrowsException A method/constructor should not explicitly throw java.lang.Exception 147
SignatureDeclareThrowsException A method/constructor should not explicitly throw java.lang.Exception 161
SignatureDeclareThrowsException A method/constructor should not explicitly throw java.lang.Exception 175
SignatureDeclareThrowsException A method/constructor should not explicitly throw java.lang.Exception 187
CommentRequired Public method and constructor comments are required 192195

fr/paris/lutece/plugins/broadcastproxy/service/Constants.java

Rule Violation Ligne
CommentRequired Header comments are required 3643

fr/paris/lutece/plugins/broadcastproxy/web/BroadcastproxyJspBean.java

Rule Violation Ligne
RedundantFieldInitializer Avoid using redundant field initializer for '_subscriptionTypes' 94
CommentDefaultAccessModifier To avoid mistakes add a comment at the beginning of the _subscriptionTypes field if you want a default access modifier 94
DefaultPackage Use explicit scoping instead of the default package private level 94
DefaultPackage Use explicit scoping instead of the default package private level 95
RedundantFieldInitializer Avoid using redundant field initializer for '_subscriptionFeeds' 95
CommentDefaultAccessModifier To avoid mistakes add a comment at the beginning of the _subscriptionFeeds field if you want a default access modifier 95
DefaultPackage Use explicit scoping instead of the default package private level 96
CommentDefaultAccessModifier To avoid mistakes add a comment at the beginning of the _currentFeedType field if you want a default access modifier 96
RedundantFieldInitializer Avoid using redundant field initializer for '_currentFeedType' 96
AvoidDuplicateLiterals The String literal "Invalid subscription type" appears 4 times in this file; the first occurrence is on line 122 122
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 141
UnnecessaryAnnotationValueElement Avoid the use of value in annotations when its the only element 161
CyclomaticComplexity The method 'doUpdateUserSubscribtions(HttpServletRequest)' has a cyclomatic complexity of 15. 162260
NPathComplexity The method 'doUpdateUserSubscribtions(HttpServletRequest)' has an NPath complexity of 409 162260
AvoidDeeplyNestedIfStmts Deeply nested if..then statements are hard to read 215216
ControlStatementBraces This statement should have braces 216
UseIndexOfChar String.indexOf(char) is faster than String.indexOf(String). 224
AvoidDeeplyNestedIfStmts Deeply nested if..then statements are hard to read 229232
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 252
UnnecessaryAnnotationValueElement Avoid the use of value in annotations when its the only element 269
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 311
UnnecessaryAnnotationValueElement Avoid the use of value in annotations when its the only element 328
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 370
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 390
ShortVariable Avoid variables with short names like i 396
ControlStatementBraces This statement should have braces 400

fr/paris/lutece/plugins/broadcastproxy/web/BroadcastproxyXPage.java

Rule Violation Ligne
ConfusingTernary Avoid if (x != y) ..; else ..; 85101
ControlStatementBraces This statement should have braces 127
ShortVariable Avoid variables with short names like sb 132
ControlStatementBraces This statement should have braces 136137
AssignmentInOperand Avoid assignments in operands 136
SimplifyBooleanExpressions Avoid unnecessary comparisons in boolean expressions 146
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 167

fr/paris/lutece/plugins/broadcastproxy/web/MyDashboardBroadcastproxy.java

Rule Violation Ligne
CommentRequired Header comments are required 58200
ImmutableField Private field '_listInfos' could be made final; it is only initialized in the declaration or constructor. 78
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 96
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 97
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 97
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 98
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 111
AvoidDeeplyNestedIfStmts Deeply nested if..then statements are hard to read 117120
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 135
ShortVariable Avoid variables with short names like t 147
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 166
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 166

Priority 4

fr/paris/lutece/plugins/broadcastproxy/business/Feed.java

Rule Violation Ligne
ShortClassName Avoid short class names like Feed 47199

Fichiers

fr/paris/lutece/plugins/broadcastproxy/business/Feed.java

Rule Violation Priority Ligne
ShortClassName Avoid short class names like Feed 4 47199
DataClass The class 'Feed' is suspected to be a Data Class (WOC=0.000%, NOPA=0, NOAM=12, WMC=14) 3 47199
FormalParameterNamingConventions The method parameter name '_type' doesn't match '[a-z][a-zA-Z0-9]*' 1 71
FormalParameterNamingConventions The method parameter name '_id' doesn't match '[a-z][a-zA-Z0-9]*' 1 71
FormalParameterNamingConventions The method parameter name '_name' doesn't match '[a-z][a-zA-Z0-9]*' 1 71
FormalParameterNamingConventions The method parameter name '_name' doesn't match '[a-z][a-zA-Z0-9]*' 1 94
FormalParameterNamingConventions The method parameter name '_id' doesn't match '[a-z][a-zA-Z0-9]*' 1 114
FormalParameterNamingConventions The method parameter name '_description' doesn't match '[a-z][a-zA-Z0-9]*' 1 134
FormalParameterNamingConventions The method parameter name '_type' doesn't match '[a-z][a-zA-Z0-9]*' 1 154
FormalParameterNamingConventions The method parameter name '_data' doesn't match '[a-z][a-zA-Z0-9]*' 1 174
FormalParameterNamingConventions The method parameter name '_active' doesn't match '[a-z][a-zA-Z0-9]*' 1 194

fr/paris/lutece/plugins/broadcastproxy/business/IBroadcastProvider.java

Rule Violation Priority Ligne
CommentRequired Header comments are required 3 39134
SignatureDeclareThrowsException A method/constructor should not explicitly throw java.lang.Exception 3 58
SignatureDeclareThrowsException A method/constructor should not explicitly throw java.lang.Exception 3 69
SignatureDeclareThrowsException A method/constructor should not explicitly throw java.lang.Exception 3 79
SignatureDeclareThrowsException A method/constructor should not explicitly throw java.lang.Exception 3 91
SignatureDeclareThrowsException A method/constructor should not explicitly throw java.lang.Exception 3 100
SignatureDeclareThrowsException A method/constructor should not explicitly throw java.lang.Exception 3 109
SignatureDeclareThrowsException A method/constructor should not explicitly throw java.lang.Exception 3 118
UnnecessaryModifier Unnecessary modifier 'public' on method 'getSubscriptionViewOrder': the method is declared in an interface type 3 132

fr/paris/lutece/plugins/broadcastproxy/business/Subscription.java

Rule Violation Priority Ligne
DataClass The class 'Subscription' is suspected to be a Data Class (WOC=17.647%, NOPA=0, NOAM=14, WMC=18) 3 48233
ControlStatementBraces This statement should have braces 3 209
FormalParameterNamingConventions The method parameter name '_description' doesn't match '[a-z][a-zA-Z0-9]*' 1 228

fr/paris/lutece/plugins/broadcastproxy/business/providers/dolist/DolistAPI.java

Rule Violation Priority Ligne
CommentRequired Header comments are required 3 55512
ControlStatementBraces This statement should have braces 3 116
ControlStatementBraces This statement should have braces 3 119
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 3 122
AvoidDuplicateLiterals The String literal "\":" appears 4 times in this file; the first occurrence is on line 139 3 139
AvoidLiteralsInIfCondition Avoid using Literals in Conditional Statements 3 147
AvoidDuplicateLiterals The String literal "' : " appears 5 times in this file; the first occurrence is on line 164 3 164
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 3 181
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 3 182
SignatureDeclareThrowsException A method/constructor should not explicitly throw java.lang.Exception 3 315
PositionLiteralsFirstInComparisons Position literals first in String comparisons 3 324
ControlStatementBraces This statement should have braces 3 325
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 3 336
UnnecessaryLocalBeforeReturn Consider simply returning the value vs storing it in local variable 'response' 3 347
SignatureDeclareThrowsException A method/constructor should not explicitly throw java.lang.Exception 3 350
CommentRequired Public method and constructor comments are required 3 350385
PositionLiteralsFirstInComparisons Position literals first in String comparisons 3 359
ControlStatementBraces This statement should have braces 3 360
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 3 477
AssignmentInOperand Avoid assignments in operands 3 503

fr/paris/lutece/plugins/broadcastproxy/business/providers/dolist/DolistConstants.java

Rule Violation Priority Ligne
CommentRequired Header comments are required 3 3643
ClassNamingConventions The utility class name 'DolistConstants' doesn't match '[A-Z][a-zA-Z0-9]+(Utils?|Helper|Home|Service)' 1 3643
FieldNamingConventions The static field name 'TYPE_SUBSCRIPTION' doesn't match '_[a-z][a-zA-Z0-9]*' 1 38
FieldNamingConventions The static field name 'TYPE_INTEREST' doesn't match '_[a-z][a-zA-Z0-9]*' 1 39
FieldNamingConventions The static field name 'NO_GROUP_NAME' doesn't match '_[a-z][a-zA-Z0-9]*' 1 41

fr/paris/lutece/plugins/broadcastproxy/business/providers/dolist/DolistHttpAccess.java

Rule Violation Priority Ligne
CommentRequired Header comments are required 3 54225
CommentRequired Public method and constructor comments are required 3 6099
AvoidDuplicateLiterals The String literal "' : " appears 4 times in this file; the first occurrence is on line 88 3 88
AvoidDuplicateLiterals The String literal "strError" appears 4 times in this file; the first occurrence is on line 90 3 90
CommentRequired Public method and constructor comments are required 3 101141
CommentRequired Public method and constructor comments are required 3 143183
CommentRequired Public method and constructor comments are required 3 185224

fr/paris/lutece/plugins/broadcastproxy/business/providers/dolist/DolistProvider.java

Rule Violation Priority Ligne
CommentRequired Header comments are required 3 58602
GodClass Possible God Class (WMC=60, ATFD=51, TCC=11.696%) 3 58602
ImmutableField Private field '_dolistAPI' could be made final; it is only initialized in the declaration or constructor. 3 80
ImmutableField Private field '_groupViewRang' could be made final; it is only initialized in the declaration or constructor. 3 82
LooseCoupling Avoid using implementation types like 'TreeMap'; use the interface instead 3 82
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 3 83
ImmutableField Private field '_groupsMapIdName' could be made final; it is only initialized in the declaration or constructor. 3 83
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 3 84
ImmutableField Private field '_interestsMapIdName' could be made final; it is only initialized in the declaration or constructor. 3 84
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 3 85
ImmutableField Private field '_subscriptionsMapIdName' could be made final; it is only initialized in the declaration or constructor. 3 85
UnnecessaryLocalBeforeReturn Consider simply returning the value vs storing it in local variable 'userSubscriptions' 3 124
UnnecessaryLocalBeforeReturn Consider simply returning the value vs storing it in local variable 'jsonUserSubscriptions' 3 134
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 3 146
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 3 183
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 3 195
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 3 195
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 3 220
SignatureDeclareThrowsException A method/constructor should not explicitly throw java.lang.Exception 3 230
CommentRequired Public method and constructor comments are required 3 230303
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 3 232
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 3 232
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 3 233
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 3 234
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 3 234
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 3 235
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 3 235
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 3 236
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 3 236
ControlStatementBraces This statement should have braces 3 261
ControlStatementBraces This statement should have braces 3 263
PositionLiteralsFirstInComparisons Position literals first in String comparisons 3 270
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 3 296
CommentRequired Public method and constructor comments are required 3 305309
SignatureDeclareThrowsException A method/constructor should not explicitly throw java.lang.Exception 3 305
CommentRequired Public method and constructor comments are required 3 311359
SignatureDeclareThrowsException A method/constructor should not explicitly throw java.lang.Exception 3 311
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 3 314
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 3 314
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 3 314
LocalVariableNamingConventions The local variable name 'SubscriptionsName' doesn't match '[a-z][a-zA-Z0-9]*' 1 314
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 3 315
ControlStatementBraces This statement should have braces 3 319
LocalVariableNamingConventions The local variable name 'SubscriptionsNamesList' doesn't match '[a-z][a-zA-Z0-9]*' 1 337
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 3 337
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 3 352
CyclomaticComplexity The method 'getUserSubscriptionsNamesAsList(String, String)' has a cyclomatic complexity of 11. 3 361408
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 3 364
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 3 365
ControlStatementBraces This statement should have braces 3 377
ControlStatementBraces This statement should have braces 3 388
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 3 401
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 3 421
CommentRequired Public method and constructor comments are required 3 443478
SignatureDeclareThrowsException A method/constructor should not explicitly throw java.lang.Exception 3 443
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 3 446
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 3 471
CyclomaticComplexity The method 'initMapIdName()' has a cyclomatic complexity of 13. 3 483551
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 3 506
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 3 507
PositionLiteralsFirstInComparisons Position literals first in String comparisons 3 527
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 3 546
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 3 561
ControlStatementBraces This statement should have braces 3 574
ControlStatementBraces This statement should have braces 3 576

fr/paris/lutece/plugins/broadcastproxy/business/providers/mock/MockProvider.java

Rule Violation Priority Ligne
CommentRequired Header comments are required 3 46171
UnusedPrivateField Avoid unused private fields such as 'DEFAULT_USER_SUBSCRIPTIONS_MAP'. 3 50
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 3 59
CommentRequired Public method and constructor comments are required 3 7780
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 3 97
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 3 97
UnnecessaryLocalBeforeReturn Consider simply returning the value vs storing it in local variable 'map' 3 111
CommentRequired Public method and constructor comments are required 3 121148
MissingOverride The method 'getFeeds()' is missing an @Override annotation. 3 121148
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 3 131

fr/paris/lutece/plugins/broadcastproxy/service/BroadcastService.java

Rule Violation Priority Ligne
CommentRequired Header comments are required 3 46207
ClassWithOnlyPrivateConstructorsShouldBeFinal A class which only has private constructors should be final 1 46207
AvoidSynchronizedAtMethodLevel Use block level rather than method level synchronization 3 7685
AvoidSynchronizedAtMethodLevel Use block level rather than method level synchronization 3 93100
SignatureDeclareThrowsException A method/constructor should not explicitly throw java.lang.Exception 3 111
SignatureDeclareThrowsException A method/constructor should not explicitly throw java.lang.Exception 3 123
SignatureDeclareThrowsException A method/constructor should not explicitly throw java.lang.Exception 3 135
SignatureDeclareThrowsException A method/constructor should not explicitly throw java.lang.Exception 3 147
SignatureDeclareThrowsException A method/constructor should not explicitly throw java.lang.Exception 3 161
SignatureDeclareThrowsException A method/constructor should not explicitly throw java.lang.Exception 3 175
SignatureDeclareThrowsException A method/constructor should not explicitly throw java.lang.Exception 3 187
CommentRequired Public method and constructor comments are required 3 192195

fr/paris/lutece/plugins/broadcastproxy/service/Constants.java

Rule Violation Priority Ligne
ClassNamingConventions The utility class name 'Constants' doesn't match '[A-Z][a-zA-Z0-9]+(Utils?|Helper|Home|Service)' 1 3643
CommentRequired Header comments are required 3 3643
FieldNamingConventions The static field name 'TYPE_ALERT' doesn't match '_[a-z][a-zA-Z0-9]*' 1 38
FieldNamingConventions The static field name 'TYPE_NEWSLETTER' doesn't match '_[a-z][a-zA-Z0-9]*' 1 39
FieldNamingConventions The static field name 'ACTION_ADD' doesn't match '_[a-z][a-zA-Z0-9]*' 1 40
FieldNamingConventions The static field name 'ACTION_DELETE' doesn't match '_[a-z][a-zA-Z0-9]*' 1 41

fr/paris/lutece/plugins/broadcastproxy/web/BroadcastproxyJspBean.java

Rule Violation Priority Ligne
RedundantFieldInitializer Avoid using redundant field initializer for '_subscriptionTypes' 3 94
CommentDefaultAccessModifier To avoid mistakes add a comment at the beginning of the _subscriptionTypes field if you want a default access modifier 3 94
DefaultPackage Use explicit scoping instead of the default package private level 3 94
DefaultPackage Use explicit scoping instead of the default package private level 3 95
RedundantFieldInitializer Avoid using redundant field initializer for '_subscriptionFeeds' 3 95
CommentDefaultAccessModifier To avoid mistakes add a comment at the beginning of the _subscriptionFeeds field if you want a default access modifier 3 95
DefaultPackage Use explicit scoping instead of the default package private level 3 96
CommentDefaultAccessModifier To avoid mistakes add a comment at the beginning of the _currentFeedType field if you want a default access modifier 3 96
RedundantFieldInitializer Avoid using redundant field initializer for '_currentFeedType' 3 96
AvoidDuplicateLiterals The String literal "Invalid subscription type" appears 4 times in this file; the first occurrence is on line 122 3 122
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 3 141
UnnecessaryAnnotationValueElement Avoid the use of value in annotations when its the only element 3 161
CyclomaticComplexity The method 'doUpdateUserSubscribtions(HttpServletRequest)' has a cyclomatic complexity of 15. 3 162260
NPathComplexity The method 'doUpdateUserSubscribtions(HttpServletRequest)' has an NPath complexity of 409 3 162260
AvoidDeeplyNestedIfStmts Deeply nested if..then statements are hard to read 3 215216
ControlStatementBraces This statement should have braces 3 216
UseIndexOfChar String.indexOf(char) is faster than String.indexOf(String). 3 224
AvoidDeeplyNestedIfStmts Deeply nested if..then statements are hard to read 3 229232
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 3 252
UnnecessaryAnnotationValueElement Avoid the use of value in annotations when its the only element 3 269
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 3 311
UnnecessaryAnnotationValueElement Avoid the use of value in annotations when its the only element 3 328
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 3 370
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 3 390
ShortVariable Avoid variables with short names like i 3 396
ControlStatementBraces This statement should have braces 3 400

fr/paris/lutece/plugins/broadcastproxy/web/BroadcastproxyXPage.java

Rule Violation Priority Ligne
ConfusingTernary Avoid if (x != y) ..; else ..; 3 85101
ControlStatementBraces This statement should have braces 3 127
ShortVariable Avoid variables with short names like sb 3 132
ControlStatementBraces This statement should have braces 3 136137
AssignmentInOperand Avoid assignments in operands 3 136
SimplifyBooleanExpressions Avoid unnecessary comparisons in boolean expressions 3 146
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 3 167

fr/paris/lutece/plugins/broadcastproxy/web/MyDashboardBroadcastproxy.java

Rule Violation Priority Ligne
CommentRequired Header comments are required 3 58200
ImmutableField Private field '_listInfos' could be made final; it is only initialized in the declaration or constructor. 3 78
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 3 96
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 3 97
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 3 97
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 3 98
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 3 111
AvoidDeeplyNestedIfStmts Deeply nested if..then statements are hard to read 3 117120
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 3 135
ShortVariable Avoid variables with short names like t 3 147
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 3 166
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 3 166