The following document contains the results of PMD 5.3.5.
| Violation | Line |
|---|---|
| Avoid variables with short names like id | 65 |
| Avoid variables with short names like id | 72 |
| Avoid variables with short names like id | 85 |
| Violation | Line |
|---|---|
| Avoid variables with short names like id | 58 |
| Violation | Line |
|---|---|
| Avoid variables with short names like id | 142 |
| Avoid variables with short names like id | 163 |
| Avoid variables with short names like id | 202 |
| Violation | Line |
|---|---|
| Avoid variables with short names like id | 127 |
| Violation | Line |
|---|---|
| Abstract classes should be named AbstractXXX | 42–153 |
| Violation | Line |
|---|---|
| Avoid variables with short names like id | 47 |
| Violation | Line |
|---|---|
| Avoid variables with short names like id | 53 |
| Avoid variables with short names like id | 62 |
| Avoid variables with short names like id | 98 |
| Violation | Line |
|---|---|
| Avoid variables with short names like id | 51 |
| Avoid variables with short names like id | 58 |
| Violation | Line |
|---|---|
| Avoid variables with short names like id | 97 |
| Avoid variables with short names like id | 132 |
| Do not add empty strings | 213 |
| Do not add empty strings | 214 |
| Do not add empty strings | 254 |
| Do not add empty strings | 255 |
| Avoid variables with short names like id | 264 |
| Violation | Line |
|---|---|
| Avoid variables with short names like id | 111 |
| Violation | Line |
|---|---|
| Avoid variables with short names like id | 98 |
| Avoid variables with short names like id | 118 |
| Avoid appending characters as strings in StringBuffer.append. | 146 |
| StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 146 |
| StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 147 |
| Avoid appending characters as strings in StringBuffer.append. | 148 |
| Avoid appending characters as strings in StringBuffer.append. | 166 |
| Avoid appending characters as strings in StringBuffer.append. | 191 |
| StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 191 |
| StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 192 |
| Avoid appending characters as strings in StringBuffer.append. | 193 |
| Avoid appending characters as strings in StringBuffer.append. | 211 |
| Avoid variables with short names like id | 325 |
| Violation | Line |
|---|---|
| Document empty constructor | 97–99 |
| Violation | Line |
|---|---|
| The class 'XmlDTO' has a Standard Cyclomatic Complexity of 2 (Highest = 10). | 43–293 |
| The class 'XmlDTO' has a Modified Cyclomatic Complexity of 2 (Highest = 10). | 43–293 |
| The class 'XmlDTO' has a Cyclomatic Complexity of 2 (Highest = 10). | 43–293 |
| Avoid using final local variables, turn them into fields | 234 |
| The method 'equals' has a Standard Cyclomatic Complexity of 10. | 248–292 |
| The method 'equals' has a Modified Cyclomatic Complexity of 10. | 248–292 |
| The method 'equals' has a Cyclomatic Complexity of 10. | 248–292 |
| Violation | Line |
|---|---|
| Avoid excessively long variable names like SQL_QUERY_SELECT_CONTENT_TYPE_WITHOUT_ASSOCIATED_STYLESHEET | 58 |
| Violation | Line |
|---|---|
| Use explicit scoping instead of the default package private level | 80–98 |
| Prefer StringBuffer over += for concatenating strings | 109 |
| Prefer StringBuffer over += for concatenating strings | 119 |
| Prefer StringBuffer over += for concatenating strings | 123 |
| Prefer StringBuffer over += for concatenating strings | 126 |
| This statement may have some unnecessary parentheses | 185 |
| Violation | Line |
|---|---|
| Do not add empty strings | 109 |
| Violation | Line |
|---|---|
| Avoid variables with short names like sb | 59 |
| StringBuffer constructor is initialized with size 16, but has at least 100 characters appended. | 59 |
| StringBuffer (or StringBuilder).append is called 6 consecutive times with literal Strings. Use a single append with a single combined String. | 65 |
| Avoid appending characters as strings in StringBuffer.append. | 66 |
| Avoid appending characters as strings in StringBuffer.append. | 69 |
| Avoid appending characters as strings in StringBuffer.append. | 72 |
| Avoid appending characters as strings in StringBuffer.append. | 78 |
| Violation | Line |
|---|---|
| Avoid variables with short names like e | 58 |
| Violation | Line |
|---|---|
| Private field '_dilaStyleSheetService' could be made final; it is only initialized in the declaration or constructor. | 72 |
| It is a good practice to call super() in a constructor | 75–78 |
| Avoid variables with short names like rt | 85 |
| Avoid variables with short names like p | 91 |
| Violation | Line |
|---|---|
| Avoid variables with short names like id | 69 |
| Avoid variables with short names like id | 76 |
| Avoid variables with short names like id | 89 |
| Violation | Line |
|---|---|
| A method/constructor shouldnt explicitly throw java.lang.Exception | 69 |
| A method/constructor shouldnt explicitly throw java.lang.Exception | 69 |
| Violation | Line |
|---|---|
| Avoid variables with short names like id | 63 |
| Violation | Line |
|---|---|
| Avoid variables with short names like id | 84 |
| Avoid variables with short names like id | 93 |
| Avoid variables with short names like id | 102 |
| Violation | Line |
|---|---|
| Avoid variables with short names like id | 56 |
| Avoid variables with short names like id | 63 |
| Violation | Line |
|---|---|
| debug logging that involves string concatenation should be guarded with isDebugEnabled() checks | 120 |
| Violation | Line |
|---|---|
| A high number of imports can indicate a high degree of coupling within an object. | 4–336 |
| The class 'DilaCacheService' has a Modified Cyclomatic Complexity of 6 (Highest = 19). | 60–336 |
| The class 'DilaCacheService' has a Standard Cyclomatic Complexity of 7 (Highest = 23). | 60–336 |
| The class 'DilaCacheService' has a Cyclomatic Complexity of 8 (Highest = 26). | 60–336 |
| It is a good practice to call super() in a constructor | 93–96 |
| The method buildDilaPage() has an NCSS line count of 114 | 126–335 |
| The method 'buildDilaPage' has a Cyclomatic Complexity of 26. | 126–335 |
| The method 'buildDilaPage' has a Modified Cyclomatic Complexity of 19. | 126–335 |
| The method buildDilaPage() has an NPath complexity of 7448 | 126–335 |
| Avoid really long methods. | 126–335 |
| The method 'buildDilaPage' has a Standard Cyclomatic Complexity of 23. | 126–335 |
| Avoid declaring a variable if it is unreferenced before a possible exit point. | 157 |
| If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 284 |
| StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 289 |
| StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 290 |
| Violation | Line |
|---|---|
| Avoid variables with short names like id | 105 |
| Avoid variables with short names like id | 114 |
| Avoid variables with short names like id | 132 |
| Violation | Line |
|---|---|
| A high number of imports can indicate a high degree of coupling within an object. | 34–271 |
| The class 'DilaDownloadService' has a Modified Cyclomatic Complexity of 9 (Highest = 16). | 75–271 |
| The class 'DilaDownloadService' has a Standard Cyclomatic Complexity of 9 (Highest = 16). | 75–271 |
| The class 'DilaDownloadService' has a Cyclomatic Complexity of 10 (Highest = 17). | 75–271 |
| The method 'download' has a Standard Cyclomatic Complexity of 16. | 105–270 |
| Avoid really long methods. | 105–270 |
| The method 'download' has a Modified Cyclomatic Complexity of 16. | 105–270 |
| The method 'download' has a Cyclomatic Complexity of 17. | 105–270 |
| The method download() has an NPath complexity of 18432 | 105–270 |
| The String literal "Error on HTTP protocol" appears 4 times in this file; the first occurrence is on line 153 | 153 |
| New exception is thrown in catch block, original stack trace may be lost | 154 |
| New exception is thrown in catch block, original stack trace may be lost | 159 |
| debug logging that involves string concatenation should be guarded with isDebugEnabled() checks | 164 |
| debug logging that involves string concatenation should be guarded with isDebugEnabled() checks | 168 |
| Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 178 |
| New exception is thrown in catch block, original stack trace may be lost | 181 |
| Avoid declaring a variable if it is unreferenced before a possible exit point. | 187 |
| debug logging that involves string concatenation should be guarded with isDebugEnabled() checks | 192 |
| New exception is thrown in catch block, original stack trace may be lost | 201 |
| New exception is thrown in catch block, original stack trace may be lost | 214 |
| New exception is thrown in catch block, original stack trace may be lost | 224 |
| New exception is thrown in catch block, original stack trace may be lost | 235 |
| New exception is thrown in catch block, original stack trace may be lost | 246 |
| New exception is thrown in catch block, original stack trace may be lost | 257 |
| New exception is thrown in catch block, original stack trace may be lost | 268 |
| Violation | Line |
|---|---|
| The class 'DilaExtractService' has a Modified Cyclomatic Complexity of 6 (Highest = 10). | 65–360 |
| The class 'DilaExtractService' has a Cyclomatic Complexity of 6 (Highest = 10). | 65–360 |
| The class 'DilaExtractService' has a Standard Cyclomatic Complexity of 6 (Highest = 10). | 65–360 |
| Perhaps '_strArchivesDirPath' could be replaced by a local variable. | 71 |
| Private field '_filenameFilterArchive' could be made final; it is only initialized in the declaration or constructor. | 76 |
| The method 'extractAll' has a Standard Cyclomatic Complexity of 10. | 79–161 |
| The method 'extractAll' has a Cyclomatic Complexity of 10. | 79–161 |
| The method 'extractAll' has a Modified Cyclomatic Complexity of 10. | 79–161 |
| Avoid using Literals in Conditional Statements | 96 |
| debug logging that involves string concatenation should be guarded with isDebugEnabled() checks | 104 |
| New exception is thrown in catch block, original stack trace may be lost | 151 |
| Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 153 |
| New exception is thrown in catch block, original stack trace may be lost | 155 |
| A method/constructor shouldnt explicitly throw java.lang.Exception | 165 |
| A method/constructor shouldnt explicitly throw java.lang.Exception | 165 |
| This statement may have some unnecessary parentheses | 171 |
| Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 216 |
| New exception is thrown in catch block, original stack trace may be lost | 219 |
| A method/constructor shouldnt explicitly throw java.lang.Exception | 273 |
| A method/constructor shouldnt explicitly throw java.lang.Exception | 273 |
| Avoid variables with short names like in | 280 |
| New exception is thrown in catch block, original stack trace may be lost | 305 |
| New exception is thrown in catch block, original stack trace may be lost | 309 |
| Violation | Line |
|---|---|
| Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 119 |
| Violation | Line |
|---|---|
| The class 'DilaLocalCardService' has a Modified Cyclomatic Complexity of 2 (Highest = 11). | 56–186 |
| The class 'DilaLocalCardService' has a Standard Cyclomatic Complexity of 2 (Highest = 11). | 56–186 |
| The class 'DilaLocalCardService' has a Cyclomatic Complexity of 2 (Highest = 12). | 56–186 |
| The method 'insertCardLinks' has a Standard Cyclomatic Complexity of 11. | 105–179 |
| The method 'insertCardLinks' has a Cyclomatic Complexity of 12. | 105–179 |
| The method 'insertCardLinks' has a Modified Cyclomatic Complexity of 11. | 105–179 |
| Avoid using Literals in Conditional Statements | 139 |
| Do not add empty strings | 143 |
| Do not add empty strings | 144 |
| Do not add empty strings | 153 |
| Do not add empty strings | 164 |
| Violation | Line |
|---|---|
| Avoid variables with short names like id | 81 |
| Violation | Line |
|---|---|
| The class 'DilaLocalFolderService' has a Cyclomatic Complexity of 2 (Highest = 10). | 56–190 |
| The method 'insertFolderLinks' has a Cyclomatic Complexity of 10. | 118–180 |
| Avoid using Literals in Conditional Statements | 141 |
| Do not add empty strings | 145 |
| Do not add empty strings | 146 |
| Do not add empty strings | 155 |
| Do not add empty strings | 166 |
| Violation | Line |
|---|---|
| Avoid variables with short names like id | 68 |
| Avoid variables with short names like id | 74 |
| Avoid variables with short names like id | 104 |
| Violation | Line |
|---|---|
| Possible God class (WMC=52, ATFD=49, TCC=0.0) | 34–403 |
| Avoid declaring a variable if it is unreferenced before a possible exit point. | 142 |
| Avoid declaring a variable if it is unreferenced before a possible exit point. | 224 |
| Avoid declaring a variable if it is unreferenced before a possible exit point. | 225 |
| This call to String.startsWith can be rewritten using String.charAt(0) | 298 |
| Violation | Line |
|---|---|
| A high number of imports can indicate a high degree of coupling within an object. | 34–324 |
| The class 'DilaXmlService' has a Cyclomatic Complexity of 2 (Highest = 12). | 86–324 |
| The class 'DilaXmlService' has a Modified Cyclomatic Complexity of 2 (Highest = 11). | 86–324 |
| The class 'DilaXmlService' has a Standard Cyclomatic Complexity of 2 (Highest = 11). | 86–324 |
| The method 'insertRssLinks' has a Cyclomatic Complexity of 12. | 205–315 |
| The method 'insertRssLinks' has a Modified Cyclomatic Complexity of 11. | 205–315 |
| Avoid really long methods. | 205–315 |
| The method 'insertRssLinks' has a Standard Cyclomatic Complexity of 11. | 205–315 |
| Deeply nested if..then statements are hard to read | 232–238 |
| Violation | Line |
|---|---|
| Private field '_dilaLocalService' could be made final; it is only initialized in the declaration or constructor. | 72 |
| Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 87 |
| This statement may have some unnecessary parentheses | 130 |
| Position literals first in String comparisons for EqualsIgnoreCase | 130 |
| Do not add empty strings | 177 |
| Do not add empty strings | 190 |
| Violation | Line |
|---|---|
| Private field '_dilaXmlService' could be made final; it is only initialized in the declaration or constructor. | 71 |
| Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 86 |
| Position literals first in String comparisons for EqualsIgnoreCase | 129 |
| This statement may have some unnecessary parentheses | 129 |
| StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 191 |
| StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 192 |
| Avoid appending characters as strings in StringBuffer.append. | 192 |
| Violation | Line |
|---|---|
| Avoid using Literals in Conditional Statements | 73 |
| Violation | Line |
|---|---|
| When instantiating a SimpleDateFormat object, specify a Locale | 64 |
| When instantiating a SimpleDateFormat object, specify a Locale | 78 |
| Violation | Line |
|---|---|
| The String literal "Error creating a combo list : " appears 4 times in this file; the first occurrence is on line 124 | 124 |
| Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 134 |
| Violation | Line |
|---|---|
| Avoid really long methods. | 117–226 |
| When instantiating a SimpleDateFormat object, specify a Locale | 119 |
| StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 124 |
| StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 125 |
| StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 128 |
| StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 129 |
| StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 130 |
| StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 131 |
| StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 132 |
| StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 133 |
| StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 134–135 |
| StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 184 |
| StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 196 |
| StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 197 |
| StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 221 |
| When instantiating a SimpleDateFormat object, specify a Locale | 237 |
| StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 242 |
| StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 243 |
| StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 246 |
| StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 247 |
| StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 248 |
| StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 249 |
| StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 250 |
| StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 251 |
| StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 252–253 |
| StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 304 |
| StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 305 |
| StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 306 |
| StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 308 |
| StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 309 |
| Substitute calls to size() == 0 (or size() != 0, size() > 0, size() < 1) with calls to isEmpty() | 313 |
| Do not add empty strings | 317 |
| Violation | Line |
|---|---|
| When doing a String.toLowerCase()/toUpperCase() call, use a Locale | 59 |
| Violation | Line |
|---|---|
| When doing a String.toLowerCase()/toUpperCase() call, use a Locale | 60 |
| Violation | Line |
|---|---|
| Deeply nested if..then statements are hard to read | 69–74 |
| Violation | Line |
|---|---|
| Possible God class (WMC=58, ATFD=121, TCC=0.30994152046783624) | 34–769 |
| A high number of imports can indicate a high degree of coupling within an object. | 34–769 |
| Perhaps '_nDefaultItemsPerPage' could be replaced by a local variable. | 116 |
| Private field '_dilaComplementaryDataService' could be made final; it is only initialized in the declaration or constructor. | 118 |
| Private field '_dilaComplementaryDataLinkService' could be made final; it is only initialized in the declaration or constructor. | 120 |
| Private field '_dilaXmlService' could be made final; it is only initialized in the declaration or constructor. | 122 |
| Private field '_dilaAudienceService' could be made final; it is only initialized in the declaration or constructor. | 123 |
| If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 132 |
| Prefer StringBuffer over += for concatenating strings | 162 |
| Prefer StringBuffer over += for concatenating strings | 167 |
| Do not add empty strings | 174 |
| If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 195 |
| If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 243 |
| Avoid variables with short names like id | 271 |
| If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 279 |
| If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 295 |
| If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 324 |
| If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 350 |
| If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 379 |
| Avoid variables with short names like id | 473 |
| Avoid variables with short names like id | 553 |
| Avoid unused method parameters such as 'id'. | 575 |
| Avoid variables with short names like id | 575 |
| Violation | Line |
|---|---|
| Private field '_dilaCacheService' could be made final; it is only initialized in the declaration or constructor. | 76 |
| Violation | Line |
|---|---|
| Private field '_dilaLocalService' could be made final; it is only initialized in the declaration or constructor. | 59 |
| Prefer StringBuffer over += for concatenating strings | 86 |
| Prefer StringBuffer over += for concatenating strings | 86 |
| Prefer StringBuffer over += for concatenating strings | 90 |
| Prefer StringBuffer over += for concatenating strings | 90 |
| Violation | Line |
|---|---|
| A high number of imports can indicate a high degree of coupling within an object. | 34–1017 |
| Possible God class (WMC=73, ATFD=151, TCC=0.24867724867724866) | 34–1017 |
| The class 'LocalCardJspBean' has a Cyclomatic Complexity of 3 (Highest = 10). | 79–1017 |
| Private field '_dilaLocalFolderService' could be made final; it is only initialized in the declaration or constructor. | 125 |
| Private field '_dilaLocalService' could be made final; it is only initialized in the declaration or constructor. | 126 |
| Private field '_dilaLocalCardService' could be made final; it is only initialized in the declaration or constructor. | 127 |
| Private field '_dilaAudienceService' could be made final; it is only initialized in the declaration or constructor. | 128 |
| Private field '_dilaLocalCardChapterService' could be made final; it is only initialized in the declaration or constructor. | 129 |
| Private field '_dilaLocalFolderLinkService' could be made final; it is only initialized in the declaration or constructor. | 131 |
| Private field '_dilaValidationService' could be made final; it is only initialized in the declaration or constructor. | 133 |
| If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 142 |
| If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 198 |
| If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 247 |
| If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 271 |
| If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 298 |
| If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 338 |
| If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 364 |
| Avoid using Literals in Conditional Statements | 370 |
| If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 392 |
| If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 417 |
| Avoid declaring a variable if it is unreferenced before a possible exit point. | 440 |
| Avoid declaring a variable if it is unreferenced before a possible exit point. | 470 |
| Avoid declaring a variable if it is unreferenced before a possible exit point. | 503 |
| Avoid declaring a variable if it is unreferenced before a possible exit point. | 533 |
| Avoid declaring a variable if it is unreferenced before a possible exit point. | 564 |
| If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 775 |
| If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 829 |
| Avoid variables with short names like id | 952 |
| The method 'filterLocal' has a Cyclomatic Complexity of 10. | 952–982 |
| Violation | Line |
|---|---|
| Possible God class (WMC=68, ATFD=169, TCC=0.0) | 34–706 |
| A high number of imports can indicate a high degree of coupling within an object. | 34–706 |
| The class 'StyleSheetJspBean' has a Modified Cyclomatic Complexity of 6 (Highest = 12). | 94–706 |
| The class 'StyleSheetJspBean' has a Standard Cyclomatic Complexity of 6 (Highest = 12). | 94–706 |
| The class 'StyleSheetJspBean' has a Cyclomatic Complexity of 7 (Highest = 19). | 94–706 |
| Perhaps '_nDefaultItemsPerPage' could be replaced by a local variable. | 104 |
| Private field '_typeContenuService' could be made final; it is only initialized in the declaration or constructor. | 108 |
| Private field '_dilaStyleSheetService' could be made final; it is only initialized in the declaration or constructor. | 109 |
| Private field '_dilaStyleSheetActionService' could be made final; it is only initialized in the declaration or constructor. | 110 |
| Prefer StringBuffer over += for concatenating strings | 122 |
| Prefer StringBuffer over += for concatenating strings | 122 |
| Prefer StringBuffer over += for concatenating strings | 162 |
| Prefer StringBuffer over += for concatenating strings | 167 |
| If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 174 |
| Do not add empty strings | 201 |
| If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 226 |
| The method doSaveStyleSheet() has an NPath complexity of 800 | 286–364 |
| The method 'doSaveStyleSheet' has a Modified Cyclomatic Complexity of 12. | 286–364 |
| The method 'doSaveStyleSheet' has a Cyclomatic Complexity of 12. | 286–364 |
| The method 'doSaveStyleSheet' has a Standard Cyclomatic Complexity of 12. | 286–364 |
| Avoid declaring a variable if it is unreferenced before a possible exit point. | 288 |
| The String literal "User is not authrorized to access this page." appears 5 times in this file; the first occurrence is on line 305 | 305 |
| If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 395 |
| The method 'getData' has a Standard Cyclomatic Complexity of 11. | 440–539 |
| The method 'getData' has a Modified Cyclomatic Complexity of 11. | 440–539 |
| The method 'getData' has a Cyclomatic Complexity of 19. | 440–539 |
| The method getData() has an NPath complexity of 2800 | 440–539 |
| Avoid declaring a variable if it is unreferenced before a possible exit point. | 443 |
| Avoid declaring a variable if it is unreferenced before a possible exit point. | 445 |
| These nested if statements could be combined | 459–462 |
| Avoid variables with short names like is | 555 |
| These nested if statements could be combined | 590–593 |
| These nested if statements could be combined | 625–628 |
| Avoid variables with short names like os | 694 |
