FindBugs Bug Detector Report
The following document contains the results of FindBugs
FindBugs Version is 3.0.1
Threshold is
Effort is max
Summary
| Classes |
Bugs |
Errors |
Missing Classes |
| 164 |
55 |
0 |
55 |
fr.paris.lutece.plugins.document.business.Document
| Bug |
Category |
Details |
Line |
Priority |
| fr.paris.lutece.plugins.document.business.Document.getDateCreation() may expose internal representation by returning Document._dateCreation |
MALICIOUS_CODE |
EI_EXPOSE_REP |
224 |
Medium |
| fr.paris.lutece.plugins.document.business.Document.getDateModification() may expose internal representation by returning Document._dateModification |
MALICIOUS_CODE |
EI_EXPOSE_REP |
266 |
Medium |
| fr.paris.lutece.plugins.document.business.Document.getDateValidityBegin() may expose internal representation by returning Document._dateValidityBegin |
MALICIOUS_CODE |
EI_EXPOSE_REP |
287 |
Medium |
| fr.paris.lutece.plugins.document.business.Document.getDateValidityEnd() may expose internal representation by returning Document._dateValidityEnd |
MALICIOUS_CODE |
EI_EXPOSE_REP |
308 |
Medium |
| fr.paris.lutece.plugins.document.business.Document.setDateCreation(Timestamp) may expose internal representation by storing an externally mutable object into Document._dateCreation |
MALICIOUS_CODE |
EI_EXPOSE_REP2 |
235 |
Medium |
| fr.paris.lutece.plugins.document.business.Document.setDateModification(Timestamp) may expose internal representation by storing an externally mutable object into Document._dateModification |
MALICIOUS_CODE |
EI_EXPOSE_REP2 |
277 |
Medium |
| fr.paris.lutece.plugins.document.business.Document.setDateValidityBegin(Timestamp) may expose internal representation by storing an externally mutable object into Document._dateValidityBegin |
MALICIOUS_CODE |
EI_EXPOSE_REP2 |
298 |
Medium |
| fr.paris.lutece.plugins.document.business.Document.setDateValidityEnd(Timestamp) may expose internal representation by storing an externally mutable object into Document._dateValidityEnd |
MALICIOUS_CODE |
EI_EXPOSE_REP2 |
319 |
Medium |
fr.paris.lutece.plugins.document.business.DocumentFilter
| Bug |
Category |
Details |
Line |
Priority |
| fr.paris.lutece.plugins.document.business.DocumentFilter.getCategoriesId() may expose internal representation by returning DocumentFilter._arrayCategoriesId |
MALICIOUS_CODE |
EI_EXPOSE_REP |
155 |
Medium |
| fr.paris.lutece.plugins.document.business.DocumentFilter.getIds() may expose internal representation by returning DocumentFilter._arrayId |
MALICIOUS_CODE |
EI_EXPOSE_REP |
192 |
Medium |
| fr.paris.lutece.plugins.document.business.DocumentFilter.setCategoriesId(int[]) may expose internal representation by storing an externally mutable object into DocumentFilter._arrayCategoriesId |
MALICIOUS_CODE |
EI_EXPOSE_REP2 |
164 |
Medium |
| fr.paris.lutece.plugins.document.business.DocumentFilter.setIds(int[]) may expose internal representation by storing an externally mutable object into DocumentFilter._arrayId |
MALICIOUS_CODE |
EI_EXPOSE_REP2 |
201 |
Medium |
fr.paris.lutece.plugins.document.business.DocumentResource
| Bug |
Category |
Details |
Line |
Priority |
| fr.paris.lutece.plugins.document.business.DocumentResource.getContent() may expose internal representation by returning DocumentResource._strContent |
MALICIOUS_CODE |
EI_EXPOSE_REP |
53 |
Medium |
| fr.paris.lutece.plugins.document.business.DocumentResource.setContent(byte[]) may expose internal representation by storing an externally mutable object into DocumentResource._strContent |
MALICIOUS_CODE |
EI_EXPOSE_REP2 |
64 |
Medium |
fr.paris.lutece.plugins.document.business.DocumentType
| Bug |
Category |
Details |
Line |
Priority |
| fr.paris.lutece.plugins.document.business.DocumentType.getAdminXsl() may expose internal representation by returning DocumentType._baAdminXsl |
MALICIOUS_CODE |
EI_EXPOSE_REP |
179 |
Medium |
| fr.paris.lutece.plugins.document.business.DocumentType.getContentServiceXsl() may expose internal representation by returning DocumentType._baContentServiceXsl |
MALICIOUS_CODE |
EI_EXPOSE_REP |
200 |
Medium |
| fr.paris.lutece.plugins.document.business.DocumentType.setAdminXsl(byte[]) may expose internal representation by storing an externally mutable object into DocumentType._baAdminXsl |
MALICIOUS_CODE |
EI_EXPOSE_REP2 |
190 |
Medium |
| fr.paris.lutece.plugins.document.business.DocumentType.setContentServiceXsl(byte[]) may expose internal representation by storing an externally mutable object into DocumentType._baContentServiceXsl |
MALICIOUS_CODE |
EI_EXPOSE_REP2 |
211 |
Medium |
fr.paris.lutece.plugins.document.business.attributes.DocumentAttribute
| Bug |
Category |
Details |
Line |
Priority |
| fr.paris.lutece.plugins.document.business.attributes.DocumentAttribute.getBinaryValue() may expose internal representation by returning DocumentAttribute._bytes |
MALICIOUS_CODE |
EI_EXPOSE_REP |
330 |
Medium |
| fr.paris.lutece.plugins.document.business.attributes.DocumentAttribute.setBinaryValue(byte[]) may expose internal representation by storing an externally mutable object into DocumentAttribute._bytes |
MALICIOUS_CODE |
EI_EXPOSE_REP2 |
320 |
Medium |
fr.paris.lutece.plugins.document.business.autopublication.DocumentAutoPublication
| Bug |
Category |
Details |
Line |
Priority |
| Incorrect lazy initialization and update of static field fr.paris.lutece.plugins.document.business.autopublication.DocumentAutoPublication._listenerDocumentSpace in fr.paris.lutece.plugins.document.business.autopublication.DocumentAutoPublication.init() |
MT_CORRECTNESS |
LI_LAZY_INIT_UPDATE_STATIC |
54-56 |
Medium |
fr.paris.lutece.plugins.document.business.category.Category
| Bug |
Category |
Details |
Line |
Priority |
| fr.paris.lutece.plugins.document.business.category.Category.getIconContent() may expose internal representation by returning Category._byteIconContent |
MALICIOUS_CODE |
EI_EXPOSE_REP |
57 |
Medium |
| fr.paris.lutece.plugins.document.business.category.Category.setIconContent(byte[]) may expose internal representation by storing an externally mutable object into Category._byteIconContent |
MALICIOUS_CODE |
EI_EXPOSE_REP2 |
66 |
Medium |
fr.paris.lutece.plugins.document.business.history.HistoryEvent
| Bug |
Category |
Details |
Line |
Priority |
| fr.paris.lutece.plugins.document.business.history.HistoryEvent.getDate() may expose internal representation by returning HistoryEvent._eventDate |
MALICIOUS_CODE |
EI_EXPOSE_REP |
108 |
Medium |
| fr.paris.lutece.plugins.document.business.history.HistoryEvent.setDate(Timestamp) may expose internal representation by storing an externally mutable object into HistoryEvent._eventDate |
MALICIOUS_CODE |
EI_EXPOSE_REP2 |
119 |
Medium |
fr.paris.lutece.plugins.document.business.portlet.DocumentListPortlet
| Bug |
Category |
Details |
Line |
Priority |
| fr.paris.lutece.plugins.document.business.portlet.DocumentListPortlet.getIdCategory() may expose internal representation by returning DocumentListPortlet._nArrayIdCategory |
MALICIOUS_CODE |
EI_EXPOSE_REP |
170 |
Medium |
| fr.paris.lutece.plugins.document.business.portlet.DocumentListPortlet.setIdCategory(int[]) may expose internal representation by storing an externally mutable object into DocumentListPortlet._nArrayIdCategory |
MALICIOUS_CODE |
EI_EXPOSE_REP2 |
179 |
Medium |
fr.paris.lutece.plugins.document.business.portlet.DocumentPortlet
| Bug |
Category |
Details |
Line |
Priority |
| fr.paris.lutece.plugins.document.business.portlet.DocumentPortlet.getIdCategory() may expose internal representation by returning DocumentPortlet._nArrayIdCategory |
MALICIOUS_CODE |
EI_EXPOSE_REP |
173 |
Medium |
| fr.paris.lutece.plugins.document.business.portlet.DocumentPortlet.setIdCategory(int[]) may expose internal representation by storing an externally mutable object into DocumentPortlet._nArrayIdCategory |
MALICIOUS_CODE |
EI_EXPOSE_REP2 |
182 |
Medium |
fr.paris.lutece.plugins.document.business.portlet.PortletFilter
| Bug |
Category |
Details |
Line |
Priority |
| fr.paris.lutece.plugins.document.business.portlet.PortletFilter.getPageName() may expose internal representation by returning PortletFilter._tabPageName |
MALICIOUS_CODE |
EI_EXPOSE_REP |
80 |
Medium |
| fr.paris.lutece.plugins.document.business.portlet.PortletFilter.getPortletName() may expose internal representation by returning PortletFilter._tabPortletName |
MALICIOUS_CODE |
EI_EXPOSE_REP |
101 |
Medium |
| fr.paris.lutece.plugins.document.business.portlet.PortletFilter.setPageName(String[]) may expose internal representation by storing an externally mutable object into PortletFilter._tabPageName |
MALICIOUS_CODE |
EI_EXPOSE_REP2 |
70 |
Medium |
| fr.paris.lutece.plugins.document.business.portlet.PortletFilter.setPortletName(String[]) may expose internal representation by storing an externally mutable object into PortletFilter._tabPortletName |
MALICIOUS_CODE |
EI_EXPOSE_REP2 |
91 |
Medium |
fr.paris.lutece.plugins.document.business.publication.DocumentPublication
| Bug |
Category |
Details |
Line |
Priority |
| fr.paris.lutece.plugins.document.business.publication.DocumentPublication.getDatePublishing() may expose internal representation by returning DocumentPublication._datePublishing |
MALICIOUS_CODE |
EI_EXPOSE_REP |
129 |
Medium |
| fr.paris.lutece.plugins.document.business.publication.DocumentPublication.setDatePublishing(Date) may expose internal representation by storing an externally mutable object into DocumentPublication._datePublishing |
MALICIOUS_CODE |
EI_EXPOSE_REP2 |
138 |
Medium |
fr.paris.lutece.plugins.document.business.rules.RuleTypesSet
| Bug |
Category |
Details |
Line |
Priority |
| fr.paris.lutece.plugins.document.business.rules.RuleTypesSet.getRuleTypeKey(Rule) makes inefficient use of keySet iterator instead of entrySet iterator |
PERFORMANCE |
WMI_WRONG_MAP_ITERATOR |
103 |
Medium |
fr.paris.lutece.plugins.document.modules.rulemovespace.business.MoveSpaceRule
| Bug |
Category |
Details |
Line |
Priority |
| fr.paris.lutece.plugins.document.modules.rulemovespace.business.MoveSpaceRule.getAttributesList() may expose internal representation by returning MoveSpaceRule._attributes |
MALICIOUS_CODE |
EI_EXPOSE_REP |
258 |
Medium |
| Incorrect lazy initialization and update of static field fr.paris.lutece.plugins.document.modules.rulemovespace.business.MoveSpaceRule._listenerSpaces in fr.paris.lutece.plugins.document.modules.rulemovespace.business.MoveSpaceRule.init() |
MT_CORRECTNESS |
LI_LAZY_INIT_UPDATE_STATIC |
90-92 |
Medium |
fr.paris.lutece.plugins.document.modules.rulenotifyusers.business.NotifyUsersRule
| Bug |
Category |
Details |
Line |
Priority |
| fr.paris.lutece.plugins.document.modules.rulenotifyusers.business.NotifyUsersRule.getAttributesList() may expose internal representation by returning NotifyUsersRule._attributes |
MALICIOUS_CODE |
EI_EXPOSE_REP |
311 |
Medium |
| Incorrect lazy initialization and update of static field fr.paris.lutece.plugins.document.modules.rulenotifyusers.business.NotifyUsersRule._listenerMailingList in fr.paris.lutece.plugins.document.modules.rulenotifyusers.business.NotifyUsersRule.init() |
MT_CORRECTNESS |
LI_LAZY_INIT_UPDATE_STATIC |
130-132 |
Medium |
| Incorrect lazy initialization and update of static field fr.paris.lutece.plugins.document.modules.rulenotifyusers.business.NotifyUsersRule._listenerSpace in fr.paris.lutece.plugins.document.modules.rulenotifyusers.business.NotifyUsersRule.init() |
MT_CORRECTNESS |
LI_LAZY_INIT_UPDATE_STATIC |
136-138 |
Medium |
fr.paris.lutece.plugins.document.service.DocumentEventListernersManager
| Bug |
Category |
Details |
Line |
Priority |
| Write to static field fr.paris.lutece.plugins.document.service.DocumentEventListernersManager._listEventListeners from instance method fr.paris.lutece.plugins.document.service.DocumentEventListernersManager.setListeners(List) |
STYLE |
ST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD |
58 |
High |
fr.paris.lutece.plugins.document.service.DocumentService
| Bug |
Category |
Details |
Line |
Priority |
| Boxing/unboxing to parse a primitive fr.paris.lutece.plugins.document.service.DocumentService.setAttribute(DocumentAttribute, Document, MultipartHttpServletRequest, Locale) |
PERFORMANCE |
DM_BOXED_PRIMITIVE_FOR_PARSING |
798 |
High |
fr.paris.lutece.plugins.document.service.category.CategoryService$CategoryDisplay
| Bug |
Category |
Details |
Line |
Priority |
| Should fr.paris.lutece.plugins.document.service.category.CategoryService$CategoryDisplay be a _static_ inner class? |
PERFORMANCE |
SIC_INNER_SHOULD_BE_STATIC |
247-324 |
Medium |
fr.paris.lutece.plugins.document.service.docsearch.DefaultDocSearchIndexer
| Bug |
Category |
Details |
Line |
Priority |
| Found reliance on default encoding in fr.paris.lutece.plugins.document.service.docsearch.DefaultDocSearchIndexer.getDocument(Document): String.getBytes() |
I18N |
DM_DEFAULT_ENCODING |
139 |
High |
fr.paris.lutece.plugins.document.service.docsearch.DocSearchService
| Bug |
Category |
Details |
Line |
Priority |
| Exception is caught when Exception is not thrown in fr.paris.lutece.plugins.document.service.docsearch.DocSearchService.getSearchResults(String, int, AdminUser) |
STYLE |
REC_CATCH_EXCEPTION |
413 |
Medium |
| Exception is caught when Exception is not thrown in fr.paris.lutece.plugins.document.service.docsearch.DocSearchService.getSearchResults(String, boolean, boolean, String, DocumentType) |
STYLE |
REC_CATCH_EXCEPTION |
547 |
Medium |
| Write to static field fr.paris.lutece.plugins.document.service.docsearch.DocSearchService._searcher from instance method fr.paris.lutece.plugins.document.service.docsearch.DocSearchService.getSearchResults(String, int, AdminUser) |
STYLE |
ST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD |
375 |
High |
| Write to static field fr.paris.lutece.plugins.document.service.docsearch.DocSearchService._searcher from instance method fr.paris.lutece.plugins.document.service.docsearch.DocSearchService.getSearchResults(String, boolean, boolean, String, DocumentType) |
STYLE |
ST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD |
437 |
High |
fr.paris.lutece.plugins.document.service.search.DocumentIndexer
| Bug |
Category |
Details |
Line |
Priority |
| Found reliance on default encoding in fr.paris.lutece.plugins.document.service.search.DocumentIndexer.getDocument(Document, String, String, String): String.getBytes() |
I18N |
DM_DEFAULT_ENCODING |
276 |
High |
fr.paris.lutece.plugins.document.web.DocumentJspBean
| Bug |
Category |
Details |
Line |
Priority |
| Boxing/unboxing to parse a primitive fr.paris.lutece.plugins.document.web.DocumentJspBean.getMassArchivalDocument(HttpServletRequest) |
PERFORMANCE |
DM_BOXED_PRIMITIVE_FOR_PARSING |
1623 |
High |
fr.paris.lutece.plugins.document.web.DocumentTypeJspBean
| Bug |
Category |
Details |
Line |
Priority |
| Redundant nullcheck of strCode, which is known to be non-null in fr.paris.lutece.plugins.document.web.DocumentTypeJspBean.validateCodeAttribute(HttpServletRequest) |
STYLE |
RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE |
531 |
Medium |
fr.paris.lutece.plugins.document.web.ResourceValueObject
| Bug |
Category |
Details |
Line |
Priority |
| fr.paris.lutece.plugins.document.web.ResourceValueObject.getContent() may expose internal representation by returning ResourceValueObject._content |
MALICIOUS_CODE |
EI_EXPOSE_REP |
104 |
Medium |
| fr.paris.lutece.plugins.document.web.ResourceValueObject.setContent(byte[]) may expose internal representation by storing an externally mutable object into ResourceValueObject._content |
MALICIOUS_CODE |
EI_EXPOSE_REP2 |
113 |
Medium |
fr.paris.lutece.plugins.document.web.publishing.DocumentPublishingJspBean
| Bug |
Category |
Details |
Line |
Priority |
| Switch statement found in fr.paris.lutece.plugins.document.web.publishing.DocumentPublishingJspBean.doChangeModePublication(HttpServletRequest) where default case is missing |
STYLE |
SF_SWITCH_NO_DEFAULT |
665-668 |
Medium |
