Lutece helpdesk plugin – Checkstyle Results

Checkstyle Results

The following document contains the results of Checkstyle 8.19 with build-config/lutece_checks.xml ruleset.

Summary

Files	Info	Warnings	Errors
53	0	7	89

Files

File	W	E
fr/paris/lutece/plugins/helpdesk/business/AbstractSubject.java	0	1
fr/paris/lutece/plugins/helpdesk/business/AbstractSubjectHome.java	3	1
fr/paris/lutece/plugins/helpdesk/business/AbstractSubjectHomeInterface.java	0	1
fr/paris/lutece/plugins/helpdesk/business/Faq.java	0	3
fr/paris/lutece/plugins/helpdesk/business/FaqDAO.java	0	1
fr/paris/lutece/plugins/helpdesk/business/FaqHome.java	0	4
fr/paris/lutece/plugins/helpdesk/business/FaqRoleRemovalListener.java	0	1
fr/paris/lutece/plugins/helpdesk/business/FaqWorkgroupRemovalListener.java	0	1
fr/paris/lutece/plugins/helpdesk/business/IAbstractSubjectDAO.java	0	1
fr/paris/lutece/plugins/helpdesk/business/IFaqDAO.java	0	1
fr/paris/lutece/plugins/helpdesk/business/IQuestionAnswerDAO.java	0	1
fr/paris/lutece/plugins/helpdesk/business/ISubjectDAO.java	0	1
fr/paris/lutece/plugins/helpdesk/business/IThemeDAO.java	0	1
fr/paris/lutece/plugins/helpdesk/business/IVisitorQuestionDAO.java	0	1
fr/paris/lutece/plugins/helpdesk/business/QuestionAnswer.java	0	1
fr/paris/lutece/plugins/helpdesk/business/QuestionAnswerDAO.java	0	3
fr/paris/lutece/plugins/helpdesk/business/QuestionAnswerHome.java	1	1
fr/paris/lutece/plugins/helpdesk/business/Subject.java	0	1
fr/paris/lutece/plugins/helpdesk/business/SubjectDAO.java	0	1
fr/paris/lutece/plugins/helpdesk/business/SubjectHome.java	0	1
fr/paris/lutece/plugins/helpdesk/business/Theme.java	0	1
fr/paris/lutece/plugins/helpdesk/business/ThemeDAO.java	0	1
fr/paris/lutece/plugins/helpdesk/business/ThemeHome.java	0	1
fr/paris/lutece/plugins/helpdesk/business/ThemeMailingListRemovalListener.java	0	1
fr/paris/lutece/plugins/helpdesk/business/VisitorQuestion.java	0	1
fr/paris/lutece/plugins/helpdesk/business/VisitorQuestionDAO.java	0	1
fr/paris/lutece/plugins/helpdesk/business/VisitorQuestionHome.java	0	1
fr/paris/lutece/plugins/helpdesk/service/FaqResourceIdService.java	0	1
fr/paris/lutece/plugins/helpdesk/service/HelpdeskPlugin.java	0	1
fr/paris/lutece/plugins/helpdesk/service/HelpdeskService.java	0	1
fr/paris/lutece/plugins/helpdesk/service/helpdesksearch/HelpdeskLuceneSearchEngine.java	0	5
fr/paris/lutece/plugins/helpdesk/service/helpdesksearch/HelpdeskSearchEngine.java	0	1
fr/paris/lutece/plugins/helpdesk/service/helpdesksearch/HelpdeskSearchItem.java	0	1
fr/paris/lutece/plugins/helpdesk/service/helpdesksearch/HelpdeskSearchService.java	1	3
fr/paris/lutece/plugins/helpdesk/service/search/HelpdeskIndexer.java	0	1
fr/paris/lutece/plugins/helpdesk/utils/HelpdeskIndexerUtils.java	0	4
fr/paris/lutece/plugins/helpdesk/web/EnumColumns.java	0	1
fr/paris/lutece/plugins/helpdesk/web/HelpdeskApp.java	0	4
fr/paris/lutece/plugins/helpdesk/web/HelpdeskJspBean.java	2	22
fr/paris/lutece/plugins/helpdesk/web/HelpdeskSearchJspBean.java	0	10

Rules

Category	Rule	Violations	Severity
blocks	LeftCurly option: `"nl"`	1	Error
coding	DeclarationOrder	5	Error
	ReturnCount max: `"5"`	6	Warning
design	HideUtilityClassConstructor	2	Error
header	Header fileExtensions: `"java"` headerFile: `"/var/jenkins_home/jobs/admin-github-build/workspace/target/checkstyle-header.txt"`	40	Error
javadoc	JavadocMethod	10	Error
sizes	ParameterNumber	1	Warning
whitespace	ParenPad option: `"space"`	31	Error

Details

fr/paris/lutece/plugins/helpdesk/business/AbstractSubject.java

Severity	Category	Rule	Message	Line
Error	header	Header	Line does not match expected header line of ' * Copyright (c) 2002-2020, City of Paris'.	2

fr/paris/lutece/plugins/helpdesk/business/AbstractSubjectHome.java

Severity	Category	Rule	Message	Line
Error	header	Header	Line does not match expected header line of ' * Copyright (c) 2002-2020, City of Paris'.	2
Warning	coding	ReturnCount	Return count is 2 (max allowed for void methods/constructors/lambdas is 1).	266
Warning	coding	ReturnCount	Return count is 2 (max allowed for void methods/constructors/lambdas is 1).	315
Warning	coding	ReturnCount	Return count is 2 (max allowed for void methods/constructors/lambdas is 1).	344

fr/paris/lutece/plugins/helpdesk/business/AbstractSubjectHomeInterface.java

Severity	Category	Rule	Message	Line
Error	header	Header	Line does not match expected header line of ' * Copyright (c) 2002-2020, City of Paris'.	2

fr/paris/lutece/plugins/helpdesk/business/Faq.java

Severity	Category	Rule	Message	Line
Error	header	Header	Line does not match expected header line of ' * Copyright (c) 2002-2020, City of Paris'.	2
Error	coding	DeclarationOrder	Variable access definition in wrong order.	51
Error	coding	DeclarationOrder	Variable access definition in wrong order.	52

fr/paris/lutece/plugins/helpdesk/business/FaqDAO.java

Severity	Category	Rule	Message	Line
Error	header	Header	Line does not match expected header line of ' * Copyright (c) 2002-2020, City of Paris'.	2

fr/paris/lutece/plugins/helpdesk/business/FaqHome.java

Severity	Category	Rule	Message	Line
Error	header	Header	Line does not match expected header line of ' * Copyright (c) 2002-2020, City of Paris'.	2
Error	design	HideUtilityClassConstructor	Utility classes should not have a public or default constructor.	53
Error	whitespace	ParenPad	'(' is not followed by whitespace.	193
Error	whitespace	ParenPad	')' is not preceded with whitespace.	193

fr/paris/lutece/plugins/helpdesk/business/FaqRoleRemovalListener.java

Severity	Category	Rule	Message	Line
Error	header	Header	Line does not match expected header line of ' * Copyright (c) 2002-2020, City of Paris'.	2

fr/paris/lutece/plugins/helpdesk/business/FaqWorkgroupRemovalListener.java

Severity	Category	Rule	Message	Line
Error	header	Header	Line does not match expected header line of ' * Copyright (c) 2002-2020, City of Paris'.	2

fr/paris/lutece/plugins/helpdesk/business/IAbstractSubjectDAO.java

Severity	Category	Rule	Message	Line
Error	header	Header	Line does not match expected header line of ' * Copyright (c) 2002-2020, City of Paris'.	2

fr/paris/lutece/plugins/helpdesk/business/IFaqDAO.java

Severity	Category	Rule	Message	Line
Error	header	Header	Line does not match expected header line of ' * Copyright (c) 2002-2020, City of Paris'.	2

fr/paris/lutece/plugins/helpdesk/business/IQuestionAnswerDAO.java

Severity	Category	Rule	Message	Line
Error	header	Header	Line does not match expected header line of ' * Copyright (c) 2002-2020, City of Paris'.	2

fr/paris/lutece/plugins/helpdesk/business/ISubjectDAO.java

Severity	Category	Rule	Message	Line
Error	header	Header	Line does not match expected header line of ' * Copyright (c) 2002-2020, City of Paris'.	2

fr/paris/lutece/plugins/helpdesk/business/IThemeDAO.java

Severity	Category	Rule	Message	Line
Error	header	Header	Line does not match expected header line of ' * Copyright (c) 2002-2020, City of Paris'.	2

fr/paris/lutece/plugins/helpdesk/business/IVisitorQuestionDAO.java

Severity	Category	Rule	Message	Line
Error	header	Header	Line does not match expected header line of ' * Copyright (c) 2002-2020, City of Paris'.	2

fr/paris/lutece/plugins/helpdesk/business/QuestionAnswer.java

Severity	Category	Rule	Message	Line
Error	header	Header	Line does not match expected header line of ' * Copyright (c) 2002-2020, City of Paris'.	2

fr/paris/lutece/plugins/helpdesk/business/QuestionAnswerDAO.java

Severity	Category	Rule	Message	Line
Error	header	Header	Line does not match expected header line of ' * Copyright (c) 2002-2020, City of Paris'.	2
Error	whitespace	ParenPad	'(' is not followed by whitespace.	300
Error	whitespace	ParenPad	')' is not preceded with whitespace.	300

fr/paris/lutece/plugins/helpdesk/business/QuestionAnswerHome.java

Severity	Category	Rule	Message	Line
Error	header	Header	Line does not match expected header line of ' * Copyright (c) 2002-2020, City of Paris'.	2
Warning	coding	ReturnCount	Return count is 2 (max allowed for void methods/constructors/lambdas is 1).	294

fr/paris/lutece/plugins/helpdesk/business/Subject.java

Severity	Category	Rule	Message	Line
Error	header	Header	Line does not match expected header line of ' * Copyright (c) 2002-2020, City of Paris'.	2

fr/paris/lutece/plugins/helpdesk/business/SubjectDAO.java

Severity	Category	Rule	Message	Line
Error	header	Header	Line does not match expected header line of ' * Copyright (c) 2002-2020, City of Paris'.	2

fr/paris/lutece/plugins/helpdesk/business/SubjectHome.java

Severity	Category	Rule	Message	Line
Error	header	Header	Line does not match expected header line of ' * Copyright (c) 2002-2020, City of Paris'.	2

fr/paris/lutece/plugins/helpdesk/business/Theme.java

Severity	Category	Rule	Message	Line
Error	header	Header	Line does not match expected header line of ' * Copyright (c) 2002-2020, City of Paris'.	2

fr/paris/lutece/plugins/helpdesk/business/ThemeDAO.java

Severity	Category	Rule	Message	Line
Error	header	Header	Line does not match expected header line of ' * Copyright (c) 2002-2020, City of Paris'.	2

fr/paris/lutece/plugins/helpdesk/business/ThemeHome.java

Severity	Category	Rule	Message	Line
Error	header	Header	Line does not match expected header line of ' * Copyright (c) 2002-2020, City of Paris'.	2

fr/paris/lutece/plugins/helpdesk/business/ThemeMailingListRemovalListener.java

Severity	Category	Rule	Message	Line
Error	header	Header	Line does not match expected header line of ' * Copyright (c) 2002-2020, City of Paris'.	2

fr/paris/lutece/plugins/helpdesk/business/VisitorQuestion.java

Severity	Category	Rule	Message	Line
Error	header	Header	Line does not match expected header line of ' * Copyright (c) 2002-2020, City of Paris'.	2

fr/paris/lutece/plugins/helpdesk/business/VisitorQuestionDAO.java

Severity	Category	Rule	Message	Line
Error	header	Header	Line does not match expected header line of ' * Copyright (c) 2002-2020, City of Paris'.	2

fr/paris/lutece/plugins/helpdesk/business/VisitorQuestionHome.java

Severity	Category	Rule	Message	Line
Error	header	Header	Line does not match expected header line of ' * Copyright (c) 2002-2020, City of Paris'.	2

fr/paris/lutece/plugins/helpdesk/service/FaqResourceIdService.java

Severity	Category	Rule	Message	Line
Error	header	Header	Line does not match expected header line of ' * Copyright (c) 2002-2020, City of Paris'.	2

fr/paris/lutece/plugins/helpdesk/service/HelpdeskPlugin.java

Severity	Category	Rule	Message	Line
Error	header	Header	Line does not match expected header line of ' * Copyright (c) 2002-2020, City of Paris'.	2

fr/paris/lutece/plugins/helpdesk/service/HelpdeskService.java

Severity	Category	Rule	Message	Line
Error	header	Header	Line does not match expected header line of ' * Copyright (c) 2002-2020, City of Paris'.	2

fr/paris/lutece/plugins/helpdesk/service/helpdesksearch/HelpdeskLuceneSearchEngine.java

Severity	Category	Rule	Message	Line
Error	header	Header	Line does not match expected header line of ' * Copyright (c) 2002-2020, City of Paris'.	2
Error	whitespace	ParenPad	'(' is not followed by whitespace.	263
Error	whitespace	ParenPad	')' is not preceded with whitespace.	263
Error	blocks	LeftCurly	'{' at column 59 should be on a new line.	263
Error	whitespace	ParenPad	'(' is not followed by whitespace.	264

fr/paris/lutece/plugins/helpdesk/service/helpdesksearch/HelpdeskSearchEngine.java

Severity	Category	Rule	Message	Line
Error	header	Header	Line does not match expected header line of ' * Copyright (c) 2002-2020, City of Paris'.	2

fr/paris/lutece/plugins/helpdesk/service/helpdesksearch/HelpdeskSearchItem.java

Severity	Category	Rule	Message	Line
Error	header	Header	Line does not match expected header line of ' * Copyright (c) 2002-2020, City of Paris'.	2

fr/paris/lutece/plugins/helpdesk/service/helpdesksearch/HelpdeskSearchService.java

Severity	Category	Rule	Message	Line
Error	header	Header	Line does not match expected header line of ' * Copyright (c) 2002-2020, City of Paris'.	2
Warning	sizes	ParameterNumber	More than 7 parameters (found 8).	93
Error	javadoc	JavadocMethod	Unused @param tag for 'subject'.	125
Error	javadoc	JavadocMethod	Unused @param tag for 'bSearchSubSubjects'.	126

fr/paris/lutece/plugins/helpdesk/service/search/HelpdeskIndexer.java

Severity	Category	Rule	Message	Line
Error	header	Header	Line does not match expected header line of ' * Copyright (c) 2002-2020, City of Paris'.	2

fr/paris/lutece/plugins/helpdesk/utils/HelpdeskIndexerUtils.java

Severity	Category	Rule	Message	Line
Error	header	Header	Line does not match expected header line of '/*'.	1
Error	design	HideUtilityClassConstructor	Utility classes should not have a public or default constructor.	12
Error	whitespace	ParenPad	'(' is not followed by whitespace.	29
Error	whitespace	ParenPad	')' is not preceded with whitespace.	29

fr/paris/lutece/plugins/helpdesk/web/EnumColumns.java

Severity	Category	Rule	Message	Line
Error	header	Header	Line does not match expected header line of ' * Copyright (c) 2002-2020, City of Paris'.	2

fr/paris/lutece/plugins/helpdesk/web/HelpdeskApp.java

Severity	Category	Rule	Message	Line
Error	header	Header	Line does not match expected header line of ' * Copyright (c) 2002-2020, City of Paris'.	2
Error	coding	DeclarationOrder	Variable access definition in wrong order.	87
Error	coding	DeclarationOrder	Variable access definition in wrong order.	88
Error	coding	DeclarationOrder	Variable access definition in wrong order.	89

fr/paris/lutece/plugins/helpdesk/web/HelpdeskJspBean.java

Severity	Category	Rule	Message	Line
Error	header	Header	Line does not match expected header line of ' * Copyright (c) 2002-2020, City of Paris'.	2
Error	whitespace	ParenPad	'(' is not followed by whitespace.	761
Error	whitespace	ParenPad	'(' is not followed by whitespace.	788
Error	whitespace	ParenPad	')' is not preceded with whitespace.	826
Error	whitespace	ParenPad	'(' is not followed by whitespace.	892
Error	whitespace	ParenPad	'(' is not followed by whitespace.	1002
Error	whitespace	ParenPad	')' is not preceded with whitespace.	1002
Error	whitespace	ParenPad	')' is not preceded with whitespace.	1244
Warning	coding	ReturnCount	Return count is 6 (max allowed for non-void methods/lambdas is 5).	1568
Error	javadoc	JavadocMethod	Expected @param tag for 'listQuestionAnswers'.	1568
Error	javadoc	JavadocMethod	Expected @param tag for 'faq'.	1568
Error	javadoc	JavadocMethod	Expected @param tag for 'bDeleteList'.	1569
Error	javadoc	JavadocMethod	Expected @param tag for 'questionAnswerList'.	1569
Error	whitespace	ParenPad	')' is not preceded with whitespace.	1569
Error	whitespace	ParenPad	')' is not preceded with whitespace.	1623
Error	whitespace	ParenPad	'(' is not followed by whitespace.	1729
Error	whitespace	ParenPad	')' is not preceded with whitespace.	1729
Warning	coding	ReturnCount	Return count is 6 (max allowed for non-void methods/lambdas is 5).	1748
Error	whitespace	ParenPad	'(' is not followed by whitespace.	1774
Error	whitespace	ParenPad	')' is not preceded with whitespace.	1774
Error	javadoc	JavadocMethod	Unused @param tag for 'strSubjectId'.	2527
Error	javadoc	JavadocMethod	Expected @param tag for 'strIdOrder'.	2531
Error	whitespace	ParenPad	')' is not preceded with whitespace.	2538
Error	javadoc	JavadocMethod	Expected @param tag for 'isMulti'.	2601

fr/paris/lutece/plugins/helpdesk/web/HelpdeskSearchJspBean.java

Severity	Category	Rule	Message	Line
Error	header	Header	Line does not match expected header line of ' * Copyright (c) 2002-2020, City of Paris'.	2
Error	whitespace	ParenPad	')' is not preceded with whitespace.	170
Error	whitespace	ParenPad	')' is not preceded with whitespace.	171
Error	whitespace	ParenPad	'(' is not followed by whitespace.	198
Error	javadoc	JavadocMethod	Unused @param tag for 'response'.	280
Error	whitespace	ParenPad	'(' is not followed by whitespace.	283
Error	whitespace	ParenPad	')' is not preceded with whitespace.	283
Error	whitespace	ParenPad	')' is not preceded with whitespace.	287
Error	whitespace	ParenPad	'(' is not followed by whitespace.	295
Error	whitespace	ParenPad	'(' is not followed by whitespace.	296