SpotBugs Bug Detector Report
The following document contains the results of SpotBugs
SpotBugs Version is 4.5.3
Threshold is medium
Effort is default
Summary
| Classes |
Bugs |
Errors |
Missing Classes |
| 41 |
25 |
0 |
0 |
fr.paris.lutece.plugins.helpdesk.business.Faq
| Bug |
Category |
Details |
Line |
Priority |
| Incorrect lazy initialization and update of static field fr.paris.lutece.plugins.helpdesk.business.Faq._listenerRole in fr.paris.lutece.plugins.helpdesk.business.Faq.init() |
MT_CORRECTNESS |
LI_LAZY_INIT_UPDATE_STATIC |
78-80 |
Medium |
| Incorrect lazy initialization and update of static field fr.paris.lutece.plugins.helpdesk.business.Faq._listenerWorkgroup in fr.paris.lutece.plugins.helpdesk.business.Faq.init() |
MT_CORRECTNESS |
LI_LAZY_INIT_UPDATE_STATIC |
72-74 |
Medium |
fr.paris.lutece.plugins.helpdesk.business.QuestionAnswer
| Bug |
Category |
Details |
Line |
Priority |
| fr.paris.lutece.plugins.helpdesk.business.QuestionAnswer.getCreationDate() may expose internal representation by returning QuestionAnswer._dateCreation |
MALICIOUS_CODE |
EI_EXPOSE_REP |
175 |
Medium |
| fr.paris.lutece.plugins.helpdesk.business.QuestionAnswer.setCreationDate(Date) may expose internal representation by storing an externally mutable object into QuestionAnswer._dateCreation |
MALICIOUS_CODE |
EI_EXPOSE_REP2 |
183 |
Medium |
fr.paris.lutece.plugins.helpdesk.business.Subject
| Bug |
Category |
Details |
Line |
Priority |
| fr.paris.lutece.plugins.helpdesk.business.Subject.getQuestions() may expose internal representation by returning Subject._questions |
MALICIOUS_CODE |
EI_EXPOSE_REP |
62 |
Medium |
| fr.paris.lutece.plugins.helpdesk.business.Subject.setQuestions(List) may expose internal representation by storing an externally mutable object into Subject._questions |
MALICIOUS_CODE |
EI_EXPOSE_REP2 |
71 |
Medium |
fr.paris.lutece.plugins.helpdesk.business.SubjectHome
| Bug |
Category |
Details |
Line |
Priority |
| Public static fr.paris.lutece.plugins.helpdesk.business.SubjectHome.getInstance() may expose internal representation by returning SubjectHome._singleton |
MALICIOUS_CODE |
MS_EXPOSE_REP |
77 |
Medium |
fr.paris.lutece.plugins.helpdesk.business.Theme
| Bug |
Category |
Details |
Line |
Priority |
| fr.paris.lutece.plugins.helpdesk.business.Theme.getQuestions() may expose internal representation by returning Theme._questions |
MALICIOUS_CODE |
EI_EXPOSE_REP |
77 |
Medium |
| fr.paris.lutece.plugins.helpdesk.business.Theme.setQuestions(Collection) may expose internal representation by storing an externally mutable object into Theme._questions |
MALICIOUS_CODE |
EI_EXPOSE_REP2 |
86 |
Medium |
| Incorrect lazy initialization and update of static field fr.paris.lutece.plugins.helpdesk.business.Theme._listenerMailinglist in fr.paris.lutece.plugins.helpdesk.business.Theme.init() |
MT_CORRECTNESS |
LI_LAZY_INIT_UPDATE_STATIC |
64-66 |
Medium |
fr.paris.lutece.plugins.helpdesk.business.ThemeHome
| Bug |
Category |
Details |
Line |
Priority |
| Public static fr.paris.lutece.plugins.helpdesk.business.ThemeHome.getInstance() may expose internal representation by returning ThemeHome._singleton |
MALICIOUS_CODE |
MS_EXPOSE_REP |
82 |
Medium |
fr.paris.lutece.plugins.helpdesk.business.VisitorQuestion
| Bug |
Category |
Details |
Line |
Priority |
| fr.paris.lutece.plugins.helpdesk.business.VisitorQuestion.getDate() may expose internal representation by returning VisitorQuestion._dateVQ |
MALICIOUS_CODE |
EI_EXPOSE_REP |
184 |
Medium |
| fr.paris.lutece.plugins.helpdesk.business.VisitorQuestion.setDate(Date) may expose internal representation by storing an externally mutable object into VisitorQuestion._dateVQ |
MALICIOUS_CODE |
EI_EXPOSE_REP2 |
174 |
Medium |
fr.paris.lutece.plugins.helpdesk.service.helpdesksearch.HelpdeskLuceneSearchEngine
| Bug |
Category |
Details |
Line |
Priority |
| Exception is caught when Exception is not thrown in fr.paris.lutece.plugins.helpdesk.service.helpdesksearch.HelpdeskLuceneSearchEngine.getSearchResults(int, String, Date, Date, Subject, boolean, HttpServletRequest) |
STYLE |
REC_CATCH_EXCEPTION |
208 |
Medium |
fr.paris.lutece.plugins.helpdesk.service.search.HelpdeskIndexer
| Bug |
Category |
Details |
Line |
Priority |
| Found reliance on default encoding in fr.paris.lutece.plugins.helpdesk.service.search.HelpdeskIndexer.getDocument(int, QuestionAnswer, String, String, Plugin): String.getBytes() |
I18N |
DM_DEFAULT_ENCODING |
316 |
High |
fr.paris.lutece.plugins.helpdesk.web.HelpdeskJspBean
| Bug |
Category |
Details |
Line |
Priority |
| Possible null pointer dereference of questionAnswer in fr.paris.lutece.plugins.helpdesk.web.HelpdeskJspBean.doPublishQuestionAnswer(HttpServletRequest) |
CORRECTNESS |
NP_NULL_ON_SOME_PATH |
1126 |
Medium |
| Possible null pointer dereference of questionAnswer in fr.paris.lutece.plugins.helpdesk.web.HelpdeskJspBean.doUnpublishQuestionAnswer(HttpServletRequest) |
CORRECTNESS |
NP_NULL_ON_SOME_PATH |
1164 |
Medium |
| Redundant nullcheck of listQuestionAnswers, which is known to be non-null in fr.paris.lutece.plugins.helpdesk.web.HelpdeskJspBean.doConfirmImportQuestionAnswerList(HttpServletRequest) |
STYLE |
RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE |
1724 |
Medium |
| Redundant nullcheck of faq, which is known to be non-null in fr.paris.lutece.plugins.helpdesk.web.HelpdeskJspBean.doCreateTheme(HttpServletRequest) |
STYLE |
RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE |
2029 |
Medium |
| Redundant nullcheck of listQuestionAnswers, which is known to be non-null in fr.paris.lutece.plugins.helpdesk.web.HelpdeskJspBean.doImportQuestionAnswerList(HttpServletRequest) |
STYLE |
RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE |
1768 |
Medium |
| Redundant nullcheck of faq, which is known to be non-null in fr.paris.lutece.plugins.helpdesk.web.HelpdeskJspBean.doModifyFaq(HttpServletRequest) |
STYLE |
RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE |
2411 |
Medium |
fr.paris.lutece.plugins.helpdesk.web.HelpdeskSearchJspBean
| Bug |
Category |
Details |
Line |
Priority |
| Dead store to plugin in fr.paris.lutece.plugins.helpdesk.web.HelpdeskSearchJspBean.getCSVListFromRequest(HttpServletRequest) |
STYLE |
DLS_DEAD_LOCAL_STORE |
285 |
Medium |
| Dead store to nPageIndex in fr.paris.lutece.plugins.helpdesk.web.HelpdeskSearchJspBean.getSearch(HttpServletRequest) |
STYLE |
DLS_DEAD_LOCAL_STORE |
159 |
Medium |
| Found reliance on default encoding in fr.paris.lutece.plugins.helpdesk.web.HelpdeskSearchJspBean.doExportQuestionCSV(HttpServletRequest, HttpServletResponse): String.getBytes() |
I18N |
DM_DEFAULT_ENCODING |
253 |
High |
| Class fr.paris.lutece.plugins.helpdesk.web.HelpdeskSearchJspBean defines non-transient non-serializable instance field _listResults |
BAD_PRACTICE |
SE_BAD_FIELD |
Not available |
Medium |
