Lutece identitymediation plugin – Checkstyle Results

Checkstyle Results

The following document contains the results of Checkstyle 8.19 with build-config/lutece_checks.xml ruleset.

Summary

Files	Info	Warnings	Errors
5	0	2	225

Files

File	W	E
fr/paris/lutece/plugins/identitymediation/buisness/MediationIdentity.java	0	14
fr/paris/lutece/plugins/identitymediation/cache/ServiceContractCache.java	0	9
fr/paris/lutece/plugins/identitymediation/web/IdentityDuplicateJspBean.java	2	202

Rules

Category	Rule	Violations	Severity
blocks	LeftCurly option: `"nl"`	21	Error
	NeedBraces	1	Error
	RightCurly option: `"alone"`	4	Error
coding	ArrayTrailingComma	1	Error
	DeclarationOrder	19	Error
	ExplicitInitialization	1	Error
	HiddenField	3	Error
	ReturnCount max: `"5"`	2	Warning
design	VisibilityModifier	5	Error
header	Header fileExtensions: `"java"` headerFile: `"/opt/datas/jenkins/home/jobs/admin-github-build/workspace/target/checkstyle-header.txt"`	3	Error
imports	AvoidStarImport	4	Error
javadoc	JavadocMethod	48	Error
	JavadocType	2	Error
naming	MemberName format: `"^_[a-z](_?[a-zA-Z0-9])*$"`	8	Error
whitespace	ParenPad option: `"space"`	105	Error

Details

fr/paris/lutece/plugins/identitymediation/buisness/MediationIdentity.java

Severity	Category	Rule	Message	Line
Error	header	Header	Line does not match expected header line of ' * Copyright (c) 2002-2020, City of Paris'.	2
Error	javadoc	JavadocType	Missing a Javadoc comment.	41
Error	naming	MemberName	Name 'suspiciousIdentity' must match pattern '^_[a-z](_?[a-zA-Z0-9])*$'.	43
Error	naming	MemberName	Name 'bestIdentity' must match pattern '^_[a-z](_?[a-zA-Z0-9])*$'.	44
Error	naming	MemberName	Name 'duplicatesToMergeAttributes' must match pattern '^_[a-z](_?[a-zA-Z0-9])*$'.	45
Error	javadoc	JavadocMethod	Missing a Javadoc comment.	47
Error	javadoc	JavadocMethod	Missing a Javadoc comment.	52
Error	coding	HiddenField	'suspiciousIdentity' hides a field.	52
Error	javadoc	JavadocMethod	Missing a Javadoc comment.	57
Error	javadoc	JavadocMethod	Missing a Javadoc comment.	62
Error	coding	HiddenField	'bestIdentity' hides a field.	62
Error	javadoc	JavadocMethod	Missing a Javadoc comment.	67
Error	javadoc	JavadocMethod	Missing a Javadoc comment.	72
Error	coding	HiddenField	'duplicatesToMergeAttributes' hides a field.	72

fr/paris/lutece/plugins/identitymediation/cache/ServiceContractCache.java

Severity	Category	Rule	Message	Line
Error	header	Header	Line does not match expected header line of ' * Copyright (c) 2002-2020, City of Paris'.	2
Error	javadoc	JavadocType	Missing a Javadoc comment.	45
Error	javadoc	JavadocMethod	Missing a Javadoc comment.	51
Error	javadoc	JavadocMethod	Missing a Javadoc comment.	56
Error	javadoc	JavadocMethod	Missing a Javadoc comment.	66
Error	javadoc	JavadocMethod	Missing a Javadoc comment.	76
Error	javadoc	JavadocMethod	Missing a Javadoc comment.	87
Error	javadoc	JavadocMethod	Missing a Javadoc comment.	95
Error	blocks	LeftCurly	'{' at column 69 should be on a new line.	99

fr/paris/lutece/plugins/identitymediation/web/IdentityDuplicateJspBean.java

Severity	Category	Rule	Message	Line
Error	header	Header	Line does not match expected header line of ' * Copyright (c) 2002-2020, City of Paris'.	2
Error	imports	AvoidStarImport	Using the '.' form of import should be avoided - fr.paris.lutece.plugins.identitystore.v3.web.rs.dto.common..	38
Error	imports	AvoidStarImport	Using the '.' form of import should be avoided - fr.paris.lutece.plugins.identitystore.v3.web.rs.dto.crud..	41
Error	imports	AvoidStarImport	Using the '.' form of import should be avoided - fr.paris.lutece.plugins.identitystore.v3.web.rs.dto.history..	44
Error	imports	AvoidStarImport	Using the '.' form of import should be avoided - java.util..	69
Error	naming	MemberName	Name 'PARAMETERS_DUPLICATE_SEARCH' must match pattern '^_[a-z](_?[a-zA-Z0-9])*$'.	128
Error	design	VisibilityModifier	Variable 'PARAMETERS_DUPLICATE_SEARCH' must be private and have accessor methods.	128
Error	coding	ArrayTrailingComma	Array should contain trailing comma.	130
Error	naming	MemberName	Name 'PARAMETER_PAGE' must match pattern '^_[a-z](_?[a-zA-Z0-9])*$'.	131
Error	design	VisibilityModifier	Variable 'PARAMETER_PAGE' must be private and have accessor methods.	131
Error	naming	MemberName	Name 'PARAMETER_CUID_PINNED' must match pattern '^_[a-z](_?[a-zA-Z0-9])*$'.	132
Error	design	VisibilityModifier	Variable 'PARAMETER_CUID_PINNED' must be private and have accessor methods.	132
Error	naming	MemberName	Name 'PARAMETER_CUID_TO_EXCLUDE' must match pattern '^_[a-z](_?[a-zA-Z0-9])*$'.	133
Error	design	VisibilityModifier	Variable 'PARAMETER_CUID_TO_EXCLUDE' must be private and have accessor methods.	133
Error	naming	MemberName	Name 'PARAMETER_CUID' must match pattern '^_[a-z](_?[a-zA-Z0-9])*$'.	134
Error	design	VisibilityModifier	Variable 'PARAMETER_CUID' must be private and have accessor methods.	134
Error	coding	DeclarationOrder	Static variable definition in wrong order.	137
Error	coding	DeclarationOrder	Static variable definition in wrong order.	138
Error	coding	DeclarationOrder	Static variable definition in wrong order.	139
Error	coding	DeclarationOrder	Static variable definition in wrong order.	140
Error	coding	DeclarationOrder	Static variable definition in wrong order.	141
Error	coding	DeclarationOrder	Static variable definition in wrong order.	142
Error	coding	DeclarationOrder	Static variable definition in wrong order.	143
Error	coding	DeclarationOrder	Static variable definition in wrong order.	144
Error	coding	DeclarationOrder	Static variable definition in wrong order.	145
Error	coding	DeclarationOrder	Static variable definition in wrong order.	146
Error	coding	DeclarationOrder	Static variable definition in wrong order.	147
Error	coding	DeclarationOrder	Static variable definition in wrong order.	148
Error	coding	DeclarationOrder	Static variable definition in wrong order.	149
Error	coding	DeclarationOrder	Static variable definition in wrong order.	150
Error	coding	DeclarationOrder	Static variable definition in wrong order.	151
Error	coding	DeclarationOrder	Static variable definition in wrong order.	152
Error	coding	DeclarationOrder	Static variable definition in wrong order.	155
Error	coding	DeclarationOrder	Static variable definition in wrong order.	156
Error	coding	DeclarationOrder	Static variable definition in wrong order.	157
Error	coding	ExplicitInitialization	Variable '_totalRecords' explicitly initialized to '0' (default value for its type).	179
Error	javadoc	JavadocMethod	Expected @return tag.	187
Error	javadoc	JavadocMethod	Expected @param tag for 'request'.	188
Error	blocks	LeftCurly	'{' at column 72 should be on a new line.	240
Error	blocks	LeftCurly	'{' at column 13 should be on a new line.	251
Error	blocks	RightCurly	'}' at column 9 should be alone on a line.	253
Error	whitespace	ParenPad	'(' is not followed by whitespace.	253
Error	whitespace	ParenPad	')' is not preceded with whitespace.	253
Error	blocks	LeftCurly	'{' at column 44 should be on a new line.	253
Error	blocks	LeftCurly	'{' at column 13 should be on a new line.	267
Error	blocks	RightCurly	'}' at column 9 should be alone on a line.	270
Error	whitespace	ParenPad	'(' is not followed by whitespace.	270
Error	whitespace	ParenPad	')' is not preceded with whitespace.	270
Error	blocks	LeftCurly	'{' at column 44 should be on a new line.	270
Warning	coding	ReturnCount	Return count is 7 (max allowed for non-void methods/lambdas is 5).	285
Error	javadoc	JavadocMethod	Expected @param tag for 'request'.	286
Warning	coding	ReturnCount	Return count is 8 (max allowed for non-void methods/lambdas is 5).	370
Error	javadoc	JavadocMethod	Expected @param tag for 'request'.	450
Error	javadoc	JavadocMethod	Expected @return tag.	469
Error	javadoc	JavadocMethod	Expected @param tag for 'request'.	470
Error	blocks	LeftCurly	'{' at column 78 should be on a new line.	486
Error	javadoc	JavadocMethod	Expected @return tag.	534
Error	javadoc	JavadocMethod	Expected @param tag for 'request'.	535
Error	javadoc	JavadocMethod	Expected @return tag.	586
Error	javadoc	JavadocMethod	Expected @param tag for 'request'.	587
Error	whitespace	ParenPad	'(' is not followed by whitespace.	623
Error	whitespace	ParenPad	')' is not preceded with whitespace.	623
Error	whitespace	ParenPad	'(' is not followed by whitespace.	627
Error	whitespace	ParenPad	')' is not preceded with whitespace.	627
Error	whitespace	ParenPad	'(' is not followed by whitespace.	631
Error	whitespace	ParenPad	'(' is not followed by whitespace.	632
Error	whitespace	ParenPad	'(' is not followed by whitespace.	632
Error	whitespace	ParenPad	')' is not preceded with whitespace.	632
Error	whitespace	ParenPad	'(' is not followed by whitespace.	633
Error	whitespace	ParenPad	'(' is not followed by whitespace.	634
Error	whitespace	ParenPad	'(' is not followed by whitespace.	635
Error	whitespace	ParenPad	'(' is not followed by whitespace.	636
Error	whitespace	ParenPad	'(' is not followed by whitespace.	636
Error	whitespace	ParenPad	'(' is not followed by whitespace.	637
Error	whitespace	ParenPad	')' is not preceded with whitespace.	637
Error	whitespace	ParenPad	')' is not preceded with whitespace.	639
Error	whitespace	ParenPad	'(' is not followed by whitespace.	643
Error	whitespace	ParenPad	')' is not preceded with whitespace.	643
Error	whitespace	ParenPad	'(' is not followed by whitespace.	647
Error	whitespace	ParenPad	')' is not preceded with whitespace.	647
Error	whitespace	ParenPad	'(' is not followed by whitespace.	651
Error	whitespace	ParenPad	'(' is not followed by whitespace.	651
Error	whitespace	ParenPad	'(' is not followed by whitespace.	651
Error	whitespace	ParenPad	')' is not preceded with whitespace.	651
Error	whitespace	ParenPad	')' is not preceded with whitespace.	651
Error	whitespace	ParenPad	')' is not preceded with whitespace.	651
Error	whitespace	ParenPad	'(' is not followed by whitespace.	652
Error	whitespace	ParenPad	')' is not preceded with whitespace.	652
Error	whitespace	ParenPad	'(' is not followed by whitespace.	658
Error	whitespace	ParenPad	'(' is not followed by whitespace.	658
Error	whitespace	ParenPad	'(' is not followed by whitespace.	658
Error	whitespace	ParenPad	')' is not preceded with whitespace.	658
Error	whitespace	ParenPad	')' is not preceded with whitespace.	658
Error	whitespace	ParenPad	')' is not preceded with whitespace.	658
Error	whitespace	ParenPad	'(' is not followed by whitespace.	659
Error	whitespace	ParenPad	'(' is not followed by whitespace.	659
Error	whitespace	ParenPad	')' is not preceded with whitespace.	659
Error	whitespace	ParenPad	'(' is not followed by whitespace.	659
Error	whitespace	ParenPad	')' is not preceded with whitespace.	659
Error	whitespace	ParenPad	')' is not preceded with whitespace.	659
Error	whitespace	ParenPad	'(' is not followed by whitespace.	663
Error	blocks	LeftCurly	'{' at column 59 should be on a new line.	663
Error	whitespace	ParenPad	'(' is not followed by whitespace.	664
Error	whitespace	ParenPad	')' is not preceded with whitespace.	664
Error	whitespace	ParenPad	')' is not preceded with whitespace.	674
Error	whitespace	ParenPad	'(' is not followed by whitespace.	675
Error	whitespace	ParenPad	')' is not preceded with whitespace.	675
Error	whitespace	ParenPad	'(' is not followed by whitespace.	678
Error	whitespace	ParenPad	')' is not preceded with whitespace.	678
Error	javadoc	JavadocMethod	Missing a Javadoc comment.	684
Error	whitespace	ParenPad	'(' is not followed by whitespace.	684
Error	whitespace	ParenPad	')' is not preceded with whitespace.	684
Error	whitespace	ParenPad	')' is not preceded with whitespace.	686
Error	whitespace	ParenPad	'(' is not followed by whitespace.	691
Error	whitespace	ParenPad	')' is not preceded with whitespace.	691
Error	whitespace	ParenPad	'(' is not followed by whitespace.	718
Error	whitespace	ParenPad	')' is not preceded with whitespace.	718
Error	whitespace	ParenPad	'(' is not followed by whitespace.	718
Error	whitespace	ParenPad	')' is not preceded with whitespace.	718
Error	whitespace	ParenPad	')' is not preceded with whitespace.	718
Error	javadoc	JavadocMethod	Expected @param tag for 'request'.	738
Error	blocks	LeftCurly	'{' at column 69 should be on a new line.	790
Error	javadoc	JavadocMethod	Expected @param tag for 'request'.	825
Error	javadoc	JavadocMethod	Expected @param tag for 'currentRuleCode'.	825
Error	javadoc	JavadocMethod	Expected @throws tag for 'IdentityStoreException'.	825
Error	whitespace	ParenPad	'(' is not followed by whitespace.	861
Error	whitespace	ParenPad	')' is not preceded with whitespace.	861
Error	javadoc	JavadocMethod	Expected @param tag for 'search'.	880
Error	javadoc	JavadocMethod	Expected @param tag for 'currentRuleCode'.	880
Error	whitespace	ParenPad	')' is not preceded with whitespace.	880
Error	whitespace	ParenPad	'(' is not followed by whitespace.	888
Error	whitespace	ParenPad	')' is not preceded with whitespace.	888
Error	blocks	LeftCurly	'{' at column 21 should be on a new line.	888
Error	whitespace	ParenPad	'(' is not followed by whitespace.	894
Error	whitespace	ParenPad	'(' is not followed by whitespace.	896
Error	whitespace	ParenPad	')' is not preceded with whitespace.	896
Error	javadoc	JavadocMethod	Expected @param tag for 'suspiciousIdentity'.	906
Error	javadoc	JavadocMethod	Expected @throws tag for 'IdentityStoreException'.	906
Error	javadoc	JavadocMethod	Expected @param tag for 'suspiciousIdentity'.	923
Error	javadoc	JavadocMethod	Expected @throws tag for 'IdentityStoreException'.	923
Error	javadoc	JavadocMethod	Expected @param tag for 'identityList'.	937
Error	javadoc	JavadocMethod	Expected @param tag for 'identity1'.	950
Error	javadoc	JavadocMethod	Expected @param tag for 'identity2'.	950
Error	blocks	LeftCurly	'{' at column 150 should be on a new line.	953
Error	javadoc	JavadocMethod	Expected @param tag for 'customerId'.	975
Error	javadoc	JavadocMethod	Expected @throws tag for 'IdentityStoreException'.	975
Error	javadoc	JavadocMethod	Expected @param tag for 'identity'.	1001
Error	javadoc	JavadocMethod	Expected @param tag for 'currentRuleCode'.	1001
Error	javadoc	JavadocMethod	Expected @param tag for 'showError'.	1001
Error	javadoc	JavadocMethod	Expected @throws tag for 'IdentityStoreException'.	1001
Error	blocks	LeftCurly	'{' at column 26 should be on a new line.	1009
Error	javadoc	JavadocMethod	Missing a Javadoc comment.	1016
Error	whitespace	ParenPad	'(' is not followed by whitespace.	1016
Error	whitespace	ParenPad	')' is not preceded with whitespace.	1016
Error	blocks	LeftCurly	'{' at column 138 should be on a new line.	1016
Error	whitespace	ParenPad	'(' is not followed by whitespace.	1017
Error	whitespace	ParenPad	')' is not preceded with whitespace.	1017
Error	blocks	LeftCurly	'{' at column 31 should be on a new line.	1017
Error	whitespace	ParenPad	'(' is not followed by whitespace.	1021
Error	whitespace	ParenPad	')' is not preceded with whitespace.	1021
Error	whitespace	ParenPad	'(' is not followed by whitespace.	1025
Error	whitespace	ParenPad	'(' is not followed by whitespace.	1025
Error	blocks	LeftCurly	'{' at column 59 should be on a new line.	1025
Error	blocks	LeftCurly	'{' at column 21 should be on a new line.	1026
Error	whitespace	ParenPad	'(' is not followed by whitespace.	1027
Error	whitespace	ParenPad	')' is not preceded with whitespace.	1027
Error	whitespace	ParenPad	'(' is not followed by whitespace.	1028
Error	whitespace	ParenPad	')' is not preceded with whitespace.	1028
Error	blocks	LeftCurly	'{' at column 57 should be on a new line.	1028
Error	whitespace	ParenPad	'(' is not followed by whitespace.	1029
Error	whitespace	ParenPad	')' is not preceded with whitespace.	1029
Error	blocks	RightCurly	'}' at column 17 should be alone on a line.	1031
Error	whitespace	ParenPad	'(' is not followed by whitespace.	1031
Error	whitespace	ParenPad	')' is not preceded with whitespace.	1031
Error	blocks	LeftCurly	'{' at column 52 should be on a new line.	1031
Error	whitespace	ParenPad	')' is not preceded with whitespace.	1034
Error	whitespace	ParenPad	')' is not preceded with whitespace.	1034
Error	whitespace	ParenPad	'(' is not followed by whitespace.	1035
Error	whitespace	ParenPad	')' is not preceded with whitespace.	1035
Error	whitespace	ParenPad	'(' is not followed by whitespace.	1037
Error	whitespace	ParenPad	'(' is not followed by whitespace.	1037
Error	whitespace	ParenPad	')' is not preceded with whitespace.	1037
Error	whitespace	ParenPad	')' is not preceded with whitespace.	1037
Error	blocks	LeftCurly	'{' at column 13 should be on a new line.	1038
Error	blocks	RightCurly	'}' at column 9 should be alone on a line.	1040
Error	whitespace	ParenPad	'(' is not followed by whitespace.	1040
Error	whitespace	ParenPad	')' is not preceded with whitespace.	1040
Error	blocks	LeftCurly	'{' at column 63 should be on a new line.	1040
Error	whitespace	ParenPad	'(' is not followed by whitespace.	1041
Error	whitespace	ParenPad	')' is not preceded with whitespace.	1041
Error	javadoc	JavadocMethod	Expected @param tag for 'request'.	1054
Error	blocks	LeftCurly	'{' at column 74 should be on a new line.	1073
Error	javadoc	JavadocMethod	Missing a Javadoc comment.	1090
Error	javadoc	JavadocMethod	Missing a Javadoc comment.	1101
Error	javadoc	JavadocMethod	Expected @param tag for 'currentRuleCode'.	1121
Error	blocks	NeedBraces	'if' construct must use '{}'s.	1140
Error	whitespace	ParenPad	'(' is not followed by whitespace.	1228
Error	whitespace	ParenPad	')' is not preceded with whitespace.	1228
Error	whitespace	ParenPad	'(' is not followed by whitespace.	1230
Error	whitespace	ParenPad	')' is not preceded with whitespace.	1230
Error	whitespace	ParenPad	')' is not preceded with whitespace.	1240
Error	whitespace	ParenPad	')' is not preceded with whitespace.	1241
Error	whitespace	ParenPad	')' is not preceded with whitespace.	1242
Error	javadoc	JavadocMethod	Missing a Javadoc comment.	1271