The following document contains the results of PMD 6.13.0.
| Rule | Violation | Line |
|---|---|---|
| FieldNamingConventions | The field name 'suspiciousIdentity' doesn't match '_[a-z][a-zA-Z0-9]*' | 43 |
| FieldNamingConventions | The field name 'bestIdentity' doesn't match '_[a-z][a-zA-Z0-9]*' | 44 |
| FieldNamingConventions | The field name 'duplicatesToMergeAttributes' doesn't match '_[a-z][a-zA-Z0-9]*' | 45 |
| Rule | Violation | Line |
|---|---|---|
| FieldNamingConventions | The final field name '_sortedAttributeKeyList' doesn't match '[a-z][a-zA-Z0-9]*' | 49 |
| Rule | Violation | Line |
|---|---|---|
| FieldNamingConventions | The final field name 'PARAMETERS_DUPLICATE_SEARCH' doesn't match '[a-z][a-zA-Z0-9]*' | 128 |
| FieldNamingConventions | The final field name 'PARAMETER_PAGE' doesn't match '[a-z][a-zA-Z0-9]*' | 131 |
| FieldNamingConventions | The final field name 'PARAMETER_CUID_PINNED' doesn't match '[a-z][a-zA-Z0-9]*' | 132 |
| FieldNamingConventions | The final field name 'PARAMETER_CUID_TO_EXCLUDE' doesn't match '[a-z][a-zA-Z0-9]*' | 133 |
| FieldNamingConventions | The final field name 'PARAMETER_CUID' doesn't match '[a-z][a-zA-Z0-9]*' | 134 |
| FieldNamingConventions | The constant name '_serviceQuality' doesn't match '[A-Z][A-Z_0-9]*' | 155 |
| FieldNamingConventions | The constant name '_serviceContractService' doesn't match '[A-Z][A-Z_0-9]*' | 156 |
| FieldNamingConventions | The constant name '_serviceIdentity' doesn't match '[A-Z][A-Z_0-9]*' | 157 |
| FieldNamingConventions | The final field name '_sortedAttributeKeyList' doesn't match '[a-z][a-zA-Z0-9]*' | 160 |
| FieldNamingConventions | The final field name '_attributeKeyToShowList' doesn't match '[a-z][a-zA-Z0-9]*' | 161 |
| FieldNamingConventions | The final field name '_rulePriorityMin' doesn't match '[a-z][a-zA-Z0-9]*' | 166 |
| FieldNamingConventions | The final field name '_duplicateRules' doesn't match '[a-z][a-zA-Z0-9]*' | 172 |
| FieldNamingConventions | The final field name '_mediationIdentities' doesn't match '[a-z][a-zA-Z0-9]*' | 173 |
| LocalVariableNamingConventions | The final local variable name '_suspiciousCuid' doesn't match '[a-z][a-zA-Z0-9]*' | 373 |
| Rule | Violation | Line |
|---|---|---|
| GuardLogStatement | Logger calls should be surrounded by log level guards. | 63 |
| GuardLogStatement | Logger calls should be surrounded by log level guards. | 73 |
| Rule | Violation | Line |
|---|---|---|
| CommentRequired | Header comments are required | 41–76 |
| DataClass | The class 'MediationIdentity' is suspected to be a Data Class (WOC=0.000%, NOPA=0, NOAM=6, WMC=6) | 41–76 |
| Rule | Violation | Line |
|---|---|---|
| CommentRequired | Header comments are required | 45–114 |
| CallSuperInConstructor | It is a good practice to call super() in a constructor | 51–54 |
| CommentRequired | Public method and constructor comments are required | 51–54 |
| CommentRequired | Public method and constructor comments are required | 56–64 |
| CommentRequired | Public method and constructor comments are required | 66–74 |
| CommentRequired | Public method and constructor comments are required | 76–85 |
| CommentRequired | Public method and constructor comments are required | 87–93 |
| ShortVariable | Avoid variables with short names like i1 | 102 |
| ShortVariable | Avoid variables with short names like i2 | 103 |
| Rule | Violation | Line |
|---|---|---|
| ExcessiveImports | A high number of imports can indicate a high degree of coupling within an object. | 34–1277 |
| TooManyFields | Too many fields | 79–1277 |
| MissingSerialVersionUID | Classes implementing Serializable should set a serialVersionUID | 79–1277 |
| ExcessiveClassLength | Avoid really long classes. | 79–1277 |
| GodClass | Possible God Class (WMC=96, ATFD=126, TCC=26.515%) | 79–1277 |
| CyclomaticComplexity | The class 'IdentityDuplicateJspBean' has a total cyclomatic complexity of 96 (highest 11). | 79–1277 |
| TooManyMethods | This class has too many methods, consider refactoring it. | 80–1277 |
| UnusedPrivateField | Avoid unused private fields such as 'MESSAGE_FETCH_DUPLICATE_RULES_NORESULT'. | 84 |
| UnusedPrivateField | Avoid unused private fields such as 'MESSAGE_FETCH_DUPLICATE_HOLDERS_ERROR'. | 85 |
| UnusedPrivateField | Avoid unused private fields such as 'MESSAGE_FETCH_DUPLICATE_HOLDERS_NORESULT'. | 86 |
| UnusedPrivateField | Avoid unused private fields such as 'MESSAGE_FETCH_DUPLICATES_NORESULT'. | 93 |
| DefaultPackage | Use explicit scoping instead of the default package private level | 128–130 |
| CommentDefaultAccessModifier | To avoid mistakes add a comment at the beginning of the PARAMETERS_DUPLICATE_SEARCH field if you want a default access modifier | 128–130 |
| FinalFieldCouldBeStatic | This final field could be made static | 131 |
| DefaultPackage | Use explicit scoping instead of the default package private level | 131 |
| CommentDefaultAccessModifier | To avoid mistakes add a comment at the beginning of the PARAMETER_PAGE field if you want a default access modifier | 131 |
| CommentDefaultAccessModifier | To avoid mistakes add a comment at the beginning of the PARAMETER_CUID_PINNED field if you want a default access modifier | 132 |
| FinalFieldCouldBeStatic | This final field could be made static | 132 |
| DefaultPackage | Use explicit scoping instead of the default package private level | 132 |
| DefaultPackage | Use explicit scoping instead of the default package private level | 133 |
| CommentDefaultAccessModifier | To avoid mistakes add a comment at the beginning of the PARAMETER_CUID_TO_EXCLUDE field if you want a default access modifier | 133 |
| FinalFieldCouldBeStatic | This final field could be made static | 133 |
| FinalFieldCouldBeStatic | This final field could be made static | 134 |
| CommentDefaultAccessModifier | To avoid mistakes add a comment at the beginning of the PARAMETER_CUID field if you want a default access modifier | 134 |
| DefaultPackage | Use explicit scoping instead of the default package private level | 134 |
| RedundantFieldInitializer | Avoid using redundant field initializer for '_totalRecords' | 179 |
| UnnecessaryAnnotationValueElement | Avoid the use of value in annotations when its the only element | 187 |
| NullAssignment | Assigning an Object to null is a code smell. Consider refactoring. | 190 |
| NullAssignment | Assigning an Object to null is a code smell. Consider refactoring. | 210 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 213 |
| UnnecessaryAnnotationValueElement | Avoid the use of value in annotations when its the only element | 239 |
| UnnecessaryAnnotationValueElement | Avoid the use of value in annotations when its the only element | 285 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 288 |
| AvoidLiteralsInIfCondition | Avoid using Literals in Conditional Statements | 343 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 346 |
| UnnecessaryAnnotationValueElement | Avoid the use of value in annotations when its the only element | 370 |
| CyclomaticComplexity | The method 'getResolveDuplicates(HttpServletRequest)' has a cyclomatic complexity of 13. | 371–441 |
| NPathComplexity | The method 'getResolveDuplicates(HttpServletRequest)' has an NPath complexity of 540 | 371–441 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 373 |
| NullAssignment | Assigning an Object to null is a code smell. Consider refactoring. | 475 |
| NullAssignment | Assigning an Object to null is a code smell. Consider refactoring. | 476 |
| NullAssignment | Assigning an Object to null is a code smell. Consider refactoring. | 497 |
| NullAssignment | Assigning an Object to null is a code smell. Consider refactoring. | 498 |
| NullAssignment | Assigning an Object to null is a code smell. Consider refactoring. | 506 |
| NullAssignment | Assigning an Object to null is a code smell. Consider refactoring. | 507 |
| NullAssignment | Assigning an Object to null is a code smell. Consider refactoring. | 521 |
| NullAssignment | Assigning an Object to null is a code smell. Consider refactoring. | 522 |
| NullAssignment | Assigning an Object to null is a code smell. Consider refactoring. | 599 |
| NullAssignment | Assigning an Object to null is a code smell. Consider refactoring. | 600 |
| NPathComplexity | The method 'init(HttpServletRequest, boolean)' has an NPath complexity of 512 | 612–682 |
| CyclomaticComplexity | The method 'init(HttpServletRequest, boolean)' has a cyclomatic complexity of 11. | 612–682 |
| NullAssignment | Assigning an Object to null is a code smell. Consider refactoring. | 623 |
| NullAssignment | Assigning an Object to null is a code smell. Consider refactoring. | 632 |
| NullAssignment | Assigning an Object to null is a code smell. Consider refactoring. | 634 |
| NullAssignment | Assigning an Object to null is a code smell. Consider refactoring. | 636 |
| LinguisticNaming | Linguistics Antipattern - The getter 'getSuspiciousSummary' should not return void linguistically | 684–699 |
| AvoidCatchingGenericException | Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 725 |
| AvoidCatchingGenericException | Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 772 |
| ShortVariable | Avoid variables with short names like i1 | 793 |
| ShortVariable | Avoid variables with short names like i2 | 794 |
| CompareObjectsWithEquals | Use equals() to compare object references. | 965 |
| AvoidLiteralsInIfCondition | Avoid using Literals in Conditional Statements | 982 |
| AvoidDuplicateLiterals | The String literal "override-" appears 6 times in this file; the first occurrence is on line 1,066 | 1066 |
| ControlStatementBraces | This statement should have braces | 1141 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 1176 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 1184 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| CommentRequired | Header comments are required | 3 | 41–76 |
| DataClass | The class 'MediationIdentity' is suspected to be a Data Class (WOC=0.000%, NOPA=0, NOAM=6, WMC=6) | 3 | 41–76 |
| FieldNamingConventions | The field name 'suspiciousIdentity' doesn't match '_[a-z][a-zA-Z0-9]*' | 1 | 43 |
| FieldNamingConventions | The field name 'bestIdentity' doesn't match '_[a-z][a-zA-Z0-9]*' | 1 | 44 |
| FieldNamingConventions | The field name 'duplicatesToMergeAttributes' doesn't match '_[a-z][a-zA-Z0-9]*' | 1 | 45 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| CommentRequired | Header comments are required | 3 | 45–114 |
| FieldNamingConventions | The final field name '_sortedAttributeKeyList' doesn't match '[a-z][a-zA-Z0-9]*' | 1 | 49 |
| CallSuperInConstructor | It is a good practice to call super() in a constructor | 3 | 51–54 |
| CommentRequired | Public method and constructor comments are required | 3 | 51–54 |
| CommentRequired | Public method and constructor comments are required | 3 | 56–64 |
| GuardLogStatement | Logger calls should be surrounded by log level guards. | 2 | 63 |
| CommentRequired | Public method and constructor comments are required | 3 | 66–74 |
| GuardLogStatement | Logger calls should be surrounded by log level guards. | 2 | 73 |
| CommentRequired | Public method and constructor comments are required | 3 | 76–85 |
| CommentRequired | Public method and constructor comments are required | 3 | 87–93 |
| ShortVariable | Avoid variables with short names like i1 | 3 | 102 |
| ShortVariable | Avoid variables with short names like i2 | 3 | 103 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| ExcessiveImports | A high number of imports can indicate a high degree of coupling within an object. | 3 | 34–1277 |
| TooManyFields | Too many fields | 3 | 79–1277 |
| MissingSerialVersionUID | Classes implementing Serializable should set a serialVersionUID | 3 | 79–1277 |
| ExcessiveClassLength | Avoid really long classes. | 3 | 79–1277 |
| GodClass | Possible God Class (WMC=96, ATFD=126, TCC=26.515%) | 3 | 79–1277 |
| CyclomaticComplexity | The class 'IdentityDuplicateJspBean' has a total cyclomatic complexity of 96 (highest 11). | 3 | 79–1277 |
| TooManyMethods | This class has too many methods, consider refactoring it. | 3 | 80–1277 |
| UnusedPrivateField | Avoid unused private fields such as 'MESSAGE_FETCH_DUPLICATE_RULES_NORESULT'. | 3 | 84 |
| UnusedPrivateField | Avoid unused private fields such as 'MESSAGE_FETCH_DUPLICATE_HOLDERS_ERROR'. | 3 | 85 |
| UnusedPrivateField | Avoid unused private fields such as 'MESSAGE_FETCH_DUPLICATE_HOLDERS_NORESULT'. | 3 | 86 |
| UnusedPrivateField | Avoid unused private fields such as 'MESSAGE_FETCH_DUPLICATES_NORESULT'. | 3 | 93 |
| DefaultPackage | Use explicit scoping instead of the default package private level | 3 | 128–130 |
| CommentDefaultAccessModifier | To avoid mistakes add a comment at the beginning of the PARAMETERS_DUPLICATE_SEARCH field if you want a default access modifier | 3 | 128–130 |
| FieldNamingConventions | The final field name 'PARAMETERS_DUPLICATE_SEARCH' doesn't match '[a-z][a-zA-Z0-9]*' | 1 | 128 |
| FieldNamingConventions | The final field name 'PARAMETER_PAGE' doesn't match '[a-z][a-zA-Z0-9]*' | 1 | 131 |
| FinalFieldCouldBeStatic | This final field could be made static | 3 | 131 |
| DefaultPackage | Use explicit scoping instead of the default package private level | 3 | 131 |
| CommentDefaultAccessModifier | To avoid mistakes add a comment at the beginning of the PARAMETER_PAGE field if you want a default access modifier | 3 | 131 |
| CommentDefaultAccessModifier | To avoid mistakes add a comment at the beginning of the PARAMETER_CUID_PINNED field if you want a default access modifier | 3 | 132 |
| FinalFieldCouldBeStatic | This final field could be made static | 3 | 132 |
| FieldNamingConventions | The final field name 'PARAMETER_CUID_PINNED' doesn't match '[a-z][a-zA-Z0-9]*' | 1 | 132 |
| DefaultPackage | Use explicit scoping instead of the default package private level | 3 | 132 |
| DefaultPackage | Use explicit scoping instead of the default package private level | 3 | 133 |
| CommentDefaultAccessModifier | To avoid mistakes add a comment at the beginning of the PARAMETER_CUID_TO_EXCLUDE field if you want a default access modifier | 3 | 133 |
| FieldNamingConventions | The final field name 'PARAMETER_CUID_TO_EXCLUDE' doesn't match '[a-z][a-zA-Z0-9]*' | 1 | 133 |
| FinalFieldCouldBeStatic | This final field could be made static | 3 | 133 |
| FinalFieldCouldBeStatic | This final field could be made static | 3 | 134 |
| FieldNamingConventions | The final field name 'PARAMETER_CUID' doesn't match '[a-z][a-zA-Z0-9]*' | 1 | 134 |
| CommentDefaultAccessModifier | To avoid mistakes add a comment at the beginning of the PARAMETER_CUID field if you want a default access modifier | 3 | 134 |
| DefaultPackage | Use explicit scoping instead of the default package private level | 3 | 134 |
| FieldNamingConventions | The constant name '_serviceQuality' doesn't match '[A-Z][A-Z_0-9]*' | 1 | 155 |
| FieldNamingConventions | The constant name '_serviceContractService' doesn't match '[A-Z][A-Z_0-9]*' | 1 | 156 |
| FieldNamingConventions | The constant name '_serviceIdentity' doesn't match '[A-Z][A-Z_0-9]*' | 1 | 157 |
| FieldNamingConventions | The final field name '_sortedAttributeKeyList' doesn't match '[a-z][a-zA-Z0-9]*' | 1 | 160 |
| FieldNamingConventions | The final field name '_attributeKeyToShowList' doesn't match '[a-z][a-zA-Z0-9]*' | 1 | 161 |
| FieldNamingConventions | The final field name '_rulePriorityMin' doesn't match '[a-z][a-zA-Z0-9]*' | 1 | 166 |
| FieldNamingConventions | The final field name '_duplicateRules' doesn't match '[a-z][a-zA-Z0-9]*' | 1 | 172 |
| FieldNamingConventions | The final field name '_mediationIdentities' doesn't match '[a-z][a-zA-Z0-9]*' | 1 | 173 |
| RedundantFieldInitializer | Avoid using redundant field initializer for '_totalRecords' | 3 | 179 |
| UnnecessaryAnnotationValueElement | Avoid the use of value in annotations when its the only element | 3 | 187 |
| NullAssignment | Assigning an Object to null is a code smell. Consider refactoring. | 3 | 190 |
| NullAssignment | Assigning an Object to null is a code smell. Consider refactoring. | 3 | 210 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 3 | 213 |
| UnnecessaryAnnotationValueElement | Avoid the use of value in annotations when its the only element | 3 | 239 |
| UnnecessaryAnnotationValueElement | Avoid the use of value in annotations when its the only element | 3 | 285 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 288 |
| AvoidLiteralsInIfCondition | Avoid using Literals in Conditional Statements | 3 | 343 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 3 | 346 |
| UnnecessaryAnnotationValueElement | Avoid the use of value in annotations when its the only element | 3 | 370 |
| CyclomaticComplexity | The method 'getResolveDuplicates(HttpServletRequest)' has a cyclomatic complexity of 13. | 3 | 371–441 |
| NPathComplexity | The method 'getResolveDuplicates(HttpServletRequest)' has an NPath complexity of 540 | 3 | 371–441 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 373 |
| LocalVariableNamingConventions | The final local variable name '_suspiciousCuid' doesn't match '[a-z][a-zA-Z0-9]*' | 1 | 373 |
| NullAssignment | Assigning an Object to null is a code smell. Consider refactoring. | 3 | 475 |
| NullAssignment | Assigning an Object to null is a code smell. Consider refactoring. | 3 | 476 |
| NullAssignment | Assigning an Object to null is a code smell. Consider refactoring. | 3 | 497 |
| NullAssignment | Assigning an Object to null is a code smell. Consider refactoring. | 3 | 498 |
| NullAssignment | Assigning an Object to null is a code smell. Consider refactoring. | 3 | 506 |
| NullAssignment | Assigning an Object to null is a code smell. Consider refactoring. | 3 | 507 |
| NullAssignment | Assigning an Object to null is a code smell. Consider refactoring. | 3 | 521 |
| NullAssignment | Assigning an Object to null is a code smell. Consider refactoring. | 3 | 522 |
| NullAssignment | Assigning an Object to null is a code smell. Consider refactoring. | 3 | 599 |
| NullAssignment | Assigning an Object to null is a code smell. Consider refactoring. | 3 | 600 |
| NPathComplexity | The method 'init(HttpServletRequest, boolean)' has an NPath complexity of 512 | 3 | 612–682 |
| CyclomaticComplexity | The method 'init(HttpServletRequest, boolean)' has a cyclomatic complexity of 11. | 3 | 612–682 |
| NullAssignment | Assigning an Object to null is a code smell. Consider refactoring. | 3 | 623 |
| NullAssignment | Assigning an Object to null is a code smell. Consider refactoring. | 3 | 632 |
| NullAssignment | Assigning an Object to null is a code smell. Consider refactoring. | 3 | 634 |
| NullAssignment | Assigning an Object to null is a code smell. Consider refactoring. | 3 | 636 |
| LinguisticNaming | Linguistics Antipattern - The getter 'getSuspiciousSummary' should not return void linguistically | 3 | 684–699 |
| AvoidCatchingGenericException | Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 3 | 725 |
| AvoidCatchingGenericException | Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 3 | 772 |
| ShortVariable | Avoid variables with short names like i1 | 3 | 793 |
| ShortVariable | Avoid variables with short names like i2 | 3 | 794 |
| CompareObjectsWithEquals | Use equals() to compare object references. | 3 | 965 |
| AvoidLiteralsInIfCondition | Avoid using Literals in Conditional Statements | 3 | 982 |
| AvoidDuplicateLiterals | The String literal "override-" appears 6 times in this file; the first occurrence is on line 1,066 | 3 | 1066 |
| ControlStatementBraces | This statement should have braces | 3 | 1141 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 3 | 1176 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 3 | 1184 |
