The following document contains the results of PMD 6.13.0.
| Rule | Violation | Line |
|---|---|---|
| FieldNamingConventions | The field name 'suspiciousIdentity' doesn't match '_[a-z][a-zA-Z0-9]*' | 43 |
| FieldNamingConventions | The field name 'bestIdentity' doesn't match '_[a-z][a-zA-Z0-9]*' | 44 |
| FieldNamingConventions | The field name 'duplicatesToMergeAttributes' doesn't match '_[a-z][a-zA-Z0-9]*' | 45 |
| Rule | Violation | Line |
|---|---|---|
| FieldNamingConventions | The final field name '_sortedAttributeKeyList' doesn't match '[a-z][a-zA-Z0-9]*' | 49 |
| Rule | Violation | Line |
|---|---|---|
| FieldNamingConventions | The final field name 'PARAMETERS_DUPLICATE_SEARCH' doesn't match '[a-z][a-zA-Z0-9]*' | 123 |
| FieldNamingConventions | The final field name 'PARAMETER_PAGE' doesn't match '[a-z][a-zA-Z0-9]*' | 126 |
| FieldNamingConventions | The final field name 'PARAMETER_CUID_PINNED' doesn't match '[a-z][a-zA-Z0-9]*' | 127 |
| FieldNamingConventions | The final field name 'PARAMETER_CUID_TO_EXCLUDE' doesn't match '[a-z][a-zA-Z0-9]*' | 128 |
| FieldNamingConventions | The constant name '_serviceQuality' doesn't match '[A-Z][A-Z_0-9]*' | 147 |
| FieldNamingConventions | The constant name '_serviceContractService' doesn't match '[A-Z][A-Z_0-9]*' | 148 |
| FieldNamingConventions | The constant name '_serviceIdentity' doesn't match '[A-Z][A-Z_0-9]*' | 149 |
| FieldNamingConventions | The final field name '_sortedAttributeKeyList' doesn't match '[a-z][a-zA-Z0-9]*' | 152 |
| FieldNamingConventions | The final field name '_attributeKeyToShowList' doesn't match '[a-z][a-zA-Z0-9]*' | 153 |
| FieldNamingConventions | The final field name '_rulePriorityMin' doesn't match '[a-z][a-zA-Z0-9]*' | 158 |
| FieldNamingConventions | The final field name '_duplicateRules' doesn't match '[a-z][a-zA-Z0-9]*' | 164 |
| FieldNamingConventions | The final field name '_mediationIdentities' doesn't match '[a-z][a-zA-Z0-9]*' | 165 |
| LocalVariableNamingConventions | The final local variable name '_suspiciousCuid' doesn't match '[a-z][a-zA-Z0-9]*' | 320 |
| Rule | Violation | Line |
|---|---|---|
| GuardLogStatement | Logger calls should be surrounded by log level guards. | 63 |
| GuardLogStatement | Logger calls should be surrounded by log level guards. | 73 |
| Rule | Violation | Line |
|---|---|---|
| CommentRequired | Header comments are required | 41–76 |
| DataClass | The class 'MediationIdentity' is suspected to be a Data Class (WOC=0.000%, NOPA=0, NOAM=6, WMC=6) | 41–76 |
| Rule | Violation | Line |
|---|---|---|
| CommentRequired | Header comments are required | 45–114 |
| CommentRequired | Public method and constructor comments are required | 51–54 |
| CallSuperInConstructor | It is a good practice to call super() in a constructor | 51–54 |
| CommentRequired | Public method and constructor comments are required | 56–64 |
| CommentRequired | Public method and constructor comments are required | 66–74 |
| CommentRequired | Public method and constructor comments are required | 76–85 |
| CommentRequired | Public method and constructor comments are required | 87–93 |
| ShortVariable | Avoid variables with short names like i1 | 102 |
| ShortVariable | Avoid variables with short names like i2 | 103 |
| Rule | Violation | Line |
|---|---|---|
| ExcessiveImports | A high number of imports can indicate a high degree of coupling within an object. | 34–1189 |
| CyclomaticComplexity | The class 'IdentityDuplicateJspBean' has a total cyclomatic complexity of 91 (highest 11). | 76–1189 |
| GodClass | Possible God Class (WMC=91, ATFD=121, TCC=28.387%) | 76–1189 |
| MissingSerialVersionUID | Classes implementing Serializable should set a serialVersionUID | 76–1189 |
| ExcessiveClassLength | Avoid really long classes. | 76–1189 |
| TooManyFields | Too many fields | 76–1189 |
| TooManyMethods | This class has too many methods, consider refactoring it. | 77–1189 |
| UnusedPrivateField | Avoid unused private fields such as 'MESSAGE_FETCH_DUPLICATE_RULES_NORESULT'. | 81 |
| UnusedPrivateField | Avoid unused private fields such as 'MESSAGE_FETCH_DUPLICATE_HOLDERS_ERROR'. | 82 |
| UnusedPrivateField | Avoid unused private fields such as 'MESSAGE_FETCH_DUPLICATE_HOLDERS_NORESULT'. | 83 |
| UnusedPrivateField | Avoid unused private fields such as 'MESSAGE_FETCH_DUPLICATES_NORESULT'. | 90 |
| DefaultPackage | Use explicit scoping instead of the default package private level | 123–125 |
| CommentDefaultAccessModifier | To avoid mistakes add a comment at the beginning of the PARAMETERS_DUPLICATE_SEARCH field if you want a default access modifier | 123–125 |
| DefaultPackage | Use explicit scoping instead of the default package private level | 126 |
| FinalFieldCouldBeStatic | This final field could be made static | 126 |
| CommentDefaultAccessModifier | To avoid mistakes add a comment at the beginning of the PARAMETER_PAGE field if you want a default access modifier | 126 |
| CommentDefaultAccessModifier | To avoid mistakes add a comment at the beginning of the PARAMETER_CUID_PINNED field if you want a default access modifier | 127 |
| DefaultPackage | Use explicit scoping instead of the default package private level | 127 |
| FinalFieldCouldBeStatic | This final field could be made static | 127 |
| FinalFieldCouldBeStatic | This final field could be made static | 128 |
| CommentDefaultAccessModifier | To avoid mistakes add a comment at the beginning of the PARAMETER_CUID_TO_EXCLUDE field if you want a default access modifier | 128 |
| DefaultPackage | Use explicit scoping instead of the default package private level | 128 |
| RedundantFieldInitializer | Avoid using redundant field initializer for '_totalRecords' | 171 |
| UnnecessaryAnnotationValueElement | Avoid the use of value in annotations when its the only element | 179 |
| NullAssignment | Assigning an Object to null is a code smell. Consider refactoring. | 182 |
| NullAssignment | Assigning an Object to null is a code smell. Consider refactoring. | 202 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 205 |
| UnnecessaryAnnotationValueElement | Avoid the use of value in annotations when its the only element | 232 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 235 |
| AvoidLiteralsInIfCondition | Avoid using Literals in Conditional Statements | 290 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 293 |
| UnnecessaryAnnotationValueElement | Avoid the use of value in annotations when its the only element | 317 |
| CyclomaticComplexity | The method 'getResolveDuplicates(HttpServletRequest)' has a cyclomatic complexity of 13. | 318–388 |
| NPathComplexity | The method 'getResolveDuplicates(HttpServletRequest)' has an NPath complexity of 540 | 318–388 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 320 |
| NullAssignment | Assigning an Object to null is a code smell. Consider refactoring. | 422 |
| NullAssignment | Assigning an Object to null is a code smell. Consider refactoring. | 423 |
| NullAssignment | Assigning an Object to null is a code smell. Consider refactoring. | 444 |
| NullAssignment | Assigning an Object to null is a code smell. Consider refactoring. | 445 |
| NullAssignment | Assigning an Object to null is a code smell. Consider refactoring. | 453 |
| NullAssignment | Assigning an Object to null is a code smell. Consider refactoring. | 454 |
| NullAssignment | Assigning an Object to null is a code smell. Consider refactoring. | 468 |
| NullAssignment | Assigning an Object to null is a code smell. Consider refactoring. | 469 |
| NullAssignment | Assigning an Object to null is a code smell. Consider refactoring. | 546 |
| NullAssignment | Assigning an Object to null is a code smell. Consider refactoring. | 547 |
| NPathComplexity | The method 'init(HttpServletRequest, boolean)' has an NPath complexity of 512 | 559–629 |
| CyclomaticComplexity | The method 'init(HttpServletRequest, boolean)' has a cyclomatic complexity of 11. | 559–629 |
| NullAssignment | Assigning an Object to null is a code smell. Consider refactoring. | 570 |
| NullAssignment | Assigning an Object to null is a code smell. Consider refactoring. | 579 |
| NullAssignment | Assigning an Object to null is a code smell. Consider refactoring. | 581 |
| NullAssignment | Assigning an Object to null is a code smell. Consider refactoring. | 583 |
| LinguisticNaming | Linguistics Antipattern - The getter 'getSuspiciousSummary' should not return void linguistically | 631–646 |
| AvoidCatchingGenericException | Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 672 |
| AvoidCatchingGenericException | Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 719 |
| ShortVariable | Avoid variables with short names like i1 | 740 |
| ShortVariable | Avoid variables with short names like i2 | 741 |
| CompareObjectsWithEquals | Use equals() to compare object references. | 912 |
| AvoidLiteralsInIfCondition | Avoid using Literals in Conditional Statements | 929 |
| AvoidDuplicateLiterals | The String literal "override-" appears 6 times in this file; the first occurrence is on line 978 | 978 |
| ControlStatementBraces | This statement should have braces | 1053 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 1088 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 1096 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| CommentRequired | Header comments are required | 3 | 41–76 |
| DataClass | The class 'MediationIdentity' is suspected to be a Data Class (WOC=0.000%, NOPA=0, NOAM=6, WMC=6) | 3 | 41–76 |
| FieldNamingConventions | The field name 'suspiciousIdentity' doesn't match '_[a-z][a-zA-Z0-9]*' | 1 | 43 |
| FieldNamingConventions | The field name 'bestIdentity' doesn't match '_[a-z][a-zA-Z0-9]*' | 1 | 44 |
| FieldNamingConventions | The field name 'duplicatesToMergeAttributes' doesn't match '_[a-z][a-zA-Z0-9]*' | 1 | 45 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| CommentRequired | Header comments are required | 3 | 45–114 |
| FieldNamingConventions | The final field name '_sortedAttributeKeyList' doesn't match '[a-z][a-zA-Z0-9]*' | 1 | 49 |
| CommentRequired | Public method and constructor comments are required | 3 | 51–54 |
| CallSuperInConstructor | It is a good practice to call super() in a constructor | 3 | 51–54 |
| CommentRequired | Public method and constructor comments are required | 3 | 56–64 |
| GuardLogStatement | Logger calls should be surrounded by log level guards. | 2 | 63 |
| CommentRequired | Public method and constructor comments are required | 3 | 66–74 |
| GuardLogStatement | Logger calls should be surrounded by log level guards. | 2 | 73 |
| CommentRequired | Public method and constructor comments are required | 3 | 76–85 |
| CommentRequired | Public method and constructor comments are required | 3 | 87–93 |
| ShortVariable | Avoid variables with short names like i1 | 3 | 102 |
| ShortVariable | Avoid variables with short names like i2 | 3 | 103 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| ExcessiveImports | A high number of imports can indicate a high degree of coupling within an object. | 3 | 34–1189 |
| CyclomaticComplexity | The class 'IdentityDuplicateJspBean' has a total cyclomatic complexity of 91 (highest 11). | 3 | 76–1189 |
| GodClass | Possible God Class (WMC=91, ATFD=121, TCC=28.387%) | 3 | 76–1189 |
| MissingSerialVersionUID | Classes implementing Serializable should set a serialVersionUID | 3 | 76–1189 |
| ExcessiveClassLength | Avoid really long classes. | 3 | 76–1189 |
| TooManyFields | Too many fields | 3 | 76–1189 |
| TooManyMethods | This class has too many methods, consider refactoring it. | 3 | 77–1189 |
| UnusedPrivateField | Avoid unused private fields such as 'MESSAGE_FETCH_DUPLICATE_RULES_NORESULT'. | 3 | 81 |
| UnusedPrivateField | Avoid unused private fields such as 'MESSAGE_FETCH_DUPLICATE_HOLDERS_ERROR'. | 3 | 82 |
| UnusedPrivateField | Avoid unused private fields such as 'MESSAGE_FETCH_DUPLICATE_HOLDERS_NORESULT'. | 3 | 83 |
| UnusedPrivateField | Avoid unused private fields such as 'MESSAGE_FETCH_DUPLICATES_NORESULT'. | 3 | 90 |
| DefaultPackage | Use explicit scoping instead of the default package private level | 3 | 123–125 |
| CommentDefaultAccessModifier | To avoid mistakes add a comment at the beginning of the PARAMETERS_DUPLICATE_SEARCH field if you want a default access modifier | 3 | 123–125 |
| FieldNamingConventions | The final field name 'PARAMETERS_DUPLICATE_SEARCH' doesn't match '[a-z][a-zA-Z0-9]*' | 1 | 123 |
| DefaultPackage | Use explicit scoping instead of the default package private level | 3 | 126 |
| FieldNamingConventions | The final field name 'PARAMETER_PAGE' doesn't match '[a-z][a-zA-Z0-9]*' | 1 | 126 |
| FinalFieldCouldBeStatic | This final field could be made static | 3 | 126 |
| CommentDefaultAccessModifier | To avoid mistakes add a comment at the beginning of the PARAMETER_PAGE field if you want a default access modifier | 3 | 126 |
| CommentDefaultAccessModifier | To avoid mistakes add a comment at the beginning of the PARAMETER_CUID_PINNED field if you want a default access modifier | 3 | 127 |
| DefaultPackage | Use explicit scoping instead of the default package private level | 3 | 127 |
| FieldNamingConventions | The final field name 'PARAMETER_CUID_PINNED' doesn't match '[a-z][a-zA-Z0-9]*' | 1 | 127 |
| FinalFieldCouldBeStatic | This final field could be made static | 3 | 127 |
| FieldNamingConventions | The final field name 'PARAMETER_CUID_TO_EXCLUDE' doesn't match '[a-z][a-zA-Z0-9]*' | 1 | 128 |
| FinalFieldCouldBeStatic | This final field could be made static | 3 | 128 |
| CommentDefaultAccessModifier | To avoid mistakes add a comment at the beginning of the PARAMETER_CUID_TO_EXCLUDE field if you want a default access modifier | 3 | 128 |
| DefaultPackage | Use explicit scoping instead of the default package private level | 3 | 128 |
| FieldNamingConventions | The constant name '_serviceQuality' doesn't match '[A-Z][A-Z_0-9]*' | 1 | 147 |
| FieldNamingConventions | The constant name '_serviceContractService' doesn't match '[A-Z][A-Z_0-9]*' | 1 | 148 |
| FieldNamingConventions | The constant name '_serviceIdentity' doesn't match '[A-Z][A-Z_0-9]*' | 1 | 149 |
| FieldNamingConventions | The final field name '_sortedAttributeKeyList' doesn't match '[a-z][a-zA-Z0-9]*' | 1 | 152 |
| FieldNamingConventions | The final field name '_attributeKeyToShowList' doesn't match '[a-z][a-zA-Z0-9]*' | 1 | 153 |
| FieldNamingConventions | The final field name '_rulePriorityMin' doesn't match '[a-z][a-zA-Z0-9]*' | 1 | 158 |
| FieldNamingConventions | The final field name '_duplicateRules' doesn't match '[a-z][a-zA-Z0-9]*' | 1 | 164 |
| FieldNamingConventions | The final field name '_mediationIdentities' doesn't match '[a-z][a-zA-Z0-9]*' | 1 | 165 |
| RedundantFieldInitializer | Avoid using redundant field initializer for '_totalRecords' | 3 | 171 |
| UnnecessaryAnnotationValueElement | Avoid the use of value in annotations when its the only element | 3 | 179 |
| NullAssignment | Assigning an Object to null is a code smell. Consider refactoring. | 3 | 182 |
| NullAssignment | Assigning an Object to null is a code smell. Consider refactoring. | 3 | 202 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 3 | 205 |
| UnnecessaryAnnotationValueElement | Avoid the use of value in annotations when its the only element | 3 | 232 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 235 |
| AvoidLiteralsInIfCondition | Avoid using Literals in Conditional Statements | 3 | 290 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 3 | 293 |
| UnnecessaryAnnotationValueElement | Avoid the use of value in annotations when its the only element | 3 | 317 |
| CyclomaticComplexity | The method 'getResolveDuplicates(HttpServletRequest)' has a cyclomatic complexity of 13. | 3 | 318–388 |
| NPathComplexity | The method 'getResolveDuplicates(HttpServletRequest)' has an NPath complexity of 540 | 3 | 318–388 |
| LocalVariableNamingConventions | The final local variable name '_suspiciousCuid' doesn't match '[a-z][a-zA-Z0-9]*' | 1 | 320 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 320 |
| NullAssignment | Assigning an Object to null is a code smell. Consider refactoring. | 3 | 422 |
| NullAssignment | Assigning an Object to null is a code smell. Consider refactoring. | 3 | 423 |
| NullAssignment | Assigning an Object to null is a code smell. Consider refactoring. | 3 | 444 |
| NullAssignment | Assigning an Object to null is a code smell. Consider refactoring. | 3 | 445 |
| NullAssignment | Assigning an Object to null is a code smell. Consider refactoring. | 3 | 453 |
| NullAssignment | Assigning an Object to null is a code smell. Consider refactoring. | 3 | 454 |
| NullAssignment | Assigning an Object to null is a code smell. Consider refactoring. | 3 | 468 |
| NullAssignment | Assigning an Object to null is a code smell. Consider refactoring. | 3 | 469 |
| NullAssignment | Assigning an Object to null is a code smell. Consider refactoring. | 3 | 546 |
| NullAssignment | Assigning an Object to null is a code smell. Consider refactoring. | 3 | 547 |
| NPathComplexity | The method 'init(HttpServletRequest, boolean)' has an NPath complexity of 512 | 3 | 559–629 |
| CyclomaticComplexity | The method 'init(HttpServletRequest, boolean)' has a cyclomatic complexity of 11. | 3 | 559–629 |
| NullAssignment | Assigning an Object to null is a code smell. Consider refactoring. | 3 | 570 |
| NullAssignment | Assigning an Object to null is a code smell. Consider refactoring. | 3 | 579 |
| NullAssignment | Assigning an Object to null is a code smell. Consider refactoring. | 3 | 581 |
| NullAssignment | Assigning an Object to null is a code smell. Consider refactoring. | 3 | 583 |
| LinguisticNaming | Linguistics Antipattern - The getter 'getSuspiciousSummary' should not return void linguistically | 3 | 631–646 |
| AvoidCatchingGenericException | Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 3 | 672 |
| AvoidCatchingGenericException | Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 3 | 719 |
| ShortVariable | Avoid variables with short names like i1 | 3 | 740 |
| ShortVariable | Avoid variables with short names like i2 | 3 | 741 |
| CompareObjectsWithEquals | Use equals() to compare object references. | 3 | 912 |
| AvoidLiteralsInIfCondition | Avoid using Literals in Conditional Statements | 3 | 929 |
| AvoidDuplicateLiterals | The String literal "override-" appears 6 times in this file; the first occurrence is on line 978 | 3 | 978 |
| ControlStatementBraces | This statement should have braces | 3 | 1053 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 3 | 1088 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 3 | 1096 |
