The following document contains the results of PMD 6.13.0.
| Rule | Violation | Line |
|---|---|---|
| ClassWithOnlyPrivateConstructorsShouldBeFinal | A class which only has private constructors should be final | 42–81 |
| Rule | Violation | Line |
|---|---|---|
| ClassWithOnlyPrivateConstructorsShouldBeFinal | A class which only has private constructors should be final | 42–81 |
| Rule | Violation | Line |
|---|---|---|
| FieldNamingConventions | The field name 'first' doesn't match '_[a-z][a-zA-Z0-9]*' | 700 |
| FieldNamingConventions | The field name 'second' doesn't match '_[a-z][a-zA-Z0-9]*' | 701 |
| Rule | Violation | Line |
|---|---|---|
| LocalVariableNamingConventions | The local variable name '_listAttributesAssociation' doesn't match '[a-z][a-zA-Z0-9]*' | 466 |
| LocalVariableNamingConventions | The local variable name 'docType_code' doesn't match '[a-z][a-zA-Z0-9]*' | 485 |
| LocalVariableNamingConventions | The local variable name '_docAttr' doesn't match '[a-z][a-zA-Z0-9]*' | 486 |
| Rule | Violation | Line |
|---|---|---|
| CommentRequired | Header comments are required | 41–54 |
| CommentRequired | Public method and constructor comments are required | 43 |
| CommentRequired | Public method and constructor comments are required | 45 |
| CommentRequired | Public method and constructor comments are required | 47 |
| CommentRequired | Public method and constructor comments are required | 49 |
| CommentRequired | Public method and constructor comments are required | 51 |
| CommentRequired | Public method and constructor comments are required | 53 |
| Rule | Violation | Line |
|---|---|---|
| CommentRequired | Header comments are required | 41–52 |
| CommentRequired | Public method and constructor comments are required | 43 |
| CommentRequired | Public method and constructor comments are required | 45 |
| CommentRequired | Public method and constructor comments are required | 47 |
| CommentRequired | Public method and constructor comments are required | 49 |
| CommentRequired | Public method and constructor comments are required | 51 |
| Rule | Violation | Line |
|---|---|---|
| CommentRequired | Header comments are required | 41–54 |
| CommentRequired | Public method and constructor comments are required | 43 |
| CommentRequired | Public method and constructor comments are required | 45 |
| CommentRequired | Public method and constructor comments are required | 47 |
| CommentRequired | Public method and constructor comments are required | 49 |
| CommentRequired | Public method and constructor comments are required | 51 |
| CommentRequired | Public method and constructor comments are required | 53 |
| Rule | Violation | Line |
|---|---|---|
| CommentRequired | Header comments are required | 40–137 |
| CommentRequired | Public method and constructor comments are required | 47–50 |
| CommentRequired | Public method and constructor comments are required | 52–55 |
| CommentRequired | Public method and constructor comments are required | 57–60 |
| CommentRequired | Public method and constructor comments are required | 62–65 |
| CommentRequired | Public method and constructor comments are required | 67–70 |
| CommentRequired | Public method and constructor comments are required | 72–75 |
| CommentRequired | Public method and constructor comments are required | 77–80 |
| CommentRequired | Public method and constructor comments are required | 82–85 |
| CommentRequired | Public method and constructor comments are required | 87–99 |
| UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 95 |
| CommentRequired | Header comments are required | 101–136 |
| CommentRequired | Public method and constructor comments are required | 107–110 |
| CommentRequired | Public method and constructor comments are required | 112–115 |
| CommentRequired | Public method and constructor comments are required | 117–120 |
| CommentRequired | Public method and constructor comments are required | 122–125 |
| CommentRequired | Public method and constructor comments are required | 127–130 |
| CommentRequired | Public method and constructor comments are required | 132–135 |
| Rule | Violation | Line |
|---|---|---|
| CommentRequired | Header comments are required | 44–229 |
| MissingOverride | The method 'delete(int, Plugin)' is missing an @Override annotation. | 57–70 |
| CommentRequired | Public method and constructor comments are required | 57–70 |
| CommentRequired | Public method and constructor comments are required | 72–98 |
| MissingOverride | The method 'insert(LibraryMapping, Plugin)' is missing an @Override annotation. | 72–98 |
| CommentRequired | Public method and constructor comments are required | 100–127 |
| MissingOverride | The method 'load(int, Plugin)' is missing an @Override annotation. | 100–127 |
| CommentRequired | Public method and constructor comments are required | 129–162 |
| MissingOverride | The method 'selectByMedia(int, Plugin)' is missing an @Override annotation. | 129–162 |
| UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 131 |
| CommentRequired | Public method and constructor comments are required | 164–196 |
| MissingOverride | The method 'store(LibraryMapping, Plugin)' is missing an @Override annotation. | 164–196 |
| MissingOverride | The method 'deleteAttributeAssociation(int, Plugin)' is missing an @Override annotation. | 221–228 |
| CommentRequired | Public method and constructor comments are required | 221–228 |
| Rule | Violation | Line |
|---|---|---|
| CommentRequired | Header comments are required | 42–81 |
| CommentRequired | Public method and constructor comments are required | 52–55 |
| CommentRequired | Public method and constructor comments are required | 57–60 |
| CommentRequired | Public method and constructor comments are required | 62–65 |
| CommentRequired | Public method and constructor comments are required | 67–70 |
| CommentRequired | Public method and constructor comments are required | 72–75 |
| CommentRequired | Public method and constructor comments are required | 77–80 |
| Rule | Violation | Line |
|---|---|---|
| CommentRequired | Header comments are required | 41–115 |
| CommentRequired | Public method and constructor comments are required | 50–53 |
| CommentRequired | Public method and constructor comments are required | 55–58 |
| CommentRequired | Public method and constructor comments are required | 60–63 |
| CommentRequired | Public method and constructor comments are required | 65–68 |
| CommentRequired | Public method and constructor comments are required | 70–73 |
| CommentRequired | Public method and constructor comments are required | 75–78 |
| CommentRequired | Public method and constructor comments are required | 80–83 |
| CommentRequired | Public method and constructor comments are required | 85–88 |
| CommentRequired | Public method and constructor comments are required | 100–104 |
| CommentRequired | Public method and constructor comments are required | 106–109 |
| CommentRequired | Public method and constructor comments are required | 111–114 |
| Rule | Violation | Line |
|---|---|---|
| CommentRequired | Header comments are required | 43–153 |
| CommentRequired | Public method and constructor comments are required | 52–58 |
| MissingOverride | The method 'delete(int, Plugin)' is missing an @Override annotation. | 52–58 |
| MissingOverride | The method 'insert(LibraryMedia, Plugin)' is missing an @Override annotation. | 60–73 |
| CommentRequired | Public method and constructor comments are required | 60–73 |
| CommentRequired | Public method and constructor comments are required | 75–95 |
| MissingOverride | The method 'load(int, Plugin)' is missing an @Override annotation. | 75–95 |
| CommentRequired | Public method and constructor comments are required | 97–116 |
| MissingOverride | The method 'selectAll(Plugin)' is missing an @Override annotation. | 97–116 |
| UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 99 |
| CommentRequired | Public method and constructor comments are required | 118–128 |
| MissingOverride | The method 'store(LibraryMedia, Plugin)' is missing an @Override annotation. | 118–128 |
| Rule | Violation | Line |
|---|---|---|
| CommentRequired | Header comments are required | 42–76 |
| CommentRequired | Public method and constructor comments are required | 52–55 |
| CommentRequired | Public method and constructor comments are required | 57–60 |
| CommentRequired | Public method and constructor comments are required | 62–65 |
| CommentRequired | Public method and constructor comments are required | 67–70 |
| CommentRequired | Public method and constructor comments are required | 72–75 |
| Rule | Violation | Line |
|---|---|---|
| CommentRequired | Header comments are required | 42–177 |
| CommentRequired | Public method and constructor comments are required | 62–65 |
| CommentRequired | Public method and constructor comments are required | 67–70 |
| CommentRequired | Public method and constructor comments are required | 72–75 |
| CommentRequired | Public method and constructor comments are required | 77–80 |
| CommentRequired | Public method and constructor comments are required | 82–85 |
| CommentRequired | Public method and constructor comments are required | 87–90 |
| CommentRequired | Public method and constructor comments are required | 92–95 |
| CommentRequired | Public method and constructor comments are required | 97–100 |
| CommentRequired | Public method and constructor comments are required | 102–106 |
| CommentRequired | Public method and constructor comments are required | 108–111 |
| CommentRequired | Public method and constructor comments are required | 113–116 |
| CommentRequired | Public method and constructor comments are required | 118–151 |
| MissingOverride | The method 'setLocale(Locale)' is missing an @Override annotation. | 153–156 |
| Rule | Violation | Line |
|---|---|---|
| CommentRequired | Header comments are required | 43–167 |
| MissingOverride | The method 'delete(int, Plugin)' is missing an @Override annotation. | 53–59 |
| CommentRequired | Public method and constructor comments are required | 53–59 |
| CommentRequired | Public method and constructor comments are required | 61–73 |
| MissingOverride | The method 'insert(MediaAttribute, Plugin)' is missing an @Override annotation. | 61–73 |
| CommentRequired | Public method and constructor comments are required | 75–96 |
| MissingOverride | The method 'load(int, Plugin)' is missing an @Override annotation. | 75–96 |
| MissingOverride | The method 'selectAllAttributesForMedia(int, Plugin)' is missing an @Override annotation. | 98–120 |
| CommentRequired | Public method and constructor comments are required | 98–120 |
| UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 100 |
| MissingOverride | The method 'store(MediaAttribute, Plugin)' is missing an @Override annotation. | 122–135 |
| CommentRequired | Public method and constructor comments are required | 122–135 |
| MissingOverride | The method 'deleteAllForMedia(int, Plugin)' is missing an @Override annotation. | 160–166 |
| CommentRequired | Public method and constructor comments are required | 160–166 |
| Rule | Violation | Line |
|---|---|---|
| CommentRequired | Header comments are required | 42–81 |
| CommentRequired | Public method and constructor comments are required | 52–55 |
| CommentRequired | Public method and constructor comments are required | 57–60 |
| CommentRequired | Public method and constructor comments are required | 62–65 |
| CommentRequired | Public method and constructor comments are required | 67–70 |
| CommentRequired | Public method and constructor comments are required | 72–75 |
| CommentRequired | Public method and constructor comments are required | 77–80 |
| Rule | Violation | Line |
|---|---|---|
| CommentRequired | Header comments are required | 41–184 |
| ShortVariable | Avoid variables with short names like o | 175 |
| Rule | Violation | Line |
|---|---|---|
| ExcessiveImports | A high number of imports can indicate a high degree of coupling within an object. | 34–719 |
| UnusedPrivateField | Avoid unused private fields such as 'PARAMETER_PAGE_INDEX'. | 104 |
| UnusedPrivateField | Avoid unused private fields such as 'DEFAULT_RESULTS_PER_PAGE'. | 136 |
| SingularField | Perhaps '_nDefaultItemsPerPage' could be replaced by a local variable. | 150 |
| MissingOverride | The method 'getInsertServiceSelectorUI(HttpServletRequest)' is missing an @Override annotation. | 152–164 |
| CommentRequired | Public method and constructor comments are required | 152–164 |
| NullAssignment | Assigning an Object to null is a code smell. Consider refactoring. | 155 |
| NPathComplexity | The method 'getSelectMedia(HttpServletRequest)' has an NPath complexity of 256 | 166–256 |
| CommentRequired | Public method and constructor comments are required | 166–256 |
| CyclomaticComplexity | The method 'getSelectMedia(HttpServletRequest)' has a cyclomatic complexity of 11. | 166–256 |
| UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 197 |
| UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 198 |
| UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 199 |
| SimplifiedTernary | Ternary operators that can be simplified with || or && | 251 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 251 |
| CommentRequired | Public method and constructor comments are required | 258–298 |
| CommentRequired | Public method and constructor comments are required | 300–370 |
| CyclomaticComplexity | The method 'doSelectMedia(HttpServletRequest)' has a cyclomatic complexity of 10. | 300–370 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 306 |
| UseCollectionIsEmpty | Substitute calls to size() == 0 (or size() != 0, size() > 0, size() < 1) with calls to isEmpty() | 321 |
| UseCollectionIsEmpty | Substitute calls to size() == 0 (or size() != 0, size() > 0, size() < 1) with calls to isEmpty() | 333 |
| NullAssignment | Assigning an Object to null is a code smell. Consider refactoring. | 346 |
| UseCollectionIsEmpty | Substitute calls to size() == 0 (or size() != 0, size() > 0, size() < 1) with calls to isEmpty() | 357 |
| UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 359 |
| CommentRequired | Public method and constructor comments are required | 372–427 |
| UseCollectionIsEmpty | Substitute calls to size() == 0 (or size() != 0, size() > 0, size() < 1) with calls to isEmpty() | 385 |
| UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 387 |
| AvoidReassigningLoopVariables | Avoid reassigning the loop control variable 'document' | 401 |
| CommentRequired | Public method and constructor comments are required | 429–490 |
| CommentRequired | Public method and constructor comments are required | 492–572 |
| AvoidCatchingGenericException | Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 559 |
| UseProperClassLoader | In J2EE, getClassLoader() might not work as expected. Use Thread.currentThread().getContextClassLoader() instead. | 562 |
| NullAssignment | Assigning an Object to null is a code smell. Consider refactoring. | 569 |
| ShortVariable | Avoid variables with short names like m | 574 |
| UnusedFormalParameter | Avoid unused method parameters such as 'nSpaceId'. | 597 |
| ShortVariable | Avoid variables with short names like m | 597 |
| UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 601 |
| ShortVariable | Avoid variables with short names like m | 616 |
| UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 618 |
| LooseCoupling | Avoid using implementation types like 'HashMap'; use the interface instead | 647 |
| UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 649 |
| IdempotentOperations | Avoid idempotent operations (like assigning a variable to itself). | 685 |
| UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 693–694 |
| UnnecessaryLocalBeforeReturn | Consider simply returning the value vs storing it in local variable 'paginator' | 695 |
| CommentRequired | Header comments are required | 698–718 |
| ImmutableField | Private field 'first' could be made final; it is only initialized in the declaration or constructor. | 700 |
| ImmutableField | Private field 'second' could be made final; it is only initialized in the declaration or constructor. | 701 |
| ShortVariable | Avoid variables with short names like x | 703 |
| CommentRequired | Public method and constructor comments are required | 703–707 |
| ShortVariable | Avoid variables with short names like y | 703 |
| Rule | Violation | Line |
|---|---|---|
| ExcessiveImports | A high number of imports can indicate a high degree of coupling within an object. | 34–724 |
| UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 146 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 146 |
| UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 258 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 258 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 278 |
| UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 315 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 315 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 335 |
| UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 372 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 394 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 524 |
| UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 524 |
| UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 534 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 534 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 563 |
| UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 563 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 636 |
| UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 636 |
| Rule | Violation | Line |
|---|---|---|
| ExcessiveImports | A high number of imports can indicate a high degree of coupling within an object. | 34–565 |
| LooseCoupling | Avoid using implementation types like 'HashMap'; use the interface instead | 181 |
| UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 183 |
| UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 305 |
| AddEmptyString | Do not add empty strings | 306 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 343 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 408–415 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 428–435 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 477–490 |
| ControlStatementBraces | This statement should have braces | 487 |
| AvoidCatchingGenericException | Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 514 |
| UseProperClassLoader | In J2EE, getClassLoader() might not work as expected. Use Thread.currentThread().getContextClassLoader() instead. | 517 |
| ShortVariable | Avoid variables with short names like m | 553 |
| UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 555 |
| Rule | Violation | Line |
|---|---|---|
| BooleanGetMethodName | A getX() method which returns a boolean should be named isX() | 106–109 |
| Rule | Violation | Line |
|---|---|---|
| ShortClassName | Avoid short class names like Pair | 698–718 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| CommentRequired | Header comments are required | 3 | 41–54 |
| CommentRequired | Public method and constructor comments are required | 3 | 43 |
| CommentRequired | Public method and constructor comments are required | 3 | 45 |
| CommentRequired | Public method and constructor comments are required | 3 | 47 |
| CommentRequired | Public method and constructor comments are required | 3 | 49 |
| CommentRequired | Public method and constructor comments are required | 3 | 51 |
| CommentRequired | Public method and constructor comments are required | 3 | 53 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| CommentRequired | Header comments are required | 3 | 41–52 |
| CommentRequired | Public method and constructor comments are required | 3 | 43 |
| CommentRequired | Public method and constructor comments are required | 3 | 45 |
| CommentRequired | Public method and constructor comments are required | 3 | 47 |
| CommentRequired | Public method and constructor comments are required | 3 | 49 |
| CommentRequired | Public method and constructor comments are required | 3 | 51 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| CommentRequired | Header comments are required | 3 | 41–54 |
| CommentRequired | Public method and constructor comments are required | 3 | 43 |
| CommentRequired | Public method and constructor comments are required | 3 | 45 |
| CommentRequired | Public method and constructor comments are required | 3 | 47 |
| CommentRequired | Public method and constructor comments are required | 3 | 49 |
| CommentRequired | Public method and constructor comments are required | 3 | 51 |
| CommentRequired | Public method and constructor comments are required | 3 | 53 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| CommentRequired | Header comments are required | 3 | 40–137 |
| CommentRequired | Public method and constructor comments are required | 3 | 47–50 |
| CommentRequired | Public method and constructor comments are required | 3 | 52–55 |
| CommentRequired | Public method and constructor comments are required | 3 | 57–60 |
| CommentRequired | Public method and constructor comments are required | 3 | 62–65 |
| CommentRequired | Public method and constructor comments are required | 3 | 67–70 |
| CommentRequired | Public method and constructor comments are required | 3 | 72–75 |
| CommentRequired | Public method and constructor comments are required | 3 | 77–80 |
| CommentRequired | Public method and constructor comments are required | 3 | 82–85 |
| CommentRequired | Public method and constructor comments are required | 3 | 87–99 |
| UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 3 | 95 |
| CommentRequired | Header comments are required | 3 | 101–136 |
| CommentRequired | Public method and constructor comments are required | 3 | 107–110 |
| CommentRequired | Public method and constructor comments are required | 3 | 112–115 |
| CommentRequired | Public method and constructor comments are required | 3 | 117–120 |
| CommentRequired | Public method and constructor comments are required | 3 | 122–125 |
| CommentRequired | Public method and constructor comments are required | 3 | 127–130 |
| CommentRequired | Public method and constructor comments are required | 3 | 132–135 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| CommentRequired | Header comments are required | 3 | 44–229 |
| MissingOverride | The method 'delete(int, Plugin)' is missing an @Override annotation. | 3 | 57–70 |
| CommentRequired | Public method and constructor comments are required | 3 | 57–70 |
| CommentRequired | Public method and constructor comments are required | 3 | 72–98 |
| MissingOverride | The method 'insert(LibraryMapping, Plugin)' is missing an @Override annotation. | 3 | 72–98 |
| CommentRequired | Public method and constructor comments are required | 3 | 100–127 |
| MissingOverride | The method 'load(int, Plugin)' is missing an @Override annotation. | 3 | 100–127 |
| CommentRequired | Public method and constructor comments are required | 3 | 129–162 |
| MissingOverride | The method 'selectByMedia(int, Plugin)' is missing an @Override annotation. | 3 | 129–162 |
| UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 3 | 131 |
| CommentRequired | Public method and constructor comments are required | 3 | 164–196 |
| MissingOverride | The method 'store(LibraryMapping, Plugin)' is missing an @Override annotation. | 3 | 164–196 |
| MissingOverride | The method 'deleteAttributeAssociation(int, Plugin)' is missing an @Override annotation. | 3 | 221–228 |
| CommentRequired | Public method and constructor comments are required | 3 | 221–228 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| ClassWithOnlyPrivateConstructorsShouldBeFinal | A class which only has private constructors should be final | 1 | 42–81 |
| CommentRequired | Header comments are required | 3 | 42–81 |
| CommentRequired | Public method and constructor comments are required | 3 | 52–55 |
| CommentRequired | Public method and constructor comments are required | 3 | 57–60 |
| CommentRequired | Public method and constructor comments are required | 3 | 62–65 |
| CommentRequired | Public method and constructor comments are required | 3 | 67–70 |
| CommentRequired | Public method and constructor comments are required | 3 | 72–75 |
| CommentRequired | Public method and constructor comments are required | 3 | 77–80 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| CommentRequired | Header comments are required | 3 | 41–115 |
| CommentRequired | Public method and constructor comments are required | 3 | 50–53 |
| CommentRequired | Public method and constructor comments are required | 3 | 55–58 |
| CommentRequired | Public method and constructor comments are required | 3 | 60–63 |
| CommentRequired | Public method and constructor comments are required | 3 | 65–68 |
| CommentRequired | Public method and constructor comments are required | 3 | 70–73 |
| CommentRequired | Public method and constructor comments are required | 3 | 75–78 |
| CommentRequired | Public method and constructor comments are required | 3 | 80–83 |
| CommentRequired | Public method and constructor comments are required | 3 | 85–88 |
| CommentRequired | Public method and constructor comments are required | 3 | 100–104 |
| CommentRequired | Public method and constructor comments are required | 3 | 106–109 |
| BooleanGetMethodName | A getX() method which returns a boolean should be named isX() | 4 | 106–109 |
| CommentRequired | Public method and constructor comments are required | 3 | 111–114 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| CommentRequired | Header comments are required | 3 | 43–153 |
| CommentRequired | Public method and constructor comments are required | 3 | 52–58 |
| MissingOverride | The method 'delete(int, Plugin)' is missing an @Override annotation. | 3 | 52–58 |
| MissingOverride | The method 'insert(LibraryMedia, Plugin)' is missing an @Override annotation. | 3 | 60–73 |
| CommentRequired | Public method and constructor comments are required | 3 | 60–73 |
| CommentRequired | Public method and constructor comments are required | 3 | 75–95 |
| MissingOverride | The method 'load(int, Plugin)' is missing an @Override annotation. | 3 | 75–95 |
| CommentRequired | Public method and constructor comments are required | 3 | 97–116 |
| MissingOverride | The method 'selectAll(Plugin)' is missing an @Override annotation. | 3 | 97–116 |
| UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 3 | 99 |
| CommentRequired | Public method and constructor comments are required | 3 | 118–128 |
| MissingOverride | The method 'store(LibraryMedia, Plugin)' is missing an @Override annotation. | 3 | 118–128 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| CommentRequired | Header comments are required | 3 | 42–76 |
| CommentRequired | Public method and constructor comments are required | 3 | 52–55 |
| CommentRequired | Public method and constructor comments are required | 3 | 57–60 |
| CommentRequired | Public method and constructor comments are required | 3 | 62–65 |
| CommentRequired | Public method and constructor comments are required | 3 | 67–70 |
| CommentRequired | Public method and constructor comments are required | 3 | 72–75 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| CommentRequired | Header comments are required | 3 | 42–177 |
| CommentRequired | Public method and constructor comments are required | 3 | 62–65 |
| CommentRequired | Public method and constructor comments are required | 3 | 67–70 |
| CommentRequired | Public method and constructor comments are required | 3 | 72–75 |
| CommentRequired | Public method and constructor comments are required | 3 | 77–80 |
| CommentRequired | Public method and constructor comments are required | 3 | 82–85 |
| CommentRequired | Public method and constructor comments are required | 3 | 87–90 |
| CommentRequired | Public method and constructor comments are required | 3 | 92–95 |
| CommentRequired | Public method and constructor comments are required | 3 | 97–100 |
| CommentRequired | Public method and constructor comments are required | 3 | 102–106 |
| CommentRequired | Public method and constructor comments are required | 3 | 108–111 |
| CommentRequired | Public method and constructor comments are required | 3 | 113–116 |
| CommentRequired | Public method and constructor comments are required | 3 | 118–151 |
| MissingOverride | The method 'setLocale(Locale)' is missing an @Override annotation. | 3 | 153–156 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| CommentRequired | Header comments are required | 3 | 43–167 |
| MissingOverride | The method 'delete(int, Plugin)' is missing an @Override annotation. | 3 | 53–59 |
| CommentRequired | Public method and constructor comments are required | 3 | 53–59 |
| CommentRequired | Public method and constructor comments are required | 3 | 61–73 |
| MissingOverride | The method 'insert(MediaAttribute, Plugin)' is missing an @Override annotation. | 3 | 61–73 |
| CommentRequired | Public method and constructor comments are required | 3 | 75–96 |
| MissingOverride | The method 'load(int, Plugin)' is missing an @Override annotation. | 3 | 75–96 |
| MissingOverride | The method 'selectAllAttributesForMedia(int, Plugin)' is missing an @Override annotation. | 3 | 98–120 |
| CommentRequired | Public method and constructor comments are required | 3 | 98–120 |
| UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 3 | 100 |
| MissingOverride | The method 'store(MediaAttribute, Plugin)' is missing an @Override annotation. | 3 | 122–135 |
| CommentRequired | Public method and constructor comments are required | 3 | 122–135 |
| MissingOverride | The method 'deleteAllForMedia(int, Plugin)' is missing an @Override annotation. | 3 | 160–166 |
| CommentRequired | Public method and constructor comments are required | 3 | 160–166 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| CommentRequired | Header comments are required | 3 | 42–81 |
| ClassWithOnlyPrivateConstructorsShouldBeFinal | A class which only has private constructors should be final | 1 | 42–81 |
| CommentRequired | Public method and constructor comments are required | 3 | 52–55 |
| CommentRequired | Public method and constructor comments are required | 3 | 57–60 |
| CommentRequired | Public method and constructor comments are required | 3 | 62–65 |
| CommentRequired | Public method and constructor comments are required | 3 | 67–70 |
| CommentRequired | Public method and constructor comments are required | 3 | 72–75 |
| CommentRequired | Public method and constructor comments are required | 3 | 77–80 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| CommentRequired | Header comments are required | 3 | 41–184 |
| ShortVariable | Avoid variables with short names like o | 3 | 175 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| ExcessiveImports | A high number of imports can indicate a high degree of coupling within an object. | 3 | 34–719 |
| UnusedPrivateField | Avoid unused private fields such as 'PARAMETER_PAGE_INDEX'. | 3 | 104 |
| UnusedPrivateField | Avoid unused private fields such as 'DEFAULT_RESULTS_PER_PAGE'. | 3 | 136 |
| SingularField | Perhaps '_nDefaultItemsPerPage' could be replaced by a local variable. | 3 | 150 |
| MissingOverride | The method 'getInsertServiceSelectorUI(HttpServletRequest)' is missing an @Override annotation. | 3 | 152–164 |
| CommentRequired | Public method and constructor comments are required | 3 | 152–164 |
| NullAssignment | Assigning an Object to null is a code smell. Consider refactoring. | 3 | 155 |
| NPathComplexity | The method 'getSelectMedia(HttpServletRequest)' has an NPath complexity of 256 | 3 | 166–256 |
| CommentRequired | Public method and constructor comments are required | 3 | 166–256 |
| CyclomaticComplexity | The method 'getSelectMedia(HttpServletRequest)' has a cyclomatic complexity of 11. | 3 | 166–256 |
| UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 3 | 197 |
| UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 3 | 198 |
| UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 3 | 199 |
| SimplifiedTernary | Ternary operators that can be simplified with || or && | 3 | 251 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 3 | 251 |
| CommentRequired | Public method and constructor comments are required | 3 | 258–298 |
| CommentRequired | Public method and constructor comments are required | 3 | 300–370 |
| CyclomaticComplexity | The method 'doSelectMedia(HttpServletRequest)' has a cyclomatic complexity of 10. | 3 | 300–370 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 306 |
| UseCollectionIsEmpty | Substitute calls to size() == 0 (or size() != 0, size() > 0, size() < 1) with calls to isEmpty() | 3 | 321 |
| UseCollectionIsEmpty | Substitute calls to size() == 0 (or size() != 0, size() > 0, size() < 1) with calls to isEmpty() | 3 | 333 |
| NullAssignment | Assigning an Object to null is a code smell. Consider refactoring. | 3 | 346 |
| UseCollectionIsEmpty | Substitute calls to size() == 0 (or size() != 0, size() > 0, size() < 1) with calls to isEmpty() | 3 | 357 |
| UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 3 | 359 |
| CommentRequired | Public method and constructor comments are required | 3 | 372–427 |
| UseCollectionIsEmpty | Substitute calls to size() == 0 (or size() != 0, size() > 0, size() < 1) with calls to isEmpty() | 3 | 385 |
| UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 3 | 387 |
| AvoidReassigningLoopVariables | Avoid reassigning the loop control variable 'document' | 3 | 401 |
| CommentRequired | Public method and constructor comments are required | 3 | 429–490 |
| CommentRequired | Public method and constructor comments are required | 3 | 492–572 |
| AvoidCatchingGenericException | Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 3 | 559 |
| UseProperClassLoader | In J2EE, getClassLoader() might not work as expected. Use Thread.currentThread().getContextClassLoader() instead. | 3 | 562 |
| NullAssignment | Assigning an Object to null is a code smell. Consider refactoring. | 3 | 569 |
| ShortVariable | Avoid variables with short names like m | 3 | 574 |
| UnusedFormalParameter | Avoid unused method parameters such as 'nSpaceId'. | 3 | 597 |
| ShortVariable | Avoid variables with short names like m | 3 | 597 |
| UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 3 | 601 |
| ShortVariable | Avoid variables with short names like m | 3 | 616 |
| UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 3 | 618 |
| LooseCoupling | Avoid using implementation types like 'HashMap'; use the interface instead | 3 | 647 |
| UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 3 | 649 |
| IdempotentOperations | Avoid idempotent operations (like assigning a variable to itself). | 3 | 685 |
| UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 3 | 693–694 |
| UnnecessaryLocalBeforeReturn | Consider simply returning the value vs storing it in local variable 'paginator' | 3 | 695 |
| ShortClassName | Avoid short class names like Pair | 4 | 698–718 |
| CommentRequired | Header comments are required | 3 | 698–718 |
| ImmutableField | Private field 'first' could be made final; it is only initialized in the declaration or constructor. | 3 | 700 |
| FieldNamingConventions | The field name 'first' doesn't match '_[a-z][a-zA-Z0-9]*' | 1 | 700 |
| FieldNamingConventions | The field name 'second' doesn't match '_[a-z][a-zA-Z0-9]*' | 1 | 701 |
| ImmutableField | Private field 'second' could be made final; it is only initialized in the declaration or constructor. | 3 | 701 |
| ShortVariable | Avoid variables with short names like x | 3 | 703 |
| CommentRequired | Public method and constructor comments are required | 3 | 703–707 |
| ShortVariable | Avoid variables with short names like y | 3 | 703 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| ExcessiveImports | A high number of imports can indicate a high degree of coupling within an object. | 3 | 34–724 |
| UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 3 | 146 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 3 | 146 |
| UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 3 | 258 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 3 | 258 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 278 |
| UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 3 | 315 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 3 | 315 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 335 |
| UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 3 | 372 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 394 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 3 | 524 |
| UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 3 | 524 |
| UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 3 | 534 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 3 | 534 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 3 | 563 |
| UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 3 | 563 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 3 | 636 |
| UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 3 | 636 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| ExcessiveImports | A high number of imports can indicate a high degree of coupling within an object. | 3 | 34–565 |
| LooseCoupling | Avoid using implementation types like 'HashMap'; use the interface instead | 3 | 181 |
| UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 3 | 183 |
| UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 3 | 305 |
| AddEmptyString | Do not add empty strings | 3 | 306 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 343 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 3 | 408–415 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 3 | 428–435 |
| LocalVariableNamingConventions | The local variable name '_listAttributesAssociation' doesn't match '[a-z][a-zA-Z0-9]*' | 1 | 466 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 3 | 477–490 |
| LocalVariableNamingConventions | The local variable name 'docType_code' doesn't match '[a-z][a-zA-Z0-9]*' | 1 | 485 |
| LocalVariableNamingConventions | The local variable name '_docAttr' doesn't match '[a-z][a-zA-Z0-9]*' | 1 | 486 |
| ControlStatementBraces | This statement should have braces | 3 | 487 |
| AvoidCatchingGenericException | Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 3 | 514 |
| UseProperClassLoader | In J2EE, getClassLoader() might not work as expected. Use Thread.currentThread().getContextClassLoader() instead. | 3 | 517 |
| ShortVariable | Avoid variables with short names like m | 3 | 553 |
| UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 3 | 555 |
