SpotBugs Bug Detector Report
The following document contains the results of SpotBugs
SpotBugs Version is 4.5.3
Threshold is medium
Effort is default
Summary
| Classes |
Bugs |
Errors |
Missing Classes |
| 18 |
19 |
0 |
0 |
fr.paris.lutece.plugins.library.business.LibraryMapping
| Bug |
Category |
Details |
Line |
Priority |
| fr.paris.lutece.plugins.library.business.LibraryMapping.getAttributeAssociationList() may expose internal representation by returning LibraryMapping._colAttributeAssociation |
MALICIOUS_CODE |
EI_EXPOSE_REP |
79 |
Medium |
| fr.paris.lutece.plugins.library.business.LibraryMapping.setAttributeAssociationList(Collection) may expose internal representation by storing an externally mutable object into LibraryMapping._colAttributeAssociation |
MALICIOUS_CODE |
EI_EXPOSE_REP2 |
84 |
Medium |
fr.paris.lutece.plugins.library.business.LibraryMapping$AttributeAssociation
| Bug |
Category |
Details |
Line |
Priority |
| new fr.paris.lutece.plugins.library.business.LibraryMapping$AttributeAssociation(LibraryMapping) may expose internal representation by storing an externally mutable object into LibraryMapping$AttributeAssociation.this$0 |
MALICIOUS_CODE |
EI_EXPOSE_REP2 |
101 |
Medium |
| Should fr.paris.lutece.plugins.library.business.LibraryMapping$AttributeAssociation be a _static_ inner class? |
PERFORMANCE |
SIC_INNER_SHOULD_BE_STATIC |
101-134 |
Medium |
fr.paris.lutece.plugins.library.business.LibraryMedia
| Bug |
Category |
Details |
Line |
Priority |
| fr.paris.lutece.plugins.library.business.LibraryMedia.getMediaAttributeList() may expose internal representation by returning LibraryMedia._colMediaAttribute |
MALICIOUS_CODE |
EI_EXPOSE_REP |
52 |
Medium |
| fr.paris.lutece.plugins.library.business.LibraryMedia.getStyleSheet() may expose internal representation by returning LibraryMedia._stylesheet |
MALICIOUS_CODE |
EI_EXPOSE_REP |
92 |
Medium |
| fr.paris.lutece.plugins.library.business.LibraryMedia.setMediaAttributeList(Collection) may expose internal representation by storing an externally mutable object into LibraryMedia._colMediaAttribute |
MALICIOUS_CODE |
EI_EXPOSE_REP2 |
57 |
Medium |
| fr.paris.lutece.plugins.library.business.LibraryMedia.setStyleSheet(StyleSheet) may expose internal representation by storing an externally mutable object into LibraryMedia._stylesheet |
MALICIOUS_CODE |
EI_EXPOSE_REP2 |
97 |
Medium |
fr.paris.lutece.plugins.library.business.SelectedMedia
| Bug |
Category |
Details |
Line |
Priority |
| fr.paris.lutece.plugins.library.business.SelectedMedia.getAttributesFromMapping() may expose internal representation by returning SelectedMedia._attributesFromMapping |
MALICIOUS_CODE |
EI_EXPOSE_REP |
163 |
Medium |
| fr.paris.lutece.plugins.library.business.SelectedMedia.getDocument() may expose internal representation by returning SelectedMedia._document |
MALICIOUS_CODE |
EI_EXPOSE_REP |
149 |
Medium |
| fr.paris.lutece.plugins.library.business.SelectedMedia.setAttributesFromMapping(Map) may expose internal representation by storing an externally mutable object into SelectedMedia._attributesFromMapping |
MALICIOUS_CODE |
EI_EXPOSE_REP2 |
168 |
Medium |
| fr.paris.lutece.plugins.library.business.SelectedMedia.setDocument(Document) may expose internal representation by storing an externally mutable object into SelectedMedia._document |
MALICIOUS_CODE |
EI_EXPOSE_REP2 |
158 |
Medium |
| fr.paris.lutece.plugins.library.business.SelectedMedia defines compareTo(SelectedMedia) and uses Object.equals() |
BAD_PRACTICE |
EQ_COMPARETO_USE_OBJECT_EQUALS |
177-182 |
Medium |
fr.paris.lutece.plugins.library.web.LibraryInsertServiceJspBean
| Bug |
Category |
Details |
Line |
Priority |
| Self assignment of field LibraryInsertServiceJspBean._strCurrentPageIndex in fr.paris.lutece.plugins.library.web.LibraryInsertServiceJspBean.getPaginator(HttpServletRequest, List) |
CORRECTNESS |
SA_FIELD_SELF_ASSIGNMENT |
664 |
Medium |
| Class fr.paris.lutece.plugins.library.web.LibraryInsertServiceJspBean defines non-transient non-serializable instance field _listSelectedMedia |
BAD_PRACTICE |
SE_BAD_FIELD |
Not available |
Medium |
| Class fr.paris.lutece.plugins.library.web.LibraryInsertServiceJspBean defines non-transient non-serializable instance field _plugin |
BAD_PRACTICE |
SE_BAD_FIELD |
Not available |
Medium |
fr.paris.lutece.plugins.library.web.LibraryInsertServiceJspBean$Pair
| Bug |
Category |
Details |
Line |
Priority |
| new fr.paris.lutece.plugins.library.web.LibraryInsertServiceJspBean$Pair(LibraryInsertServiceJspBean, Object, Object) may expose internal representation by storing an externally mutable object into LibraryInsertServiceJspBean$Pair.this$0 |
MALICIOUS_CODE |
EI_EXPOSE_REP2 |
697 |
Medium |
| Should fr.paris.lutece.plugins.library.web.LibraryInsertServiceJspBean$Pair be a _static_ inner class? |
PERFORMANCE |
SIC_INNER_SHOULD_BE_STATIC |
697-709 |
Medium |
fr.paris.lutece.plugins.library.web.UploadInsertServiceJspBean
| Bug |
Category |
Details |
Line |
Priority |
| Class fr.paris.lutece.plugins.library.web.UploadInsertServiceJspBean defines non-transient non-serializable instance field _plugin |
BAD_PRACTICE |
SE_BAD_FIELD |
Not available |
Medium |
