The following document contains the results of PMD 6.13.0.
| Rule | Violation | Line |
|---|---|---|
| ClassWithOnlyPrivateConstructorsShouldBeFinal | A class which only has private constructors should be final | 42–97 |
| Rule | Violation | Line |
|---|---|---|
| ClassWithOnlyPrivateConstructorsShouldBeFinal | A class which only has private constructors should be final | 57–200 |
| FieldNamingConventions | The constant name '_mapper' doesn't match '[A-Z][A-Z_0-9]*' | 63 |
| Rule | Violation | Line |
|---|---|---|
| ClassNamingConventions | The utility class name 'Globals' doesn't match '[A-Z][a-zA-Z0-9]+(Utils?|Helper|Home|Service)' | 36–43 |
| ClassWithOnlyPrivateConstructorsShouldBeFinal | A class which only has private constructors should be final | 36–43 |
| Rule | Violation | Line |
|---|---|---|
| ClassWithOnlyPrivateConstructorsShouldBeFinal | A class which only has private constructors should be final | 42–82 |
| Rule | Violation | Line |
|---|---|---|
| ClassWithOnlyPrivateConstructorsShouldBeFinal | A class which only has private constructors should be final | 62–160 |
| Rule | Violation | Line |
|---|---|---|
| ClassWithOnlyPrivateConstructorsShouldBeFinal | A class which only has private constructors should be final | 44–79 |
| Rule | Violation | Line |
|---|---|---|
| FieldNamingConventions | The constant name '_mapper' doesn't match '[A-Z][A-Z_0-9]*' | 100 |
| Rule | Violation | Line |
|---|---|---|
| ClassNamingConventions | The utility class name 'Constants' doesn't match '[A-Z][a-zA-Z0-9]+(Utils?|Helper|Home|Service)' | 36–59 |
| Rule | Violation | Line |
|---|---|---|
| FieldNamingConventions | The constant name '_mapper' doesn't match '[A-Z][A-Z_0-9]*' | 64 |
| Rule | Violation | Line |
|---|---|---|
| FieldNamingConventions | The constant name '_mapper' doesn't match '[A-Z][A-Z_0-9]*' | 69 |
| Rule | Violation | Line |
|---|---|---|
| AvoidReassigningParameters | Avoid reassigning parameters such as 'site' | 241 |
| Rule | Violation | Line |
|---|---|---|
| GuardLogStatement | Logger calls should be surrounded by log level guards. | 146 |
| GuardLogStatement | Logger calls should be surrounded by log level guards. | 151 |
| Rule | Violation | Line |
|---|---|---|
| CommentRequired | Header comments are required | 42–100 |
| Rule | Violation | Line |
|---|---|---|
| CommentRequired | Header comments are required | 42–97 |
| Rule | Violation | Line |
|---|---|---|
| CommentRequired | Header comments are required | 40–82 |
| Rule | Violation | Line |
|---|---|---|
| AvoidCatchingGenericException | Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 193 |
| Rule | Violation | Line |
|---|---|---|
| CommentRequired | Public method and constructor comments are required | 109–117 |
| Rule | Violation | Line |
|---|---|---|
| ShortVariable | Avoid variables with short names like sb | 201 |
| ShortVariable | Avoid variables with short names like sb | 224 |
| AppendCharacterWithChar | Avoid appending characters as strings in StringBuffer.append. | 228 |
| AppendCharacterWithChar | Avoid appending characters as strings in StringBuffer.append. | 228 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 250 |
| Rule | Violation | Line |
|---|---|---|
| AssignmentToNonFinalStatic | Possible unsafe assignment to a non-final static field in a constructor. | 77 |
| CallSuperInConstructor | It is a good practice to call super() in a constructor | 83–86 |
| AvoidLiteralsInIfCondition | Avoid using Literals in Conditional Statements | 130 |
| AvoidLiteralsInIfCondition | Avoid using Literals in Conditional Statements | 130 |
| AvoidCatchingGenericException | Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 147 |
| NonThreadSafeSingleton | Singleton is not thread safe | 179–182 |
| CommentDefaultAccessModifier | To avoid mistakes add a comment at the beginning of the getRepositories method if you want a default access modifier | 200–225 |
| DefaultPackage | Use explicit scoping instead of the default package private level | 200–225 |
| AvoidReassigningLoopVariables | Avoid reassigning the loop control variable 'strOrganization' | 210 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 242–255 |
| CyclomaticComplexity | The method 'fillGitHubErrors(Component)' has a cyclomatic complexity of 10. | 267–303 |
| InsufficientStringBufferDeclaration | StringBuffer constructor is initialized with size 16, but has at least 31 characters appended. | 269 |
| AvoidDuplicateLiterals | The String literal "github" appears 4 times in this file; the first occurrence is on line 274 | 274 |
| Rule | Violation | Line |
|---|---|---|
| NonThreadSafeSingleton | Singleton is not thread safe | 114–117 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 147 |
| DefaultPackage | Use explicit scoping instead of the default package private level | 164–176 |
| CommentDefaultAccessModifier | To avoid mistakes add a comment at the beginning of the getGroup method if you want a default access modifier | 164–176 |
| Rule | Violation | Line |
|---|---|---|
| CommentRequired | Header comments are required | 36–43 |
| Rule | Violation | Line |
|---|---|---|
| CyclomaticComplexity | The method 'fill(Component, StringBuilder)' has a cyclomatic complexity of 11. | 120–206 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 122 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 141–148 |
| AvoidCatchingGenericException | Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 186 |
| InsufficientStringBufferDeclaration | StringBuffer constructor is initialized with size 16, but has at least 210 characters appended. | 216 |
| Rule | Violation | Line |
|---|---|---|
| CommentRequired | Header comments are required | 54–277 |
| ShortVariable | Avoid variables with short names like s | 245 |
| CommentRequired | Public method and constructor comments are required | 249–261 |
| CommentRequired | Public method and constructor comments are required | 263–275 |
| Rule | Violation | Line |
|---|---|---|
| ExcessiveImports | A high number of imports can indicate a high degree of coupling within an object. | 34–857 |
| GodClass | Possible God Class (WMC=83, ATFD=98, TCC=9.420%) | 73–857 |
| CyclomaticComplexity | The class 'MavenRepoService' has a total cyclomatic complexity of 83 (highest 12). | 73–857 |
| UseUnderscoresInNumericLiterals | Number 7200000L should separate every third digit with an underscore | 118 |
| AvoidStringBufferField | StringBuffers can grow quite a lot, and so may become a source of memory leak (if the owning class has a long life time). | 127 |
| AvoidSynchronizedAtMethodLevel | Use block level rather than method level synchronization | 142–156 |
| UseStringBufferForStringAppends | Prefer StringBuilder (non-synchronized) or StringBuffer (synchronized) over += for concatenating strings | 175 |
| ControlStatementBraces | This statement should have braces | 175 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 226 |
| LinguisticNaming | Linguistics Antipattern - The getter 'getPomInfos' should not return void linguistically | 447–494 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 485–493 |
| LinguisticNaming | Linguistics Antipattern - The getter 'getPomInfos' should not return void linguistically | 504–552 |
| CyclomaticComplexity | The method 'getSnapshotPomUrl(Component, StringBuilder, String)' has a cyclomatic complexity of 12. | 561–644 |
| UseStringBufferForStringAppends | Prefer StringBuilder (non-synchronized) or StringBuffer (synchronized) over += for concatenating strings | 629 |
| DefaultPackage | Use explicit scoping instead of the default package private level | 667–680 |
| CommentDefaultAccessModifier | To avoid mistakes add a comment at the beginning of the getAnchorsList2 method if you want a default access modifier | 667–680 |
| UseIndexOfChar | String.indexOf(char) is faster than String.indexOf(String). | 699 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 713–742 |
| CommentRequired | Public method and constructor comments are required | 773–776 |
| CommentRequired | Public method and constructor comments are required | 778–781 |
| AvoidSynchronizedAtMethodLevel | Use block level rather than method level synchronization | 778–781 |
| CommentRequired | Public method and constructor comments are required | 803–806 |
| Rule | Violation | Line |
|---|---|---|
| AvoidSynchronizedAtMethodLevel | Use block level rather than method level synchronization | 92–100 |
| NPathComplexity | The method 'getLuteceDependencies(Component, String, boolean, StringBuilder)' has an NPath complexity of 490 | 109–186 |
| LinguisticNaming | Linguistics Antipattern - The getter 'getLuteceDependencies' should not return void linguistically | 109–186 |
| CyclomaticComplexity | The method 'getLuteceDependencies(Component, String, boolean, StringBuilder)' has a cyclomatic complexity of 15. | 109–186 |
| ShortVariable | Avoid variables with short names like is | 117 |
| AppendCharacterWithChar | Avoid appending characters as strings in StringBuffer.append. | 184 |
| Rule | Violation | Line |
|---|---|---|
| CommentRequired | Header comments are required | 13–106 |
| CommentRequired | Public method and constructor comments are required | 25–31 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 37 |
| UseLocaleWithCaseConversions | When doing a String.toLowerCase()/toUpperCase() call, use a Locale | 48 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 57 |
| Rule | Violation | Line |
|---|---|---|
| ImmutableField | Private field '_sbScmUrl' could be made final; it is only initialized in the declaration or constructor. | 56 |
| AvoidStringBufferField | StringBuffers can grow quite a lot, and so may become a source of memory leak (if the owning class has a long life time). | 56 |
| ImmutableField | Private field '_sbScmConnection' could be made final; it is only initialized in the declaration or constructor. | 57 |
| AvoidStringBufferField | StringBuffers can grow quite a lot, and so may become a source of memory leak (if the owning class has a long life time). | 57 |
| AvoidStringBufferField | StringBuffers can grow quite a lot, and so may become a source of memory leak (if the owning class has a long life time). | 58 |
| ImmutableField | Private field '_sbScmDeveloperConnection' could be made final; it is only initialized in the declaration or constructor. | 58 |
| ShortVariable | Avoid variables with short names like ch | 228 |
| CyclomaticComplexity | The method 'characters(char, int, int)' has a cyclomatic complexity of 13. | 228–265 |
| PositionLiteralsFirstInComparisons | Position literals first in String comparisons | 238 |
| Rule | Violation | Line |
|---|---|---|
| AvoidSynchronizedAtMethodLevel | Use block level rather than method level synchronization | 98–106 |
| LinguisticNaming | Linguistics Antipattern - The getter 'getSiteInfos' should not return void linguistically | 116–224 |
| ExcessiveMethodLength | Avoid really long methods. | 116–224 |
| NPathComplexity | The method 'getSiteInfos(Component, String, String, StringBuilder)' has an NPath complexity of 4034 | 116–224 |
| CyclomaticComplexity | The method 'getSiteInfos(Component, String, String, StringBuilder)' has a cyclomatic complexity of 19. | 116–224 |
| ShortVariable | Avoid variables with short names like is | 126 |
| AvoidCatchingGenericException | Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 220 |
| Rule | Violation | Line |
|---|---|---|
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 126 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 144 |
| UselessStringValueOf | No need to call String.valueOf to append to a string. | 167 |
| Rule | Violation | Line |
|---|---|---|
| ShortVariable | Avoid variables with short names like ci | 56 |
| AvoidLiteralsInIfCondition | Avoid using Literals in Conditional Statements | 65 |
| AvoidLiteralsInIfCondition | Avoid using Literals in Conditional Statements | 70 |
| Rule | Violation | Line |
|---|---|---|
| CommentRequired | Public method and constructor comments are required | 90–103 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 131–138 |
| Rule | Violation | Line |
|---|---|---|
| CommentRequired | Public method and constructor comments are required | 132–141 |
| CommentRequired | Public method and constructor comments are required | 143–187 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 169–180 |
| AvoidCatchingGenericException | Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 182 |
| Rule | Violation | Line |
|---|---|---|
| MissingSerialVersionUID | Classes implementing Serializable should set a serialVersionUID | 39–45 |
| CommentRequired | Public method and constructor comments are required | 41–44 |
| Rule | Violation | Line |
|---|---|---|
| AbstractClassWithoutAbstractMethod | This abstract class does not have any abstract methods | 44–79 |
| Rule | Violation | Line |
|---|---|---|
| NPathComplexity | The method 'viewHome(HttpServletRequest)' has an NPath complexity of 69984 | 123–221 |
| NcssCount | The method 'viewHome(HttpServletRequest)' has a NCSS line count of 62. | 123–221 |
| CyclomaticComplexity | The method 'viewHome(HttpServletRequest)' has a cyclomatic complexity of 21. | 123–221 |
| UnnecessaryAnnotationValueElement | Avoid the use of value in annotations when its the only element | 230 |
| ShortVariable | Avoid variables with short names like c | 241 |
| NPathComplexity | The method 'getViewParameters(HttpServletRequest)' has an NPath complexity of 2187 | 332–375 |
| CyclomaticComplexity | The method 'getViewParameters(HttpServletRequest)' has a cyclomatic complexity of 15. | 332–375 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 392 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 393 |
| Rule | Violation | Line |
|---|---|---|
| RedundantFieldInitializer | Avoid using redundant field initializer for '_bGenerated' | 64 |
| CommentRequired | Public method and constructor comments are required | 85–94 |
| CommentRequired | Public method and constructor comments are required | 97–104 |
| CommentRequired | Public method and constructor comments are required | 107–110 |
| Rule | Violation | Line |
|---|---|---|
| CommentRequired | Public method and constructor comments are required | 82–91 |
| Rule | Violation | Line |
|---|---|---|
| ImmutableField | Private field '_lutecetoolsAsynchronousUploadHandler' could be made final; it is only initialized in the declaration or constructor. | 74 |
| CommentRequired | Public method and constructor comments are required | 102–132 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 106–129 |
| Rule | Violation | Line |
|---|---|---|
| ExcessiveImports | A high number of imports can indicate a high degree of coupling within an object. | 34–381 |
| CommentRequired | Public method and constructor comments are required | 104–121 |
| UseObjectForClearerAPI | Rather than using a lot of String arguments, consider using a container object for those values. | 183–185 |
| InsufficientStringBufferDeclaration | StringBuffer constructor is initialized with size 16, but has at least 45 characters appended. | 223 |
| AvoidCatchingGenericException | Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 239 |
| AvoidCatchingGenericException | Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 279 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 321 |
| Rule | Violation | Line |
|---|---|---|
| CommentRequired | Header comments are required | 36–59 |
| Rule | Violation | Line |
|---|---|---|
| CommentRequired | Public method and constructor comments are required | 73–103 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 79–100 |
| Rule | Violation | Line |
|---|---|---|
| UseVarargs | Consider using varargs for methods or constructors which take an array the last parameter. | 133 |
| Rule | Violation | Line |
|---|---|---|
| UnusedImports | Avoid unused imports such as 'java.io.FileNotFoundException' | 36 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| CommentRequired | Header comments are required | 3 | 42–100 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| ClassWithOnlyPrivateConstructorsShouldBeFinal | A class which only has private constructors should be final | 1 | 42–97 |
| CommentRequired | Header comments are required | 3 | 42–97 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| CommentRequired | Header comments are required | 3 | 40–82 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| ClassWithOnlyPrivateConstructorsShouldBeFinal | A class which only has private constructors should be final | 1 | 57–200 |
| FieldNamingConventions | The constant name '_mapper' doesn't match '[A-Z][A-Z_0-9]*' | 1 | 63 |
| AvoidCatchingGenericException | Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 3 | 193 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| CommentRequired | Public method and constructor comments are required | 3 | 109–117 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UseVarargs | Consider using varargs for methods or constructors which take an array the last parameter. | 4 | 133 |
| ShortVariable | Avoid variables with short names like sb | 3 | 201 |
| ShortVariable | Avoid variables with short names like sb | 3 | 224 |
| AppendCharacterWithChar | Avoid appending characters as strings in StringBuffer.append. | 3 | 228 |
| AppendCharacterWithChar | Avoid appending characters as strings in StringBuffer.append. | 3 | 228 |
| AvoidReassigningParameters | Avoid reassigning parameters such as 'site' | 2 | 241 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 3 | 250 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UnusedImports | Avoid unused imports such as 'java.io.FileNotFoundException' | 4 | 36 |
| AssignmentToNonFinalStatic | Possible unsafe assignment to a non-final static field in a constructor. | 3 | 77 |
| CallSuperInConstructor | It is a good practice to call super() in a constructor | 3 | 83–86 |
| AvoidLiteralsInIfCondition | Avoid using Literals in Conditional Statements | 3 | 130 |
| AvoidLiteralsInIfCondition | Avoid using Literals in Conditional Statements | 3 | 130 |
| AvoidCatchingGenericException | Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 3 | 147 |
| NonThreadSafeSingleton | Singleton is not thread safe | 3 | 179–182 |
| CommentDefaultAccessModifier | To avoid mistakes add a comment at the beginning of the getRepositories method if you want a default access modifier | 3 | 200–225 |
| DefaultPackage | Use explicit scoping instead of the default package private level | 3 | 200–225 |
| AvoidReassigningLoopVariables | Avoid reassigning the loop control variable 'strOrganization' | 3 | 210 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 3 | 242–255 |
| CyclomaticComplexity | The method 'fillGitHubErrors(Component)' has a cyclomatic complexity of 10. | 3 | 267–303 |
| InsufficientStringBufferDeclaration | StringBuffer constructor is initialized with size 16, but has at least 31 characters appended. | 3 | 269 |
| AvoidDuplicateLiterals | The String literal "github" appears 4 times in this file; the first occurrence is on line 274 | 3 | 274 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| NonThreadSafeSingleton | Singleton is not thread safe | 3 | 114–117 |
| GuardLogStatement | Logger calls should be surrounded by log level guards. | 2 | 146 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 3 | 147 |
| GuardLogStatement | Logger calls should be surrounded by log level guards. | 2 | 151 |
| DefaultPackage | Use explicit scoping instead of the default package private level | 3 | 164–176 |
| CommentDefaultAccessModifier | To avoid mistakes add a comment at the beginning of the getGroup method if you want a default access modifier | 3 | 164–176 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| CommentRequired | Header comments are required | 3 | 36–43 |
| ClassNamingConventions | The utility class name 'Globals' doesn't match '[A-Z][a-zA-Z0-9]+(Utils?|Helper|Home|Service)' | 1 | 36–43 |
| ClassWithOnlyPrivateConstructorsShouldBeFinal | A class which only has private constructors should be final | 1 | 36–43 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| CyclomaticComplexity | The method 'fill(Component, StringBuilder)' has a cyclomatic complexity of 11. | 3 | 120–206 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 122 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 3 | 141–148 |
| AvoidCatchingGenericException | Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 3 | 186 |
| InsufficientStringBufferDeclaration | StringBuffer constructor is initialized with size 16, but has at least 210 characters appended. | 3 | 216 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| CommentRequired | Header comments are required | 3 | 54–277 |
| ShortVariable | Avoid variables with short names like s | 3 | 245 |
| CommentRequired | Public method and constructor comments are required | 3 | 249–261 |
| CommentRequired | Public method and constructor comments are required | 3 | 263–275 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| ExcessiveImports | A high number of imports can indicate a high degree of coupling within an object. | 3 | 34–857 |
| GodClass | Possible God Class (WMC=83, ATFD=98, TCC=9.420%) | 3 | 73–857 |
| CyclomaticComplexity | The class 'MavenRepoService' has a total cyclomatic complexity of 83 (highest 12). | 3 | 73–857 |
| UseUnderscoresInNumericLiterals | Number 7200000L should separate every third digit with an underscore | 3 | 118 |
| AvoidStringBufferField | StringBuffers can grow quite a lot, and so may become a source of memory leak (if the owning class has a long life time). | 3 | 127 |
| AvoidSynchronizedAtMethodLevel | Use block level rather than method level synchronization | 3 | 142–156 |
| UseStringBufferForStringAppends | Prefer StringBuilder (non-synchronized) or StringBuffer (synchronized) over += for concatenating strings | 3 | 175 |
| ControlStatementBraces | This statement should have braces | 3 | 175 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 226 |
| LinguisticNaming | Linguistics Antipattern - The getter 'getPomInfos' should not return void linguistically | 3 | 447–494 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 3 | 485–493 |
| LinguisticNaming | Linguistics Antipattern - The getter 'getPomInfos' should not return void linguistically | 3 | 504–552 |
| CyclomaticComplexity | The method 'getSnapshotPomUrl(Component, StringBuilder, String)' has a cyclomatic complexity of 12. | 3 | 561–644 |
| UseStringBufferForStringAppends | Prefer StringBuilder (non-synchronized) or StringBuffer (synchronized) over += for concatenating strings | 3 | 629 |
| DefaultPackage | Use explicit scoping instead of the default package private level | 3 | 667–680 |
| CommentDefaultAccessModifier | To avoid mistakes add a comment at the beginning of the getAnchorsList2 method if you want a default access modifier | 3 | 667–680 |
| UseIndexOfChar | String.indexOf(char) is faster than String.indexOf(String). | 3 | 699 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 3 | 713–742 |
| CommentRequired | Public method and constructor comments are required | 3 | 773–776 |
| CommentRequired | Public method and constructor comments are required | 3 | 778–781 |
| AvoidSynchronizedAtMethodLevel | Use block level rather than method level synchronization | 3 | 778–781 |
| CommentRequired | Public method and constructor comments are required | 3 | 803–806 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| AvoidSynchronizedAtMethodLevel | Use block level rather than method level synchronization | 3 | 92–100 |
| NPathComplexity | The method 'getLuteceDependencies(Component, String, boolean, StringBuilder)' has an NPath complexity of 490 | 3 | 109–186 |
| LinguisticNaming | Linguistics Antipattern - The getter 'getLuteceDependencies' should not return void linguistically | 3 | 109–186 |
| CyclomaticComplexity | The method 'getLuteceDependencies(Component, String, boolean, StringBuilder)' has a cyclomatic complexity of 15. | 3 | 109–186 |
| ShortVariable | Avoid variables with short names like is | 3 | 117 |
| AppendCharacterWithChar | Avoid appending characters as strings in StringBuffer.append. | 3 | 184 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| CommentRequired | Header comments are required | 3 | 13–106 |
| CommentRequired | Public method and constructor comments are required | 3 | 25–31 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 37 |
| UseLocaleWithCaseConversions | When doing a String.toLowerCase()/toUpperCase() call, use a Locale | 3 | 48 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 3 | 57 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| ImmutableField | Private field '_sbScmUrl' could be made final; it is only initialized in the declaration or constructor. | 3 | 56 |
| AvoidStringBufferField | StringBuffers can grow quite a lot, and so may become a source of memory leak (if the owning class has a long life time). | 3 | 56 |
| ImmutableField | Private field '_sbScmConnection' could be made final; it is only initialized in the declaration or constructor. | 3 | 57 |
| AvoidStringBufferField | StringBuffers can grow quite a lot, and so may become a source of memory leak (if the owning class has a long life time). | 3 | 57 |
| AvoidStringBufferField | StringBuffers can grow quite a lot, and so may become a source of memory leak (if the owning class has a long life time). | 3 | 58 |
| ImmutableField | Private field '_sbScmDeveloperConnection' could be made final; it is only initialized in the declaration or constructor. | 3 | 58 |
| ShortVariable | Avoid variables with short names like ch | 3 | 228 |
| CyclomaticComplexity | The method 'characters(char, int, int)' has a cyclomatic complexity of 13. | 3 | 228–265 |
| PositionLiteralsFirstInComparisons | Position literals first in String comparisons | 3 | 238 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| AvoidSynchronizedAtMethodLevel | Use block level rather than method level synchronization | 3 | 98–106 |
| LinguisticNaming | Linguistics Antipattern - The getter 'getSiteInfos' should not return void linguistically | 3 | 116–224 |
| ExcessiveMethodLength | Avoid really long methods. | 3 | 116–224 |
| NPathComplexity | The method 'getSiteInfos(Component, String, String, StringBuilder)' has an NPath complexity of 4034 | 3 | 116–224 |
| CyclomaticComplexity | The method 'getSiteInfos(Component, String, String, StringBuilder)' has a cyclomatic complexity of 19. | 3 | 116–224 |
| ShortVariable | Avoid variables with short names like is | 3 | 126 |
| AvoidCatchingGenericException | Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 3 | 220 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 3 | 126 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 3 | 144 |
| UselessStringValueOf | No need to call String.valueOf to append to a string. | 3 | 167 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| ClassWithOnlyPrivateConstructorsShouldBeFinal | A class which only has private constructors should be final | 1 | 42–82 |
| ShortVariable | Avoid variables with short names like ci | 3 | 56 |
| AvoidLiteralsInIfCondition | Avoid using Literals in Conditional Statements | 3 | 65 |
| AvoidLiteralsInIfCondition | Avoid using Literals in Conditional Statements | 3 | 70 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| ClassWithOnlyPrivateConstructorsShouldBeFinal | A class which only has private constructors should be final | 1 | 62–160 |
| CommentRequired | Public method and constructor comments are required | 3 | 90–103 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 3 | 131–138 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| CommentRequired | Public method and constructor comments are required | 3 | 132–141 |
| CommentRequired | Public method and constructor comments are required | 3 | 143–187 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 3 | 169–180 |
| AvoidCatchingGenericException | Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 3 | 182 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| MissingSerialVersionUID | Classes implementing Serializable should set a serialVersionUID | 3 | 39–45 |
| CommentRequired | Public method and constructor comments are required | 3 | 41–44 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| AbstractClassWithoutAbstractMethod | This abstract class does not have any abstract methods | 3 | 44–79 |
| ClassWithOnlyPrivateConstructorsShouldBeFinal | A class which only has private constructors should be final | 1 | 44–79 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| NPathComplexity | The method 'viewHome(HttpServletRequest)' has an NPath complexity of 69984 | 3 | 123–221 |
| NcssCount | The method 'viewHome(HttpServletRequest)' has a NCSS line count of 62. | 3 | 123–221 |
| CyclomaticComplexity | The method 'viewHome(HttpServletRequest)' has a cyclomatic complexity of 21. | 3 | 123–221 |
| UnnecessaryAnnotationValueElement | Avoid the use of value in annotations when its the only element | 3 | 230 |
| ShortVariable | Avoid variables with short names like c | 3 | 241 |
| NPathComplexity | The method 'getViewParameters(HttpServletRequest)' has an NPath complexity of 2187 | 3 | 332–375 |
| CyclomaticComplexity | The method 'getViewParameters(HttpServletRequest)' has a cyclomatic complexity of 15. | 3 | 332–375 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 3 | 392 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 3 | 393 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| RedundantFieldInitializer | Avoid using redundant field initializer for '_bGenerated' | 3 | 64 |
| CommentRequired | Public method and constructor comments are required | 3 | 85–94 |
| CommentRequired | Public method and constructor comments are required | 3 | 97–104 |
| CommentRequired | Public method and constructor comments are required | 3 | 107–110 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| CommentRequired | Public method and constructor comments are required | 3 | 82–91 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| ImmutableField | Private field '_lutecetoolsAsynchronousUploadHandler' could be made final; it is only initialized in the declaration or constructor. | 3 | 74 |
| CommentRequired | Public method and constructor comments are required | 3 | 102–132 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 3 | 106–129 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| ExcessiveImports | A high number of imports can indicate a high degree of coupling within an object. | 3 | 34–381 |
| FieldNamingConventions | The constant name '_mapper' doesn't match '[A-Z][A-Z_0-9]*' | 1 | 100 |
| CommentRequired | Public method and constructor comments are required | 3 | 104–121 |
| UseObjectForClearerAPI | Rather than using a lot of String arguments, consider using a container object for those values. | 3 | 183–185 |
| InsufficientStringBufferDeclaration | StringBuffer constructor is initialized with size 16, but has at least 45 characters appended. | 3 | 223 |
| AvoidCatchingGenericException | Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 3 | 239 |
| AvoidCatchingGenericException | Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 3 | 279 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 3 | 321 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| ClassNamingConventions | The utility class name 'Constants' doesn't match '[A-Z][a-zA-Z0-9]+(Utils?|Helper|Home|Service)' | 1 | 36–59 |
| CommentRequired | Header comments are required | 3 | 36–59 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| FieldNamingConventions | The constant name '_mapper' doesn't match '[A-Z][A-Z_0-9]*' | 1 | 64 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| FieldNamingConventions | The constant name '_mapper' doesn't match '[A-Z][A-Z_0-9]*' | 1 | 69 |
| CommentRequired | Public method and constructor comments are required | 3 | 73–103 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 3 | 79–100 |
