The following document contains the results of PMD 5.5.1.
| Violation | Line |
|---|---|
| Avoid unused imports such as 'javax.validation.constraints' | 36 |
| Avoid unused imports such as 'org.hibernate.validator.constraints' | 38 |
| Violation | Line |
|---|---|
| Avoid unused imports such as 'java.sql.Date' | 37 |
| Avoid unused imports such as 'java.sql.Date' | 37 |
| Violation | Line |
|---|---|
| Avoid throwing raw exception types. | 112 |
| Avoid throwing raw exception types. | 171 |
| Violation | Line |
|---|---|
| Avoid unused imports such as 'javax.validation.constraints' | 36 |
| Avoid unused imports such as 'org.hibernate.validator.constraints' | 38 |
| Violation | Line |
|---|---|
| The class 'ResourceDAO' has a Cyclomatic Complexity of 3 (Highest = 14). | 46–448 |
| The class 'ResourceDAO' has a Modified Cyclomatic Complexity of 3 (Highest = 14). | 46–448 |
| The class 'ResourceDAO' has a Standard Cyclomatic Complexity of 3 (Highest = 14). | 46–448 |
| Avoid unused private fields such as 'CONSTANT_ORDER_BY'. | 70 |
| Avoid unused private fields such as 'CONSTANT_PERCENT'. | 71 |
| Avoid unused private fields such as 'CONSTANT_QUESTION_MARK'. | 72 |
| Avoid unused private fields such as 'CONSTANT_COMMA'. | 73 |
| Avoid unused private fields such as 'CONSTANT_CLOSE_PARENTHESIS'. | 74 |
| Avoid unused private fields such as 'CONSTANT_ASC'. | 75 |
| Avoid unused private fields such as 'CONSTANT_DESC'. | 76 |
| The method 'getSqlQueryFromFilter' has a Standard Cyclomatic Complexity of 14. | 317–373 |
| The method getSqlQueryFromFilter() has an NPath complexity of 93312 | 317–373 |
| The method 'getSqlQueryFromFilter' has a Cyclomatic Complexity of 14. | 317–373 |
| The method 'getSqlQueryFromFilter' has a Modified Cyclomatic Complexity of 14. | 317–373 |
| Violation | Line |
|---|---|
| Avoid variables with short names like rt | 57 |
| Avoid variables with short names like p | 63 |
| Violation | Line |
|---|---|
| Singleton is not thread safe | 52–57 |
| Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 79 |
| Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 102 |
| Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 131 |
| Violation | Line |
|---|---|
| Avoid modifiers which are implied by the context | 46 |
| Avoid modifiers which are implied by the context | 64 |
| Violation | Line |
|---|---|
| Avoid unused imports such as 'fr.paris.lutece.plugins.workflowcore.business.workflow.WorkflowFilter' | 48 |
| Avoid unused imports such as 'fr.paris.lutece.plugins.workflowcore.business.workflow.WorkflowFilter' | 48 |
| Singleton is not thread safe | 67–72 |
| Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 111 |
| Violation | Line |
|---|---|
| The class 'ConfigJspBean' has a Modified Cyclomatic Complexity of 5 (Highest = 23). | 71–623 |
| The class 'ConfigJspBean' has a Standard Cyclomatic Complexity of 5 (Highest = 23). | 71–623 |
| The class 'ConfigJspBean' has a Cyclomatic Complexity of 7 (Highest = 35). | 71–623 |
| Avoid unused private fields such as 'MARK_RESOURCEFORM_LIST'. | 122 |
| Avoid unused private fields such as 'MARK_RESOURCEFORM_CONFIG_LIST'. | 123 |
| Private field '_actionService' could be made final; it is only initialized in the declaration or constructor. | 135 |
| Assigning an Object to null is a code smell. Consider refactoring. | 148 |
| The method 'getCreateConfig' has a Modified Cyclomatic Complexity of 15. | 171–261 |
| The method getCreateConfig() has an NPath complexity of 3920 | 171–261 |
| The method 'getCreateConfig' has a Standard Cyclomatic Complexity of 15. | 171–261 |
| The method 'getCreateConfig' has a Cyclomatic Complexity of 22. | 171–261 |
| Avoid using if statements without curly braces | 193–194 |
| Avoid really long methods. | 350–499 |
| The method 'getModifyConfig' has a Cyclomatic Complexity of 35. | 350–499 |
| The method 'getModifyConfig' has a Standard Cyclomatic Complexity of 23. | 350–499 |
| The method getModifyConfig() has an NPath complexity of 27930 | 350–499 |
| The method 'getModifyConfig' has a Modified Cyclomatic Complexity of 23. | 350–499 |
| Avoid declaring a variable if it is unreferenced before a possible exit point. | 353 |
| Avoid declaring a variable if it is unreferenced before a possible exit point. | 355 |
| Avoid declaring a variable if it is unreferenced before a possible exit point. | 356 |
| Avoid declaring a variable if it is unreferenced before a possible exit point. | 357 |
| Avoid declaring a variable if it is unreferenced before a possible exit point. | 358 |
| Avoid unused local variables such as 'removedAction'. | 358 |
| Avoid declaring a variable if it is unreferenced before a possible exit point. | 360 |
| Avoid using if statements without curly braces | 379–380 |
| Avoid using a branching statement as the last in a loop. | 421 |
| Avoid using if statements without curly braces | 616–617 |
| Violation | Line |
|---|---|
| Abstract classes should be named AbstractXXX | 53–111 |
| Perhaps '_nDefaultItemsPerPage' could be replaced by a local variable. | 70 |
| Do not add empty strings | 101 |
| Violation | Line |
|---|---|
| Assigning an Object to null is a code smell. Consider refactoring. | 110 |
| Violation | Line |
|---|---|
| Abstract classes should be named AbstractXXX | 53–111 |
| Perhaps '_nDefaultItemsPerPage' could be replaced by a local variable. | 70 |
| Do not add empty strings | 101 |
| Violation | Line |
|---|---|
| Abstract classes should be named AbstractXXX | 53–110 |
| Perhaps '_nDefaultItemsPerPage' could be replaced by a local variable. | 69 |
| Do not add empty strings | 100 |
| Violation | Line |
|---|---|
| Avoid unused private fields such as 'TEMPLATE_CREATE_RESOURCE'. | 71 |
| Avoid unused private fields such as 'PROPERTY_PAGE_TITLE_CREATE_RESOURCE'. | 81 |
| Avoid unused private fields such as 'VALIDATION_ATTRIBUTES_PREFIX'. | 94 |
| Avoid unused private fields such as 'VIEW_CREATE_RESOURCE'. | 98 |
| Assigning an Object to null is a code smell. Consider refactoring. | 123 |
| Avoid using if statements without curly braces | 144–145 |
| Deeply nested if..then statements are hard to read | 144–145 |
| If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 205 |
| Avoid declaring a variable if it is unreferenced before a possible exit point. | 239 |
| Avoid unused local variables such as 'resource'. | 239 |
| Deeply nested if..then statements are hard to read | 249–252 |
| If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 267 |
