The following document contains the results of SpotBugs
SpotBugs Version is 4.5.3
Threshold is medium
Effort is default
Classes | Bugs | Errors | Missing Classes |
---|---|---|---|
27 | 81 | 0 | 0 |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
Inconsistent synchronization of com.tvnavig.server.asset.service.common.MetaValueResult.id; locked 60% of time | MT_CORRECTNESS | IS2_INCONSISTENT_SYNC | 79 | Medium |
Inconsistent synchronization of com.tvnavig.server.asset.service.common.MetaValueResult.metaDataId; locked 60% of time | MT_CORRECTNESS | IS2_INCONSISTENT_SYNC | 89 | Medium |
Inconsistent synchronization of com.tvnavig.server.asset.service.common.MetaValueResult.value; locked 60% of time | MT_CORRECTNESS | IS2_INCONSISTENT_SYNC | 109 | Medium |
Public static com.tvnavig.server.asset.service.common.MetaValueResult.getTypeDesc() may expose internal representation by returning MetaValueResult.typeDesc | MALICIOUS_CODE | MS_EXPOSE_REP | 197 | Medium |
Redundant nullcheck of obj, which is known to be non-null in com.tvnavig.server.asset.service.common.MetaValueResult.equals(Object) | STYLE | RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE | 126 | High |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
Dead store to other in com.tvnavig.server.searchengine.SearchAssetServiceException.equals(Object) | STYLE | DLS_DEAD_LOCAL_STORE | 56 | Medium |
Public static com.tvnavig.server.searchengine.SearchAssetServiceException.getTypeDesc() may expose internal representation by returning SearchAssetServiceException.typeDesc | MALICIOUS_CODE | MS_EXPOSE_REP | 92 | Medium |
Redundant nullcheck of obj, which is known to be non-null in com.tvnavig.server.searchengine.SearchAssetServiceException.equals(Object) | STYLE | RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE | 57 | High |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
com.tvnavig.server.searchengine.SearchAssetServiceSoapBindingStub.getAsset(int, int) invokes inefficient new Integer(int) constructor; use Integer.valueOf(int) instead | PERFORMANCE | DM_NUMBER_CTOR | 295 | Medium |
com.tvnavig.server.searchengine.SearchAssetServiceSoapBindingStub.getAssetPlayer(int) invokes inefficient new Integer(int) constructor; use Integer.valueOf(int) instead | PERFORMANCE | DM_NUMBER_CTOR | 373 | Medium |
com.tvnavig.server.searchengine.SearchAssetServiceSoapBindingStub.getAssetsList(int, String, MetaValueResult[], Calendar, Calendar, String) invokes inefficient new Integer(int) constructor; use Integer.valueOf(int) instead | PERFORMANCE | DM_NUMBER_CTOR | 334 | Medium |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
com.tvnavig.server.searchengine.service.common.AssetOGC.getCreationDate() may expose internal representation by returning AssetOGC.creationDate | MALICIOUS_CODE | EI_EXPOSE_REP | 117 | Medium |
com.tvnavig.server.searchengine.service.common.AssetOGC.getFormats() may expose internal representation by returning AssetOGC.formats | MALICIOUS_CODE | EI_EXPOSE_REP | 157 | Medium |
com.tvnavig.server.searchengine.service.common.AssetOGC.getMetaValues() may expose internal representation by returning AssetOGC.metaValues | MALICIOUS_CODE | EI_EXPOSE_REP | 177 | Medium |
new com.tvnavig.server.searchengine.service.common.AssetOGC(int, Calendar, String, String[], MetaValueResult[], String, String, String, String) may expose internal representation by storing an externally mutable object into AssetOGC.creationDate | MALICIOUS_CODE | EI_EXPOSE_REP2 | 81 | Medium |
new com.tvnavig.server.searchengine.service.common.AssetOGC(int, Calendar, String, String[], MetaValueResult[], String, String, String, String) may expose internal representation by storing an externally mutable object into AssetOGC.formats | MALICIOUS_CODE | EI_EXPOSE_REP2 | 83 | Medium |
new com.tvnavig.server.searchengine.service.common.AssetOGC(int, Calendar, String, String[], MetaValueResult[], String, String, String, String) may expose internal representation by storing an externally mutable object into AssetOGC.metaValues | MALICIOUS_CODE | EI_EXPOSE_REP2 | 84 | Medium |
com.tvnavig.server.searchengine.service.common.AssetOGC.setCreationDate(Calendar) may expose internal representation by storing an externally mutable object into AssetOGC.creationDate | MALICIOUS_CODE | EI_EXPOSE_REP2 | 127 | Medium |
com.tvnavig.server.searchengine.service.common.AssetOGC.setFormats(String[]) may expose internal representation by storing an externally mutable object into AssetOGC.formats | MALICIOUS_CODE | EI_EXPOSE_REP2 | 167 | Medium |
com.tvnavig.server.searchengine.service.common.AssetOGC.setMetaValues(MetaValueResult[]) may expose internal representation by storing an externally mutable object into AssetOGC.metaValues | MALICIOUS_CODE | EI_EXPOSE_REP2 | 187 | Medium |
Inconsistent synchronization of com.tvnavig.server.searchengine.service.common.AssetOGC.creationDate; locked 60% of time | MT_CORRECTNESS | IS2_INCONSISTENT_SYNC | 127 | Medium |
Inconsistent synchronization of com.tvnavig.server.searchengine.service.common.AssetOGC.description; locked 60% of time | MT_CORRECTNESS | IS2_INCONSISTENT_SYNC | 137 | Medium |
Inconsistent synchronization of com.tvnavig.server.searchengine.service.common.AssetOGC.formats; locked 60% of time | MT_CORRECTNESS | IS2_INCONSISTENT_SYNC | 157 | Medium |
Inconsistent synchronization of com.tvnavig.server.searchengine.service.common.AssetOGC.metaValues; locked 60% of time | MT_CORRECTNESS | IS2_INCONSISTENT_SYNC | 177 | Medium |
Inconsistent synchronization of com.tvnavig.server.searchengine.service.common.AssetOGC.previewURL; locked 60% of time | MT_CORRECTNESS | IS2_INCONSISTENT_SYNC | 207 | Medium |
Inconsistent synchronization of com.tvnavig.server.searchengine.service.common.AssetOGC.thumbnail; locked 60% of time | MT_CORRECTNESS | IS2_INCONSISTENT_SYNC | 217 | Medium |
Inconsistent synchronization of com.tvnavig.server.searchengine.service.common.AssetOGC.title; locked 60% of time | MT_CORRECTNESS | IS2_INCONSISTENT_SYNC | 247 | Medium |
Inconsistent synchronization of com.tvnavig.server.searchengine.service.common.AssetOGC.videoURL; locked 60% of time | MT_CORRECTNESS | IS2_INCONSISTENT_SYNC | 257 | Medium |
Public static com.tvnavig.server.searchengine.service.common.AssetOGC.getTypeDesc() may expose internal representation by returning AssetOGC.typeDesc | MALICIOUS_CODE | MS_EXPOSE_REP | 429 | Medium |
Redundant nullcheck of obj, which is known to be non-null in com.tvnavig.server.searchengine.service.common.AssetOGC.equals(Object) | STYLE | RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE | 274 | High |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
Inconsistent synchronization of com.tvnavig.server.searchengine.service.common.AssetPlayer.htmlEmbed; locked 60% of time | MT_CORRECTNESS | IS2_INCONSISTENT_SYNC | 65 | Medium |
Inconsistent synchronization of com.tvnavig.server.searchengine.service.common.AssetPlayer.thumbnail; locked 60% of time | MT_CORRECTNESS | IS2_INCONSISTENT_SYNC | 85 | Medium |
Public static com.tvnavig.server.searchengine.service.common.AssetPlayer.getTypeDesc() may expose internal representation by returning AssetPlayer.typeDesc | MALICIOUS_CODE | MS_EXPOSE_REP | 161 | Medium |
Redundant nullcheck of obj, which is known to be non-null in com.tvnavig.server.searchengine.service.common.AssetPlayer.equals(Object) | STYLE | RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE | 102 | High |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
Dead store to other in com.tvnavig.server.user.UserServiceException.equals(Object) | STYLE | DLS_DEAD_LOCAL_STORE | 56 | Medium |
Public static com.tvnavig.server.user.UserServiceException.getTypeDesc() may expose internal representation by returning UserServiceException.typeDesc | MALICIOUS_CODE | MS_EXPOSE_REP | 92 | Medium |
Redundant nullcheck of obj, which is known to be non-null in com.tvnavig.server.user.UserServiceException.equals(Object) | STYLE | RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE | 57 | High |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
com.tvnavig.server.user.UserServiceSoapBindingStub.getDomainsFromUser(int) invokes inefficient new Integer(int) constructor; use Integer.valueOf(int) instead | PERFORMANCE | DM_NUMBER_CTOR | 378 | Medium |
com.tvnavig.server.user.UserServiceSoapBindingStub.getGroupsandMetaDatasFromDomain(int) invokes inefficient new Integer(int) constructor; use Integer.valueOf(int) instead | PERFORMANCE | DM_NUMBER_CTOR | 417 | Medium |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
com.tvnavig.server.user.service.common.MetaDataResult.getValueList() may expose internal representation by returning MetaDataResult.valueList | MALICIOUS_CODE | EI_EXPOSE_REP | 133 | Medium |
new com.tvnavig.server.user.service.common.MetaDataResult(int, String, int, String[]) may expose internal representation by storing an externally mutable object into MetaDataResult.valueList | MALICIOUS_CODE | EI_EXPOSE_REP2 | 63 | Medium |
com.tvnavig.server.user.service.common.MetaDataResult.setValueList(String[]) may expose internal representation by storing an externally mutable object into MetaDataResult.valueList | MALICIOUS_CODE | EI_EXPOSE_REP2 | 143 | Medium |
Inconsistent synchronization of com.tvnavig.server.user.service.common.MetaDataResult.name; locked 60% of time | MT_CORRECTNESS | IS2_INCONSISTENT_SYNC | 93 | Medium |
Inconsistent synchronization of com.tvnavig.server.user.service.common.MetaDataResult.valueList; locked 60% of time | MT_CORRECTNESS | IS2_INCONSISTENT_SYNC | 133 | Medium |
Public static com.tvnavig.server.user.service.common.MetaDataResult.getTypeDesc() may expose internal representation by returning MetaDataResult.typeDesc | MALICIOUS_CODE | MS_EXPOSE_REP | 233 | Medium |
Redundant nullcheck of obj, which is known to be non-null in com.tvnavig.server.user.service.common.MetaDataResult.equals(Object) | STYLE | RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE | 150 | High |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
Inconsistent synchronization of com.tvnavig.server.user.service.common.UserDomainResult.id; locked 60% of time | MT_CORRECTNESS | IS2_INCONSISTENT_SYNC | 75 | Medium |
Inconsistent synchronization of com.tvnavig.server.user.service.common.UserDomainResult.name; locked 60% of time | MT_CORRECTNESS | IS2_INCONSISTENT_SYNC | 85 | Medium |
Public static com.tvnavig.server.user.service.common.UserDomainResult.getTypeDesc() may expose internal representation by returning UserDomainResult.typeDesc | MALICIOUS_CODE | MS_EXPOSE_REP | 161 | Medium |
Redundant nullcheck of obj, which is known to be non-null in com.tvnavig.server.user.service.common.UserDomainResult.equals(Object) | STYLE | RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE | 102 | High |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
Inconsistent synchronization of com.tvnavig.server.user.service.common.UserGroupResult.description; locked 60% of time | MT_CORRECTNESS | IS2_INCONSISTENT_SYNC | 79 | Medium |
Inconsistent synchronization of com.tvnavig.server.user.service.common.UserGroupResult.groupId; locked 60% of time | MT_CORRECTNESS | IS2_INCONSISTENT_SYNC | 89 | Medium |
Inconsistent synchronization of com.tvnavig.server.user.service.common.UserGroupResult.name; locked 60% of time | MT_CORRECTNESS | IS2_INCONSISTENT_SYNC | 109 | Medium |
Public static com.tvnavig.server.user.service.common.UserGroupResult.getTypeDesc() may expose internal representation by returning UserGroupResult.typeDesc | MALICIOUS_CODE | MS_EXPOSE_REP | 197 | Medium |
Redundant nullcheck of obj, which is known to be non-null in com.tvnavig.server.user.service.common.UserGroupResult.equals(Object) | STYLE | RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE | 126 | High |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
com.tvnavig.server.user.service.common.UserGroupandMetaDataResult.getMetaDataList() may expose internal representation by returning UserGroupandMetaDataResult.metaDataList | MALICIOUS_CODE | EI_EXPOSE_REP | 65 | Medium |
com.tvnavig.server.user.service.common.UserGroupandMetaDataResult.getUserGroupList() may expose internal representation by returning UserGroupandMetaDataResult.userGroupList | MALICIOUS_CODE | EI_EXPOSE_REP | 85 | Medium |
new com.tvnavig.server.user.service.common.UserGroupandMetaDataResult(MetaDataResult[], UserGroupResult[]) may expose internal representation by storing an externally mutable object into UserGroupandMetaDataResult.metaDataList | MALICIOUS_CODE | EI_EXPOSE_REP2 | 54 | Medium |
new com.tvnavig.server.user.service.common.UserGroupandMetaDataResult(MetaDataResult[], UserGroupResult[]) may expose internal representation by storing an externally mutable object into UserGroupandMetaDataResult.userGroupList | MALICIOUS_CODE | EI_EXPOSE_REP2 | 55 | Medium |
com.tvnavig.server.user.service.common.UserGroupandMetaDataResult.setMetaDataList(MetaDataResult[]) may expose internal representation by storing an externally mutable object into UserGroupandMetaDataResult.metaDataList | MALICIOUS_CODE | EI_EXPOSE_REP2 | 75 | Medium |
com.tvnavig.server.user.service.common.UserGroupandMetaDataResult.setUserGroupList(UserGroupResult[]) may expose internal representation by storing an externally mutable object into UserGroupandMetaDataResult.userGroupList | MALICIOUS_CODE | EI_EXPOSE_REP2 | 95 | Medium |
Inconsistent synchronization of com.tvnavig.server.user.service.common.UserGroupandMetaDataResult.metaDataList; locked 60% of time | MT_CORRECTNESS | IS2_INCONSISTENT_SYNC | 65 | Medium |
Inconsistent synchronization of com.tvnavig.server.user.service.common.UserGroupandMetaDataResult.userGroupList; locked 60% of time | MT_CORRECTNESS | IS2_INCONSISTENT_SYNC | 85 | Medium |
Public static com.tvnavig.server.user.service.common.UserGroupandMetaDataResult.getTypeDesc() may expose internal representation by returning UserGroupandMetaDataResult.typeDesc | MALICIOUS_CODE | MS_EXPOSE_REP | 177 | Medium |
Redundant nullcheck of obj, which is known to be non-null in com.tvnavig.server.user.service.common.UserGroupandMetaDataResult.equals(Object) | STYLE | RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE | 102 | High |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
Inconsistent synchronization of com.tvnavig.server.user.service.common.UserServiceResult.email; locked 60% of time | MT_CORRECTNESS | IS2_INCONSISTENT_SYNC | 87 | Medium |
Inconsistent synchronization of com.tvnavig.server.user.service.common.UserServiceResult.firstName; locked 60% of time | MT_CORRECTNESS | IS2_INCONSISTENT_SYNC | 97 | Medium |
Inconsistent synchronization of com.tvnavig.server.user.service.common.UserServiceResult.lastName; locked 60% of time | MT_CORRECTNESS | IS2_INCONSISTENT_SYNC | 117 | Medium |
Inconsistent synchronization of com.tvnavig.server.user.service.common.UserServiceResult.login; locked 60% of time | MT_CORRECTNESS | IS2_INCONSISTENT_SYNC | 137 | Medium |
Inconsistent synchronization of com.tvnavig.server.user.service.common.UserServiceResult.userId; locked 60% of time | MT_CORRECTNESS | IS2_INCONSISTENT_SYNC | 167 | Medium |
Public static com.tvnavig.server.user.service.common.UserServiceResult.getTypeDesc() may expose internal representation by returning UserServiceResult.typeDesc | MALICIOUS_CODE | MS_EXPOSE_REP | 269 | Medium |
Redundant nullcheck of obj, which is known to be non-null in com.tvnavig.server.user.service.common.UserServiceResult.equals(Object) | STYLE | RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE | 174 | High |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
com.tvnavig.server.util.ServiceException.getError() may expose internal representation by returning ServiceException.error | MALICIOUS_CODE | EI_EXPOSE_REP | 61 | Medium |
new com.tvnavig.server.util.ServiceException(String[]) may expose internal representation by storing an externally mutable object into ServiceException.error | MALICIOUS_CODE | EI_EXPOSE_REP2 | 51 | Medium |
com.tvnavig.server.util.ServiceException.setError(String[]) may expose internal representation by storing an externally mutable object into ServiceException.error | MALICIOUS_CODE | EI_EXPOSE_REP2 | 71 | Medium |
Inconsistent synchronization of com.tvnavig.server.util.ServiceException.error; locked 60% of time | MT_CORRECTNESS | IS2_INCONSISTENT_SYNC | 61 | Medium |
Public static com.tvnavig.server.util.ServiceException.getTypeDesc() may expose internal representation by returning ServiceException.typeDesc | MALICIOUS_CODE | MS_EXPOSE_REP | 133 | Medium |
Redundant nullcheck of obj, which is known to be non-null in com.tvnavig.server.util.ServiceException.equals(Object) | STYLE | RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE | 78 | High |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
Write to static field fr.paris.lutece.plugins.parisvideo.service.SingleSessionHttpTransport.uniqueCookie1 from instance method fr.paris.lutece.plugins.parisvideo.service.SingleSessionHttpTransport.processReturnedMessageContext(MessageContext) | STYLE | ST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD | 64 | High |
Write to static field fr.paris.lutece.plugins.parisvideo.service.SingleSessionHttpTransport.uniqueCookie2 from instance method fr.paris.lutece.plugins.parisvideo.service.SingleSessionHttpTransport.processReturnedMessageContext(MessageContext) | STYLE | ST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD | 65 | High |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
Useless object stored in variable model of method fr.paris.lutece.plugins.parisvideo.web.ParisvideoJspBean.doVideoChoose(HttpServletRequest) | STYLE | UC_USELESS_OBJECT | 229 | Medium |