FindBugs Bug Detector Report
The following document contains the results of FindBugs
FindBugs Version is 3.0.1
Threshold is
Effort is max
Summary
| Classes |
Bugs |
Errors |
Missing Classes |
| 92 |
23 |
0 |
0 |
fr.paris.lutece.plugins.participatoryideation.business.proposal.Proposal
| Bug |
Category |
Details |
Line |
Priority |
| fr.paris.lutece.plugins.participatoryideation.business.proposal.Proposal.getCreationTimestamp() may expose internal representation by returning Proposal._creationTimestamp |
MALICIOUS_CODE |
EI_EXPOSE_REP |
701 |
Medium |
| fr.paris.lutece.plugins.participatoryideation.business.proposal.Proposal.setCreationTimestamp(Timestamp) may expose internal representation by storing an externally mutable object into Proposal._creationTimestamp |
MALICIOUS_CODE |
EI_EXPOSE_REP2 |
710 |
Medium |
fr.paris.lutece.plugins.participatoryideation.business.proposal.ProposalHome
| Bug |
Category |
Details |
Line |
Priority |
| Switch statement found in fr.paris.lutece.plugins.participatoryideation.business.proposal.ProposalHome.getSubProposalsNicknames(int, ProposalHome$GetSubProposalsMethod, String) where default case is missing |
STYLE |
SF_SWITCH_NO_DEFAULT |
288-300 |
Medium |
| Switch statement found in fr.paris.lutece.plugins.participatoryideation.business.proposal.ProposalHome.getSubProposalsNicknamesNiceText(int, ProposalHome$GetSubProposalsMethod, String) where default case is missing |
STYLE |
SF_SWITCH_NO_DEFAULT |
327-339 |
Medium |
fr.paris.lutece.plugins.participatoryideation.service.IdeationSolrAddon
| Bug |
Category |
Details |
Line |
Priority |
| fr.paris.lutece.plugins.participatoryideation.service.IdeationSolrAddon.getGeolocModel(List) makes inefficient use of keySet iterator instead of entrySet iterator |
PERFORMANCE |
WMI_WRONG_MAP_ITERATOR |
105 |
Medium |
fr.paris.lutece.plugins.participatoryideation.service.ProposalService
| Bug |
Category |
Details |
Line |
Priority |
| Incorrect lazy initialization of static field fr.paris.lutece.plugins.participatoryideation.service.ProposalService._singleton in fr.paris.lutece.plugins.participatoryideation.service.ProposalService.getInstance() |
MT_CORRECTNESS |
LI_LAZY_INIT_STATIC |
99-101 |
Medium |
fr.paris.lutece.plugins.participatoryideation.service.SolrProposalIndexer
| Bug |
Category |
Details |
Line |
Priority |
| fr.paris.lutece.plugins.participatoryideation.service.SolrProposalIndexer.solrItem2SolrInputDocument(SolrItem) makes inefficient use of keySet iterator instead of entrySet iterator |
PERFORMANCE |
WMI_WRONG_MAP_ITERATOR |
421 |
Medium |
fr.paris.lutece.plugins.participatoryideation.service.notify.TaskNotifyIdeation
| Bug |
Category |
Details |
Line |
Priority |
| Nullcheck of resourceHistory at line 135 of value previously dereferenced in fr.paris.lutece.plugins.participatoryideation.service.notify.TaskNotifyIdeation.processTask(int, HttpServletRequest, Locale) |
CORRECTNESS |
RCN_REDUNDANT_NULLCHECK_WOULD_HAVE_BEEN_A_NPE |
135 |
Medium |
fr.paris.lutece.plugins.participatoryideation.service.subscription.IdeationSubscriptionProviderService
| Bug |
Category |
Details |
Line |
Priority |
| Incorrect lazy initialization of static field fr.paris.lutece.plugins.participatoryideation.service.subscription.IdeationSubscriptionProviderService._instance in fr.paris.lutece.plugins.participatoryideation.service.subscription.IdeationSubscriptionProviderService.getService() |
MT_CORRECTNESS |
LI_LAZY_INIT_STATIC |
84-88 |
Medium |
| fr.paris.lutece.plugins.participatoryideation.service.subscription.IdeationSubscriptionProviderService.TAB_SUBSCRIPTIONS should be package protected |
MALICIOUS_CODE |
MS_PKGPROTECT |
66 |
Medium |
fr.paris.lutece.plugins.participatoryideation.util.CsvUtils
| Bug |
Category |
Details |
Line |
Priority |
| Dead store to fieldsArray in fr.paris.lutece.plugins.participatoryideation.util.CsvUtils.writeCsv(String, List, OutputStream, Locale) |
STYLE |
DLS_DEAD_LOCAL_STORE |
176 |
Medium |
fr.paris.lutece.plugins.participatoryideation.web.IdeationApp
| Bug |
Category |
Details |
Line |
Priority |
| Class fr.paris.lutece.plugins.participatoryideation.web.IdeationApp defines non-transient non-serializable instance field _formEtapeApprox |
BAD_PRACTICE |
SE_BAD_FIELD |
Not available |
Medium |
| Class fr.paris.lutece.plugins.participatoryideation.web.IdeationApp defines non-transient non-serializable instance field _formEtapeDescription |
BAD_PRACTICE |
SE_BAD_FIELD |
Not available |
Medium |
| Class fr.paris.lutece.plugins.participatoryideation.web.IdeationApp defines non-transient non-serializable instance field _formEtapeLocation |
BAD_PRACTICE |
SE_BAD_FIELD |
Not available |
Medium |
| Class fr.paris.lutece.plugins.participatoryideation.web.IdeationApp defines non-transient non-serializable instance field _formEtapeRecap |
BAD_PRACTICE |
SE_BAD_FIELD |
Not available |
Medium |
| Class fr.paris.lutece.plugins.participatoryideation.web.IdeationApp defines non-transient non-serializable instance field _formEtapeTitle |
BAD_PRACTICE |
SE_BAD_FIELD |
Not available |
Medium |
| Class fr.paris.lutece.plugins.participatoryideation.web.IdeationApp defines non-transient non-serializable instance field _formEtapeUpload |
BAD_PRACTICE |
SE_BAD_FIELD |
Not available |
Medium |
fr.paris.lutece.plugins.participatoryideation.web.ProposalJspBean
| Bug |
Category |
Details |
Line |
Priority |
| Class fr.paris.lutece.plugins.participatoryideation.web.ProposalJspBean defines non-transient non-serializable instance field _proposalBoForm |
BAD_PRACTICE |
SE_BAD_FIELD |
Not available |
Medium |
| Class fr.paris.lutece.plugins.participatoryideation.web.ProposalJspBean defines non-transient non-serializable instance field _proposalSearcher |
BAD_PRACTICE |
SE_BAD_FIELD |
Not available |
Medium |
fr.paris.lutece.plugins.participatoryideation.web.ProposalLinksJspBean
| Bug |
Category |
Details |
Line |
Priority |
| Class fr.paris.lutece.plugins.participatoryideation.web.ProposalLinksJspBean defines non-transient non-serializable instance field _linkSearcher |
BAD_PRACTICE |
SE_BAD_FIELD |
Not available |
Medium |
fr.paris.lutece.plugins.participatoryideation.web.ProposalSubscriberXPage
| Bug |
Category |
Details |
Line |
Priority |
| Dead store to wrapper in fr.paris.lutece.plugins.participatoryideation.web.ProposalSubscriberXPage.getSubscriberProposals(HttpServletRequest) |
STYLE |
DLS_DEAD_LOCAL_STORE |
169 |
Medium |
| Class fr.paris.lutece.plugins.participatoryideation.web.ProposalSubscriberXPage defines non-transient non-serializable instance field _resourceExtenderHistoryService |
BAD_PRACTICE |
SE_BAD_FIELD |
Not available |
Medium |
fr.paris.lutece.plugins.participatoryideation.web.etape.FormEtapeDescription
| Bug |
Category |
Details |
Line |
Priority |
| Dead store to userUid in fr.paris.lutece.plugins.participatoryideation.web.etape.FormEtapeDescription.checkValidationErrorsLocalized(HttpServletRequest, Proposal, Locale) |
STYLE |
DLS_DEAD_LOCAL_STORE |
158 |
Medium |
