The following document contains the results of PMD 6.13.0.
| Rule | Violation | Line |
|---|---|---|
| FormalParameterNamingConventions | The method parameter name '_nId' doesn't match '[a-z][a-zA-Z0-9]*' | 65 |
| FormalParameterNamingConventions | The method parameter name '_parentId' doesn't match '[a-z][a-zA-Z0-9]*' | 75 |
| FormalParameterNamingConventions | The method parameter name '_childId' doesn't match '[a-z][a-zA-Z0-9]*' | 85 |
| FormalParameterNamingConventions | The method parameter name '_parentCodeCampaign' doesn't match '[a-z][a-zA-Z0-9]*' | 95 |
| FormalParameterNamingConventions | The method parameter name '_childCodeCampaign' doesn't match '[a-z][a-zA-Z0-9]*' | 105 |
| FormalParameterNamingConventions | The method parameter name '_parentCodeProposal' doesn't match '[a-z][a-zA-Z0-9]*' | 115 |
| FormalParameterNamingConventions | The method parameter name '_childCodeProposal' doesn't match '[a-z][a-zA-Z0-9]*' | 125 |
| FormalParameterNamingConventions | The method parameter name '_parentTitle' doesn't match '[a-z][a-zA-Z0-9]*' | 135 |
| FormalParameterNamingConventions | The method parameter name '_childTitle' doesn't match '[a-z][a-zA-Z0-9]*' | 145 |
| Rule | Violation | Line |
|---|---|---|
| FieldNamingConventions | The constant name 'valueMap' doesn't match '[A-Z][A-Z_0-9]*' | 129 |
| FieldNamingConventions | The constant name 'listStatusPublished' doesn't match '[A-Z][A-Z_0-9]*' | 130 |
| FieldNamingConventions | The constant name 'listStatusUnPublished' doesn't match '[A-Z][A-Z_0-9]*' | 131 |
| FormalParameterNamingConventions | The method parameter name '_dLatitude' doesn't match '[a-z][a-zA-Z0-9]*' | 233 |
| FormalParameterNamingConventions | The method parameter name '_strField4' doesn't match '[a-z][a-zA-Z0-9]*' | 327 |
| FormalParameterNamingConventions | The method parameter name '_strField4Complement' doesn't match '[a-z][a-zA-Z0-9]*' | 337 |
| FormalParameterNamingConventions | The method parameter name '_nCout' doesn't match '[a-z][a-zA-Z0-9]*' | 463 |
| FormalParameterNamingConventions | The method parameter name '_strLocationType' doesn't match '[a-z][a-zA-Z0-9]*' | 473 |
| FormalParameterNamingConventions | The method parameter name '_strAdress' doesn't match '[a-z][a-zA-Z0-9]*' | 483 |
| FormalParameterNamingConventions | The method parameter name '_strLocationArdt' doesn't match '[a-z][a-zA-Z0-9]*' | 493 |
| FormalParameterNamingConventions | The method parameter name '_strSubmitterType' doesn't match '[a-z][a-zA-Z0-9]*' | 503 |
| FormalParameterNamingConventions | The method parameter name '_dLongitude' doesn't match '[a-z][a-zA-Z0-9]*' | 513 |
| FormalParameterNamingConventions | The method parameter name '_bAcceptExploit' doesn't match '[a-z][a-zA-Z0-9]*' | 523 |
| FormalParameterNamingConventions | The method parameter name '_strSubmitter' doesn't match '[a-z][a-zA-Z0-9]*' | 543 |
| FormalParameterNamingConventions | The method parameter name '_creationTimestamp' doesn't match '[a-z][a-zA-Z0-9]*' | 708 |
| FormalParameterNamingConventions | The method parameter name '_strMotifRecev' doesn't match '[a-z][a-zA-Z0-9]*' | 833 |
| FormalParameterNamingConventions | The method parameter name '_strCodeCampaign' doesn't match '[a-z][a-zA-Z0-9]*' | 909 |
| Rule | Violation | Line |
|---|---|---|
| LocalVariableNamingConventions | The local variable name '_ids' doesn't match '[a-z][a-zA-Z0-9]*' | 247 |
| LocalVariableNamingConventions | The local variable name '_proposal' doesn't match '[a-z][a-zA-Z0-9]*' | 253 |
| LocalVariableNamingConventions | The local variable name '_newMethod' doesn't match '[a-z][a-zA-Z0-9]*' | 261 |
| LocalVariableNamingConventions | The local variable name '_nIds' doesn't match '[a-z][a-zA-Z0-9]*' | 280 |
| LocalVariableNamingConventions | The local variable name '_proposal' doesn't match '[a-z][a-zA-Z0-9]*' | 284 |
| LocalVariableNamingConventions | The local variable name '_nIds' doesn't match '[a-z][a-zA-Z0-9]*' | 318 |
| Rule | Violation | Line |
|---|---|---|
| FormalParameterNamingConventions | The method parameter name 'CodeCampaign' doesn't match '[a-z][a-zA-Z0-9]*' | 77 |
| FormalParameterNamingConventions | The method parameter name 'CodeTheme' doesn't match '[a-z][a-zA-Z0-9]*' | 94 |
| FormalParameterNamingConventions | The method parameter name '_strLuteceUserName' doesn't match '[a-z][a-zA-Z0-9]*' | 230 |
| FormalParameterNamingConventions | The method parameter name '_bIsPublished' doesn't match '[a-z][a-zA-Z0-9]*' | 295 |
| Rule | Violation | Line |
|---|---|---|
| ConstructorCallsOverridableMethod | Overridable method 'setErrorCode' called during object construction | 54 |
| Rule | Violation | Line |
|---|---|---|
| LocalVariableNamingConventions | The local variable name 'WorkflowStatesReferenceList' doesn't match '[a-z][a-zA-Z0-9]*' | 144 |
| Rule | Violation | Line |
|---|---|---|
| LocalVariableNamingConventions | The local variable name 'nId_Proposal' doesn't match '[a-z][a-zA-Z0-9]*' | 151 |
| Rule | Violation | Line |
|---|---|---|
| FormalParameterNamingConventions | The method parameter name 'nId_Proposal' doesn't match '[a-z][a-zA-Z0-9]*' | 99 |
| FormalParameterNamingConventions | The method parameter name 'nId_Proposal' doesn't match '[a-z][a-zA-Z0-9]*' | 124 |
| FormalParameterNamingConventions | The method parameter name 'nId_Proposal' doesn't match '[a-z][a-zA-Z0-9]*' | 251 |
| FormalParameterNamingConventions | The method parameter name 'nId_Proposal' doesn't match '[a-z][a-zA-Z0-9]*' | 278 |
| Rule | Violation | Line |
|---|---|---|
| LocalVariableNamingConventions | The local variable name '_service' doesn't match '[a-z][a-zA-Z0-9]*' | 260 |
| Rule | Violation | Line |
|---|---|---|
| LocalVariableNamingConventions | The local variable name 'SOLR_SERVER' doesn't match '[a-z][a-zA-Z0-9]*' | 112 |
| LocalVariableNamingConventions | The local variable name '_proposalSearcher' doesn't match '[a-z][a-zA-Z0-9]*' | 338 |
| LocalVariableNamingConventions | The local variable name 'SOLR_SERVER' doesn't match '[a-z][a-zA-Z0-9]*' | 429 |
| Rule | Violation | Line |
|---|---|---|
| FieldNamingConventions | The static field name 'PROPERTY_PREFIX' doesn't match '_[a-z][a-zA-Z0-9]*' | 66 |
| FieldNamingConventions | The static field name 'PROPERTY_SEP' doesn't match '_[a-z][a-zA-Z0-9]*' | 67 |
| FieldNamingConventions | The static field name 'campaigns' doesn't match '_[a-z][a-zA-Z0-9]*' | 70 |
| FieldNamingConventions | The static field name 'themeLabels' doesn't match '_[a-z][a-zA-Z0-9]*' | 76 |
| FieldNamingConventions | The static field name 'themeFrontRgbs' doesn't match '_[a-z][a-zA-Z0-9]*' | 82 |
| FieldNamingConventions | The static field name 'areaLabels' doesn't match '_[a-z][a-zA-Z0-9]*' | 88 |
| FieldNamingConventions | The static field name 'areaTypes' doesn't match '_[a-z][a-zA-Z0-9]*' | 94 |
| FieldNamingConventions | The static field name 'dates' doesn't match '_[a-z][a-zA-Z0-9]*' | 100 |
| FieldNamingConventions | The static field name 'fields' doesn't match '_[a-z][a-zA-Z0-9]*' | 109 |
| Rule | Violation | Line |
|---|---|---|
| ClassWithOnlyPrivateConstructorsShouldBeFinal | A class which only has private constructors should be final | 50–145 |
| Rule | Violation | Line |
|---|---|---|
| AvoidThrowingRawExceptionTypes | Avoid throwing raw exception types. | 248 |
| AvoidThrowingRawExceptionTypes | Avoid throwing raw exception types. | 271 |
| AvoidThrowingRawExceptionTypes | Avoid throwing raw exception types. | 322 |
| AvoidThrowingRawExceptionTypes | Avoid throwing raw exception types. | 340 |
| AvoidThrowingRawExceptionTypes | Avoid throwing raw exception types. | 360 |
| AvoidThrowingRawExceptionTypes | Avoid throwing raw exception types. | 379 |
| Rule | Violation | Line |
|---|---|---|
| ClassNamingConventions | The utility class name 'ParticipatoryIdeationConstants' doesn't match '[A-Z][a-zA-Z0-9]+(Utils?|Helper|Home|Service)' | 39–70 |
| Rule | Violation | Line |
|---|---|---|
| ClassWithOnlyPrivateConstructorsShouldBeFinal | A class which only has private constructors should be final | 39–101 |
| Rule | Violation | Line |
|---|---|---|
| LocalVariableNamingConventions | The local variable name 'results_keyword' doesn't match '[a-z][a-zA-Z0-9]*' | 412 |
| LocalVariableNamingConventions | The local variable name 'results_location' doesn't match '[a-z][a-zA-Z0-9]*' | 413 |
| LocalVariableNamingConventions | The local variable name 'results_previous_campaigns' doesn't match '[a-z][a-zA-Z0-9]*' | 414 |
| FieldNamingConventions | The constant name 'nameMap' doesn't match '[A-Z][A-Z_0-9]*' | 1455 |
| Rule | Violation | Line |
|---|---|---|
| FieldNamingConventions | The public constant name 'RIGHT_MANAGE_participatoryideation_proposals' doesn't match '[A-Z][A-Z_0-9]*' | 60 |
| Rule | Violation | Line |
|---|---|---|
| FormalParameterNamingConventions | The method parameter name '_strTitre' doesn't match '[a-z][a-zA-Z0-9]*' | 226 |
| FormalParameterNamingConventions | The method parameter name '_strDescription' doesn't match '[a-z][a-zA-Z0-9]*' | 236 |
| FormalParameterNamingConventions | The method parameter name '_strCout' doesn't match '[a-z][a-zA-Z0-9]*' | 246 |
| FormalParameterNamingConventions | The method parameter name '_strLocationArdt' doesn't match '[a-z][a-zA-Z0-9]*' | 256 |
| Rule | Violation | Line |
|---|---|---|
| FieldNamingConventions | The static field name 'defaultSearcher' doesn't match '_[a-z][a-zA-Z0-9]*' | 192 |
| Rule | Violation | Line |
|---|---|---|
| FieldNamingConventions | The static field name 'defaultSearcher' doesn't match '_[a-z][a-zA-Z0-9]*' | 138 |
| FormalParameterNamingConventions | The method parameter name '_str' doesn't match '[a-z][a-zA-Z0-9]*' | 526 |
| FormalParameterNamingConventions | The method parameter name '_link' doesn't match '[a-z][a-zA-Z0-9]*' | 548 |
| Rule | Violation | Line |
|---|---|---|
| LocalVariableNamingConventions | The local variable name '_proposalSearcher' doesn't match '[a-z][a-zA-Z0-9]*' | 140 |
| LocalVariableNamingConventions | The local variable name '_commentFilter' doesn't match '[a-z][a-zA-Z0-9]*' | 146 |
| LocalVariableNamingConventions | The local variable name '_proposalSearcher' doesn't match '[a-z][a-zA-Z0-9]*' | 206 |
| LocalVariableNamingConventions | The local variable name 'IdExtendableResourceList' doesn't match '[a-z][a-zA-Z0-9]*' | 283 |
| Rule | Violation | Line |
|---|---|---|
| LocalVariableNamingConventions | The local variable name '_proposal' doesn't match '[a-z][a-zA-Z0-9]*' | 158 |
| LocalVariableNamingConventions | The local variable name '_proposal' doesn't match '[a-z][a-zA-Z0-9]*' | 253 |
| Rule | Violation | Line |
|---|---|---|
| FieldNamingConventions | The constant name 'strSearchSolrUrl' doesn't match '[A-Z][A-Z_0-9]*' | 76 |
| FieldNamingConventions | The constant name 'strAmpSymbol' doesn't match '[A-Z][A-Z_0-9]*' | 77 |
| FieldNamingConventions | The constant name 'strEqualSymbol' doesn't match '[A-Z][A-Z_0-9]*' | 78 |
| Rule | Violation | Line |
|---|---|---|
| EmptyMethodInAbstractClassShouldBeAbstract | An empty method in an abstract class should be abstract instead | 49–52 |
| EmptyMethodInAbstractClassShouldBeAbstract | An empty method in an abstract class should be abstract instead | 55–58 |
| FormalParameterNamingConventions | The method parameter name '_bValidated' doesn't match '[a-z][a-zA-Z0-9]*' | 65 |
| Rule | Violation | Line |
|---|---|---|
| FormalParameterNamingConventions | The method parameter name '_strDescription' doesn't match '[a-z][a-zA-Z0-9]*' | 89 |
| FormalParameterNamingConventions | The method parameter name '_strCout' doesn't match '[a-z][a-zA-Z0-9]*' | 101 |
| Rule | Violation | Line |
|---|---|---|
| FormalParameterNamingConventions | The method parameter name '_strGeojson' doesn't match '[a-z][a-zA-Z0-9]*' | 135 |
| FormalParameterNamingConventions | The method parameter name '_strAdress' doesn't match '[a-z][a-zA-Z0-9]*' | 208 |
| FormalParameterNamingConventions | The method parameter name '_strSubmitterType' doesn't match '[a-z][a-zA-Z0-9]*' | 218 |
| FormalParameterNamingConventions | The method parameter name '_strConseilQuartier' doesn't match '[a-z][a-zA-Z0-9]*' | 228 |
| Rule | Violation | Line |
|---|---|---|
| FormalParameterNamingConventions | The method parameter name '_strAcceptExploit' doesn't match '[a-z][a-zA-Z0-9]*' | 59 |
| Rule | Violation | Line |
|---|---|---|
| FormalParameterNamingConventions | The method parameter name '_bValidated' doesn't match '[a-z][a-zA-Z0-9]*' | 52 |
| Rule | Violation | Line |
|---|---|---|
| LocalVariableNamingConventions | The local variable name '_user' doesn't match '[a-z][a-zA-Z0-9]*' | 117 |
| LocalVariableNamingConventions | The local variable name '_proposalSearcher' doesn't match '[a-z][a-zA-Z0-9]*' | 127 |
| LocalVariableNamingConventions | The local variable name '_commentFilter' doesn't match '[a-z][a-zA-Z0-9]*' | 133 |
| LocalVariableNamingConventions | The local variable name 'IdExtendableResourceList' doesn't match '[a-z][a-zA-Z0-9]*' | 184 |
| Rule | Violation | Line |
|---|---|---|
| FieldNamingConventions | The constant name 'TEMPLATE_CHANGE_Proposal_Status_CONFIG' doesn't match '[A-Z][A-Z_0-9]*' | 74 |
| Rule | Violation | Line |
|---|---|---|
| AvoidReassigningParameters | Avoid reassigning parameters such as 'nCpt' | 407 |
| AvoidReassigningParameters | Avoid reassigning parameters such as 'nCpt' | 407 |
| AvoidReassigningParameters | Avoid reassigning parameters such as 'nCpt' | 407 |
| AvoidBranchingStatementAsLastInLoop | Avoid using a branching statement as the last in a loop. | 428 |
| Rule | Violation | Line |
|---|---|---|
| AvoidUsingVolatile | Use of modifier volatile is not recommended. | 79 |
| AvoidUsingVolatile | Use of modifier volatile is not recommended. | 80 |
| AvoidUsingVolatile | Use of modifier volatile is not recommended. | 82 |
| AvoidUsingVolatile | Use of modifier volatile is not recommended. | 83 |
| AvoidUsingVolatile | Use of modifier volatile is not recommended. | 85 |
| AvoidUsingVolatile | Use of modifier volatile is not recommended. | 86 |
| Rule | Violation | Line |
|---|---|---|
| AvoidReassigningParameters | Avoid reassigning parameters such as 'proposal' | 186 |
| Rule | Violation | Line |
|---|---|---|
| GuardLogStatement | Logger calls should be surrounded by log level guards. | 134 |
| Rule | Violation | Line |
|---|---|---|
| CommentRequired | Header comments are required | 36–146 |
| DefaultPackage | Use explicit scoping instead of the default package private level | 38 |
| CommentDefaultAccessModifier | To avoid mistakes add a comment at the beginning of the _strType field if you want a default access modifier | 38 |
| CommentDefaultAccessModifier | To avoid mistakes add a comment at the beginning of the _strId field if you want a default access modifier | 39 |
| DefaultPackage | Use explicit scoping instead of the default package private level | 39 |
| DefaultPackage | Use explicit scoping instead of the default package private level | 40 |
| CommentDefaultAccessModifier | To avoid mistakes add a comment at the beginning of the _strLibelle field if you want a default access modifier | 40 |
| DefaultPackage | Use explicit scoping instead of the default package private level | 41 |
| CommentDefaultAccessModifier | To avoid mistakes add a comment at the beginning of the _strGpruNom field if you want a default access modifier | 41 |
| DefaultPackage | Use explicit scoping instead of the default package private level | 42 |
| CommentDefaultAccessModifier | To avoid mistakes add a comment at the beginning of the _strExtBp field if you want a default access modifier | 42 |
| CommentDefaultAccessModifier | To avoid mistakes add a comment at the beginning of the _strFid field if you want a default access modifier | 43 |
| DefaultPackage | Use explicit scoping instead of the default package private level | 43 |
| Rule | Violation | Line |
|---|---|---|
| CommentRequired | Header comments are required | 81–119 |
| DataClass | The class 'QpvQvaRestResponse' is suspected to be a Data Class (WOC=0.000%, NOPA=7, NOAM=1, WMC=1) | 81–119 |
| CommentDefaultAccessModifier | To avoid mistakes add a comment at the beginning of the _features field if you want a default access modifier | 91 |
| DefaultPackage | Use explicit scoping instead of the default package private level | 91 |
| UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 96 |
| Rule | Violation | Line |
|---|---|---|
| DataClass | The class 'Link' is suspected to be a Data Class (WOC=11.111%, NOPA=0, NOAM=16, WMC=18) | 41–161 |
| CommentRequired | Public method and constructor comments are required | 60–63 |
| CommentRequired | Public method and constructor comments are required | 65–68 |
| Rule | Violation | Line |
|---|---|---|
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 226 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 228 |
| UnnecessaryLocalBeforeReturn | Consider simply returning the value vs storing it in local variable 'result' | 245 |
| InsufficientStringBufferDeclaration | StringBuffer constructor is initialized with size 16, but has at least 149 characters appended. | 280 |
| InsufficientStringBufferDeclaration | StringBuffer constructor is initialized with size 16, but has at least 60 characters appended. | 284 |
| Rule | Violation | Line |
|---|---|---|
| CommentRequired | Public method and constructor comments are required | 51–54 |
| CommentRequired | Public method and constructor comments are required | 56–59 |
| CommentRequired | Public method and constructor comments are required | 61–64 |
| CommentRequired | Public method and constructor comments are required | 66–69 |
| CommentRequired | Public method and constructor comments are required | 71–74 |
| CommentRequired | Public method and constructor comments are required | 76–79 |
| Rule | Violation | Line |
|---|---|---|
| AvoidSynchronizedAtMethodLevel | Use block level rather than method level synchronization | 54–66 |
| Rule | Violation | Line |
|---|---|---|
| AvoidSynchronizedAtMethodLevel | Use block level rather than method level synchronization | 57–76 |
| Rule | Violation | Line |
|---|---|---|
| LinguisticNaming | Linguistics Antipattern - The method 'hasParent' indicates linguistically it returns a boolean, but it returns 'int' | 128 |
| Rule | Violation | Line |
|---|---|---|
| ExcessivePublicCount | This class has a bunch of public methods and attributes | 34–914 |
| CyclomaticComplexity | The class 'Proposal' has a total cyclomatic complexity of 85 (highest 2). | 53–914 |
| TooManyFields | Too many fields | 53–914 |
| CommentRequired | Public method and constructor comments are required | 150–153 |
| CommentRequired | Public method and constructor comments are required | 155–158 |
| CommentRequired | Public method and constructor comments are required | 160–163 |
| FieldDeclarationsShouldBeAtStartOfClass | Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. | 165 |
| FieldDeclarationsShouldBeAtStartOfClass | Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. | 166 |
| FieldDeclarationsShouldBeAtStartOfClass | Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. | 167 |
| CommentRequired | Public method and constructor comments are required | 176–179 |
| CommentRequired | Public method and constructor comments are required | 181–184 |
| CommentRequired | Public method and constructor comments are required | 186–189 |
| CommentRequired | Public method and constructor comments are required | 228–231 |
| CommentRequired | Public method and constructor comments are required | 233–236 |
| CommentRequired | Public method and constructor comments are required | 322–325 |
| CommentRequired | Public method and constructor comments are required | 327–330 |
| CommentRequired | Public method and constructor comments are required | 332–335 |
| CommentRequired | Public method and constructor comments are required | 337–340 |
| CommentRequired | Public method and constructor comments are required | 468–471 |
| CommentRequired | Public method and constructor comments are required | 473–476 |
| CommentRequired | Public method and constructor comments are required | 478–481 |
| CommentRequired | Public method and constructor comments are required | 483–486 |
| CommentRequired | Public method and constructor comments are required | 488–491 |
| CommentRequired | Public method and constructor comments are required | 493–496 |
| CommentRequired | Public method and constructor comments are required | 498–501 |
| CommentRequired | Public method and constructor comments are required | 503–506 |
| CommentRequired | Public method and constructor comments are required | 508–511 |
| CommentRequired | Public method and constructor comments are required | 513–516 |
| CommentRequired | Public method and constructor comments are required | 518–521 |
| CommentRequired | Public method and constructor comments are required | 523–526 |
| CommentRequired | Public method and constructor comments are required | 528–531 |
| CommentRequired | Public method and constructor comments are required | 533–536 |
| CommentRequired | Public method and constructor comments are required | 538–541 |
| CommentRequired | Public method and constructor comments are required | 543–546 |
| CommentRequired | Public method and constructor comments are required | 803–806 |
| CommentRequired | Public method and constructor comments are required | 828–831 |
| CommentRequired | Public method and constructor comments are required | 833–836 |
| Rule | Violation | Line |
|---|---|---|
| GodClass | Possible God Class (WMC=70, ATFD=130, TCC=0.265%) | 60–991 |
| TooManyMethods | This class has too many methods, consider refactoring it. | 61–991 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 160–167 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 178–185 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 187–194 |
| NullAssignment | Assigning an Object to null is a code smell. Consider refactoring. | 202 |
| NullAssignment | Assigning an Object to null is a code smell. Consider refactoring. | 203 |
| ShortVariable | Avoid variables with short names like id | 224 |
| ShortVariable | Avoid variables with short names like id | 229 |
| ShortVariable | Avoid variables with short names like id | 258 |
| UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 335 |
| UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 336 |
| UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 383 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 447–454 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 456–463 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 477–485 |
| ExcessiveMethodLength | Avoid really long methods. | 512–613 |
| NPathComplexity | The method 'selectProposalsListSearch(Plugin, ProposalSearcher)' has an NPath complexity of 6480 | 512–613 |
| CyclomaticComplexity | The method 'selectProposalsListSearch(Plugin, ProposalSearcher)' has a cyclomatic complexity of 18. | 512–613 |
| UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 514 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 514 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 516 |
| UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 543 |
| UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 611 |
| UnnecessaryLocalBeforeReturn | Consider simply returning the value vs storing it in local variable 'result' | 612 |
| UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 621 |
| NcssCount | The method 'appendFilters(String, ProposalSearcher)' has a NCSS line count of 68. | 700–832 |
| NPathComplexity | The method 'appendFilters(String, ProposalSearcher)' has an NPath complexity of 2211840 | 700–832 |
| ExcessiveMethodLength | Avoid really long methods. | 700–832 |
| CyclomaticComplexity | The method 'appendFilters(String, ProposalSearcher)' has a cyclomatic complexity of 26. | 700–832 |
| ConsecutiveLiteralAppends | StringBuffer (or StringBuilder).append is called 6 consecutive times with literals. Use a single append with a single combined String. | 728 |
| AvoidDuplicateLiterals | The String literal " proposals.type_nqpv_qva != ? AND" appears 6 times in this file; the first occurrence is on line 728 | 728 |
| InsufficientStringBufferDeclaration | StringBuffer constructor is initialized with size 16, but has at least 415 characters appended. | 775 |
| AppendCharacterWithChar | Avoid appending characters as strings in StringBuffer.append. | 788 |
| AppendCharacterWithChar | Avoid appending characters as strings in StringBuffer.append. | 794 |
| AppendCharacterWithChar | Avoid appending characters as strings in StringBuffer.append. | 807 |
| AppendCharacterWithChar | Avoid appending characters as strings in StringBuffer.append. | 817 |
| NPathComplexity | The method 'setFilterValues(DAOUtil, ProposalSearcher)' has an NPath complexity of 2304 | 842–908 |
| CyclomaticComplexity | The method 'setFilterValues(DAOUtil, ProposalSearcher)' has a cyclomatic complexity of 13. | 842–908 |
| InsufficientStringBufferDeclaration | StringBuffer constructor is initialized with size 16, but has at least 32 characters appended. | 912 |
| AppendCharacterWithChar | Avoid appending characters as strings in StringBuffer.append. | 916 |
| ConsecutiveLiteralAppends | StringBuffer (or StringBuilder).append is called 2 consecutive times with literals. Use a single append with a single combined String. | 918 |
| AppendCharacterWithChar | Avoid appending characters as strings in StringBuffer.append. | 918 |
| AppendCharacterWithChar | Avoid appending characters as strings in StringBuffer.append. | 919 |
| UnusedPrivateMethod | Avoid unused private methods such as 'insertLink(int,int,Plugin)'. | 955 |
| Rule | Violation | Line |
|---|---|---|
| LinguisticNaming | Linguistics Antipattern - The method 'hasParent' indicates linguistically it returns a boolean, but it returns 'int' | 160–163 |
| UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 247 |
| AvoidDeeplyNestedIfStmts | Deeply nested if..then statements are hard to read | 259–264 |
| SwitchStmtsShouldHaveDefault | Switch statements should have a default label | 288–302 |
| ShortVariable | Avoid variables with short names like s | 306 |
| CyclomaticComplexity | The method 'getSubProposalsNicknamesNiceText(int, GetSubProposalsMethod, String)' has a cyclomatic complexity of 23. | 313–380 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 316 |
| SwitchStmtsShouldHaveDefault | Switch statements should have a default label | 327–341 |
| AvoidLiteralsInIfCondition | Avoid using Literals in Conditional Statements | 352 |
| ControlStatementBraces | This statement should have braces | 363–364 |
| ControlStatementBraces | This statement should have braces | 367–368 |
| ControlStatementBraces | This statement should have braces | 371–372 |
| Rule | Violation | Line |
|---|---|---|
| CommentRequired | Public method and constructor comments are required | 172–175 |
| CommentRequired | Public method and constructor comments are required | 177–180 |
| CommentRequired | Public method and constructor comments are required | 290–293 |
| CommentRequired | Public method and constructor comments are required | 295–298 |
| Rule | Violation | Line |
|---|---|---|
| UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 220 |
| Rule | Violation | Line |
|---|---|---|
| TooManyMethods | This class has too many methods, consider refactoring it. | 51–359 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 282 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 331 |
| UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 347 |
| Rule | Violation | Line |
|---|---|---|
| CommentRequired | Header comments are required | 47–106 |
| Rule | Violation | Line |
|---|---|---|
| CommentRequired | Header comments are required | 38–59 |
| UnnecessaryModifier | Unnecessary modifier 'public' on method 'fillCampaignStaticContent': the method is declared in an interface type | 49 |
| UnnecessaryModifier | Unnecessary modifier 'public' on method 'fillAllStaticContent': the method is declared in an interface type | 57 |
| Rule | Violation | Line |
|---|---|---|
| CommentRequired | Header comments are required | 43–95 |
| CommentRequired | Public method and constructor comments are required | 46 |
| CommentRequired | Public method and constructor comments are required | 48 |
| CommentRequired | Public method and constructor comments are required | 50 |
| CommentRequired | Public method and constructor comments are required | 52 |
| CommentRequired | Public method and constructor comments are required | 64 |
| CommentRequired | Public method and constructor comments are required | 66 |
| CommentRequired | Public method and constructor comments are required | 68 |
| CommentRequired | Public method and constructor comments are required | 70 |
| CommentRequired | Public method and constructor comments are required | 72 |
| CommentRequired | Public method and constructor comments are required | 74 |
| UnnecessaryModifier | Unnecessary modifier 'public' on method 'getUniqueUserGuidsProposalsSubmitters': the method is declared in an interface type | 88 |
| UnnecessaryModifier | Unnecessary modifier 'public' on method 'getUniqueUserGuidsProposalsFollowers': the method is declared in an interface type | 93 |
| Rule | Violation | Line |
|---|---|---|
| CommentRequired | Header comments are required | 36–39 |
| Rule | Violation | Line |
|---|---|---|
| CommentRequired | Header comments are required | 43–117 |
| UnnecessaryModifier | Unnecessary modifier 'public' on method 'getProposalsList': the method is declared in an interface type | 51 |
| UnnecessaryModifier | Unnecessary modifier 'public' on method 'getProposalsListSearch': the method is declared in an interface type | 75 |
| UnnecessaryModifier | Unnecessary modifier 'public' on method 'updateProposal': the method is declared in an interface type | 84 |
| UnnecessaryModifier | Unnecessary modifier 'public' on method 'updateProposal': the method is declared in an interface type | 86 |
| CommentRequired | Public method and constructor comments are required | 86 |
| UnnecessaryModifier | Unnecessary modifier 'public' on method 'updateProposal': the method is declared in an interface type | 88 |
| CommentRequired | Public method and constructor comments are required | 88 |
| UnnecessaryModifier | Unnecessary modifier 'public' on method 'createComment': the method is declared in an interface type | 95 |
| Rule | Violation | Line |
|---|---|---|
| CallSuperInConstructor | It is a good practice to call super() in a constructor | 52–55 |
| Rule | Violation | Line |
|---|---|---|
| ShortVariable | Avoid variables with short names like se | 50 |
| ShortVariable | Avoid variables with short names like se | 59 |
| Rule | Violation | Line |
|---|---|---|
| CommentRequired | Header comments are required | 53–145 |
| UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 93 |
| UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 94 |
| UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 104 |
| ShortVariable | Avoid variables with short names like h | 104 |
| UseIndexOfChar | String.indexOf(char) is faster than String.indexOf(String). | 136 |
| Rule | Violation | Line |
|---|---|---|
| CommentRequired | Header comments are required | 56–267 |
| CommentRequired | Public method and constructor comments are required | 98–105 |
| NonThreadSafeSingleton | Singleton is not thread safe | 100–103 |
| CommentRequired | Public method and constructor comments are required | 107–110 |
| CallSuperInConstructor | It is a good practice to call super() in a constructor | 107–110 |
| CommentRequired | Public method and constructor comments are required | 112–115 |
| MissingOverride | The method 'getName()' is missing an @Override annotation. | 112–115 |
| MissingOverride | The method 'fillCampaignStaticContent(Map, String)' is missing an @Override annotation. | 125–164 |
| MissingOverride | The method 'fillAllStaticContent(Map)' is missing an @Override annotation. | 174–195 |
| UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 207 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 207 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 214 |
| UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 214 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 235 |
| UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 235 |
| UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 243 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 243 |
| Rule | Violation | Line |
|---|---|---|
| CommentRequired | Header comments are required | 55–273 |
| UseUnderscoresInNumericLiterals | Number 2097152 should separate every third digit with an underscore | 76 |
| UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 81 |
| CyclomaticComplexity | The method 'canUploadFiles(HttpServletRequest, String, List, Locale)' has a cyclomatic complexity of 12. | 122–186 |
| NPathComplexity | The method 'canUploadFiles(HttpServletRequest, String, List, Locale)' has an NPath complexity of 264 | 122–186 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 124 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 125–126 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 129 |
| UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 248 |
| UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 258 |
| Rule | Violation | Line |
|---|---|---|
| CommentRequired | Header comments are required | 51–191 |
| PositionLiteralsFirstInComparisons | Position literals first in String comparisons | 115 |
| EmptyIfStmt | Avoid empty if statements | 121–123 |
| UseObjectForClearerAPI | Rather than using a lot of String arguments, consider using a container object for those values. | 148 |
| EmptyIfStmt | Avoid empty if statements | 162–164 |
| SimplifyBooleanReturns | Avoid unnecessary if..then..else statements when returning booleans | 183–187 |
| Rule | Violation | Line |
|---|---|---|
| CommentRequired | Header comments are required | 43–67 |
| Rule | Violation | Line |
|---|---|---|
| CommentRequired | Header comments are required | 38–45 |
| CommentRequired | Public method and constructor comments are required | 41–44 |
| MissingOverride | The method 'getIcon(String)' is missing an @Override annotation. | 41–44 |
| Rule | Violation | Line |
|---|---|---|
| CommentRequired | Header comments are required | 47–66 |
| MissingOverride | The method 'getPopup(HttpServletRequest, String, String)' is missing an @Override annotation. | 56–65 |
| CommentRequired | Public method and constructor comments are required | 56–65 |
| UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 60 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 60 |
| ShortVariable | Avoid variables with short names like t | 63 |
| Rule | Violation | Line |
|---|---|---|
| CommentRequired | Header comments are required | 41–69 |
| Rule | Violation | Line |
|---|---|---|
| CommentRequired | Header comments are required | 63–298 |
| CommentRequired | Public method and constructor comments are required | 97–127 |
| NonThreadSafeSingleton | Singleton is not thread safe | 99–124 |
| UnusedFormalParameter | Avoid unused method parameters such as 'proposal'. | 129 |
| UnusedFormalParameter | Avoid unused method parameters such as 'type'. | 129 |
| MissingOverride | The method 'createProposalDB(Proposal)' is missing an @Override annotation. | 142–147 |
| CommentRequired | Public method and constructor comments are required | 142–147 |
| AvoidSynchronizedAtMethodLevel | Use block level rather than method level synchronization | 142–147 |
| MissingOverride | The method 'createProposal(Proposal)' is missing an @Override annotation. | 149–153 |
| CommentRequired | Public method and constructor comments are required | 149–153 |
| CommentRequired | Public method and constructor comments are required | 155–161 |
| MissingOverride | The method 'removeProposal(Proposal)' is missing an @Override annotation. | 163–169 |
| CommentRequired | Public method and constructor comments are required | 163–169 |
| CommentRequired | Public method and constructor comments are required | 171–177 |
| MissingOverride | The method 'removeProposalByMdp(Proposal)' is missing an @Override annotation. | 171–177 |
| MissingOverride | The method 'getQpvQvaCodesList()' is missing an @Override annotation. | 192–195 |
| MissingOverride | The method 'getQpvQvaCodesMap()' is missing an @Override annotation. | 200–203 |
| MissingOverride | The method 'getField4CodesList()' is missing an @Override annotation. | 208–211 |
| MissingOverride | The method 'getField4CodesMap()' is missing an @Override annotation. | 216–219 |
| MissingOverride | The method 'getTypeLocationList()' is missing an @Override annotation. | 224–227 |
| MissingOverride | The method 'getTypeLocationMap()' is missing an @Override annotation. | 232–235 |
| UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 248 |
| UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 277 |
| Rule | Violation | Line |
|---|---|---|
| CommentRequired | Header comments are required | 58–284 |
| UseUtilityClass | All methods are static. Consider using a utility class instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning. | 59–284 |
| NonThreadSafeSingleton | Singleton is not thread safe | 73–76 |
| NonThreadSafeSingleton | Singleton is not thread safe | 87–90 |
| UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 101 |
| UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 126 |
| UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 165 |
| UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 207 |
| UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 215 |
| Rule | Violation | Line |
|---|---|---|
| ExcessiveImports | A high number of imports can indicate a high degree of coupling within an object. | 34–340 |
| CommentRequired | Header comments are required | 71–340 |
| NonThreadSafeSingleton | Singleton is not thread safe | 93–100 |
| CyclomaticComplexity | The method 'updateProposal(Proposal, Proposal, boolean, HttpServletRequest)' has a cyclomatic complexity of 17. | 143–183 |
| EmptyIfStmt | Avoid empty if statements | 161–163 |
| UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 198 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 198 |
| ShortVariable | Avoid variables with short names like t | 202 |
| AvoidCatchingGenericException | Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 205 |
| AddEmptyString | Do not add empty strings | 212 |
| AddEmptyString | Do not add empty strings | 232 |
| CommentRequired | Public method and constructor comments are required | 335–338 |
| Rule | Violation | Line |
|---|---|---|
| ExcessiveImports | A high number of imports can indicate a high degree of coupling within an object. | 34–471 |
| AvoidDuplicateLiterals | The String literal "proposal" appears 5 times in this file; the first occurrence is on line 78 | 78 |
| AvoidCatchingGenericException | Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 97 |
| AvoidCatchingGenericException | Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 118 |
| CyclomaticComplexity | The method 'getItem(Proposal)' has a cyclomatic complexity of 18. | 130–260 |
| NPathComplexity | The method 'getItem(Proposal)' has an NPath complexity of 3840 | 130–260 |
| NcssCount | The method 'getItem(Proposal)' has a NCSS line count of 75. | 130–260 |
| ExcessiveMethodLength | Avoid really long methods. | 130–260 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 146–169 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 177–184 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 215–224 |
| UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 238 |
| ShortVariable | Avoid variables with short names like sb | 241 |
| InefficientStringBuffering | Avoid concatenating nonliterals in a StringBuffer/StringBuilder constructor or append(). | 242 |
| InefficientStringBuffering | Avoid concatenating nonliterals in a StringBuffer/StringBuilder constructor or append(). | 245 |
| InefficientStringBuffering | Avoid concatenating nonliterals in a StringBuffer/StringBuilder constructor or append(). | 251 |
| InefficientStringBuffering | Avoid concatenating nonliterals in a StringBuffer/StringBuilder constructor or append(). | 255 |
| ShortVariable | Avoid variables with short names like sb | 268 |
| MissingOverride | The method 'indexDocuments()' is missing an @Override annotation. | 330–382 |
| UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 334 |
| UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 341 |
| UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 343 |
| AvoidCatchingGenericException | Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 348 |
| AvoidCatchingGenericException | Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 361 |
| AvoidCatchingGenericException | Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 374 |
| AvoidCatchingGenericException | Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 436 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 454–467 |
| Rule | Violation | Line |
|---|---|---|
| UnnecessaryModifier | Unnecessary modifiers 'public static final' on field 'WHOLE_AREA': the field is declared in an interface type | 49 |
| CommentRequired | Public method and constructor comments are required | 57 |
| UnnecessaryModifier | Unnecessary modifier 'public' on method 'getCampaigns': the method is declared in an interface type | 57 |
| UnnecessaryModifier | Unnecessary modifier 'public' on method 'getLastCampaign': the method is declared in an interface type | 60 |
| CommentRequired | Public method and constructor comments are required | 60 |
| CommentRequired | Public method and constructor comments are required | 68 |
| UnnecessaryModifier | Unnecessary modifier 'public' on method 'isBeforeBeginning': the method is declared in an interface type | 68 |
| CommentRequired | Public method and constructor comments are required | 70 |
| UnnecessaryModifier | Unnecessary modifier 'public' on method 'isAfterBeginning': the method is declared in an interface type | 70 |
| UnnecessaryModifier | Unnecessary modifier 'public' on method 'isDuring': the method is declared in an interface type | 72 |
| CommentRequired | Public method and constructor comments are required | 72 |
| CommentRequired | Public method and constructor comments are required | 74 |
| UnnecessaryModifier | Unnecessary modifier 'public' on method 'isBeforeEnd': the method is declared in an interface type | 74 |
| UnnecessaryModifier | Unnecessary modifier 'public' on method 'isAfterEnd': the method is declared in an interface type | 76 |
| CommentRequired | Public method and constructor comments are required | 76 |
| CommentRequired | Public method and constructor comments are required | 79 |
| UnnecessaryModifier | Unnecessary modifier 'public' on method 'isBeforeBeginning': the method is declared in an interface type | 79 |
| CommentRequired | Public method and constructor comments are required | 81 |
| UnnecessaryModifier | Unnecessary modifier 'public' on method 'isAfterBeginning': the method is declared in an interface type | 81 |
| UnnecessaryModifier | Unnecessary modifier 'public' on method 'isDuring': the method is declared in an interface type | 83 |
| CommentRequired | Public method and constructor comments are required | 83 |
| CommentRequired | Public method and constructor comments are required | 85 |
| UnnecessaryModifier | Unnecessary modifier 'public' on method 'isBeforeEnd': the method is declared in an interface type | 85 |
| CommentRequired | Public method and constructor comments are required | 87 |
| UnnecessaryModifier | Unnecessary modifier 'public' on method 'isAfterEnd': the method is declared in an interface type | 87 |
| UnnecessaryModifier | Unnecessary modifier 'public' on method 'getCampaignAllAreaLabels': the method is declared in an interface type | 96 |
| CommentRequired | Public method and constructor comments are required | 96 |
| CommentRequired | Public method and constructor comments are required | 98 |
| UnnecessaryModifier | Unnecessary modifier 'public' on method 'getCampaignAllAreaTypes': the method is declared in an interface type | 98 |
| CommentRequired | Public method and constructor comments are required | 100 |
| UnnecessaryModifier | Unnecessary modifier 'public' on method 'getCampaignWholeAreaLabel': the method is declared in an interface type | 100 |
| UnnecessaryModifier | Unnecessary modifier 'public' on method 'getCampaignLocalizedAreaLabels': the method is declared in an interface type | 102 |
| CommentRequired | Public method and constructor comments are required | 102 |
| CommentRequired | Public method and constructor comments are required | 104 |
| UnnecessaryModifier | Unnecessary modifier 'public' on method 'getCampaignNumberLocalizedAreas': the method is declared in an interface type | 104 |
| CommentRequired | Public method and constructor comments are required | 108 |
| UnnecessaryModifier | Unnecessary modifier 'public' on method 'getLastCampaignAllAreaLabels': the method is declared in an interface type | 108 |
| CommentRequired | Public method and constructor comments are required | 110 |
| UnnecessaryModifier | Unnecessary modifier 'public' on method 'getLastCampaignAllAreaTypes': the method is declared in an interface type | 110 |
| UnnecessaryModifier | Unnecessary modifier 'public' on method 'getLastCampaignWholeAreaLabel': the method is declared in an interface type | 112 |
| CommentRequired | Public method and constructor comments are required | 112 |
| CommentRequired | Public method and constructor comments are required | 114 |
| UnnecessaryModifier | Unnecessary modifier 'public' on method 'getLastCampaignLocalizedAreaLabels': the method is declared in an interface type | 114 |
| UnnecessaryModifier | Unnecessary modifier 'public' on method 'getLastCampaignNumberLocalizedAreas': the method is declared in an interface type | 116 |
| CommentRequired | Public method and constructor comments are required | 116 |
| UnnecessaryModifier | Unnecessary modifier 'public' on method 'getCampaignSubmitterTypes': the method is declared in an interface type | 124 |
| CommentRequired | Public method and constructor comments are required | 124 |
| CommentRequired | Public method and constructor comments are required | 132 |
| UnnecessaryModifier | Unnecessary modifier 'public' on method 'getCampaignThemes': the method is declared in an interface type | 132 |
| CommentRequired | Public method and constructor comments are required | 135 |
| UnnecessaryModifier | Unnecessary modifier 'public' on method 'getLastCampaignThemes': the method is declared in an interface type | 135 |
| UnnecessaryModifier | Unnecessary modifier 'public' on method 'getCampaignThemesFrontRgb': the method is declared in an interface type | 138 |
| CommentRequired | Public method and constructor comments are required | 138 |
| CommentRequired | Public method and constructor comments are required | 150 |
| UnnecessaryModifier | Unnecessary modifier 'public' on method 'getCampaignFieldData': the method is declared in an interface type | 150 |
| CommentRequired | Public method and constructor comments are required | 153 |
| UnnecessaryModifier | Unnecessary modifier 'public' on method 'getCampaignFieldsData': the method is declared in an interface type | 153 |
| Rule | Violation | Line |
|---|---|---|
| RedundantFieldInitializer | Avoid using redundant field initializer for 'campaigns' | 70 |
| RedundantFieldInitializer | Avoid using redundant field initializer for 'themeLabels' | 76 |
| RedundantFieldInitializer | Avoid using redundant field initializer for 'themeFrontRgbs' | 82 |
| RedundantFieldInitializer | Avoid using redundant field initializer for 'areaLabels' | 88 |
| RedundantFieldInitializer | Avoid using redundant field initializer for 'areaTypes' | 94 |
| RedundantFieldInitializer | Avoid using redundant field initializer for 'dates' | 100 |
| RedundantFieldInitializer | Avoid using redundant field initializer for 'fields' | 109 |
| CommentRequired | Public method and constructor comments are required | 120–128 |
| NonThreadSafeSingleton | Singleton is not thread safe | 122–126 |
| ShortVariable | Avoid variables with short names like c2 | 147 |
| ShortVariable | Avoid variables with short names like c1 | 147 |
| AvoidDuplicateLiterals | The String literal "Unexpected phase code '" appears 4 times in this file; the first occurrence is on line 166 | 166 |
| CyclomaticComplexity | The method 'loadProperties()' has a cyclomatic complexity of 17. | 390–525 |
| NPathComplexity | The method 'loadProperties()' has an NPath complexity of 2700 | 390–525 |
| ExcessiveMethodLength | Avoid really long methods. | 390–525 |
| NcssCount | The method 'loadProperties()' has a NCSS line count of 78. | 390–525 |
| AvoidLiteralsInIfCondition | Avoid using Literals in Conditional Statements | 404 |
| AvoidDuplicateLiterals | The String literal "The property '" appears 4 times in this file; the first occurrence is on line 406 | 406 |
| AvoidLiteralsInIfCondition | Avoid using Literals in Conditional Statements | 430 |
| AvoidLiteralsInIfCondition | Avoid using Literals in Conditional Statements | 462 |
| AvoidLiteralsInIfCondition | Avoid using Literals in Conditional Statements | 490 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 507 |
| Rule | Violation | Line |
|---|---|---|
| CommentRequired | Header comments are required | 50–145 |
| AvoidDuplicateLiterals | The String literal "false" appears 6 times in this file; the first occurrence is on line 66 | 66 |
| SignatureDeclareThrowsException | A method/constructor should not explicitly throw java.lang.Exception | 110 |
| CommentRequired | Public method and constructor comments are required | 110–143 |
| UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 113 |
| UnnecessaryLocalBeforeReturn | Consider simply returning the value vs storing it in local variable 'features' | 142 |
| Rule | Violation | Line |
|---|---|---|
| AvoidSynchronizedAtMethodLevel | Use block level rather than method level synchronization | 67–70 |
| MissingOverride | The method 'getImageResource(int)' is missing an @Override annotation. | 97–116 |
| UnconditionalIfStatement | Do not use if statements that are always true or always false | 99 |
| MissingOverride | The method 'getResourceTypeId()' is missing an @Override annotation. | 123–126 |
| Rule | Violation | Line |
|---|---|---|
| UnnecessaryModifier | Unnecessary modifier 'public' on method 'isUserValid': the method is declared in an interface type | 44 |
| CommentRequired | Public method and constructor comments are required | 44 |
| CommentRequired | Public method and constructor comments are required | 48 |
| UnnecessaryModifier | Unnecessary modifier 'public' on method 'getUrlMyInfosFillAction': the method is declared in an interface type | 48 |
| Rule | Violation | Line |
|---|---|---|
| CommentRequired | Public method and constructor comments are required | 60–67 |
| NonThreadSafeSingleton | Singleton is not thread safe | 62–65 |
| Rule | Violation | Line |
|---|---|---|
| UnusedPrivateField | Avoid unused private fields such as 'MESSAGE_UNPUBLISHED_PROPOSAL'. | 71 |
| UnusedPrivateField | Avoid unused private fields such as 'MESSAGE_PUBLISHED_PROPOSAL'. | 72 |
| Rule | Violation | Line |
|---|---|---|
| ExcessiveImports | A high number of imports can indicate a high degree of coupling within an object. | 34–388 |
| NPathComplexity | The method 'processTask(int, HttpServletRequest, Locale)' has an NPath complexity of 87256 | 126–387 |
| ExcessiveMethodLength | Avoid really long methods. | 126–387 |
| NcssCount | The method 'processTask(int, HttpServletRequest, Locale)' has a NCSS line count of 127. | 126–387 |
| CyclomaticComplexity | The method 'processTask(int, HttpServletRequest, Locale)' has a cyclomatic complexity of 49. | 126–387 |
| UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 170 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 170 |
| UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 191 |
| UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 192 |
| AvoidDuplicateLiterals | The String literal "[#ftl]\n[#setting date_format=\"dd/MM/yyyy\"]\n" appears 6 times in this file; the first occurrence is on line 240 | 240 |
| AvoidCatchingGenericException | Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 246 |
| AvoidCatchingGenericException | Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 269 |
| AvoidCatchingGenericException | Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 320 |
| AvoidCatchingGenericException | Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 338 |
| AvoidCatchingGenericException | Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 358 |
| AvoidCatchingGenericException | Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 377 |
| Rule | Violation | Line |
|---|---|---|
| UselessOverridingMethod | Overriding method merely calls super | 52–55 |
| UselessOverridingMethod | Overriding method merely calls super | 61–64 |
| UselessOverridingMethod | Overriding method merely calls super | 70–73 |
| Rule | Violation | Line |
|---|---|---|
| AbstractClassWithoutAbstractMethod | This abstract class does not have any abstract methods | 55–255 |
| AvoidCatchingGenericException | Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 73 |
| AvoidUncheckedExceptionsInSignatures | A method or constructor should not explicitly declare unchecked exceptions in its 'throws' clause | 83 |
| AvoidCatchingGenericException | Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 90 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 107 |
| AvoidDuplicateLiterals | The String literal "status" appears 4 times in this file; the first occurrence is on line 110 | 110 |
| AvoidDuplicateLiterals | The String literal "result" appears 6 times in this file; the first occurrence is on line 112 | 112 |
| AvoidCatchingGenericException | Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 126 |
| AvoidCatchingGenericException | Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 147 |
| AvoidCatchingGenericException | Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 163 |
| AvoidCatchingGenericException | Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 195 |
| AvoidCatchingGenericException | Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 226 |
| AvoidCatchingGenericException | Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 248 |
| Rule | Violation | Line |
|---|---|---|
| NonThreadSafeSingleton | Singleton is not thread safe | 84–91 |
| ForLoopCanBeForeach | This for loop can be replaced by a foreach loop | 112–119 |
| UseCollectionIsEmpty | Substitute calls to size() == 0 (or size() != 0, size() > 0, size() < 1) with calls to isEmpty() | 166 |
| SimplifyBooleanReturns | Avoid unnecessary if..then..else statements when returning booleans | 225–228 |
| UseCollectionIsEmpty | Substitute calls to size() == 0 (or size() != 0, size() > 0, size() < 1) with calls to isEmpty() | 225 |
| CommentRequired | Public method and constructor comments are required | 240–251 |
| ForLoopCanBeForeach | This for loop can be replaced by a foreach loop | 256–260 |
| Rule | Violation | Line |
|---|---|---|
| CommentRequired | Header comments are required | 52–202 |
| UseUtilityClass | All methods are static. Consider using a utility class instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning. | 53–202 |
| LooseCoupling | Avoid using implementation types like 'ArrayList'; use the interface instead | 64 |
| LinguisticNaming | Linguistics Antipattern - The getter 'getValuesFromCsv' should not return void linguistically | 74–109 |
| LinguisticNaming | Linguistics Antipattern - The variable 'isCsvProperty' indicates linguistically it is a boolean, but it is 'InputStream' | 77 |
| UseProperClassLoader | In J2EE, getClassLoader() might not work as expected. Use Thread.currentThread().getContextClassLoader() instead. | 77 |
| UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 88 |
| UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 89 |
| ShortVariable | Avoid variables with short names like i | 95 |
| CommentRequired | Public method and constructor comments are required | 111–119 |
| CommentRequired | Public method and constructor comments are required | 121–129 |
| CyclomaticComplexity | The method 'writeCsv(String, List, OutputStream, Locale)' has a cyclomatic complexity of 10. | 142–201 |
| UseProperClassLoader | In J2EE, getClassLoader() might not work as expected. Use Thread.currentThread().getContextClassLoader() instead. | 147 |
| LinguisticNaming | Linguistics Antipattern - The variable 'isCsvProperty' indicates linguistically it is a boolean, but it is 'InputStream' | 147 |
| EmptyStatementNotInLoop | An empty statement (semicolon) not part of a loop | 158 |
| UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 180 |
| ForLoopCanBeForeach | This for loop can be replaced by a foreach loop | 181–184 |
| Rule | Violation | Line |
|---|---|---|
| CommentRequired | Header comments are required | 39–101 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 87–94 |
| Rule | Violation | Line |
|---|---|---|
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 93–94 |
| Rule | Violation | Line |
|---|---|---|
| ExcessiveImports | A high number of imports can indicate a high degree of coupling within an object. | 34–1476 |
| ExcessiveClassLength | Avoid really long classes. | 108–1476 |
| GodClass | Possible God Class (WMC=97, ATFD=173, TCC=22.942%) | 108–1476 |
| CyclomaticComplexity | The class 'IdeationApp' has a total cyclomatic complexity of 97 (highest 22). | 108–1476 |
| TooManyMethods | This class has too many methods, consider refactoring it. | 109–1476 |
| AvoidDuplicateLiterals | The String literal "true" appears 4 times in this file; the first occurrence is on line 146 | 146 |
| CommentDefaultAccessModifier | To avoid mistakes add a comment at the beginning of the _formEtapeLocation field if you want a default access modifier | 226 |
| DefaultPackage | Use explicit scoping instead of the default package private level | 226 |
| DefaultPackage | Use explicit scoping instead of the default package private level | 227 |
| CommentDefaultAccessModifier | To avoid mistakes add a comment at the beginning of the _formEtapeTitle field if you want a default access modifier | 227 |
| CommentDefaultAccessModifier | To avoid mistakes add a comment at the beginning of the _formEtapeApprox field if you want a default access modifier | 228 |
| DefaultPackage | Use explicit scoping instead of the default package private level | 228 |
| DefaultPackage | Use explicit scoping instead of the default package private level | 229 |
| CommentDefaultAccessModifier | To avoid mistakes add a comment at the beginning of the _formEtapeDescription field if you want a default access modifier | 229 |
| DefaultPackage | Use explicit scoping instead of the default package private level | 230 |
| CommentDefaultAccessModifier | To avoid mistakes add a comment at the beginning of the _formEtapeUpload field if you want a default access modifier | 230 |
| CommentDefaultAccessModifier | To avoid mistakes add a comment at the beginning of the _formEtapeRecap field if you want a default access modifier | 231 |
| DefaultPackage | Use explicit scoping instead of the default package private level | 231 |
| CommentDefaultAccessModifier | To avoid mistakes add a comment at the beginning of the _proposalCreate field if you want a default access modifier | 233 |
| DefaultPackage | Use explicit scoping instead of the default package private level | 233 |
| DefaultPackage | Use explicit scoping instead of the default package private level | 234 |
| CommentDefaultAccessModifier | To avoid mistakes add a comment at the beginning of the _proposalDisplay field if you want a default access modifier | 234 |
| CommentDefaultAccessModifier | To avoid mistakes add a comment at the beginning of the _strNextStep field if you want a default access modifier | 235 |
| DefaultPackage | Use explicit scoping instead of the default package private level | 235 |
| CallSuperInConstructor | It is a good practice to call super() in a constructor | 242–245 |
| CommentRequired | Public method and constructor comments are required | 242–245 |
| CyclomaticComplexity | The method 'getPage(HttpServletRequest, int, Plugin)' has a cyclomatic complexity of 13. | 253–308 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 255 |
| CollapsibleIfStatements | These nested if statements could be combined | 301–304 |
| UnnecessaryAnnotationValueElement | Avoid the use of value in annotations when its the only element | 350 |
| UnnecessaryAnnotationValueElement | Avoid the use of value in annotations when its the only element | 371 |
| UnnecessaryAnnotationValueElement | Avoid the use of value in annotations when its the only element | 387 |
| UnnecessaryAnnotationValueElement | Avoid the use of value in annotations when its the only element | 408 |
| CyclomaticComplexity | The method 'viewApprox(HttpServletRequest)' has a cyclomatic complexity of 14. | 409–483 |
| NPathComplexity | The method 'viewApprox(HttpServletRequest)' has an NPath complexity of 202 | 409–483 |
| UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 424 |
| UseCollectionIsEmpty | Substitute calls to size() == 0 (or size() != 0, size() > 0, size() < 1) with calls to isEmpty() | 427 |
| UseCollectionIsEmpty | Substitute calls to size() == 0 (or size() != 0, size() > 0, size() < 1) with calls to isEmpty() | 436 |
| AvoidLiteralsInIfCondition | Avoid using Literals in Conditional Statements | 507 |
| UnnecessaryLocalBeforeReturn | Consider simply returning the value vs storing it in local variable 'strGeofiltFq' | 533 |
| AvoidLiteralsInIfCondition | Avoid using Literals in Conditional Statements | 557 |
| UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 570 |
| OptimizableToArrayCall | This call to Collection.toArray() may be optimizable | 578 |
| AvoidDuplicateLiterals | The String literal "IdeationApp: error during approx search; " appears 6 times in this file; the first occurrence is on line 588 | 588 |
| IdenticalCatchBranches | 'catch' branch identical to 'SolrServerException' branch | 590–593 |
| NPathComplexity | The method 'getKeywordApproxResults(SolrQuery, SolrClient)' has an NPath complexity of 8448 | 606–735 |
| CyclomaticComplexity | The method 'getKeywordApproxResults(SolrQuery, SolrClient)' has a cyclomatic complexity of 22. | 606–735 |
| NcssCount | The method 'getKeywordApproxResults(SolrQuery, SolrClient)' has a NCSS line count of 62. | 606–735 |
| ExcessiveMethodLength | Avoid really long methods. | 606–735 |
| AvoidLiteralsInIfCondition | Avoid using Literals in Conditional Statements | 613 |
| UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 627 |
| OptimizableToArrayCall | This call to Collection.toArray() may be optimizable | 647 |
| UseCollectionIsEmpty | Substitute calls to size() == 0 (or size() != 0, size() > 0, size() < 1) with calls to isEmpty() | 676 |
| AvoidLiteralsInIfCondition | Avoid using Literals in Conditional Statements | 680 |
| IdenticalCatchBranches | 'catch' branch identical to 'SolrServerException' branch | 730–733 |
| AvoidLiteralsInIfCondition | Avoid using Literals in Conditional Statements | 762 |
| UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 778 |
| OptimizableToArrayCall | This call to Collection.toArray() may be optimizable | 781 |
| IdenticalCatchBranches | 'catch' branch identical to 'SolrServerException' branch | 802–805 |
| UnnecessaryAnnotationValueElement | Avoid the use of value in annotations when its the only element | 817 |
| UnnecessaryAnnotationValueElement | Avoid the use of value in annotations when its the only element | 831 |
| UnnecessaryAnnotationValueElement | Avoid the use of value in annotations when its the only element | 845 |
| UnnecessaryAnnotationValueElement | Avoid the use of value in annotations when its the only element | 861 |
| UnnecessaryAnnotationValueElement | Avoid the use of value in annotations when its the only element | 883 |
| UnnecessaryAnnotationValueElement | Avoid the use of value in annotations when its the only element | 902 |
| UnnecessaryAnnotationValueElement | Avoid the use of value in annotations when its the only element | 938 |
| UnnecessaryAnnotationValueElement | Avoid the use of value in annotations when its the only element | 954 |
| UnnecessaryAnnotationValueElement | Avoid the use of value in annotations when its the only element | 1001 |
| UnusedFormalParameter | Avoid unused method parameters such as 'request'. | 1024 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 1031–1048 |
| AvoidCatchingGenericException | Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 1040 |
| CommentRequired | Protected method constructor comments are required | 1132–1140 |
| AvoidLiteralsInIfCondition | Avoid using Literals in Conditional Statements | 1165 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 1174 |
| UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 1174 |
| DefaultPackage | Use explicit scoping instead of the default package private level | 1203–1237 |
| CommentDefaultAccessModifier | To avoid mistakes add a comment at the beginning of the isValidateFormEtape method if you want a default access modifier | 1203–1237 |
| DefaultPackage | Use explicit scoping instead of the default package private level | 1239–1244 |
| CommentDefaultAccessModifier | To avoid mistakes add a comment at the beginning of the isAllEtapeValidated method if you want a default access modifier | 1239–1244 |
| NcssCount | The method 'convertFormEtapeLocation(FormEtapeLocation, Proposal)' has a NCSS line count of 73. | 1246–1363 |
| ExcessiveMethodLength | Avoid really long methods. | 1246–1363 |
| CyclomaticComplexity | The method 'convertFormEtapeLocation(FormEtapeLocation, Proposal)' has a cyclomatic complexity of 14. | 1246–1363 |
| UseCollectionIsEmpty | Substitute calls to size() == 0 (or size() != 0, size() > 0, size() < 1) with calls to isEmpty() | 1273 |
| AvoidCatchingGenericException | Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 1325 |
| UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 1424 |
| UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 1458 |
| UnnecessaryModifier | Unnecessary modifier 'private' on constructor 'STEPS(String)': enum constructors are implicitly private | 1465–1468 |
| CommentRequired | Public method and constructor comments are required | 1470–1473 |
| Rule | Violation | Line |
|---|---|---|
| SingularField | Perhaps '_nDefaultItemsPerPage' could be replaced by a local variable. | 64 |
| AddEmptyString | Do not add empty strings | 95 |
| Rule | Violation | Line |
|---|---|---|
| MissingSerialVersionUID | Classes implementing Serializable should set a serialVersionUID | 57–136 |
| SingularField | Perhaps '_nDefaultItemsPerPage' could be replaced by a local variable. | 71 |
| AddEmptyString | Do not add empty strings | 102 |
| UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 119 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 125 |
| UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 125 |
| Rule | Violation | Line |
|---|---|---|
| MissingSerialVersionUID | Classes implementing Serializable should set a serialVersionUID | 50–98 |
| SingularField | Perhaps '_nDefaultItemsPerPage' could be replaced by a local variable. | 61 |
| AddEmptyString | Do not add empty strings | 92 |
| Rule | Violation | Line |
|---|---|---|
| CommentRequired | Header comments are required | 36–261 |
| CommentRequired | Public method and constructor comments are required | 127–130 |
| CommentRequired | Public method and constructor comments are required | 132–135 |
| CommentRequired | Public method and constructor comments are required | 221–224 |
| CommentRequired | Public method and constructor comments are required | 226–229 |
| CommentRequired | Public method and constructor comments are required | 231–234 |
| CommentRequired | Public method and constructor comments are required | 236–239 |
| CommentRequired | Public method and constructor comments are required | 241–244 |
| CommentRequired | Public method and constructor comments are required | 246–249 |
| CommentRequired | Public method and constructor comments are required | 251–254 |
| CommentRequired | Public method and constructor comments are required | 256–259 |
| Rule | Violation | Line |
|---|---|---|
| ExcessiveImports | A high number of imports can indicate a high degree of coupling within an object. | 34–1129 |
| MissingSerialVersionUID | Classes implementing Serializable should set a serialVersionUID | 83–1129 |
| ExcessiveClassLength | Avoid really long classes. | 83–1129 |
| NPathComplexity | The method 'getManageProposals(HttpServletRequest)' has an NPath complexity of 10250 | 214–308 |
| CyclomaticComplexity | The method 'getManageProposals(HttpServletRequest)' has a cyclomatic complexity of 16. | 214–308 |
| NullAssignment | Assigning an Object to null is a code smell. Consider refactoring. | 216 |
| NullAssignment | Assigning an Object to null is a code smell. Consider refactoring. | 217 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 218 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 293 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 294 |
| AddEmptyString | Do not add empty strings | 297 |
| AddEmptyString | Do not add empty strings | 299 |
| UnnecessaryAnnotationValueElement | Avoid the use of value in annotations when its the only element | 322 |
| NcssCount | The method 'doSearchProposal(HttpServletRequest)' has a NCSS line count of 64. | 323–461 |
| NPathComplexity | The method 'doSearchProposal(HttpServletRequest)' has an NPath complexity of 118098 | 323–461 |
| CyclomaticComplexity | The method 'doSearchProposal(HttpServletRequest)' has a cyclomatic complexity of 22. | 323–461 |
| ExcessiveMethodLength | Avoid really long methods. | 323–461 |
| UnnecessaryAnnotationValueElement | Avoid the use of value in annotations when its the only element | 470 |
| NullAssignment | Assigning an Object to null is a code smell. Consider refactoring. | 473 |
| CommentRequired | Public method and constructor comments are required | 486–496 |
| CommentRequired | Public method and constructor comments are required | 499–530 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 501 |
| UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 509 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 509 |
| CyclomaticComplexity | The method 'doCreateProposal(HttpServletRequest)' has a cyclomatic complexity of 15. | 533–650 |
| CommentRequired | Public method and constructor comments are required | 533–650 |
| NcssCount | The method 'doCreateProposal(HttpServletRequest)' has a NCSS line count of 66. | 533–650 |
| NPathComplexity | The method 'doCreateProposal(HttpServletRequest)' has an NPath complexity of 486 | 533–650 |
| ExcessiveMethodLength | Avoid really long methods. | 533–650 |
| UseCollectionIsEmpty | Substitute calls to size() == 0 (or size() != 0, size() > 0, size() < 1) with calls to isEmpty() | 572 |
| AvoidCatchingGenericException | Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 624 |
| NullAssignment | Assigning an Object to null is a code smell. Consider refactoring. | 646 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 682–689 |
| AvoidCatchingGenericException | Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 732 |
| UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 788 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 788 |
| UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 822 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 822 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 857 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 862 |
| ShortVariable | Avoid variables with short names like os | 935 |
| CyclomaticComplexity | The method 'copyProposalBoFormToProposal(ProposalBoForm, Proposal)' has a cyclomatic complexity of 14. | 958–1051 |
| NPathComplexity | The method 'copyProposalBoFormToProposal(ProposalBoForm, Proposal)' has an NPath complexity of 2560 | 958–1051 |
| AvoidCatchingGenericException | Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 1119 |
| Rule | Violation | Line |
|---|---|---|
| NullAssignment | Assigning an Object to null is a code smell. Consider refactoring. | 160 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 161 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 205 |
| UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 287 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 287 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 288 |
| UnnecessaryAnnotationValueElement | Avoid the use of value in annotations when its the only element | 452 |
| UnnecessaryAnnotationValueElement | Avoid the use of value in annotations when its the only element | 511 |
| NullAssignment | Assigning an Object to null is a code smell. Consider refactoring. | 514 |
| UnusedFormalParameter | Avoid unused method parameters such as 'request'. | 548 |
| Rule | Violation | Line |
|---|---|---|
| ExcessiveImports | A high number of imports can indicate a high degree of coupling within an object. | 34–333 |
| ImmutableField | Private field '_resourceExtenderHistoryService' could be made final; it is only initialized in the declaration or constructor. | 121 |
| ControlStatementBraces | This statement should have braces | 138 |
| UseUnderscoresInNumericLiterals | Number 10000 should separate every third digit with an underscore | 150 |
| UnusedLocalVariable | Avoid unused local variables such as 'wrapper'. | 169 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 169 |
| ControlStatementBraces | This statement should have braces | 194 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 234 |
| UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 234 |
| NonThreadSafeSingleton | Singleton is not thread safe | 266–269 |
| UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 282 |
| UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 283 |
| UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 313 |
| Rule | Violation | Line |
|---|---|---|
| MissingSerialVersionUID | Classes implementing Serializable should set a serialVersionUID | 61–167 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 91 |
| UnnecessaryAnnotationValueElement | Avoid the use of value in annotations when its the only element | 120 |
| ForLoopCanBeForeach | This for loop can be replaced by a foreach loop | 140–148 |
| Rule | Violation | Line |
|---|---|---|
| ExcessiveImports | A high number of imports can indicate a high degree of coupling within an object. | 34–373 |
| AvoidDuplicateLiterals | The String literal "proposal" appears 4 times in this file; the first occurrence is on line 76 | 76 |
| NPathComplexity | The method 'getViewProposal(HttpServletRequest)' has an NPath complexity of 576 | 145–236 |
| CyclomaticComplexity | The method 'getViewProposal(HttpServletRequest)' has a cyclomatic complexity of 16. | 145–236 |
| NullAssignment | Assigning an Object to null is a code smell. Consider refactoring. | 155 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 159–166 |
| NullAssignment | Assigning an Object to null is a code smell. Consider refactoring. | 165 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 168 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 170 |
| CollapsibleIfStatements | These nested if statements could be combined | 176–179 |
| AvoidDeeplyNestedIfStmts | Deeply nested if..then statements are hard to read | 220–223 |
| UnnecessaryAnnotationValueElement | Avoid the use of value in annotations when its the only element | 238 |
| CommentRequired | Public method and constructor comments are required | 239–339 |
| ExcessiveMethodLength | Avoid really long methods. | 239–339 |
| NPathComplexity | The method 'doContacterSubmitter(HttpServletRequest)' has an NPath complexity of 2304 | 239–339 |
| CyclomaticComplexity | The method 'doContacterSubmitter(HttpServletRequest)' has a cyclomatic complexity of 15. | 239–339 |
| NullAssignment | Assigning an Object to null is a code smell. Consider refactoring. | 250 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 254–261 |
| NullAssignment | Assigning an Object to null is a code smell. Consider refactoring. | 260 |
| UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 263 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 263 |
| AddEmptyString | Do not add empty strings | 265 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 285 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 285 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 288 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 291 |
| UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 291 |
| ShortVariable | Avoid variables with short names like t | 313 |
| AvoidCatchingGenericException | Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 316 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 325–336 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 365 |
| AddEmptyString | Do not add empty strings | 365 |
| Rule | Violation | Line |
|---|---|---|
| CommentRequired | Public method and constructor comments are required | 81–144 |
| InefficientStringBuffering | Avoid concatenating nonliterals in a StringBuffer/StringBuilder constructor or append(). | 106 |
| InefficientStringBuffering | Avoid concatenating nonliterals in a StringBuffer/StringBuilder constructor or append(). | 116 |
| InefficientStringBuffering | Avoid concatenating nonliterals in a StringBuffer/StringBuilder constructor or append(). | 127 |
| Rule | Violation | Line |
|---|---|---|
| MissingSerialVersionUID | Classes implementing Serializable should set a serialVersionUID | 54–245 |
| UnusedPrivateField | Avoid unused private fields such as 'PROPERTY_DEFAULT_LIST_SUBMITTER_PER_PAGE'. | 81 |
| NullAssignment | Assigning an Object to null is a code smell. Consider refactoring. | 114 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 131 |
| Rule | Violation | Line |
|---|---|---|
| MissingSerialVersionUID | Classes implementing Serializable should set a serialVersionUID | 54–245 |
| UnusedPrivateField | Avoid unused private fields such as 'PROPERTY_DEFAULT_LIST_SUBMITTER_PER_PAGE'. | 81 |
| NullAssignment | Assigning an Object to null is a code smell. Consider refactoring. | 114 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 131 |
| Rule | Violation | Line |
|---|---|---|
| CommentRequired | Header comments are required | 43–69 |
| CommentDefaultAccessModifier | To avoid mistakes add a comment at the beginning of the _bValidated field if you want a default access modifier | 46 |
| DefaultPackage | Use explicit scoping instead of the default package private level | 46 |
| MissingOverride | The method 'isValidated()' is missing an @Override annotation. | 60–63 |
| CommentRequired | Public method and constructor comments are required | 60–63 |
| CommentRequired | Public method and constructor comments are required | 65–68 |
| MissingOverride | The method 'setValidated(boolean)' is missing an @Override annotation. | 65–68 |
| Rule | Violation | Line |
|---|---|---|
| CommentRequired | Header comments are required | 36–39 |
| Rule | Violation | Line |
|---|---|---|
| CommentRequired | Header comments are required | 55–271 |
| UnusedPrivateField | Avoid unused private fields such as 'I18N_ERROR_FIELD4_COMPLEMENT_MIN_LENGTH'. | 68 |
| UnusedPrivateField | Avoid unused private fields such as 'I18N_ERROR_FIELD4_COMPLEMENT_MAX_LENGTH'. | 69 |
| UnusedPrivateField | Avoid unused private fields such as 'DSKEY_FIELD4_COMPLEMENT_MIN_LENGTH'. | 73 |
| UnusedPrivateField | Avoid unused private fields such as 'DSKEY_FIELD4_COMPLEMENT_MAX_LENGTH'. | 74 |
| UseUnderscoresInNumericLiterals | Number 10000 should separate every third digit with an underscore | 77 |
| CommentRequired | Public method and constructor comments are required | 84–87 |
| CommentRequired | Public method and constructor comments are required | 89–92 |
| CommentRequired | Public method and constructor comments are required | 96–99 |
| CommentRequired | Public method and constructor comments are required | 101–104 |
| FieldDeclarationsShouldBeAtStartOfClass | Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. | 108 |
| CommentRequired | Public method and constructor comments are required | 110–113 |
| CommentRequired | Public method and constructor comments are required | 115–118 |
| FieldDeclarationsShouldBeAtStartOfClass | Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. | 122 |
| CommentRequired | Public method and constructor comments are required | 124–127 |
| CommentRequired | Public method and constructor comments are required | 129–132 |
| FieldDeclarationsShouldBeAtStartOfClass | Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. | 136 |
| CommentRequired | Public method and constructor comments are required | 138–141 |
| CommentRequired | Public method and constructor comments are required | 143–146 |
| NPathComplexity | The method 'checkValidationErrorsLocalized(HttpServletRequest, Proposal, Locale)' has an NPath complexity of 4992 | 151–269 |
| CyclomaticComplexity | The method 'checkValidationErrorsLocalized(HttpServletRequest, Proposal, Locale)' has a cyclomatic complexity of 23. | 151–269 |
| ExcessiveMethodLength | Avoid really long methods. | 151–269 |
| UnusedLocalVariable | Avoid unused local variables such as 'userUid'. | 154 |
| AvoidLiteralsInIfCondition | Avoid using Literals in Conditional Statements | 164 |
| AvoidLiteralsInIfCondition | Avoid using Literals in Conditional Statements | 184 |
| AvoidLiteralsInIfCondition | Avoid using Literals in Conditional Statements | 214 |
| AddEmptyString | Do not add empty strings | 225 |
| AddEmptyString | Do not add empty strings | 232 |
| CollapsibleIfStatements | These nested if statements could be combined | 241–265 |
| AvoidLiteralsInIfCondition | Avoid using Literals in Conditional Statements | 243 |
| AddEmptyString | Do not add empty strings | 254 |
| AddEmptyString | Do not add empty strings | 261 |
| Rule | Violation | Line |
|---|---|---|
| CommentRequired | Header comments are required | 52–238 |
| UnusedPrivateField | Avoid unused private fields such as 'I18N_ERROR_ADRESS_FORMAT'. | 56 |
| UnusedPrivateField | Avoid unused private fields such as 'I18N_ERROR_ADRESS_NOT_VALID'. | 57 |
| UnusedPrivateField | Avoid unused private fields such as 'I18N_ERROR_ADRESS_ARDT_MISMATCH'. | 58 |
| CommentRequired | Public method and constructor comments are required | 99–102 |
| CommentRequired | Public method and constructor comments are required | 104–107 |
| CommentRequired | Public method and constructor comments are required | 130–133 |
| CommentRequired | Public method and constructor comments are required | 135–138 |
| CommentRequired | Public method and constructor comments are required | 203–206 |
| CommentRequired | Public method and constructor comments are required | 208–211 |
| CommentRequired | Public method and constructor comments are required | 213–216 |
| CommentRequired | Public method and constructor comments are required | 218–221 |
| CommentRequired | Public method and constructor comments are required | 223–226 |
| CommentRequired | Public method and constructor comments are required | 228–231 |
| CommentRequired | Public method and constructor comments are required | 233–237 |
| Rule | Violation | Line |
|---|---|---|
| CommentRequired | Header comments are required | 36–57 |
| Rule | Violation | Line |
|---|---|---|
| CommentRequired | Header comments are required | 52–217 |
| CommentRequired | Public method and constructor comments are required | 77–80 |
| CommentRequired | Public method and constructor comments are required | 82–85 |
| CommentRequired | Public method and constructor comments are required | 87–90 |
| CommentRequired | Public method and constructor comments are required | 92–95 |
| CommentRequired | Public method and constructor comments are required | 97–100 |
| CommentRequired | Public method and constructor comments are required | 102–105 |
| NPathComplexity | The method 'checkValidationErrorsLocalized(HttpServletRequest, Proposal, Locale)' has an NPath complexity of 2304 | 108–215 |
| CyclomaticComplexity | The method 'checkValidationErrorsLocalized(HttpServletRequest, Proposal, Locale)' has a cyclomatic complexity of 21. | 108–215 |
| ExcessiveMethodLength | Avoid really long methods. | 108–215 |
| AvoidLiteralsInIfCondition | Avoid using Literals in Conditional Statements | 115 |
| AvoidLiteralsInIfCondition | Avoid using Literals in Conditional Statements | 134 |
| AvoidLiteralsInIfCondition | Avoid using Literals in Conditional Statements | 163 |
| AddEmptyString | Do not add empty strings | 174 |
| AddEmptyString | Do not add empty strings | 181 |
| AvoidLiteralsInIfCondition | Avoid using Literals in Conditional Statements | 190 |
| AddEmptyString | Do not add empty strings | 201 |
| AddEmptyString | Do not add empty strings | 208 |
| Rule | Violation | Line |
|---|---|---|
| CommentRequired | Header comments are required | 45–117 |
| CommentDefaultAccessModifier | To avoid mistakes add a comment at the beginning of the _ideationUploadHandler field if you want a default access modifier | 52 |
| DefaultPackage | Use explicit scoping instead of the default package private level | 52 |
| CommentRequired | Public method and constructor comments are required | 54–57 |
| CommentRequired | Public method and constructor comments are required | 59–62 |
| CommentRequired | Public method and constructor comments are required | 64–71 |
| AvoidDuplicateLiterals | The String literal "participatoryideation.ProposalAsynchronousHandler" appears 4 times in this file; the first occurrence is on line 68 | 68 |
| CommentRequired | Public method and constructor comments are required | 73–80 |
| CommentRequired | Public method and constructor comments are required | 82–89 |
| Rule | Violation | Line |
|---|---|---|
| CommentRequired | Header comments are required | 43–53 |
| CommentRequired | Public method and constructor comments are required | 46 |
| CommentRequired | Public method and constructor comments are required | 48 |
| CommentRequired | Public method and constructor comments are required | 50 |
| CommentRequired | Public method and constructor comments are required | 52 |
| Rule | Violation | Line |
|---|---|---|
| UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 114 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 114 |
| UseUnderscoresInNumericLiterals | Number 10000 should separate every third digit with an underscore | 137 |
| NonThreadSafeSingleton | Singleton is not thread safe | 167–170 |
| UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 183 |
| UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 184 |
| UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 214 |
| Rule | Violation | Line |
|---|---|---|
| UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 132 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 132 |
| Rule | Violation | Line |
|---|---|---|
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 152 |
| UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 152 |
| Rule | Violation | Line |
|---|---|---|
| ShortClassName | Avoid short class names like Link | 41–161 |
| Rule | Violation | Line |
|---|---|---|
| BooleanGetMethodName | A getX() method which returns a boolean should be named isX() | 884–888 |
| Rule | Violation | Line |
|---|---|---|
| UnusedImports | Avoid unused imports such as 'java.util.Locale' | 38 |
| UnusedImports | Avoid unused imports such as 'fr.paris.lutece.portal.service.security.LuteceUser' | 49 |
| UnusedImports | Avoid unused imports such as 'fr.paris.lutece.portal.service.security.SecurityService' | 50 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| CommentRequired | Header comments are required | 3 | 36–146 |
| DefaultPackage | Use explicit scoping instead of the default package private level | 3 | 38 |
| CommentDefaultAccessModifier | To avoid mistakes add a comment at the beginning of the _strType field if you want a default access modifier | 3 | 38 |
| CommentDefaultAccessModifier | To avoid mistakes add a comment at the beginning of the _strId field if you want a default access modifier | 3 | 39 |
| DefaultPackage | Use explicit scoping instead of the default package private level | 3 | 39 |
| DefaultPackage | Use explicit scoping instead of the default package private level | 3 | 40 |
| CommentDefaultAccessModifier | To avoid mistakes add a comment at the beginning of the _strLibelle field if you want a default access modifier | 3 | 40 |
| DefaultPackage | Use explicit scoping instead of the default package private level | 3 | 41 |
| CommentDefaultAccessModifier | To avoid mistakes add a comment at the beginning of the _strGpruNom field if you want a default access modifier | 3 | 41 |
| DefaultPackage | Use explicit scoping instead of the default package private level | 3 | 42 |
| CommentDefaultAccessModifier | To avoid mistakes add a comment at the beginning of the _strExtBp field if you want a default access modifier | 3 | 42 |
| CommentDefaultAccessModifier | To avoid mistakes add a comment at the beginning of the _strFid field if you want a default access modifier | 3 | 43 |
| DefaultPackage | Use explicit scoping instead of the default package private level | 3 | 43 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| CommentRequired | Header comments are required | 3 | 81–119 |
| DataClass | The class 'QpvQvaRestResponse' is suspected to be a Data Class (WOC=0.000%, NOPA=7, NOAM=1, WMC=1) | 3 | 81–119 |
| CommentDefaultAccessModifier | To avoid mistakes add a comment at the beginning of the _features field if you want a default access modifier | 3 | 91 |
| DefaultPackage | Use explicit scoping instead of the default package private level | 3 | 91 |
| UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 3 | 96 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| ShortClassName | Avoid short class names like Link | 4 | 41–161 |
| DataClass | The class 'Link' is suspected to be a Data Class (WOC=11.111%, NOPA=0, NOAM=16, WMC=18) | 3 | 41–161 |
| CommentRequired | Public method and constructor comments are required | 3 | 60–63 |
| FormalParameterNamingConventions | The method parameter name '_nId' doesn't match '[a-z][a-zA-Z0-9]*' | 1 | 65 |
| CommentRequired | Public method and constructor comments are required | 3 | 65–68 |
| FormalParameterNamingConventions | The method parameter name '_parentId' doesn't match '[a-z][a-zA-Z0-9]*' | 1 | 75 |
| FormalParameterNamingConventions | The method parameter name '_childId' doesn't match '[a-z][a-zA-Z0-9]*' | 1 | 85 |
| FormalParameterNamingConventions | The method parameter name '_parentCodeCampaign' doesn't match '[a-z][a-zA-Z0-9]*' | 1 | 95 |
| FormalParameterNamingConventions | The method parameter name '_childCodeCampaign' doesn't match '[a-z][a-zA-Z0-9]*' | 1 | 105 |
| FormalParameterNamingConventions | The method parameter name '_parentCodeProposal' doesn't match '[a-z][a-zA-Z0-9]*' | 1 | 115 |
| FormalParameterNamingConventions | The method parameter name '_childCodeProposal' doesn't match '[a-z][a-zA-Z0-9]*' | 1 | 125 |
| FormalParameterNamingConventions | The method parameter name '_parentTitle' doesn't match '[a-z][a-zA-Z0-9]*' | 1 | 135 |
| FormalParameterNamingConventions | The method parameter name '_childTitle' doesn't match '[a-z][a-zA-Z0-9]*' | 1 | 145 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 3 | 226 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 3 | 228 |
| UnnecessaryLocalBeforeReturn | Consider simply returning the value vs storing it in local variable 'result' | 3 | 245 |
| InsufficientStringBufferDeclaration | StringBuffer constructor is initialized with size 16, but has at least 149 characters appended. | 3 | 280 |
| InsufficientStringBufferDeclaration | StringBuffer constructor is initialized with size 16, but has at least 60 characters appended. | 3 | 284 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| CommentRequired | Public method and constructor comments are required | 3 | 51–54 |
| CommentRequired | Public method and constructor comments are required | 3 | 56–59 |
| CommentRequired | Public method and constructor comments are required | 3 | 61–64 |
| CommentRequired | Public method and constructor comments are required | 3 | 66–69 |
| CommentRequired | Public method and constructor comments are required | 3 | 71–74 |
| CommentRequired | Public method and constructor comments are required | 3 | 76–79 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| AvoidSynchronizedAtMethodLevel | Use block level rather than method level synchronization | 3 | 54–66 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| AvoidSynchronizedAtMethodLevel | Use block level rather than method level synchronization | 3 | 57–76 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| LinguisticNaming | Linguistics Antipattern - The method 'hasParent' indicates linguistically it returns a boolean, but it returns 'int' | 3 | 128 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| ExcessivePublicCount | This class has a bunch of public methods and attributes | 3 | 34–914 |
| CyclomaticComplexity | The class 'Proposal' has a total cyclomatic complexity of 85 (highest 2). | 3 | 53–914 |
| TooManyFields | Too many fields | 3 | 53–914 |
| FieldNamingConventions | The constant name 'valueMap' doesn't match '[A-Z][A-Z_0-9]*' | 1 | 129 |
| FieldNamingConventions | The constant name 'listStatusPublished' doesn't match '[A-Z][A-Z_0-9]*' | 1 | 130 |
| FieldNamingConventions | The constant name 'listStatusUnPublished' doesn't match '[A-Z][A-Z_0-9]*' | 1 | 131 |
| CommentRequired | Public method and constructor comments are required | 3 | 150–153 |
| CommentRequired | Public method and constructor comments are required | 3 | 155–158 |
| CommentRequired | Public method and constructor comments are required | 3 | 160–163 |
| FieldDeclarationsShouldBeAtStartOfClass | Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. | 3 | 165 |
| FieldDeclarationsShouldBeAtStartOfClass | Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. | 3 | 166 |
| FieldDeclarationsShouldBeAtStartOfClass | Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. | 3 | 167 |
| CommentRequired | Public method and constructor comments are required | 3 | 176–179 |
| CommentRequired | Public method and constructor comments are required | 3 | 181–184 |
| CommentRequired | Public method and constructor comments are required | 3 | 186–189 |
| CommentRequired | Public method and constructor comments are required | 3 | 228–231 |
| FormalParameterNamingConventions | The method parameter name '_dLatitude' doesn't match '[a-z][a-zA-Z0-9]*' | 1 | 233 |
| CommentRequired | Public method and constructor comments are required | 3 | 233–236 |
| CommentRequired | Public method and constructor comments are required | 3 | 322–325 |
| CommentRequired | Public method and constructor comments are required | 3 | 327–330 |
| FormalParameterNamingConventions | The method parameter name '_strField4' doesn't match '[a-z][a-zA-Z0-9]*' | 1 | 327 |
| CommentRequired | Public method and constructor comments are required | 3 | 332–335 |
| CommentRequired | Public method and constructor comments are required | 3 | 337–340 |
| FormalParameterNamingConventions | The method parameter name '_strField4Complement' doesn't match '[a-z][a-zA-Z0-9]*' | 1 | 337 |
| FormalParameterNamingConventions | The method parameter name '_nCout' doesn't match '[a-z][a-zA-Z0-9]*' | 1 | 463 |
| CommentRequired | Public method and constructor comments are required | 3 | 468–471 |
| CommentRequired | Public method and constructor comments are required | 3 | 473–476 |
| FormalParameterNamingConventions | The method parameter name '_strLocationType' doesn't match '[a-z][a-zA-Z0-9]*' | 1 | 473 |
| CommentRequired | Public method and constructor comments are required | 3 | 478–481 |
| FormalParameterNamingConventions | The method parameter name '_strAdress' doesn't match '[a-z][a-zA-Z0-9]*' | 1 | 483 |
| CommentRequired | Public method and constructor comments are required | 3 | 483–486 |
| CommentRequired | Public method and constructor comments are required | 3 | 488–491 |
| FormalParameterNamingConventions | The method parameter name '_strLocationArdt' doesn't match '[a-z][a-zA-Z0-9]*' | 1 | 493 |
| CommentRequired | Public method and constructor comments are required | 3 | 493–496 |
| CommentRequired | Public method and constructor comments are required | 3 | 498–501 |
| CommentRequired | Public method and constructor comments are required | 3 | 503–506 |
| FormalParameterNamingConventions | The method parameter name '_strSubmitterType' doesn't match '[a-z][a-zA-Z0-9]*' | 1 | 503 |
| CommentRequired | Public method and constructor comments are required | 3 | 508–511 |
| CommentRequired | Public method and constructor comments are required | 3 | 513–516 |
| FormalParameterNamingConventions | The method parameter name '_dLongitude' doesn't match '[a-z][a-zA-Z0-9]*' | 1 | 513 |
| CommentRequired | Public method and constructor comments are required | 3 | 518–521 |
| FormalParameterNamingConventions | The method parameter name '_bAcceptExploit' doesn't match '[a-z][a-zA-Z0-9]*' | 1 | 523 |
| CommentRequired | Public method and constructor comments are required | 3 | 523–526 |
| CommentRequired | Public method and constructor comments are required | 3 | 528–531 |
| CommentRequired | Public method and constructor comments are required | 3 | 533–536 |
| CommentRequired | Public method and constructor comments are required | 3 | 538–541 |
| CommentRequired | Public method and constructor comments are required | 3 | 543–546 |
| FormalParameterNamingConventions | The method parameter name '_strSubmitter' doesn't match '[a-z][a-zA-Z0-9]*' | 1 | 543 |
| FormalParameterNamingConventions | The method parameter name '_creationTimestamp' doesn't match '[a-z][a-zA-Z0-9]*' | 1 | 708 |
| CommentRequired | Public method and constructor comments are required | 3 | 803–806 |
| CommentRequired | Public method and constructor comments are required | 3 | 828–831 |
| FormalParameterNamingConventions | The method parameter name '_strMotifRecev' doesn't match '[a-z][a-zA-Z0-9]*' | 1 | 833 |
| CommentRequired | Public method and constructor comments are required | 3 | 833–836 |
| BooleanGetMethodName | A getX() method which returns a boolean should be named isX() | 4 | 884–888 |
| FormalParameterNamingConventions | The method parameter name '_strCodeCampaign' doesn't match '[a-z][a-zA-Z0-9]*' | 1 | 909 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| GodClass | Possible God Class (WMC=70, ATFD=130, TCC=0.265%) | 3 | 60–991 |
| TooManyMethods | This class has too many methods, consider refactoring it. | 3 | 61–991 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 3 | 160–167 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 3 | 178–185 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 3 | 187–194 |
| NullAssignment | Assigning an Object to null is a code smell. Consider refactoring. | 3 | 202 |
| NullAssignment | Assigning an Object to null is a code smell. Consider refactoring. | 3 | 203 |
| ShortVariable | Avoid variables with short names like id | 3 | 224 |
| ShortVariable | Avoid variables with short names like id | 3 | 229 |
| ShortVariable | Avoid variables with short names like id | 3 | 258 |
| UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 3 | 335 |
| UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 3 | 336 |
| UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 3 | 383 |
| AvoidReassigningParameters | Avoid reassigning parameters such as 'nCpt' | 2 | 407 |
| AvoidReassigningParameters | Avoid reassigning parameters such as 'nCpt' | 2 | 407 |
| AvoidReassigningParameters | Avoid reassigning parameters such as 'nCpt' | 2 | 407 |
| AvoidBranchingStatementAsLastInLoop | Avoid using a branching statement as the last in a loop. | 2 | 428 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 3 | 447–454 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 3 | 456–463 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 3 | 477–485 |
| ExcessiveMethodLength | Avoid really long methods. | 3 | 512–613 |
| NPathComplexity | The method 'selectProposalsListSearch(Plugin, ProposalSearcher)' has an NPath complexity of 6480 | 3 | 512–613 |
| CyclomaticComplexity | The method 'selectProposalsListSearch(Plugin, ProposalSearcher)' has a cyclomatic complexity of 18. | 3 | 512–613 |
| UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 3 | 514 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 3 | 514 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 3 | 516 |
| UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 3 | 543 |
| UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 3 | 611 |
| UnnecessaryLocalBeforeReturn | Consider simply returning the value vs storing it in local variable 'result' | 3 | 612 |
| UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 3 | 621 |
| NcssCount | The method 'appendFilters(String, ProposalSearcher)' has a NCSS line count of 68. | 3 | 700–832 |
| NPathComplexity | The method 'appendFilters(String, ProposalSearcher)' has an NPath complexity of 2211840 | 3 | 700–832 |
| ExcessiveMethodLength | Avoid really long methods. | 3 | 700–832 |
| CyclomaticComplexity | The method 'appendFilters(String, ProposalSearcher)' has a cyclomatic complexity of 26. | 3 | 700–832 |
| ConsecutiveLiteralAppends | StringBuffer (or StringBuilder).append is called 6 consecutive times with literals. Use a single append with a single combined String. | 3 | 728 |
| AvoidDuplicateLiterals | The String literal " proposals.type_nqpv_qva != ? AND" appears 6 times in this file; the first occurrence is on line 728 | 3 | 728 |
| InsufficientStringBufferDeclaration | StringBuffer constructor is initialized with size 16, but has at least 415 characters appended. | 3 | 775 |
| AppendCharacterWithChar | Avoid appending characters as strings in StringBuffer.append. | 3 | 788 |
| AppendCharacterWithChar | Avoid appending characters as strings in StringBuffer.append. | 3 | 794 |
| AppendCharacterWithChar | Avoid appending characters as strings in StringBuffer.append. | 3 | 807 |
| AppendCharacterWithChar | Avoid appending characters as strings in StringBuffer.append. | 3 | 817 |
| NPathComplexity | The method 'setFilterValues(DAOUtil, ProposalSearcher)' has an NPath complexity of 2304 | 3 | 842–908 |
| CyclomaticComplexity | The method 'setFilterValues(DAOUtil, ProposalSearcher)' has a cyclomatic complexity of 13. | 3 | 842–908 |
| InsufficientStringBufferDeclaration | StringBuffer constructor is initialized with size 16, but has at least 32 characters appended. | 3 | 912 |
| AppendCharacterWithChar | Avoid appending characters as strings in StringBuffer.append. | 3 | 916 |
| ConsecutiveLiteralAppends | StringBuffer (or StringBuilder).append is called 2 consecutive times with literals. Use a single append with a single combined String. | 3 | 918 |
| AppendCharacterWithChar | Avoid appending characters as strings in StringBuffer.append. | 3 | 918 |
| AppendCharacterWithChar | Avoid appending characters as strings in StringBuffer.append. | 3 | 919 |
| UnusedPrivateMethod | Avoid unused private methods such as 'insertLink(int,int,Plugin)'. | 3 | 955 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| LinguisticNaming | Linguistics Antipattern - The method 'hasParent' indicates linguistically it returns a boolean, but it returns 'int' | 3 | 160–163 |
| UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 3 | 247 |
| LocalVariableNamingConventions | The local variable name '_ids' doesn't match '[a-z][a-zA-Z0-9]*' | 1 | 247 |
| LocalVariableNamingConventions | The local variable name '_proposal' doesn't match '[a-z][a-zA-Z0-9]*' | 1 | 253 |
| AvoidDeeplyNestedIfStmts | Deeply nested if..then statements are hard to read | 3 | 259–264 |
| LocalVariableNamingConventions | The local variable name '_newMethod' doesn't match '[a-z][a-zA-Z0-9]*' | 1 | 261 |
| LocalVariableNamingConventions | The local variable name '_nIds' doesn't match '[a-z][a-zA-Z0-9]*' | 1 | 280 |
| LocalVariableNamingConventions | The local variable name '_proposal' doesn't match '[a-z][a-zA-Z0-9]*' | 1 | 284 |
| SwitchStmtsShouldHaveDefault | Switch statements should have a default label | 3 | 288–302 |
| ShortVariable | Avoid variables with short names like s | 3 | 306 |
| CyclomaticComplexity | The method 'getSubProposalsNicknamesNiceText(int, GetSubProposalsMethod, String)' has a cyclomatic complexity of 23. | 3 | 313–380 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 316 |
| LocalVariableNamingConventions | The local variable name '_nIds' doesn't match '[a-z][a-zA-Z0-9]*' | 1 | 318 |
| SwitchStmtsShouldHaveDefault | Switch statements should have a default label | 3 | 327–341 |
| AvoidLiteralsInIfCondition | Avoid using Literals in Conditional Statements | 3 | 352 |
| ControlStatementBraces | This statement should have braces | 3 | 363–364 |
| ControlStatementBraces | This statement should have braces | 3 | 367–368 |
| ControlStatementBraces | This statement should have braces | 3 | 371–372 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| FormalParameterNamingConventions | The method parameter name 'CodeCampaign' doesn't match '[a-z][a-zA-Z0-9]*' | 1 | 77 |
| FormalParameterNamingConventions | The method parameter name 'CodeTheme' doesn't match '[a-z][a-zA-Z0-9]*' | 1 | 94 |
| CommentRequired | Public method and constructor comments are required | 3 | 172–175 |
| CommentRequired | Public method and constructor comments are required | 3 | 177–180 |
| FormalParameterNamingConventions | The method parameter name '_strLuteceUserName' doesn't match '[a-z][a-zA-Z0-9]*' | 1 | 230 |
| CommentRequired | Public method and constructor comments are required | 3 | 290–293 |
| CommentRequired | Public method and constructor comments are required | 3 | 295–298 |
| FormalParameterNamingConventions | The method parameter name '_bIsPublished' doesn't match '[a-z][a-zA-Z0-9]*' | 1 | 295 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 3 | 220 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| TooManyMethods | This class has too many methods, consider refactoring it. | 3 | 51–359 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 3 | 282 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 3 | 331 |
| UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 3 | 347 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| CommentRequired | Header comments are required | 3 | 47–106 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| CommentRequired | Header comments are required | 3 | 38–59 |
| UnnecessaryModifier | Unnecessary modifier 'public' on method 'fillCampaignStaticContent': the method is declared in an interface type | 3 | 49 |
| UnnecessaryModifier | Unnecessary modifier 'public' on method 'fillAllStaticContent': the method is declared in an interface type | 3 | 57 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| CommentRequired | Header comments are required | 3 | 43–95 |
| CommentRequired | Public method and constructor comments are required | 3 | 46 |
| CommentRequired | Public method and constructor comments are required | 3 | 48 |
| CommentRequired | Public method and constructor comments are required | 3 | 50 |
| CommentRequired | Public method and constructor comments are required | 3 | 52 |
| CommentRequired | Public method and constructor comments are required | 3 | 64 |
| CommentRequired | Public method and constructor comments are required | 3 | 66 |
| CommentRequired | Public method and constructor comments are required | 3 | 68 |
| CommentRequired | Public method and constructor comments are required | 3 | 70 |
| CommentRequired | Public method and constructor comments are required | 3 | 72 |
| CommentRequired | Public method and constructor comments are required | 3 | 74 |
| UnnecessaryModifier | Unnecessary modifier 'public' on method 'getUniqueUserGuidsProposalsSubmitters': the method is declared in an interface type | 3 | 88 |
| UnnecessaryModifier | Unnecessary modifier 'public' on method 'getUniqueUserGuidsProposalsFollowers': the method is declared in an interface type | 3 | 93 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| CommentRequired | Header comments are required | 3 | 36–39 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| CommentRequired | Header comments are required | 3 | 43–117 |
| UnnecessaryModifier | Unnecessary modifier 'public' on method 'getProposalsList': the method is declared in an interface type | 3 | 51 |
| UnnecessaryModifier | Unnecessary modifier 'public' on method 'getProposalsListSearch': the method is declared in an interface type | 3 | 75 |
| UnnecessaryModifier | Unnecessary modifier 'public' on method 'updateProposal': the method is declared in an interface type | 3 | 84 |
| UnnecessaryModifier | Unnecessary modifier 'public' on method 'updateProposal': the method is declared in an interface type | 3 | 86 |
| CommentRequired | Public method and constructor comments are required | 3 | 86 |
| UnnecessaryModifier | Unnecessary modifier 'public' on method 'updateProposal': the method is declared in an interface type | 3 | 88 |
| CommentRequired | Public method and constructor comments are required | 3 | 88 |
| UnnecessaryModifier | Unnecessary modifier 'public' on method 'createComment': the method is declared in an interface type | 3 | 95 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| CallSuperInConstructor | It is a good practice to call super() in a constructor | 3 | 52–55 |
| ConstructorCallsOverridableMethod | Overridable method 'setErrorCode' called during object construction | 1 | 54 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| ShortVariable | Avoid variables with short names like se | 3 | 50 |
| ShortVariable | Avoid variables with short names like se | 3 | 59 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| CommentRequired | Header comments are required | 3 | 53–145 |
| UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 3 | 93 |
| UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 3 | 94 |
| UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 3 | 104 |
| ShortVariable | Avoid variables with short names like h | 3 | 104 |
| UseIndexOfChar | String.indexOf(char) is faster than String.indexOf(String). | 3 | 136 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| CommentRequired | Header comments are required | 3 | 56–267 |
| CommentRequired | Public method and constructor comments are required | 3 | 98–105 |
| NonThreadSafeSingleton | Singleton is not thread safe | 3 | 100–103 |
| CommentRequired | Public method and constructor comments are required | 3 | 107–110 |
| CallSuperInConstructor | It is a good practice to call super() in a constructor | 3 | 107–110 |
| CommentRequired | Public method and constructor comments are required | 3 | 112–115 |
| MissingOverride | The method 'getName()' is missing an @Override annotation. | 3 | 112–115 |
| MissingOverride | The method 'fillCampaignStaticContent(Map, String)' is missing an @Override annotation. | 3 | 125–164 |
| LocalVariableNamingConventions | The local variable name 'WorkflowStatesReferenceList' doesn't match '[a-z][a-zA-Z0-9]*' | 1 | 144 |
| MissingOverride | The method 'fillAllStaticContent(Map)' is missing an @Override annotation. | 3 | 174–195 |
| UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 3 | 207 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 3 | 207 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 3 | 214 |
| UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 3 | 214 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 3 | 235 |
| UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 3 | 235 |
| UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 3 | 243 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 3 | 243 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| CommentRequired | Header comments are required | 3 | 55–273 |
| UseUnderscoresInNumericLiterals | Number 2097152 should separate every third digit with an underscore | 3 | 76 |
| UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 3 | 81 |
| CyclomaticComplexity | The method 'canUploadFiles(HttpServletRequest, String, List, Locale)' has a cyclomatic complexity of 12. | 3 | 122–186 |
| NPathComplexity | The method 'canUploadFiles(HttpServletRequest, String, List, Locale)' has an NPath complexity of 264 | 3 | 122–186 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 124 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 125–126 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 129 |
| UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 3 | 248 |
| UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 3 | 258 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| CommentRequired | Header comments are required | 3 | 51–191 |
| PositionLiteralsFirstInComparisons | Position literals first in String comparisons | 3 | 115 |
| EmptyIfStmt | Avoid empty if statements | 3 | 121–123 |
| UseObjectForClearerAPI | Rather than using a lot of String arguments, consider using a container object for those values. | 3 | 148 |
| LocalVariableNamingConventions | The local variable name 'nId_Proposal' doesn't match '[a-z][a-zA-Z0-9]*' | 1 | 151 |
| EmptyIfStmt | Avoid empty if statements | 3 | 162–164 |
| SimplifyBooleanReturns | Avoid unnecessary if..then..else statements when returning booleans | 3 | 183–187 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| CommentRequired | Header comments are required | 3 | 43–67 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| CommentRequired | Header comments are required | 3 | 38–45 |
| CommentRequired | Public method and constructor comments are required | 3 | 41–44 |
| MissingOverride | The method 'getIcon(String)' is missing an @Override annotation. | 3 | 41–44 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| CommentRequired | Header comments are required | 3 | 47–66 |
| MissingOverride | The method 'getPopup(HttpServletRequest, String, String)' is missing an @Override annotation. | 3 | 56–65 |
| CommentRequired | Public method and constructor comments are required | 3 | 56–65 |
| UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 3 | 60 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 3 | 60 |
| ShortVariable | Avoid variables with short names like t | 3 | 63 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| CommentRequired | Header comments are required | 3 | 41–69 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| CommentRequired | Header comments are required | 3 | 63–298 |
| AvoidUsingVolatile | Use of modifier volatile is not recommended. | 2 | 79 |
| AvoidUsingVolatile | Use of modifier volatile is not recommended. | 2 | 80 |
| AvoidUsingVolatile | Use of modifier volatile is not recommended. | 2 | 82 |
| AvoidUsingVolatile | Use of modifier volatile is not recommended. | 2 | 83 |
| AvoidUsingVolatile | Use of modifier volatile is not recommended. | 2 | 85 |
| AvoidUsingVolatile | Use of modifier volatile is not recommended. | 2 | 86 |
| CommentRequired | Public method and constructor comments are required | 3 | 97–127 |
| NonThreadSafeSingleton | Singleton is not thread safe | 3 | 99–124 |
| UnusedFormalParameter | Avoid unused method parameters such as 'proposal'. | 3 | 129 |
| UnusedFormalParameter | Avoid unused method parameters such as 'type'. | 3 | 129 |
| MissingOverride | The method 'createProposalDB(Proposal)' is missing an @Override annotation. | 3 | 142–147 |
| CommentRequired | Public method and constructor comments are required | 3 | 142–147 |
| AvoidSynchronizedAtMethodLevel | Use block level rather than method level synchronization | 3 | 142–147 |
| MissingOverride | The method 'createProposal(Proposal)' is missing an @Override annotation. | 3 | 149–153 |
| CommentRequired | Public method and constructor comments are required | 3 | 149–153 |
| CommentRequired | Public method and constructor comments are required | 3 | 155–161 |
| MissingOverride | The method 'removeProposal(Proposal)' is missing an @Override annotation. | 3 | 163–169 |
| CommentRequired | Public method and constructor comments are required | 3 | 163–169 |
| CommentRequired | Public method and constructor comments are required | 3 | 171–177 |
| MissingOverride | The method 'removeProposalByMdp(Proposal)' is missing an @Override annotation. | 3 | 171–177 |
| MissingOverride | The method 'getQpvQvaCodesList()' is missing an @Override annotation. | 3 | 192–195 |
| MissingOverride | The method 'getQpvQvaCodesMap()' is missing an @Override annotation. | 3 | 200–203 |
| MissingOverride | The method 'getField4CodesList()' is missing an @Override annotation. | 3 | 208–211 |
| MissingOverride | The method 'getField4CodesMap()' is missing an @Override annotation. | 3 | 216–219 |
| MissingOverride | The method 'getTypeLocationList()' is missing an @Override annotation. | 3 | 224–227 |
| MissingOverride | The method 'getTypeLocationMap()' is missing an @Override annotation. | 3 | 232–235 |
| UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 3 | 248 |
| UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 3 | 277 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| CommentRequired | Header comments are required | 3 | 58–284 |
| UseUtilityClass | All methods are static. Consider using a utility class instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning. | 3 | 59–284 |
| NonThreadSafeSingleton | Singleton is not thread safe | 3 | 73–76 |
| NonThreadSafeSingleton | Singleton is not thread safe | 3 | 87–90 |
| FormalParameterNamingConventions | The method parameter name 'nId_Proposal' doesn't match '[a-z][a-zA-Z0-9]*' | 1 | 99 |
| UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 3 | 101 |
| FormalParameterNamingConventions | The method parameter name 'nId_Proposal' doesn't match '[a-z][a-zA-Z0-9]*' | 1 | 124 |
| UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 3 | 126 |
| UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 3 | 165 |
| UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 3 | 207 |
| UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 3 | 215 |
| FormalParameterNamingConventions | The method parameter name 'nId_Proposal' doesn't match '[a-z][a-zA-Z0-9]*' | 1 | 251 |
| FormalParameterNamingConventions | The method parameter name 'nId_Proposal' doesn't match '[a-z][a-zA-Z0-9]*' | 1 | 278 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| ExcessiveImports | A high number of imports can indicate a high degree of coupling within an object. | 3 | 34–340 |
| CommentRequired | Header comments are required | 3 | 71–340 |
| NonThreadSafeSingleton | Singleton is not thread safe | 3 | 93–100 |
| CyclomaticComplexity | The method 'updateProposal(Proposal, Proposal, boolean, HttpServletRequest)' has a cyclomatic complexity of 17. | 3 | 143–183 |
| EmptyIfStmt | Avoid empty if statements | 3 | 161–163 |
| AvoidReassigningParameters | Avoid reassigning parameters such as 'proposal' | 2 | 186 |
| UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 3 | 198 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 3 | 198 |
| ShortVariable | Avoid variables with short names like t | 3 | 202 |
| AvoidCatchingGenericException | Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 3 | 205 |
| AddEmptyString | Do not add empty strings | 3 | 212 |
| AddEmptyString | Do not add empty strings | 3 | 232 |
| LocalVariableNamingConventions | The local variable name '_service' doesn't match '[a-z][a-zA-Z0-9]*' | 1 | 260 |
| CommentRequired | Public method and constructor comments are required | 3 | 335–338 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| ExcessiveImports | A high number of imports can indicate a high degree of coupling within an object. | 3 | 34–471 |
| AvoidDuplicateLiterals | The String literal "proposal" appears 5 times in this file; the first occurrence is on line 78 | 3 | 78 |
| AvoidCatchingGenericException | Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 3 | 97 |
| LocalVariableNamingConventions | The local variable name 'SOLR_SERVER' doesn't match '[a-z][a-zA-Z0-9]*' | 1 | 112 |
| AvoidCatchingGenericException | Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 3 | 118 |
| CyclomaticComplexity | The method 'getItem(Proposal)' has a cyclomatic complexity of 18. | 3 | 130–260 |
| NPathComplexity | The method 'getItem(Proposal)' has an NPath complexity of 3840 | 3 | 130–260 |
| NcssCount | The method 'getItem(Proposal)' has a NCSS line count of 75. | 3 | 130–260 |
| ExcessiveMethodLength | Avoid really long methods. | 3 | 130–260 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 3 | 146–169 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 3 | 177–184 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 3 | 215–224 |
| UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 3 | 238 |
| ShortVariable | Avoid variables with short names like sb | 3 | 241 |
| InefficientStringBuffering | Avoid concatenating nonliterals in a StringBuffer/StringBuilder constructor or append(). | 3 | 242 |
| InefficientStringBuffering | Avoid concatenating nonliterals in a StringBuffer/StringBuilder constructor or append(). | 3 | 245 |
| InefficientStringBuffering | Avoid concatenating nonliterals in a StringBuffer/StringBuilder constructor or append(). | 3 | 251 |
| InefficientStringBuffering | Avoid concatenating nonliterals in a StringBuffer/StringBuilder constructor or append(). | 3 | 255 |
| ShortVariable | Avoid variables with short names like sb | 3 | 268 |
| MissingOverride | The method 'indexDocuments()' is missing an @Override annotation. | 3 | 330–382 |
| UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 3 | 334 |
| LocalVariableNamingConventions | The local variable name '_proposalSearcher' doesn't match '[a-z][a-zA-Z0-9]*' | 1 | 338 |
| UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 3 | 341 |
| UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 3 | 343 |
| AvoidCatchingGenericException | Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 3 | 348 |
| AvoidCatchingGenericException | Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 3 | 361 |
| AvoidCatchingGenericException | Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 3 | 374 |
| LocalVariableNamingConventions | The local variable name 'SOLR_SERVER' doesn't match '[a-z][a-zA-Z0-9]*' | 1 | 429 |
| AvoidCatchingGenericException | Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 3 | 436 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 3 | 454–467 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UnnecessaryModifier | Unnecessary modifiers 'public static final' on field 'WHOLE_AREA': the field is declared in an interface type | 3 | 49 |
| CommentRequired | Public method and constructor comments are required | 3 | 57 |
| UnnecessaryModifier | Unnecessary modifier 'public' on method 'getCampaigns': the method is declared in an interface type | 3 | 57 |
| UnnecessaryModifier | Unnecessary modifier 'public' on method 'getLastCampaign': the method is declared in an interface type | 3 | 60 |
| CommentRequired | Public method and constructor comments are required | 3 | 60 |
| CommentRequired | Public method and constructor comments are required | 3 | 68 |
| UnnecessaryModifier | Unnecessary modifier 'public' on method 'isBeforeBeginning': the method is declared in an interface type | 3 | 68 |
| CommentRequired | Public method and constructor comments are required | 3 | 70 |
| UnnecessaryModifier | Unnecessary modifier 'public' on method 'isAfterBeginning': the method is declared in an interface type | 3 | 70 |
| UnnecessaryModifier | Unnecessary modifier 'public' on method 'isDuring': the method is declared in an interface type | 3 | 72 |
| CommentRequired | Public method and constructor comments are required | 3 | 72 |
| CommentRequired | Public method and constructor comments are required | 3 | 74 |
| UnnecessaryModifier | Unnecessary modifier 'public' on method 'isBeforeEnd': the method is declared in an interface type | 3 | 74 |
| UnnecessaryModifier | Unnecessary modifier 'public' on method 'isAfterEnd': the method is declared in an interface type | 3 | 76 |
| CommentRequired | Public method and constructor comments are required | 3 | 76 |
| CommentRequired | Public method and constructor comments are required | 3 | 79 |
| UnnecessaryModifier | Unnecessary modifier 'public' on method 'isBeforeBeginning': the method is declared in an interface type | 3 | 79 |
| CommentRequired | Public method and constructor comments are required | 3 | 81 |
| UnnecessaryModifier | Unnecessary modifier 'public' on method 'isAfterBeginning': the method is declared in an interface type | 3 | 81 |
| UnnecessaryModifier | Unnecessary modifier 'public' on method 'isDuring': the method is declared in an interface type | 3 | 83 |
| CommentRequired | Public method and constructor comments are required | 3 | 83 |
| CommentRequired | Public method and constructor comments are required | 3 | 85 |
| UnnecessaryModifier | Unnecessary modifier 'public' on method 'isBeforeEnd': the method is declared in an interface type | 3 | 85 |
| CommentRequired | Public method and constructor comments are required | 3 | 87 |
| UnnecessaryModifier | Unnecessary modifier 'public' on method 'isAfterEnd': the method is declared in an interface type | 3 | 87 |
| UnnecessaryModifier | Unnecessary modifier 'public' on method 'getCampaignAllAreaLabels': the method is declared in an interface type | 3 | 96 |
| CommentRequired | Public method and constructor comments are required | 3 | 96 |
| CommentRequired | Public method and constructor comments are required | 3 | 98 |
| UnnecessaryModifier | Unnecessary modifier 'public' on method 'getCampaignAllAreaTypes': the method is declared in an interface type | 3 | 98 |
| CommentRequired | Public method and constructor comments are required | 3 | 100 |
| UnnecessaryModifier | Unnecessary modifier 'public' on method 'getCampaignWholeAreaLabel': the method is declared in an interface type | 3 | 100 |
| UnnecessaryModifier | Unnecessary modifier 'public' on method 'getCampaignLocalizedAreaLabels': the method is declared in an interface type | 3 | 102 |
| CommentRequired | Public method and constructor comments are required | 3 | 102 |
| CommentRequired | Public method and constructor comments are required | 3 | 104 |
| UnnecessaryModifier | Unnecessary modifier 'public' on method 'getCampaignNumberLocalizedAreas': the method is declared in an interface type | 3 | 104 |
| CommentRequired | Public method and constructor comments are required | 3 | 108 |
| UnnecessaryModifier | Unnecessary modifier 'public' on method 'getLastCampaignAllAreaLabels': the method is declared in an interface type | 3 | 108 |
| CommentRequired | Public method and constructor comments are required | 3 | 110 |
| UnnecessaryModifier | Unnecessary modifier 'public' on method 'getLastCampaignAllAreaTypes': the method is declared in an interface type | 3 | 110 |
| UnnecessaryModifier | Unnecessary modifier 'public' on method 'getLastCampaignWholeAreaLabel': the method is declared in an interface type | 3 | 112 |
| CommentRequired | Public method and constructor comments are required | 3 | 112 |
| CommentRequired | Public method and constructor comments are required | 3 | 114 |
| UnnecessaryModifier | Unnecessary modifier 'public' on method 'getLastCampaignLocalizedAreaLabels': the method is declared in an interface type | 3 | 114 |
| UnnecessaryModifier | Unnecessary modifier 'public' on method 'getLastCampaignNumberLocalizedAreas': the method is declared in an interface type | 3 | 116 |
| CommentRequired | Public method and constructor comments are required | 3 | 116 |
| UnnecessaryModifier | Unnecessary modifier 'public' on method 'getCampaignSubmitterTypes': the method is declared in an interface type | 3 | 124 |
| CommentRequired | Public method and constructor comments are required | 3 | 124 |
| CommentRequired | Public method and constructor comments are required | 3 | 132 |
| UnnecessaryModifier | Unnecessary modifier 'public' on method 'getCampaignThemes': the method is declared in an interface type | 3 | 132 |
| CommentRequired | Public method and constructor comments are required | 3 | 135 |
| UnnecessaryModifier | Unnecessary modifier 'public' on method 'getLastCampaignThemes': the method is declared in an interface type | 3 | 135 |
| UnnecessaryModifier | Unnecessary modifier 'public' on method 'getCampaignThemesFrontRgb': the method is declared in an interface type | 3 | 138 |
| CommentRequired | Public method and constructor comments are required | 3 | 138 |
| CommentRequired | Public method and constructor comments are required | 3 | 150 |
| UnnecessaryModifier | Unnecessary modifier 'public' on method 'getCampaignFieldData': the method is declared in an interface type | 3 | 150 |
| CommentRequired | Public method and constructor comments are required | 3 | 153 |
| UnnecessaryModifier | Unnecessary modifier 'public' on method 'getCampaignFieldsData': the method is declared in an interface type | 3 | 153 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| FieldNamingConventions | The static field name 'PROPERTY_PREFIX' doesn't match '_[a-z][a-zA-Z0-9]*' | 1 | 66 |
| FieldNamingConventions | The static field name 'PROPERTY_SEP' doesn't match '_[a-z][a-zA-Z0-9]*' | 1 | 67 |
| FieldNamingConventions | The static field name 'campaigns' doesn't match '_[a-z][a-zA-Z0-9]*' | 1 | 70 |
| RedundantFieldInitializer | Avoid using redundant field initializer for 'campaigns' | 3 | 70 |
| FieldNamingConventions | The static field name 'themeLabels' doesn't match '_[a-z][a-zA-Z0-9]*' | 1 | 76 |
| RedundantFieldInitializer | Avoid using redundant field initializer for 'themeLabels' | 3 | 76 |
| RedundantFieldInitializer | Avoid using redundant field initializer for 'themeFrontRgbs' | 3 | 82 |
| FieldNamingConventions | The static field name 'themeFrontRgbs' doesn't match '_[a-z][a-zA-Z0-9]*' | 1 | 82 |
| RedundantFieldInitializer | Avoid using redundant field initializer for 'areaLabels' | 3 | 88 |
| FieldNamingConventions | The static field name 'areaLabels' doesn't match '_[a-z][a-zA-Z0-9]*' | 1 | 88 |
| RedundantFieldInitializer | Avoid using redundant field initializer for 'areaTypes' | 3 | 94 |
| FieldNamingConventions | The static field name 'areaTypes' doesn't match '_[a-z][a-zA-Z0-9]*' | 1 | 94 |
| RedundantFieldInitializer | Avoid using redundant field initializer for 'dates' | 3 | 100 |
| FieldNamingConventions | The static field name 'dates' doesn't match '_[a-z][a-zA-Z0-9]*' | 1 | 100 |
| RedundantFieldInitializer | Avoid using redundant field initializer for 'fields' | 3 | 109 |
| FieldNamingConventions | The static field name 'fields' doesn't match '_[a-z][a-zA-Z0-9]*' | 1 | 109 |
| CommentRequired | Public method and constructor comments are required | 3 | 120–128 |
| NonThreadSafeSingleton | Singleton is not thread safe | 3 | 122–126 |
| ShortVariable | Avoid variables with short names like c2 | 3 | 147 |
| ShortVariable | Avoid variables with short names like c1 | 3 | 147 |
| AvoidDuplicateLiterals | The String literal "Unexpected phase code '" appears 4 times in this file; the first occurrence is on line 166 | 3 | 166 |
| CyclomaticComplexity | The method 'loadProperties()' has a cyclomatic complexity of 17. | 3 | 390–525 |
| NPathComplexity | The method 'loadProperties()' has an NPath complexity of 2700 | 3 | 390–525 |
| ExcessiveMethodLength | Avoid really long methods. | 3 | 390–525 |
| NcssCount | The method 'loadProperties()' has a NCSS line count of 78. | 3 | 390–525 |
| AvoidLiteralsInIfCondition | Avoid using Literals in Conditional Statements | 3 | 404 |
| AvoidDuplicateLiterals | The String literal "The property '" appears 4 times in this file; the first occurrence is on line 406 | 3 | 406 |
| AvoidLiteralsInIfCondition | Avoid using Literals in Conditional Statements | 3 | 430 |
| AvoidLiteralsInIfCondition | Avoid using Literals in Conditional Statements | 3 | 462 |
| AvoidLiteralsInIfCondition | Avoid using Literals in Conditional Statements | 3 | 490 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 3 | 507 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| ClassWithOnlyPrivateConstructorsShouldBeFinal | A class which only has private constructors should be final | 1 | 50–145 |
| CommentRequired | Header comments are required | 3 | 50–145 |
| AvoidDuplicateLiterals | The String literal "false" appears 6 times in this file; the first occurrence is on line 66 | 3 | 66 |
| SignatureDeclareThrowsException | A method/constructor should not explicitly throw java.lang.Exception | 3 | 110 |
| CommentRequired | Public method and constructor comments are required | 3 | 110–143 |
| UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 3 | 113 |
| UnnecessaryLocalBeforeReturn | Consider simply returning the value vs storing it in local variable 'features' | 3 | 142 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| AvoidSynchronizedAtMethodLevel | Use block level rather than method level synchronization | 3 | 67–70 |
| MissingOverride | The method 'getImageResource(int)' is missing an @Override annotation. | 3 | 97–116 |
| UnconditionalIfStatement | Do not use if statements that are always true or always false | 3 | 99 |
| MissingOverride | The method 'getResourceTypeId()' is missing an @Override annotation. | 3 | 123–126 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UnnecessaryModifier | Unnecessary modifier 'public' on method 'isUserValid': the method is declared in an interface type | 3 | 44 |
| CommentRequired | Public method and constructor comments are required | 3 | 44 |
| CommentRequired | Public method and constructor comments are required | 3 | 48 |
| UnnecessaryModifier | Unnecessary modifier 'public' on method 'getUrlMyInfosFillAction': the method is declared in an interface type | 3 | 48 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| CommentRequired | Public method and constructor comments are required | 3 | 60–67 |
| NonThreadSafeSingleton | Singleton is not thread safe | 3 | 62–65 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UnusedPrivateField | Avoid unused private fields such as 'MESSAGE_UNPUBLISHED_PROPOSAL'. | 3 | 71 |
| UnusedPrivateField | Avoid unused private fields such as 'MESSAGE_PUBLISHED_PROPOSAL'. | 3 | 72 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| ExcessiveImports | A high number of imports can indicate a high degree of coupling within an object. | 3 | 34–388 |
| NPathComplexity | The method 'processTask(int, HttpServletRequest, Locale)' has an NPath complexity of 87256 | 3 | 126–387 |
| ExcessiveMethodLength | Avoid really long methods. | 3 | 126–387 |
| NcssCount | The method 'processTask(int, HttpServletRequest, Locale)' has a NCSS line count of 127. | 3 | 126–387 |
| CyclomaticComplexity | The method 'processTask(int, HttpServletRequest, Locale)' has a cyclomatic complexity of 49. | 3 | 126–387 |
| UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 3 | 170 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 3 | 170 |
| UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 3 | 191 |
| UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 3 | 192 |
| AvoidDuplicateLiterals | The String literal "[#ftl]\n[#setting date_format=\"dd/MM/yyyy\"]\n" appears 6 times in this file; the first occurrence is on line 240 | 3 | 240 |
| AvoidCatchingGenericException | Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 3 | 246 |
| AvoidThrowingRawExceptionTypes | Avoid throwing raw exception types. | 1 | 248 |
| AvoidCatchingGenericException | Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 3 | 269 |
| AvoidThrowingRawExceptionTypes | Avoid throwing raw exception types. | 1 | 271 |
| AvoidCatchingGenericException | Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 3 | 320 |
| AvoidThrowingRawExceptionTypes | Avoid throwing raw exception types. | 1 | 322 |
| AvoidCatchingGenericException | Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 3 | 338 |
| AvoidThrowingRawExceptionTypes | Avoid throwing raw exception types. | 1 | 340 |
| AvoidCatchingGenericException | Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 3 | 358 |
| AvoidThrowingRawExceptionTypes | Avoid throwing raw exception types. | 1 | 360 |
| AvoidCatchingGenericException | Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 3 | 377 |
| AvoidThrowingRawExceptionTypes | Avoid throwing raw exception types. | 1 | 379 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UselessOverridingMethod | Overriding method merely calls super | 3 | 52–55 |
| UselessOverridingMethod | Overriding method merely calls super | 3 | 61–64 |
| UselessOverridingMethod | Overriding method merely calls super | 3 | 70–73 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| AbstractClassWithoutAbstractMethod | This abstract class does not have any abstract methods | 3 | 55–255 |
| AvoidCatchingGenericException | Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 3 | 73 |
| AvoidUncheckedExceptionsInSignatures | A method or constructor should not explicitly declare unchecked exceptions in its 'throws' clause | 3 | 83 |
| AvoidCatchingGenericException | Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 3 | 90 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 3 | 107 |
| AvoidDuplicateLiterals | The String literal "status" appears 4 times in this file; the first occurrence is on line 110 | 3 | 110 |
| AvoidDuplicateLiterals | The String literal "result" appears 6 times in this file; the first occurrence is on line 112 | 3 | 112 |
| AvoidCatchingGenericException | Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 3 | 126 |
| AvoidCatchingGenericException | Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 3 | 147 |
| AvoidCatchingGenericException | Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 3 | 163 |
| AvoidCatchingGenericException | Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 3 | 195 |
| AvoidCatchingGenericException | Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 3 | 226 |
| AvoidCatchingGenericException | Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 3 | 248 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| NonThreadSafeSingleton | Singleton is not thread safe | 3 | 84–91 |
| ForLoopCanBeForeach | This for loop can be replaced by a foreach loop | 3 | 112–119 |
| UseCollectionIsEmpty | Substitute calls to size() == 0 (or size() != 0, size() > 0, size() < 1) with calls to isEmpty() | 3 | 166 |
| SimplifyBooleanReturns | Avoid unnecessary if..then..else statements when returning booleans | 3 | 225–228 |
| UseCollectionIsEmpty | Substitute calls to size() == 0 (or size() != 0, size() > 0, size() < 1) with calls to isEmpty() | 3 | 225 |
| CommentRequired | Public method and constructor comments are required | 3 | 240–251 |
| ForLoopCanBeForeach | This for loop can be replaced by a foreach loop | 3 | 256–260 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| CommentRequired | Header comments are required | 3 | 52–202 |
| UseUtilityClass | All methods are static. Consider using a utility class instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning. | 3 | 53–202 |
| LooseCoupling | Avoid using implementation types like 'ArrayList'; use the interface instead | 3 | 64 |
| LinguisticNaming | Linguistics Antipattern - The getter 'getValuesFromCsv' should not return void linguistically | 3 | 74–109 |
| LinguisticNaming | Linguistics Antipattern - The variable 'isCsvProperty' indicates linguistically it is a boolean, but it is 'InputStream' | 3 | 77 |
| UseProperClassLoader | In J2EE, getClassLoader() might not work as expected. Use Thread.currentThread().getContextClassLoader() instead. | 3 | 77 |
| UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 3 | 88 |
| UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 3 | 89 |
| ShortVariable | Avoid variables with short names like i | 3 | 95 |
| CommentRequired | Public method and constructor comments are required | 3 | 111–119 |
| CommentRequired | Public method and constructor comments are required | 3 | 121–129 |
| CyclomaticComplexity | The method 'writeCsv(String, List, OutputStream, Locale)' has a cyclomatic complexity of 10. | 3 | 142–201 |
| UseProperClassLoader | In J2EE, getClassLoader() might not work as expected. Use Thread.currentThread().getContextClassLoader() instead. | 3 | 147 |
| LinguisticNaming | Linguistics Antipattern - The variable 'isCsvProperty' indicates linguistically it is a boolean, but it is 'InputStream' | 3 | 147 |
| EmptyStatementNotInLoop | An empty statement (semicolon) not part of a loop | 3 | 158 |
| UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 3 | 180 |
| ForLoopCanBeForeach | This for loop can be replaced by a foreach loop | 3 | 181–184 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| ClassNamingConventions | The utility class name 'ParticipatoryIdeationConstants' doesn't match '[A-Z][a-zA-Z0-9]+(Utils?|Helper|Home|Service)' | 1 | 39–70 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| ClassWithOnlyPrivateConstructorsShouldBeFinal | A class which only has private constructors should be final | 1 | 39–101 |
| CommentRequired | Header comments are required | 3 | 39–101 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 3 | 87–94 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 3 | 93–94 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| ExcessiveImports | A high number of imports can indicate a high degree of coupling within an object. | 3 | 34–1476 |
| ExcessiveClassLength | Avoid really long classes. | 3 | 108–1476 |
| GodClass | Possible God Class (WMC=97, ATFD=173, TCC=22.942%) | 3 | 108–1476 |
| CyclomaticComplexity | The class 'IdeationApp' has a total cyclomatic complexity of 97 (highest 22). | 3 | 108–1476 |
| TooManyMethods | This class has too many methods, consider refactoring it. | 3 | 109–1476 |
| AvoidDuplicateLiterals | The String literal "true" appears 4 times in this file; the first occurrence is on line 146 | 3 | 146 |
| CommentDefaultAccessModifier | To avoid mistakes add a comment at the beginning of the _formEtapeLocation field if you want a default access modifier | 3 | 226 |
| DefaultPackage | Use explicit scoping instead of the default package private level | 3 | 226 |
| DefaultPackage | Use explicit scoping instead of the default package private level | 3 | 227 |
| CommentDefaultAccessModifier | To avoid mistakes add a comment at the beginning of the _formEtapeTitle field if you want a default access modifier | 3 | 227 |
| CommentDefaultAccessModifier | To avoid mistakes add a comment at the beginning of the _formEtapeApprox field if you want a default access modifier | 3 | 228 |
| DefaultPackage | Use explicit scoping instead of the default package private level | 3 | 228 |
| DefaultPackage | Use explicit scoping instead of the default package private level | 3 | 229 |
| CommentDefaultAccessModifier | To avoid mistakes add a comment at the beginning of the _formEtapeDescription field if you want a default access modifier | 3 | 229 |
| DefaultPackage | Use explicit scoping instead of the default package private level | 3 | 230 |
| CommentDefaultAccessModifier | To avoid mistakes add a comment at the beginning of the _formEtapeUpload field if you want a default access modifier | 3 | 230 |
| CommentDefaultAccessModifier | To avoid mistakes add a comment at the beginning of the _formEtapeRecap field if you want a default access modifier | 3 | 231 |
| DefaultPackage | Use explicit scoping instead of the default package private level | 3 | 231 |
| CommentDefaultAccessModifier | To avoid mistakes add a comment at the beginning of the _proposalCreate field if you want a default access modifier | 3 | 233 |
| DefaultPackage | Use explicit scoping instead of the default package private level | 3 | 233 |
| DefaultPackage | Use explicit scoping instead of the default package private level | 3 | 234 |
| CommentDefaultAccessModifier | To avoid mistakes add a comment at the beginning of the _proposalDisplay field if you want a default access modifier | 3 | 234 |
| CommentDefaultAccessModifier | To avoid mistakes add a comment at the beginning of the _strNextStep field if you want a default access modifier | 3 | 235 |
| DefaultPackage | Use explicit scoping instead of the default package private level | 3 | 235 |
| CallSuperInConstructor | It is a good practice to call super() in a constructor | 3 | 242–245 |
| CommentRequired | Public method and constructor comments are required | 3 | 242–245 |
| CyclomaticComplexity | The method 'getPage(HttpServletRequest, int, Plugin)' has a cyclomatic complexity of 13. | 3 | 253–308 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 255 |
| CollapsibleIfStatements | These nested if statements could be combined | 3 | 301–304 |
| UnnecessaryAnnotationValueElement | Avoid the use of value in annotations when its the only element | 3 | 350 |
| UnnecessaryAnnotationValueElement | Avoid the use of value in annotations when its the only element | 3 | 371 |
| UnnecessaryAnnotationValueElement | Avoid the use of value in annotations when its the only element | 3 | 387 |
| UnnecessaryAnnotationValueElement | Avoid the use of value in annotations when its the only element | 3 | 408 |
| CyclomaticComplexity | The method 'viewApprox(HttpServletRequest)' has a cyclomatic complexity of 14. | 3 | 409–483 |
| NPathComplexity | The method 'viewApprox(HttpServletRequest)' has an NPath complexity of 202 | 3 | 409–483 |
| LocalVariableNamingConventions | The local variable name 'results_keyword' doesn't match '[a-z][a-zA-Z0-9]*' | 1 | 412 |
| LocalVariableNamingConventions | The local variable name 'results_location' doesn't match '[a-z][a-zA-Z0-9]*' | 1 | 413 |
| LocalVariableNamingConventions | The local variable name 'results_previous_campaigns' doesn't match '[a-z][a-zA-Z0-9]*' | 1 | 414 |
| UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 3 | 424 |
| UseCollectionIsEmpty | Substitute calls to size() == 0 (or size() != 0, size() > 0, size() < 1) with calls to isEmpty() | 3 | 427 |
| UseCollectionIsEmpty | Substitute calls to size() == 0 (or size() != 0, size() > 0, size() < 1) with calls to isEmpty() | 3 | 436 |
| AvoidLiteralsInIfCondition | Avoid using Literals in Conditional Statements | 3 | 507 |
| UnnecessaryLocalBeforeReturn | Consider simply returning the value vs storing it in local variable 'strGeofiltFq' | 3 | 533 |
| AvoidLiteralsInIfCondition | Avoid using Literals in Conditional Statements | 3 | 557 |
| UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 3 | 570 |
| OptimizableToArrayCall | This call to Collection.toArray() may be optimizable | 3 | 578 |
| AvoidDuplicateLiterals | The String literal "IdeationApp: error during approx search; " appears 6 times in this file; the first occurrence is on line 588 | 3 | 588 |
| IdenticalCatchBranches | 'catch' branch identical to 'SolrServerException' branch | 3 | 590–593 |
| NPathComplexity | The method 'getKeywordApproxResults(SolrQuery, SolrClient)' has an NPath complexity of 8448 | 3 | 606–735 |
| CyclomaticComplexity | The method 'getKeywordApproxResults(SolrQuery, SolrClient)' has a cyclomatic complexity of 22. | 3 | 606–735 |
| NcssCount | The method 'getKeywordApproxResults(SolrQuery, SolrClient)' has a NCSS line count of 62. | 3 | 606–735 |
| ExcessiveMethodLength | Avoid really long methods. | 3 | 606–735 |
| AvoidLiteralsInIfCondition | Avoid using Literals in Conditional Statements | 3 | 613 |
| UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 3 | 627 |
| OptimizableToArrayCall | This call to Collection.toArray() may be optimizable | 3 | 647 |
| UseCollectionIsEmpty | Substitute calls to size() == 0 (or size() != 0, size() > 0, size() < 1) with calls to isEmpty() | 3 | 676 |
| AvoidLiteralsInIfCondition | Avoid using Literals in Conditional Statements | 3 | 680 |
| IdenticalCatchBranches | 'catch' branch identical to 'SolrServerException' branch | 3 | 730–733 |
| AvoidLiteralsInIfCondition | Avoid using Literals in Conditional Statements | 3 | 762 |
| UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 3 | 778 |
| OptimizableToArrayCall | This call to Collection.toArray() may be optimizable | 3 | 781 |
| IdenticalCatchBranches | 'catch' branch identical to 'SolrServerException' branch | 3 | 802–805 |
| UnnecessaryAnnotationValueElement | Avoid the use of value in annotations when its the only element | 3 | 817 |
| UnnecessaryAnnotationValueElement | Avoid the use of value in annotations when its the only element | 3 | 831 |
| UnnecessaryAnnotationValueElement | Avoid the use of value in annotations when its the only element | 3 | 845 |
| UnnecessaryAnnotationValueElement | Avoid the use of value in annotations when its the only element | 3 | 861 |
| UnnecessaryAnnotationValueElement | Avoid the use of value in annotations when its the only element | 3 | 883 |
| UnnecessaryAnnotationValueElement | Avoid the use of value in annotations when its the only element | 3 | 902 |
| UnnecessaryAnnotationValueElement | Avoid the use of value in annotations when its the only element | 3 | 938 |
| UnnecessaryAnnotationValueElement | Avoid the use of value in annotations when its the only element | 3 | 954 |
| UnnecessaryAnnotationValueElement | Avoid the use of value in annotations when its the only element | 3 | 1001 |
| UnusedFormalParameter | Avoid unused method parameters such as 'request'. | 3 | 1024 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 3 | 1031–1048 |
| AvoidCatchingGenericException | Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 3 | 1040 |
| CommentRequired | Protected method constructor comments are required | 3 | 1132–1140 |
| AvoidLiteralsInIfCondition | Avoid using Literals in Conditional Statements | 3 | 1165 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 3 | 1174 |
| UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 3 | 1174 |
| DefaultPackage | Use explicit scoping instead of the default package private level | 3 | 1203–1237 |
| CommentDefaultAccessModifier | To avoid mistakes add a comment at the beginning of the isValidateFormEtape method if you want a default access modifier | 3 | 1203–1237 |
| DefaultPackage | Use explicit scoping instead of the default package private level | 3 | 1239–1244 |
| CommentDefaultAccessModifier | To avoid mistakes add a comment at the beginning of the isAllEtapeValidated method if you want a default access modifier | 3 | 1239–1244 |
| NcssCount | The method 'convertFormEtapeLocation(FormEtapeLocation, Proposal)' has a NCSS line count of 73. | 3 | 1246–1363 |
| ExcessiveMethodLength | Avoid really long methods. | 3 | 1246–1363 |
| CyclomaticComplexity | The method 'convertFormEtapeLocation(FormEtapeLocation, Proposal)' has a cyclomatic complexity of 14. | 3 | 1246–1363 |
| UseCollectionIsEmpty | Substitute calls to size() == 0 (or size() != 0, size() > 0, size() < 1) with calls to isEmpty() | 3 | 1273 |
| AvoidCatchingGenericException | Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 3 | 1325 |
| UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 3 | 1424 |
| FieldNamingConventions | The constant name 'nameMap' doesn't match '[A-Z][A-Z_0-9]*' | 1 | 1455 |
| UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 3 | 1458 |
| UnnecessaryModifier | Unnecessary modifier 'private' on constructor 'STEPS(String)': enum constructors are implicitly private | 3 | 1465–1468 |
| CommentRequired | Public method and constructor comments are required | 3 | 1470–1473 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| SingularField | Perhaps '_nDefaultItemsPerPage' could be replaced by a local variable. | 3 | 64 |
| AddEmptyString | Do not add empty strings | 3 | 95 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| MissingSerialVersionUID | Classes implementing Serializable should set a serialVersionUID | 3 | 57–136 |
| FieldNamingConventions | The public constant name 'RIGHT_MANAGE_participatoryideation_proposals' doesn't match '[A-Z][A-Z_0-9]*' | 1 | 60 |
| SingularField | Perhaps '_nDefaultItemsPerPage' could be replaced by a local variable. | 3 | 71 |
| AddEmptyString | Do not add empty strings | 3 | 102 |
| UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 3 | 119 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 3 | 125 |
| UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 3 | 125 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| MissingSerialVersionUID | Classes implementing Serializable should set a serialVersionUID | 3 | 50–98 |
| SingularField | Perhaps '_nDefaultItemsPerPage' could be replaced by a local variable. | 3 | 61 |
| AddEmptyString | Do not add empty strings | 3 | 92 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| CommentRequired | Header comments are required | 3 | 36–261 |
| CommentRequired | Public method and constructor comments are required | 3 | 127–130 |
| CommentRequired | Public method and constructor comments are required | 3 | 132–135 |
| CommentRequired | Public method and constructor comments are required | 3 | 221–224 |
| FormalParameterNamingConventions | The method parameter name '_strTitre' doesn't match '[a-z][a-zA-Z0-9]*' | 1 | 226 |
| CommentRequired | Public method and constructor comments are required | 3 | 226–229 |
| CommentRequired | Public method and constructor comments are required | 3 | 231–234 |
| FormalParameterNamingConventions | The method parameter name '_strDescription' doesn't match '[a-z][a-zA-Z0-9]*' | 1 | 236 |
| CommentRequired | Public method and constructor comments are required | 3 | 236–239 |
| CommentRequired | Public method and constructor comments are required | 3 | 241–244 |
| FormalParameterNamingConventions | The method parameter name '_strCout' doesn't match '[a-z][a-zA-Z0-9]*' | 1 | 246 |
| CommentRequired | Public method and constructor comments are required | 3 | 246–249 |
| CommentRequired | Public method and constructor comments are required | 3 | 251–254 |
| FormalParameterNamingConventions | The method parameter name '_strLocationArdt' doesn't match '[a-z][a-zA-Z0-9]*' | 1 | 256 |
| CommentRequired | Public method and constructor comments are required | 3 | 256–259 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| ExcessiveImports | A high number of imports can indicate a high degree of coupling within an object. | 3 | 34–1129 |
| MissingSerialVersionUID | Classes implementing Serializable should set a serialVersionUID | 3 | 83–1129 |
| ExcessiveClassLength | Avoid really long classes. | 3 | 83–1129 |
| FieldNamingConventions | The static field name 'defaultSearcher' doesn't match '_[a-z][a-zA-Z0-9]*' | 1 | 192 |
| NPathComplexity | The method 'getManageProposals(HttpServletRequest)' has an NPath complexity of 10250 | 3 | 214–308 |
| CyclomaticComplexity | The method 'getManageProposals(HttpServletRequest)' has a cyclomatic complexity of 16. | 3 | 214–308 |
| NullAssignment | Assigning an Object to null is a code smell. Consider refactoring. | 3 | 216 |
| NullAssignment | Assigning an Object to null is a code smell. Consider refactoring. | 3 | 217 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 3 | 218 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 3 | 293 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 3 | 294 |
| AddEmptyString | Do not add empty strings | 3 | 297 |
| AddEmptyString | Do not add empty strings | 3 | 299 |
| UnnecessaryAnnotationValueElement | Avoid the use of value in annotations when its the only element | 3 | 322 |
| NcssCount | The method 'doSearchProposal(HttpServletRequest)' has a NCSS line count of 64. | 3 | 323–461 |
| NPathComplexity | The method 'doSearchProposal(HttpServletRequest)' has an NPath complexity of 118098 | 3 | 323–461 |
| CyclomaticComplexity | The method 'doSearchProposal(HttpServletRequest)' has a cyclomatic complexity of 22. | 3 | 323–461 |
| ExcessiveMethodLength | Avoid really long methods. | 3 | 323–461 |
| UnnecessaryAnnotationValueElement | Avoid the use of value in annotations when its the only element | 3 | 470 |
| NullAssignment | Assigning an Object to null is a code smell. Consider refactoring. | 3 | 473 |
| CommentRequired | Public method and constructor comments are required | 3 | 486–496 |
| CommentRequired | Public method and constructor comments are required | 3 | 499–530 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 501 |
| UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 3 | 509 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 3 | 509 |
| CyclomaticComplexity | The method 'doCreateProposal(HttpServletRequest)' has a cyclomatic complexity of 15. | 3 | 533–650 |
| CommentRequired | Public method and constructor comments are required | 3 | 533–650 |
| NcssCount | The method 'doCreateProposal(HttpServletRequest)' has a NCSS line count of 66. | 3 | 533–650 |
| NPathComplexity | The method 'doCreateProposal(HttpServletRequest)' has an NPath complexity of 486 | 3 | 533–650 |
| ExcessiveMethodLength | Avoid really long methods. | 3 | 533–650 |
| UseCollectionIsEmpty | Substitute calls to size() == 0 (or size() != 0, size() > 0, size() < 1) with calls to isEmpty() | 3 | 572 |
| AvoidCatchingGenericException | Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 3 | 624 |
| NullAssignment | Assigning an Object to null is a code smell. Consider refactoring. | 3 | 646 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 3 | 682–689 |
| AvoidCatchingGenericException | Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 3 | 732 |
| UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 3 | 788 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 3 | 788 |
| UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 3 | 822 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 3 | 822 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 857 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 862 |
| ShortVariable | Avoid variables with short names like os | 3 | 935 |
| CyclomaticComplexity | The method 'copyProposalBoFormToProposal(ProposalBoForm, Proposal)' has a cyclomatic complexity of 14. | 3 | 958–1051 |
| NPathComplexity | The method 'copyProposalBoFormToProposal(ProposalBoForm, Proposal)' has an NPath complexity of 2560 | 3 | 958–1051 |
| AvoidCatchingGenericException | Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 3 | 1119 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| FieldNamingConventions | The static field name 'defaultSearcher' doesn't match '_[a-z][a-zA-Z0-9]*' | 1 | 138 |
| NullAssignment | Assigning an Object to null is a code smell. Consider refactoring. | 3 | 160 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 3 | 161 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 3 | 205 |
| UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 3 | 287 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 287 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 288 |
| UnnecessaryAnnotationValueElement | Avoid the use of value in annotations when its the only element | 3 | 452 |
| UnnecessaryAnnotationValueElement | Avoid the use of value in annotations when its the only element | 3 | 511 |
| NullAssignment | Assigning an Object to null is a code smell. Consider refactoring. | 3 | 514 |
| FormalParameterNamingConventions | The method parameter name '_str' doesn't match '[a-z][a-zA-Z0-9]*' | 1 | 526 |
| FormalParameterNamingConventions | The method parameter name '_link' doesn't match '[a-z][a-zA-Z0-9]*' | 1 | 548 |
| UnusedFormalParameter | Avoid unused method parameters such as 'request'. | 3 | 548 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| ExcessiveImports | A high number of imports can indicate a high degree of coupling within an object. | 3 | 34–333 |
| ImmutableField | Private field '_resourceExtenderHistoryService' could be made final; it is only initialized in the declaration or constructor. | 3 | 121 |
| ControlStatementBraces | This statement should have braces | 3 | 138 |
| LocalVariableNamingConventions | The local variable name '_proposalSearcher' doesn't match '[a-z][a-zA-Z0-9]*' | 1 | 140 |
| LocalVariableNamingConventions | The local variable name '_commentFilter' doesn't match '[a-z][a-zA-Z0-9]*' | 1 | 146 |
| UseUnderscoresInNumericLiterals | Number 10000 should separate every third digit with an underscore | 3 | 150 |
| UnusedLocalVariable | Avoid unused local variables such as 'wrapper'. | 3 | 169 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 169 |
| ControlStatementBraces | This statement should have braces | 3 | 194 |
| LocalVariableNamingConventions | The local variable name '_proposalSearcher' doesn't match '[a-z][a-zA-Z0-9]*' | 1 | 206 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 3 | 234 |
| UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 3 | 234 |
| NonThreadSafeSingleton | Singleton is not thread safe | 3 | 266–269 |
| UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 3 | 282 |
| LocalVariableNamingConventions | The local variable name 'IdExtendableResourceList' doesn't match '[a-z][a-zA-Z0-9]*' | 1 | 283 |
| UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 3 | 283 |
| UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 3 | 313 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| MissingSerialVersionUID | Classes implementing Serializable should set a serialVersionUID | 3 | 61–167 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 91 |
| UnnecessaryAnnotationValueElement | Avoid the use of value in annotations when its the only element | 3 | 120 |
| ForLoopCanBeForeach | This for loop can be replaced by a foreach loop | 3 | 140–148 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| ExcessiveImports | A high number of imports can indicate a high degree of coupling within an object. | 3 | 34–373 |
| AvoidDuplicateLiterals | The String literal "proposal" appears 4 times in this file; the first occurrence is on line 76 | 3 | 76 |
| NPathComplexity | The method 'getViewProposal(HttpServletRequest)' has an NPath complexity of 576 | 3 | 145–236 |
| CyclomaticComplexity | The method 'getViewProposal(HttpServletRequest)' has a cyclomatic complexity of 16. | 3 | 145–236 |
| NullAssignment | Assigning an Object to null is a code smell. Consider refactoring. | 3 | 155 |
| LocalVariableNamingConventions | The local variable name '_proposal' doesn't match '[a-z][a-zA-Z0-9]*' | 1 | 158 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 3 | 159–166 |
| NullAssignment | Assigning an Object to null is a code smell. Consider refactoring. | 3 | 165 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 168 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 170 |
| CollapsibleIfStatements | These nested if statements could be combined | 3 | 176–179 |
| AvoidDeeplyNestedIfStmts | Deeply nested if..then statements are hard to read | 3 | 220–223 |
| UnnecessaryAnnotationValueElement | Avoid the use of value in annotations when its the only element | 3 | 238 |
| CommentRequired | Public method and constructor comments are required | 3 | 239–339 |
| ExcessiveMethodLength | Avoid really long methods. | 3 | 239–339 |
| NPathComplexity | The method 'doContacterSubmitter(HttpServletRequest)' has an NPath complexity of 2304 | 3 | 239–339 |
| CyclomaticComplexity | The method 'doContacterSubmitter(HttpServletRequest)' has a cyclomatic complexity of 15. | 3 | 239–339 |
| NullAssignment | Assigning an Object to null is a code smell. Consider refactoring. | 3 | 250 |
| LocalVariableNamingConventions | The local variable name '_proposal' doesn't match '[a-z][a-zA-Z0-9]*' | 1 | 253 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 3 | 254–261 |
| NullAssignment | Assigning an Object to null is a code smell. Consider refactoring. | 3 | 260 |
| UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 3 | 263 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 3 | 263 |
| AddEmptyString | Do not add empty strings | 3 | 265 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 285 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 3 | 285 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 288 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 3 | 291 |
| UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 3 | 291 |
| ShortVariable | Avoid variables with short names like t | 3 | 313 |
| AvoidCatchingGenericException | Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 3 | 316 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 3 | 325–336 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 3 | 365 |
| AddEmptyString | Do not add empty strings | 3 | 365 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| FieldNamingConventions | The constant name 'strSearchSolrUrl' doesn't match '[A-Z][A-Z_0-9]*' | 1 | 76 |
| FieldNamingConventions | The constant name 'strAmpSymbol' doesn't match '[A-Z][A-Z_0-9]*' | 1 | 77 |
| FieldNamingConventions | The constant name 'strEqualSymbol' doesn't match '[A-Z][A-Z_0-9]*' | 1 | 78 |
| CommentRequired | Public method and constructor comments are required | 3 | 81–144 |
| InefficientStringBuffering | Avoid concatenating nonliterals in a StringBuffer/StringBuilder constructor or append(). | 3 | 106 |
| InefficientStringBuffering | Avoid concatenating nonliterals in a StringBuffer/StringBuilder constructor or append(). | 3 | 116 |
| InefficientStringBuffering | Avoid concatenating nonliterals in a StringBuffer/StringBuilder constructor or append(). | 3 | 127 |
| GuardLogStatement | Logger calls should be surrounded by log level guards. | 2 | 134 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| MissingSerialVersionUID | Classes implementing Serializable should set a serialVersionUID | 3 | 54–245 |
| UnusedPrivateField | Avoid unused private fields such as 'PROPERTY_DEFAULT_LIST_SUBMITTER_PER_PAGE'. | 3 | 81 |
| NullAssignment | Assigning an Object to null is a code smell. Consider refactoring. | 3 | 114 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 3 | 131 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| MissingSerialVersionUID | Classes implementing Serializable should set a serialVersionUID | 3 | 54–245 |
| UnusedPrivateField | Avoid unused private fields such as 'PROPERTY_DEFAULT_LIST_SUBMITTER_PER_PAGE'. | 3 | 81 |
| NullAssignment | Assigning an Object to null is a code smell. Consider refactoring. | 3 | 114 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 3 | 131 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| CommentRequired | Header comments are required | 3 | 43–69 |
| CommentDefaultAccessModifier | To avoid mistakes add a comment at the beginning of the _bValidated field if you want a default access modifier | 3 | 46 |
| DefaultPackage | Use explicit scoping instead of the default package private level | 3 | 46 |
| EmptyMethodInAbstractClassShouldBeAbstract | An empty method in an abstract class should be abstract instead | 1 | 49–52 |
| EmptyMethodInAbstractClassShouldBeAbstract | An empty method in an abstract class should be abstract instead | 1 | 55–58 |
| MissingOverride | The method 'isValidated()' is missing an @Override annotation. | 3 | 60–63 |
| CommentRequired | Public method and constructor comments are required | 3 | 60–63 |
| CommentRequired | Public method and constructor comments are required | 3 | 65–68 |
| MissingOverride | The method 'setValidated(boolean)' is missing an @Override annotation. | 3 | 65–68 |
| FormalParameterNamingConventions | The method parameter name '_bValidated' doesn't match '[a-z][a-zA-Z0-9]*' | 1 | 65 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| CommentRequired | Header comments are required | 3 | 36–39 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| CommentRequired | Header comments are required | 3 | 55–271 |
| UnusedPrivateField | Avoid unused private fields such as 'I18N_ERROR_FIELD4_COMPLEMENT_MIN_LENGTH'. | 3 | 68 |
| UnusedPrivateField | Avoid unused private fields such as 'I18N_ERROR_FIELD4_COMPLEMENT_MAX_LENGTH'. | 3 | 69 |
| UnusedPrivateField | Avoid unused private fields such as 'DSKEY_FIELD4_COMPLEMENT_MIN_LENGTH'. | 3 | 73 |
| UnusedPrivateField | Avoid unused private fields such as 'DSKEY_FIELD4_COMPLEMENT_MAX_LENGTH'. | 3 | 74 |
| UseUnderscoresInNumericLiterals | Number 10000 should separate every third digit with an underscore | 3 | 77 |
| CommentRequired | Public method and constructor comments are required | 3 | 84–87 |
| FormalParameterNamingConventions | The method parameter name '_strDescription' doesn't match '[a-z][a-zA-Z0-9]*' | 1 | 89 |
| CommentRequired | Public method and constructor comments are required | 3 | 89–92 |
| CommentRequired | Public method and constructor comments are required | 3 | 96–99 |
| CommentRequired | Public method and constructor comments are required | 3 | 101–104 |
| FormalParameterNamingConventions | The method parameter name '_strCout' doesn't match '[a-z][a-zA-Z0-9]*' | 1 | 101 |
| FieldDeclarationsShouldBeAtStartOfClass | Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. | 3 | 108 |
| CommentRequired | Public method and constructor comments are required | 3 | 110–113 |
| CommentRequired | Public method and constructor comments are required | 3 | 115–118 |
| FieldDeclarationsShouldBeAtStartOfClass | Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. | 3 | 122 |
| CommentRequired | Public method and constructor comments are required | 3 | 124–127 |
| CommentRequired | Public method and constructor comments are required | 3 | 129–132 |
| FieldDeclarationsShouldBeAtStartOfClass | Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. | 3 | 136 |
| CommentRequired | Public method and constructor comments are required | 3 | 138–141 |
| CommentRequired | Public method and constructor comments are required | 3 | 143–146 |
| NPathComplexity | The method 'checkValidationErrorsLocalized(HttpServletRequest, Proposal, Locale)' has an NPath complexity of 4992 | 3 | 151–269 |
| CyclomaticComplexity | The method 'checkValidationErrorsLocalized(HttpServletRequest, Proposal, Locale)' has a cyclomatic complexity of 23. | 3 | 151–269 |
| ExcessiveMethodLength | Avoid really long methods. | 3 | 151–269 |
| UnusedLocalVariable | Avoid unused local variables such as 'userUid'. | 3 | 154 |
| AvoidLiteralsInIfCondition | Avoid using Literals in Conditional Statements | 3 | 164 |
| AvoidLiteralsInIfCondition | Avoid using Literals in Conditional Statements | 3 | 184 |
| AvoidLiteralsInIfCondition | Avoid using Literals in Conditional Statements | 3 | 214 |
| AddEmptyString | Do not add empty strings | 3 | 225 |
| AddEmptyString | Do not add empty strings | 3 | 232 |
| CollapsibleIfStatements | These nested if statements could be combined | 3 | 241–265 |
| AvoidLiteralsInIfCondition | Avoid using Literals in Conditional Statements | 3 | 243 |
| AddEmptyString | Do not add empty strings | 3 | 254 |
| AddEmptyString | Do not add empty strings | 3 | 261 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UnusedImports | Avoid unused imports such as 'java.util.Locale' | 4 | 38 |
| UnusedImports | Avoid unused imports such as 'fr.paris.lutece.portal.service.security.LuteceUser' | 4 | 49 |
| UnusedImports | Avoid unused imports such as 'fr.paris.lutece.portal.service.security.SecurityService' | 4 | 50 |
| CommentRequired | Header comments are required | 3 | 52–238 |
| UnusedPrivateField | Avoid unused private fields such as 'I18N_ERROR_ADRESS_FORMAT'. | 3 | 56 |
| UnusedPrivateField | Avoid unused private fields such as 'I18N_ERROR_ADRESS_NOT_VALID'. | 3 | 57 |
| UnusedPrivateField | Avoid unused private fields such as 'I18N_ERROR_ADRESS_ARDT_MISMATCH'. | 3 | 58 |
| CommentRequired | Public method and constructor comments are required | 3 | 99–102 |
| CommentRequired | Public method and constructor comments are required | 3 | 104–107 |
| CommentRequired | Public method and constructor comments are required | 3 | 130–133 |
| CommentRequired | Public method and constructor comments are required | 3 | 135–138 |
| FormalParameterNamingConventions | The method parameter name '_strGeojson' doesn't match '[a-z][a-zA-Z0-9]*' | 1 | 135 |
| CommentRequired | Public method and constructor comments are required | 3 | 203–206 |
| FormalParameterNamingConventions | The method parameter name '_strAdress' doesn't match '[a-z][a-zA-Z0-9]*' | 1 | 208 |
| CommentRequired | Public method and constructor comments are required | 3 | 208–211 |
| CommentRequired | Public method and constructor comments are required | 3 | 213–216 |
| CommentRequired | Public method and constructor comments are required | 3 | 218–221 |
| FormalParameterNamingConventions | The method parameter name '_strSubmitterType' doesn't match '[a-z][a-zA-Z0-9]*' | 1 | 218 |
| CommentRequired | Public method and constructor comments are required | 3 | 223–226 |
| CommentRequired | Public method and constructor comments are required | 3 | 228–231 |
| FormalParameterNamingConventions | The method parameter name '_strConseilQuartier' doesn't match '[a-z][a-zA-Z0-9]*' | 1 | 228 |
| CommentRequired | Public method and constructor comments are required | 3 | 233–237 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| CommentRequired | Header comments are required | 3 | 36–57 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| CommentRequired | Header comments are required | 3 | 52–217 |
| CommentRequired | Public method and constructor comments are required | 3 | 77–80 |
| CommentRequired | Public method and constructor comments are required | 3 | 82–85 |
| CommentRequired | Public method and constructor comments are required | 3 | 87–90 |
| CommentRequired | Public method and constructor comments are required | 3 | 92–95 |
| CommentRequired | Public method and constructor comments are required | 3 | 97–100 |
| CommentRequired | Public method and constructor comments are required | 3 | 102–105 |
| NPathComplexity | The method 'checkValidationErrorsLocalized(HttpServletRequest, Proposal, Locale)' has an NPath complexity of 2304 | 3 | 108–215 |
| CyclomaticComplexity | The method 'checkValidationErrorsLocalized(HttpServletRequest, Proposal, Locale)' has a cyclomatic complexity of 21. | 3 | 108–215 |
| ExcessiveMethodLength | Avoid really long methods. | 3 | 108–215 |
| AvoidLiteralsInIfCondition | Avoid using Literals in Conditional Statements | 3 | 115 |
| AvoidLiteralsInIfCondition | Avoid using Literals in Conditional Statements | 3 | 134 |
| AvoidLiteralsInIfCondition | Avoid using Literals in Conditional Statements | 3 | 163 |
| AddEmptyString | Do not add empty strings | 3 | 174 |
| AddEmptyString | Do not add empty strings | 3 | 181 |
| AvoidLiteralsInIfCondition | Avoid using Literals in Conditional Statements | 3 | 190 |
| AddEmptyString | Do not add empty strings | 3 | 201 |
| AddEmptyString | Do not add empty strings | 3 | 208 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| CommentRequired | Header comments are required | 3 | 45–117 |
| CommentDefaultAccessModifier | To avoid mistakes add a comment at the beginning of the _ideationUploadHandler field if you want a default access modifier | 3 | 52 |
| DefaultPackage | Use explicit scoping instead of the default package private level | 3 | 52 |
| CommentRequired | Public method and constructor comments are required | 3 | 54–57 |
| FormalParameterNamingConventions | The method parameter name '_strAcceptExploit' doesn't match '[a-z][a-zA-Z0-9]*' | 1 | 59 |
| CommentRequired | Public method and constructor comments are required | 3 | 59–62 |
| CommentRequired | Public method and constructor comments are required | 3 | 64–71 |
| AvoidDuplicateLiterals | The String literal "participatoryideation.ProposalAsynchronousHandler" appears 4 times in this file; the first occurrence is on line 68 | 3 | 68 |
| CommentRequired | Public method and constructor comments are required | 3 | 73–80 |
| CommentRequired | Public method and constructor comments are required | 3 | 82–89 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| CommentRequired | Header comments are required | 3 | 43–53 |
| CommentRequired | Public method and constructor comments are required | 3 | 46 |
| CommentRequired | Public method and constructor comments are required | 3 | 48 |
| CommentRequired | Public method and constructor comments are required | 3 | 50 |
| FormalParameterNamingConventions | The method parameter name '_bValidated' doesn't match '[a-z][a-zA-Z0-9]*' | 1 | 52 |
| CommentRequired | Public method and constructor comments are required | 3 | 52 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 3 | 114 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 3 | 114 |
| LocalVariableNamingConventions | The local variable name '_user' doesn't match '[a-z][a-zA-Z0-9]*' | 1 | 117 |
| LocalVariableNamingConventions | The local variable name '_proposalSearcher' doesn't match '[a-z][a-zA-Z0-9]*' | 1 | 127 |
| LocalVariableNamingConventions | The local variable name '_commentFilter' doesn't match '[a-z][a-zA-Z0-9]*' | 1 | 133 |
| UseUnderscoresInNumericLiterals | Number 10000 should separate every third digit with an underscore | 3 | 137 |
| NonThreadSafeSingleton | Singleton is not thread safe | 3 | 167–170 |
| UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 3 | 183 |
| LocalVariableNamingConventions | The local variable name 'IdExtendableResourceList' doesn't match '[a-z][a-zA-Z0-9]*' | 1 | 184 |
| UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 3 | 184 |
| UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 3 | 214 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| FieldNamingConventions | The constant name 'TEMPLATE_CHANGE_Proposal_Status_CONFIG' doesn't match '[A-Z][A-Z_0-9]*' | 1 | 74 |
| UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 3 | 132 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 3 | 132 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 3 | 152 |
| UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 3 | 152 |
