The following document contains the results of PMD 6.13.0.
Rule | Violation | Line |
---|---|---|
MethodNamingConventions | The instance method name 'BusinessClass' doesn't match '[a-z][a-zA-Z0-9]*' | 626–629 |
Rule | Violation | Line |
---|---|---|
FieldNamingConventions | The static field name '_jsp_prefix' doesn't match '_[a-z][a-zA-Z0-9]*' | 53 |
Rule | Violation | Line |
---|---|---|
FieldNamingConventions | The static field name '_template_prefix' doesn't match '_[a-z][a-zA-Z0-9]*' | 57 |
LocalVariableNamingConventions | The local variable name 'admin_feature' doesn't match '[a-z][a-zA-Z0-9]*' | 84 |
FormalParameterNamingConventions | The method parameter name 'admin_feature' doesn't match '[a-z][a-zA-Z0-9]*' | 120 |
Rule | Violation | Line |
---|---|---|
FormalParameterNamingConventions | The method parameter name '_bIsDefault' doesn't match '[a-z][a-zA-Z0-9]*' | 129 |
Rule | Violation | Line |
---|---|---|
ClassNamingConventions | The utility class name 'Markers' doesn't match '[A-Z][a-zA-Z0-9]+(Utils?|Helper|Home|Service)' | 39–89 |
Rule | Violation | Line |
---|---|---|
LocalVariableNamingConventions | The local variable name 'BusinessNames' doesn't match '[a-z][a-zA-Z0-9]*' | 87 |
Rule | Violation | Line |
---|---|---|
LocalVariableNamingConventions | The local variable name '_path' doesn't match '[a-z][a-zA-Z0-9]*' | 60 |
Rule | Violation | Line |
---|---|---|
LocalVariableNamingConventions | The local variable name '_path' doesn't match '[a-z][a-zA-Z0-9]*' | 64 |
Rule | Violation | Line |
---|---|---|
FieldNamingConventions | The static field name '_template_prefix' doesn't match '_[a-z][a-zA-Z0-9]*' | 57 |
Rule | Violation | Line |
---|---|---|
ClassNamingConventions | The utility class name 'Utils' doesn't match '[A-Z][a-zA-Z0-9]+(Utils?|Helper|Home|Service)' | 39–97 |
Rule | Violation | Line |
---|---|---|
ClassNamingConventions | The utility class name 'Constants' doesn't match '[A-Z][a-zA-Z0-9]+(Utils?|Helper|Home|Service)' | 41–76 |
Rule | Violation | Line |
---|---|---|
FormalParameterNamingConventions | The method parameter name '_strType' doesn't match '[a-z][a-zA-Z0-9]*' | 304 |
FormalParameterNamingConventions | The method parameter name '_bIsModule' doesn't match '[a-z][a-zA-Z0-9]*' | 335 |
Rule | Violation | Line |
---|---|---|
MissingOverride | The method 'insert(ConfigurationKey, Plugin)' is missing an @Override annotation. | 91–105 |
MissingOverride | The method 'load(int, Plugin)' is missing an @Override annotation. | 116–138 |
MissingOverride | The method 'delete(int, Plugin)' is missing an @Override annotation. | 148–156 |
MissingOverride | The method 'store(ConfigurationKey, Plugin)' is missing an @Override annotation. | 166–179 |
MissingOverride | The method 'selectConfigurationKeysList(Plugin)' is missing an @Override annotation. | 188–210 |
Rule | Violation | Line |
---|---|---|
ConfusingTernary | Avoid if (x != y) ..; else ..; | 132–139 |
ConfusingTernary | Avoid if (x != y) ..; else ..; | 150–157 |
NullAssignment | Assigning an Object to null is a code smell. Consider refactoring. | 156 |
Rule | Violation | Line |
---|---|---|
UseLocaleWithCaseConversions | When doing a String.toLowerCase()/toUpperCase() call, use a Locale | 157 |
UseLocaleWithCaseConversions | When doing a String.toLowerCase()/toUpperCase() call, use a Locale | 190 |
UseLocaleWithCaseConversions | When doing a String.toLowerCase()/toUpperCase() call, use a Locale | 201 |
Rule | Violation | Line |
---|---|---|
ConfusingTernary | Avoid if (x != y) ..; else ..; | 142–149 |
NullAssignment | Assigning an Object to null is a code smell. Consider refactoring. | 148 |
ConfusingTernary | Avoid if (x != y) ..; else ..; | 159–166 |
Rule | Violation | Line |
---|---|---|
ConfusingTernary | Avoid if (x != y) ..; else ..; | 229–236 |
ConfusingTernary | Avoid if (x != y) ..; else ..; | 247–254 |
NullAssignment | Assigning an Object to null is a code smell. Consider refactoring. | 253 |
Rule | Violation | Line |
---|---|---|
ExcessivePublicCount | This class has a bunch of public methods and attributes | 34–684 |
TooManyFields | Too many fields | 51–684 |
UseLocaleWithCaseConversions | When doing a String.toLowerCase()/toUpperCase() call, use a Locale | 195 |
UseLocaleWithCaseConversions | When doing a String.toLowerCase()/toUpperCase() call, use a Locale | 199 |
ConfusingTernary | Avoid if (x != y) ..; else ..; | 514–521 |
NullAssignment | Assigning an Object to null is a code smell. Consider refactoring. | 520 |
ConfusingTernary | Avoid if (x != y) ..; else ..; | 563–570 |
NullAssignment | Assigning an Object to null is a code smell. Consider refactoring. | 569 |
ConfusingTernary | Avoid if (x != y) ..; else ..; | 591–598 |
NullAssignment | Assigning an Object to null is a code smell. Consider refactoring. | 597 |
CommentRequired | Public method and constructor comments are required | 621–624 |
CommentRequired | Public method and constructor comments are required | 626–629 |
Rule | Violation | Line |
---|---|---|
MissingOverride | The method 'insert(PluginModel, Plugin)' is missing an @Override annotation. | 93–118 |
MissingOverride | The method 'load(int, Plugin)' is missing an @Override annotation. | 129–164 |
MissingOverride | The method 'delete(int, Plugin)' is missing an @Override annotation. | 174–182 |
MissingOverride | The method 'store(PluginModel, Plugin)' is missing an @Override annotation. | 192–216 |
MissingOverride | The method 'selectPluginModelsList(Plugin)' is missing an @Override annotation. | 225–258 |
MissingOverride | The method 'selectPluginModelByName(Plugin, String)' is missing an @Override annotation. | 269–287 |
MissingOverride | The method 'pluginExists(String, Plugin)' is missing an @Override annotation. | 298–321 |
Rule | Violation | Line |
---|---|---|
ConfusingTernary | Avoid if (x != y) ..; else ..; | 81–88 |
ConfusingTernary | Avoid if (x != y) ..; else ..; | 99–106 |
NullAssignment | Assigning an Object to null is a code smell. Consider refactoring. | 105 |
Rule | Violation | Line |
---|---|---|
ConfusingTernary | Avoid if (x != y) ..; else ..; | 60–67 |
NullAssignment | Assigning an Object to null is a code smell. Consider refactoring. | 66 |
Rule | Violation | Line |
---|---|---|
ShortVariable | Avoid variables with short names like sw | 67 |
UnnecessaryLocalBeforeReturn | Consider simply returning the value vs storing it in local variable 'sw' | 68 |
AvoidCatchingGenericException | Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 91 |
Rule | Violation | Line |
---|---|---|
GodClass | Possible God Class (WMC=136, ATFD=143, TCC=1.714%) | 63–1269 |
CyclomaticComplexity | The class 'ModelService' has a total cyclomatic complexity of 136 (highest 7). | 63–1269 |
ExcessiveClassLength | Avoid really long classes. | 63–1269 |
TooManyMethods | This class has too many methods, consider refactoring it. | 64–1269 |
ShortVariable | Avoid variables with short names like ID | 67 |
ShortVariable | Avoid variables with short names like pm | 87 |
ShortVariable | Avoid variables with short names like pm | 105 |
ConfusingTernary | Avoid if (x != y) ..; else ..; | 108–116 |
ShortVariable | Avoid variables with short names like pm | 127 |
ConfusingTernary | Avoid if (x != y) ..; else ..; | 136–143 |
ShortVariable | Avoid variables with short names like pm | 153 |
ShortVariable | Avoid variables with short names like pm | 191 |
ShortVariable | Avoid variables with short names like pm | 211 |
ShortVariable | Avoid variables with short names like pm | 231 |
ShortVariable | Avoid variables with short names like pm | 256 |
ShortVariable | Avoid variables with short names like f | 261 |
ShortVariable | Avoid variables with short names like pm | 285 |
ShortVariable | Avoid variables with short names like f | 290 |
ShortVariable | Avoid variables with short names like pm | 318 |
ShortVariable | Avoid variables with short names like pm | 332 |
ShortVariable | Avoid variables with short names like pm | 355 |
ShortVariable | Avoid variables with short names like pm | 371 |
ShortVariable | Avoid variables with short names like pm | 396 |
ShortVariable | Avoid variables with short names like pm | 425 |
ShortVariable | Avoid variables with short names like f | 430 |
ShortVariable | Avoid variables with short names like pm | 458 |
ShortVariable | Avoid variables with short names like pm | 481 |
ShortVariable | Avoid variables with short names like pm | 496 |
ShortVariable | Avoid variables with short names like pm | 521 |
ShortVariable | Avoid variables with short names like p | 526 |
ShortVariable | Avoid variables with short names like pm | 550 |
ShortVariable | Avoid variables with short names like p | 555 |
ShortVariable | Avoid variables with short names like pm | 581 |
ShortVariable | Avoid variables with short names like pm | 595 |
ShortVariable | Avoid variables with short names like bc | 617 |
PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 619 |
ShortVariable | Avoid variables with short names like pm | 619 |
ForLoopCanBeForeach | This for loop can be replaced by a foreach loop | 637–644 |
UseStringBufferForStringAppends | Prefer StringBuilder (non-synchronized) or StringBuffer (synchronized) over += for concatenating strings | 641 |
UseStringBufferForStringAppends | Prefer StringBuilder (non-synchronized) or StringBuffer (synchronized) over += for concatenating strings | 643 |
ShortVariable | Avoid variables with short names like pm | 662 |
ShortVariable | Avoid variables with short names like pm | 687 |
ShortVariable | Avoid variables with short names like bc | 692 |
PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 698 |
ShortVariable | Avoid variables with short names like pm | 735 |
ShortVariable | Avoid variables with short names like bc | 740 |
ShortVariable | Avoid variables with short names like pm | 761 |
ShortVariable | Avoid variables with short names like pm | 784 |
ShortVariable | Avoid variables with short names like bc | 785 |
ConfusingTernary | Avoid if (x != y) ..; else ..; | 786–803 |
ShortVariable | Avoid variables with short names like pm | 818 |
ShortVariable | Avoid variables with short names like bc | 819 |
ShortVariable | Avoid variables with short names like pm | 867 |
ShortVariable | Avoid variables with short names like bc | 868 |
ShortVariable | Avoid variables with short names like pm | 901 |
ShortVariable | Avoid variables with short names like bc | 902 |
ShortVariable | Avoid variables with short names like pm | 936 |
ShortVariable | Avoid variables with short names like pm | 950 |
ShortVariable | Avoid variables with short names like pm | 964 |
ShortVariable | Avoid variables with short names like pm | 976 |
ShortVariable | Avoid variables with short names like pm | 1004 |
ShortVariable | Avoid variables with short names like pm | 1038 |
ShortVariable | Avoid variables with short names like pm | 1072 |
ShortVariable | Avoid variables with short names like pm | 1107 |
CommentRequired | Public method and constructor comments are required | 1225–1239 |
ShortVariable | Avoid variables with short names like pm | 1227 |
CommentRequired | Public method and constructor comments are required | 1241–1254 |
ShortVariable | Avoid variables with short names like pm | 1243 |
CommentRequired | Public method and constructor comments are required | 1256–1268 |
ShortVariable | Avoid variables with short names like pm | 1258 |
Rule | Violation | Line |
---|---|---|
UnusedPrivateField | Avoid unused private fields such as '_plugin'. | 50 |
AvoidSynchronizedAtMethodLevel | Use block level rather than method level synchronization | 57–65 |
CommentRequired | Public method and constructor comments are required | 83–88 |
Rule | Violation | Line |
---|---|---|
AvoidSynchronizedAtMethodLevel | Use block level rather than method level synchronization | 66–74 |
ShortVariable | Avoid variables with short names like sb | 104 |
AssignmentInOperand | Avoid assignments in operands | 110 |
AvoidCatchingGenericException | Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 122 |
CommentRequired | Public method and constructor comments are required | 130–135 |
Rule | Violation | Line |
---|---|---|
UseUtilityClass | All methods are static. Consider using a utility class instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning. | 44–66 |
Rule | Violation | Line |
---|---|---|
ShortVariable | Avoid variables with short names like pm | 59 |
ShortVariable | Avoid variables with short names like pm | 89 |
UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 91 |
ShortVariable | Avoid variables with short names like pm | 108 |
ShortVariable | Avoid variables with short names like pm | 120 |
Rule | Violation | Line |
---|---|---|
ShortVariable | Avoid variables with short names like pm | 108 |
UseLocaleWithCaseConversions | When doing a String.toLowerCase()/toUpperCase() call, use a Locale | 136 |
UseLocaleWithCaseConversions | When doing a String.toLowerCase()/toUpperCase() call, use a Locale | 136 |
UnnecessaryLocalBeforeReturn | Consider simply returning the value vs storing it in local variable 'strValueCap' | 138 |
ShortVariable | Avoid variables with short names like pm | 148 |
UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 150 |
ShortVariable | Avoid variables with short names like pm | 163 |
ShortVariable | Avoid variables with short names like pm | 177 |
Rule | Violation | Line |
---|---|---|
CommentRequired | Public method and constructor comments are required | 65–75 |
ConfusingTernary | Avoid if (x != y) ..; else ..; | 67–74 |
NullAssignment | Assigning an Object to null is a code smell. Consider refactoring. | 73 |
ShortVariable | Avoid variables with short names like pm | 91 |
CyclomaticComplexity | The method 'generate(PluginModel, String)' has a cyclomatic complexity of 12. | 91–136 |
MissingOverride | The method 'generate(PluginModel, String)' is missing an @Override annotation. | 91–136 |
ShortVariable | Avoid variables with short names like pm | 151 |
UseObjectForClearerAPI | Rather than using a lot of String arguments, consider using a container object for those values. | 151–152 |
ShortVariable | Avoid variables with short names like pm | 179 |
UseObjectForClearerAPI | Rather than using a lot of String arguments, consider using a container object for those values. | 179–180 |
ShortVariable | Avoid variables with short names like pm | 204 |
Rule | Violation | Line |
---|---|---|
ShortVariable | Avoid variables with short names like pm | 81 |
UseLocaleWithCaseConversions | When doing a String.toLowerCase()/toUpperCase() call, use a Locale | 122 |
UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 123 |
UnusedPrivateMethod | Avoid unused private methods such as 'getFeatureJspFile(String,String,boolean)'. | 141 |
UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 143 |
Rule | Violation | Line |
---|---|---|
ShortVariable | Avoid variables with short names like pm | 85 |
UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 137 |
AddEmptyString | Do not add empty strings | 141 |
UseLocaleWithCaseConversions | When doing a String.toLowerCase()/toUpperCase() call, use a Locale | 144 |
UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 162 |
Rule | Violation | Line |
---|---|---|
ShortVariable | Avoid variables with short names like pm | 68 |
UseLocaleWithCaseConversions | When doing a String.toLowerCase()/toUpperCase() call, use a Locale | 89 |
UseLocaleWithCaseConversions | When doing a String.toLowerCase()/toUpperCase() call, use a Locale | 97 |
UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 123 |
UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 123 |
UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 159 |
UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 159 |
Rule | Violation | Line |
---|---|---|
ConfusingTernary | Avoid if (x != y) ..; else ..; | 63–70 |
NullAssignment | Assigning an Object to null is a code smell. Consider refactoring. | 69 |
ShortVariable | Avoid variables with short names like pm | 77 |
UseObjectForClearerAPI | Rather than using a lot of String arguments, consider using a container object for those values. | 117 |
UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 119 |
Rule | Violation | Line |
---|---|---|
ConfusingTernary | Avoid if (x != y) ..; else ..; | 62–69 |
NullAssignment | Assigning an Object to null is a code smell. Consider refactoring. | 68 |
ShortVariable | Avoid variables with short names like pm | 76 |
UseObjectForClearerAPI | Rather than using a lot of String arguments, consider using a container object for those values. | 116 |
UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 118 |
Rule | Violation | Line |
---|---|---|
RedundantFieldInitializer | Avoid using redundant field initializer for '_bIsDefault' | 47 |
ConfusingTernary | Avoid if (x != y) ..; else ..; | 88–95 |
ConfusingTernary | Avoid if (x != y) ..; else ..; | 104–111 |
NullAssignment | Assigning an Object to null is a code smell. Consider refactoring. | 110 |
Rule | Violation | Line |
---|---|---|
UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 67 |
AvoidCatchingGenericException | Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 79 |
Rule | Violation | Line |
---|---|---|
ShortVariable | Avoid variables with short names like pm | 60 |
ShortVariable | Avoid variables with short names like pm | 69 |
UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 71 |
CommentRequired | Public method and constructor comments are required | 79–116 |
ShortVariable | Avoid variables with short names like pm | 79 |
UseCollectionIsEmpty | Substitute calls to size() == 0 (or size() != 0, size() > 0, size() < 1) with calls to isEmpty() | 85 |
ShortVariable | Avoid variables with short names like i | 88 |
ShortVariable | Avoid variables with short names like id | 89 |
ShortVariable | Avoid variables with short names like pm | 122 |
UseLocaleWithCaseConversions | When doing a String.toLowerCase()/toUpperCase() call, use a Locale | 124 |
Rule | Violation | Line |
---|---|---|
UnusedPrivateField | Avoid unused private fields such as 'KEY_PREFIX'. | 53 |
ShortVariable | Avoid variables with short names like pm | 64 |
ShortVariable | Avoid variables with short names like pm | 76 |
UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 78 |
ShortVariable | Avoid variables with short names like pm | 101 |
Rule | Violation | Line |
---|---|---|
ConfusingTernary | Avoid if (x != y) ..; else ..; | 62–69 |
NullAssignment | Assigning an Object to null is a code smell. Consider refactoring. | 68 |
ShortVariable | Avoid variables with short names like pm | 76 |
UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 114 |
Rule | Violation | Line |
---|---|---|
ShortVariable | Avoid variables with short names like pm | 55 |
UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 84 |
Rule | Violation | Line |
---|---|---|
ShortVariable | Avoid variables with short names like pm | 59 |
UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 95 |
Rule | Violation | Line |
---|---|---|
ShortVariable | Avoid variables with short names like pm | 57 |
UseLocaleWithCaseConversions | When doing a String.toLowerCase()/toUpperCase() call, use a Locale | 66 |
UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 108 |
Rule | Violation | Line |
---|---|---|
ShortVariable | Avoid variables with short names like pm | 56 |
UseLocaleWithCaseConversions | When doing a String.toLowerCase()/toUpperCase() call, use a Locale | 84 |
UseLocaleWithCaseConversions | When doing a String.toLowerCase()/toUpperCase() call, use a Locale | 84 |
UnnecessaryLocalBeforeReturn | Consider simply returning the value vs storing it in local variable 'strValueCap' | 86 |
UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 100 |
Rule | Violation | Line |
---|---|---|
ShortVariable | Avoid variables with short names like pm | 51 |
ShortVariable | Avoid variables with short names like pm | 60 |
UseLocaleWithCaseConversions | When doing a String.toLowerCase()/toUpperCase() call, use a Locale | 62 |
Rule | Violation | Line |
---|---|---|
ShortVariable | Avoid variables with short names like pm | 73 |
ShortVariable | Avoid variables with short names like pm | 101 |
ShortVariable | Avoid variables with short names like sb | 103 |
ShortVariable | Avoid variables with short names like pm | 122 |
ShortVariable | Avoid variables with short names like sb | 122 |
ConsecutiveLiteralAppends | StringBuffer (or StringBuilder).append is called 2 consecutive times with literals. Use a single append with a single combined String. | 127 |
AppendCharacterWithChar | Avoid appending characters as strings in StringBuffer.append. | 127 |
AppendCharacterWithChar | Avoid appending characters as strings in StringBuffer.append. | 128 |
AppendCharacterWithChar | Avoid appending characters as strings in StringBuffer.append. | 132 |
ConsecutiveLiteralAppends | StringBuffer (or StringBuilder).append is called 2 consecutive times with literals. Use a single append with a single combined String. | 132 |
AppendCharacterWithChar | Avoid appending characters as strings in StringBuffer.append. | 133 |
AppendCharacterWithChar | Avoid appending characters as strings in StringBuffer.append. | 136 |
ShortVariable | Avoid variables with short names like pm | 147 |
ShortVariable | Avoid variables with short names like sb | 147 |
ConsecutiveLiteralAppends | StringBuffer (or StringBuilder).append is called 2 consecutive times with literals. Use a single append with a single combined String. | 155 |
AppendCharacterWithChar | Avoid appending characters as strings in StringBuffer.append. | 155 |
AppendCharacterWithChar | Avoid appending characters as strings in StringBuffer.append. | 157 |
AppendCharacterWithChar | Avoid appending characters as strings in StringBuffer.append. | 160 |
ShortVariable | Avoid variables with short names like pm | 164 |
ShortVariable | Avoid variables with short names like sb | 164 |
AvoidDuplicateLiterals | The String literal "xpage." appears 4 times in this file; the first occurrence is on line 175 | 175 |
AppendCharacterWithChar | Avoid appending characters as strings in StringBuffer.append. | 176 |
ConsecutiveLiteralAppends | StringBuffer (or StringBuilder).append is called 2 consecutive times with literals. Use a single append with a single combined String. | 176 |
AppendCharacterWithChar | Avoid appending characters as strings in StringBuffer.append. | 178 |
UseLocaleWithCaseConversions | When doing a String.toLowerCase()/toUpperCase() call, use a Locale | 188 |
ConsecutiveLiteralAppends | StringBuffer (or StringBuilder).append is called 2 consecutive times with literals. Use a single append with a single combined String. | 189 |
UseLocaleWithCaseConversions | When doing a String.toLowerCase()/toUpperCase() call, use a Locale | 189 |
AppendCharacterWithChar | Avoid appending characters as strings in StringBuffer.append. | 189 |
UseLocaleWithCaseConversions | When doing a String.toLowerCase()/toUpperCase() call, use a Locale | 190 |
AppendCharacterWithChar | Avoid appending characters as strings in StringBuffer.append. | 191 |
UseLocaleWithCaseConversions | When doing a String.toLowerCase()/toUpperCase() call, use a Locale | 191 |
ShortVariable | Avoid variables with short names like pm | 209 |
CyclomaticComplexity | The method 'generateBusinessClassKeys(StringBuilder, PluginModel, String)' has a cyclomatic complexity of 11. | 209–278 |
ShortVariable | Avoid variables with short names like sb | 209 |
AppendCharacterWithChar | Avoid appending characters as strings in StringBuffer.append. | 218 |
UseLocaleWithCaseConversions | When doing a String.toLowerCase()/toUpperCase() call, use a Locale | 220 |
AppendCharacterWithChar | Avoid appending characters as strings in StringBuffer.append. | 221 |
AppendCharacterWithChar | Avoid appending characters as strings in StringBuffer.append. | 222 |
AppendCharacterWithChar | Avoid appending characters as strings in StringBuffer.append. | 223 |
AppendCharacterWithChar | Avoid appending characters as strings in StringBuffer.append. | 227 |
AppendCharacterWithChar | Avoid appending characters as strings in StringBuffer.append. | 227 |
UseLocaleWithCaseConversions | When doing a String.toLowerCase()/toUpperCase() call, use a Locale | 232 |
AppendCharacterWithChar | Avoid appending characters as strings in StringBuffer.append. | 233 |
AppendCharacterWithChar | Avoid appending characters as strings in StringBuffer.append. | 234 |
AppendCharacterWithChar | Avoid appending characters as strings in StringBuffer.append. | 238 |
AppendCharacterWithChar | Avoid appending characters as strings in StringBuffer.append. | 238 |
AppendCharacterWithChar | Avoid appending characters as strings in StringBuffer.append. | 244 |
AppendCharacterWithChar | Avoid appending characters as strings in StringBuffer.append. | 245 |
ConsecutiveLiteralAppends | StringBuffer (or StringBuilder).append is called 2 consecutive times with literals. Use a single append with a single combined String. | 245 |
UseLocaleWithCaseConversions | When doing a String.toLowerCase()/toUpperCase() call, use a Locale | 250 |
AppendCharacterWithChar | Avoid appending characters as strings in StringBuffer.append. | 259 |
AppendCharacterWithChar | Avoid appending characters as strings in StringBuffer.append. | 265 |
AddEmptyString | Do not add empty strings | 265 |
UseLocaleWithCaseConversions | When doing a String.toLowerCase()/toUpperCase() call, use a Locale | 271 |
AppendCharacterWithChar | Avoid appending characters as strings in StringBuffer.append. | 275 |
AppendCharacterWithChar | Avoid appending characters as strings in StringBuffer.append. | 275 |
ShortVariable | Avoid variables with short names like pm | 288 |
ShortVariable | Avoid variables with short names like sb | 288 |
UseLocaleWithCaseConversions | When doing a String.toLowerCase()/toUpperCase() call, use a Locale | 296 |
AppendCharacterWithChar | Avoid appending characters as strings in StringBuffer.append. | 297 |
AppendCharacterWithChar | Avoid appending characters as strings in StringBuffer.append. | 300 |
ShortVariable | Avoid variables with short names like sb | 312 |
ShortVariable | Avoid variables with short names like pm | 312 |
AppendCharacterWithChar | Avoid appending characters as strings in StringBuffer.append. | 322 |
AppendCharacterWithChar | Avoid appending characters as strings in StringBuffer.append. | 322 |
UseLocaleWithCaseConversions | When doing a String.toLowerCase()/toUpperCase() call, use a Locale | 322 |
AppendCharacterWithChar | Avoid appending characters as strings in StringBuffer.append. | 323 |
AppendCharacterWithChar | Avoid appending characters as strings in StringBuffer.append. | 323 |
AppendCharacterWithChar | Avoid appending characters as strings in StringBuffer.append. | 327 |
Rule | Violation | Line |
---|---|---|
ShortVariable | Avoid variables with short names like pm | 60 |
ShortVariable | Avoid variables with short names like pm | 85 |
Rule | Violation | Line |
---|---|---|
ShortVariable | Avoid variables with short names like pm | 60 |
ShortVariable | Avoid variables with short names like pm | 89 |
Rule | Violation | Line |
---|---|---|
ShortVariable | Avoid variables with short names like pm | 60 |
ShortVariable | Avoid variables with short names like pm | 85 |
Rule | Violation | Line |
---|---|---|
ShortVariable | Avoid variables with short names like pm | 60 |
ShortVariable | Avoid variables with short names like pm | 85 |
Rule | Violation | Line |
---|---|---|
ShortVariable | Avoid variables with short names like pm | 52 |
ShortVariable | Avoid variables with short names like pm | 76 |
UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 78 |
Rule | Violation | Line |
---|---|---|
ShortVariable | Avoid variables with short names like pm | 56 |
ShortVariable | Avoid variables with short names like pm | 68 |
UseLocaleWithCaseConversions | When doing a String.toLowerCase()/toUpperCase() call, use a Locale | 70 |
Rule | Violation | Line |
---|---|---|
ShortVariable | Avoid variables with short names like pm | 60 |
UseLocaleWithCaseConversions | When doing a String.toLowerCase()/toUpperCase() call, use a Locale | 68 |
ShortVariable | Avoid variables with short names like pm | 105 |
UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 107 |
Rule | Violation | Line |
---|---|---|
ConfusingTernary | Avoid if (x != y) ..; else ..; | 73–80 |
NullAssignment | Assigning an Object to null is a code smell. Consider refactoring. | 79 |
ShortVariable | Avoid variables with short names like pm | 89 |
CyclomaticComplexity | The method 'generate(PluginModel, String)' has a cyclomatic complexity of 11. | 89–128 |
UnusedLocalVariable | Avoid unused local variables such as 'strFilesPath'. | 92 |
PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 92 |
ShortVariable | Avoid variables with short names like pm | 145 |
ShortVariable | Avoid variables with short names like pm | 172 |
Rule | Violation | Line |
---|---|---|
ShortVariable | Avoid variables with short names like pm | 68 |
UseLocaleWithCaseConversions | When doing a String.toLowerCase()/toUpperCase() call, use a Locale | 93 |
UseLocaleWithCaseConversions | When doing a String.toLowerCase()/toUpperCase() call, use a Locale | 101 |
UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 129 |
UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 163 |
UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 192 |
Rule | Violation | Line |
---|---|---|
ShortVariable | Avoid variables with short names like c | 63 |
AvoidLiteralsInIfCondition | Avoid using Literals in Conditional Statements | 65 |
UseLocaleWithCaseConversions | When doing a String.toLowerCase()/toUpperCase() call, use a Locale | 75 |
UseLocaleWithCaseConversions | When doing a String.toLowerCase()/toUpperCase() call, use a Locale | 95 |
Rule | Violation | Line |
---|---|---|
ExcessiveImports | A high number of imports can indicate a high degree of coupling within an object. | 34–1507 |
ExcessivePublicCount | This class has a bunch of public methods and attributes | 34–1507 |
ExcessiveClassLength | Avoid really long classes. | 83–1507 |
TooManyMethods | This class has too many methods, consider refactoring it. | 84–1507 |
AvoidDeeplyNestedIfStmts | Deeply nested if..then statements are hard to read | 271–274 |
CommentRequired | Public method and constructor comments are required | 385–391 |
ConfusingTernary | Avoid if (x != y) ..; else ..; | 431 |
ShortVariable | Avoid variables with short names like pm | 520 |
ShortVariable | Avoid variables with short names like pm | 540 |
ConfusingTernary | Avoid if (x != y) ..; else ..; | 541 |
ShortVariable | Avoid variables with short names like pm | 561 |
ConfusingTernary | Avoid if (x != y) ..; else ..; | 592–610 |
NullAssignment | Assigning an Object to null is a code smell. Consider refactoring. | 606 |
ConfusingTernary | Avoid if (x != y) ..; else ..; | 628–646 |
NullAssignment | Assigning an Object to null is a code smell. Consider refactoring. | 642 |
ConfusingTernary | Avoid if (x != y) ..; else ..; | 715 |
NullAssignment | Assigning an Object to null is a code smell. Consider refactoring. | 742 |
NullAssignment | Assigning an Object to null is a code smell. Consider refactoring. | 773 |
NullAssignment | Assigning an Object to null is a code smell. Consider refactoring. | 801 |
NullAssignment | Assigning an Object to null is a code smell. Consider refactoring. | 942 |
NullAssignment | Assigning an Object to null is a code smell. Consider refactoring. | 969 |
CommentRequired | Public method and constructor comments are required | 1014–1017 |
ShortVariable | Avoid variables with short names like pm | 1049 |
ConfusingTernary | Avoid if (x != y) ..; else ..; | 1050 |
ShortVariable | Avoid variables with short names like pm | 1070 |
NullAssignment | Assigning an Object to null is a code smell. Consider refactoring. | 1108 |
NullAssignment | Assigning an Object to null is a code smell. Consider refactoring. | 1135 |
ConfusingTernary | Avoid if (x != y) ..; else ..; | 1207 |
NullAssignment | Assigning an Object to null is a code smell. Consider refactoring. | 1256 |
NullAssignment | Assigning an Object to null is a code smell. Consider refactoring. | 1280 |
ShortVariable | Avoid variables with short names like pm | 1332 |
ShortVariable | Avoid variables with short names like e | 1408 |
Rule | Violation | Line |
---|---|---|
SingularField | Perhaps '_nDefaultItemsPerPage' could be replaced by a local variable. | 109 |
UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 134 |
UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 134 |
AddEmptyString | Do not add empty strings | 136 |
UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 156 |
UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 156 |
PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 172 |
PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 174 |
PositionLiteralsFirstInComparisons | Position literals first in String comparisons | 176 |
PositionLiteralsFirstInComparisons | Position literals first in String comparisons | 181 |
UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 239 |
UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 239 |
PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 259 |
Rule | Violation | Line |
---|---|---|
MissingSerialVersionUID | Classes implementing Serializable should set a serialVersionUID | 44–183 |
Rule | Violation | Line |
---|---|---|
MissingSerialVersionUID | Classes implementing Serializable should set a serialVersionUID | 47–339 |
UnnecessaryConstructor | Avoid unnecessary constructors - the compiler will generate these for you | 75–77 |
UncommentedEmptyConstructor | Document empty constructor | 75–77 |
Rule | Violation | Line |
---|---|---|
MissingSerialVersionUID | Classes implementing Serializable should set a serialVersionUID | 44–66 |
Rule | Violation | Line |
---|---|---|
BooleanGetMethodName | A getX() method which returns a boolean should be named isX() | 226–229 |
Rule | Violation | Line |
---|---|---|
BooleanGetMethodName | A getX() method which returns a boolean should be named isX() | 668–671 |
Rule | Violation | Line |
---|---|---|
ShortClassName | Avoid short class names like Rest | 43–108 |
Rule | Violation | Line |
---|---|---|
UnusedImports | Avoid unused imports such as 'fr.paris.lutece.plugins.pluginwizard.util.Utils' | 40 |
Rule | Violation | Line |
---|---|---|
UnusedImports | Avoid unused imports such as 'fr.paris.lutece.plugins.pluginwizard.util.Utils' | 40 |
Rule | Violation | Line |
---|---|---|
UnusedImports | Avoid unused imports such as 'fr.paris.lutece.portal.service.datastore.DatastoreService' | 39 |
UnusedImports | Avoid unused imports such as 'fr.paris.lutece.util.ReferenceList' | 40 |
Rule | Violation | Line |
---|---|---|
UnusedImports | Avoid unused imports such as 'fr.paris.lutece.plugins.pluginwizard.util.Utils' | 40 |
Rule | Violation | Line |
---|---|---|
BooleanGetMethodName | A getX() method which returns a boolean should be named isX() | 324–327 |
Rule | Violation | Priority | Line |
---|---|---|---|
MissingOverride | The method 'insert(ConfigurationKey, Plugin)' is missing an @Override annotation. | 3 | 91–105 |
MissingOverride | The method 'load(int, Plugin)' is missing an @Override annotation. | 3 | 116–138 |
MissingOverride | The method 'delete(int, Plugin)' is missing an @Override annotation. | 3 | 148–156 |
MissingOverride | The method 'store(ConfigurationKey, Plugin)' is missing an @Override annotation. | 3 | 166–179 |
MissingOverride | The method 'selectConfigurationKeysList(Plugin)' is missing an @Override annotation. | 3 | 188–210 |
Rule | Violation | Priority | Line |
---|---|---|---|
ConfusingTernary | Avoid if (x != y) ..; else ..; | 3 | 132–139 |
ConfusingTernary | Avoid if (x != y) ..; else ..; | 3 | 150–157 |
NullAssignment | Assigning an Object to null is a code smell. Consider refactoring. | 3 | 156 |
Rule | Violation | Priority | Line |
---|---|---|---|
UseLocaleWithCaseConversions | When doing a String.toLowerCase()/toUpperCase() call, use a Locale | 3 | 157 |
UseLocaleWithCaseConversions | When doing a String.toLowerCase()/toUpperCase() call, use a Locale | 3 | 190 |
UseLocaleWithCaseConversions | When doing a String.toLowerCase()/toUpperCase() call, use a Locale | 3 | 201 |
BooleanGetMethodName | A getX() method which returns a boolean should be named isX() | 4 | 226–229 |
Rule | Violation | Priority | Line |
---|---|---|---|
ConfusingTernary | Avoid if (x != y) ..; else ..; | 3 | 142–149 |
NullAssignment | Assigning an Object to null is a code smell. Consider refactoring. | 3 | 148 |
ConfusingTernary | Avoid if (x != y) ..; else ..; | 3 | 159–166 |
Rule | Violation | Priority | Line |
---|---|---|---|
ConfusingTernary | Avoid if (x != y) ..; else ..; | 3 | 229–236 |
ConfusingTernary | Avoid if (x != y) ..; else ..; | 3 | 247–254 |
NullAssignment | Assigning an Object to null is a code smell. Consider refactoring. | 3 | 253 |
Rule | Violation | Priority | Line |
---|---|---|---|
ExcessivePublicCount | This class has a bunch of public methods and attributes | 3 | 34–684 |
TooManyFields | Too many fields | 3 | 51–684 |
UseLocaleWithCaseConversions | When doing a String.toLowerCase()/toUpperCase() call, use a Locale | 3 | 195 |
UseLocaleWithCaseConversions | When doing a String.toLowerCase()/toUpperCase() call, use a Locale | 3 | 199 |
ConfusingTernary | Avoid if (x != y) ..; else ..; | 3 | 514–521 |
NullAssignment | Assigning an Object to null is a code smell. Consider refactoring. | 3 | 520 |
ConfusingTernary | Avoid if (x != y) ..; else ..; | 3 | 563–570 |
NullAssignment | Assigning an Object to null is a code smell. Consider refactoring. | 3 | 569 |
ConfusingTernary | Avoid if (x != y) ..; else ..; | 3 | 591–598 |
NullAssignment | Assigning an Object to null is a code smell. Consider refactoring. | 3 | 597 |
CommentRequired | Public method and constructor comments are required | 3 | 621–624 |
MethodNamingConventions | The instance method name 'BusinessClass' doesn't match '[a-z][a-zA-Z0-9]*' | 1 | 626–629 |
CommentRequired | Public method and constructor comments are required | 3 | 626–629 |
BooleanGetMethodName | A getX() method which returns a boolean should be named isX() | 4 | 668–671 |
Rule | Violation | Priority | Line |
---|---|---|---|
MissingOverride | The method 'insert(PluginModel, Plugin)' is missing an @Override annotation. | 3 | 93–118 |
MissingOverride | The method 'load(int, Plugin)' is missing an @Override annotation. | 3 | 129–164 |
MissingOverride | The method 'delete(int, Plugin)' is missing an @Override annotation. | 3 | 174–182 |
MissingOverride | The method 'store(PluginModel, Plugin)' is missing an @Override annotation. | 3 | 192–216 |
MissingOverride | The method 'selectPluginModelsList(Plugin)' is missing an @Override annotation. | 3 | 225–258 |
MissingOverride | The method 'selectPluginModelByName(Plugin, String)' is missing an @Override annotation. | 3 | 269–287 |
MissingOverride | The method 'pluginExists(String, Plugin)' is missing an @Override annotation. | 3 | 298–321 |
Rule | Violation | Priority | Line |
---|---|---|---|
ShortClassName | Avoid short class names like Rest | 4 | 43–108 |
ConfusingTernary | Avoid if (x != y) ..; else ..; | 3 | 81–88 |
ConfusingTernary | Avoid if (x != y) ..; else ..; | 3 | 99–106 |
NullAssignment | Assigning an Object to null is a code smell. Consider refactoring. | 3 | 105 |
Rule | Violation | Priority | Line |
---|---|---|---|
ConfusingTernary | Avoid if (x != y) ..; else ..; | 3 | 60–67 |
NullAssignment | Assigning an Object to null is a code smell. Consider refactoring. | 3 | 66 |
Rule | Violation | Priority | Line |
---|---|---|---|
ShortVariable | Avoid variables with short names like sw | 3 | 67 |
UnnecessaryLocalBeforeReturn | Consider simply returning the value vs storing it in local variable 'sw' | 3 | 68 |
AvoidCatchingGenericException | Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 3 | 91 |
Rule | Violation | Priority | Line |
---|---|---|---|
GodClass | Possible God Class (WMC=136, ATFD=143, TCC=1.714%) | 3 | 63–1269 |
CyclomaticComplexity | The class 'ModelService' has a total cyclomatic complexity of 136 (highest 7). | 3 | 63–1269 |
ExcessiveClassLength | Avoid really long classes. | 3 | 63–1269 |
TooManyMethods | This class has too many methods, consider refactoring it. | 3 | 64–1269 |
ShortVariable | Avoid variables with short names like ID | 3 | 67 |
ShortVariable | Avoid variables with short names like pm | 3 | 87 |
ShortVariable | Avoid variables with short names like pm | 3 | 105 |
ConfusingTernary | Avoid if (x != y) ..; else ..; | 3 | 108–116 |
ShortVariable | Avoid variables with short names like pm | 3 | 127 |
ConfusingTernary | Avoid if (x != y) ..; else ..; | 3 | 136–143 |
ShortVariable | Avoid variables with short names like pm | 3 | 153 |
ShortVariable | Avoid variables with short names like pm | 3 | 191 |
ShortVariable | Avoid variables with short names like pm | 3 | 211 |
ShortVariable | Avoid variables with short names like pm | 3 | 231 |
ShortVariable | Avoid variables with short names like pm | 3 | 256 |
ShortVariable | Avoid variables with short names like f | 3 | 261 |
ShortVariable | Avoid variables with short names like pm | 3 | 285 |
ShortVariable | Avoid variables with short names like f | 3 | 290 |
ShortVariable | Avoid variables with short names like pm | 3 | 318 |
ShortVariable | Avoid variables with short names like pm | 3 | 332 |
ShortVariable | Avoid variables with short names like pm | 3 | 355 |
ShortVariable | Avoid variables with short names like pm | 3 | 371 |
ShortVariable | Avoid variables with short names like pm | 3 | 396 |
ShortVariable | Avoid variables with short names like pm | 3 | 425 |
ShortVariable | Avoid variables with short names like f | 3 | 430 |
ShortVariable | Avoid variables with short names like pm | 3 | 458 |
ShortVariable | Avoid variables with short names like pm | 3 | 481 |
ShortVariable | Avoid variables with short names like pm | 3 | 496 |
ShortVariable | Avoid variables with short names like pm | 3 | 521 |
ShortVariable | Avoid variables with short names like p | 3 | 526 |
ShortVariable | Avoid variables with short names like pm | 3 | 550 |
ShortVariable | Avoid variables with short names like p | 3 | 555 |
ShortVariable | Avoid variables with short names like pm | 3 | 581 |
ShortVariable | Avoid variables with short names like pm | 3 | 595 |
ShortVariable | Avoid variables with short names like bc | 3 | 617 |
PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 619 |
ShortVariable | Avoid variables with short names like pm | 3 | 619 |
ForLoopCanBeForeach | This for loop can be replaced by a foreach loop | 3 | 637–644 |
UseStringBufferForStringAppends | Prefer StringBuilder (non-synchronized) or StringBuffer (synchronized) over += for concatenating strings | 3 | 641 |
UseStringBufferForStringAppends | Prefer StringBuilder (non-synchronized) or StringBuffer (synchronized) over += for concatenating strings | 3 | 643 |
ShortVariable | Avoid variables with short names like pm | 3 | 662 |
ShortVariable | Avoid variables with short names like pm | 3 | 687 |
ShortVariable | Avoid variables with short names like bc | 3 | 692 |
PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 698 |
ShortVariable | Avoid variables with short names like pm | 3 | 735 |
ShortVariable | Avoid variables with short names like bc | 3 | 740 |
ShortVariable | Avoid variables with short names like pm | 3 | 761 |
ShortVariable | Avoid variables with short names like pm | 3 | 784 |
ShortVariable | Avoid variables with short names like bc | 3 | 785 |
ConfusingTernary | Avoid if (x != y) ..; else ..; | 3 | 786–803 |
ShortVariable | Avoid variables with short names like pm | 3 | 818 |
ShortVariable | Avoid variables with short names like bc | 3 | 819 |
ShortVariable | Avoid variables with short names like pm | 3 | 867 |
ShortVariable | Avoid variables with short names like bc | 3 | 868 |
ShortVariable | Avoid variables with short names like pm | 3 | 901 |
ShortVariable | Avoid variables with short names like bc | 3 | 902 |
ShortVariable | Avoid variables with short names like pm | 3 | 936 |
ShortVariable | Avoid variables with short names like pm | 3 | 950 |
ShortVariable | Avoid variables with short names like pm | 3 | 964 |
ShortVariable | Avoid variables with short names like pm | 3 | 976 |
ShortVariable | Avoid variables with short names like pm | 3 | 1004 |
ShortVariable | Avoid variables with short names like pm | 3 | 1038 |
ShortVariable | Avoid variables with short names like pm | 3 | 1072 |
ShortVariable | Avoid variables with short names like pm | 3 | 1107 |
CommentRequired | Public method and constructor comments are required | 3 | 1225–1239 |
ShortVariable | Avoid variables with short names like pm | 3 | 1227 |
CommentRequired | Public method and constructor comments are required | 3 | 1241–1254 |
ShortVariable | Avoid variables with short names like pm | 3 | 1243 |
CommentRequired | Public method and constructor comments are required | 3 | 1256–1268 |
ShortVariable | Avoid variables with short names like pm | 3 | 1258 |
Rule | Violation | Priority | Line |
---|---|---|---|
UnusedPrivateField | Avoid unused private fields such as '_plugin'. | 3 | 50 |
AvoidSynchronizedAtMethodLevel | Use block level rather than method level synchronization | 3 | 57–65 |
CommentRequired | Public method and constructor comments are required | 3 | 83–88 |
Rule | Violation | Priority | Line |
---|---|---|---|
AvoidSynchronizedAtMethodLevel | Use block level rather than method level synchronization | 3 | 66–74 |
ShortVariable | Avoid variables with short names like sb | 3 | 104 |
AssignmentInOperand | Avoid assignments in operands | 3 | 110 |
AvoidCatchingGenericException | Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 3 | 122 |
CommentRequired | Public method and constructor comments are required | 3 | 130–135 |
Rule | Violation | Priority | Line |
---|---|---|---|
UseUtilityClass | All methods are static. Consider using a utility class instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning. | 3 | 44–66 |
Rule | Violation | Priority | Line |
---|---|---|---|
ShortVariable | Avoid variables with short names like pm | 3 | 59 |
ShortVariable | Avoid variables with short names like pm | 3 | 89 |
UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 3 | 91 |
ShortVariable | Avoid variables with short names like pm | 3 | 108 |
ShortVariable | Avoid variables with short names like pm | 3 | 120 |
Rule | Violation | Priority | Line |
---|---|---|---|
ShortVariable | Avoid variables with short names like pm | 3 | 108 |
UseLocaleWithCaseConversions | When doing a String.toLowerCase()/toUpperCase() call, use a Locale | 3 | 136 |
UseLocaleWithCaseConversions | When doing a String.toLowerCase()/toUpperCase() call, use a Locale | 3 | 136 |
UnnecessaryLocalBeforeReturn | Consider simply returning the value vs storing it in local variable 'strValueCap' | 3 | 138 |
ShortVariable | Avoid variables with short names like pm | 3 | 148 |
UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 3 | 150 |
ShortVariable | Avoid variables with short names like pm | 3 | 163 |
ShortVariable | Avoid variables with short names like pm | 3 | 177 |
Rule | Violation | Priority | Line |
---|---|---|---|
CommentRequired | Public method and constructor comments are required | 3 | 65–75 |
ConfusingTernary | Avoid if (x != y) ..; else ..; | 3 | 67–74 |
NullAssignment | Assigning an Object to null is a code smell. Consider refactoring. | 3 | 73 |
ShortVariable | Avoid variables with short names like pm | 3 | 91 |
CyclomaticComplexity | The method 'generate(PluginModel, String)' has a cyclomatic complexity of 12. | 3 | 91–136 |
MissingOverride | The method 'generate(PluginModel, String)' is missing an @Override annotation. | 3 | 91–136 |
ShortVariable | Avoid variables with short names like pm | 3 | 151 |
UseObjectForClearerAPI | Rather than using a lot of String arguments, consider using a container object for those values. | 3 | 151–152 |
ShortVariable | Avoid variables with short names like pm | 3 | 179 |
UseObjectForClearerAPI | Rather than using a lot of String arguments, consider using a container object for those values. | 3 | 179–180 |
ShortVariable | Avoid variables with short names like pm | 3 | 204 |
Rule | Violation | Priority | Line |
---|---|---|---|
UnusedImports | Avoid unused imports such as 'fr.paris.lutece.plugins.pluginwizard.util.Utils' | 4 | 40 |
ShortVariable | Avoid variables with short names like pm | 3 | 81 |
UseLocaleWithCaseConversions | When doing a String.toLowerCase()/toUpperCase() call, use a Locale | 3 | 122 |
UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 3 | 123 |
UnusedPrivateMethod | Avoid unused private methods such as 'getFeatureJspFile(String,String,boolean)'. | 3 | 141 |
UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 3 | 143 |
Rule | Violation | Priority | Line |
---|---|---|---|
FieldNamingConventions | The static field name '_jsp_prefix' doesn't match '_[a-z][a-zA-Z0-9]*' | 1 | 53 |
ShortVariable | Avoid variables with short names like pm | 3 | 85 |
UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 3 | 137 |
AddEmptyString | Do not add empty strings | 3 | 141 |
UseLocaleWithCaseConversions | When doing a String.toLowerCase()/toUpperCase() call, use a Locale | 3 | 144 |
UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 3 | 162 |
Rule | Violation | Priority | Line |
---|---|---|---|
UnusedImports | Avoid unused imports such as 'fr.paris.lutece.plugins.pluginwizard.util.Utils' | 4 | 40 |
FieldNamingConventions | The static field name '_template_prefix' doesn't match '_[a-z][a-zA-Z0-9]*' | 1 | 57 |
ShortVariable | Avoid variables with short names like pm | 3 | 68 |
LocalVariableNamingConventions | The local variable name 'admin_feature' doesn't match '[a-z][a-zA-Z0-9]*' | 1 | 84 |
UseLocaleWithCaseConversions | When doing a String.toLowerCase()/toUpperCase() call, use a Locale | 3 | 89 |
UseLocaleWithCaseConversions | When doing a String.toLowerCase()/toUpperCase() call, use a Locale | 3 | 97 |
FormalParameterNamingConventions | The method parameter name 'admin_feature' doesn't match '[a-z][a-zA-Z0-9]*' | 1 | 120 |
UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 3 | 123 |
UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 3 | 123 |
UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 3 | 159 |
UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 3 | 159 |
Rule | Violation | Priority | Line |
---|---|---|---|
ConfusingTernary | Avoid if (x != y) ..; else ..; | 3 | 63–70 |
NullAssignment | Assigning an Object to null is a code smell. Consider refactoring. | 3 | 69 |
ShortVariable | Avoid variables with short names like pm | 3 | 77 |
UseObjectForClearerAPI | Rather than using a lot of String arguments, consider using a container object for those values. | 3 | 117 |
UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 3 | 119 |
Rule | Violation | Priority | Line |
---|---|---|---|
ConfusingTernary | Avoid if (x != y) ..; else ..; | 3 | 62–69 |
NullAssignment | Assigning an Object to null is a code smell. Consider refactoring. | 3 | 68 |
ShortVariable | Avoid variables with short names like pm | 3 | 76 |
UseObjectForClearerAPI | Rather than using a lot of String arguments, consider using a container object for those values. | 3 | 116 |
UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 3 | 118 |
Rule | Violation | Priority | Line |
---|---|---|---|
RedundantFieldInitializer | Avoid using redundant field initializer for '_bIsDefault' | 3 | 47 |
ConfusingTernary | Avoid if (x != y) ..; else ..; | 3 | 88–95 |
ConfusingTernary | Avoid if (x != y) ..; else ..; | 3 | 104–111 |
NullAssignment | Assigning an Object to null is a code smell. Consider refactoring. | 3 | 110 |
FormalParameterNamingConventions | The method parameter name '_bIsDefault' doesn't match '[a-z][a-zA-Z0-9]*' | 1 | 129 |
Rule | Violation | Priority | Line |
---|---|---|---|
UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 3 | 67 |
AvoidCatchingGenericException | Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 3 | 79 |
Rule | Violation | Priority | Line |
---|---|---|---|
ClassNamingConventions | The utility class name 'Markers' doesn't match '[A-Z][a-zA-Z0-9]+(Utils?|Helper|Home|Service)' | 1 | 39–89 |
Rule | Violation | Priority | Line |
---|---|---|---|
ShortVariable | Avoid variables with short names like pm | 3 | 60 |
ShortVariable | Avoid variables with short names like pm | 3 | 69 |
UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 3 | 71 |
CommentRequired | Public method and constructor comments are required | 3 | 79–116 |
ShortVariable | Avoid variables with short names like pm | 3 | 79 |
UseCollectionIsEmpty | Substitute calls to size() == 0 (or size() != 0, size() > 0, size() < 1) with calls to isEmpty() | 3 | 85 |
LocalVariableNamingConventions | The local variable name 'BusinessNames' doesn't match '[a-z][a-zA-Z0-9]*' | 1 | 87 |
ShortVariable | Avoid variables with short names like i | 3 | 88 |
ShortVariable | Avoid variables with short names like id | 3 | 89 |
ShortVariable | Avoid variables with short names like pm | 3 | 122 |
UseLocaleWithCaseConversions | When doing a String.toLowerCase()/toUpperCase() call, use a Locale | 3 | 124 |
Rule | Violation | Priority | Line |
---|---|---|---|
UnusedImports | Avoid unused imports such as 'fr.paris.lutece.portal.service.datastore.DatastoreService' | 4 | 39 |
UnusedImports | Avoid unused imports such as 'fr.paris.lutece.util.ReferenceList' | 4 | 40 |
UnusedPrivateField | Avoid unused private fields such as 'KEY_PREFIX'. | 3 | 53 |
ShortVariable | Avoid variables with short names like pm | 3 | 64 |
ShortVariable | Avoid variables with short names like pm | 3 | 76 |
UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 3 | 78 |
ShortVariable | Avoid variables with short names like pm | 3 | 101 |
Rule | Violation | Priority | Line |
---|---|---|---|
ConfusingTernary | Avoid if (x != y) ..; else ..; | 3 | 62–69 |
NullAssignment | Assigning an Object to null is a code smell. Consider refactoring. | 3 | 68 |
ShortVariable | Avoid variables with short names like pm | 3 | 76 |
UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 3 | 114 |
Rule | Violation | Priority | Line |
---|---|---|---|
ShortVariable | Avoid variables with short names like pm | 3 | 55 |
LocalVariableNamingConventions | The local variable name '_path' doesn't match '[a-z][a-zA-Z0-9]*' | 1 | 60 |
UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 3 | 84 |
Rule | Violation | Priority | Line |
---|---|---|---|
ShortVariable | Avoid variables with short names like pm | 3 | 59 |
LocalVariableNamingConventions | The local variable name '_path' doesn't match '[a-z][a-zA-Z0-9]*' | 1 | 64 |
UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 3 | 95 |
Rule | Violation | Priority | Line |
---|---|---|---|
ShortVariable | Avoid variables with short names like pm | 3 | 57 |
UseLocaleWithCaseConversions | When doing a String.toLowerCase()/toUpperCase() call, use a Locale | 3 | 66 |
UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 3 | 108 |
Rule | Violation | Priority | Line |
---|---|---|---|
ShortVariable | Avoid variables with short names like pm | 3 | 56 |
UseLocaleWithCaseConversions | When doing a String.toLowerCase()/toUpperCase() call, use a Locale | 3 | 84 |
UseLocaleWithCaseConversions | When doing a String.toLowerCase()/toUpperCase() call, use a Locale | 3 | 84 |
UnnecessaryLocalBeforeReturn | Consider simply returning the value vs storing it in local variable 'strValueCap' | 3 | 86 |
UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 3 | 100 |
Rule | Violation | Priority | Line |
---|---|---|---|
ShortVariable | Avoid variables with short names like pm | 3 | 51 |
ShortVariable | Avoid variables with short names like pm | 3 | 60 |
UseLocaleWithCaseConversions | When doing a String.toLowerCase()/toUpperCase() call, use a Locale | 3 | 62 |
Rule | Violation | Priority | Line |
---|---|---|---|
ShortVariable | Avoid variables with short names like pm | 3 | 73 |
ShortVariable | Avoid variables with short names like pm | 3 | 101 |
ShortVariable | Avoid variables with short names like sb | 3 | 103 |
ShortVariable | Avoid variables with short names like pm | 3 | 122 |
ShortVariable | Avoid variables with short names like sb | 3 | 122 |
ConsecutiveLiteralAppends | StringBuffer (or StringBuilder).append is called 2 consecutive times with literals. Use a single append with a single combined String. | 3 | 127 |
AppendCharacterWithChar | Avoid appending characters as strings in StringBuffer.append. | 3 | 127 |
AppendCharacterWithChar | Avoid appending characters as strings in StringBuffer.append. | 3 | 128 |
AppendCharacterWithChar | Avoid appending characters as strings in StringBuffer.append. | 3 | 132 |
ConsecutiveLiteralAppends | StringBuffer (or StringBuilder).append is called 2 consecutive times with literals. Use a single append with a single combined String. | 3 | 132 |
AppendCharacterWithChar | Avoid appending characters as strings in StringBuffer.append. | 3 | 133 |
AppendCharacterWithChar | Avoid appending characters as strings in StringBuffer.append. | 3 | 136 |
ShortVariable | Avoid variables with short names like pm | 3 | 147 |
ShortVariable | Avoid variables with short names like sb | 3 | 147 |
ConsecutiveLiteralAppends | StringBuffer (or StringBuilder).append is called 2 consecutive times with literals. Use a single append with a single combined String. | 3 | 155 |
AppendCharacterWithChar | Avoid appending characters as strings in StringBuffer.append. | 3 | 155 |
AppendCharacterWithChar | Avoid appending characters as strings in StringBuffer.append. | 3 | 157 |
AppendCharacterWithChar | Avoid appending characters as strings in StringBuffer.append. | 3 | 160 |
ShortVariable | Avoid variables with short names like pm | 3 | 164 |
ShortVariable | Avoid variables with short names like sb | 3 | 164 |
AvoidDuplicateLiterals | The String literal "xpage." appears 4 times in this file; the first occurrence is on line 175 | 3 | 175 |
AppendCharacterWithChar | Avoid appending characters as strings in StringBuffer.append. | 3 | 176 |
ConsecutiveLiteralAppends | StringBuffer (or StringBuilder).append is called 2 consecutive times with literals. Use a single append with a single combined String. | 3 | 176 |
AppendCharacterWithChar | Avoid appending characters as strings in StringBuffer.append. | 3 | 178 |
UseLocaleWithCaseConversions | When doing a String.toLowerCase()/toUpperCase() call, use a Locale | 3 | 188 |
ConsecutiveLiteralAppends | StringBuffer (or StringBuilder).append is called 2 consecutive times with literals. Use a single append with a single combined String. | 3 | 189 |
UseLocaleWithCaseConversions | When doing a String.toLowerCase()/toUpperCase() call, use a Locale | 3 | 189 |
AppendCharacterWithChar | Avoid appending characters as strings in StringBuffer.append. | 3 | 189 |
UseLocaleWithCaseConversions | When doing a String.toLowerCase()/toUpperCase() call, use a Locale | 3 | 190 |
AppendCharacterWithChar | Avoid appending characters as strings in StringBuffer.append. | 3 | 191 |
UseLocaleWithCaseConversions | When doing a String.toLowerCase()/toUpperCase() call, use a Locale | 3 | 191 |
ShortVariable | Avoid variables with short names like pm | 3 | 209 |
CyclomaticComplexity | The method 'generateBusinessClassKeys(StringBuilder, PluginModel, String)' has a cyclomatic complexity of 11. | 3 | 209–278 |
ShortVariable | Avoid variables with short names like sb | 3 | 209 |
AppendCharacterWithChar | Avoid appending characters as strings in StringBuffer.append. | 3 | 218 |
UseLocaleWithCaseConversions | When doing a String.toLowerCase()/toUpperCase() call, use a Locale | 3 | 220 |
AppendCharacterWithChar | Avoid appending characters as strings in StringBuffer.append. | 3 | 221 |
AppendCharacterWithChar | Avoid appending characters as strings in StringBuffer.append. | 3 | 222 |
AppendCharacterWithChar | Avoid appending characters as strings in StringBuffer.append. | 3 | 223 |
AppendCharacterWithChar | Avoid appending characters as strings in StringBuffer.append. | 3 | 227 |
AppendCharacterWithChar | Avoid appending characters as strings in StringBuffer.append. | 3 | 227 |
UseLocaleWithCaseConversions | When doing a String.toLowerCase()/toUpperCase() call, use a Locale | 3 | 232 |
AppendCharacterWithChar | Avoid appending characters as strings in StringBuffer.append. | 3 | 233 |
AppendCharacterWithChar | Avoid appending characters as strings in StringBuffer.append. | 3 | 234 |
AppendCharacterWithChar | Avoid appending characters as strings in StringBuffer.append. | 3 | 238 |
AppendCharacterWithChar | Avoid appending characters as strings in StringBuffer.append. | 3 | 238 |
AppendCharacterWithChar | Avoid appending characters as strings in StringBuffer.append. | 3 | 244 |
AppendCharacterWithChar | Avoid appending characters as strings in StringBuffer.append. | 3 | 245 |
ConsecutiveLiteralAppends | StringBuffer (or StringBuilder).append is called 2 consecutive times with literals. Use a single append with a single combined String. | 3 | 245 |
UseLocaleWithCaseConversions | When doing a String.toLowerCase()/toUpperCase() call, use a Locale | 3 | 250 |
AppendCharacterWithChar | Avoid appending characters as strings in StringBuffer.append. | 3 | 259 |
AppendCharacterWithChar | Avoid appending characters as strings in StringBuffer.append. | 3 | 265 |
AddEmptyString | Do not add empty strings | 3 | 265 |
UseLocaleWithCaseConversions | When doing a String.toLowerCase()/toUpperCase() call, use a Locale | 3 | 271 |
AppendCharacterWithChar | Avoid appending characters as strings in StringBuffer.append. | 3 | 275 |
AppendCharacterWithChar | Avoid appending characters as strings in StringBuffer.append. | 3 | 275 |
ShortVariable | Avoid variables with short names like pm | 3 | 288 |
ShortVariable | Avoid variables with short names like sb | 3 | 288 |
UseLocaleWithCaseConversions | When doing a String.toLowerCase()/toUpperCase() call, use a Locale | 3 | 296 |
AppendCharacterWithChar | Avoid appending characters as strings in StringBuffer.append. | 3 | 297 |
AppendCharacterWithChar | Avoid appending characters as strings in StringBuffer.append. | 3 | 300 |
ShortVariable | Avoid variables with short names like sb | 3 | 312 |
ShortVariable | Avoid variables with short names like pm | 3 | 312 |
AppendCharacterWithChar | Avoid appending characters as strings in StringBuffer.append. | 3 | 322 |
AppendCharacterWithChar | Avoid appending characters as strings in StringBuffer.append. | 3 | 322 |
UseLocaleWithCaseConversions | When doing a String.toLowerCase()/toUpperCase() call, use a Locale | 3 | 322 |
AppendCharacterWithChar | Avoid appending characters as strings in StringBuffer.append. | 3 | 323 |
AppendCharacterWithChar | Avoid appending characters as strings in StringBuffer.append. | 3 | 323 |
AppendCharacterWithChar | Avoid appending characters as strings in StringBuffer.append. | 3 | 327 |
Rule | Violation | Priority | Line |
---|---|---|---|
ShortVariable | Avoid variables with short names like pm | 3 | 60 |
ShortVariable | Avoid variables with short names like pm | 3 | 85 |
Rule | Violation | Priority | Line |
---|---|---|---|
ShortVariable | Avoid variables with short names like pm | 3 | 60 |
ShortVariable | Avoid variables with short names like pm | 3 | 89 |
Rule | Violation | Priority | Line |
---|---|---|---|
ShortVariable | Avoid variables with short names like pm | 3 | 60 |
ShortVariable | Avoid variables with short names like pm | 3 | 85 |
Rule | Violation | Priority | Line |
---|---|---|---|
ShortVariable | Avoid variables with short names like pm | 3 | 60 |
ShortVariable | Avoid variables with short names like pm | 3 | 85 |
Rule | Violation | Priority | Line |
---|---|---|---|
ShortVariable | Avoid variables with short names like pm | 3 | 52 |
ShortVariable | Avoid variables with short names like pm | 3 | 76 |
UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 3 | 78 |
Rule | Violation | Priority | Line |
---|---|---|---|
ShortVariable | Avoid variables with short names like pm | 3 | 56 |
ShortVariable | Avoid variables with short names like pm | 3 | 68 |
UseLocaleWithCaseConversions | When doing a String.toLowerCase()/toUpperCase() call, use a Locale | 3 | 70 |
Rule | Violation | Priority | Line |
---|---|---|---|
ShortVariable | Avoid variables with short names like pm | 3 | 60 |
UseLocaleWithCaseConversions | When doing a String.toLowerCase()/toUpperCase() call, use a Locale | 3 | 68 |
ShortVariable | Avoid variables with short names like pm | 3 | 105 |
UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 3 | 107 |
Rule | Violation | Priority | Line |
---|---|---|---|
ConfusingTernary | Avoid if (x != y) ..; else ..; | 3 | 73–80 |
NullAssignment | Assigning an Object to null is a code smell. Consider refactoring. | 3 | 79 |
ShortVariable | Avoid variables with short names like pm | 3 | 89 |
CyclomaticComplexity | The method 'generate(PluginModel, String)' has a cyclomatic complexity of 11. | 3 | 89–128 |
UnusedLocalVariable | Avoid unused local variables such as 'strFilesPath'. | 3 | 92 |
PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 92 |
ShortVariable | Avoid variables with short names like pm | 3 | 145 |
ShortVariable | Avoid variables with short names like pm | 3 | 172 |
Rule | Violation | Priority | Line |
---|---|---|---|
UnusedImports | Avoid unused imports such as 'fr.paris.lutece.plugins.pluginwizard.util.Utils' | 4 | 40 |
FieldNamingConventions | The static field name '_template_prefix' doesn't match '_[a-z][a-zA-Z0-9]*' | 1 | 57 |
ShortVariable | Avoid variables with short names like pm | 3 | 68 |
UseLocaleWithCaseConversions | When doing a String.toLowerCase()/toUpperCase() call, use a Locale | 3 | 93 |
UseLocaleWithCaseConversions | When doing a String.toLowerCase()/toUpperCase() call, use a Locale | 3 | 101 |
UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 3 | 129 |
UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 3 | 163 |
UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 3 | 192 |
Rule | Violation | Priority | Line |
---|---|---|---|
ClassNamingConventions | The utility class name 'Utils' doesn't match '[A-Z][a-zA-Z0-9]+(Utils?|Helper|Home|Service)' | 1 | 39–97 |
ShortVariable | Avoid variables with short names like c | 3 | 63 |
AvoidLiteralsInIfCondition | Avoid using Literals in Conditional Statements | 3 | 65 |
UseLocaleWithCaseConversions | When doing a String.toLowerCase()/toUpperCase() call, use a Locale | 3 | 75 |
UseLocaleWithCaseConversions | When doing a String.toLowerCase()/toUpperCase() call, use a Locale | 3 | 95 |
Rule | Violation | Priority | Line |
---|---|---|---|
ClassNamingConventions | The utility class name 'Constants' doesn't match '[A-Z][a-zA-Z0-9]+(Utils?|Helper|Home|Service)' | 1 | 41–76 |
Rule | Violation | Priority | Line |
---|---|---|---|
ExcessiveImports | A high number of imports can indicate a high degree of coupling within an object. | 3 | 34–1507 |
ExcessivePublicCount | This class has a bunch of public methods and attributes | 3 | 34–1507 |
ExcessiveClassLength | Avoid really long classes. | 3 | 83–1507 |
TooManyMethods | This class has too many methods, consider refactoring it. | 3 | 84–1507 |
AvoidDeeplyNestedIfStmts | Deeply nested if..then statements are hard to read | 3 | 271–274 |
CommentRequired | Public method and constructor comments are required | 3 | 385–391 |
ConfusingTernary | Avoid if (x != y) ..; else ..; | 3 | 431 |
ShortVariable | Avoid variables with short names like pm | 3 | 520 |
ShortVariable | Avoid variables with short names like pm | 3 | 540 |
ConfusingTernary | Avoid if (x != y) ..; else ..; | 3 | 541 |
ShortVariable | Avoid variables with short names like pm | 3 | 561 |
ConfusingTernary | Avoid if (x != y) ..; else ..; | 3 | 592–610 |
NullAssignment | Assigning an Object to null is a code smell. Consider refactoring. | 3 | 606 |
ConfusingTernary | Avoid if (x != y) ..; else ..; | 3 | 628–646 |
NullAssignment | Assigning an Object to null is a code smell. Consider refactoring. | 3 | 642 |
ConfusingTernary | Avoid if (x != y) ..; else ..; | 3 | 715 |
NullAssignment | Assigning an Object to null is a code smell. Consider refactoring. | 3 | 742 |
NullAssignment | Assigning an Object to null is a code smell. Consider refactoring. | 3 | 773 |
NullAssignment | Assigning an Object to null is a code smell. Consider refactoring. | 3 | 801 |
NullAssignment | Assigning an Object to null is a code smell. Consider refactoring. | 3 | 942 |
NullAssignment | Assigning an Object to null is a code smell. Consider refactoring. | 3 | 969 |
CommentRequired | Public method and constructor comments are required | 3 | 1014–1017 |
ShortVariable | Avoid variables with short names like pm | 3 | 1049 |
ConfusingTernary | Avoid if (x != y) ..; else ..; | 3 | 1050 |
ShortVariable | Avoid variables with short names like pm | 3 | 1070 |
NullAssignment | Assigning an Object to null is a code smell. Consider refactoring. | 3 | 1108 |
NullAssignment | Assigning an Object to null is a code smell. Consider refactoring. | 3 | 1135 |
ConfusingTernary | Avoid if (x != y) ..; else ..; | 3 | 1207 |
NullAssignment | Assigning an Object to null is a code smell. Consider refactoring. | 3 | 1256 |
NullAssignment | Assigning an Object to null is a code smell. Consider refactoring. | 3 | 1280 |
ShortVariable | Avoid variables with short names like pm | 3 | 1332 |
ShortVariable | Avoid variables with short names like e | 3 | 1408 |
Rule | Violation | Priority | Line |
---|---|---|---|
SingularField | Perhaps '_nDefaultItemsPerPage' could be replaced by a local variable. | 3 | 109 |
UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 3 | 134 |
UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 3 | 134 |
AddEmptyString | Do not add empty strings | 3 | 136 |
UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 3 | 156 |
UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 3 | 156 |
PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 172 |
PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 174 |
PositionLiteralsFirstInComparisons | Position literals first in String comparisons | 3 | 176 |
PositionLiteralsFirstInComparisons | Position literals first in String comparisons | 3 | 181 |
UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 3 | 239 |
UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 3 | 239 |
PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 259 |
Rule | Violation | Priority | Line |
---|---|---|---|
MissingSerialVersionUID | Classes implementing Serializable should set a serialVersionUID | 3 | 44–183 |
Rule | Violation | Priority | Line |
---|---|---|---|
MissingSerialVersionUID | Classes implementing Serializable should set a serialVersionUID | 3 | 47–339 |
UnnecessaryConstructor | Avoid unnecessary constructors - the compiler will generate these for you | 3 | 75–77 |
UncommentedEmptyConstructor | Document empty constructor | 3 | 75–77 |
FormalParameterNamingConventions | The method parameter name '_strType' doesn't match '[a-z][a-zA-Z0-9]*' | 1 | 304 |
BooleanGetMethodName | A getX() method which returns a boolean should be named isX() | 4 | 324–327 |
FormalParameterNamingConventions | The method parameter name '_bIsModule' doesn't match '[a-z][a-zA-Z0-9]*' | 1 | 335 |
Rule | Violation | Priority | Line |
---|---|---|---|
MissingSerialVersionUID | Classes implementing Serializable should set a serialVersionUID | 3 | 44–66 |