Lutece quicklinks plugin – Checkstyle Results

Checkstyle Results

The following document contains the results of Checkstyle 8.19 with build-config/lutece_checks.xml ruleset.

Summary

Files	Info	Warnings	Errors
58	0	9	78

Files

File	W	E
fr/paris/lutece/plugins/quicklinks/business/Entry.java	0	17
fr/paris/lutece/plugins/quicklinks/business/EntryDAO.java	0	2
fr/paris/lutece/plugins/quicklinks/business/EntryHome.java	3	0
fr/paris/lutece/plugins/quicklinks/business/EntryInternalLink.java	0	1
fr/paris/lutece/plugins/quicklinks/business/EntryInternalLinkDAO.java	1	0
fr/paris/lutece/plugins/quicklinks/business/EntrySelect.java	0	2
fr/paris/lutece/plugins/quicklinks/business/EntrySelectDAO.java	1	0
fr/paris/lutece/plugins/quicklinks/business/EntrySelectOption.java	0	1
fr/paris/lutece/plugins/quicklinks/business/EntrySelectOptionHome.java	2	0
fr/paris/lutece/plugins/quicklinks/business/EntryText.java	0	1
fr/paris/lutece/plugins/quicklinks/business/EntryTextDAO.java	1	0
fr/paris/lutece/plugins/quicklinks/business/EntryUrl.java	0	1
fr/paris/lutece/plugins/quicklinks/business/EntryUrlDAO.java	1	0
fr/paris/lutece/plugins/quicklinks/business/EntryUrlDisplayProperties.java	0	2
fr/paris/lutece/plugins/quicklinks/business/EntryUrlLinkProperties.java	0	2
fr/paris/lutece/plugins/quicklinks/business/IEntry.java	0	24
fr/paris/lutece/plugins/quicklinks/business/Quicklinks.java	0	3
fr/paris/lutece/plugins/quicklinks/business/QuicklinksDAO.java	0	1
fr/paris/lutece/plugins/quicklinks/business/QuicklinksHome.java	0	1
fr/paris/lutece/plugins/quicklinks/business/QuicklinksType.java	0	2
fr/paris/lutece/plugins/quicklinks/business/insertservice/InternalLinkInsertService.java	0	1
fr/paris/lutece/plugins/quicklinks/business/insertservice/InternalLinkInsertServiceDAO.java	0	2
fr/paris/lutece/plugins/quicklinks/business/insertservice/InternalLinkInsertServiceHome.java	0	2
fr/paris/lutece/plugins/quicklinks/service/QuicklinksService.java	0	1
fr/paris/lutece/plugins/quicklinks/web/InternalLinkInsertServiceJspBean.java	0	3
fr/paris/lutece/plugins/quicklinks/web/QuicklinksEntrySelectJspBean.java	0	2
fr/paris/lutece/plugins/quicklinks/web/QuicklinksJspBean.java	0	6
fr/paris/lutece/plugins/quicklinks/web/portlet/QuicklinksPortletJspBean.java	0	1

Rules

Category	Rule	Violations	Severity
coding	ArrayTrailingComma	5	Error
	DeclarationOrder	3	Error
	ReturnCount max: `"5"`	9	Warning
	SuperClone	7	Error
design	FinalClass	3	Error
header	Header fileExtensions: `"java"` headerFile: `"/opt/datas/jenkins/home/jobs/admin-github-build/workspace/target/checkstyle-header.txt"`	4	Error
imports	UnusedImports	1	Error
javadoc	JavadocMethod	26	Error
	JavadocType	2	Error
modifier	RedundantModifier	27	Error

Details

fr/paris/lutece/plugins/quicklinks/business/Entry.java

Severity	Category	Rule	Message	Line
Error	javadoc	JavadocType	Missing a Javadoc comment.	46
Error	javadoc	JavadocMethod	Missing a Javadoc comment.	77
Error	javadoc	JavadocMethod	Missing a Javadoc comment.	87
Error	javadoc	JavadocMethod	Missing a Javadoc comment.	97
Error	javadoc	JavadocMethod	Missing a Javadoc comment.	107
Error	javadoc	JavadocMethod	Missing a Javadoc comment.	117
Error	javadoc	JavadocMethod	Missing a Javadoc comment.	127
Error	javadoc	JavadocMethod	Missing a Javadoc comment.	137
Error	javadoc	JavadocMethod	Missing a Javadoc comment.	147
Error	javadoc	JavadocMethod	Missing a Javadoc comment.	159
Error	javadoc	JavadocMethod	Missing a Javadoc comment.	169
Error	javadoc	JavadocMethod	Expected @return tag.	176
Error	coding	SuperClone	Method 'clone' should call 'super.clone'.	176
Error	javadoc	JavadocMethod	Expected @throws tag for 'CloneNotSupportedException'.	176
Error	javadoc	JavadocMethod	Missing a Javadoc comment.	243
Error	javadoc	JavadocMethod	Missing a Javadoc comment.	253
Error	javadoc	JavadocMethod	Missing a Javadoc comment.	263

fr/paris/lutece/plugins/quicklinks/business/EntryDAO.java

Severity	Category	Rule	Message	Line
Error	javadoc	JavadocMethod	Expected @return tag.	148
Error	javadoc	JavadocMethod	Expected @param tag for 'plugin'.	227

fr/paris/lutece/plugins/quicklinks/business/EntryHome.java

Severity	Category	Rule	Message	Line
Warning	coding	ReturnCount	Return count is 2 (max allowed for void methods/constructors/lambdas is 1).	169
Warning	coding	ReturnCount	Return count is 2 (max allowed for void methods/constructors/lambdas is 1).	394
Warning	coding	ReturnCount	Return count is 2 (max allowed for void methods/constructors/lambdas is 1).	466

fr/paris/lutece/plugins/quicklinks/business/EntryInternalLink.java

Severity	Category	Rule	Message	Line
Error	coding	SuperClone	Method 'clone' should call 'super.clone'.	73

fr/paris/lutece/plugins/quicklinks/business/EntryInternalLinkDAO.java

Severity	Category	Rule	Message	Line
Warning	coding	ReturnCount	Return count is 2 (max allowed for void methods/constructors/lambdas is 1).	155

fr/paris/lutece/plugins/quicklinks/business/EntrySelect.java

Severity	Category	Rule	Message	Line
Error	imports	UnusedImports	Unused import - fr.paris.lutece.portal.web.constants.Messages.	47
Error	coding	SuperClone	Method 'clone' should call 'super.clone'.	90

fr/paris/lutece/plugins/quicklinks/business/EntrySelectDAO.java

Severity	Category	Rule	Message	Line
Warning	coding	ReturnCount	Return count is 2 (max allowed for void methods/constructors/lambdas is 1).	152

fr/paris/lutece/plugins/quicklinks/business/EntrySelectOption.java

Severity	Category	Rule	Message	Line
Error	coding	SuperClone	Method 'clone' should call 'super.clone'.	72

fr/paris/lutece/plugins/quicklinks/business/EntrySelectOptionHome.java

Severity	Category	Rule	Message	Line
Warning	coding	ReturnCount	Return count is 2 (max allowed for void methods/constructors/lambdas is 1).	139
Warning	coding	ReturnCount	Return count is 2 (max allowed for void methods/constructors/lambdas is 1).	204

fr/paris/lutece/plugins/quicklinks/business/EntryText.java

Severity	Category	Rule	Message	Line
Error	coding	SuperClone	Method 'clone' should call 'super.clone'.	83

fr/paris/lutece/plugins/quicklinks/business/EntryTextDAO.java

Severity	Category	Rule	Message	Line
Warning	coding	ReturnCount	Return count is 2 (max allowed for void methods/constructors/lambdas is 1).	155

fr/paris/lutece/plugins/quicklinks/business/EntryUrl.java

Severity	Category	Rule	Message	Line
Error	coding	SuperClone	Method 'clone' should call 'super.clone'.	201

fr/paris/lutece/plugins/quicklinks/business/EntryUrlDAO.java

Severity	Category	Rule	Message	Line
Warning	coding	ReturnCount	Return count is 2 (max allowed for void methods/constructors/lambdas is 1).	167

fr/paris/lutece/plugins/quicklinks/business/EntryUrlDisplayProperties.java

Severity	Category	Rule	Message	Line
Error	modifier	RedundantModifier	Redundant 'private' modifier.	56
Error	javadoc	JavadocMethod	Expected @param tag for 'strI18nKey'.	56

fr/paris/lutece/plugins/quicklinks/business/EntryUrlLinkProperties.java

Severity	Category	Rule	Message	Line
Error	modifier	RedundantModifier	Redundant 'private' modifier.	56
Error	javadoc	JavadocMethod	Expected @param tag for 'strI18nKey'.	56

fr/paris/lutece/plugins/quicklinks/business/IEntry.java

Severity	Category	Rule	Message	Line
Error	modifier	RedundantModifier	Redundant 'public' modifier.	53
Error	modifier	RedundantModifier	Redundant 'public' modifier.	59
Error	modifier	RedundantModifier	Redundant 'public' modifier.	64
Error	modifier	RedundantModifier	Redundant 'public' modifier.	70
Error	modifier	RedundantModifier	Redundant 'public' modifier.	75
Error	modifier	RedundantModifier	Redundant 'public' modifier.	81
Error	modifier	RedundantModifier	Redundant 'public' modifier.	86
Error	modifier	RedundantModifier	Redundant 'public' modifier.	92
Error	modifier	RedundantModifier	Redundant 'public' modifier.	99
Error	modifier	RedundantModifier	Redundant 'public' modifier.	108
Error	modifier	RedundantModifier	Redundant 'public' modifier.	113
Error	modifier	RedundantModifier	Redundant 'public' modifier.	119
Error	modifier	RedundantModifier	Redundant 'public' modifier.	124
Error	modifier	RedundantModifier	Redundant 'public' modifier.	130
Error	modifier	RedundantModifier	Redundant 'public' modifier.	141
Error	modifier	RedundantModifier	Redundant 'public' modifier.	153
Error	modifier	RedundantModifier	Redundant 'public' modifier.	162
Error	modifier	RedundantModifier	Redundant 'public' modifier.	169
Error	modifier	RedundantModifier	Redundant 'public' modifier.	180
Error	modifier	RedundantModifier	Redundant 'public' modifier.	193
Error	modifier	RedundantModifier	Redundant 'public' modifier.	201
Error	modifier	RedundantModifier	Redundant 'public' modifier.	209
Error	modifier	RedundantModifier	Redundant 'public' modifier.	217
Error	modifier	RedundantModifier	Redundant 'public' modifier.	225

fr/paris/lutece/plugins/quicklinks/business/Quicklinks.java

Severity	Category	Rule	Message	Line
Error	javadoc	JavadocMethod	Expected @return tag.	211
Error	javadoc	JavadocMethod	Expected @return tag.	219
Error	coding	SuperClone	Method 'clone' should call 'super.clone'.	294

fr/paris/lutece/plugins/quicklinks/business/QuicklinksDAO.java

Severity	Category	Rule	Message	Line
Error	javadoc	JavadocMethod	Expected @param tag for 'plugin'.	266

fr/paris/lutece/plugins/quicklinks/business/QuicklinksHome.java

Severity	Category	Rule	Message	Line
Error	design	FinalClass	Class QuicklinksHome should be declared as final.	46

fr/paris/lutece/plugins/quicklinks/business/QuicklinksType.java

Severity	Category	Rule	Message	Line
Error	modifier	RedundantModifier	Redundant 'private' modifier.	55
Error	javadoc	JavadocMethod	Expected @param tag for 'strI18nKey'.	55

fr/paris/lutece/plugins/quicklinks/business/insertservice/InternalLinkInsertService.java

Severity	Category	Rule	Message	Line
Error	header	Header	Line does not match expected header line of ' * Copyright (c) 2002-2020, City of Paris'.	2

fr/paris/lutece/plugins/quicklinks/business/insertservice/InternalLinkInsertServiceDAO.java

Severity	Category	Rule	Message	Line
Error	header	Header	Line does not match expected header line of ' * Copyright (c) 2002-2020, City of Paris'.	2
Error	design	FinalClass	Class InternalLinkInsertServiceDAO should be declared as final.	45

fr/paris/lutece/plugins/quicklinks/business/insertservice/InternalLinkInsertServiceHome.java

Severity	Category	Rule	Message	Line
Error	header	Header	Line does not match expected header line of ' * Copyright (c) 2002-2020, City of Paris'.	2
Error	design	FinalClass	Class InternalLinkInsertServiceHome should be declared as final.	42

fr/paris/lutece/plugins/quicklinks/service/QuicklinksService.java

Severity	Category	Rule	Message	Line
Error	javadoc	JavadocType	Missing a Javadoc comment.	38

fr/paris/lutece/plugins/quicklinks/web/InternalLinkInsertServiceJspBean.java

Severity	Category	Rule	Message	Line
Error	header	Header	Line does not match expected header line of ' * Copyright (c) 2002-2020, City of Paris'.	2
Error	javadoc	JavadocMethod	Missing a Javadoc comment.	231
Error	javadoc	JavadocMethod	Missing a Javadoc comment.	239

fr/paris/lutece/plugins/quicklinks/web/QuicklinksEntrySelectJspBean.java

Severity	Category	Rule	Message	Line
Error	coding	DeclarationOrder	Variable access definition in wrong order.	72
Error	javadoc	JavadocMethod	Expected @throws tag for 'AccessDeniedException'.	125

fr/paris/lutece/plugins/quicklinks/web/QuicklinksJspBean.java

Severity	Category	Rule	Message	Line
Error	coding	DeclarationOrder	Variable access definition in wrong order.	88
Error	coding	ArrayTrailingComma	Array should contain trailing comma.	219
Error	coding	ArrayTrailingComma	Array should contain trailing comma.	453
Error	coding	ArrayTrailingComma	Array should contain trailing comma.	499
Error	coding	ArrayTrailingComma	Array should contain trailing comma.	528
Error	coding	ArrayTrailingComma	Array should contain trailing comma.	1054

fr/paris/lutece/plugins/quicklinks/web/portlet/QuicklinksPortletJspBean.java

Severity	Category	Rule	Message	Line
Error	coding	DeclarationOrder	Variable access definition in wrong order.	70