FindBugs Bug Detector Report
The following document contains the results of FindBugs
FindBugs Version is 3.0.1
Threshold is
Effort is max
Summary
| Classes |
Bugs |
Errors |
Missing Classes |
| 54 |
26 |
0 |
0 |
fr.paris.lutece.plugins.rss.business.RssFeed
| Bug |
Category |
Details |
Line |
Priority |
| fr.paris.lutece.plugins.rss.business.RssFeed.getLastFetchDate() may expose internal representation by returning RssFeed._dateLastFetch |
MALICIOUS_CODE |
EI_EXPOSE_REP |
125 |
Medium |
| fr.paris.lutece.plugins.rss.business.RssFeed.setLastFetchDate(Timestamp) may expose internal representation by storing an externally mutable object into RssFeed._dateLastFetch |
MALICIOUS_CODE |
EI_EXPOSE_REP2 |
135 |
Medium |
fr.paris.lutece.plugins.rss.business.RssGeneratedFile
| Bug |
Category |
Details |
Line |
Priority |
| fr.paris.lutece.plugins.rss.business.RssGeneratedFile.getUpdateDate() may expose internal representation by returning RssGeneratedFile._dateUpdate |
MALICIOUS_CODE |
EI_EXPOSE_REP |
191 |
Medium |
| fr.paris.lutece.plugins.rss.business.RssGeneratedFile.setUpdateDate(Timestamp) may expose internal representation by storing an externally mutable object into RssGeneratedFile._dateUpdate |
MALICIOUS_CODE |
EI_EXPOSE_REP2 |
200 |
Medium |
| Incorrect lazy initialization and update of static field fr.paris.lutece.plugins.rss.business.RssGeneratedFile._listenerWorkgroup in fr.paris.lutece.plugins.rss.business.RssGeneratedFile.init() |
MT_CORRECTNESS |
LI_LAZY_INIT_UPDATE_STATIC |
70-72 |
Medium |
fr.paris.lutece.plugins.rss.service.AutoUpdatingRss
| Bug |
Category |
Details |
Line |
Priority |
| Exceptional return value of java.io.File.delete() ignored in fr.paris.lutece.plugins.rss.service.AutoUpdatingRss.processUpdatingRssFileFile(Plugin) |
BAD_PRACTICE |
RV_RETURN_VALUE_IGNORED_BAD_PRACTICE |
109 |
Medium |
| Exceptional return value of java.io.File.mkdir() ignored in fr.paris.lutece.plugins.rss.service.AutoUpdatingRss.processUpdatingRssFileFile(Plugin) |
BAD_PRACTICE |
RV_RETURN_VALUE_IGNORED_BAD_PRACTICE |
94 |
Medium |
fr.paris.lutece.plugins.rss.service.RssContentLoader
| Bug |
Category |
Details |
Line |
Priority |
| Found reliance on default encoding in fr.paris.lutece.plugins.rss.service.RssContentLoader.getFromCacheFile(String): new java.io.FileReader(File) |
I18N |
DM_DEFAULT_ENCODING |
170 |
High |
| Found reliance on default encoding in fr.paris.lutece.plugins.rss.service.RssContentLoader.saveInCacheFile(int, String): String.getBytes() |
I18N |
DM_DEFAULT_ENCODING |
228 |
High |
| fr.paris.lutece.plugins.rss.service.RssContentLoader.saveInCacheFile(int, String) may fail to clean up java.io.OutputStream on checked exception |
EXPERIMENTAL |
OBL_UNSATISFIED_OBLIGATION_EXCEPTION_EDGE |
226 |
Medium |
| Exceptional return value of java.io.File.delete() ignored in fr.paris.lutece.plugins.rss.service.RssContentLoader.saveInCacheFile(int, String) |
BAD_PRACTICE |
RV_RETURN_VALUE_IGNORED_BAD_PRACTICE |
223 |
Medium |
fr.paris.lutece.plugins.rss.service.RssGeneratorService
| Bug |
Category |
Details |
Line |
Priority |
| Found reliance on default encoding in fr.paris.lutece.plugins.rss.service.RssGeneratorService.createFileRss(String, String): new java.io.FileWriter(File) |
I18N |
DM_DEFAULT_ENCODING |
259 |
High |
| fr.paris.lutece.plugins.rss.service.RssGeneratorService.createFileRss(String, String) may fail to clean up java.io.Writer on checked exception |
EXPERIMENTAL |
OBL_UNSATISFIED_OBLIGATION_EXCEPTION_EDGE |
259 |
Medium |
| Exceptional return value of java.io.File.delete() ignored in fr.paris.lutece.plugins.rss.service.RssGeneratorService.createFileRss(String, String) |
BAD_PRACTICE |
RV_RETURN_VALUE_IGNORED_BAD_PRACTICE |
268 |
Medium |
| Exceptional return value of java.io.File.mkdir() ignored in fr.paris.lutece.plugins.rss.service.RssGeneratorService.createFileRss(String, String) |
BAD_PRACTICE |
RV_RETURN_VALUE_IGNORED_BAD_PRACTICE |
249 |
Medium |
| Exceptional return value of java.io.File.renameTo(File) ignored in fr.paris.lutece.plugins.rss.service.RssGeneratorService.createFileRss(String, String) |
BAD_PRACTICE |
RV_RETURN_VALUE_IGNORED_BAD_PRACTICE |
271 |
Medium |
| Exceptional return value of java.io.File.delete() ignored in fr.paris.lutece.plugins.rss.service.RssGeneratorService.deleteFileRss(String, String) |
BAD_PRACTICE |
RV_RETURN_VALUE_IGNORED_BAD_PRACTICE |
301 |
Medium |
fr.paris.lutece.plugins.rss.web.FeedUtil
| Bug |
Category |
Details |
Line |
Priority |
| Unchecked/unconfirmed cast from fr.paris.lutece.portal.business.rss.IResourceRss to fr.paris.lutece.plugins.rss.business.RssFeed in fr.paris.lutece.plugins.rss.web.FeedUtil.getFeed(IResourceRss) |
STYLE |
BC_UNCONFIRMED_CAST |
110 |
Medium |
fr.paris.lutece.plugins.rss.web.RssAdminDashboardComponent
| Bug |
Category |
Details |
Line |
Priority |
| Dead store to template in fr.paris.lutece.plugins.rss.web.RssAdminDashboardComponent.getDashboardData(AdminUser, HttpServletRequest) |
STYLE |
DLS_DEAD_LOCAL_STORE |
62 |
Medium |
fr.paris.lutece.plugins.rss.web.RssFeedInclude
| Bug |
Category |
Details |
Line |
Priority |
| Useless object stored in variable model of method fr.paris.lutece.plugins.rss.web.RssFeedInclude.fillTemplate(Map, PageData, int, HttpServletRequest) |
STYLE |
UC_USELESS_OBJECT |
115 |
Medium |
fr.paris.lutece.plugins.rss.web.RssJspBean
| Bug |
Category |
Details |
Line |
Priority |
| fr.paris.lutece.plugins.rss.web.RssJspBean.getJspCreateRssResource(HttpServletRequest, String, String, String, String, Map) invokes inefficient new String() constructor |
PERFORMANCE |
DM_STRING_VOID_CTOR |
947 |
Medium |
| fr.paris.lutece.plugins.rss.web.RssJspBean.getJspModifyRssResource(HttpServletRequest, String, String, String, String, String, Map) invokes inefficient new String() constructor |
PERFORMANCE |
DM_STRING_VOID_CTOR |
967 |
Medium |
| fr.paris.lutece.plugins.rss.web.RssJspBean.getJspCreateRssResource(HttpServletRequest, String, String, String, String, Map) concatenates strings using + in a loop |
PERFORMANCE |
SBSC_USE_STRINGBUFFER_CONCATENATION |
951 |
Medium |
| fr.paris.lutece.plugins.rss.web.RssJspBean.getJspModifyRssResource(HttpServletRequest, String, String, String, String, String, Map) concatenates strings using + in a loop |
PERFORMANCE |
SBSC_USE_STRINGBUFFER_CONCATENATION |
971 |
Medium |
| fr.paris.lutece.plugins.rss.web.RssJspBean.getJspCreateRssResource(HttpServletRequest, String, String, String, String, Map) makes inefficient use of keySet iterator instead of entrySet iterator |
PERFORMANCE |
WMI_WRONG_MAP_ITERATOR |
951 |
Medium |
| fr.paris.lutece.plugins.rss.web.RssJspBean.getJspModifyRssResource(HttpServletRequest, String, String, String, String, String, Map) makes inefficient use of keySet iterator instead of entrySet iterator |
PERFORMANCE |
WMI_WRONG_MAP_ITERATOR |
971 |
Medium |
