The following document contains the results of PMD 6.13.0.
| Rule | Violation | Line |
|---|---|---|
| ClassNamingConventions | The utility class name 'AutoUpdatingRss' doesn't match '[A-Z][a-zA-Z0-9]+(Utils?|Helper|Home|Service)' | 55–161 |
| Rule | Violation | Line |
|---|---|---|
| ClassWithOnlyPrivateConstructorsShouldBeFinal | A class which only has private constructors should be final | 46–97 |
| Rule | Violation | Line |
|---|---|---|
| AvoidFileStream | Avoid instantiating FileInputStream, FileOutputStream, FileReader, or FileWriter | 170 |
| AvoidFileStream | Avoid instantiating FileInputStream, FileOutputStream, FileReader, or FileWriter | 226 |
| Rule | Violation | Line |
|---|---|---|
| AvoidFileStream | Avoid instantiating FileInputStream, FileOutputStream, FileReader, or FileWriter | 259 |
| Rule | Violation | Line |
|---|---|---|
| AbstractClassWithoutAnyMethod | No abstract method which means that the keyword is most likely used to prevent instantiation. Use a private or protected constructor instead. | 42–45 |
| Rule | Violation | Line |
|---|---|---|
| LocalVariableNamingConventions | The local variable name 'paginator_active' doesn't match '[a-z][a-zA-Z0-9]*' | 181 |
| LocalVariableNamingConventions | The local variable name 'paginator_inactive' doesn't match '[a-z][a-zA-Z0-9]*' | 188 |
| Rule | Violation | Line |
|---|---|---|
| FormalParameterNamingConventions | The method parameter name 'rss_type' doesn't match '[a-z][a-zA-Z0-9]*' | 945 |
| FormalParameterNamingConventions | The method parameter name 'id_rss' doesn't match '[a-z][a-zA-Z0-9]*' | 964 |
| FormalParameterNamingConventions | The method parameter name 'rss_type' doesn't match '[a-z][a-zA-Z0-9]*' | 965 |
| Rule | Violation | Line |
|---|---|---|
| AvoidReassigningParameters | Avoid reassigning parameters such as 'rssFeed' | 102 |
| Rule | Violation | Line |
|---|---|---|
| StringInstantiation | Avoid instantiating String objects; this is usually unnecessary. | 947 |
| StringInstantiation | Avoid instantiating String objects; this is usually unnecessary. | 967 |
| Rule | Violation | Line |
|---|---|---|
| TooManyMethods | This class has too many methods, consider refactoring it. | 46–137 |
| Rule | Violation | Line |
|---|---|---|
| MissingOverride | The method 'getWorkgroup()' is missing an @Override annotation. | 193–196 |
| Rule | Violation | Line |
|---|---|---|
| MissingOverride | The method 'newPrimaryKey(boolean)' is missing an @Override annotation. | 74–91 |
| MissingOverride | The method 'insert(RssFeed)' is missing an @Override annotation. | 97–114 |
| MissingOverride | The method 'load(int, boolean)' is missing an @Override annotation. | 122–147 |
| MissingOverride | The method 'delete(RssFeed)' is missing an @Override annotation. | 153–161 |
| MissingOverride | The method 'store(RssFeed)' is missing an @Override annotation. | 167–181 |
| MissingOverride | The method 'storeLastFetchInfos(RssFeed)' is missing an @Override annotation. | 187–199 |
| MissingOverride | The method 'selectRssFeeds(boolean)' is missing an @Override annotation. | 206–233 |
| MissingOverride | The method 'checkUrlNotUsed(String)' is missing an @Override annotation. | 240–257 |
| MissingOverride | The method 'selectRssFeedReferenceList(boolean)' is missing an @Override annotation. | 264–282 |
| Rule | Violation | Line |
|---|---|---|
| NPathComplexity | The method 'updateOrder(RssFeed, int)' has an NPath complexity of 480 | 184–253 |
| CyclomaticComplexity | The method 'updateOrder(RssFeed, int)' has a cyclomatic complexity of 17. | 184–253 |
| AvoidUncheckedExceptionsInSignatures | A method or constructor should not explicitly declare unchecked exceptions in its 'throws' clause | 185 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 193 |
| UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 205 |
| LinguisticNaming | Linguistics Antipattern - The setter 'setActive' should not return any type except void linguistically | 261–267 |
| Rule | Violation | Line |
|---|---|---|
| NonThreadSafeSingleton | Singleton is not thread safe | 70–74 |
| MissingOverride | The method 'getWorkgroup()' is missing an @Override annotation. | 207–210 |
| Rule | Violation | Line |
|---|---|---|
| TooManyMethods | This class has too many methods, consider refactoring it. | 51–462 |
| MissingOverride | The method 'insert(RssGeneratedFile)' is missing an @Override annotation. | 116–136 |
| MissingOverride | The method 'delete(int)' is missing an @Override annotation. | 142–149 |
| MissingOverride | The method 'store(RssGeneratedFile)' is missing an @Override annotation. | 155–173 |
| MissingOverride | The method 'updateState(RssGeneratedFile)' is missing an @Override annotation. | 179–189 |
| MissingOverride | The method 'load(int)' is missing an @Override annotation. | 196–224 |
| MissingOverride | The method 'checkExistPushrssByPortlet(int)' is missing an @Override annotation. | 231–248 |
| MissingOverride | The method 'checkRssFileFileName(String)' is missing an @Override annotation. | 255–271 |
| MissingOverride | The method 'selectRssFileList()' is missing an @Override annotation. | 277–304 |
| MissingOverride | The method 'selectRssPortlets()' is missing an @Override annotation. | 310–329 |
| MissingOverride | The method 'selectAllRssPortlets()' is missing an @Override annotation. | 335–356 |
| MissingOverride | The method 'selectRssFilePortletName(int)' is missing an @Override annotation. | 363–379 |
| MissingOverride | The method 'checkRssFilePortlet(int)' is missing an @Override annotation. | 386–403 |
| MissingOverride | The method 'selectDocumentsByPortlet(int)' is missing an @Override annotation. | 411–435 |
| MissingOverride | The method 'selectXslFile(int)' is missing an @Override annotation. | 442–461 |
| Rule | Violation | Line |
|---|---|---|
| TooManyMethods | This class has too many methods, consider refactoring it. | 50–232 |
| Rule | Violation | Line |
|---|---|---|
| MissingOverride | The method 'canBeRemoved(String)' is missing an @Override annotation. | 55–73 |
| MissingOverride | The method 'getRemovalRefusedMessage(String, Locale)' is missing an @Override annotation. | 81–85 |
| Rule | Violation | Line |
|---|---|---|
| MissingOverride | The method 'load(String, Plugin)' is missing an @Override annotation. | 57–74 |
| MissingOverride | The method 'store(ReferenceItem, Plugin)' is missing an @Override annotation. | 79–88 |
| MissingOverride | The method 'selectAll(Plugin)' is missing an @Override annotation. | 93–111 |
| Rule | Violation | Line |
|---|---|---|
| UseUtilityClass | All methods are static. Consider using a utility class instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning. | 48–84 |
| Rule | Violation | Line |
|---|---|---|
| MissingOverride | The method 'delete(int)' is missing an @Override annotation. | 52 |
| MissingOverride | The method 'insert(Portlet)' is missing an @Override annotation. | 60 |
| MissingOverride | The method 'load(int)' is missing an @Override annotation. | 68 |
| MissingOverride | The method 'store(Portlet)' is missing an @Override annotation. | 76 |
| Rule | Violation | Line |
|---|---|---|
| MissingOverride | The method 'delete(int)' is missing an @Override annotation. | 54 |
| MissingOverride | The method 'insert(Portlet)' is missing an @Override annotation. | 62 |
| MissingOverride | The method 'load(int)' is missing an @Override annotation. | 70 |
| MissingOverride | The method 'store(Portlet)' is missing an @Override annotation. | 78 |
| Rule | Violation | Line |
|---|---|---|
| CallSuperInConstructor | It is a good practice to call super() in a constructor | 58–61 |
| MissingOverride | The method 'getXmlDocument(HttpServletRequest)' is missing an @Override annotation. | 69–72 |
| MissingOverride | The method 'getXml(HttpServletRequest)' is missing an @Override annotation. | 80–97 |
| MissingOverride | The method 'remove()' is missing an @Override annotation. | 110–113 |
| Rule | Violation | Line |
|---|---|---|
| MissingOverride | The method 'insert(Portlet)' is missing an @Override annotation. | 60–67 |
| ShortVariable | Avoid variables with short names like p | 62 |
| MissingOverride | The method 'delete(int)' is missing an @Override annotation. | 74–80 |
| MissingOverride | The method 'store(Portlet)' is missing an @Override annotation. | 87–96 |
| ShortVariable | Avoid variables with short names like p | 89 |
| MissingOverride | The method 'load(int)' is missing an @Override annotation. | 103–118 |
| Rule | Violation | Line |
|---|---|---|
| AssignmentToNonFinalStatic | Possible unsafe assignment to a non-final static field in a constructor. | 52 |
| CallSuperInConstructor | It is a good practice to call super() in a constructor | 57–63 |
| MissingOverride | The method 'getPortletTypeId()' is missing an @Override annotation. | 70–76 |
| UnnecessaryLocalBeforeReturn | Consider simply returning the value vs storing it in local variable 'strPortletTypeId' | 75 |
| NonThreadSafeSingleton | Singleton is not thread safe | 85–88 |
| MissingOverride | The method 'getDAO()' is missing an @Override annotation. | 98–101 |
| Rule | Violation | Line |
|---|---|---|
| CallSuperInConstructor | It is a good practice to call super() in a constructor | 56–59 |
| MissingOverride | The method 'getXmlDocument(HttpServletRequest)' is missing an @Override annotation. | 87–90 |
| MissingOverride | The method 'getXml(HttpServletRequest)' is missing an @Override annotation. | 98–116 |
| MissingOverride | The method 'remove()' is missing an @Override annotation. | 129–132 |
| Rule | Violation | Line |
|---|---|---|
| MissingOverride | The method 'insert(Portlet)' is missing an @Override annotation. | 64–72 |
| ShortVariable | Avoid variables with short names like p | 66 |
| MissingOverride | The method 'delete(int)' is missing an @Override annotation. | 79–85 |
| MissingOverride | The method 'store(Portlet)' is missing an @Override annotation. | 92–102 |
| ShortVariable | Avoid variables with short names like p | 94 |
| MissingOverride | The method 'load(int)' is missing an @Override annotation. | 109–125 |
| MissingOverride | The method 'checkLinkedPortlet(int)' is missing an @Override annotation. | 132–151 |
| UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 138 |
| Rule | Violation | Line |
|---|---|---|
| AssignmentToNonFinalStatic | Possible unsafe assignment to a non-final static field in a constructor. | 53 |
| CallSuperInConstructor | It is a good practice to call super() in a constructor | 58–64 |
| MissingOverride | The method 'getPortletTypeId()' is missing an @Override annotation. | 71–77 |
| UnnecessaryLocalBeforeReturn | Consider simply returning the value vs storing it in local variable 'strPortletTypeId' | 76 |
| NonThreadSafeSingleton | Singleton is not thread safe | 86–89 |
| MissingOverride | The method 'getDAO()' is missing an @Override annotation. | 99–102 |
| Rule | Violation | Line |
|---|---|---|
| PackageCase | Package name contains upper case characters | 34 |
| Rule | Violation | Line |
|---|---|---|
| PackageCase | Package name contains upper case characters | 34 |
| MissingOverride | The method 'getResourceRss(String)' is missing an @Override annotation. | 53–101 |
| IdenticalCatchBranches | 'catch' branch identical to 'ClassNotFoundException' branch | 87–92 |
| IdenticalCatchBranches | 'catch' branch identical to 'ClassNotFoundException' branch | 93–97 |
| MissingOverride | The method 'getAllResourceRssType()' is missing an @Override annotation. | 107–110 |
| Rule | Violation | Line |
|---|---|---|
| CyclomaticComplexity | The method 'processUpdatingRssFileFile(Plugin)' has a cyclomatic complexity of 11. | 73–160 |
| AvoidSynchronizedAtMethodLevel | Use block level rather than method level synchronization | 73–160 |
| UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 77 |
| UseCollectionIsEmpty | Substitute calls to size() == 0 (or size() != 0, size() > 0, size() < 1) with calls to isEmpty() | 103 |
| AvoidCatchingGenericException | Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 153 |
| Rule | Violation | Line |
|---|---|---|
| CommentRequired | Header comments are required | 46–97 |
| UnusedPrivateField | Avoid unused private fields such as 'PROPERTY_LOADERS'. | 51 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 86 |
| UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 86 |
| Rule | Violation | Line |
|---|---|---|
| MissingOverride | The method 'getResources()' is missing an @Override annotation. | 75–89 |
| ShortVariable | Avoid variables with short names like i | 79 |
| AddEmptyString | Do not add empty strings | 84 |
| MissingOverride | The method 'getResource(String)' is missing an @Override annotation. | 96–118 |
| AssignmentInOperand | Avoid assignments in operands | 174 |
| IdenticalCatchBranches | 'catch' branch identical to 'FileNotFoundException' branch | 185–188 |
| AddEmptyString | Do not add empty strings | 215 |
| ShortVariable | Avoid variables with short names like i | 245 |
| InefficientStringBuffering | Avoid concatenating nonliterals in a StringBuffer/StringBuilder constructor or append(). | 260 |
| Rule | Violation | Line |
|---|---|---|
| CallSuperInConstructor | It is a good practice to call super() in a constructor | 53–57 |
| Rule | Violation | Line |
|---|---|---|
| CommentRequired | Header comments are required | 43–58 |
| CommentRequired | Public method and constructor comments are required | 49–52 |
| CommentRequired | Public method and constructor comments are required | 54–57 |
| Rule | Violation | Line |
|---|---|---|
| UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 168 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 178 |
| UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 178 |
| AvoidCatchingNPE | Avoid catching NullPointerException; consider removing the cause of the NPE. | 277 |
| IdenticalCatchBranches | 'catch' branch identical to 'IOException' branch | 277–280 |
| AvoidCatchingGenericException | Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 277 |
| AvoidCatchingGenericException | Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 304 |
| AvoidCatchingNPE | Avoid catching NullPointerException; consider removing the cause of the NPE. | 304 |
| ShortVariable | Avoid variables with short names like sb | 316 |
| InsufficientStringBufferDeclaration | StringBuffer constructor is initialized with size 79, but has at least 86 characters appended. | 316 |
| Rule | Violation | Line |
|---|---|---|
| MissingSerialVersionUID | Classes implementing Serializable should set a serialVersionUID | 40–51 |
| ShortVariable | Avoid variables with short names like e | 47 |
| Rule | Violation | Line |
|---|---|---|
| MissingOverride | The method 'init()' is missing an @Override annotation. | 49–53 |
| Rule | Violation | Line |
|---|---|---|
| NonThreadSafeSingleton | Singleton is not thread safe | 78–81 |
| MissingOverride | The method 'getRssContent(int)' is missing an @Override annotation. | 91–105 |
| CommentRequired | Public method and constructor comments are required | 107–110 |
| MissingOverride | The method 'getRefListRssFeed()' is missing an @Override annotation. | 107–110 |
| CommentRequired | Public method and constructor comments are required | 112–115 |
| Rule | Violation | Line |
|---|---|---|
| MissingOverride | The method 'run()' is missing an @Override annotation. | 52–55 |
| Rule | Violation | Line |
|---|---|---|
| MissingOverride | The method 'run()' is missing an @Override annotation. | 53–58 |
| Rule | Violation | Line |
|---|---|---|
| MissingOverride | The method 'run()' is missing an @Override annotation. | 52–57 |
| Rule | Violation | Line |
|---|---|---|
| MissingOverride | The method 'getWireFeed(String, IFeedResource, String, int)' is missing an @Override annotation. | 72–84 |
| Rule | Violation | Line |
|---|---|---|
| MissingOverride | The method 'isInvoked(String)' is missing an @Override annotation. | 59–62 |
| MissingOverride | The method 'getATOMEntries(List, int)' is missing an @Override annotation. | 67–92 |
| UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 69 |
| MissingOverride | The method 'getATOMEntry(IFeedResourceItem)' is missing an @Override annotation. | 97–114 |
| Rule | Violation | Line |
|---|---|---|
| MissingOverride | The method 'getWireFeed(String, IFeedResource, String, int)' is missing an @Override annotation. | 73–97 |
| Rule | Violation | Line |
|---|---|---|
| MissingOverride | The method 'isInvoked(String)' is missing an @Override annotation. | 60–63 |
| MissingOverride | The method 'getRSSItems(List, int)' is missing an @Override annotation. | 68–93 |
| UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 70 |
| MissingOverride | The method 'getRSSItem(IFeedResourceItem)' is missing an @Override annotation. | 98–119 |
| Rule | Violation | Line |
|---|---|---|
| MissingOverride | The method 'isInvoked(String)' is missing an @Override annotation. | 62–65 |
| MissingOverride | The method 'getRSSItems(List, int)' is missing an @Override annotation. | 70–95 |
| UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 72 |
| MissingOverride | The method 'getRSSItem(IFeedResourceItem)' is missing an @Override annotation. | 100–130 |
| Rule | Violation | Line |
|---|---|---|
| CommentRequired | Header comments are required | 50–70 |
| Rule | Violation | Line |
|---|---|---|
| MissingOverride | The method 'fillTemplate(Map, PageData, int, HttpServletRequest)' is missing an @Override annotation. | 110–128 |
| UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 115 |
| UselessStringValueOf | No need to call String.valueOf to append to a string. | 124 |
| CommentRequired | Public method and constructor comments are required | 130–133 |
| UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 144 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 150–185 |
| AvoidCatchingGenericException | Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 177 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 206–213 |
| Rule | Violation | Line |
|---|---|---|
| ExcessiveImports | A high number of imports can indicate a high degree of coupling within an object. | 34–595 |
| MissingSerialVersionUID | Classes implementing Serializable should set a serialVersionUID | 81–595 |
| UnusedPrivateField | Avoid unused private fields such as 'MARK_RSS_INCLUDE_TAG'. | 123 |
| UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 166 |
| UselessStringValueOf | No need to call String.valueOf to append to a string. | 173 |
| AddEmptyString | Do not add empty strings | 193 |
| AddEmptyString | Do not add empty strings | 194 |
| UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 271 |
| UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 374 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 475–489 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 481–488 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 503–504 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 558 |
| Rule | Violation | Line |
|---|---|---|
| MissingOverride | The method 'fillTemplate(Map, PageData, int, HttpServletRequest)' is missing an @Override annotation. | 83–104 |
| UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 85 |
| UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 87 |
| Rule | Violation | Line |
|---|---|---|
| CyclomaticComplexity | The class 'RssJspBean' has a total cyclomatic complexity of 102 (highest 15). | 74–1181 |
| ExcessiveClassLength | Avoid really long classes. | 74–1181 |
| GodClass | Possible God Class (WMC=102, ATFD=241, TCC=18.615%) | 74–1181 |
| MissingSerialVersionUID | Classes implementing Serializable should set a serialVersionUID | 74–1181 |
| UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 171 |
| AddEmptyString | Do not add empty strings | 173 |
| NPathComplexity | The method 'doModifyRssFilePortlet(HttpServletRequest)' has an NPath complexity of 288 | 206–302 |
| CyclomaticComplexity | The method 'doModifyRssFilePortlet(HttpServletRequest)' has a cyclomatic complexity of 10. | 206–302 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 215 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 216 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 217 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 218 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 220 |
| NPathComplexity | The method 'doModifyRssFileResource(HttpServletRequest)' has an NPath complexity of 3072 | 310–440 |
| CyclomaticComplexity | The method 'doModifyRssFileResource(HttpServletRequest)' has a cyclomatic complexity of 14. | 310–440 |
| ExcessiveMethodLength | Avoid really long methods. | 310–440 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 321 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 323 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 324 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 325 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 326 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 327 |
| UseLocaleWithCaseConversions | When doing a String.toLowerCase()/toUpperCase() call, use a Locale | 352 |
| UseStringBufferForStringAppends | Prefer StringBuilder (non-synchronized) or StringBuffer (synchronized) over += for concatenating strings | 354 |
| NPathComplexity | The method 'doCreateRssFile(HttpServletRequest)' has an NPath complexity of 400 | 448–572 |
| CyclomaticComplexity | The method 'doCreateRssFile(HttpServletRequest)' has a cyclomatic complexity of 14. | 448–572 |
| ExcessiveMethodLength | Avoid really long methods. | 448–572 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 456 |
| UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 480 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 482–489 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 491–498 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 500–507 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 509–516 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 518–525 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 542–549 |
| CyclomaticComplexity | The method 'doCreateRssFilePortlet(HttpServletRequest)' has a cyclomatic complexity of 14. | 615–726 |
| ExcessiveMethodLength | Avoid really long methods. | 615–726 |
| NPathComplexity | The method 'doCreateRssFilePortlet(HttpServletRequest)' has an NPath complexity of 3456 | 615–726 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 623 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 624 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 625 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 626 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 627 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 628 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 635 |
| UseLocaleWithCaseConversions | When doing a String.toLowerCase()/toUpperCase() call, use a Locale | 658 |
| UseStringBufferForStringAppends | Prefer StringBuilder (non-synchronized) or StringBuffer (synchronized) over += for concatenating strings | 660 |
| UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 740 |
| UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 772 |
| CyclomaticComplexity | The method 'doCreateRssFileResource(HttpServletRequest)' has a cyclomatic complexity of 15. | 805–927 |
| ExcessiveMethodLength | Avoid really long methods. | 805–927 |
| NPathComplexity | The method 'doCreateRssFileResource(HttpServletRequest)' has an NPath complexity of 6144 | 805–927 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 812 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 813 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 814 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 815 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 816 |
| PositionLiteralsFirstInComparisons | Position literals first in String comparisons | 828 |
| UseLocaleWithCaseConversions | When doing a String.toLowerCase()/toUpperCase() call, use a Locale | 846 |
| UseStringBufferForStringAppends | Prefer StringBuilder (non-synchronized) or StringBuffer (synchronized) over += for concatenating strings | 848 |
| UseObjectForClearerAPI | Rather than using a lot of String arguments, consider using a container object for those values. | 944–945 |
| UseStringBufferForStringAppends | Prefer StringBuilder (non-synchronized) or StringBuffer (synchronized) over += for concatenating strings | 951 |
| UseObjectForClearerAPI | Rather than using a lot of String arguments, consider using a container object for those values. | 964–965 |
| UseStringBufferForStringAppends | Prefer StringBuilder (non-synchronized) or StringBuffer (synchronized) over += for concatenating strings | 971 |
| UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 994 |
| SimplifyStartsWith | This call to String.startsWith can be rewritten using String.charAt(0) | 1067 |
| UseStringBufferForStringAppends | Prefer StringBuilder (non-synchronized) or StringBuffer (synchronized) over += for concatenating strings | 1073 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 1135–1149 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 1141–1148 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 1162 |
| Rule | Violation | Line |
|---|---|---|
| MissingSerialVersionUID | Classes implementing Serializable should set a serialVersionUID | 56–88 |
| MissingOverride | The method 'getPage(HttpServletRequest, int, Plugin)' is missing an @Override annotation. | 66–87 |
| UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 72 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 72 |
| Rule | Violation | Line |
|---|---|---|
| MissingOverride | The method 'fillTemplate(Map, PageData, int, HttpServletRequest)' is missing an @Override annotation. | 73–82 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 75 |
| Rule | Violation | Line |
|---|---|---|
| UseStringBufferForStringAppends | Prefer StringBuilder (non-synchronized) or StringBuffer (synchronized) over += for concatenating strings | 82 |
| Rule | Violation | Line |
|---|---|---|
| MissingSerialVersionUID | Classes implementing Serializable should set a serialVersionUID | 49–181 |
| MissingOverride | The method 'getCreate(HttpServletRequest)' is missing an @Override annotation. | 80–87 |
| MissingOverride | The method 'getModify(HttpServletRequest)' is missing an @Override annotation. | 94–102 |
| MissingOverride | The method 'doCreate(HttpServletRequest)' is missing an @Override annotation. | 110–142 |
| MissingOverride | The method 'doModify(HttpServletRequest)' is missing an @Override annotation. | 150–180 |
| Rule | Violation | Line |
|---|---|---|
| MissingSerialVersionUID | Classes implementing Serializable should set a serialVersionUID | 56–243 |
| MissingOverride | The method 'getCreate(HttpServletRequest)' is missing an @Override annotation. | 96–106 |
| MissingOverride | The method 'getModify(HttpServletRequest)' is missing an @Override annotation. | 113–126 |
| MissingOverride | The method 'doCreate(HttpServletRequest)' is missing an @Override annotation. | 134–176 |
| MissingOverride | The method 'doModify(HttpServletRequest)' is missing an @Override annotation. | 184–225 |
| DefaultPackage | Use explicit scoping instead of the default package private level | 233–242 |
| CommentDefaultAccessModifier | To avoid mistakes add a comment at the beginning of the getFeedIndexCombo method if you want a default access modifier | 233–242 |
| UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 235 |
| Rule | Violation | Line |
|---|---|---|
| BooleanGetMethodName | A getX() method which returns a boolean should be named isX() | 247–250 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| TooManyMethods | This class has too many methods, consider refactoring it. | 3 | 46–137 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| MissingOverride | The method 'getWorkgroup()' is missing an @Override annotation. | 3 | 193–196 |
| BooleanGetMethodName | A getX() method which returns a boolean should be named isX() | 4 | 247–250 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| MissingOverride | The method 'newPrimaryKey(boolean)' is missing an @Override annotation. | 3 | 74–91 |
| MissingOverride | The method 'insert(RssFeed)' is missing an @Override annotation. | 3 | 97–114 |
| MissingOverride | The method 'load(int, boolean)' is missing an @Override annotation. | 3 | 122–147 |
| MissingOverride | The method 'delete(RssFeed)' is missing an @Override annotation. | 3 | 153–161 |
| MissingOverride | The method 'store(RssFeed)' is missing an @Override annotation. | 3 | 167–181 |
| MissingOverride | The method 'storeLastFetchInfos(RssFeed)' is missing an @Override annotation. | 3 | 187–199 |
| MissingOverride | The method 'selectRssFeeds(boolean)' is missing an @Override annotation. | 3 | 206–233 |
| MissingOverride | The method 'checkUrlNotUsed(String)' is missing an @Override annotation. | 3 | 240–257 |
| MissingOverride | The method 'selectRssFeedReferenceList(boolean)' is missing an @Override annotation. | 3 | 264–282 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| AvoidReassigningParameters | Avoid reassigning parameters such as 'rssFeed' | 2 | 102 |
| NPathComplexity | The method 'updateOrder(RssFeed, int)' has an NPath complexity of 480 | 3 | 184–253 |
| CyclomaticComplexity | The method 'updateOrder(RssFeed, int)' has a cyclomatic complexity of 17. | 3 | 184–253 |
| AvoidUncheckedExceptionsInSignatures | A method or constructor should not explicitly declare unchecked exceptions in its 'throws' clause | 3 | 185 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 193 |
| UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 3 | 205 |
| LinguisticNaming | Linguistics Antipattern - The setter 'setActive' should not return any type except void linguistically | 3 | 261–267 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| NonThreadSafeSingleton | Singleton is not thread safe | 3 | 70–74 |
| MissingOverride | The method 'getWorkgroup()' is missing an @Override annotation. | 3 | 207–210 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| TooManyMethods | This class has too many methods, consider refactoring it. | 3 | 51–462 |
| MissingOverride | The method 'insert(RssGeneratedFile)' is missing an @Override annotation. | 3 | 116–136 |
| MissingOverride | The method 'delete(int)' is missing an @Override annotation. | 3 | 142–149 |
| MissingOverride | The method 'store(RssGeneratedFile)' is missing an @Override annotation. | 3 | 155–173 |
| MissingOverride | The method 'updateState(RssGeneratedFile)' is missing an @Override annotation. | 3 | 179–189 |
| MissingOverride | The method 'load(int)' is missing an @Override annotation. | 3 | 196–224 |
| MissingOverride | The method 'checkExistPushrssByPortlet(int)' is missing an @Override annotation. | 3 | 231–248 |
| MissingOverride | The method 'checkRssFileFileName(String)' is missing an @Override annotation. | 3 | 255–271 |
| MissingOverride | The method 'selectRssFileList()' is missing an @Override annotation. | 3 | 277–304 |
| MissingOverride | The method 'selectRssPortlets()' is missing an @Override annotation. | 3 | 310–329 |
| MissingOverride | The method 'selectAllRssPortlets()' is missing an @Override annotation. | 3 | 335–356 |
| MissingOverride | The method 'selectRssFilePortletName(int)' is missing an @Override annotation. | 3 | 363–379 |
| MissingOverride | The method 'checkRssFilePortlet(int)' is missing an @Override annotation. | 3 | 386–403 |
| MissingOverride | The method 'selectDocumentsByPortlet(int)' is missing an @Override annotation. | 3 | 411–435 |
| MissingOverride | The method 'selectXslFile(int)' is missing an @Override annotation. | 3 | 442–461 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| TooManyMethods | This class has too many methods, consider refactoring it. | 3 | 50–232 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| MissingOverride | The method 'canBeRemoved(String)' is missing an @Override annotation. | 3 | 55–73 |
| MissingOverride | The method 'getRemovalRefusedMessage(String, Locale)' is missing an @Override annotation. | 3 | 81–85 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| MissingOverride | The method 'load(String, Plugin)' is missing an @Override annotation. | 3 | 57–74 |
| MissingOverride | The method 'store(ReferenceItem, Plugin)' is missing an @Override annotation. | 3 | 79–88 |
| MissingOverride | The method 'selectAll(Plugin)' is missing an @Override annotation. | 3 | 93–111 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UseUtilityClass | All methods are static. Consider using a utility class instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning. | 3 | 48–84 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| MissingOverride | The method 'delete(int)' is missing an @Override annotation. | 3 | 52 |
| MissingOverride | The method 'insert(Portlet)' is missing an @Override annotation. | 3 | 60 |
| MissingOverride | The method 'load(int)' is missing an @Override annotation. | 3 | 68 |
| MissingOverride | The method 'store(Portlet)' is missing an @Override annotation. | 3 | 76 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| MissingOverride | The method 'delete(int)' is missing an @Override annotation. | 3 | 54 |
| MissingOverride | The method 'insert(Portlet)' is missing an @Override annotation. | 3 | 62 |
| MissingOverride | The method 'load(int)' is missing an @Override annotation. | 3 | 70 |
| MissingOverride | The method 'store(Portlet)' is missing an @Override annotation. | 3 | 78 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| CallSuperInConstructor | It is a good practice to call super() in a constructor | 3 | 58–61 |
| MissingOverride | The method 'getXmlDocument(HttpServletRequest)' is missing an @Override annotation. | 3 | 69–72 |
| MissingOverride | The method 'getXml(HttpServletRequest)' is missing an @Override annotation. | 3 | 80–97 |
| MissingOverride | The method 'remove()' is missing an @Override annotation. | 3 | 110–113 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| MissingOverride | The method 'insert(Portlet)' is missing an @Override annotation. | 3 | 60–67 |
| ShortVariable | Avoid variables with short names like p | 3 | 62 |
| MissingOverride | The method 'delete(int)' is missing an @Override annotation. | 3 | 74–80 |
| MissingOverride | The method 'store(Portlet)' is missing an @Override annotation. | 3 | 87–96 |
| ShortVariable | Avoid variables with short names like p | 3 | 89 |
| MissingOverride | The method 'load(int)' is missing an @Override annotation. | 3 | 103–118 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| AssignmentToNonFinalStatic | Possible unsafe assignment to a non-final static field in a constructor. | 3 | 52 |
| CallSuperInConstructor | It is a good practice to call super() in a constructor | 3 | 57–63 |
| MissingOverride | The method 'getPortletTypeId()' is missing an @Override annotation. | 3 | 70–76 |
| UnnecessaryLocalBeforeReturn | Consider simply returning the value vs storing it in local variable 'strPortletTypeId' | 3 | 75 |
| NonThreadSafeSingleton | Singleton is not thread safe | 3 | 85–88 |
| MissingOverride | The method 'getDAO()' is missing an @Override annotation. | 3 | 98–101 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| CallSuperInConstructor | It is a good practice to call super() in a constructor | 3 | 56–59 |
| MissingOverride | The method 'getXmlDocument(HttpServletRequest)' is missing an @Override annotation. | 3 | 87–90 |
| MissingOverride | The method 'getXml(HttpServletRequest)' is missing an @Override annotation. | 3 | 98–116 |
| MissingOverride | The method 'remove()' is missing an @Override annotation. | 3 | 129–132 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| MissingOverride | The method 'insert(Portlet)' is missing an @Override annotation. | 3 | 64–72 |
| ShortVariable | Avoid variables with short names like p | 3 | 66 |
| MissingOverride | The method 'delete(int)' is missing an @Override annotation. | 3 | 79–85 |
| MissingOverride | The method 'store(Portlet)' is missing an @Override annotation. | 3 | 92–102 |
| ShortVariable | Avoid variables with short names like p | 3 | 94 |
| MissingOverride | The method 'load(int)' is missing an @Override annotation. | 3 | 109–125 |
| MissingOverride | The method 'checkLinkedPortlet(int)' is missing an @Override annotation. | 3 | 132–151 |
| UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 3 | 138 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| AssignmentToNonFinalStatic | Possible unsafe assignment to a non-final static field in a constructor. | 3 | 53 |
| CallSuperInConstructor | It is a good practice to call super() in a constructor | 3 | 58–64 |
| MissingOverride | The method 'getPortletTypeId()' is missing an @Override annotation. | 3 | 71–77 |
| UnnecessaryLocalBeforeReturn | Consider simply returning the value vs storing it in local variable 'strPortletTypeId' | 3 | 76 |
| NonThreadSafeSingleton | Singleton is not thread safe | 3 | 86–89 |
| MissingOverride | The method 'getDAO()' is missing an @Override annotation. | 3 | 99–102 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| PackageCase | Package name contains upper case characters | 3 | 34 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| PackageCase | Package name contains upper case characters | 3 | 34 |
| MissingOverride | The method 'getResourceRss(String)' is missing an @Override annotation. | 3 | 53–101 |
| IdenticalCatchBranches | 'catch' branch identical to 'ClassNotFoundException' branch | 3 | 87–92 |
| IdenticalCatchBranches | 'catch' branch identical to 'ClassNotFoundException' branch | 3 | 93–97 |
| MissingOverride | The method 'getAllResourceRssType()' is missing an @Override annotation. | 3 | 107–110 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| ClassNamingConventions | The utility class name 'AutoUpdatingRss' doesn't match '[A-Z][a-zA-Z0-9]+(Utils?|Helper|Home|Service)' | 1 | 55–161 |
| CyclomaticComplexity | The method 'processUpdatingRssFileFile(Plugin)' has a cyclomatic complexity of 11. | 3 | 73–160 |
| AvoidSynchronizedAtMethodLevel | Use block level rather than method level synchronization | 3 | 73–160 |
| UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 3 | 77 |
| UseCollectionIsEmpty | Substitute calls to size() == 0 (or size() != 0, size() > 0, size() < 1) with calls to isEmpty() | 3 | 103 |
| AvoidCatchingGenericException | Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 3 | 153 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| CommentRequired | Header comments are required | 3 | 46–97 |
| ClassWithOnlyPrivateConstructorsShouldBeFinal | A class which only has private constructors should be final | 1 | 46–97 |
| UnusedPrivateField | Avoid unused private fields such as 'PROPERTY_LOADERS'. | 3 | 51 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 3 | 86 |
| UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 3 | 86 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| MissingOverride | The method 'getResources()' is missing an @Override annotation. | 3 | 75–89 |
| ShortVariable | Avoid variables with short names like i | 3 | 79 |
| AddEmptyString | Do not add empty strings | 3 | 84 |
| MissingOverride | The method 'getResource(String)' is missing an @Override annotation. | 3 | 96–118 |
| AvoidFileStream | Avoid instantiating FileInputStream, FileOutputStream, FileReader, or FileWriter | 1 | 170 |
| AssignmentInOperand | Avoid assignments in operands | 3 | 174 |
| IdenticalCatchBranches | 'catch' branch identical to 'FileNotFoundException' branch | 3 | 185–188 |
| AddEmptyString | Do not add empty strings | 3 | 215 |
| AvoidFileStream | Avoid instantiating FileInputStream, FileOutputStream, FileReader, or FileWriter | 1 | 226 |
| ShortVariable | Avoid variables with short names like i | 3 | 245 |
| InefficientStringBuffering | Avoid concatenating nonliterals in a StringBuffer/StringBuilder constructor or append(). | 3 | 260 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| CallSuperInConstructor | It is a good practice to call super() in a constructor | 3 | 53–57 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| CommentRequired | Header comments are required | 3 | 43–58 |
| CommentRequired | Public method and constructor comments are required | 3 | 49–52 |
| CommentRequired | Public method and constructor comments are required | 3 | 54–57 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 3 | 168 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 3 | 178 |
| UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 3 | 178 |
| AvoidFileStream | Avoid instantiating FileInputStream, FileOutputStream, FileReader, or FileWriter | 1 | 259 |
| AvoidCatchingNPE | Avoid catching NullPointerException; consider removing the cause of the NPE. | 3 | 277 |
| IdenticalCatchBranches | 'catch' branch identical to 'IOException' branch | 3 | 277–280 |
| AvoidCatchingGenericException | Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 3 | 277 |
| AvoidCatchingGenericException | Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 3 | 304 |
| AvoidCatchingNPE | Avoid catching NullPointerException; consider removing the cause of the NPE. | 3 | 304 |
| ShortVariable | Avoid variables with short names like sb | 3 | 316 |
| InsufficientStringBufferDeclaration | StringBuffer constructor is initialized with size 79, but has at least 86 characters appended. | 3 | 316 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| MissingSerialVersionUID | Classes implementing Serializable should set a serialVersionUID | 3 | 40–51 |
| ShortVariable | Avoid variables with short names like e | 3 | 47 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| MissingOverride | The method 'init()' is missing an @Override annotation. | 3 | 49–53 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| NonThreadSafeSingleton | Singleton is not thread safe | 3 | 78–81 |
| MissingOverride | The method 'getRssContent(int)' is missing an @Override annotation. | 3 | 91–105 |
| CommentRequired | Public method and constructor comments are required | 3 | 107–110 |
| MissingOverride | The method 'getRefListRssFeed()' is missing an @Override annotation. | 3 | 107–110 |
| CommentRequired | Public method and constructor comments are required | 3 | 112–115 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| MissingOverride | The method 'run()' is missing an @Override annotation. | 3 | 52–55 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| MissingOverride | The method 'run()' is missing an @Override annotation. | 3 | 53–58 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| MissingOverride | The method 'run()' is missing an @Override annotation. | 3 | 52–57 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| AbstractClassWithoutAnyMethod | No abstract method which means that the keyword is most likely used to prevent instantiation. Use a private or protected constructor instead. | 1 | 42–45 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| MissingOverride | The method 'getWireFeed(String, IFeedResource, String, int)' is missing an @Override annotation. | 3 | 72–84 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| MissingOverride | The method 'isInvoked(String)' is missing an @Override annotation. | 3 | 59–62 |
| MissingOverride | The method 'getATOMEntries(List, int)' is missing an @Override annotation. | 3 | 67–92 |
| UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 3 | 69 |
| MissingOverride | The method 'getATOMEntry(IFeedResourceItem)' is missing an @Override annotation. | 3 | 97–114 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| MissingOverride | The method 'getWireFeed(String, IFeedResource, String, int)' is missing an @Override annotation. | 3 | 73–97 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| MissingOverride | The method 'isInvoked(String)' is missing an @Override annotation. | 3 | 60–63 |
| MissingOverride | The method 'getRSSItems(List, int)' is missing an @Override annotation. | 3 | 68–93 |
| UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 3 | 70 |
| MissingOverride | The method 'getRSSItem(IFeedResourceItem)' is missing an @Override annotation. | 3 | 98–119 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| MissingOverride | The method 'isInvoked(String)' is missing an @Override annotation. | 3 | 62–65 |
| MissingOverride | The method 'getRSSItems(List, int)' is missing an @Override annotation. | 3 | 70–95 |
| UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 3 | 72 |
| MissingOverride | The method 'getRSSItem(IFeedResourceItem)' is missing an @Override annotation. | 3 | 100–130 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| CommentRequired | Header comments are required | 3 | 50–70 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| MissingOverride | The method 'fillTemplate(Map, PageData, int, HttpServletRequest)' is missing an @Override annotation. | 3 | 110–128 |
| UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 3 | 115 |
| UselessStringValueOf | No need to call String.valueOf to append to a string. | 3 | 124 |
| CommentRequired | Public method and constructor comments are required | 3 | 130–133 |
| UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 3 | 144 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 3 | 150–185 |
| AvoidCatchingGenericException | Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 3 | 177 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 3 | 206–213 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| ExcessiveImports | A high number of imports can indicate a high degree of coupling within an object. | 3 | 34–595 |
| MissingSerialVersionUID | Classes implementing Serializable should set a serialVersionUID | 3 | 81–595 |
| UnusedPrivateField | Avoid unused private fields such as 'MARK_RSS_INCLUDE_TAG'. | 3 | 123 |
| UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 3 | 166 |
| UselessStringValueOf | No need to call String.valueOf to append to a string. | 3 | 173 |
| LocalVariableNamingConventions | The local variable name 'paginator_active' doesn't match '[a-z][a-zA-Z0-9]*' | 1 | 181 |
| LocalVariableNamingConventions | The local variable name 'paginator_inactive' doesn't match '[a-z][a-zA-Z0-9]*' | 1 | 188 |
| AddEmptyString | Do not add empty strings | 3 | 193 |
| AddEmptyString | Do not add empty strings | 3 | 194 |
| UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 3 | 271 |
| UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 3 | 374 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 3 | 475–489 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 3 | 481–488 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 3 | 503–504 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 3 | 558 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| MissingOverride | The method 'fillTemplate(Map, PageData, int, HttpServletRequest)' is missing an @Override annotation. | 3 | 83–104 |
| UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 3 | 85 |
| UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 3 | 87 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| CyclomaticComplexity | The class 'RssJspBean' has a total cyclomatic complexity of 102 (highest 15). | 3 | 74–1181 |
| ExcessiveClassLength | Avoid really long classes. | 3 | 74–1181 |
| GodClass | Possible God Class (WMC=102, ATFD=241, TCC=18.615%) | 3 | 74–1181 |
| MissingSerialVersionUID | Classes implementing Serializable should set a serialVersionUID | 3 | 74–1181 |
| UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 3 | 171 |
| AddEmptyString | Do not add empty strings | 3 | 173 |
| NPathComplexity | The method 'doModifyRssFilePortlet(HttpServletRequest)' has an NPath complexity of 288 | 3 | 206–302 |
| CyclomaticComplexity | The method 'doModifyRssFilePortlet(HttpServletRequest)' has a cyclomatic complexity of 10. | 3 | 206–302 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 215 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 216 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 217 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 218 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 220 |
| NPathComplexity | The method 'doModifyRssFileResource(HttpServletRequest)' has an NPath complexity of 3072 | 3 | 310–440 |
| CyclomaticComplexity | The method 'doModifyRssFileResource(HttpServletRequest)' has a cyclomatic complexity of 14. | 3 | 310–440 |
| ExcessiveMethodLength | Avoid really long methods. | 3 | 310–440 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 321 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 323 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 324 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 325 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 326 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 327 |
| UseLocaleWithCaseConversions | When doing a String.toLowerCase()/toUpperCase() call, use a Locale | 3 | 352 |
| UseStringBufferForStringAppends | Prefer StringBuilder (non-synchronized) or StringBuffer (synchronized) over += for concatenating strings | 3 | 354 |
| NPathComplexity | The method 'doCreateRssFile(HttpServletRequest)' has an NPath complexity of 400 | 3 | 448–572 |
| CyclomaticComplexity | The method 'doCreateRssFile(HttpServletRequest)' has a cyclomatic complexity of 14. | 3 | 448–572 |
| ExcessiveMethodLength | Avoid really long methods. | 3 | 448–572 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 456 |
| UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 3 | 480 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 3 | 482–489 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 3 | 491–498 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 3 | 500–507 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 3 | 509–516 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 3 | 518–525 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 3 | 542–549 |
| CyclomaticComplexity | The method 'doCreateRssFilePortlet(HttpServletRequest)' has a cyclomatic complexity of 14. | 3 | 615–726 |
| ExcessiveMethodLength | Avoid really long methods. | 3 | 615–726 |
| NPathComplexity | The method 'doCreateRssFilePortlet(HttpServletRequest)' has an NPath complexity of 3456 | 3 | 615–726 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 623 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 624 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 625 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 626 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 627 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 628 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 635 |
| UseLocaleWithCaseConversions | When doing a String.toLowerCase()/toUpperCase() call, use a Locale | 3 | 658 |
| UseStringBufferForStringAppends | Prefer StringBuilder (non-synchronized) or StringBuffer (synchronized) over += for concatenating strings | 3 | 660 |
| UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 3 | 740 |
| UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 3 | 772 |
| CyclomaticComplexity | The method 'doCreateRssFileResource(HttpServletRequest)' has a cyclomatic complexity of 15. | 3 | 805–927 |
| ExcessiveMethodLength | Avoid really long methods. | 3 | 805–927 |
| NPathComplexity | The method 'doCreateRssFileResource(HttpServletRequest)' has an NPath complexity of 6144 | 3 | 805–927 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 812 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 813 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 814 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 815 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 816 |
| PositionLiteralsFirstInComparisons | Position literals first in String comparisons | 3 | 828 |
| UseLocaleWithCaseConversions | When doing a String.toLowerCase()/toUpperCase() call, use a Locale | 3 | 846 |
| UseStringBufferForStringAppends | Prefer StringBuilder (non-synchronized) or StringBuffer (synchronized) over += for concatenating strings | 3 | 848 |
| UseObjectForClearerAPI | Rather than using a lot of String arguments, consider using a container object for those values. | 3 | 944–945 |
| FormalParameterNamingConventions | The method parameter name 'rss_type' doesn't match '[a-z][a-zA-Z0-9]*' | 1 | 945 |
| StringInstantiation | Avoid instantiating String objects; this is usually unnecessary. | 2 | 947 |
| UseStringBufferForStringAppends | Prefer StringBuilder (non-synchronized) or StringBuffer (synchronized) over += for concatenating strings | 3 | 951 |
| FormalParameterNamingConventions | The method parameter name 'id_rss' doesn't match '[a-z][a-zA-Z0-9]*' | 1 | 964 |
| UseObjectForClearerAPI | Rather than using a lot of String arguments, consider using a container object for those values. | 3 | 964–965 |
| FormalParameterNamingConventions | The method parameter name 'rss_type' doesn't match '[a-z][a-zA-Z0-9]*' | 1 | 965 |
| StringInstantiation | Avoid instantiating String objects; this is usually unnecessary. | 2 | 967 |
| UseStringBufferForStringAppends | Prefer StringBuilder (non-synchronized) or StringBuffer (synchronized) over += for concatenating strings | 3 | 971 |
| UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 3 | 994 |
| SimplifyStartsWith | This call to String.startsWith can be rewritten using String.charAt(0) | 3 | 1067 |
| UseStringBufferForStringAppends | Prefer StringBuilder (non-synchronized) or StringBuffer (synchronized) over += for concatenating strings | 3 | 1073 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 3 | 1135–1149 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 3 | 1141–1148 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 3 | 1162 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| MissingSerialVersionUID | Classes implementing Serializable should set a serialVersionUID | 3 | 56–88 |
| MissingOverride | The method 'getPage(HttpServletRequest, int, Plugin)' is missing an @Override annotation. | 3 | 66–87 |
| UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 3 | 72 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 3 | 72 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| MissingOverride | The method 'fillTemplate(Map, PageData, int, HttpServletRequest)' is missing an @Override annotation. | 3 | 73–82 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 3 | 75 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UseStringBufferForStringAppends | Prefer StringBuilder (non-synchronized) or StringBuffer (synchronized) over += for concatenating strings | 3 | 82 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| MissingSerialVersionUID | Classes implementing Serializable should set a serialVersionUID | 3 | 49–181 |
| MissingOverride | The method 'getCreate(HttpServletRequest)' is missing an @Override annotation. | 3 | 80–87 |
| MissingOverride | The method 'getModify(HttpServletRequest)' is missing an @Override annotation. | 3 | 94–102 |
| MissingOverride | The method 'doCreate(HttpServletRequest)' is missing an @Override annotation. | 3 | 110–142 |
| MissingOverride | The method 'doModify(HttpServletRequest)' is missing an @Override annotation. | 3 | 150–180 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| MissingSerialVersionUID | Classes implementing Serializable should set a serialVersionUID | 3 | 56–243 |
| MissingOverride | The method 'getCreate(HttpServletRequest)' is missing an @Override annotation. | 3 | 96–106 |
| MissingOverride | The method 'getModify(HttpServletRequest)' is missing an @Override annotation. | 3 | 113–126 |
| MissingOverride | The method 'doCreate(HttpServletRequest)' is missing an @Override annotation. | 3 | 134–176 |
| MissingOverride | The method 'doModify(HttpServletRequest)' is missing an @Override annotation. | 3 | 184–225 |
| DefaultPackage | Use explicit scoping instead of the default package private level | 3 | 233–242 |
| CommentDefaultAccessModifier | To avoid mistakes add a comment at the beginning of the getFeedIndexCombo method if you want a default access modifier | 3 | 233–242 |
| UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 3 | 235 |
